[kamailio/kamailio] [pua] reginfo_increase_version does nothing (Issue #3234)
<!-- Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports. If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list: * http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list: * http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue. If there is no content to be filled in a section, the entire section can be removed. You can delete the comments from the template sections when filling. You can delete next line and everything above before submitting (it is a comment). --> ### Description The reginfo notifications sent via pua_reginfo + presence_reginfo contains the version fixed to `0`. The pua docs report the param `reginfo_increase_version` which should increase the version if enabled, but currently does nothing. Looking into the code seems to confirm that, param is read from `pua` module but is not used anywhere. While the param `dlginfo_increase_version` seems to be used for the intended scope. #### Reproduction Setup pua + pua_reginfo to publish registration informations and observe that version param of reginfo is always 0, not respecting pua `reginfo_increase_version` setting. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.6.1 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 9.4.0 ``` * **Operating System**: ``` Linux Debian bullseye/sid ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3234@github.com>
You are right, there seems to be some implementation code missing. You could create a PR with the implementation (maybe get some inspiration from the existing dlginfo_increase_version). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1254749696 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3234/1254749696@github.com>
This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1801301932 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3234/1801301932@github.com>
Will have a look, its probably not a large extension. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1820375934 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3234/1820375934@github.com>
@xkaraman -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1866055685 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3234/1866055685@github.com>
Hey @xadhoom, A commit has been made in 4c93985 that probably fixes this, can you maybe help and confirm it works? Thanks -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1866586959 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3234/1866586959@github.com>
Sure, I'll be able to test it in the very beginning of the new year, will keep you posted. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1866982085 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3234/1866982085@github.com>
This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1922685515 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3234/1922685515@github.com>
Sorry for the late reply, but seems good to me! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1936214221 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3234/1936214221@github.com>
Thanks for the feedback, close it then. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1936227046 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3234/1936227046@github.com>
Closed #3234 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#event-11760099761 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issue/3234/issue_event/11760099761@github.com>
participants (4)
-
github-actions[bot] -
Henning Westerholt -
Matteo -
Xenofon Karamanos