Module: kamailio Branch: 5.6 Commit: 2b1a5ffb75566fb9411b23be23b263986b3eafaa URL: https://github.com/kamailio/kamailio/commit/2b1a5ffb75566fb9411b23be23b26398...
Author: Daniel-Constantin Mierla miconda@gmail.com Committer: Daniel-Constantin Mierla miconda@gmail.com Date: 2022-09-15T10:28:03+02:00
dmq: docs - note about using same Kamailio version
(cherry picked from commit 1fd789246cc7c58237b9a903a198521cd5b3494d)
---
Modified: src/modules/dmq/doc/dmq_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/2b1a5ffb75566fb9411b23be23b26398... Patch: https://github.com/kamailio/kamailio/commit/2b1a5ffb75566fb9411b23be23b26398...
---
diff --git a/src/modules/dmq/doc/dmq_admin.xml b/src/modules/dmq/doc/dmq_admin.xml index 661fd4b8471..7a2c933c62f 100644 --- a/src/modules/dmq/doc/dmq_admin.xml +++ b/src/modules/dmq/doc/dmq_admin.xml @@ -47,6 +47,11 @@ Nodes that are not responding to KDMQ reguests are removed the from local list of active nodes, no longer being considered to be part of the KDMQ cluster. </para> + <para> + IMPORTANT: DMQ must be used only between Kamailio instances having same + major version. Internal structures can be incompatible between different + major versions and can lead to crashes or unexpected behaviour. + </para> <example> <title>KDMQ Request Example</title> <para>
On 15 Sept 2022, at 10:28, Daniel-Constantin Mierla miconda@gmail.com wrote:
<para> + IMPORTANT: DMQ must be used only between Kamailio instances having same + major version. Internal structures can be incompatible between different + major versions and can lead to crashes or unexpected behaviour. + </para>
Would it be possible to include a check in the actual DMQ protocol?
Cheers, /O
On 15.09.22 10:42, Olle E. Johansson wrote:
On 15 Sept 2022, at 10:28, Daniel-Constantin Mierla miconda@gmail.com wrote:
<para> +IMPORTANT: DMQ must be used only between Kamailio instances having same +major version. Internal structures can be incompatible between different +major versions and can lead to crashes or unexpected behaviour. +</para>
Would it be possible to include a check in the actual DMQ protocol?
It's open source, someone just needs to write the C code.
Otherwise, right now, one could check in the config with the User-Agent header.
On the other hand, afaik, all the storage systems that do replication ensure compatibility only for the same version, and adding checks for each mirrored packet can add to the processing overhead and affect performances.
Cheers, Daniel
On 15 Sept 2022, at 10:58, Daniel-Constantin Mierla miconda@gmail.com wrote:
On 15.09.22 10:42, Olle E. Johansson wrote:
On 15 Sept 2022, at 10:28, Daniel-Constantin Mierla <miconda@gmail.com mailto:miconda@gmail.com> wrote:
<para> + IMPORTANT: DMQ must be used only between Kamailio instances having same + major version. Internal structures can be incompatible between different + major versions and can lead to crashes or unexpected behaviour. + </para>
Would it be possible to include a check in the actual DMQ protocol?
It's open source, someone just needs to write the C code.
Otherwise, right now, one could check in the config with the User-Agent header.
On the other hand, afaik, all the storage systems that do replication ensure compatibility only for the same version, and adding checks for each mirrored packet can add to the processing overhead and affect performances.
Agreed, adding mandatory CPU is not what we want. It could like many other things, be handled in the routing script.
Cheers, /O