git:master: snmpstats: control exporting registrar records
Module: sip-router Branch: master Commit: 0696af54dac4ecc53bb0a9dc4e56da11bc3f2b30 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0696af54... Author: Daniel-Constantin Mierla <miconda@gmail.com> Committer: Daniel-Constantin Mierla <miconda@gmail.com> Date: Sun Oct 16 11:33:16 2011 +0200 snmpstats: control exporting registrar records - exporting of large location database may result in out of shared memory, as well as when the records are not pulled - might be the case of out of memory messages reported by Klaus Darilion - new parameter export_registrar was added to enable/disable location records export (off by default) - fixed missing exporting the counter with all processed dialogs (discussion from March 2011 with Stefan Tiedje) --- modules_k/snmpstats/README | 31 ++++++++++++++++----- modules_k/snmpstats/doc/snmpstats_admin.xml | 25 +++++++++++++++++ modules_k/snmpstats/mibs/OPENSER-MIB | 13 ++++++++- modules_k/snmpstats/snmpObjects.c | 28 +++++++++++++++++++ modules_k/snmpstats/snmpObjects.h | 1 + modules_k/snmpstats/snmpstats.c | 40 +++++++++++++++++---------- 6 files changed, 115 insertions(+), 23 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=0696...
Hi Daniel! I think there is a minor copy-paste bug in snmpstats.c, the function is exported twice: 155 { "snmpCommunity", STR_PARAM|USE_FUNC_PARAM, 156 (void *)set_snmp_community }, 157 { "snmpCommunity", STR_PARAM|USE_FUNC_PARAM, 158 (void *)set_snmp_community }, regards Klaus On 16.10.2011 11:43, Daniel-Constantin Mierla wrote:
Module: sip-router Branch: master Commit: 0696af54dac4ecc53bb0a9dc4e56da11bc3f2b30 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0696af54...
Author: Daniel-Constantin Mierla<miconda@gmail.com> Committer: Daniel-Constantin Mierla<miconda@gmail.com> Date: Sun Oct 16 11:33:16 2011 +0200
snmpstats: control exporting registrar records
- exporting of large location database may result in out of shared memory, as well as when the records are not pulled - might be the case of out of memory messages reported by Klaus Darilion - new parameter export_registrar was added to enable/disable location records export (off by default) - fixed missing exporting the counter with all processed dialogs (discussion from March 2011 with Stefan Tiedje)
---
modules_k/snmpstats/README | 31 ++++++++++++++++----- modules_k/snmpstats/doc/snmpstats_admin.xml | 25 +++++++++++++++++ modules_k/snmpstats/mibs/OPENSER-MIB | 13 ++++++++- modules_k/snmpstats/snmpObjects.c | 28 +++++++++++++++++++ modules_k/snmpstats/snmpObjects.h | 1 + modules_k/snmpstats/snmpstats.c | 40 +++++++++++++++++---------- 6 files changed, 115 insertions(+), 23 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=0696...
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Hello, On 10/31/11 8:10 AM, Klaus Darilion wrote:
Hi Daniel!
I think there is a minor copy-paste bug in snmpstats.c, the function is exported twice:
155 { "snmpCommunity", STR_PARAM|USE_FUNC_PARAM, 156 (void *)set_snmp_community }, 157 { "snmpCommunity", STR_PARAM|USE_FUNC_PARAM, 158 (void *)set_snmp_community }, indeed, it was a duplicated module parameter exported twice. Such thing is completely harmless, anyhow, I committed to git a patch to remove one.
Thanks, Daniel
regards Klaus
On 16.10.2011 11:43, Daniel-Constantin Mierla wrote:
Module: sip-router Branch: master Commit: 0696af54dac4ecc53bb0a9dc4e56da11bc3f2b30 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0696af54...
Author: Daniel-Constantin Mierla<miconda@gmail.com> Committer: Daniel-Constantin Mierla<miconda@gmail.com> Date: Sun Oct 16 11:33:16 2011 +0200
snmpstats: control exporting registrar records
- exporting of large location database may result in out of shared memory, as well as when the records are not pulled - might be the case of out of memory messages reported by Klaus Darilion - new parameter export_registrar was added to enable/disable location records export (off by default) - fixed missing exporting the counter with all processed dialogs (discussion from March 2011 with Stefan Tiedje)
---
modules_k/snmpstats/README | 31 ++++++++++++++++----- modules_k/snmpstats/doc/snmpstats_admin.xml | 25 +++++++++++++++++ modules_k/snmpstats/mibs/OPENSER-MIB | 13 ++++++++- modules_k/snmpstats/snmpObjects.c | 28 +++++++++++++++++++ modules_k/snmpstats/snmpObjects.h | 1 + modules_k/snmpstats/snmpstats.c | 40 +++++++++++++++++---------- 6 files changed, 115 insertions(+), 23 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=0696...
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- Daniel-Constantin Mierla -- http://www.asipto.com Kamailio Advanced Training, Dec 5-8, Berlin: http://asipto.com/u/kat http://linkedin.com/in/miconda -- http://twitter.com/miconda
I tested the patch and it seems to work fine. At least the chunks allocated by snmpstats module stay now constant when I reREGISTER/REGISTER. Previously the number of chunks increased with every deREGISTER/REGISTER. btw: as it is a bugfix we should backport it also to 3.1 (or is 3.1 not supported since 3.2?). klaus On 16.10.2011 11:43, Daniel-Constantin Mierla wrote:
Module: sip-router Branch: master Commit: 0696af54dac4ecc53bb0a9dc4e56da11bc3f2b30 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0696af54...
Author: Daniel-Constantin Mierla<miconda@gmail.com> Committer: Daniel-Constantin Mierla<miconda@gmail.com> Date: Sun Oct 16 11:33:16 2011 +0200
snmpstats: control exporting registrar records
- exporting of large location database may result in out of shared memory, as well as when the records are not pulled - might be the case of out of memory messages reported by Klaus Darilion - new parameter export_registrar was added to enable/disable location records export (off by default) - fixed missing exporting the counter with all processed dialogs (discussion from March 2011 with Stefan Tiedje)
---
modules_k/snmpstats/README | 31 ++++++++++++++++----- modules_k/snmpstats/doc/snmpstats_admin.xml | 25 +++++++++++++++++ modules_k/snmpstats/mibs/OPENSER-MIB | 13 ++++++++- modules_k/snmpstats/snmpObjects.c | 28 +++++++++++++++++++ modules_k/snmpstats/snmpObjects.h | 1 + modules_k/snmpstats/snmpstats.c | 40 +++++++++++++++++---------- 6 files changed, 115 insertions(+), 23 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=0696...
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Daniel, will you backport this to 3.1? regards Klaus On 31.10.2011 18:13, Klaus Darilion wrote:
I tested the patch and it seems to work fine. At least the chunks allocated by snmpstats module stay now constant when I reREGISTER/REGISTER. Previously the number of chunks increased with every deREGISTER/REGISTER.
btw: as it is a bugfix we should backport it also to 3.1 (or is 3.1 not supported since 3.2?).
klaus
On 16.10.2011 11:43, Daniel-Constantin Mierla wrote:
Module: sip-router Branch: master Commit: 0696af54dac4ecc53bb0a9dc4e56da11bc3f2b30 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0696af54...
Author: Daniel-Constantin Mierla<miconda@gmail.com> Committer: Daniel-Constantin Mierla<miconda@gmail.com> Date: Sun Oct 16 11:33:16 2011 +0200
snmpstats: control exporting registrar records
- exporting of large location database may result in out of shared memory, as well as when the records are not pulled - might be the case of out of memory messages reported by Klaus Darilion - new parameter export_registrar was added to enable/disable location records export (off by default) - fixed missing exporting the counter with all processed dialogs (discussion from March 2011 with Stefan Tiedje)
---
modules_k/snmpstats/README | 31 ++++++++++++++++----- modules_k/snmpstats/doc/snmpstats_admin.xml | 25 +++++++++++++++++ modules_k/snmpstats/mibs/OPENSER-MIB | 13 ++++++++- modules_k/snmpstats/snmpObjects.c | 28 +++++++++++++++++++ modules_k/snmpstats/snmpObjects.h | 1 + modules_k/snmpstats/snmpstats.c | 40 +++++++++++++++++---------- 6 files changed, 115 insertions(+), 23 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=0696...
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Reminder - a backport would be nice :-) klaus On 07.11.2011 11:14, Klaus Darilion wrote:
Daniel, will you backport this to 3.1?
regards Klaus
On 31.10.2011 18:13, Klaus Darilion wrote:
I tested the patch and it seems to work fine. At least the chunks allocated by snmpstats module stay now constant when I reREGISTER/REGISTER. Previously the number of chunks increased with every deREGISTER/REGISTER.
btw: as it is a bugfix we should backport it also to 3.1 (or is 3.1 not supported since 3.2?).
klaus
On 16.10.2011 11:43, Daniel-Constantin Mierla wrote:
Module: sip-router Branch: master Commit: 0696af54dac4ecc53bb0a9dc4e56da11bc3f2b30 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0696af54...
Author: Daniel-Constantin Mierla<miconda@gmail.com> Committer: Daniel-Constantin Mierla<miconda@gmail.com> Date: Sun Oct 16 11:33:16 2011 +0200
snmpstats: control exporting registrar records
- exporting of large location database may result in out of shared memory, as well as when the records are not pulled - might be the case of out of memory messages reported by Klaus Darilion - new parameter export_registrar was added to enable/disable location records export (off by default) - fixed missing exporting the counter with all processed dialogs (discussion from March 2011 with Stefan Tiedje)
---
modules_k/snmpstats/README | 31 ++++++++++++++++----- modules_k/snmpstats/doc/snmpstats_admin.xml | 25 +++++++++++++++++ modules_k/snmpstats/mibs/OPENSER-MIB | 13 ++++++++- modules_k/snmpstats/snmpObjects.c | 28 +++++++++++++++++++ modules_k/snmpstats/snmpObjects.h | 1 + modules_k/snmpstats/snmpstats.c | 40 +++++++++++++++++---------- 6 files changed, 115 insertions(+), 23 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=0696...
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Done. Feel free to do it anytime you need a backport for fixes. I wrote some hints about how to do it: * http://www.kamailio.org/wiki/devel/backporting-to-3.2.x You can replace master and 3.2 branches there with other branches, should just work the same. An extra tip for backporting to 3.1, is to backport first to 3.2 and then cherry-pick from 3.2 in 3.1 -- in this way the risk of conflicting (thus a need for manual intervention) is lower. Cheers, Daniel On 11/29/11 11:34 AM, Klaus Darilion wrote:
Reminder - a backport would be nice :-)
klaus
On 07.11.2011 11:14, Klaus Darilion wrote:
Daniel, will you backport this to 3.1?
regards Klaus
On 31.10.2011 18:13, Klaus Darilion wrote:
I tested the patch and it seems to work fine. At least the chunks allocated by snmpstats module stay now constant when I reREGISTER/REGISTER. Previously the number of chunks increased with every deREGISTER/REGISTER.
btw: as it is a bugfix we should backport it also to 3.1 (or is 3.1 not supported since 3.2?).
klaus
On 16.10.2011 11:43, Daniel-Constantin Mierla wrote:
Module: sip-router Branch: master Commit: 0696af54dac4ecc53bb0a9dc4e56da11bc3f2b30 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0696af54...
Author: Daniel-Constantin Mierla<miconda@gmail.com> Committer: Daniel-Constantin Mierla<miconda@gmail.com> Date: Sun Oct 16 11:33:16 2011 +0200
snmpstats: control exporting registrar records
- exporting of large location database may result in out of shared memory, as well as when the records are not pulled - might be the case of out of memory messages reported by Klaus Darilion - new parameter export_registrar was added to enable/disable location records export (off by default) - fixed missing exporting the counter with all processed dialogs (discussion from March 2011 with Stefan Tiedje)
---
modules_k/snmpstats/README | 31 ++++++++++++++++----- modules_k/snmpstats/doc/snmpstats_admin.xml | 25 +++++++++++++++++ modules_k/snmpstats/mibs/OPENSER-MIB | 13 ++++++++- modules_k/snmpstats/snmpObjects.c | 28 +++++++++++++++++++ modules_k/snmpstats/snmpObjects.h | 1 + modules_k/snmpstats/snmpstats.c | 40 +++++++++++++++++---------- 6 files changed, 115 insertions(+), 23 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=0696...
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- Daniel-Constantin Mierla -- http://www.asipto.com Kamailio Advanced Training, Dec 5-8, Berlin: http://asipto.com/u/kat http://linkedin.com/in/miconda -- http://twitter.com/miconda
participants (2)
-
Daniel-Constantin Mierla -
Klaus Darilion