tsearle created an issue (kamailio/kamailio#4308)
while rtpengine_subscribe_request is the correct method name in kemi, when using the kamailio scripting engine the correct name is rtpengine_subscribe_offer
the documentation for the module needs to be updated to reflect this
miconda left a comment (kamailio/kamailio#4308)
I think it is better to have the same function names in the kamailio.cfg and kemi, if they do the same. The idea is that, for kemi, one can correlate by function name to look at the docs in the readme of the module.
tsearle left a comment (kamailio/kamailio#4308)
at this stage which way would you like to go? change the kemi method to match the cfg or the other way around?
miconda left a comment (kamailio/kamailio#4308)
If none of the names is more suitable for what the function does, then you pick.
tsearle left a comment (kamailio/kamailio#4308)
subscribe_offer and subscribe_answer matches offer answer better, but "request" and "answer" are what the actual rtpengine commands are. so I think probably it would be best if I revert my documentation change and then make a patch to change the command in the .cfg
https://rtpengine.readthedocs.io/en/latest/ng_control_protocol.html
should I mark such a pr breaking? (it hasn't been merged into any branch yet)
miconda left a comment (kamailio/kamailio#4308)
AFAIK all these are only in git master branch, so it is not breaking anything -- till a stable release is out, new functions/parameters in devel version can be changed without worrying.
Closed #4308 as completed.
-
Daniel-Constantin Mierla -
tsearle