<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #1458
#### Description <!-- Describe your changes in detail -->
Added ability to explicitly request usage of DTLS transports UDP/TLS/RTP/SAVP and UDP/TLS/RTP/SAVPF via rtpengine API. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1460
-- Commit Summary --
* rtpengine: added support for DTLS transports
-- File Changes --
M src/modules/rtpengine/doc/rtpengine_admin.xml (6) M src/modules/rtpengine/rtpengine.c (23)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1460.patch https://github.com/kamailio/kamailio/pull/1460.diff
Merged #1460.
@rfuchs - should this be backported to 5.1 branch? I can do it before the release tomorrow.
@miconda it's not really a bugfix, and FTR what this commit does has been possible before too, using `transport-protocol=UDP/TLS/...` (which is what people have been using)
@miconda that being said, since 5.1 isn't actually out yet, you're welcome to cherry pick it in
OK, thanks for clarifications. Tomorrow I plan to release the 5.1.2 and ponder what to backport.
Yes, this is not a bugfix, it is just a streamlining change that removes the need to use the undocumented feature `transport-protocol=UDP/TLS/...`.
@rfuchs this commit has broken my use of `rtpengine_manage(DTLS=off)`. Now the key DTLS is not passed to rtpengine but hijacked to set transport.
Without DTLS=off rtpengine adds two lines to SDP a=setup:actpass a=fingerprint:xxxxxxxxxxxxxxxxxxxxxxxxxxx
This seems harmless, but FreeSWITCH expecting SDES fails. UACs based on PSJIP are working. I think that is why my kamailio scripts always had DTLS=off to make FreeSWITCH happy.
@aalba6675 - do not comment in two places for the same issue, it is hard to track where the relevant information is written. As you opened a bug, comment there and reference the PR with #NUMBER .
-
aalba6675 -
Daniel-Constantin Mierla
-
jerzyptak
-
Richard Fuchs