[sr-dev] Re: [kamailio/kamailio] allow address 'grp' 'mask' 'port' fields to be a mysql BIGINT (PR #3923)

@miconda commented on this pull request. "address table - NULL value not permitted\n"); goto dberror; } - if((VAL_TYPE(val + 2) != DB1_INT) || VAL_NULL(val + 2)) { + if((VAL_TYPE(val + 2) != DB1_INT) || (VAL_TYPE(val + 2) != DB1_BIGINT) || VAL_NULL(val + 2)) { This condition does not seem right, if `VAL_TYPE(val + 2)` is `DB1_INT` (as it is expected to be till now), then `VAL_TYPE(val + 2) != DB1_BIGINT` is true, so the IF expression is going to be true and go to error. Same seems to be for the other IF expressions that were changed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3923#pullrequestreview-2185031554 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3923/review/2185031554(a)github.com>