@miconda commented on this pull request.


In src/modules/permissions/address.c:

> @@ -208,12 +208,12 @@ int reload_address_db_table(address_tables_group_t *atg)
 				   "address table - NULL value not permitted\n");
 			goto dberror;
 		}
-		if((VAL_TYPE(val + 2) != DB1_INT) || VAL_NULL(val + 2)) {
+		if((VAL_TYPE(val + 2) != DB1_INT) || (VAL_TYPE(val + 2) != DB1_BIGINT) || VAL_NULL(val + 2)) {

This condition does not seem right, if VAL_TYPE(val + 2) is DB1_INT (as it is expected to be till now), then VAL_TYPE(val + 2) != DB1_BIGINT is true, so the IF expression is going to be true and go to error.

Same seems to be for the other IF expressions that were changed.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/3923/review/2185031554@github.com>