[sr-dev] [kamailio/kamailio] ims_isc: bugfix: firstflag incorrect in isc_match_filter (PR #4018)

#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description <!-- Describe your changes in detail --> The function isc_match_filter uses a local variable "firstflag", to handle the case of an HSS based terminating unregistered service. In that case, the S-CSCF exchanges SAR/SAA with the HSS in order to learn the subscription data and the iFC for an unregistered user or for a PSI. The firstflag is necessary to make a distiction between the FAILURE ROUTE that is used for this case and the FAILURE ROUTE that is used for transaction failure towards the AS. The error is, the firstflag is set for the latter case, too, which leads to a wrong handling of communication errors towards the AS. This PR introduces a new function that looks for the old ISCMARK in the lumps of the stored message and hence can make a distinction between the SAR/SAA case and the AS failure case. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4018 -- Commit Summary -- * ims_isc: bugfix: firstflag incorrect in isc_match_filter -- File Changes -- M src/modules/ims_isc/ims_isc_mod.c (24) M src/modules/ims_isc/mark.c (51) M src/modules/ims_isc/mark.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4018.patch https://github.com/kamailio/kamailio/pull/4018.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4018 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4018(a)github.com>