Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #XXXX (replace XXXX with an open issue number)

Description

The function isc_match_filter uses a local variable "firstflag",
to handle the case of an HSS based terminating unregistered service.

In that case, the S-CSCF exchanges SAR/SAA with the HSS in order
to learn the subscription data and the iFC for an unregistered
user or for a PSI.

The firstflag is necessary to make a distiction between the
FAILURE ROUTE that is used for this case and the FAILURE ROUTE
that is used for transaction failure towards the AS.

The error is, the firstflag is set for the latter case, too,
which leads to a wrong handling of communication errors towards
the AS.

This PR introduces a new function that looks for the old
ISCMARK in the lumps of the stored message and hence can make a
distinction between the SAR/SAA case and the AS failure case.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/4018

Commit Summary

183899e ims_isc: bugfix: firstflag incorrect in isc_match_filter

File Changes

(3 files)

M src/modules/ims_isc/ims_isc_mod.c (24)
M src/modules/ims_isc/mark.c (51)
M src/modules/ims_isc/mark.h (1)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.