1 Feb
2018
1 Feb
'18
11:21 a.m.
3 days for the entire PR (and 2 days from last comment) is not a long period of time, specially if people are traveling or vacation.
Before merging, if it is not a module you developed, then ask again like:
``` If no further comments in 3 days, then I will merge ... ```
This is a generic remark, not saying that this PR should be reverted. But overall, it's not advisable to rush and merge specially on big changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1417#issuecomment-362236904