oops sorry i didn't think about dmq support. the API endpoint is scrictly to update the presentity database, the existing update_presentity() function seems to do a lot more than that... i will look into integrating the 2 or at least add dmq support to the API function -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1417#issuecomment-361356336

@charlesrchance thanks for the comment on this, turned out it was not too difficult to call the existing function. when you get a chance, please let me know what you think about this. my tests show it's working (calling the API with some test code updates presentity table) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1417#issuecomment-361624147

Nice...why not include the last two params now, though, for completeness? Then it's just a question of the docs - seems to be a lot of API functions missing already, so could be a good time to bring them up to date. What do others think? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1417#issuecomment-361689125

To me, adding a separate function for an extra two params is bloating the code. The final two params are a direct passthrough, anyway. So your function simply becomes: ``` int _api_pres_refresh_watchers(str *pres, str *event, int type, str *file_uri, str *filename) { return pres_refresh_watchers(pres, event, type, file_uri, filename); } ``` Compared with: ``` int _api_pres_refresh_watchers(str *pres, str *event, int type) { return pres_refresh_watchers(pres, event, type, NULL, NULL); } int _api_pres_refresh_watchers_file(str *pres, str *event, int type, str *file_uri, str *filename) { return pres_refresh_watchers(pres, event, type, file_uri, filename); } ``` Plus you consider others' needs in future and not just your own right now. Just my opinion - perhaps others think differently. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1417#issuecomment-361693961

i am considering others' needs as Im preparing these API functions in order to submit a new module which will use them. The new module will be for everyone to freely use-- and if there becomes a need to use any more API functions, i expect the developer that requires them, will have to do exactly as I did, and create those API functions. But there is also a good chance that the API function we are talking about will *never* be required so IMO it becomes bloat -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1417#issuecomment-361697583

merging this since i haven't received further comment -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1417#issuecomment-362235307

3 days for the entire PR (and 2 days from last comment) is not a long period of time, specially if people are traveling or vacation. Before merging, if it is not a module you developed, then ask again like: ``` If no further comments in 3 days, then I will merge ... ``` This is a generic remark, not saying that this PR should be reverted. But overall, it's not advisable to rush and merge specially on big changes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1417#issuecomment-362236904

@eschmidbauer - also just another remark for the future - the personal branches should use `userid/branch-name`, not only `branch-name` -- e.g., `eschmidbauer/presence-api`. It should be written somewhere in the contribution guidelines or in the wiki for devs info. Branches without the userid that are not officially created for a specific purpose (releases, continuous integration) can be removed without notice. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1417#issuecomment-362237700