I'm sorry as well, just was too excited on my first commit.
On Mar 29 2019, at 11:00 am, Federico Cabiddu notifications@github.com wrote:
You're right, I missed it sorry.
Federico On Fri, Mar 29, 2019 at 9:36 AM Daniel-Constantin Mierla < notifications@github.com> wrote:
@samael33 https://github.com/samael33, @grumvalski https://github.com/grumvalski -- the commit messages on this pull are really inappropriate for development history.
Next time check the contribution guidelines:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/1913#issuecomment-477914492, or mute the thread https://github.com/notifications/unsubscribe-auth/ADip4799S3PxRSOVf5QUkkj4SAjbiatkks5vbdCYgaJpZM4cQJrV .
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://link.getmailspring.com/link/3618C5FA-8E0A-416A-9CB4-3A62BA641883@get...), or mute the thread (https://link.getmailspring.com/link/3618C5FA-8E0A-416A-9CB4-3A62BA641883@get...).