I&#39;m sorry as well, just was too excited on my first commit.<br>
<br>
On Mar 29 2019, at 11:00 am, Federico Cabiddu &lt;notifications@github.com&gt; wrote:<br>
&gt; You&#39;re right, I missed it sorry.<br>
&gt;<br>
&gt; Federico<br>
&gt; On Fri, Mar 29, 2019 at 9:36 AM Daniel-Constantin Mierla &lt;<br>
&gt; notifications@github.com&gt; wrote:<br>
&gt;<br>
&gt; &gt; @samael33 &lt;https://github.com/samael33&gt;, @grumvalski<br>
&gt; &gt; &lt;https://github.com/grumvalski&gt; -- the commit messages on this pull are<br>
&gt; &gt; really inappropriate for development history.<br>
&gt; &gt;<br>
&gt; &gt; Next time check the contribution guidelines:<br>
&gt; &gt;<br>
&gt; &gt; -<br>
&gt; &gt; https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md<br>
&gt; &gt;<br>
&gt; &gt; —<br>
&gt; &gt; You are receiving this because you were mentioned.<br>
&gt; &gt; Reply to this email directly, view it on GitHub<br>
&gt; &gt; &lt;https://github.com/kamailio/kamailio/pull/1913#issuecomment-477914492&gt;,<br>
&gt; &gt; or mute the thread<br>
&gt; &gt; &lt;https://github.com/notifications/unsubscribe-auth/ADip4799S3PxRSOVf5QUkkj4SAjbiatkks5vbdCYgaJpZM4cQJrV&gt;<br>
&gt; &gt; .<br>
&gt; &gt;<br>
&gt; —<br>
&gt; You are receiving this because you were mentioned.<br>
&gt; Reply to this email directly, view it on GitHub (https://link.getmailspring.com/link/3618C5FA-8E0A-416A-9CB4-3A62BA641883@getmailspring.com/0?redirect=https%3A%2F%2Fgithub.com%2Fkamailio%2Fkamailio%2Fpull%2F1913%23issuecomment-477921080&amp;recipient=cmVwbHkrMDBhZjhhNDMzNGUwZDkyOGRlYWJmYWU1MWJlZGEyNGQ5MTExYjY5OTgzZDYwN2E5OTJjZjAwMDAwMDAxMThiNWEwYTk5MmExNjljZTE5NmJiOWNjQHJlcGx5LmdpdGh1Yi5jb20%3D), or mute the thread (https://link.getmailspring.com/link/3618C5FA-8E0A-416A-9CB4-3A62BA641883@getmailspring.com/1?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAK-KQ4gRzdNKNZ340yaKjFK28BI1F7DSks5vbdYpgaJpZM4cQJrV&amp;recipient=cmVwbHkrMDBhZjhhNDMzNGUwZDkyOGRlYWJmYWU1MWJlZGEyNGQ5MTExYjY5OTgzZDYwN2E5OTJjZjAwMDAwMDAxMThiNWEwYTk5MmExNjljZTE5NmJiOWNjQHJlcGx5LmdpdGh1Yi5jb20%3D).<br>
&gt;<br>
&gt;<br>
<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1913#issuecomment-477921566">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZUrhDGfLWMIDIH3r6L5OzPA8jM52ks5vbdZugaJpZM4cQJrV">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZSIL1F8Gh9VB7wv1znFknEORWtrkks5vbdZugaJpZM4cQJrV.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@samael33 in #1913: I'm sorry as well, just was too excited on my first commit.\n\nOn Mar 29 2019, at 11:00 am, Federico Cabiddu \u003cnotifications@github.com\u003e wrote:\n\u003e You're right, I missed it sorry.\n\u003e\n\u003e Federico\n\u003e On Fri, Mar 29, 2019 at 9:36 AM Daniel-Constantin Mierla \u003c\n\u003e notifications@github.com\u003e wrote:\n\u003e\n\u003e \u003e @samael33 \u003chttps://github.com/samael33\u003e, @grumvalski\n\u003e \u003e \u003chttps://github.com/grumvalski\u003e -- the commit messages on this pull are\n\u003e \u003e really inappropriate for development history.\n\u003e \u003e\n\u003e \u003e Next time check the contribution guidelines:\n\u003e \u003e\n\u003e \u003e -\n\u003e \u003e https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md\n\u003e \u003e\n\u003e \u003e —\n\u003e \u003e You are receiving this because you were mentioned.\n\u003e \u003e Reply to this email directly, view it on GitHub\n\u003e \u003e \u003chttps://github.com/kamailio/kamailio/pull/1913#issuecomment-477914492\u003e,\n\u003e \u003e or mute the thread\n\u003e \u003e \u003chttps://github.com/notifications/unsubscribe-auth/ADip4799S3PxRSOVf5QUkkj4SAjbiatkks5vbdCYgaJpZM4cQJrV\u003e\n\u003e \u003e .\n\u003e \u003e\n\u003e —\n\u003e You are receiving this because you were mentioned.\n\u003e Reply to this email directly, view it on GitHub (https://link.getmailspring.com/link/3618C5FA-8E0A-416A-9CB4-3A62BA641883@getmailspring.com/0?redirect=https%3A%2F%2Fgithub.com%2Fkamailio%2Fkamailio%2Fpull%2F1913%23issuecomment-477921080\u0026recipient=cmVwbHkrMDBhZjhhNDMzNGUwZDkyOGRlYWJmYWU1MWJlZGEyNGQ5MTExYjY5OTgzZDYwN2E5OTJjZjAwMDAwMDAxMThiNWEwYTk5MmExNjljZTE5NmJiOWNjQHJlcGx5LmdpdGh1Yi5jb20%3D), or mute the thread (https://link.getmailspring.com/link/3618C5FA-8E0A-416A-9CB4-3A62BA641883@getmailspring.com/1?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAK-KQ4gRzdNKNZ340yaKjFK28BI1F7DSks5vbdYpgaJpZM4cQJrV\u0026recipient=cmVwbHkrMDBhZjhhNDMzNGUwZDkyOGRlYWJmYWU1MWJlZGEyNGQ5MTExYjY5OTgzZDYwN2E5OTJjZjAwMDAwMDAxMThiNWEwYTk5MmExNjljZTE5NmJiOWNjQHJlcGx5LmdpdGh1Yi5jb20%3D).\n\u003e\n\u003e\n\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1913#issuecomment-477921566"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1913#issuecomment-477921566",
"url": "https://github.com/kamailio/kamailio/pull/1913#issuecomment-477921566",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>