sr-dev

sr-dev@lists.kamailio.org

16 participants
45408 discussions

git:master:d99f0404: tm: t flags field made int
by Daniel-Constantin Mierla 26 Mar '25

26 Mar '25

Module: kamailio Branch: master Commit: d99f040463805a8f7438409e41a9a270ec298092 URL: https://github.com/kamailio/kamailio/commit/d99f040463805a8f7438409e41a9a27… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-25T22:21:52+01:00 tm: t flags field made int - short size is full, flag 15 already used --- Modified: src/modules/tm/h_table.h Modified: src/modules/tm/uac.h --- Diff: https://github.com/kamailio/kamailio/commit/d99f040463805a8f7438409e41a9a27… Patch: https://github.com/kamailio/kamailio/commit/d99f040463805a8f7438409e41a9a27… --- diff --git a/src/modules/tm/h_table.h b/src/modules/tm/h_table.h index 59e229d068d..3e8136cbdac 100644 --- a/src/modules/tm/h_table.h +++ b/src/modules/tm/h_table.h @@ -346,9 +346,9 @@ typedef struct cell /* sequence number within hash collision slot */ unsigned int label; /* different information about the transaction */ - unsigned short flags; + unsigned int flags; /* number of forks */ - short nr_of_outgoings; + int nr_of_outgoings; /* free operations counter - debug */ int fcount; diff --git a/src/modules/tm/uac.h b/src/modules/tm/uac.h index a76d8ea63a7..00dc32d2a5b 100644 --- a/src/modules/tm/uac.h +++ b/src/modules/tm/uac.h @@ -32,6 +32,7 @@ #define DEFAULT_CSEQ 10 /* Default CSeq number */ + /* structure for UAC interface * * You can free the memory allocated

1 0

[kamailio/kamailio] [rtpengine] failure to ping rtpengine results in consistent core dump in kamailio 5.8.2 (Issue #4122)
by Brandon Armstead 26 Mar '25

26 Mar '25

### RTPEngine + RTIMER + SEGFAULT + unable to ping When unable to ping RTPEngine instances kamailio crashes. ### Troubleshooting Determined issue was related to the ping failures, resolved AWS SG issue, allowing successful pings. Issue subsequently went away. #### Reproduction Use rtpengine with RDS backend Load rtpengine with ~ 20 destinations you do not expect a response from on Use rtimer to call rtpengine.reload via jsonrpcs: ``` modparam("rtimer", "timer", "name=rtpengine;interval=60;mode=0;") modparam("rtimer", "exec", "timer=rtpengine;route=RELOAD_RTPENGINE") route[RELOAD_RTPENGINE] { xinfo("RTPEngine database reloading"); jsonrpc_exec('{"jsonrpc": "2.0", "method": "rtpengine.reload", "id": 1}'); } ``` #### Debugging Data Got a core dump -- although I deleted quickly (not thinking) as they were running instances out of disk quickly. bt full did not show much to step through all though clearly pointed to rtpengine. #### Log Messages ``` send_rtpp_command(): timeout waiting reply for command "ping" from RTPEngine <udp:10.0.X.X> ``` ### Possible Solutions TBD / do not have ping failures under heavy load. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.2 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 10.2.1 ``` * **Operating System**: ``` uname -a Linux 5.10.0-27-cloud-amd64 #1 SMP Debian 5.10.205-2 (2023-12-31) x86_64 GNU/Linux cat /proc/version Linux version 5.10.0-27-cloud-amd64 (debian-kernel(a)lists.debian.org) (gcc-10 (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2) #1 SMP Debian 5.10.205-2 (2023-12-31) lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4122 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4122(a)github.com>

3 4

git:master:7cc9a197: uid_domain: rename internal is_local() to avoid duplicates
by Daniel-Constantin Mierla 25 Mar '25

25 Mar '25

Module: kamailio Branch: master Commit: 7cc9a1979a2594f4b19d6750cffb2795b3274ede URL: https://github.com/kamailio/kamailio/commit/7cc9a1979a2594f4b19d6750cffb279… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-25T18:37:44+01:00 uid_domain: rename internal is_local() to avoid duplicates --- Modified: src/modules/uid_domain/uid_domain_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/7cc9a1979a2594f4b19d6750cffb279… Patch: https://github.com/kamailio/kamailio/commit/7cc9a1979a2594f4b19d6750cffb279… --- diff --git a/src/modules/uid_domain/uid_domain_mod.c b/src/modules/uid_domain/uid_domain_mod.c index e140e003d95..57a2c7d0c63 100644 --- a/src/modules/uid_domain/uid_domain_mod.c +++ b/src/modules/uid_domain/uid_domain_mod.c @@ -51,7 +51,7 @@ static int mod_init(void); static void destroy(void); static int child_init(int rank); -static int is_local(struct sip_msg *msg, char *s1, char *s2); +static int uid_domain_is_local(struct sip_msg *msg, char *s1, char *s2); static int lookup_domain(struct sip_msg *msg, char *s1, char *s2); static int get_did(str *did, str *domain); @@ -122,8 +122,10 @@ static domain_t dom_buf[2]; * Exported functions */ static cmd_export_t cmds[] = { - {"is_local", is_local, 1, fixup_var_str_1, fixup_free_fparam_1, REQUEST_ROUTE | FAILURE_ROUTE | BRANCH_ROUTE}, - {"lookup_domain", lookup_domain, 2, lookup_domain_fixup, lookup_domain_fixup_free, REQUEST_ROUTE | FAILURE_ROUTE}, + {"is_local", uid_domain_is_local, 1, fixup_var_str_1, fixup_free_fparam_1, + REQUEST_ROUTE | FAILURE_ROUTE | BRANCH_ROUTE}, + {"lookup_domain", lookup_domain, 2, lookup_domain_fixup, + lookup_domain_fixup_free, REQUEST_ROUTE | FAILURE_ROUTE}, {"get_did", (cmd_function)get_did, 0, 0, 0, 0}, {"bind_domain", (cmd_function)bind_domain, 0, 0, 0, 0}, {0, 0, 0, 0, 0, 0} @@ -384,7 +386,7 @@ static void destroy(void) /* * Check if domain is local */ -static int is_local(struct sip_msg *msg, char *fp, char *s2) +static int uid_domain_is_local(struct sip_msg *msg, char *fp, char *s2) { str domain;

1 0

[kamailio/kamailio] fix typo on sanity checks module (PR #4184)
by Alessio Garzi 25 Mar '25

25 Mar '25

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4184 -- Commit Summary -- * fix typo on sanity checks module -- File Changes -- M src/modules/sanity/sanity.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4184.patch https://github.com/kamailio/kamailio/pull/4184.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4184 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4184(a)github.com>

3 5

[kamailio/kamailio] github: check-commit for PR (PR #4188)
by Victor Seva 25 Mar '25

25 Mar '25

* minimal checks for prefix in commit subject You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4188 -- Commit Summary -- * github: check-commit for PR -- File Changes -- A .github/scripts/check-commit.sh (37) M .github/workflows/pull_request.yml (10) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4188.patch https://github.com/kamailio/kamailio/pull/4188.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4188 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4188(a)github.com>

1 11

git:master:d062d9a1: github: check-commit for PR
by Victor Seva 25 Mar '25

25 Mar '25

Module: kamailio Branch: master Commit: d062d9a1d5dc1a73c51994ece0703fa759e9afbc URL: https://github.com/kamailio/kamailio/commit/d062d9a1d5dc1a73c51994ece0703fa… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-25T16:27:29+01:00 github: check-commit for PR * minimal checks for prefix in commit subject --- Added: .github/scripts/check-commit.sh Modified: .github/workflows/pull_request.yml --- Diff: https://github.com/kamailio/kamailio/commit/d062d9a1d5dc1a73c51994ece0703fa… Patch: https://github.com/kamailio/kamailio/commit/d062d9a1d5dc1a73c51994ece0703fa… --- diff --git a/.github/scripts/check-commit.sh b/.github/scripts/check-commit.sh new file mode 100755 index 00000000000..144d6a4395e --- /dev/null +++ b/.github/scripts/check-commit.sh @@ -0,0 +1,83 @@ +#!/bin/bash +COMMIT_MESSAGE_SUBJECT_FORMAT="%s" + +set -eu + +res=0 + +die() { echo "$@" >&2; exit 1; } +fail() { echo "*** $@ ***" >&2; res=1; } + +git_log_format() { + local pattern="$1" + local reference="$2" + git log -1 --pretty=format:"$pattern" "$reference" +} + +check_subject() { + local commit="$1" + local subject="$2" + + # get the prefix + if ! [[ "${subject}" =~ ^([^:]+):.*$ ]] ; then + fail "[${commit}] prefix not detected:'${subject}'" + return + fi + prefix="${BASH_REMATCH[1]}" + if [ -z "${prefix}" ] ; then + fail "[${commit}] commit subject has no prefix:'${subject}'" + return + fi + + # core or lib + if [ -d "src/${prefix}" ] ; then + echo "[${commit}] prefix is core or lib, OK[${prefix}]" + return + fi + + # prefix is a module + if [ -d "src/modules/${prefix}" ] ; then + echo "[${commit}] prefix is module, OK[${prefix}]" + return + fi + + # utils? + if [ -d "${prefix}" ] ; then + echo "[${commit}] prefix is a dir in the repo, OK[${prefix}]" + return + fi + + # github configs + if [[ "${prefix}" =~ ^github$ ]] ; then + echo "[${commit}] prefix is github config, OK[${prefix}]" + return + fi + + fail "[${commit}] unknown prefix:'${prefix}'" +} + +target="${GITHUB_BASE_REF:-master}" +if [ "${CI:-}" ]; then + git rev-parse -q --no-revs --verify "origin/${target}" || \ + git rev-parse -q --no-revs --verify "${target}" || \ + git fetch origin --depth=1 "${target}" + git rev-parse -q --no-revs --verify "origin/${target}" || \ + git rev-parse -q --no-revs --verify "${target}" || \ + git fetch origin --depth=1 tag "${target}" + # Ensure that the target revision has some history + target_sha=$(git rev-parse -q --verify "origin/${target}" || git rev-parse -q --verify "${target}") + git fetch -q "--depth=${FETCH_DEPTH:-50}" origin "+${target_sha}" +else + target_sha=$(git rev-parse -q --verify "${target}") || die "fatal: couldn't find ref ${target}" +fi + +ref=${ref:-HEAD} +src_sha=$(git rev-parse -q --verify "${ref}") || die "fatal: couldn't find ref ${ref}" +echo "Checking $(git rev-list --count "${src_sha}" "^${target_sha}") commits since revision ${target_sha}" +for commit in $(git rev-list --reverse "${src_sha}" "^${target_sha}"); do + COMMIT_MESSAGE_SUBJECT=$(git_log_format "${COMMIT_MESSAGE_SUBJECT_FORMAT}" "${commit}") + check_subject "${commit}" "${COMMIT_MESSAGE_SUBJECT}" +done + +echo "Result: ${res}" +exit $res diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 351b0ba9542..dcd44cd72c8 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -12,10 +12,24 @@ jobs: permissions: contents: read # to fetch code (actions/checkout) steps: - - uses: actions/checkout@v4 + - name: Check out the repository to the runner + uses: actions/checkout@v4 - uses: wolletd/clang-format-checker(a)v1.12 with: target-ref: master + check-commit: + runs-on: ubuntu-latest + permissions: + contents: read # to fetch code (actions/checkout) + steps: + - name: Check out the repository to the runner + uses: actions/checkout@v4 + with: + ref: ${{ github.event.pull_request.head.sha }} + - name: Run scripts/check-commit.sh + run: ./.github/scripts/check-commit.sh + env: + ref: ${{ github.event.pull_request.head.sha }} build: runs-on: ubuntu-latest permissions: @@ -38,7 +52,8 @@ jobs: - distribution: bookworm compilier: clang steps: - - uses: actions/checkout@v4 + - name: Check out the repository to the runner + uses: actions/checkout@v4 - uses: ammaraskar/gcc-problem-matcher(a)0.3.0 - name: build run: |

1 0

git:5.8:52772bf0: fix typo on sanity checks module
by Victor Seva 25 Mar '25

25 Mar '25

Module: kamailio Branch: 5.8 Commit: 52772bf03ad07758e92eea4a71d22f5df8e976f4 URL: https://github.com/kamailio/kamailio/commit/52772bf03ad07758e92eea4a71d22f5… Author: Alessio Garzi <agarzi(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-25T10:21:44+01:00 fix typo on sanity checks module (cherry picked from commit 3b48fff143b49f16b328475a7b26017209e98666) (cherry picked from commit ecb00946bf684b4c8405d71fe9306d35aba21359) --- Modified: src/modules/sanity/sanity.c --- Diff: https://github.com/kamailio/kamailio/commit/52772bf03ad07758e92eea4a71d22f5… Patch: https://github.com/kamailio/kamailio/commit/52772bf03ad07758e92eea4a71d22f5… --- diff --git a/src/modules/sanity/sanity.c b/src/modules/sanity/sanity.c index 44765f7a17f..d4a50c3e566 100644 --- a/src/modules/sanity/sanity.c +++ b/src/modules/sanity/sanity.c @@ -811,7 +811,7 @@ int check_parse_uris(sip_msg_t *msg, int checks) if(!msg->to || !msg->to->body.s) { msg->msg_flags |= FL_MSG_NOREPLY; } else { - if(sanity_reply(msg, 400, "Ivalid To Header") < 0) { + if(sanity_reply(msg, 400, "Invalid To Header") < 0) { LM_WARN("failed to send 400 via sl reply (missing To)\n"); } }

1 0

git:6.0:ecb00946: fix typo on sanity checks module
by Victor Seva 25 Mar '25

25 Mar '25

Module: kamailio Branch: 6.0 Commit: ecb00946bf684b4c8405d71fe9306d35aba21359 URL: https://github.com/kamailio/kamailio/commit/ecb00946bf684b4c8405d71fe9306d3… Author: Alessio Garzi <agarzi(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-25T10:21:13+01:00 fix typo on sanity checks module (cherry picked from commit 3b48fff143b49f16b328475a7b26017209e98666) --- Modified: src/modules/sanity/sanity.c --- Diff: https://github.com/kamailio/kamailio/commit/ecb00946bf684b4c8405d71fe9306d3… Patch: https://github.com/kamailio/kamailio/commit/ecb00946bf684b4c8405d71fe9306d3… --- diff --git a/src/modules/sanity/sanity.c b/src/modules/sanity/sanity.c index 582a1aaada0..8059866c428 100644 --- a/src/modules/sanity/sanity.c +++ b/src/modules/sanity/sanity.c @@ -813,7 +813,7 @@ int check_parse_uris(sip_msg_t *msg, int checks) if(!msg->to || !msg->to->body.s) { msg->msg_flags |= FL_MSG_NOREPLY; } else { - if(sanity_reply(msg, 400, "Ivalid To Header") < 0) { + if(sanity_reply(msg, 400, "Invalid To Header") < 0) { LM_WARN("failed to send 400 via sl reply (missing To)\n"); } }

1 0

git:master:3b48fff1: fix typo on sanity checks module
by Victor Seva 25 Mar '25

25 Mar '25

Module: kamailio Branch: master Commit: 3b48fff143b49f16b328475a7b26017209e98666 URL: https://github.com/kamailio/kamailio/commit/3b48fff143b49f16b328475a7b26017… Author: Alessio Garzi <agarzi(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-25T10:19:59+01:00 fix typo on sanity checks module --- Modified: src/modules/sanity/sanity.c --- Diff: https://github.com/kamailio/kamailio/commit/3b48fff143b49f16b328475a7b26017… Patch: https://github.com/kamailio/kamailio/commit/3b48fff143b49f16b328475a7b26017… --- diff --git a/src/modules/sanity/sanity.c b/src/modules/sanity/sanity.c index 582a1aaada0..8059866c428 100644 --- a/src/modules/sanity/sanity.c +++ b/src/modules/sanity/sanity.c @@ -813,7 +813,7 @@ int check_parse_uris(sip_msg_t *msg, int checks) if(!msg->to || !msg->to->body.s) { msg->msg_flags |= FL_MSG_NOREPLY; } else { - if(sanity_reply(msg, 400, "Ivalid To Header") < 0) { + if(sanity_reply(msg, 400, "Invalid To Header") < 0) { LM_WARN("failed to send 400 via sl reply (missing To)\n"); } }

1 0

[kamailio/kamailio] Migrate to C23 (Issue #4106)
by soroshsabz 25 Mar '25

25 Mar '25

ITNOA As you can see many defects resolve in [C17](https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2244.htm) and [C23](https://en.wikipedia.org/wiki/C23_(C_standard_revision) introduce many new language features for clean coding. So I suggest migrate codebase to C23, and if you agree with me, I can try to migrate that -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4106 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4106(a)github.com>

5 14

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev