sr-dev

sr-dev@lists.kamailio.org

16 participants
45394 discussions

[kamailio/kamailio] github: check-commit for PR (PR #4188)
by Victor Seva 25 Mar '25

25 Mar '25

* minimal checks for prefix in commit subject You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4188 -- Commit Summary -- * github: check-commit for PR -- File Changes -- A .github/scripts/check-commit.sh (37) M .github/workflows/pull_request.yml (10) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4188.patch https://github.com/kamailio/kamailio/pull/4188.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4188 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4188(a)github.com>

1 11

git:master:d062d9a1: github: check-commit for PR
by Victor Seva 25 Mar '25

25 Mar '25

Module: kamailio Branch: master Commit: d062d9a1d5dc1a73c51994ece0703fa759e9afbc URL: https://github.com/kamailio/kamailio/commit/d062d9a1d5dc1a73c51994ece0703fa… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-25T16:27:29+01:00 github: check-commit for PR * minimal checks for prefix in commit subject --- Added: .github/scripts/check-commit.sh Modified: .github/workflows/pull_request.yml --- Diff: https://github.com/kamailio/kamailio/commit/d062d9a1d5dc1a73c51994ece0703fa… Patch: https://github.com/kamailio/kamailio/commit/d062d9a1d5dc1a73c51994ece0703fa… --- diff --git a/.github/scripts/check-commit.sh b/.github/scripts/check-commit.sh new file mode 100755 index 00000000000..144d6a4395e --- /dev/null +++ b/.github/scripts/check-commit.sh @@ -0,0 +1,83 @@ +#!/bin/bash +COMMIT_MESSAGE_SUBJECT_FORMAT="%s" + +set -eu + +res=0 + +die() { echo "$@" >&2; exit 1; } +fail() { echo "*** $@ ***" >&2; res=1; } + +git_log_format() { + local pattern="$1" + local reference="$2" + git log -1 --pretty=format:"$pattern" "$reference" +} + +check_subject() { + local commit="$1" + local subject="$2" + + # get the prefix + if ! [[ "${subject}" =~ ^([^:]+):.*$ ]] ; then + fail "[${commit}] prefix not detected:'${subject}'" + return + fi + prefix="${BASH_REMATCH[1]}" + if [ -z "${prefix}" ] ; then + fail "[${commit}] commit subject has no prefix:'${subject}'" + return + fi + + # core or lib + if [ -d "src/${prefix}" ] ; then + echo "[${commit}] prefix is core or lib, OK[${prefix}]" + return + fi + + # prefix is a module + if [ -d "src/modules/${prefix}" ] ; then + echo "[${commit}] prefix is module, OK[${prefix}]" + return + fi + + # utils? + if [ -d "${prefix}" ] ; then + echo "[${commit}] prefix is a dir in the repo, OK[${prefix}]" + return + fi + + # github configs + if [[ "${prefix}" =~ ^github$ ]] ; then + echo "[${commit}] prefix is github config, OK[${prefix}]" + return + fi + + fail "[${commit}] unknown prefix:'${prefix}'" +} + +target="${GITHUB_BASE_REF:-master}" +if [ "${CI:-}" ]; then + git rev-parse -q --no-revs --verify "origin/${target}" || \ + git rev-parse -q --no-revs --verify "${target}" || \ + git fetch origin --depth=1 "${target}" + git rev-parse -q --no-revs --verify "origin/${target}" || \ + git rev-parse -q --no-revs --verify "${target}" || \ + git fetch origin --depth=1 tag "${target}" + # Ensure that the target revision has some history + target_sha=$(git rev-parse -q --verify "origin/${target}" || git rev-parse -q --verify "${target}") + git fetch -q "--depth=${FETCH_DEPTH:-50}" origin "+${target_sha}" +else + target_sha=$(git rev-parse -q --verify "${target}") || die "fatal: couldn't find ref ${target}" +fi + +ref=${ref:-HEAD} +src_sha=$(git rev-parse -q --verify "${ref}") || die "fatal: couldn't find ref ${ref}" +echo "Checking $(git rev-list --count "${src_sha}" "^${target_sha}") commits since revision ${target_sha}" +for commit in $(git rev-list --reverse "${src_sha}" "^${target_sha}"); do + COMMIT_MESSAGE_SUBJECT=$(git_log_format "${COMMIT_MESSAGE_SUBJECT_FORMAT}" "${commit}") + check_subject "${commit}" "${COMMIT_MESSAGE_SUBJECT}" +done + +echo "Result: ${res}" +exit $res diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 351b0ba9542..dcd44cd72c8 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -12,10 +12,24 @@ jobs: permissions: contents: read # to fetch code (actions/checkout) steps: - - uses: actions/checkout@v4 + - name: Check out the repository to the runner + uses: actions/checkout@v4 - uses: wolletd/clang-format-checker(a)v1.12 with: target-ref: master + check-commit: + runs-on: ubuntu-latest + permissions: + contents: read # to fetch code (actions/checkout) + steps: + - name: Check out the repository to the runner + uses: actions/checkout@v4 + with: + ref: ${{ github.event.pull_request.head.sha }} + - name: Run scripts/check-commit.sh + run: ./.github/scripts/check-commit.sh + env: + ref: ${{ github.event.pull_request.head.sha }} build: runs-on: ubuntu-latest permissions: @@ -38,7 +52,8 @@ jobs: - distribution: bookworm compilier: clang steps: - - uses: actions/checkout@v4 + - name: Check out the repository to the runner + uses: actions/checkout@v4 - uses: ammaraskar/gcc-problem-matcher(a)0.3.0 - name: build run: |

1 0

git:5.8:52772bf0: fix typo on sanity checks module
by Victor Seva 25 Mar '25

25 Mar '25

Module: kamailio Branch: 5.8 Commit: 52772bf03ad07758e92eea4a71d22f5df8e976f4 URL: https://github.com/kamailio/kamailio/commit/52772bf03ad07758e92eea4a71d22f5… Author: Alessio Garzi <agarzi(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-25T10:21:44+01:00 fix typo on sanity checks module (cherry picked from commit 3b48fff143b49f16b328475a7b26017209e98666) (cherry picked from commit ecb00946bf684b4c8405d71fe9306d35aba21359) --- Modified: src/modules/sanity/sanity.c --- Diff: https://github.com/kamailio/kamailio/commit/52772bf03ad07758e92eea4a71d22f5… Patch: https://github.com/kamailio/kamailio/commit/52772bf03ad07758e92eea4a71d22f5… --- diff --git a/src/modules/sanity/sanity.c b/src/modules/sanity/sanity.c index 44765f7a17f..d4a50c3e566 100644 --- a/src/modules/sanity/sanity.c +++ b/src/modules/sanity/sanity.c @@ -811,7 +811,7 @@ int check_parse_uris(sip_msg_t *msg, int checks) if(!msg->to || !msg->to->body.s) { msg->msg_flags |= FL_MSG_NOREPLY; } else { - if(sanity_reply(msg, 400, "Ivalid To Header") < 0) { + if(sanity_reply(msg, 400, "Invalid To Header") < 0) { LM_WARN("failed to send 400 via sl reply (missing To)\n"); } }

1 0

git:6.0:ecb00946: fix typo on sanity checks module
by Victor Seva 25 Mar '25

25 Mar '25

Module: kamailio Branch: 6.0 Commit: ecb00946bf684b4c8405d71fe9306d35aba21359 URL: https://github.com/kamailio/kamailio/commit/ecb00946bf684b4c8405d71fe9306d3… Author: Alessio Garzi <agarzi(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-25T10:21:13+01:00 fix typo on sanity checks module (cherry picked from commit 3b48fff143b49f16b328475a7b26017209e98666) --- Modified: src/modules/sanity/sanity.c --- Diff: https://github.com/kamailio/kamailio/commit/ecb00946bf684b4c8405d71fe9306d3… Patch: https://github.com/kamailio/kamailio/commit/ecb00946bf684b4c8405d71fe9306d3… --- diff --git a/src/modules/sanity/sanity.c b/src/modules/sanity/sanity.c index 582a1aaada0..8059866c428 100644 --- a/src/modules/sanity/sanity.c +++ b/src/modules/sanity/sanity.c @@ -813,7 +813,7 @@ int check_parse_uris(sip_msg_t *msg, int checks) if(!msg->to || !msg->to->body.s) { msg->msg_flags |= FL_MSG_NOREPLY; } else { - if(sanity_reply(msg, 400, "Ivalid To Header") < 0) { + if(sanity_reply(msg, 400, "Invalid To Header") < 0) { LM_WARN("failed to send 400 via sl reply (missing To)\n"); } }

1 0

git:master:3b48fff1: fix typo on sanity checks module
by Victor Seva 25 Mar '25

25 Mar '25

Module: kamailio Branch: master Commit: 3b48fff143b49f16b328475a7b26017209e98666 URL: https://github.com/kamailio/kamailio/commit/3b48fff143b49f16b328475a7b26017… Author: Alessio Garzi <agarzi(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-25T10:19:59+01:00 fix typo on sanity checks module --- Modified: src/modules/sanity/sanity.c --- Diff: https://github.com/kamailio/kamailio/commit/3b48fff143b49f16b328475a7b26017… Patch: https://github.com/kamailio/kamailio/commit/3b48fff143b49f16b328475a7b26017… --- diff --git a/src/modules/sanity/sanity.c b/src/modules/sanity/sanity.c index 582a1aaada0..8059866c428 100644 --- a/src/modules/sanity/sanity.c +++ b/src/modules/sanity/sanity.c @@ -813,7 +813,7 @@ int check_parse_uris(sip_msg_t *msg, int checks) if(!msg->to || !msg->to->body.s) { msg->msg_flags |= FL_MSG_NOREPLY; } else { - if(sanity_reply(msg, 400, "Ivalid To Header") < 0) { + if(sanity_reply(msg, 400, "Invalid To Header") < 0) { LM_WARN("failed to send 400 via sl reply (missing To)\n"); } }

1 0

[kamailio/kamailio] Migrate to C23 (Issue #4106)
by soroshsabz 25 Mar '25

25 Mar '25

ITNOA As you can see many defects resolve in [C17](https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2244.htm) and [C23](https://en.wikipedia.org/wiki/C23_(C_standard_revision) introduce many new language features for clean coding. So I suggest migrate codebase to C23, and if you agree with me, I can try to migrate that -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4106 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4106(a)github.com>

5 14

[kamailio/kamailio] cmake: Add Windows support (Issue #4109)
by soroshsabz 25 Mar '25

25 Mar '25

ITNOA I suggest port Kamailio to windows, if you agree with me, I can try to port that -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4109 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4109(a)github.com>

2 2

[kamailio/kamailio] Commands of old makefiles with cmake (Issue #4052)
by Daniel-Constantin Mierla 24 Mar '25

24 Mar '25

Opening this generic issue to track how some commands from old Makefiles can be done when using the new CMake-based build system, or what the possible alternatives. Hopefully we can build some knowledge here that can be then transferred to the wiki cmake tutorials. ### Compiling core only With the old makefiles, the `make` compiled only the core of Kamailio. With cmake, `make` compiles everything. Would it be possible to have a command with cmake that compiles only the core? Like: ``` make core ``` Or maybe there is a way to do it already?!? ### Compile a single module With the old makefiles, compiling a single module, say acc, was possible with: ``` make modules modules=src/modules/acc ``` With cmake, this is possible with: ``` make acc ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4052 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4052(a)github.com>

4 11

[kamailio/kamailio] Dialog: Timeout/dlg_bye randomly doesn't send BYE message (Issue #4169)
by Mercury109 24 Mar '25

24 Mar '25

Mercury109 created an issue (kamailio/kamailio#4169) ### Description I loop through the active dialogs in a timer functions and based on some conditions, a dialog may be ended by setting a short timeout or using the dlg_bye function. **Sometimes** when a dialog times out or the dlg_bye("all") function is used, the BYE is not being sent in both directions, only towards the caller. There's a warning: send_bye(): dlg [25641:71143] with callid XXXXXXXXX already in deleted state, BYE not sent. I noticed this check was added in the commit below: https://github.com/kamailio/kamailio/commit/d411c6ea4358e6d9dd367349e877ed5… Is there a race condition between marking the dialog as terminated and sending the BYE? Not sending a BYE towards the callee when it should is much worse than sending an unnecessary BYE as it causes billing issues. If this can't be resolved to be 100% reliable, it's safer to remove this check all together. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.6 (x86_64/linux)) ``` * **Operating System**: Debian GNU/Linux 12 (bookworm) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4169 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4169(a)github.com>

3 5

[kamailio/kamailio] Typo (PR #4183)
by Alessio Garzi 24 Mar '25

24 Mar '25

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4183 -- Commit Summary -- * lcr: add counters per gateway * lcr: add counters per gateway documentation * Typo on sanity module error -- File Changes -- M src/modules/lcr/doc/lcr_admin.xml (58) M src/modules/lcr/lcr_mod.c (306) M src/modules/lcr/lcr_mod.h (52) M src/modules/lcr/lcr_rpc.c (460) M src/modules/sanity/sanity.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4183.patch https://github.com/kamailio/kamailio/pull/4183.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4183 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4183(a)github.com>

1 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev