sr-dev

sr-dev@lists.kamailio.org

13 participants
44200 discussions

git:master:824e8131: topos: catch ACK without contact that needs no storage updates

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 824e81319b60054feb81c37b3a8be80523f8c95d URL: https://github.com/kamailio/kamailio/commit/824e81319b60054feb81c37b3a8be80… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-23T08:22:14+02:00 topos: catch ACK without contact that needs no storage updates --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/824e81319b60054feb81c37b3a8be80… Patch: https://github.com/kamailio/kamailio/commit/824e81319b60054feb81c37b3a8be80… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index 946092c04f9..1fe7319b926 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -594,6 +594,12 @@ int tps_storage_record(sip_msg_t *msg, tps_data_t *td, int dialog, int dir) str suid; str *sx = NULL; + if(get_cseq(msg)->method_id == METHOD_ACK) { + if(parse_headers(msg, HDR_CONTACT_F, 0) < 0 || msg->contact == NULL) { + /* ACK with no Contact - nothing to store */ + return 0; + } + } if(_tps_context_value.len > 0) { sx = &_tps_context_value; } else if(_tps_context_param.len > 0) {

2 months, 2 weeks

git:master:a6b924be: topos: extended error log message

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: a6b924be7fd7d4ce6a92ad5a0247077b09a29474 URL: https://github.com/kamailio/kamailio/commit/a6b924be7fd7d4ce6a92ad5a0247077… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-23T08:22:14+02:00 topos: extended error log message - ensure headers are parsed for storage record --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/a6b924be7fd7d4ce6a92ad5a0247077… Patch: https://github.com/kamailio/kamailio/commit/a6b924be7fd7d4ce6a92ad5a0247077… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index 1fe7319b926..e87232285f6 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -594,6 +594,10 @@ int tps_storage_record(sip_msg_t *msg, tps_data_t *td, int dialog, int dir) str suid; str *sx = NULL; + if(parse_headers(msg, HDR_EOH_F, 0) == -1) { + return -1; + } + if(get_cseq(msg)->method_id == METHOD_ACK) { if(parse_headers(msg, HDR_CONTACT_F, 0) < 0 || msg->contact == NULL) { /* ACK with no Contact - nothing to store */ @@ -649,7 +653,8 @@ int tps_storage_record(sip_msg_t *msg, tps_data_t *td, int dialog, int dir) return 0; error: - LM_ERR("failed to store\n"); + LM_ERR("failed to store (dlg: %d dir: %d metid: %d)\n", dialog, dir, + get_cseq(msg)->method_id); return ret; }

2 months, 2 weeks

[kamailio/kamailio] nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! (Issue #4005)

by Md. Mostafijur Rahman

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: INVITE from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to sip:voc_106@sip-pd.cleverstack.in -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:wss Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine offer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3050]: INFO: {2 1 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 407 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3050]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: FS_FAULT Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 ACK udfal237dcbsaao5u84v} <script>: ACK from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: INVITE from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to sip:voc_106@sip-pd.cleverstack.in -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:wss Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine offer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3046]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 100 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 183 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to <null> -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:udp Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine answer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: ERROR: {2 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: ERROR: {2 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: INVITE from: sip:voc_104@51.79.190.145 (IP:51.79.190.145:5062) to: sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg , ru=sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: SOURCE_CLASSIFY: request INVITE from FS Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: FS_TO_KAM || sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg || sip:voc_104@51.79.190.145 --> sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: FS_TO_KAM || looking for registered extension Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: LOCATION sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: LOCATION || exturl = sip:voc_106@sip-dev.cleverstack.in Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Branch [0] to sip:g321jqm6@14gassrhfn7h.invalid;transport=ws;lhst=103.133.141.52:53161;lm=midreg -- FLAGS: 8320 Checking Conditions Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Source Protocol:udp Destination Protocol: WS Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Saving RtpEngine ID: 4 into SIP R-Route params Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:4) RTP-Engine offer: trust-address replace-origin replace-session-connection rtcp-mux-offer DTLS=passive SDES-off ICE=force RTP/SAVPF via-branch=extra DTLS-fingerprint=sha-256 Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=36 callid=1cd1065f-aec7-4360-8631-3198d673c841 Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: WARNING: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/forward.c:231]: get_send_socket2(): protocol/port mismatch (forced udp:51.79.190.145:5560, to ws:103.133.141.52:53161) Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: WARNING: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/msg_translator.c:2864]: via_builder(): TCP/TLS connection (id: 0) for WebSocket could not be found Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/msg_translator.c:2040]: build_req_buf_from_sip_req(): could not create Via header Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} tm [t_fwd.c:479]: prepare_new_uac(): could not build request Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} tm [t_fwd.c:1757]: t_forward_nonack(): failure to add branches Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} sl [sl_funcs.c:418]: sl_reply_error(): stateless error reply used: No error (2/SL) Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3043]: INFO: {1 90260957 ACK 1cd1065f-aec7-4360-8631-3198d673c841} <script>: ACK from: sip:voc_104@51.79.190.145 (IP:51.79.190.145:5062) to: sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg , ru=sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3043]: INFO: {1 90260957 ACK 1cd1065f-aec7-4360-8631-3198d673c841} <script>: SOURCE_CLASSIFY: request ACK from FS ``` #### Log Messages  ``` Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: INVITE from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to sip:voc_106@sip-pd.cleverstack.in -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:wss Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine offer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3050]: INFO: {2 1 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 407 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3050]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: FS_FAULT Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 ACK udfal237dcbsaao5u84v} <script>: ACK from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: INVITE from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to sip:voc_106@sip-pd.cleverstack.in -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:wss Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine offer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3046]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 100 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 183 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to <null> -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:udp Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine answer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: ERROR: {2 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: ERROR: {2 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: INVITE from: sip:voc_104@51.79.190.145 (IP:51.79.190.145:5062) to: sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg , ru=sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: SOURCE_CLASSIFY: request INVITE from FS Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: FS_TO_KAM || sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg || sip:voc_104@51.79.190.145 --> sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: FS_TO_KAM || looking for registered extension Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: LOCATION sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: LOCATION || exturl = sip:voc_106@sip-dev.cleverstack.in Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Branch [0] to sip:g321jqm6@14gassrhfn7h.invalid;transport=ws;lhst=103.133.141.52:53161;lm=midreg -- FLAGS: 8320 Checking Conditions Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Source Protocol:udp Destination Protocol: WS Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Saving RtpEngine ID: 4 into SIP R-Route params Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:4) RTP-Engine offer: trust-address replace-origin replace-session-connection rtcp-mux-offer DTLS=passive SDES-off ICE=force RTP/SAVPF via-branch=extra DTLS-fingerprint=sha-256 Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=36 callid=1cd1065f-aec7-4360-8631-3198d673c841 Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: WARNING: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/forward.c:231]: get_send_socket2(): protocol/port mismatch (forced udp:51.79.190.145:5560, to ws:103.133.141.52:53161) Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: WARNING: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/msg_translator.c:2864]: via_builder(): TCP/TLS connection (id: 0) for WebSocket could not be found Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/msg_translator.c:2040]: build_req_buf_from_sip_req(): could not create Via header Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} tm [t_fwd.c:479]: prepare_new_uac(): could not build request Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} tm [t_fwd.c:1757]: t_forward_nonack(): failure to add branches Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} sl [sl_funcs.c:418]: sl_reply_error(): stateless error reply used: No error (2/SL) Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3043]: INFO: {1 90260957 ACK 1cd1065f-aec7-4360-8631-3198d673c841} <script>: ACK from: sip:voc_104@51.79.190.145 (IP:51.79.190.145:5062) to: sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg , ru=sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3043]: INFO: {1 90260957 ACK 1cd1065f-aec7-4360-8631-3198d673c841} <script>: SOURCE_CLASSIFY: request ACK from FS ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 5.3.9 ``` * **Operating System**:  ``` Centos7 & Debian 12 both have same issue ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4005 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4005(a)github.com>

2 months, 2 weeks

[kamailio/kamailio] [JWT Module] Failed to decode JWT value (Issue #4003)

by Lyuboslav Alexandrov

2 months, 3 weeks

git:master:9ee18988: pipelimit: use core str comparison functions

by Victor Seva

Module: kamailio Branch: master Commit: 9ee189883549faffb21d3ae113dafd7ad95757af URL: https://github.com/kamailio/kamailio/commit/9ee189883549faffb21d3ae113dafd7… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-22T16:45:35+02:00 pipelimit: use core str comparison functions --- Modified: src/modules/pipelimit/pl_ht.h --- Diff: https://github.com/kamailio/kamailio/commit/9ee189883549faffb21d3ae113dafd7… Patch: https://github.com/kamailio/kamailio/commit/9ee189883549faffb21d3ae113dafd7… --- diff --git a/src/modules/pipelimit/pl_ht.h b/src/modules/pipelimit/pl_ht.h index 8ee6568ea69..86eab1092dc 100644 --- a/src/modules/pipelimit/pl_ht.h +++ b/src/modules/pipelimit/pl_ht.h @@ -98,16 +98,6 @@ typedef struct str_map extern str_map_t algo_names[]; -static inline int str_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncmp(a->s, b->s, a->len)); -} - -static inline int str_i_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncasecmp(a->s, b->s, a->len)); -} - /** * converts a mapped str to an int * \return 0 if found, -1 otherwise @@ -115,7 +105,7 @@ static inline int str_i_cmp(const str *a, const str *b) static inline int str_map_str(const str_map_t *map, const str *key, int *ret) { for(; map->str.s; map++) - if(!str_i_cmp(&map->str, key)) { + if(!str_strcasecmp(&map->str, key)) { *ret = map->id; return 0; }

2 months, 3 weeks

git:master:c67d8fa0: lrkproxy: use core str comparison functions and macros

by Victor Seva

Module: kamailio Branch: master Commit: c67d8fa0b1015d73b34430f6f8a6afe22ca10cbe URL: https://github.com/kamailio/kamailio/commit/c67d8fa0b1015d73b34430f6f8a6afe… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-22T16:45:35+02:00 lrkproxy: use core str comparison functions and macros --- Modified: src/modules/lrkproxy/lrkproxy_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/c67d8fa0b1015d73b34430f6f8a6afe… Patch: https://github.com/kamailio/kamailio/commit/c67d8fa0b1015d73b34430f6f8a6afe… --- diff --git a/src/modules/lrkproxy/lrkproxy_hash.c b/src/modules/lrkproxy/lrkproxy_hash.c index dc0b365eed6..7daeb6596b1 100644 --- a/src/modules/lrkproxy/lrkproxy_hash.c +++ b/src/modules/lrkproxy/lrkproxy_hash.c @@ -34,24 +34,6 @@ static void lrkproxy_hash_table_free_row_lock(gen_lock_t *row_lock); static struct lrkproxy_hash_table *lrkproxy_hash_table; -/* get from sipwise rtpengine */ -static int str_cmp_str(const str a, const str b) -{ - if(a.len < b.len) - return -1; - if(a.len > b.len) - return 1; - if(a.len == 0 && b.len == 0) - return 0; - return memcmp(a.s, b.s, a.len); -} - -/* get from sipwise rtpengine */ -static int str_equal(str a, str b) -{ - return (str_cmp_str(a, b) == 0); -} - /* get from sipwise rtpengine */ static unsigned int str_hash(str s) { @@ -321,8 +303,8 @@ int lrkproxy_hash_table_insert( while(entry) { // if found, don't add new entry - if(str_equal(entry->callid, new_entry->callid) - && str_equal(entry->viabranch, new_entry->viabranch)) { + if(STR_EQ(entry->callid, new_entry->callid) + && STR_EQ(entry->viabranch, new_entry->viabranch)) { // unlock lock_release(lrkproxy_hash_table->row_locks[hash_index]); LM_NOTICE("callid=%.*s, viabranch=%.*s already in hashtable, " @@ -403,13 +385,13 @@ int lrkproxy_hash_table_remove(str callid, str viabranch, enum lrk_operation op) viabranch.len, viabranch.s, entry->viabranch.len, entry->viabranch.s); // if callid found, delete entry - if((str_equal(entry->callid, callid) - && str_equal(entry->viabranch, viabranch)) - || (str_equal(entry->callid, callid) && viabranch.len == 0 + if((STR_EQ(entry->callid, callid) + && STR_EQ(entry->viabranch, viabranch)) + || (STR_EQ(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE) - || str_equal(entry->callid, callid)) { - // if ((str_equal(entry->callid, callid) && str_equal(entry->viabranch, viabranch)) || - // (str_equal(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE)) { + || STR_EQ(entry->callid, callid)) { + // if ((STR_EQ(entry->callid, callid) && STR_EQ(entry->viabranch, viabranch)) || + // (STR_EQ(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE)) { // set pointers; exclude entry // set pointers; exclude entry @@ -496,10 +478,10 @@ struct lrkproxy_hash_entry *lrkproxy_hash_table_lookup( while(entry) { // if callid found, return entry - if((str_equal(entry->callid, callid) - && str_equal(entry->viabranch, viabranch)) - || (str_equal(entry->callid, callid) && viabranch.len == 0) - || str_equal(entry->callid, callid)) { + if((STR_EQ(entry->callid, callid) + && STR_EQ(entry->viabranch, viabranch)) + || (STR_EQ(entry->callid, callid) && viabranch.len == 0) + || STR_EQ(entry->callid, callid)) { // node = entry->node; // unlock

2 months, 3 weeks

git:master:ef9fa6fb: rtpengine: use core str comparison functions and macros

by Victor Seva

Module: kamailio Branch: master Commit: ef9fa6fb34859890afef70fc3803de360979e213 URL: https://github.com/kamailio/kamailio/commit/ef9fa6fb34859890afef70fc3803de3… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-22T16:45:34+02:00 rtpengine: use core str comparison functions and macros --- Modified: src/modules/rtpengine/rtpengine.c Modified: src/modules/rtpengine/rtpengine_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/ef9fa6fb34859890afef70fc3803de3… Patch: https://github.com/kamailio/kamailio/commit/ef9fa6fb34859890afef70fc3803de3… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index e31feb3ceeb..e04bb5e9fb3 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -859,11 +859,6 @@ static int bind_force_send_ip(int sock_idx) return 0; } -static inline int str_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncmp(a->s, b->s, a->len)); -} - static inline int str_eq(const str *p, const char *q) { int l = strlen(q); @@ -963,7 +958,7 @@ struct rtpp_node *get_rtpp_node(struct rtpp_set *rtpp_list, str *url) lock_get(rtpp_list->rset_lock); rtpp_node = rtpp_list->rn_first; while(rtpp_node) { - if(str_cmp(&rtpp_node->rn_url, url) == 0) { + if(str_strcmp(&rtpp_node->rn_url, url) == 0) { lock_release(rtpp_list->rset_lock); return rtpp_node; } @@ -4247,7 +4242,7 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, if(!bencode_dictionary_get_str(tag_dict, "label", &check)) continue; LM_DBG("rtpengine: XXX got label %.*s\n", check.len, check.s); - if(str_cmp(&check, &label)) + if(str_strcmp(&check, &label)) continue; LM_DBG("rtpengine: XXX label match\n"); medias = @@ -5800,4 +5795,4 @@ static int bind_rtpengine(rtpengine_api_t *api) api->rtpengine_delete = ki_rtpengine_delete; return 0; -} \ No newline at end of file +} diff --git a/src/modules/rtpengine/rtpengine_hash.c b/src/modules/rtpengine/rtpengine_hash.c index de6dbc9d5ed..2c7f8f2f0ba 100644 --- a/src/modules/rtpengine/rtpengine_hash.c +++ b/src/modules/rtpengine/rtpengine_hash.c @@ -11,24 +11,6 @@ static void rtpengine_hash_table_free_row_lock(gen_lock_t *row_lock); static struct rtpengine_hash_table *rtpengine_hash_table; -/* from sipwise rtpengine */ -static int str_cmp_str(const str a, const str b) -{ - if(a.len < b.len) - return -1; - if(a.len > b.len) - return 1; - if(a.len == 0 && b.len == 0) - return 0; - return memcmp(a.s, b.s, a.len); -} - -/* from sipwise rtpengine */ -static int str_equal(str a, str b) -{ - return (str_cmp_str(a, b) == 0); -} - /* from sipwise rtpengine */ static unsigned int str_hash(str s) { @@ -254,8 +236,8 @@ int rtpengine_hash_table_insert( while(entry) { // if found, don't add new entry - if(str_equal(entry->callid, new_entry->callid) - && str_equal(entry->viabranch, new_entry->viabranch)) { + if(STR_EQ(entry->callid, new_entry->callid) + && STR_EQ(entry->viabranch, new_entry->viabranch)) { // unlock lock_release(rtpengine_hash_table->row_locks[hash_index]); LM_NOTICE("callid=%.*s, viabranch=%.*s already in hashtable, " @@ -324,9 +306,9 @@ int rtpengine_hash_table_remove( while(entry) { // if callid found, delete entry - if((str_equal(entry->callid, callid) - && str_equal(entry->viabranch, viabranch)) - || (str_equal(entry->callid, callid) && viabranch.len == 0 + if((STR_EQ(entry->callid, callid) + && STR_EQ(entry->viabranch, viabranch)) + || (STR_EQ(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE)) { // set pointers; exclude entry last_entry->next = entry->next; @@ -407,9 +389,9 @@ struct rtpp_node *rtpengine_hash_table_lookup( while(entry) { // if callid found, return entry - if((str_equal(entry->callid, callid) - && str_equal(entry->viabranch, viabranch)) - || (str_equal(entry->callid, callid) && viabranch.len == 0 + if((STR_EQ(entry->callid, callid) + && STR_EQ(entry->viabranch, viabranch)) + || (STR_EQ(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE)) { node = entry->node;

2 months, 3 weeks

git:master:c44a3499: ratelimit: use core str comparison functions

by Victor Seva

Module: kamailio Branch: master Commit: c44a349964081d397ab9efa3504737bf369f8cf5 URL: https://github.com/kamailio/kamailio/commit/c44a349964081d397ab9efa3504737b… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-22T16:45:35+02:00 ratelimit: use core str comparison functions --- Modified: src/modules/ratelimit/ratelimit.c --- Diff: https://github.com/kamailio/kamailio/commit/c44a349964081d397ab9efa3504737b… Patch: https://github.com/kamailio/kamailio/commit/c44a349964081d397ab9efa3504737b… --- diff --git a/src/modules/ratelimit/ratelimit.c b/src/modules/ratelimit/ratelimit.c index 5cac92464db..295102bd08e 100644 --- a/src/modules/ratelimit/ratelimit.c +++ b/src/modules/ratelimit/ratelimit.c @@ -60,9 +60,6 @@ MODULE_VERSION #define RXL(m, str, i) (int)((m)[i].rm_eo - (m)[i].rm_so) #define RXS(m, str, i) (str) + (m)[i].rm_so -static inline int str_cmp(const str *a, const str *b); -static inline int str_i_cmp(const str *a, const str *b); - typedef struct str_map { str str; @@ -256,7 +253,7 @@ struct module_exports exports = { static int str_map_str(const str_map_t *map, const str *key, int *ret) { for(; map->str.s; map++) - if(!str_cmp(&map->str, key)) { + if(!str_strcmp(&map->str, key)) { *ret = map->id; return 0; } @@ -704,16 +701,6 @@ static void destroy(void) } -static inline int str_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncmp(a->s, b->s, a->len)); -} - -static inline int str_i_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncasecmp(a->s, b->s, a->len)); -} - str queue_other = str_init("*"); /** @@ -727,10 +714,10 @@ static int find_queue(struct sip_msg *msg, str *method, int *queue) *queue = -1; for(i = 0; i < *nqueues; i++) - if(!str_i_cmp(queues[i].method, method)) { + if(!str_strcasecmp(queues[i].method, method)) { *queue = i; return 0; - } else if(!str_i_cmp(queues[i].method, &queue_other)) { + } else if(!str_strcasecmp(queues[i].method, &queue_other)) { *queue = i; }

2 months, 3 weeks

[kamailio/kamailio] rtpengine: use core STR_EQ macro (PR #4004)

by Victor Seva

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally #### Description don't reinvent the wheel and just use core macro You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4004 -- Commit Summary -- * rtpengine: use core STR_EQ macro -- File Changes -- M src/modules/rtpengine/rtpengine.c (11) M src/modules/rtpengine/rtpengine_hash.c (34) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4004.patch https://github.com/kamailio/kamailio/pull/4004.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4004 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4004(a)github.com>

2 months, 3 weeks

[kamailio/kamailio] [WIP] ims_registrar_scscf: fixing em_max_expires (PR #3989)

by Dragos Vingarzan

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  In case of Emergency-Registrations the S-CSCF was wrongly setting the expires of the `;sos` contacts to `em_min_expires` if they were above `em_max_expires`. Other smaller related fixes: - Fixed also another typo in the config params definition. - Added some code to more easily make sense of which attributes of a struct are set with what. - Added conditions to respect the parameter documentation which indicate that if set to 0, the expires conditions won't be used. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3989 -- Commit Summary -- * ims_registrar_scscf: fixing em_max_expires -- File Changes -- M src/modules/ims_registrar_scscf/config.c (26) M src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c (2) M src/modules/ims_registrar_scscf/save.c (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3989.patch https://github.com/kamailio/kamailio/pull/3989.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3989 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3989(a)github.com>

2 months, 3 weeks

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev