sr-dev

sr-dev@lists.kamailio.org

13 participants
44200 discussions

[kamailio/kamailio] p-charging-vector bug in siputils with force flag (Issue #3929)

by Michael

### Description I used sip_p_charging_vector() function of siputils with flag f (remove + generate). This function works fine if call is received without a P-Charging-Vector and only generate needs to be done. But if the INVITE already contains a P-Charging-Vector and this vector needs to be removed and replaced by a new generated P-Charging-Vector the output is messed up. The sip_p_charging_vector() function with flag r (remove) works fine too. P-Charging-Vector is removed if INVITE contains one. So for me this looks like an issue with the combination of remove + generate. See SIP Traffic attached. The "old" P-Charging-Vector is not deleted and additionaly instead of a new P-Charging-Vector the "old" P-Charging-Vector is added again above SDP. Also some part of the next line "Session-Exp" is added and "TH: dih". ----- TH: dih icid-value=0d702d06-5700-103e-00-00-00-10-6b-03-dd-04;icid-generated-at=213.xxx.xxx.xxx Session-Exp ----- ### Troubleshooting #### Reproduction It looks like the issue is triggered always a p-charging-vector is received by kamailio and sip_p_charging_vector() with flag f is called. #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic ``` **This message is received by kamailio (Incoming):** INVITE sip:+49xxxxxxxx;npdi;rn=+49xxxxxxxx@bob.com:5060;user=phone SIP/2.0 Via: SIP/2.0/UDP 213.xxx.xxx.xxx:5060;branch=z9hG4bK08Bf3722bac16f3e05b From: <sip:+43xxxxxxxx@alice.com;user=phone>;tag=gK085abca7 To: <sip:+49xxxxxxxx0@92.xxx.xxx.xxx:5060;user=phone> Call-ID: 168341746_132086108(a)213.xxx.xxx.xxx CSeq: 373279 INVITE Max-Forwards: 67 Allow: INVITE,ACK,CANCEL,BYE,REGISTER,REFER,INFO,SUBSCRIBE,NOTIFY,PRACK,UPDATE,OPTIONS,MESSAGE,PUBLISH Accept: application/sdp, application/isup, application/dtmf, application/dtmf-relay, multipart/mixed Contact: <sip:+43xxxxxxxx@213.xxx.xxx.xxx:5060> P-Asserted-Identity: <sip:+43xxxxxxxx@alice.com:5060;user=phone> Supported: timer,100rel,histinfo P-Charging-Vector: icid-value=0d702d06-5700-103e-00-00-00-10-6b-03-dd-04;icid-generated-at=213.xxx.xxx.xxx Session-Expires: 1800 Min-SE: 90 Content-Length: 236 Content-Disposition: session; handling=required Content-Type: application/sdp v=0 o=Sonus_UAC 278609 22801 IN IP4 213.xxx.xxx.xxx s=SIP Media Capabilities c=IN IP4 213.xxx.xxx.xxx t=0 0 m=audio 29020 RTP/AVP 8 101 a=rtpmap:8 PCMA/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-15 a=sendrecv a=ptime:20 **This message is send out by kamailio (outgoing):** INVITE sip:+49xxxxxxxx;npdi;rn=+49xxxxxxxx@bob.com:5060;user=phone SIP/2.0 Record-Route: <sip:172.xxx.xxx.xxx;r2=on;lr=on;ftag=gK085abca7> Record-Route: <sip:92.xxx.xxx.xxx9;r2=on;lr=on;ftag=gK085abca7> Via: SIP/2.0/UDP 172.xxx.xxx.xxx;branch=z9hG4bKc451.940fa2c220f96c1ef968de3c156db262.0 Via: SIP/2.0/UDP 213.xxx.xxx.xxx:5060;TH=div;branch=z9hG4bK08Bf3722bac16f3e05b From: <sip:+43xxxxxxxx@alice.com;user=phone>;tag=gK085abca7 To: <sip:+49xxxxxxxx@92.xxx.xxx.xxx:5060;user=phone> Call-ID: 168341746_132086108(a)213.xxx.xxx.xxx CSeq: 373279 INVITE Max-Forwards: 66 Allow: INVITE,ACK,CANCEL,BYE,REGISTER,REFER,INFO,SUBSCRIBE,NOTIFY,PRACK,UPDATE,OPTIONS,MESSAGE,PUBLISH Accept: application/sdp, application/isup, application/dtmf, application/dtmf-relay, multipart/mixed Contact: <sip:+43xxxxxxxx@213.xxx.xxx.xxx:5060> P-Asserted-Identity: <sip:+43xxxxxxxx@alice.com:5060;user=phone> Supported: timer,100rel,histinfo P-Charging-Vector: icid-value=0d702d06-5700-103e-00-00-00-10-6b-03-dd-04;icid-generated-at=213.xxx.xxx.xxx Session-Expires: 1800 Min-SE: 90 Content-Length: 252 Content-Disposition: session; handling=required Content-Type: application/sdp **_TH: dih icid-value=0d702d06-5700-103e-00-00-00-10-6b-03-dd-04;icid-generated-at=213.xxx.xxx.xxx Session-Exp_** v=0 o=Sonus_UAC 278609 22801 IN IP4 92.xxx.xxx.xxx s=SIP Media Capabilities c=IN IP4 92.xxx.xxx.xxx t=0 0 m=audio 34622 RTP/AVP 8 101 a=rtpmap:8 PCMA/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-15 a=sendrecv a=rtcp:34623 a=ptime:20 ``` ### Additional Information ``` version: kamailio 5.8.2 (x86_64/linux) 3fa5f4 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 3fa5f4 compiled on 15:54:29 Jul 22 2024 with gcc 10.2.1 ``` * **Operating System**: ``` Debian GNU/Linux 11 5.10.0-26-amd64 #1 SMP Debian 5.10.197-1 (2023-09-29) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3929 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3929(a)github.com>

2 months, 2 weeks

git:master:ad919796: timer: export timer_enable(...) to kemi

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ad919796b24d0c38af136cbad2563e6f98df4b74 URL: https://github.com/kamailio/kamailio/commit/ad919796b24d0c38af136cbad2563e6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-29T06:52:22+01:00 timer: export timer_enable(...) to kemi - GH #4008 --- Modified: src/modules/timer/timer.c --- Diff: https://github.com/kamailio/kamailio/commit/ad919796b24d0c38af136cbad2563e6… Patch: https://github.com/kamailio/kamailio/commit/ad919796b24d0c38af136cbad2563e6… --- diff --git a/src/modules/timer/timer.c b/src/modules/timer/timer.c index 5cb92a8847c..e31ede94903 100644 --- a/src/modules/timer/timer.c +++ b/src/modules/timer/timer.c @@ -306,6 +306,19 @@ static int timer_enable_func(sip_msg_t *m, char *timer_act, char *enable) return timer_enable_helper(m, a, en); } +static int ki_timer_enable(sip_msg_t *m, str *timerid, int enable) +{ + timer_action_t *a; + + a = find_action_by_name(timer_actions, timerid->s, -1); + if(!a) { + LM_ERR("timer '%s' not declared\n", timerid->s); + return -1; + } + + return timer_enable_helper(m, a, enable); +} + static int get_next_part(char **s, str *part, char delim) { char *c, *c2; @@ -522,3 +535,27 @@ struct module_exports exports = { destroy_mod /* destroy function */ }; /* clang-format on */ + + +/** + * + */ +/* clang-format off */ +static sr_kemi_t sr_kemi_timer_exports[] = { + { str_init("timer"), str_init("timer_enable"), + SR_KEMIP_INT, ki_timer_enable, + { SR_KEMIP_STR, SR_KEMIP_INT, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } +}; +/* clang-format on */ + +/** + * + */ +int mod_register(char *path, int *dlflags, void *p1, void *p2) +{ + sr_kemi_modules_add(sr_kemi_timer_exports); + return 0; +}

2 months, 2 weeks

git:master:79d7fae0: core: parser sdp - check body end for extract_ice_option()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 79d7fae0f26f577356f017cfff5e00c348cf259c URL: https://github.com/kamailio/kamailio/commit/79d7fae0f26f577356f017cfff5e00c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-29T08:20:44+01:00 core: parser sdp - check body end for extract_ice_option() --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/79d7fae0f26f577356f017cfff5e00c… Patch: https://github.com/kamailio/kamailio/commit/79d7fae0f26f577356f017cfff5e00c… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 0e61fe5ca5d..5c7076823c4 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -379,22 +379,24 @@ int extract_ice_option(str *body, sdp_stream_cell_t *stream) sdp_ice_opt_t *ice_opt; char *ptr_src; + char *end; int max_options = 10; /* protection - max options can be listed in one line */ int length = 0; /* each option length */ /* a=ice-options: */ - if((body->len < 14) || (strncasecmp(body->s, ICE_OPTIONS, 14) != 0)) + if((body->len <= 14) || (strncasecmp(body->s, ICE_OPTIONS, 14) != 0)) return -1; + end = body->s + body->len; ptr_src = body->s + 14; if(*ptr_src == 32) ptr_src++; /* if starts with a space, skip it */ /* identify all existing ICE options, if they are listed in one row */ - while(*ptr_src && *ptr_src != '\r' && *ptr_src != '\n' + while(ptr_src < end && *ptr_src && *ptr_src != '\r' && *ptr_src != '\n' && max_options-- > 0) { - while(*ptr_src != 32 && *ptr_src && *ptr_src != '\r' + while(ptr_src < end && *ptr_src && *ptr_src != 32 && *ptr_src != '\r' && *ptr_src != '\n') { length++; ptr_src++;

2 months, 2 weeks

rtpengine module: Question about re-enabling nodes

by Christian Berger

Hi, we had strange behavior with kamailio when some rtpengines were unreachable, so we looked into the the source code and found this in select_rtpp_node_new(): 3323 /* Try to enable if it's time to try. */ 3324 if(node->rn_disabled && node->rn_recheck_ticks <= get_ticks()) { 3325 node->rn_disabled = rtpp_test(node, 1, 0); 3326 } Does this mean that a ping will be done during rtpengine manage? Is this wise? I mean there are dedicated pings in the background. Doing this in rtpengine manage will only periodically delay the processing of a SIP message. We fear that in high traffic situations this could occupy all threads. Is this a bug? As a workaround we think setting rtpengine_tout_ms to a lower value might help as it shortens the amount of time the module delays the processing of the SIP message. What do you think? Best wishes Christian Berger -- Christian Berger - berger(a)sipgate.de Telefon: +49 (0)211-63 55 55-0 Telefax: +49 (0)211-63 55 55-22 sipgate GmbH - Gladbacher Str. 74 - 40219 Düsseldorf HRB Düsseldorf 39841 - Geschäftsführer: Thilo Salmon, Tim Mois Steuernummer: 106/5724/7147, Umsatzsteuer-ID: DE219349391 www.sipgate.de - www.sipgate.co.uk

2 months, 2 weeks

git:master:a4f0ee5d: topos: deal with BYE without contact header for mode 1

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: a4f0ee5da93ad64d449c7a95ecad2f3d70aeb975 URL: https://github.com/kamailio/kamailio/commit/a4f0ee5da93ad64d449c7a95ecad2f3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-28T06:33:28+01:00 topos: deal with BYE without contact header for mode 1 --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/a4f0ee5da93ad64d449c7a95ecad2f3… Patch: https://github.com/kamailio/kamailio/commit/a4f0ee5da93ad64d449c7a95ecad2f3… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index e87232285f6..b0658da36a1 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -297,33 +297,40 @@ int tps_storage_fill_contact( /* extract the contact address */ if(parse_headers(msg, HDR_CONTACT_F, 0) < 0 || msg->contact == NULL) { - LM_WARN("bad sip message or missing Contact hdr\n"); - return -1; - } - if(parse_contact(msg->contact) < 0 - || ((contact_body_t *)msg->contact->parsed)->contacts - == NULL - || ((contact_body_t *)msg->contact->parsed) - ->contacts->next - != NULL) { - LM_ERR("bad Contact header\n"); - return -1; + if(get_cseq(msg)->method_id != METHOD_BYE) { + LM_WARN("bad sip message or missing Contact header\n"); + return -1; + } else { + LM_DBG("BYE with no contact - skipping it\n"); + } } - if(parse_uri(((contact_body_t *)msg->contact->parsed) - ->contacts->uri.s, - ((contact_body_t *)msg->contact->parsed) - ->contacts->uri.len, - &curi) - < 0) { - LM_ERR("failed to parse the contact uri\n"); - return -1; - } - if(curi.user.len > 0) { - memcpy(td->cp, curi.user.s, curi.user.len); - td->cp += curi.user.len; - cuser_len = curi.user.len; - } else { - LM_DBG("no contact user - skipping it\n"); + if(msg->contact != NULL) { + if(parse_contact(msg->contact) < 0 + || ((contact_body_t *)msg->contact->parsed) + ->contacts + == NULL + || ((contact_body_t *)msg->contact->parsed) + ->contacts->next + != NULL) { + LM_ERR("bad Contact header\n"); + return -1; + } + if(parse_uri(((contact_body_t *)msg->contact->parsed) + ->contacts->uri.s, + ((contact_body_t *)msg->contact->parsed) + ->contacts->uri.len, + &curi) + < 0) { + LM_ERR("failed to parse the contact uri\n"); + return -1; + } + if(curi.user.len > 0) { + memcpy(td->cp, curi.user.s, curi.user.len); + td->cp += curi.user.len; + cuser_len = curi.user.len; + } else { + LM_DBG("no contact user - skipping it\n"); + } } } else { /* extract the ruri */

2 months, 2 weeks

git:master:8e2541ec: timer: formatted exported structures

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 8e2541ec6126b5665e92cde5eaf17f5a4970cb8d URL: https://github.com/kamailio/kamailio/commit/8e2541ec6126b5665e92cde5eaf17f5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-28T06:45:09+01:00 timer: formatted exported structures --- Modified: src/modules/timer/timer.c --- Diff: https://github.com/kamailio/kamailio/commit/8e2541ec6126b5665e92cde5eaf17f5… Patch: https://github.com/kamailio/kamailio/commit/8e2541ec6126b5665e92cde5eaf17f5… --- diff --git a/src/modules/timer/timer.c b/src/modules/timer/timer.c index 2f3f1b1bf34..5cb92a8847c 100644 --- a/src/modules/timer/timer.c +++ b/src/modules/timer/timer.c @@ -144,15 +144,18 @@ static int sel_executed(str *res, select_t *s, sip_msg_t *msg) return 0; } +/* clang-format off */ select_row_t sel_declaration[] = { - {NULL, SEL_PARAM_STR, STR_STATIC_INIT(MODULE_NAME), sel_root, + {NULL, SEL_PARAM_STR, STR_STATIC_INIT(MODULE_NAME), sel_root, SEL_PARAM_EXPECTED}, - {sel_root, SEL_PARAM_STR, STR_STATIC_INIT("timer"), sel_timer, + {sel_root, SEL_PARAM_STR, STR_STATIC_INIT("timer"), sel_timer, SEL_PARAM_EXPECTED | CONSUME_NEXT_STR | FIXUP_CALL}, - {sel_timer, SEL_PARAM_STR, STR_STATIC_INIT("enabled"), sel_enabled, 0}, - {sel_root, SEL_PARAM_STR, STR_STATIC_INIT("executed"), sel_executed, 0}, + {sel_timer, SEL_PARAM_STR, STR_STATIC_INIT("enabled"), sel_enabled, 0}, + {sel_root, SEL_PARAM_STR, STR_STATIC_INIT("executed"), sel_executed, 0}, - {NULL, SEL_PARAM_STR, STR_NULL, NULL, 0}}; + {NULL, SEL_PARAM_STR, STR_NULL, NULL, 0} +}; +/* clang-format on */ static unsigned int timer_msg_no = 0; @@ -485,30 +488,37 @@ static void destroy_mod(void) } } +/* clang-format off */ /* * Exported functions */ -static cmd_export_t cmds[] = {{MODULE_NAME "_enable", timer_enable_func, 2, - timer_enable_fixup, 0, ANY_ROUTE}, - {0, 0, 0, 0, 0, 0}}; +static cmd_export_t cmds[] = { + {MODULE_NAME "_enable", timer_enable_func, 2, timer_enable_fixup, + 0, ANY_ROUTE}, + + {0, 0, 0, 0, 0, 0} +}; /* * Exported parameters */ static param_export_t params[] = { - {"declare_timer", PARAM_STRING | PARAM_USE_FUNC, (void *)declare_timer}, - {0, 0, 0}}; + {"declare_timer", PARAM_STRING | PARAM_USE_FUNC, (void *)declare_timer}, + + {0, 0, 0 } +}; struct module_exports exports = { - MODULE_NAME, /* module name */ - DEFAULT_DLFLAGS, /* dlopen flags */ - cmds, /* Exported commands */ - params, /* Exported parameters */ - 0, /* Exported RPC functions */ - 0, /* pseudo-variables exports */ - 0, /* response function */ - mod_init, /* module initialization function */ - child_init, /* per-child init function */ - destroy_mod /* destroy function */ + MODULE_NAME, /* module name */ + DEFAULT_DLFLAGS, /* dlopen flags */ + cmds, /* Exported commands */ + params, /* Exported parameters */ + 0, /* Exported RPC functions */ + 0, /* pseudo-variables exports */ + 0, /* response function */ + mod_init, /* module initialization function */ + child_init, /* per-child init function */ + destroy_mod /* destroy function */ }; +/* clang-format on */

2 months, 2 weeks

git:master:d10257fb: core: parser sdp - check len gor extracting fmtp

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d10257fbfdbb3e3e73c0fe60a224585822bdd7b3 URL: https://github.com/kamailio/kamailio/commit/d10257fbfdbb3e3e73c0fe60a224585… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-26T07:46:01+02:00 core: parser sdp - check len gor extracting fmtp --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/d10257fbfdbb3e3e73c0fe60a224585… Patch: https://github.com/kamailio/kamailio/commit/d10257fbfdbb3e3e73c0fe60a224585… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index fe5b464e473..0e61fe5ca5d 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -218,8 +218,12 @@ int extract_fmtp(str *body, str *fmtp_payload, str *fmtp_string) char *cp, *cp1; int len; + if(body->len <= 7) { + return -1; + } if(strncasecmp(body->s, "a=fmtp:", 7) != 0) { - /*LM_DBG("We are not pointing to an a=fmtp: attribute =>`%.*s'\n", body->len, body->s); */ + /*LM_DBG("We are not pointing to an a=fmtp: attribute =>`%.*s'\n", + * body->len, body->s); */ return -1; }

2 months, 2 weeks

git:master:3e5f8dec: dispatcher: debug messages for checking active destinations

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3e5f8deced0cb05710e631601e9098505f1d230a URL: https://github.com/kamailio/kamailio/commit/3e5f8deced0cb05710e631601e90985… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-26T07:40:07+02:00 dispatcher: debug messages for checking active destinations --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/3e5f8deced0cb05710e631601e90985… Patch: https://github.com/kamailio/kamailio/commit/3e5f8deced0cb05710e631601e90985… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index f17963cc3bf..83bb7636206 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -3945,11 +3945,15 @@ int ds_is_active_uri(sip_msg_t *msg, int group, str *uri) for(j = 0; j < list->nr; j++) { if(!ds_skip_dst(list->dlist[j].flags)) { if(uri == NULL || uri->s == NULL || uri->len <= 0) { + LM_DBG("one destination active: %d %.*s\n", group, + list->dlist[j].uri.len, list->dlist[j].uri.s); return 1; } if((list->dlist[j].uri.len == uri->len) && (memcmp(list->dlist[j].uri.s, uri->s, uri->len) == 0)) { + LM_DBG("destination active: %d %.*s\n", group, + list->dlist[j].uri.len, list->dlist[j].uri.s); return 1; } }

2 months, 2 weeks

[kamailio/kamailio] tls: Create one shared context and reuse it. (PR #3972)

by Xenofon Karamanos

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3823 #### Description  This PR aims to implement what was discussed in [mailing list](https://lists.kamailio.org/mailman3/hyperkitty/list/sr-dev@lists.kama… regarding some `tls.reload` and increasing memory usage. It adds a new parameter `enable_shared_ctx` in `tls` module that if set to 0, preserves the old behavior and if set to 1 (other than 0 tbh), it creates a single SSL context that is being shared. This have the effect of using way less memory when initialized as well, but also minimizes (can't say it fixes the problem) the `tls.reload` memory increase. I have also added a small markdown (comparison.md) file, where some comparisons where made between enabled/disabled shared context and with/without CA file (where the initial problem was occurring by the reporter). Feedback would be necessary to verify whether this patch, acts as expected and kamailio works as intented. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3972 -- Commit Summary -- * tls: Add parameter for shared contexts * tls: Comparison for enable_shared_ctx -- File Changes -- A comparison.md (15) M src/modules/tls/tls_domain.c (172) M src/modules/tls/tls_mod.c (11) M src/modules/tls/tls_mod.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3972.patch https://github.com/kamailio/kamailio/pull/3972.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3972 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3972(a)github.com>

2 months, 2 weeks

[kamailio/kamailio] db_redis: compile issues with TLS + redis-cluster (Issue #3893)

by uv-2722

### Description Hello, I am trying to setup db_redis with TLS and redis-cluster support, I get the following errors during installation. ### Troubleshooting #### Reproduction Install hiredis(v1.2.0) and hiredis-cluster(v0.13.0) from source, both with ssl support. Then install kamailio 5.8.1 from source with db_redis module  #### Log Messages  ``` 37.77 CC (gcc) [M db_redis.so] db_redis_mod.o 37.85 CC (gcc) [M db_redis.so] redis_connection.o 37.90 redis_connection.c: In function 'db_redis_connect': 37.90 redis_connection.c:129:9: error: unknown type name 'redisSSLContext'; did you mean 'redisContext'? 37.90 129 | redisSSLContext *ssl = NULL; 37.90 | ^~~~~~~~~~~~~~~ 37.90 | redisContext 37.90 redis_connection.c:166:17: warning: implicit declaration of function 'redisInitOpenSSL' [-Wimplicit-function-declaration] 37.90 166 | redisInitOpenSSL(); 37.90 | ^~~~~~~~~~~~~~~~ 37.90 redis_connection.c:167:23: warning: implicit declaration of function 'redisCreateSSLContext' [-Wimplicit-function-declaration] 37.90 167 | ssl = redisCreateSSLContext( 37.90 | ^~~~~~~~~~~~~~~~~~~~~ 37.90 redis_connection.c:167:21: warning: assignment to 'int *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 37.90 167 | ssl = redisCreateSSLContext( 37.90 | ^ 37.91 redis_connection.c:196:17: warning: implicit declaration of function 'redisClusterSetOptionEnableSSL'; did you mean 'redisClusterSetOptionMaxRetry'? [-Wimplicit-function-declaration] 37.91 196 | redisClusterSetOptionEnableSSL(con->con, ssl); 37.91 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 37.91 | redisClusterSetOptionMaxRetry 37.93 make[2]: *** [../../Makefile.rules:100: redis_connection.o] Error 1 37.93 make[1]: *** [Makefile:508: modules] Error 1 37.93 make[1]: Leaving directory '/root/build/kamailio/src' 37.93 make: *** [Makefile:34: all] Error 2 ``` ### Additional Information * **Kamailio Version**: ``` Kamailio 5.8.1 ``` * **Operating System**:  ``` Debian 12 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3893 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3893(a)github.com>

2 months, 2 weeks

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev