sr-dev

sr-dev@lists.kamailio.org

15 participants
44215 discussions

scope of AVPs (AVP defined when execution of script starts)

by jh＠tutpro.com

i send the message below to wrong mailing list. i'm experiencing this behavior with sip-router, not kamailio. perhaps the behavior would be as expected with kamailio. -- juha ---------------------------------------------------------------------- i have always thought that AVPs exits per transaction. that does not seem to be the case, however, because when i put in the beginning of my script xlog("L_INFO", "Caller lcr_id $avp(CALLER_LCR_ID_AVP)\n"); this gets printed to syslog: Aug 29 11:34:34 localhost /usr/sbin/sip-router[10210]: INFO: Caller lcr_id 2 is this the indented behavior? do i really need to delete all AVPs in the beginning of the script in order to make sure that they don't have any values left from processing of previous message? -- juha

15 years, 4 months

t_relay() seems to generate error message on its own

by jh＠tutpro.com

according to t_relay() documentation: Returns a negative value on failure--you may still want to send a negative reply upstream statelessly not to leave upstream UAC in lurch. when t_relay cannot send request to the destination (no arp response), it seems to be generating on its own an error reply: 477 Unfortunately error sending to next hop occured this then results in two error replies (another one from script). is it true that the above error message is generated by t_relay()? if yes, is it somehow possible to get rid of it? in k tm module, there used to be a flag parameter to t_relay to control its error behavior. -- juha

15 years, 4 months

include entering/leaving blocks in debug level 7

by jh＠tutpro.com

would it be possible to enhance debug level 7 so that it would print entering/leaving of route/failure/... blocks? i'm in the middle of debugging a mystery where syslog shows DBG:core:rewrite_uri: rewriting Request-URI with 'sip:foo.bar@ip-addr:5060;transport=UDP' but i cannot find in config file where that happens and debug doesn't tell what command caused the rewrite. -- juha

15 years, 4 months

SF.net SVN: openser:[5918] branches

by Henning Westerholt

Revision: 5918 http://openser.svn.sourceforge.net/openser/?rev=5918&view=rev Author: henningw Date: 2009-08-31 10:38:21 +0000 (Mon, 31 Aug 2009) Log Message: ----------- - bug fix in Makefile: don't add debugging symbols only when we compile in release mode, we want them also when we debugging mode (which enables EXTRA_DEBUG) - patch from Timo Reimann, timo dot reimann at 1und1 dot de Modified Paths: -------------- branches/1.4/Makefile.defs branches/1.5/Makefile.defs This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

15 years, 4 months

SF.net SVN: openser:[5917] branches/1.3/parser/msg_parser.c

by Henning Westerholt

Revision: 5917 http://openser.svn.sourceforge.net/openser/?rev=5917&view=rev Author: henningw Date: 2009-08-31 10:32:55 +0000 (Mon, 31 Aug 2009) Log Message: ----------- - add missing ' " ' in EXTRA_DEBUG LM_DBG statement Modified Paths: -------------- branches/1.3/parser/msg_parser.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

15 years, 4 months

SF.net SVN: openser:[5916] branches

by Henning Westerholt

Revision: 5916 http://openser.svn.sourceforge.net/openser/?rev=5916&view=rev Author: henningw Date: 2009-08-31 10:31:40 +0000 (Mon, 31 Aug 2009) Log Message: ----------- - don't try to destroy the same callback twice, could cause a shutdown crash - found by Marius Zbihlei, marius dot zbihlei at 1and1 dot ro Modified Paths: -------------- branches/1.3/script_cb.c branches/1.4/script_cb.c branches/1.5/script_cb.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

15 years, 4 months

git:master: core & avpops: fix overlapping avp flag

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 67ae0865fbdc175b0e72eadb6a098325e9168a70 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=67ae086… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Aug 31 13:01:46 2009 +0300 core & avpops: fix overlapping avp flag - k avpops uses a flag to mark whether a loaded avp from db has changed, in order to decide if worth to update db - the value was overlapping with flags defined in sr core - reported by Juha Heinanen --- modules/avpops/avpops_impl.h | 2 +- usr_avp.h | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/modules/avpops/avpops_impl.h b/modules/avpops/avpops_impl.h index 37afb6d..6e38007 100644 --- a/modules/avpops/avpops_impl.h +++ b/modules/avpops/avpops_impl.h @@ -41,7 +41,7 @@ /* flags used inside avps */ /* IMPORTANT: flagss 0-4 are reserved by core; 8-15 by script */ -#define AVP_IS_IN_DB (1<<7) +#define AVP_IS_IN_DB (1<<12) /* DB flags */ #define AVPOPS_DB_NAME_INT (1<<1) diff --git a/usr_avp.h b/usr_avp.h index 324bad4..b40ccdb 100644 --- a/usr_avp.h +++ b/usr_avp.h @@ -153,7 +153,11 @@ typedef struct avp_spec { #define AVP_INDEX_BACKWARD (1<<11) #define AVP_INDEX_ALL (AVP_INDEX_FORWARD | AVP_INDEX_BACKWARD) -#define AVP_CUSTOM_FLAGS 12 +/* AVP DB flag used by avpops module - defined in avpops + * - kept here for reference */ +// #define AVP_IS_IN_DB (1<<12) + +#define AVP_CUSTOM_FLAGS 13 #define GALIAS_CHAR_MARKER '$'

15 years, 4 months

SF.net SVN: openser:[5915] branches/1.5/modules/lcr

by Juha Heinanen

Revision: 5915 http://openser.svn.sourceforge.net/openser/?rev=5915&view=rev Author: juhe Date: 2009-08-27 17:17:37 +0000 (Thu, 27 Aug 2009) Log Message: ----------- * Restored disappeared documentation related to pinging of gateways. Modified Paths: -------------- branches/1.5/modules/lcr/README branches/1.5/modules/lcr/doc/lcr_admin.xml This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

15 years, 4 months

custom module and variables

by liran tal

Hey list, Due to technical reasons we are running openser1.0.1 on a tiny embedded system. I am exploring the way to pass a PV's value into the exported function from my module, and returning back a value from the function via the use of some other PV or a newly added AVP. I am not sure how to follow this, as basic avpops operations aren't working for me in the config file itself (without introducing my custom module at all). Could someone explain or provide an example as to how this would work? I have taken a look at http://www.asipto.com/pub/openser-devel-guide/ regarding adding a new module but I'm not quite sure as to the details regarding avops and such. Regards.

15 years, 4 months

git:master: modules/lcr: added checks on validity of lcr_id parameter.

by Juha Heinanen

Module: sip-router Branch: master Commit: b1a941a21c7404c6a21df45b988b40695efcb347 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b1a941a… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Fri Aug 28 20:40:05 2009 +0300 modules/lcr: added checks on validity of lcr_id parameter. --- modules/lcr/lcr_mod.c | 39 +++++++++++++++++++++------------------ 1 files changed, 21 insertions(+), 18 deletions(-) diff --git a/modules/lcr/lcr_mod.c b/modules/lcr/lcr_mod.c index 4ad08a7..26cfa48 100644 --- a/modules/lcr/lcr_mod.c +++ b/modules/lcr/lcr_mod.c @@ -448,7 +448,7 @@ static int mod_init(void) /* Check value of lcr_count */ if (lcr_count < 1) { - LM_ERR("invalid lcr_count value <%d>\n", lcr_count); + LM_ERR("invalid lcr_count module parameter value <%d>\n", lcr_count); return -1; } @@ -953,7 +953,7 @@ int reload_gws_and_lcrs(int lcr_id) struct gw_grp gw_grps[MAX_NO_OF_GWS]; struct gw_info *gws, *gwtp_tmp; struct lcr_info **lcrs, **lcrtp_tmp; - + key_cols[0] = &lcr_id_col; op[0] = OP_EQ; VAL_TYPE(vals) = DB1_INT; @@ -1704,13 +1704,13 @@ static int load_gws(struct sip_msg* _m, char *_lcr_id, char *_from_uri) struct lcr_info **lcrs, *lcr_rec, *pl; struct gw_info *gws; - /* Get parameter values */ + /* Get and check parameter values */ if (get_int_fparam(&lcr_id, _m, (fparam_t *)_lcr_id) != 0) { LM_ERR("no lcr_id param value\n"); return -1; } - if ((lcr_id < 1) && (lcr_id > lcr_count)) { - LM_ERR("invalid lcr_id param value\n"); + if ((lcr_id < 1) || (lcr_id > lcr_count)) { + LM_ERR("invalid lcr_id parameter value %d\n", lcr_id); return -1; } @@ -2096,7 +2096,7 @@ static int do_from_gw(struct sip_msg* _m, unsigned int lcr_id, { struct gw_info *res, *gws; int_str val; - + /* Use gws with index lcr_id */ gws = gwtp[lcr_id]; @@ -2126,19 +2126,20 @@ static int from_gw_1(struct sip_msg* _m, char* _lcr_id, char* _s2) int lcr_id; unsigned int src_addr; - /* Get parameter values */ + /* Get and check parameter value */ if (get_int_fparam(&lcr_id, _m, (fparam_t *)_lcr_id) != 0) { LM_ERR("no lcr_id param value\n"); return -1; } - if ((lcr_id < 1) && (lcr_id > lcr_count)) { - LM_ERR("invalid lcr_id param value\n"); + if ((lcr_id < 1) || (lcr_id > lcr_count)) { + LM_ERR("invalid lcr_id parameter value %d\n", lcr_id); return -1; } /* Get source address */ src_addr = _m->rcv.src_ip.u.addr32[0]; + /* Do test */ return do_from_gw(_m, lcr_id, src_addr); } @@ -2153,15 +2154,16 @@ static int from_gw_2(struct sip_msg* _m, char* _lcr_id, char* _addr) pv_value_t pv_val; struct ip_addr *ip; - /* Get parameter values */ + /* Get and check parameter values */ if (get_int_fparam(&lcr_id, _m, (fparam_t *)_lcr_id) != 0) { LM_ERR("no lcr_id param value\n"); return -1; } - if ((lcr_id < 1) && (lcr_id > lcr_count)) { - LM_ERR("invalid lcr_id param value\n"); + if ((lcr_id < 1) || (lcr_id > lcr_count)) { + LM_ERR("invalid lcr_id parameter value %d\n", lcr_id); return -1; } + if (_addr && (pv_get_spec_value(_m, (pv_spec_t *)_addr, &pv_val) == 0)) { if (pv_val.flags & PV_VAL_INT) { src_addr = pv_val.ri; @@ -2280,13 +2282,13 @@ static int to_gw_1(struct sip_msg* _m, char* _lcr_id, char* _s2) unsigned int dst_addr; struct ip_addr *ip; - /* Get parameter value */ + /* Get and check parameter value */ if (get_int_fparam(&lcr_id, _m, (fparam_t *)_lcr_id) != 0) { LM_ERR("no lcr_id param value\n"); return -1; } - if ((lcr_id < 1) && (lcr_id > lcr_count)) { - LM_ERR("invalid lcr_id param value\n"); + if ((lcr_id < 1) || (lcr_id > lcr_count)) { + LM_ERR("invalid lcr_id parameter value %d\n", lcr_id); return -1; } @@ -2323,15 +2325,16 @@ static int to_gw_2(struct sip_msg* _m, char* _lcr_id, char* _addr) pv_value_t pv_val; struct ip_addr *ip; - /* Get parameter values */ + /* Get and check parameter values */ if (get_int_fparam(&lcr_id, _m, (fparam_t *)_lcr_id) != 0) { LM_ERR("no lcr_id param value\n"); return -1; } - if ((lcr_id < 1) && (lcr_id > lcr_count)) { - LM_ERR("invalid lcr_id param value\n"); + if ((lcr_id < 1) || (lcr_id > lcr_count)) { + LM_ERR("invalid lcr_id parameter value %d\n", lcr_id); return -1; } + if (_addr && (pv_get_spec_value(_m, (pv_spec_t *)_addr, &pv_val) == 0)) { if (pv_val.flags & PV_VAL_INT) { dst_addr = pv_val.ri;

15 years, 4 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev