sr-dev

sr-dev@lists.kamailio.org

15 participants
44216 discussions

[ openser-Bugs-2851214 ] Registrar leaks contacts from unrelated users

by SourceForge.net

Bugs item #2851214, was opened at 2009-09-04 16:26 Message generated for change (Tracker Item Submitted) made by axlh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2851214&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Registrar leaks contacts from unrelated users Initial Comment: When an AOR with no active registrations queries for its current bindings (Contact: *, Expires: 0), the registrar returns the bindings of the AOR who was last handled by the same process instead of returning an empty list. Attached patch fixes this. Applies to 1.4 as well as 1.5. Btw, why does every caller of get_urecord() check for negative return code??? The function can only return 0 or 1. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2851214&group_…

15 years, 4 months

SF.net SVN: openser:[5921] branches/1.5/modules/siputils

by Henning Westerholt

Revision: 5921 http://openser.svn.sourceforge.net/openser/?rev=5921&view=rev Author: henningw Date: 2009-09-04 13:04:06 +0000 (Fri, 04 Sep 2009) Log Message: ----------- - small docs clarification related to ring_insert_callid function Modified Paths: -------------- branches/1.5/modules/siputils/README branches/1.5/modules/siputils/doc/siputils_admin.xml This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

15 years, 4 months

test if $var has been give a value

by jh＠tutpro.com

why does test if ($var(test)) ... fail even when $var(test) has a non-empty string value? the test works, if i do it like this: if ($var(test) != 0) ... i'm pretty sure that in k also the first version of the test works. -- juha

15 years, 4 months

git:master: oob cfg: merged changes from last SIPit

by Nils Ohlmeier

Module: sip-router Branch: master Commit: 3e493f4d363966db93bc32bca62c10ca6a14b927 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3e493f4… Author: Nils Ohlmeier <lando(a)bespin.rfc3261.net> Committer: Nils Ohlmeier <lando(a)bespin.rfc3261.net> Date: Thu Sep 3 16:22:48 2009 +0200 oob cfg: merged changes from last SIPit This version of sip-router-oob.cfg was successfully tested at SIPit 24. The changes are: - re-organzied the NAT detection - added lots of comments about NAT detection - renamed the record- and loose-routes - added an inactive ENUM route - activated DNS NAPTR and SRV options - disabled TCP async to allow usage of TLS - disabled the files limit as this prevents the usage of the config as non-root user on most systems --- etc/sip-router-oob.cfg | 176 ++++++++++++++++++++++++++++++++++-------------- 1 files changed, 126 insertions(+), 50 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=3e4…

15 years, 4 months

git:master: domain(k): regenerated readme

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: c92d65efc7ea5abb4c4a718ff5e90e2ec7ad6cb3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c92d65e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 3 14:43:29 2009 +0200 domain(k): regenerated readme - include new parameter 'register_myself' --- modules_k/domain/README | 235 +++++++++++++++++++++++++++++------------------ 1 files changed, 144 insertions(+), 91 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=c92…

15 years, 4 months

support for 'include' in cfg file

by Daniel-Constantin Mierla

Hello, just committed to GIT support for 'include' in config file. Hopefully this helps in nicer structuring and maintenance of your configs. The syntax is simple: include path_to_file The path_to_file can be relative or absolute. If it is not absolute path, first attempt is to locate it relative to current directory, and if fails, relative to directory of the file that includes it. There is no restriction where include can be used or what can contain - any part of config file is ok. There is a limit of maximum 10 includes in depth, otherwise you can use as many includes as you want. Reporting of the cfg file syntax errors prints now the file name for easier troubleshooting. Example: route { ... include /sr/checks.cfg ... } --- /sr/checks.cfg --- if (!mf_process_maxfwd_header("10")) { sl_send_reply("483","Too Many Hops"); exit; } --- Testing and feedback is much appreciated. Cheers, Daniel -- Daniel-Constantin Mierla * http://www.asipto.com/

15 years, 4 months

git:master: domain(k): new module parameter - register_myself

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 3653a528efc6f9f760ec31f506b37e567c6ed275 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3653a52… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 3 13:16:27 2009 +0300 domain(k): new module parameter - register_myself - cotrol registration of domain list to 'myself' check callbacks - disabled by default (requested by Juha Heinanen for backward compatibility) --- modules_k/domain/doc/domain_admin.xml | 18 ++++++++++++++++++ modules_k/domain/domain_mod.c | 11 ++++++++--- 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/modules_k/domain/doc/domain_admin.xml b/modules_k/domain/doc/domain_admin.xml index d563ce9..9961dea 100644 --- a/modules_k/domain/doc/domain_admin.xml +++ b/modules_k/domain/doc/domain_admin.xml @@ -117,6 +117,24 @@ modparam("domain", "domain_col", "domain_name") </programlisting> </example> </section> + <section> + <title><varname>register_myself</varname> (integer)</title> + <para> + Register the list of domains to match 'myself' check: + 0 means no myself registration, 1 means enable myself + registration. + </para> + <para> + Default value is 0 (disable). + </para> + <example> + <title>register_myself example</title> + <programlisting format="linespecific"> +modparam("domain", "register_myself", 1) +</programlisting> + </example> + </section> + </section> <section> diff --git a/modules_k/domain/domain_mod.c b/modules_k/domain/domain_mod.c index afefee5..fb70d06 100644 --- a/modules_k/domain/domain_mod.c +++ b/modules_k/domain/domain_mod.c @@ -77,6 +77,7 @@ static str db_url = {DEFAULT_RODB_URL, DEFAULT_RODB_URL_LEN}; int db_mode = 0; /* Database usage mode: 0 = no cache, 1 = cache */ str domain_table = {DOMAIN_TABLE, DOMAIN_TABLE_LEN}; /* Name of domain table */ str domain_col = {DOMAIN_COL, DOMAIN_COL_LEN}; /* Name of domain column */ +int domain_reg_myself = 0; /* * Other module variables @@ -110,6 +111,7 @@ static param_export_t params[] = { {"db_mode", INT_PARAM, &db_mode }, {"domain_table", STR_PARAM, &domain_table.s}, {"domain_col", STR_PARAM, &domain_col.s }, + {"register_myself",INT_PARAM, &domain_reg_myself}, {0, 0, 0} }; @@ -154,10 +156,13 @@ static int mod_init(void) LM_ERR("failed to register MI commands\n"); return -1; } - if(register_check_self_func(domain_check_self)<0) + if(domain_reg_myself!=0) { - LM_ERR("failed to register check self function\n"); - return -1; + if(register_check_self_func(domain_check_self)<0) + { + LM_ERR("failed to register check self function\n"); + return -1; + } } db_url.len = strlen(db_url.s);

15 years, 4 months

git:master: core: include replaced with include_file

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 1c9c433f7be395652bb28c5af61d2f64f33da926 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1c9c433… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 3 13:18:31 2009 +0300 core: include replaced with include_file - due to opinions expressed on mailing list suggesting it reflects better the meaning --- cfg.lex | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cfg.lex b/cfg.lex index a5941e4..9723877 100644 --- a/cfg.lex +++ b/cfg.lex @@ -156,7 +156,7 @@ /* start conditions */ %x STRING1 STRING2 STR_BETWEEN COMMENT COMMENT_LN ATTR SELECT AVP_PVAR PVAR_P -%x PVARID INCL +%x PVARID INCLF /* config script types : #!SER or #!KAMAILIO or #!MAX_COMPAT */ SER_CFG SER @@ -220,7 +220,7 @@ CASE "case" DEFAULT "default" WHILE "while" -INCLUDE "include" +INCLUDEFILE "include_file" /*ACTION LVALUES*/ URIHOST "uri:host" @@ -577,7 +577,7 @@ EAT_ABLE [\ \t\b\r] <INITIAL>{DEFAULT} { count(); yylval.strval=yytext; return DEFAULT; } <INITIAL>{WHILE} { count(); yylval.strval=yytext; return WHILE; } -<INITIAL>{INCLUDE} { count(); BEGIN(INCL); } +<INITIAL>{INCLUDEFILE} { count(); BEGIN(INCLF); } <INITIAL>{URIHOST} { count(); yylval.strval=yytext; return URIHOST; } <INITIAL>{URIPORT} { count(); yylval.strval=yytext; return URIPORT; } @@ -1120,8 +1120,8 @@ EAT_ABLE [\ \t\b\r] <SELECT>. { unput(yytext[0]); state = INITIAL_S; BEGIN(INITIAL); } /* Rescan the token in INITIAL state */ -<INCL>[ \t]* /* eat the whitespace */ -<INCL>[^ \t\n]+ { /* get the include file name */ +<INCLF>[ \t]* /* eat the whitespace */ +<INCLF>[^ \t\n]+ { /* get the include file name */ if(sr_push_yy_state(yytext)<0) exit(-1); BEGIN(INITIAL);

15 years, 4 months

CVS:commitlog: sip_router/cfg cfg_struct.c cfg_struct.h sip_router/doc cfg.txt sip_router main.c sip_router/modules/cpl-c cpl.c sip_router/modules/ctl ctl.c sip_router/modules/fifo fifo.c sip_router/modules/jabber jabber.c sip_router/modules/nathelper ...

by Miklos Tirpak

tirpi 2009/09/03 11:56:19 CEST SER CVS Repository Modified files: cfg cfg_struct.c cfg_struct.h doc cfg.txt . main.c modules/cpl-c cpl.c modules/ctl ctl.c modules/fifo fifo.c modules/jabber jabber.c modules/nathelper natping.c modules/sms sms.c Log: cfg framework: fix the initialization of child processes (backport from sip-router) The number of child processes that keep updating their local configuration needs to be known before any child process is forked. Before this the child processes increased the reference counter of the callback function list items after forking. If a child process was forked "too fast" then it freed the list before the other processes had a chance to refer to the list item. The result was that some child processes missed the initial configuration changes. (Those changes that had per-child process callback defined.) Revision Changes Path 1.14 +40 -3 sip_router/cfg/cfg_struct.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/sip_router/cfg/cfg_struct.c.d… 1.8 +18 -2 sip_router/cfg/cfg_struct.h http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/sip_router/cfg/cfg_struct.h.d… 1.12 +16 -3 sip_router/doc/cfg.txt http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/sip_router/doc/cfg.txt.diff?r… 1.276 +28 -2 sip_router/main.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/sip_router/main.c.diff?r1=1.2… 1.66 +5 -1 sip_router/modules/cpl-c/cpl.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/sip_router/modules/cpl-c/cpl.… 1.6 +4 -1 sip_router/modules/ctl/ctl.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/sip_router/modules/ctl/ctl.c.… 1.7 +8 -2 sip_router/modules/fifo/fifo.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/sip_router/modules/fifo/fifo.… 1.64 +10 -3 sip_router/modules/jabber/jabber.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/sip_router/modules/jabber/jab… 1.26 +6 -3 sip_router/modules/nathelper/natping.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/sip_router/modules/nathelper/… 1.42 +5 -1 sip_router/modules/sms/sms.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/sip_router/modules/sms/sms.c.…

15 years, 4 months

git:andrei/rpc_async: core: rpc capabilities and delayed reply api

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/rpc_async Commit: e256ce91db53172264a6e42cfd5040b30dada526 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e256ce9… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Thu Jul 30 15:40:42 2009 +0200 core: rpc capabilities and delayed reply api - added a new rpc function for interrogating the current rpc transport capabilities (for now the only extra capability is RPC_DELAYED_REPLY). - added a new special delayed reply rpc context and rpc functions hooks for creating and closing it. --- rpc.h | 25 ++++++++++++++++++++++++- 1 files changed, 24 insertions(+), 1 deletions(-) diff --git a/rpc.h b/rpc.h index 18e767e..1434146 100644 --- a/rpc.h +++ b/rpc.h @@ -37,7 +37,13 @@ enum rpc_flags { RET_ARRAY = (1 << 0), RET_VALUE = (1 << 1) }; - + +typedef enum rpc_capabilities { + RPC_DELAYED_REPLY = (1 <<0) /* delayed reply support */ +} rpc_capabilities_t; + +struct rpc_delayed_ctx; + /* Send the result to the caller */ typedef int (*rpc_send_f)(void* ctx); /* Send the reply to the client */ @@ -49,6 +55,13 @@ typedef int (*rpc_struct_add_f)(void* ctx, char* fmt, ...); /* Cr typedef int (*rpc_struct_scan_f)(void* ctx, char* fmt, ...); /* Scan attributes of a structure */ typedef int (*rpc_struct_printf_f)(void* ctx, char* name, char* fmt, ...); /* Struct version of rpc_printf */ +/* returns the supported capabilities */ +typedef rpc_capabilities_t (*rpc_capabilities_f)(void* ctx); +/* create a special "context" for delayed replies */ +typedef struct rpc_delayed_ctx* (*rpc_delayed_ctx_new_f)(void* ctx); +/* close the special "context" for delayed replies */ +typedef void (*rpc_delayed_ctx_close_f)(struct rpc_delayed_ctx* dctx); + /* * RPC context, this is what RPC functions get as a parameter and use * it to obtain the value of the parameters of the call and reference @@ -63,9 +76,19 @@ typedef struct rpc { rpc_struct_add_f struct_add; rpc_struct_scan_f struct_scan; rpc_struct_printf_f struct_printf; + rpc_capabilities_f capabilities; + rpc_delayed_ctx_new_f delayed_ctx_new; + rpc_delayed_ctx_close_f delayed_ctx_close; } rpc_t; +typedef struct rpc_delayed_ctx{ + rpc_t rpc; + void* reply_ctx; + /* more private data might follow */ +} rpc_delayed_ctx_t; + + /* * RPC Function Prototype */

15 years, 4 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev