- sr-dev - kamailio.org

git:master:43a12b88: p_usrloc: value checks for db_ops_ruid, db_update_as_insert
by Lucian Balaceanu 11 Sep '17

11 Sep '17

Module: kamailio Branch: master Commit: 43a12b88aa7ae018d92815628debe4c924e2b58f URL: https://github.com/kamailio/kamailio/commit/43a12b88aa7ae018d92815628debe4c… Author: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Committer: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Date: 2017-09-11T10:18:17+03:00 p_usrloc: value checks for db_ops_ruid, db_update_as_insert --- Modified: src/modules/p_usrloc/config.c --- Diff: https://github.com/kamailio/kamailio/commit/43a12b88aa7ae018d92815628debe4c… Patch: https://github.com/kamailio/kamailio/commit/43a12b88aa7ae018d92815628debe4c… --- diff --git a/src/modules/p_usrloc/config.c b/src/modules/p_usrloc/config.c index fd04ca63e5..b1b1417fd4 100644 --- a/src/modules/p_usrloc/config.c +++ b/src/modules/p_usrloc/config.c @@ -46,9 +46,9 @@ cfg_def_t p_usrloc_cfg_def[] = { " Specifies the error value on which a database shall be turned off. "}, {"failover_level", CFG_VAR_INT | CFG_ATOMIC, 0, 0, 0, 0, "Specifies the manner a failover is done (1 = turn off, 2 = find a spare) "}, - {"db_ops_ruid", CFG_VAR_INT | CFG_ATOMIC, 0, 0, 0, 0, + {"db_ops_ruid", CFG_VAR_INT | CFG_ATOMIC, 0, 1, 0, 0, "Set this if you want to update / delete from DB using ruid value "}, - {"db_update_as_insert", CFG_VAR_INT | CFG_ATOMIC, 0, 0, 0, 0, + {"db_update_as_insert", CFG_VAR_INT | CFG_ATOMIC, 0, 1, 0, 0, "Set this parameter if you want to do INSERT DB operations instead of UPDATE DB operations. "}, {0, 0, 0, 0, 0, 0} };

1 0

git:master:f5a329ff: uid_uri_db: removed history, updated application name
by Daniel-Constantin Mierla 10 Sep '17

10 Sep '17

Module: kamailio Branch: master Commit: f5a329ff0ce0e433c5ff8a7bfdc815819dcf1022 URL: https://github.com/kamailio/kamailio/commit/f5a329ff0ce0e433c5ff8a7bfdc8158… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-10T11:34:13+02:00 uid_uri_db: removed history, updated application name - adjustments to log messages and indentation --- Modified: src/modules/uid_uri_db/checks.c Modified: src/modules/uid_uri_db/checks.h Modified: src/modules/uid_uri_db/uid_uri_db_mod.c Modified: src/modules/uid_uri_db/uid_uri_db_mod.h --- Diff: https://github.com/kamailio/kamailio/commit/f5a329ff0ce0e433c5ff8a7bfdc8158… Patch: https://github.com/kamailio/kamailio/commit/f5a329ff0ce0e433c5ff8a7bfdc8158…

1 0

git:master:f60a3cfa: jsonrpcc: more debug messages if init fails
by Daniel-Constantin Mierla 10 Sep '17

10 Sep '17

Module: kamailio Branch: master Commit: f60a3cfa3070a4782038dcf9f2169562220cc396 URL: https://github.com/kamailio/kamailio/commit/f60a3cfa3070a4782038dcf9f216956… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-10T10:25:18+02:00 jsonrpcc: more debug messages if init fails - coherent indentation and whitespacing --- Modified: src/modules/jsonrpcc/jsonrpcc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/f60a3cfa3070a4782038dcf9f216956… Patch: https://github.com/kamailio/kamailio/commit/f60a3cfa3070a4782038dcf9f216956… --- diff --git a/src/modules/jsonrpcc/jsonrpcc_mod.c b/src/modules/jsonrpcc/jsonrpcc_mod.c index 567fdaf142..903b278447 100644 --- a/src/modules/jsonrpcc/jsonrpcc_mod.c +++ b/src/modules/jsonrpcc/jsonrpcc_mod.c @@ -60,7 +60,7 @@ static cmd_export_t cmds[]={ {"jsonrpc_notification", (cmd_function)jsonrpc_notification, 2, fixup_notification, 0, ANY_ROUTE}, {0, 0, 0, 0, 0, 0} }; - + /* * Script Parameters @@ -71,23 +71,23 @@ static param_export_t mod_params[]={ { 0,0,0 } }; - + /* * Exports */ struct module_exports exports = { - "jsonrpcc", /* module name */ - DEFAULT_DLFLAGS, /* dlopen flags */ - cmds, /* Exported functions */ - mod_params, /* Exported parameters */ - 0, /* exported statistics */ - 0, /* exported MI functions */ - 0, /* exported pseudo-variables */ - 0, /* extra processes */ - mod_init, /* module initialization function */ - 0, /* response function*/ - 0, /* destroy function */ - child_init /* per-child init function */ + "jsonrpcc", /* module name */ + DEFAULT_DLFLAGS, /* dlopen flags */ + cmds, /* Exported functions */ + mod_params, /* Exported parameters */ + 0, /* exported statistics */ + 0, /* exported MI functions */ + 0, /* exported pseudo-variables */ + 0, /* extra processes */ + mod_init, /* module initialization function */ + 0, /* response function*/ + 0, /* destroy function */ + child_init /* per-child init function */ }; @@ -97,12 +97,14 @@ static int mod_init(void) { /* load the tm functions */ if ( !(load_tm=(load_tm_f)find_export("load_tm", NO_SCRIPT, 0))) { - LOG(L_ERR, "ERROR:jsonrpc:mod_init: cannot import load_tm\n"); + LM_ERR("failed find tm - cannot import load_tm\n"); return -1; } /* let the auto-loading function load all TM stuff */ - if (load_tm( &tmb )==-1) + if (load_tm( &tmb )==-1) { + LM_ERR("failed to bind to tm api\n"); return -1; + } if (servers_param == NULL) { LM_ERR("servers parameter missing.\n"); @@ -130,8 +132,10 @@ static int child_init(int rank) return 0; pid=fork_process(PROC_NOCHLDINIT, "jsonrpc io handler", 1); - if (pid<0) + if (pid<0) { + LM_ERR("failed to fork jsonrpc io handler\n"); return -1; /* error */ + } if(pid==0){ /* child */ close(pipe_fds[1]); @@ -144,7 +148,7 @@ static int child_init(int rank) static int fixup_request(void** param, int param_no) { - if (param_no <= 4) { + if (param_no <= 4) { return fixup_spve_null(param, 1); } else if (param_no == 5) { return fixup_pvar_null(param, 1); @@ -155,7 +159,7 @@ static int fixup_request(void** param, int param_no) static int fixup_notification(void** param, int param_no) { - if (param_no <= 2) { + if (param_no <= 2) { return fixup_spve_null(param, 1); } LM_ERR("jsonrpc_notification takes exactly 2 parameters.\n"); @@ -164,7 +168,7 @@ static int fixup_notification(void** param, int param_no) static int fixup_request_free(void** param, int param_no) { - if (param_no <= 4) { + if (param_no <= 4) { return 0; } else if (param_no == 5) { return fixup_free_pvar_null(param, 1);

1 0

git:master:0281dc35: uid_gflags: fixed rpc commands doc strings
by Daniel-Constantin Mierla 10 Sep '17

10 Sep '17

Module: kamailio Branch: master Commit: 0281dc351ca4cde8d3343164cc3091d02808f3cb URL: https://github.com/kamailio/kamailio/commit/0281dc351ca4cde8d3343164cc3091d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-09T23:12:43+02:00 uid_gflags: fixed rpc commands doc strings - converted log macros - coherent indentation and whitespacing --- Modified: src/modules/uid_gflags/uid_gflags.c --- Diff: https://github.com/kamailio/kamailio/commit/0281dc351ca4cde8d3343164cc3091d… Patch: https://github.com/kamailio/kamailio/commit/0281dc351ca4cde8d3343164cc3091d…

1 0

git:master:ccfe8c42: prefix_route: added header define guards
by Daniel-Constantin Mierla 08 Sep '17

08 Sep '17

Module: kamailio Branch: master Commit: ccfe8c422135dff4b63db4b577973ff6790ebaf9 URL: https://github.com/kamailio/kamailio/commit/ccfe8c422135dff4b63db4b577973ff… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-08T10:35:00+02:00 prefix_route: added header define guards - sanitization of log messages --- Modified: src/modules/prefix_route/pr.h Modified: src/modules/prefix_route/pr_rpc.c Modified: src/modules/prefix_route/prefix_route.c Modified: src/modules/prefix_route/tree.c Modified: src/modules/prefix_route/tree.h --- Diff: https://github.com/kamailio/kamailio/commit/ccfe8c422135dff4b63db4b577973ff… Patch: https://github.com/kamailio/kamailio/commit/ccfe8c422135dff4b63db4b577973ff…

1 0

[kamailio/kamailio] need some help about acc module (#1229)
by Prashant Vidja 08 Sep '17

08 Sep '17

Hello, I have some feature required changes in acc module. In acc module we getting cdrs in database only which have METHOD=INVITE METHOD=BYE but in my setup I also get METHOD=OPTIONS so I need this entry also in acc table in kamailio database. so which changes i need to do in kamailio acc module.... or other...... my cdrs log I paste below which have mehod=options "Sep 7 07:16:53 sip /usr/local/sbin/kamailio[29264]: NOTICE: acc [acc.c:317]: acc_log_request(): ACC: request accounted: timestamp=1504783013;method=OPTIONS;from_tag=eUC9UgGrD;to_tag=j90H6yy5pU6Xc;call_id=2xJd0KCt-P;code=200;reason=OK;calling=46566464645;called=you;egressIP=kamailio.org;src_ip=1.0.0.127;to=<sip:+918866213320@sip.call.org>;tag=j90H6yy5pU6Xc;from=sip:918888888888@localhost;contact=;pai=;uri=sip:you@kamailio.org;onnet=0;rate=0.000333333" Thanks.. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1229

2 3

git:5.0:6c749dea: tm: reset T_ASYNC_CONTINUE once t_continue() callback is executed
by Daniel-Constantin Mierla 07 Sep '17

07 Sep '17

Module: kamailio Branch: 5.0 Commit: 6c749dea59d8f35b8a5303baba540edc2295cd92 URL: https://github.com/kamailio/kamailio/commit/6c749dea59d8f35b8a5303baba540ed… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-07T15:29:58+02:00 tm: reset T_ASYNC_CONTINUE once t_continue() callback is executed - by having it still set, the reply field was not reset, causing to free an invalid pointer when transaction was destroyed, reported by Vitaliy Aleksandrov - set reply of suspended request branch to FAKED_REPLY on continue, the code was already set to 500 - make it coherent with the local replied transactions - reset cloned reply under lock for suspended reply branch and free it later via backup pointer - safer if someone risks to access the suspended reply branch (should happen now, just future proof) (cherry picked from commit b672d8ef63715cf816390a05ce7a441377c3e468) --- Modified: src/modules/tm/t_suspend.c --- Diff: https://github.com/kamailio/kamailio/commit/6c749dea59d8f35b8a5303baba540ed… Patch: https://github.com/kamailio/kamailio/commit/6c749dea59d8f35b8a5303baba540ed…

1 0

git:master:e27ba180: snmpstats: removed wrong function name from log message
by Daniel-Constantin Mierla 07 Sep '17

07 Sep '17

Module: kamailio Branch: master Commit: e27ba180ab9801e6b32bfb31aad1c02d28f7e559 URL: https://github.com/kamailio/kamailio/commit/e27ba180ab9801e6b32bfb31aad1c02… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-07T15:29:09+02:00 snmpstats: removed wrong function name from log message --- Modified: src/modules/snmpstats/utilities.c --- Diff: https://github.com/kamailio/kamailio/commit/e27ba180ab9801e6b32bfb31aad1c02… Patch: https://github.com/kamailio/kamailio/commit/e27ba180ab9801e6b32bfb31aad1c02…

1 0

git:master:99ea089c: sl: exported sl_forward_reply() to kemi framework
by Daniel-Constantin Mierla 07 Sep '17

07 Sep '17

Module: kamailio Branch: master Commit: 99ea089cb410c18e26bf29feb6ed14bf404988ff URL: https://github.com/kamailio/kamailio/commit/99ea089cb410c18e26bf29feb6ed14b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-07T15:26:22+02:00 sl: exported sl_forward_reply() to kemi framework --- Modified: src/modules/sl/sl.c --- Diff: https://github.com/kamailio/kamailio/commit/99ea089cb410c18e26bf29feb6ed14b… Patch: https://github.com/kamailio/kamailio/commit/99ea089cb410c18e26bf29feb6ed14b… --- diff --git a/src/modules/sl/sl.c b/src/modules/sl/sl.c index 9c6cf3c144..ab50db3649 100644 --- a/src/modules/sl/sl.c +++ b/src/modules/sl/sl.c @@ -367,7 +367,7 @@ static int w_sl_forward_reply(sip_msg_t* msg, str* code, str* reason) LM_ERR("invalid SIP message type\n"); return -1; } - if(code!=NULL) { + if(code!=NULL && code->len>0) { if(code->len!=3) { LM_ERR("invalid reply code value %.*s\n", code->len, code->s); return -1; @@ -382,16 +382,12 @@ static int w_sl_forward_reply(sip_msg_t* msg, str* code, str* reason) return -1; } } - if(reason!=NULL && reason->len<=0) { - LM_ERR("invalid reply reason value\n"); - return -1; - } /* backup old values */ oldscode[0] = msg->first_line.u.reply.status.s[0]; oldscode[1] = msg->first_line.u.reply.status.s[1]; oldscode[2] = msg->first_line.u.reply.status.s[2]; oldncode = msg->first_line.u.reply.statuscode; - if(code!=NULL) { + if(code!=NULL && code->len>0) { /* update status code directly in msg buffer */ msg->first_line.u.reply.statuscode = (code->s[0]-'0')*100 + (code->s[1]-'0')*10 + code->s[2]-'0'; @@ -400,7 +396,7 @@ static int w_sl_forward_reply(sip_msg_t* msg, str* code, str* reason) msg->first_line.u.reply.status.s[2] = code->s[2]; } - if(reason!=NULL) { + if(reason!=NULL && reason->len>0) { ldel = del_lump(msg, msg->first_line.u.reply.reason.s - msg->buf, msg->first_line.u.reply.reason.len, @@ -419,7 +415,7 @@ static int w_sl_forward_reply(sip_msg_t* msg, str* code, str* reason) memcpy(rbuf, reason->s, reason->len); ladd = insert_new_lump_after(ldel, rbuf, reason->len, 0); if (ladd==0) { - LOG(L_ERR, "failed to add reason lump: %.*s\n", + LM_ERR("failed to add reason lump: %.*s\n", reason->len, reason->s); pkg_free(rbuf); ret = -1; @@ -428,14 +424,14 @@ static int w_sl_forward_reply(sip_msg_t* msg, str* code, str* reason) } ret = forward_reply_nocb(msg); restore: - if(reason!=NULL) { + if(reason!=NULL && reason->len>0) { if(ldel!=NULL) { remove_lump(msg, ldel); /* ladd is liked in the 'after' list inside ldel, * destroyed together, no need for its own remove operation */ } } - if(code!=NULL) { + if(code!=NULL && code->len>0) { msg->first_line.u.reply.statuscode = oldncode; msg->first_line.u.reply.status.s[0] = oldscode[0]; msg->first_line.u.reply.status.s[1] = oldscode[1]; @@ -521,6 +517,11 @@ static sr_kemi_t sl_kemi_exports[] = { { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("sl"), str_init("sl_forward_reply"), + SR_KEMIP_INT, w_sl_forward_reply, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

1 0

git:master:c4bd6709: modules: readme files regenerated - lcr ... [skip ci]
by Kamailio Dev 06 Sep '17

06 Sep '17

Module: kamailio Branch: master Commit: c4bd6709cf3abb1fb0685fc89641d85c6752eb34 URL: https://github.com/kamailio/kamailio/commit/c4bd6709cf3abb1fb0685fc89641d85… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-09-06T20:46:22+02:00 modules: readme files regenerated - lcr ... [skip ci] --- Modified: src/modules/lcr/README --- Diff: https://github.com/kamailio/kamailio/commit/c4bd6709cf3abb1fb0685fc89641d85… Patch: https://github.com/kamailio/kamailio/commit/c4bd6709cf3abb1fb0685fc89641d85… --- diff --git a/src/modules/lcr/README b/src/modules/lcr/README index 3ac0c7a185..aca7e6d6a2 100644 --- a/src/modules/lcr/README +++ b/src/modules/lcr/README @@ -571,8 +571,8 @@ modparam("lcr", "lcr_rule_table", "rules") 3.17. prefix_column (string) - Name of the column holding prefix of Request-URI user part and prefix - of gateway. + Name of the column in lcr_rule and lcr_gw tables holding prefix of + Request-URI user part and prefix of gateway, respectively. Default value is “prefix”.

1 0

git:master:b0f941e1: modules/lcr: improved description of prefix_column param
by Juha Heinanen 06 Sep '17

06 Sep '17

Module: kamailio Branch: master Commit: b0f941e1ef9a013472ea42bade3c8ecae9111768 URL: https://github.com/kamailio/kamailio/commit/b0f941e1ef9a013472ea42bade3c8ec… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: 2017-09-06T21:34:56+03:00 modules/lcr: improved description of prefix_column param --- Modified: src/modules/lcr/doc/lcr_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/b0f941e1ef9a013472ea42bade3c8ec… Patch: https://github.com/kamailio/kamailio/commit/b0f941e1ef9a013472ea42bade3c8ec… --- diff --git a/src/modules/lcr/doc/lcr_admin.xml b/src/modules/lcr/doc/lcr_admin.xml index 8c4552d1ba..5d1d92c99a 100644 --- a/src/modules/lcr/doc/lcr_admin.xml +++ b/src/modules/lcr/doc/lcr_admin.xml @@ -519,8 +519,8 @@ modparam("lcr", "lcr_rule_table", "rules") <section> <title><varname>prefix_column</varname> (string)</title> <para> - Name of the column holding prefix of Request-URI user - part and prefix of gateway. + Name of the column in lcr_rule and lcr_gw tables holding prefix + of Request-URI user part and prefix of gateway, respectively. </para> <para> <emphasis>

1 0

git:master:b672d8ef: tm: reset T_ASYNC_CONTINUE once t_continue() callback is executed
by Daniel-Constantin Mierla 06 Sep '17

06 Sep '17

Module: kamailio Branch: master Commit: b672d8ef63715cf816390a05ce7a441377c3e468 URL: https://github.com/kamailio/kamailio/commit/b672d8ef63715cf816390a05ce7a441… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-06T11:13:16+02:00 tm: reset T_ASYNC_CONTINUE once t_continue() callback is executed - by having it still set, the reply field was not reset, causing to free an invalid pointer when transaction was destroyed, reported by Vitaliy Aleksandrov - set reply of suspended request branch to FAKED_REPLY on continue, the code was already set to 500 - make it coherent with the local replied transactions - reset cloned reply under lock for suspended reply branch and free it later via backup pointer - safer if someone risks to access the suspended reply branch (should happen now, just future proof) --- Modified: src/modules/tm/t_suspend.c --- Diff: https://github.com/kamailio/kamailio/commit/b672d8ef63715cf816390a05ce7a441… Patch: https://github.com/kamailio/kamailio/commit/b672d8ef63715cf816390a05ce7a441…

1 0

git:5.0:d5f89eb4: tm: more info in some log messages
by Daniel-Constantin Mierla 06 Sep '17

06 Sep '17

Module: kamailio Branch: 5.0 Commit: d5f89eb46c6d463d162dab0af1a7b56af513549c URL: https://github.com/kamailio/kamailio/commit/d5f89eb46c6d463d162dab0af1a7b56… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-06T09:15:14+02:00 tm: more info in some log messages (cherry picked from commit 8599f6fca16367a3e2a0dd4a638c667459482cd5) --- Modified: src/modules/tm/t_lookup.c --- Diff: https://github.com/kamailio/kamailio/commit/d5f89eb46c6d463d162dab0af1a7b56… Patch: https://github.com/kamailio/kamailio/commit/d5f89eb46c6d463d162dab0af1a7b56… --- diff --git a/src/modules/tm/t_lookup.c b/src/modules/tm/t_lookup.c index 265633ca69..474ad63cbe 100644 --- a/src/modules/tm/t_lookup.c +++ b/src/modules/tm/t_lookup.c @@ -930,7 +930,7 @@ int t_reply_matching( struct sip_msg *p_msg , int *p_branch ) *p_branch =(int) branch_id; REF_UNSAFE( T ); UNLOCK_HASH(hash_index); - LM_DBG("reply matched (T=%p)!\n",T); + LM_DBG("reply (%p) matched an active transaction (T=%p)!\n", p_msg, T); if(likely(!(p_msg->msg_flags&FL_TM_RPL_MATCHED))) { /* if this is a 200 for INVITE, we will wish to store to-tags to be * able to distinguish retransmissions later and not to call @@ -997,8 +997,8 @@ int t_check_msg( struct sip_msg* p_msg , int *param_branch ) ret=0; /* is T still up-to-date ? */ - LM_DBG("msg id=%d global id=%d T start=%p\n", - p_msg->id,global_msg_id,T); + LM_DBG("msg (%p) id=%d global id=%d T start=%p\n", + p_msg,p_msg->id,global_msg_id,T); if ( p_msg->id != global_msg_id || T==T_UNDEFINED ) { global_msg_id = p_msg->id; @@ -1063,17 +1063,17 @@ int t_check_msg( struct sip_msg* p_msg , int *param_branch ) if ( T && T!=T_UNDEFINED && T->flags & (T_IN_AGONY)) { LM_WARN("transaction %p scheduled for deletion " "and called from t_check_msg (flags=%x) (but it might be ok)" - "\n", T, T->flags); + " (msg %p)\n", T, T->flags, p_msg); } #endif - LM_DBG("msg id=%d global id=%d T end=%p\n", - p_msg->id,global_msg_id,T); + LM_DBG("msg (%p) id=%d global id=%d T end=%p\n", + p_msg,p_msg->id,global_msg_id,T); } else { /* ( p_msg->id == global_msg_id && T!=T_UNDEFINED ) */ if (T){ - LM_DBG("T already found!\n"); + LM_DBG("T (%p) already found for msg (%p)!\n", T, p_msg); ret=1; }else{ - LM_DBG("T previously sought and not found\n"); + LM_DBG("T previously sought and not found for msg (%p)\n", p_msg); ret=-1; } if (likely(param_branch))

1 0

git:master:8599f6fc: tm: more info in some log messages
by Daniel-Constantin Mierla 06 Sep '17

06 Sep '17

Module: kamailio Branch: master Commit: 8599f6fca16367a3e2a0dd4a638c667459482cd5 URL: https://github.com/kamailio/kamailio/commit/8599f6fca16367a3e2a0dd4a638c667… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-06T09:09:13+02:00 tm: more info in some log messages --- Modified: src/modules/tm/t_lookup.c --- Diff: https://github.com/kamailio/kamailio/commit/8599f6fca16367a3e2a0dd4a638c667… Patch: https://github.com/kamailio/kamailio/commit/8599f6fca16367a3e2a0dd4a638c667… --- diff --git a/src/modules/tm/t_lookup.c b/src/modules/tm/t_lookup.c index 94787f1965..1fff011dee 100644 --- a/src/modules/tm/t_lookup.c +++ b/src/modules/tm/t_lookup.c @@ -930,7 +930,7 @@ int t_reply_matching( struct sip_msg *p_msg , int *p_branch ) *p_branch =(int) branch_id; REF_UNSAFE( T ); UNLOCK_HASH(hash_index); - LM_DBG("reply matched (T=%p)!\n",T); + LM_DBG("reply (%p) matched an active transaction (T=%p)!\n", p_msg, T); if(likely(!(p_msg->msg_flags&FL_TM_RPL_MATCHED))) { /* if this is a 200 for INVITE, we will wish to store to-tags to be * able to distinguish retransmissions later and not to call @@ -997,8 +997,8 @@ int t_check_msg( struct sip_msg* p_msg , int *param_branch ) ret=0; /* is T still up-to-date ? */ - LM_DBG("msg id=%d global id=%d T start=%p\n", - p_msg->id,global_msg_id,T); + LM_DBG("msg (%p) id=%d global id=%d T start=%p\n", + p_msg,p_msg->id,global_msg_id,T); if ( p_msg->id != global_msg_id || T==T_UNDEFINED ) { global_msg_id = p_msg->id; @@ -1063,17 +1063,17 @@ int t_check_msg( struct sip_msg* p_msg , int *param_branch ) if ( T && T!=T_UNDEFINED && T->flags & (T_IN_AGONY)) { LM_WARN("transaction %p scheduled for deletion " "and called from t_check_msg (flags=%x) (but it might be ok)" - "\n", T, T->flags); + " (msg %p)\n", T, T->flags, p_msg); } #endif - LM_DBG("msg id=%d global id=%d T end=%p\n", - p_msg->id,global_msg_id,T); + LM_DBG("msg (%p) id=%d global id=%d T end=%p\n", + p_msg,p_msg->id,global_msg_id,T); } else { /* ( p_msg->id == global_msg_id && T!=T_UNDEFINED ) */ if (T){ - LM_DBG("T already found!\n"); + LM_DBG("T (%p) already found for msg (%p)!\n", T, p_msg); ret=1; }else{ - LM_DBG("T previously sought and not found\n"); + LM_DBG("T previously sought and not found for msg (%p)\n", p_msg); ret=-1; } if (likely(param_branch))

1 0

git:master:e90184ed: modules: readme files regenerated - p_usrloc ... [skip ci]
by Kamailio Dev 05 Sep '17

05 Sep '17

Module: kamailio Branch: master Commit: e90184ede69a1c162da640d2df0d44198c2059bf URL: https://github.com/kamailio/kamailio/commit/e90184ede69a1c162da640d2df0d441… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-09-05T13:31:18+02:00 modules: readme files regenerated - p_usrloc ... [skip ci] --- Modified: src/modules/p_usrloc/README --- Diff: https://github.com/kamailio/kamailio/commit/e90184ede69a1c162da640d2df0d441… Patch: https://github.com/kamailio/kamailio/commit/e90184ede69a1c162da640d2df0d441… --- diff --git a/src/modules/p_usrloc/README b/src/modules/p_usrloc/README index 6d3af78ff6..0b8356e4f7 100644 --- a/src/modules/p_usrloc/README +++ b/src/modules/p_usrloc/README @@ -427,6 +427,9 @@ modparam("p_usrloc", "risk_group_column", "rg") Default value is “3600”. + Can be set at runtime, e.g.: + $ kamcmd cfg.set_now_int p_usrloc expire_time 7200 + Example 1.12. Set expire_time parameter ... modparam("p_usrloc", "expire_time", "3600") @@ -438,6 +441,9 @@ modparam("p_usrloc", "expire_time", "3600") Default value is “50”. + Can be set at runtime, e.g.: + $ kamcmd cfg.set_now_int p_usrloc db_err_threshold 20 + Example 1.13. Set db_err_threshold parameter ... modparam("p_usrloc", "db_err_threshold", "50") @@ -452,6 +458,9 @@ modparam("p_usrloc", "db_err_threshold", "50") Default value is “1”. + Can be set at runtime, e.g.: + $ kamcmd cfg.set_now_int p_usrloc failover_level 2 + Example 1.14. Set failover_level parameter ... modparam("p_usrloc", "failover_level", "1") @@ -592,6 +601,9 @@ modparam("p_usrloc", "default_db_type", "cluster") Default value is “1”. + Can be set at runtime, e.g.: + $ kamcmd cfg.set_now_int p_usrloc db_ops_ruid 1 + Example 1.24. Set db_ops_ruid parameter ... modparam("p_usrloc", "db_ops_ruid", 0) @@ -605,6 +617,9 @@ modparam("p_usrloc", "db_ops_ruid", 0) Default value is “0”. + Can be set at runtime, e.g.: + $ kamcmd cfg.set_now_int p_usrloc db_update_as_insert 1 + Example 1.25. Set db_update_as_insert parameter ... modparam("usrloc", "db_update_as_insert", 1)

1 0

git:master:fda5be33: p_usrloc: add config framework support for certain parameters
by Lucian Balaceanu 05 Sep '17

05 Sep '17

Module: kamailio Branch: master Commit: fda5be331d24342beb5b50e7171b4a3be9c5b4fc URL: https://github.com/kamailio/kamailio/commit/fda5be331d24342beb5b50e7171b4a3… Author: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Committer: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Date: 2017-09-05T14:21:40+03:00 p_usrloc: add config framework support for certain parameters The following params are now configurable via kamcmd cfg: expire_time, db_err_threshold, failover_level, db_ops_ruid, db_update_as_insert --- Added: src/modules/p_usrloc/config.c Added: src/modules/p_usrloc/config.h Modified: src/modules/p_usrloc/doc/p_usrloc_admin.xml Modified: src/modules/p_usrloc/p_usrloc_mod.c Modified: src/modules/p_usrloc/p_usrloc_mod.h Modified: src/modules/p_usrloc/ucontact.c Modified: src/modules/p_usrloc/ul_db.c Modified: src/modules/p_usrloc/ul_db_failover.c Modified: src/modules/p_usrloc/ul_db_handle.c Modified: src/modules/p_usrloc/urecord.c --- Diff: https://github.com/kamailio/kamailio/commit/fda5be331d24342beb5b50e7171b4a3… Patch: https://github.com/kamailio/kamailio/commit/fda5be331d24342beb5b50e7171b4a3…

1 0

git:master:30329454: modules: readme files regenerated - presence_xml ... [skip ci]
by Kamailio Dev 05 Sep '17

05 Sep '17

Module: kamailio Branch: master Commit: 303294547399610a4eedcd382631e7d442fd76ad URL: https://github.com/kamailio/kamailio/commit/303294547399610a4eedcd382631e7d… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-09-05T08:01:33+02:00 modules: readme files regenerated - presence_xml ... [skip ci] --- Modified: src/modules/presence_xml/README --- Diff: https://github.com/kamailio/kamailio/commit/303294547399610a4eedcd382631e7d… Patch: https://github.com/kamailio/kamailio/commit/303294547399610a4eedcd382631e7d… --- diff --git a/src/modules/presence_xml/README b/src/modules/presence_xml/README index 4b26628d6a..045edce2d9 100644 --- a/src/modules/presence_xml/README +++ b/src/modules/presence_xml/README @@ -119,8 +119,8 @@ Chapter 1. Admin Guide * presence. * sl. * xcap_client. - Only compulsory if not using an integrated xcap server (if - 'integrated_xcap_server' parameter is not set). + Needed only when not using the integrated xcap server (if + 'integrated_xcap_server' parameter is set to 0). 2.2. External Libraries or Applications @@ -223,15 +223,15 @@ modparam("presence_xml", "force_active", 1) This parameter is a flag for the type of XCAP servers used. If the XCAP server is integrated with Kamailio presence_xml module and access the same database tables directly, like the embedded XCAP server - implemented in xcap_server module, the parameter should be set to a - positive value. Apart from updating in xcap table, if the integrated - server is not running on the same Kamailio instance, it must send an - RPC command presence.refreshWatchers [pres_uri] [event] when a user - modifies a rules document, to instruct the presence_xml module to - update states from the database and, if needed, send NOTIFY updates. - - Otherwise, it uses xcap_client module to fetch documents from the XCAP - servers with HTTP requests. + implemented in xcap_server module, the parameter has to be set to 1. + Apart from updating in xcap table, if the integrated server is not + running on the same Kamailio instance, it must send an RPC command + presence.refreshWatchers [pres_uri] [event] when a user modifies a + rules document, to instruct the presence_xml module to update states + from the database and, if needed, send NOTIFY updates. + + Otherwise (if set to 0) it uses xcap_client module to fetch documents + from the XCAP servers with HTTP requests. Default value is “0”.

1 0

git:master:6fbaac0d: presence_xml: small adjustments, added section ids
by Daniel-Constantin Mierla 05 Sep '17

05 Sep '17

Module: kamailio Branch: master Commit: 6fbaac0d9383da5fe30ea9d2e9671ab3dffd9694 URL: https://github.com/kamailio/kamailio/commit/6fbaac0d9383da5fe30ea9d2e9671ab… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-05T07:55:09+02:00 presence_xml: small adjustments, added section ids --- Modified: src/modules/presence_xml/doc/presence_xml_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/6fbaac0d9383da5fe30ea9d2e9671ab… Patch: https://github.com/kamailio/kamailio/commit/6fbaac0d9383da5fe30ea9d2e9671ab…

1 0

ipsec with kamailio pcscf
by Angaroni Marco 04 Sep '17

04 Sep '17

Hello, in the following email (about one year ago) it was mentioned that kamailio was close to having the capability to configure ipsec SAs dinamically by interacting with the OS. This is needed in pcscf AKA authentication procedure. https://lists.kamailio.org/pipermail/sr-dev/2016-June/035627.html I'm interested in knowing the current status of this feature. In latest (5.0.2) kamailio sources I was not able to find any sign of ipsec SA programming (setkey system()s, pfkey_*() calls, xfrm netlink messages). Anyone has news about this ? Thanks Internet Email Confidentiality Footer ******************************************************************************************************************************************** La presente comunicazione, con le informazioni in essa contenute e ogni documento o file allegato, e' rivolta unicamente alla/e persona/e cui e' indirizzata ed alle altre da questa autorizzata/e a riceverla. Se non siete i destinatari/autorizzati siete avvisati che qualsiasi azione, copia, comunicazione, divulgazione o simili basate sul contenuto di tali informazioni e' vietata e potrebbe essere contro la legge (art. 616 C.P., D.Lgs n. 196/2003 Codice in materia di protezione dei dati personali). Se avete ricevuto questa comunicazione per errore, vi preghiamo di darne immediata notizia al mittente e di distruggere il messaggio originale e ogni file allegato senza farne copia alcuna o riprodurne in alcun modo il contenuto. ***************** This e-mail and its attachments are intended for the addressee(s) only and are confidential and/or may contain legally privileged information. If you have received this message by mistake or are not one of the addressees above, you may take no action based on it, and you may not copy or show it to anyone; please reply to this e-mail and point out the error which has occurred. ********************************************************************************************************************************************

2 1

git:5.0:629d0dad: pkg/obs: more details in the readme
by Daniel-Constantin Mierla 04 Sep '17

04 Sep '17

Module: kamailio Branch: 5.0 Commit: 629d0dad29868926dc3ac8e60e15383ac681a7a2 URL: https://github.com/kamailio/kamailio/commit/629d0dad29868926dc3ac8e60e15383… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-04T16:17:04+02:00 pkg/obs: more details in the readme (cherry picked from commit 498e6a96fa101863170399e237cad66a8620a9e6) --- Modified: pkg/kamailio/obs/README --- Diff: https://github.com/kamailio/kamailio/commit/629d0dad29868926dc3ac8e60e15383… Patch: https://github.com/kamailio/kamailio/commit/629d0dad29868926dc3ac8e60e15383… --- diff --git a/pkg/kamailio/obs/README b/pkg/kamailio/obs/README index 5ab290bb29..113f5939e7 100644 --- a/pkg/kamailio/obs/README +++ b/pkg/kamailio/obs/README @@ -1,6 +1,16 @@ -This is RPM packaging scripts for openSUSE Build Service https://build.opensuse.org/ -Scitps build RPM pckages for following dists: -1) CentOS 6 and 7 -2) RHEL 6 and 7 -3) Fedora 25 adn 26 -4) openSUSE 42.2 and 42.3 +# RPM Specs For OpenSuse Build Service (OBS) # + +Here are the RPM packaging specs for openSUSE Build Service: + + * https://build.opensuse.org/ + +It builds RPM packages for following distributions: + + * CentOS 6 and 7 + * RHEL 6 and 7 + * Fedora 25 adn 26 + * openSUSE 42.2 and 42.3 + +Kamailio's RPMs bulding projects for various versions can be found at: + + * https://build.opensuse.org/project/subprojects/home:kamailio

1 0

git:5.0:0e201145: pkg/kamailio/OBS: Added RPM packaging scripts for openSUSE Build Service
by Daniel-Constantin Mierla 04 Sep '17

04 Sep '17

Module: kamailio Branch: 5.0 Commit: 0e201145cf9465c2752993867813ae8bff60336d URL: https://github.com/kamailio/kamailio/commit/0e201145cf9465c2752993867813ae8… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-04T16:16:49+02:00 pkg/kamailio/OBS: Added RPM packaging scripts for openSUSE Build Service (cherry picked from commit 2406f79169aac6a94a4a8f26aa50dd6291d821ec) --- Added: pkg/kamailio/obs/README Added: pkg/kamailio/obs/kamailio.init Added: pkg/kamailio/obs/kamailio.service Added: pkg/kamailio/obs/kamailio.spec Added: pkg/kamailio/obs/kamailio.sysconfig Added: pkg/kamailio/obs/kamailio.tmpfiles Added: pkg/kamailio/obs/meta --- Diff: https://github.com/kamailio/kamailio/commit/0e201145cf9465c2752993867813ae8… Patch: https://github.com/kamailio/kamailio/commit/0e201145cf9465c2752993867813ae8…

1 0

[kamailio/kamailio] pkg/kamailio/centos: Updated RPM spec file to support build fedora, RHEL, openSUSE (#1227)
by sergey-safarov 04 Sep '17

04 Sep '17

Updated RPM spec file to support build fedora, RHEL, openSUSE via openSUSE build service. Removed unnecessary RPM spec files You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1227 -- Commit Summary -- * pkg/kamailio/centos. Updated RPM spec file to support build fedora, RHEL, openSUSE via openSUSE build service * pkg/kamailio: Removed unnecessary RPM spec files -- File Changes -- A pkg/kamailio/centos/6 (1) D pkg/kamailio/centos/6/README (29) D pkg/kamailio/centos/6/kamailio.init (134) D pkg/kamailio/centos/6/kamailio.spec (1279) D pkg/kamailio/centos/6/kamailio.sysconfig (30) M pkg/kamailio/centos/7/kamailio.spec (558) D pkg/kamailio/fedora/17/README (67) D pkg/kamailio/fedora/17/kamailio-build.appl (49) D pkg/kamailio/fedora/17/kamailio.appl (42) D pkg/kamailio/fedora/17/kamailio.service (14) D pkg/kamailio/fedora/17/kamailio.spec (1325) D pkg/kamailio/fedora/17/kamailio.sysconfig (12) D pkg/kamailio/fedora/18/README (1) D pkg/kamailio/fedora/18/kamailio-build.appl (49) D pkg/kamailio/fedora/18/kamailio.appl (42) D pkg/kamailio/fedora/18/kamailio.service (1) D pkg/kamailio/fedora/18/kamailio.spec (1) D pkg/kamailio/fedora/18/kamailio.sysconfig (1) A pkg/kamailio/oracle (1) D pkg/kamailio/oracle/el6/kamailio.default (30) D pkg/kamailio/oracle/el6/kamailio.init (128) D pkg/kamailio/oracle/el6/kamailio.spec (852) D pkg/kamailio/oracle/el7/kamailio.service (17) D pkg/kamailio/oracle/el7/kamailio.spec (851) D pkg/kamailio/oracle/el7/kamailio.sysconfig (36) D pkg/kamailio/oracle/kamailio.logrotate (7) D pkg/kamailio/oracle/kamailio.rsyslog (2) D pkg/kamailio/rpm/kamailio.default (30) D pkg/kamailio/rpm/kamailio.init (128) D pkg/kamailio/rpm/kamailio.init.SuSE (133) D pkg/kamailio/rpm/kamailio.spec-4.1 (409) D pkg/kamailio/rpm/kamailio.spec.CenOS (745) D pkg/kamailio/rpm/kamailio.spec.SuSE (389) A pkg/kamailio/suse/1315 (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1227.patch https://github.com/kamailio/kamailio/pull/1227.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1227

2 7

[kamailio/kamailio] pkg/kamailio/OBS: Added RPM packaging scripts for openSUSE Build Service (#1228)
by sergey-safarov 04 Sep '17

04 Sep '17

This is RPM packaging scripts for openSUSE Build Service https://build.opensuse.org/ Scitps build RPM pckages for following dists: 1) CentOS 6 and 7 2) RHEL 6 and 7 3) Fedora 25 adn 26 4) openSUSE 42.2 and 42.3 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1228 -- Commit Summary -- * pkg/kamailio/OBS: Added RPM packaging scripts for openSUSE Build Service -- File Changes -- A pkg/kamailio/OBS/README (6) A pkg/kamailio/OBS/kamailio.init (141) A pkg/kamailio/OBS/kamailio.service (17) A pkg/kamailio/OBS/kamailio.spec (1756) A pkg/kamailio/OBS/kamailio.sysconfig (18) A pkg/kamailio/OBS/kamailio.tmpfiles (1) A pkg/kamailio/OBS/meta (43) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1228.patch https://github.com/kamailio/kamailio/pull/1228.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1228

2 2

git:master:498e6a96: pkg/obs: more details in the readme
by Daniel-Constantin Mierla 04 Sep '17

04 Sep '17

Module: kamailio Branch: master Commit: 498e6a96fa101863170399e237cad66a8620a9e6 URL: https://github.com/kamailio/kamailio/commit/498e6a96fa101863170399e237cad66… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-04T16:13:01+02:00 pkg/obs: more details in the readme --- Modified: pkg/kamailio/obs/README --- Diff: https://github.com/kamailio/kamailio/commit/498e6a96fa101863170399e237cad66… Patch: https://github.com/kamailio/kamailio/commit/498e6a96fa101863170399e237cad66… --- diff --git a/pkg/kamailio/obs/README b/pkg/kamailio/obs/README index 5ab290bb29..113f5939e7 100644 --- a/pkg/kamailio/obs/README +++ b/pkg/kamailio/obs/README @@ -1,6 +1,16 @@ -This is RPM packaging scripts for openSUSE Build Service https://build.opensuse.org/ -Scitps build RPM pckages for following dists: -1) CentOS 6 and 7 -2) RHEL 6 and 7 -3) Fedora 25 adn 26 -4) openSUSE 42.2 and 42.3 +# RPM Specs For OpenSuse Build Service (OBS) # + +Here are the RPM packaging specs for openSUSE Build Service: + + * https://build.opensuse.org/ + +It builds RPM packages for following distributions: + + * CentOS 6 and 7 + * RHEL 6 and 7 + * Fedora 25 adn 26 + * openSUSE 42.2 and 42.3 + +Kamailio's RPMs bulding projects for various versions can be found at: + + * https://build.opensuse.org/project/subprojects/home:kamailio

1 0

git:master:2406f791: pkg/kamailio/OBS: Added RPM packaging scripts for openSUSE Build Service
by Daniel-Constantin Mierla 04 Sep '17

04 Sep '17

Module: kamailio Branch: master Commit: 2406f79169aac6a94a4a8f26aa50dd6291d821ec URL: https://github.com/kamailio/kamailio/commit/2406f79169aac6a94a4a8f26aa50dd6… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-04T16:08:36+02:00 pkg/kamailio/OBS: Added RPM packaging scripts for openSUSE Build Service --- Added: pkg/kamailio/obs/README Added: pkg/kamailio/obs/kamailio.init Added: pkg/kamailio/obs/kamailio.service Added: pkg/kamailio/obs/kamailio.spec Added: pkg/kamailio/obs/kamailio.sysconfig Added: pkg/kamailio/obs/kamailio.tmpfiles Added: pkg/kamailio/obs/meta --- Diff: https://github.com/kamailio/kamailio/commit/2406f79169aac6a94a4a8f26aa50dd6… Patch: https://github.com/kamailio/kamailio/commit/2406f79169aac6a94a4a8f26aa50dd6…

1 0

[kamailio/kamailio] cannot build on fedora (#1226)
by sergey-safarov 04 Sep '17

04 Sep '17

### Description On Fedora distr package `radiusclient-ng` is replaced by `freeradius-client`. [More info](https://src.fedoraproject.org/rpms/radiusclient-ng/commits/master) After updating `spec` file build of `acc_radius_mod` is still not possible details of error ``` [ 529s] In file included from acc_radius_mod.c:44:0: [ 529s] ../misc_radius/radius.h:38:12: fatal error: radiusclient-ng.h: No such file or directory [ 529s] #include <radiusclient-ng.h> [ 529s] ^~~~~~~~~~~~~~~~~~~ [ 529s] compilation terminated. [ 529s] make[2]: *** [../../Makefile.rules:100: acc_radius_mod.o] Error 1 [ 529s] make[1]: *** [Makefile:511: modules] Error 1 [ 529s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/kamailio-5.0.3/src' [ 529s] make: *** [Makefile:27: every-module] Error 2 ``` Think need use package `freeradius-client` and if this not installed then try to use `radiusclient-ng`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1226

3 5

git:master:db00b5fd: alias_db: docs - added section ids
by Daniel-Constantin Mierla 03 Sep '17

03 Sep '17

Module: kamailio Branch: master Commit: db00b5fd0ecd65ee6164fdfeac3df90bdd2a4393 URL: https://github.com/kamailio/kamailio/commit/db00b5fd0ecd65ee6164fdfeac3df90… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-03T10:22:40+02:00 alias_db: docs - added section ids --- Modified: src/modules/alias_db/doc/alias_db_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/db00b5fd0ecd65ee6164fdfeac3df90… Patch: https://github.com/kamailio/kamailio/commit/db00b5fd0ecd65ee6164fdfeac3df90… --- diff --git a/src/modules/alias_db/doc/alias_db_admin.xml b/src/modules/alias_db/doc/alias_db_admin.xml index b67a971ca6..09c0f510b5 100644 --- a/src/modules/alias_db/doc/alias_db_admin.xml +++ b/src/modules/alias_db/doc/alias_db_admin.xml @@ -63,7 +63,7 @@ </section> <section> <title>Parameters</title> - <section> + <section id="alias_db.p.db_url"> <title><varname>db_url</varname> (str)</title> <para> Database URL. @@ -83,7 +83,7 @@ modparam("alias_db", "db_url", "&exampledb;") </example> </section> - <section> + <section id="alias_db.p.user_column"> <title><varname>user_column</varname> (str)</title> <para> Name of the column storing username. @@ -103,7 +103,7 @@ modparam("alias_db", "user_column", "susername") </example> </section> - <section> + <section id="alias_db.p.domain_column"> <title><varname>domain_column</varname> (str)</title> <para> Name of the column storing user's domain. @@ -123,7 +123,7 @@ modparam("alias_db", "domain_column", "sdomain") </example> </section> - <section> + <section id="alias_db.p.alias_user_column"> <title><varname>alias_user_column</varname> (str)</title> <para> Name of the column storing alias username. @@ -143,7 +143,7 @@ modparam("alias_db", "alias_user_column", "auser") </example> </section> - <section> + <section id="alias_db.p.alias_domain_column"> <title><varname>alias_domain_column</varname> (str)</title> <para> Name of the column storing alias domain. @@ -163,7 +163,7 @@ modparam("alias_db", "alias_domain_column", "adomain") </example> </section> - <section> + <section id="alias_db.p.use_domain"> <title><varname>use_domain</varname> (int)</title> <para> Specifies whether to use or not the domain from R-URI when searching @@ -185,7 +185,7 @@ modparam("alias_db", "use_domain", 1) </example> </section> - <section> + <section id="alias_db.p.domain_prefix"> <title><varname>domain_prefix</varname> (str)</title> <para> Specifies the prefix to be stripped from the domain in R-URI before @@ -206,7 +206,7 @@ modparam("alias_db", "domain_prefix", "sip.") </example> </section> - <section> + <section id="alias_db.p.append_branches"> <title><varname>append_branches</varname> (int)</title> <para> If the alias resolves to many SIP IDs, the first is replacing @@ -231,7 +231,7 @@ modparam("alias_db", "append_branches", 1) <section> <title>Functions</title> - <section> + <section id="alias_db.f.alias_db_lookup"> <title> <function moreinfo="none">alias_db_lookup(table_name [,flags])</function> </title> @@ -290,7 +290,7 @@ alias_db_lookup("dba_$(rU{s.substr,0,1})"); </programlisting> </example> </section> - <section> + <section id="alias_db.p.alias_db_find"> <title> <function moreinfo="none">alias_db_find( table_name , input, output [,flags] )</function> </title>

1 0

git:master:ab08d6de: auth_db: docs - small cleanups
by Daniel-Constantin Mierla 03 Sep '17

03 Sep '17

Module: kamailio Branch: master Commit: ab08d6def9fa060cb6568bc13eec328078dd4e04 URL: https://github.com/kamailio/kamailio/commit/ab08d6def9fa060cb6568bc13eec328… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-03T10:18:57+02:00 auth_db: docs - small cleanups --- Modified: src/modules/auth_db/doc/auth_db_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ab08d6def9fa060cb6568bc13eec328… Patch: https://github.com/kamailio/kamailio/commit/ab08d6def9fa060cb6568bc13eec328…

1 0

git:master:25c9e1b5: xmlrpc: coherent indentation and white spacing
by Daniel-Constantin Mierla 02 Sep '17

02 Sep '17

Module: kamailio Branch: master Commit: 25c9e1b5f6bb81ef1ec730b8400cdef66c119089 URL: https://github.com/kamailio/kamailio/commit/25c9e1b5f6bb81ef1ec730b8400cdef… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-02T13:28:21+02:00 xmlrpc: coherent indentation and white spacing --- Modified: src/modules/xmlrpc/http.c Modified: src/modules/xmlrpc/http.h Modified: src/modules/xmlrpc/xmlrpc.c --- Diff: https://github.com/kamailio/kamailio/commit/25c9e1b5f6bb81ef1ec730b8400cdef… Patch: https://github.com/kamailio/kamailio/commit/25c9e1b5f6bb81ef1ec730b8400cdef…

1 0

Kamailio v5.0.3 Released
by Daniel-Constantin Mierla 01 Sep '17

01 Sep '17

Hello, Kamailio SIP Server v5.0.3 stable release is out! This is a maintenance release of the latest stable branch, 5.0, that includes fixes since the release of v5.0.2. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.0.x. Deployments running previous 5.0.x versions are strongly recommended to be upgraded to v5.0.3. For more details about version 5.0.3 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2017/09/kamailio-v5-0-3-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda

2 2

git:5.0:39b9a1e0: ChangeLog: new content updated for v5.0.3
by Daniel-Constantin Mierla 01 Sep '17

01 Sep '17

Module: kamailio Branch: 5.0 Commit: 39b9a1e0b05c05c50656588a863b564fd0708a6d URL: https://github.com/kamailio/kamailio/commit/39b9a1e0b05c05c50656588a863b564… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-01T12:25:18+02:00 ChangeLog: new content updated for v5.0.3 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/39b9a1e0b05c05c50656588a863b564… Patch: https://github.com/kamailio/kamailio/commit/39b9a1e0b05c05c50656588a863b564…

1 0

git:5.0:827ce8ad: Makefile.defs: version set to 5.0.3
by Daniel-Constantin Mierla 01 Sep '17

01 Sep '17

Module: kamailio Branch: 5.0 Commit: 827ce8ad054d16de296b195111770be225ebc0b0 URL: https://github.com/kamailio/kamailio/commit/827ce8ad054d16de296b195111770be… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-01T12:20:36+02:00 Makefile.defs: version set to 5.0.3 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/827ce8ad054d16de296b195111770be… Patch: https://github.com/kamailio/kamailio/commit/827ce8ad054d16de296b195111770be… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index d53e5f0181..28c51588d2 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -106,7 +106,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) # version number VERSION = 5 PATCHLEVEL = 0 -SUBLEVEL = 2 +SUBLEVEL = 3 EXTRAVERSION = # memory manager switcher

1 0

git:5.0:1dd66b7c: core: main - don't count wtimer secondary process separately
by Daniel-Constantin Mierla 01 Sep '17

01 Sep '17

Module: kamailio Branch: 5.0 Commit: 1dd66b7ca9943ac1f172db2fe1b2f073736eb93b URL: https://github.com/kamailio/kamailio/commit/1dd66b7ca9943ac1f172db2fe1b2f07… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-01T12:08:13+02:00 core: main - don't count wtimer secondary process separately - it is registered via sr_wtimer_init() - fixes the extra empty entry in process table reported by Juha Heinanen (cherry picked from commit ec15b23f25ba2502a661157ae69b4dc1db923f66) --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/1dd66b7ca9943ac1f172db2fe1b2f07… Patch: https://github.com/kamailio/kamailio/commit/1dd66b7ca9943ac1f172db2fe1b2f07… --- diff --git a/src/main.c b/src/main.c index 0aff706ffb..143238078d 100644 --- a/src/main.c +++ b/src/main.c @@ -1324,13 +1324,12 @@ int main_loop(void) LM_CRIT("could not initialize shared configuration\n"); goto error; } - + /* Register the children that will keep updating their * local configuration */ cfg_register_child( 1 /* main = udp listener */ + 1 /* timer */ - + 1 /* wtimer */ #ifdef USE_SLOW_TIMER + 1 /* slow timer */ #endif @@ -1433,7 +1432,6 @@ int main_loop(void) * will be added later.) */ cfg_register_child( 1 /* timer */ - + 1 /* wtimer */ #ifdef USE_SLOW_TIMER + 1 /* slow timer */ #endif @@ -1824,7 +1822,6 @@ static int calc_proc_no(void) #ifdef USE_SLOW_TIMER + 1 /* slow timer process */ #endif - + 1 /* wtimer process */ #ifdef USE_TCP +((!tcp_disable)?( 1/* tcp main */ + tcp_listeners ):0) #endif

1 0

git:5.0:d4266724: pkg: rpm - version set to 5.0.3 in specs
by Daniel-Constantin Mierla 01 Sep '17

01 Sep '17

Module: kamailio Branch: 5.0 Commit: d4266724bacb8fd30b30c70ff6664bbcd1673a78 URL: https://github.com/kamailio/kamailio/commit/d4266724bacb8fd30b30c70ff6664bb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-01T12:20:05+02:00 pkg: rpm - version set to 5.0.3 in specs --- Modified: pkg/kamailio/centos/6/kamailio.spec Modified: pkg/kamailio/centos/7/kamailio.spec Modified: pkg/kamailio/fedora/17/kamailio.spec Modified: pkg/kamailio/oracle/el6/kamailio.spec Modified: pkg/kamailio/oracle/el7/kamailio.spec Modified: pkg/kamailio/rpm/kamailio.spec-4.1 Modified: pkg/kamailio/rpm/kamailio.spec.CenOS Modified: pkg/kamailio/rpm/kamailio.spec.SuSE --- Diff: https://github.com/kamailio/kamailio/commit/d4266724bacb8fd30b30c70ff6664bb… Patch: https://github.com/kamailio/kamailio/commit/d4266724bacb8fd30b30c70ff6664bb… --- diff --git a/pkg/kamailio/centos/6/kamailio.spec b/pkg/kamailio/centos/6/kamailio.spec index bd1259f670..b5f9f76b95 100644 --- a/pkg/kamailio/centos/6/kamailio.spec +++ b/pkg/kamailio/centos/6/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.0.2 +%define ver 5.0.3 %define rel dev0.0%{dist} diff --git a/pkg/kamailio/centos/7/kamailio.spec b/pkg/kamailio/centos/7/kamailio.spec index 71666c13df..b5aae3791f 100644 --- a/pkg/kamailio/centos/7/kamailio.spec +++ b/pkg/kamailio/centos/7/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.0.2 +%define ver 5.0.3 %define rel dev0.0%{dist} %bcond_with dnssec %bcond_with kazoo diff --git a/pkg/kamailio/fedora/17/kamailio.spec b/pkg/kamailio/fedora/17/kamailio.spec index 0cac9c2722..1c29158913 100644 --- a/pkg/kamailio/fedora/17/kamailio.spec +++ b/pkg/kamailio/fedora/17/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.0.2 +%define ver 5.0.3 %define rel dev7.2%{dist} diff --git a/pkg/kamailio/oracle/el6/kamailio.spec b/pkg/kamailio/oracle/el6/kamailio.spec index 6c4ba800e5..2981d3b38f 100644 --- a/pkg/kamailio/oracle/el6/kamailio.spec +++ b/pkg/kamailio/oracle/el6/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.0.2 +%define ver 5.0.3 %define rel 0 %define _sharedir %{_prefix}/share diff --git a/pkg/kamailio/oracle/el7/kamailio.spec b/pkg/kamailio/oracle/el7/kamailio.spec index a7dd26ecce..17cbf264f7 100644 --- a/pkg/kamailio/oracle/el7/kamailio.spec +++ b/pkg/kamailio/oracle/el7/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.0.2 +%define ver 5.0.3 %define rel 0 %define _sharedir %{_prefix}/share diff --git a/pkg/kamailio/rpm/kamailio.spec-4.1 b/pkg/kamailio/rpm/kamailio.spec-4.1 index e92f0024df..7a5dc75158 100644 --- a/pkg/kamailio/rpm/kamailio.spec-4.1 +++ b/pkg/kamailio/rpm/kamailio.spec-4.1 @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.0.2 +%define ver 5.0.3 %define rel 0 %define EXCLUDED_MODULES mysql jabber cpl-c avp_radius auth_radius group_radius uri_radius pa postgres osp tlsops unixodbc diff --git a/pkg/kamailio/rpm/kamailio.spec.CenOS b/pkg/kamailio/rpm/kamailio.spec.CenOS index 76680f7f89..28160e197a 100644 --- a/pkg/kamailio/rpm/kamailio.spec.CenOS +++ b/pkg/kamailio/rpm/kamailio.spec.CenOS @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.0.2 +%define ver 5.0.3 %define rel 0 %define _sharedir %{_prefix}/share diff --git a/pkg/kamailio/rpm/kamailio.spec.SuSE b/pkg/kamailio/rpm/kamailio.spec.SuSE index d390f0f8f2..8a253fe425 100644 --- a/pkg/kamailio/rpm/kamailio.spec.SuSE +++ b/pkg/kamailio/rpm/kamailio.spec.SuSE @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.0.2 +%define ver 5.0.3 %define rel 0 %define EXCLUDED_MODULES mysql jabber cpl-c auth_radius misc_radius peering postgress pa unixodbc osp tlsops

1 0

git:5.0:f6c77135: core: pt - debug messages when registering app processes
by Daniel-Constantin Mierla 01 Sep '17

01 Sep '17

Module: kamailio Branch: 5.0 Commit: f6c771350756c2b2538c92f701596033b1eea53c URL: https://github.com/kamailio/kamailio/commit/f6c771350756c2b2538c92f70159603… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-01T12:08:03+02:00 core: pt - debug messages when registering app processes (cherry picked from commit bffb6b8374b087799b1979e2ba935dc130436987) --- Modified: src/core/pt.c --- Diff: https://github.com/kamailio/kamailio/commit/f6c771350756c2b2538c92f70159603… Patch: https://github.com/kamailio/kamailio/commit/f6c771350756c2b2538c92f70159603…

1 0

git:master:ec15b23f: core: main - don't count wtimer secondary process separately
by Daniel-Constantin Mierla 01 Sep '17

01 Sep '17

Module: kamailio Branch: master Commit: ec15b23f25ba2502a661157ae69b4dc1db923f66 URL: https://github.com/kamailio/kamailio/commit/ec15b23f25ba2502a661157ae69b4dc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-01T12:00:06+02:00 core: main - don't count wtimer secondary process separately - it is registered via sr_wtimer_init() - fixes the extra empty entry in process table reported by Juha Heinanen --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/ec15b23f25ba2502a661157ae69b4dc… Patch: https://github.com/kamailio/kamailio/commit/ec15b23f25ba2502a661157ae69b4dc… --- diff --git a/src/main.c b/src/main.c index b65b0020ca..56ea58a47d 100644 --- a/src/main.c +++ b/src/main.c @@ -1327,13 +1327,12 @@ int main_loop(void) LM_CRIT("could not initialize shared configuration\n"); goto error; } - + /* Register the children that will keep updating their * local configuration */ cfg_register_child( 1 /* main = udp listener */ + 1 /* timer */ - + 1 /* wtimer */ #ifdef USE_SLOW_TIMER + 1 /* slow timer */ #endif @@ -1436,7 +1435,6 @@ int main_loop(void) * will be added later.) */ cfg_register_child( 1 /* timer */ - + 1 /* wtimer */ #ifdef USE_SLOW_TIMER + 1 /* slow timer */ #endif @@ -1827,7 +1825,6 @@ static int calc_proc_no(void) #ifdef USE_SLOW_TIMER + 1 /* slow timer process */ #endif - + 1 /* wtimer process */ #ifdef USE_TCP +((!tcp_disable)?( 1/* tcp main */ + tcp_listeners ):0) #endif

1 0

git:master:bffb6b83: core: pt - debug messages when registering app processes
by Daniel-Constantin Mierla 01 Sep '17

01 Sep '17

Module: kamailio Branch: master Commit: bffb6b8374b087799b1979e2ba935dc130436987 URL: https://github.com/kamailio/kamailio/commit/bffb6b8374b087799b1979e2ba935dc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-01T11:58:54+02:00 core: pt - debug messages when registering app processes --- Modified: src/core/pt.c --- Diff: https://github.com/kamailio/kamailio/commit/bffb6b8374b087799b1979e2ba935dc… Patch: https://github.com/kamailio/kamailio/commit/bffb6b8374b087799b1979e2ba935dc…

1 0

git:5.0:556e066b: pkg/kamailio/deb: version set to 5.0.3
by Victor Seva 01 Sep '17

01 Sep '17

Module: kamailio Branch: 5.0 Commit: 556e066b084099ef89e63ec397e9a431eef33b3b URL: https://github.com/kamailio/kamailio/commit/556e066b084099ef89e63ec397e9a43… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-09-01T10:58:32+02:00 pkg/kamailio/deb: version set to 5.0.3 --- Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/556e066b084099ef89e63ec397e9a43… Patch: https://github.com/kamailio/kamailio/commit/556e066b084099ef89e63ec397e9a43… --- diff --git a/pkg/kamailio/deb/debian/changelog b/pkg/kamailio/deb/debian/changelog index 477f56c729..08f8f4a163 100644 --- a/pkg/kamailio/deb/debian/changelog +++ b/pkg/kamailio/deb/debian/changelog @@ -1,3 +1,9 @@ +kamailio (5.0.3) unstable; urgency=medium + + * version set to 5.0.3 + + -- Victor Seva <vseva(a)debian.org> Fri, 01 Sep 2017 10:57:51 +0200 + kamailio (5.0.2) unstable; urgency=medium * version set to 5.0.2 diff --git a/pkg/kamailio/deb/jessie/changelog b/pkg/kamailio/deb/jessie/changelog index 477f56c729..08f8f4a163 100644 --- a/pkg/kamailio/deb/jessie/changelog +++ b/pkg/kamailio/deb/jessie/changelog @@ -1,3 +1,9 @@ +kamailio (5.0.3) unstable; urgency=medium + + * version set to 5.0.3 + + -- Victor Seva <vseva(a)debian.org> Fri, 01 Sep 2017 10:57:51 +0200 + kamailio (5.0.2) unstable; urgency=medium * version set to 5.0.2 diff --git a/pkg/kamailio/deb/precise/changelog b/pkg/kamailio/deb/precise/changelog index 477f56c729..08f8f4a163 100644 --- a/pkg/kamailio/deb/precise/changelog +++ b/pkg/kamailio/deb/precise/changelog @@ -1,3 +1,9 @@ +kamailio (5.0.3) unstable; urgency=medium + + * version set to 5.0.3 + + -- Victor Seva <vseva(a)debian.org> Fri, 01 Sep 2017 10:57:51 +0200 + kamailio (5.0.2) unstable; urgency=medium * version set to 5.0.2 diff --git a/pkg/kamailio/deb/sid/changelog b/pkg/kamailio/deb/sid/changelog index 477f56c729..08f8f4a163 100644 --- a/pkg/kamailio/deb/sid/changelog +++ b/pkg/kamailio/deb/sid/changelog @@ -1,3 +1,9 @@ +kamailio (5.0.3) unstable; urgency=medium + + * version set to 5.0.3 + + -- Victor Seva <vseva(a)debian.org> Fri, 01 Sep 2017 10:57:51 +0200 + kamailio (5.0.2) unstable; urgency=medium * version set to 5.0.2 diff --git a/pkg/kamailio/deb/stretch/changelog b/pkg/kamailio/deb/stretch/changelog index 477f56c729..08f8f4a163 100644 --- a/pkg/kamailio/deb/stretch/changelog +++ b/pkg/kamailio/deb/stretch/changelog @@ -1,3 +1,9 @@ +kamailio (5.0.3) unstable; urgency=medium + + * version set to 5.0.3 + + -- Victor Seva <vseva(a)debian.org> Fri, 01 Sep 2017 10:57:51 +0200 + kamailio (5.0.2) unstable; urgency=medium * version set to 5.0.2 diff --git a/pkg/kamailio/deb/trusty/changelog b/pkg/kamailio/deb/trusty/changelog index 477f56c729..08f8f4a163 100644 --- a/pkg/kamailio/deb/trusty/changelog +++ b/pkg/kamailio/deb/trusty/changelog @@ -1,3 +1,9 @@ +kamailio (5.0.3) unstable; urgency=medium + + * version set to 5.0.3 + + -- Victor Seva <vseva(a)debian.org> Fri, 01 Sep 2017 10:57:51 +0200 + kamailio (5.0.2) unstable; urgency=medium * version set to 5.0.2 diff --git a/pkg/kamailio/deb/wheezy/changelog b/pkg/kamailio/deb/wheezy/changelog index 477f56c729..08f8f4a163 100644 --- a/pkg/kamailio/deb/wheezy/changelog +++ b/pkg/kamailio/deb/wheezy/changelog @@ -1,3 +1,9 @@ +kamailio (5.0.3) unstable; urgency=medium + + * version set to 5.0.3 + + -- Victor Seva <vseva(a)debian.org> Fri, 01 Sep 2017 10:57:51 +0200 + kamailio (5.0.2) unstable; urgency=medium * version set to 5.0.2 diff --git a/pkg/kamailio/deb/xenial/changelog b/pkg/kamailio/deb/xenial/changelog index 477f56c729..08f8f4a163 100644 --- a/pkg/kamailio/deb/xenial/changelog +++ b/pkg/kamailio/deb/xenial/changelog @@ -1,3 +1,9 @@ +kamailio (5.0.3) unstable; urgency=medium + + * version set to 5.0.3 + + -- Victor Seva <vseva(a)debian.org> Fri, 01 Sep 2017 10:57:51 +0200 + kamailio (5.0.2) unstable; urgency=medium * version set to 5.0.2

1 0

Planning Kamailio v5.0.3
by Daniel-Constantin Mierla 01 Sep '17

01 Sep '17

Hello, I am considering to release Kamailio v5.0.3 sometime next week, therefore it is the time to backport patches with fixes from master that apply to 5.0 branch. If you are aware of such fix that has to be backported, reply here or make a pull request on github project. Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - www.asipto.com Kamailio World Conference - www.kamailioworld.com

1 2

git:5.0:d08c1256: core: tcp - print reason in tcp emit closed event debug message
by Daniel-Constantin Mierla 31 Aug '17

31 Aug '17

Module: kamailio Branch: 5.0 Commit: d08c1256939a148d7fd6b3c71b2947f431c56178 URL: https://github.com/kamailio/kamailio/commit/d08c1256939a148d7fd6b3c71b2947f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T15:50:09+02:00 core: tcp - print reason in tcp emit closed event debug message (cherry picked from commit 83724225ebc3ed778e7bacb487e3d3376e47e504) --- Modified: src/core/tcp_read.c --- Diff: https://github.com/kamailio/kamailio/commit/d08c1256939a148d7fd6b3c71b2947f… Patch: https://github.com/kamailio/kamailio/commit/d08c1256939a148d7fd6b3c71b2947f… --- diff --git a/src/core/tcp_read.c b/src/core/tcp_read.c index 824239e39e..b2a9e9fbe8 100644 --- a/src/core/tcp_read.c +++ b/src/core/tcp_read.c @@ -192,14 +192,14 @@ static int tcp_emit_closed_event(struct tcp_connection *con, enum tcp_closed_rea tcp_closed_event_info_t tev; ret = 0; - LM_DBG("TCP closed event creation triggered\n"); + LM_DBG("TCP closed event creation triggered (reason: %d)\n", reason); if(likely(sr_event_enabled(SREV_TCP_CLOSED))) { memset(&tev, 0, sizeof(tcp_closed_event_info_t)); tev.reason = reason; tev.con = con; ret = sr_event_exec(SREV_TCP_CLOSED, (void*)(&tev)); } else { - LM_DBG("no callback registering for handling TCP closed event - dropping!\n"); + LM_DBG("no callback registering for handling TCP closed event\n"); } return ret; }

1 0

git:master:83724225: core: tcp - print reason in tcp emit closed event debug message
by Daniel-Constantin Mierla 31 Aug '17

31 Aug '17

Module: kamailio Branch: master Commit: 83724225ebc3ed778e7bacb487e3d3376e47e504 URL: https://github.com/kamailio/kamailio/commit/83724225ebc3ed778e7bacb487e3d33… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T15:48:54+02:00 core: tcp - print reason in tcp emit closed event debug message --- Modified: src/core/tcp_read.c --- Diff: https://github.com/kamailio/kamailio/commit/83724225ebc3ed778e7bacb487e3d33… Patch: https://github.com/kamailio/kamailio/commit/83724225ebc3ed778e7bacb487e3d33… --- diff --git a/src/core/tcp_read.c b/src/core/tcp_read.c index db3707b39e..f786fb2f6f 100644 --- a/src/core/tcp_read.c +++ b/src/core/tcp_read.c @@ -193,7 +193,7 @@ static int tcp_emit_closed_event(struct tcp_connection *con, enum tcp_closed_rea sr_event_param_t evp = {0}; ret = 0; - LM_DBG("TCP closed event creation triggered\n"); + LM_DBG("TCP closed event creation triggered (reason: %d)\n", reason); if(likely(sr_event_enabled(SREV_TCP_CLOSED))) { memset(&tev, 0, sizeof(tcp_closed_event_info_t)); tev.reason = reason; @@ -201,7 +201,7 @@ static int tcp_emit_closed_event(struct tcp_connection *con, enum tcp_closed_rea evp.data = (void*)(&tev); ret = sr_event_exec(SREV_TCP_CLOSED, &evp); } else { - LM_DBG("no callback registering for handling TCP closed event - dropping!\n"); + LM_DBG("no callback registering for handling TCP closed event\n"); } return ret; }

1 0

[kamailio/kamailio] when using db_text, can't use relative path, only full path is working in kamailio 4.4 (#1224)
by Jurijs Ivolga 31 Aug '17

31 Aug '17

### Description when using db_text, can't use relative path, only full path is working in kamailio 4.4 modparam("lcr", "db_url", "text://dbtext") -- do not work modparam("lcr", "db_url", "text:///usr/local/etc/kamailio/dbtext") -- works as expected ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` 0(1) DEBUG: db_text [dbt_file.c:104]: dbt_load_file(): db is [/usr/local/etc/kamailio/] 0(1) DEBUG: db_text [dbt_file.c:119]: dbt_load_file(): loading file [/usr/local/etc/kamailio/] 0(1) DEBUG: db_text [dbt_tb.c:181]: dbt_table_new(): mtime is 1504165928 0(1) ERROR: db_text [dbt_base.c:215]: dbt_query(): table version not loaded! (too few columns) 0(1) ERROR: db_text [dbt_base.c:357]: dbt_query(): failed to query the table! 0(1) ERROR: <core> [db.c:397]: db_table_version(): error in db_query 0(1) ERROR: <core> [db.c:436]: db_check_table_version(): querying version for table lcr_rule 0(1) ERROR: lcr [lcr_mod.c:649]: mod_init(): error during table version check 0(1) ERROR: <core> [sr_module.c:967]: init_mod(): Error while initializing module lcr (/usr/local/lib64/kamailio/modules/lcr.so) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  use full path ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 4.4.6 (x86_64/linux) 897942 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 897942 compiled on 06:27:57 Aug 31 2017 with gcc 6.3.0 ``` * **Operating System**:  ``` Debian GNU/Linux 9 \n \l 4.4.0-87-generic #110-Ubuntu SMP Tue Jul 18 12:55:35 UTC 2017 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1224

2 8

git:4.4:75f13d03: db_text: fix computing absolute path to db using cfg dir
by Daniel-Constantin Mierla 31 Aug '17

31 Aug '17

Module: kamailio Branch: 4.4 Commit: 75f13d032b44fd520216101d38a4845f9d27b12e URL: https://github.com/kamailio/kamailio/commit/75f13d032b44fd520216101d38a4845… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T12:43:46+02:00 db_text: fix computing absolute path to db using cfg dir - reported by GH #1224 (cherry picked from commit f74cddd78df3f37f6ea827fc1787796c601572b3) (cherry picked from commit 630bf041fd0530368c73a6329c894a8758484ed7) --- Modified: modules/db_text/dbt_base.c Modified: modules/db_text/dbt_file.c --- Diff: https://github.com/kamailio/kamailio/commit/75f13d032b44fd520216101d38a4845… Patch: https://github.com/kamailio/kamailio/commit/75f13d032b44fd520216101d38a4845… --- diff --git a/modules/db_text/dbt_base.c b/modules/db_text/dbt_base.c index e8b3d1fc1d..c9ccb7fa43 100644 --- a/modules/db_text/dbt_base.c +++ b/modules/db_text/dbt_base.c @@ -52,6 +52,7 @@ db1_con_t* dbt_init(const str* _sqlurl) LM_ERR("invalid parameter value\n"); return NULL; } + LM_DBG("initializing for db url: [%.*s]\n", _sqlurl->len, _sqlurl->s); _s.s = _sqlurl->s; _s.len = _sqlurl->len; if(_s.len <= DBT_ID_LEN || strncmp(_s.s, DBT_ID, DBT_ID_LEN)!=0) @@ -68,16 +69,22 @@ db1_con_t* dbt_init(const str* _sqlurl) _s.len -= DBT_ID_LEN; if(_s.s[0]!='/') { - if(sizeof(CFG_DIR)+_s.len+2 > DBT_PATH_LEN) + if(sizeof(CFG_DIR)+_s.len+2 >= DBT_PATH_LEN) { LM_ERR("path to database is too long\n"); return NULL; } strcpy(dbt_path, CFG_DIR); - dbt_path[sizeof(CFG_DIR)] = '/'; - strncpy(&dbt_path[sizeof(CFG_DIR)+1], _s.s, _s.len); - _s.len += sizeof(CFG_DIR); + if(dbt_path[sizeof(CFG_DIR)-2]!='/') { + dbt_path[sizeof(CFG_DIR)-1] = '/'; + strncpy(&dbt_path[sizeof(CFG_DIR)], _s.s, _s.len); + _s.len += sizeof(CFG_DIR); + } else { + strncpy(&dbt_path[sizeof(CFG_DIR)-1], _s.s, _s.len); + _s.len += sizeof(CFG_DIR) - 1; + } _s.s = dbt_path; + LM_DBG("updated db url: [%.*s]\n", _s.len, _s.s); } _res = pkg_malloc(sizeof(db1_con_t)+sizeof(dbt_con_t)); diff --git a/modules/db_text/dbt_file.c b/modules/db_text/dbt_file.c index eac2b73672..af4423c081 100644 --- a/modules/db_text/dbt_file.c +++ b/modules/db_text/dbt_file.c @@ -91,17 +91,18 @@ dbt_table_p dbt_load_file(const str *tbn, const str *dbn) dbt_table_p dtp = NULL; dbt_column_p colp, colp0 = NULL; dbt_row_p rowp, rowp0 = NULL; - + enum {DBT_FLINE_ST, DBT_NLINE_ST, DBT_DATA_ST} state; - - LM_DBG("request for table [%.*s]\n", tbn->len, tbn->s); - + if(!tbn || !tbn->s || tbn->len<=0 || tbn->len>=255) return NULL; + + LM_DBG("request for table [%.*s] (len: %d)\n", tbn->len, tbn->s, tbn->len); + path[0] = 0; if(dbn && dbn->s && dbn->len>0) { - LM_DBG("db is [%.*s]\n", dbn->len, dbn->s); + LM_DBG("db is [%.*s] (len: %d)\n", dbn->len, dbn->s, dbn->len); if(dbn->len+tbn->len<511) { strncpy(path, dbn->s, dbn->len); @@ -115,12 +116,14 @@ dbt_table_p dbt_load_file(const str *tbn, const str *dbn) strncpy(path, tbn->s, tbn->len); path[tbn->len] = 0; } - LM_DBG("loading file [%s]\n", path); + fin = fopen(path, "rt"); - if(!fin) - return NULL; - + if(!fin) { + LM_ERR("failed to open file [%s]\n", path); + return NULL; + } + buf = pkg_malloc(_db_text_read_buffer_size); if(!buf) { LM_ERR("error allocating read buffer, %i\n", _db_text_read_buffer_size);

1 0

git:5.0:630bf041: db_text: fix computing absolute path to db using cfg dir
by Daniel-Constantin Mierla 31 Aug '17

31 Aug '17

Module: kamailio Branch: 5.0 Commit: 630bf041fd0530368c73a6329c894a8758484ed7 URL: https://github.com/kamailio/kamailio/commit/630bf041fd0530368c73a6329c894a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T12:39:54+02:00 db_text: fix computing absolute path to db using cfg dir - reported by GH #1224 (cherry picked from commit f74cddd78df3f37f6ea827fc1787796c601572b3) --- Modified: src/modules/db_text/dbt_base.c Modified: src/modules/db_text/dbt_file.c --- Diff: https://github.com/kamailio/kamailio/commit/630bf041fd0530368c73a6329c894a8… Patch: https://github.com/kamailio/kamailio/commit/630bf041fd0530368c73a6329c894a8… --- diff --git a/src/modules/db_text/dbt_base.c b/src/modules/db_text/dbt_base.c index 667301268f..f965b22d24 100644 --- a/src/modules/db_text/dbt_base.c +++ b/src/modules/db_text/dbt_base.c @@ -52,6 +52,7 @@ db1_con_t* dbt_init(const str* _sqlurl) LM_ERR("invalid parameter value\n"); return NULL; } + LM_DBG("initializing for db url: [%.*s]\n", _sqlurl->len, _sqlurl->s); _s.s = _sqlurl->s; _s.len = _sqlurl->len; if(_s.len <= DBT_ID_LEN || strncmp(_s.s, DBT_ID, DBT_ID_LEN)!=0) @@ -68,16 +69,22 @@ db1_con_t* dbt_init(const str* _sqlurl) _s.len -= DBT_ID_LEN; if(_s.s[0]!='/') { - if(sizeof(CFG_DIR)+_s.len+2 > DBT_PATH_LEN) + if(sizeof(CFG_DIR)+_s.len+2 >= DBT_PATH_LEN) { LM_ERR("path to database is too long\n"); return NULL; } strcpy(dbt_path, CFG_DIR); - dbt_path[sizeof(CFG_DIR)] = '/'; - strncpy(&dbt_path[sizeof(CFG_DIR)+1], _s.s, _s.len); - _s.len += sizeof(CFG_DIR); + if(dbt_path[sizeof(CFG_DIR)-2]!='/') { + dbt_path[sizeof(CFG_DIR)-1] = '/'; + strncpy(&dbt_path[sizeof(CFG_DIR)], _s.s, _s.len); + _s.len += sizeof(CFG_DIR); + } else { + strncpy(&dbt_path[sizeof(CFG_DIR)-1], _s.s, _s.len); + _s.len += sizeof(CFG_DIR) - 1; + } _s.s = dbt_path; + LM_DBG("updated db url: [%.*s]\n", _s.len, _s.s); } _res = pkg_malloc(sizeof(db1_con_t)+sizeof(dbt_con_t)); diff --git a/src/modules/db_text/dbt_file.c b/src/modules/db_text/dbt_file.c index 4dfa9f53f6..66984bae5a 100644 --- a/src/modules/db_text/dbt_file.c +++ b/src/modules/db_text/dbt_file.c @@ -94,14 +94,15 @@ dbt_table_p dbt_load_file(const str *tbn, const str *dbn) enum {DBT_FLINE_ST, DBT_NLINE_ST, DBT_DATA_ST} state; - LM_DBG("request for table [%.*s]\n", tbn->len, tbn->s); - if(!tbn || !tbn->s || tbn->len<=0 || tbn->len>=255) return NULL; + + LM_DBG("request for table [%.*s] (len: %d)\n", tbn->len, tbn->s, tbn->len); + path[0] = 0; if(dbn && dbn->s && dbn->len>0) { - LM_DBG("db is [%.*s]\n", dbn->len, dbn->s); + LM_DBG("db is [%.*s] (len: %d)\n", dbn->len, dbn->s, dbn->len); if(dbn->len+tbn->len<511) { strncpy(path, dbn->s, dbn->len); @@ -118,8 +119,10 @@ dbt_table_p dbt_load_file(const str *tbn, const str *dbn) LM_DBG("loading file [%s]\n", path); fin = fopen(path, "rt"); - if(!fin) + if(!fin) { + LM_ERR("failed to open file [%s]\n", path); return NULL; + } buf = pkg_malloc(_db_text_read_buffer_size); if(!buf) {

1 0

git:master:f74cddd7: db_text: fix computing absolute path to db using cfg dir
by Daniel-Constantin Mierla 31 Aug '17

31 Aug '17

Module: kamailio Branch: master Commit: f74cddd78df3f37f6ea827fc1787796c601572b3 URL: https://github.com/kamailio/kamailio/commit/f74cddd78df3f37f6ea827fc1787796… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T12:38:20+02:00 db_text: fix computing absolute path to db using cfg dir - reported by GH #1224 --- Modified: src/modules/db_text/dbt_base.c Modified: src/modules/db_text/dbt_file.c --- Diff: https://github.com/kamailio/kamailio/commit/f74cddd78df3f37f6ea827fc1787796… Patch: https://github.com/kamailio/kamailio/commit/f74cddd78df3f37f6ea827fc1787796… --- diff --git a/src/modules/db_text/dbt_base.c b/src/modules/db_text/dbt_base.c index 6db361679c..c850501952 100644 --- a/src/modules/db_text/dbt_base.c +++ b/src/modules/db_text/dbt_base.c @@ -52,6 +52,7 @@ db1_con_t* dbt_init(const str* _sqlurl) LM_ERR("invalid parameter value\n"); return NULL; } + LM_DBG("initializing for db url: [%.*s]\n", _sqlurl->len, _sqlurl->s); _s.s = _sqlurl->s; _s.len = _sqlurl->len; if(_s.len <= DBT_ID_LEN || strncmp(_s.s, DBT_ID, DBT_ID_LEN)!=0) @@ -68,16 +69,22 @@ db1_con_t* dbt_init(const str* _sqlurl) _s.len -= DBT_ID_LEN; if(_s.s[0]!='/') { - if(sizeof(CFG_DIR)+_s.len+2 > DBT_PATH_LEN) + if(sizeof(CFG_DIR)+_s.len+2 >= DBT_PATH_LEN) { LM_ERR("path to database is too long\n"); return NULL; } strcpy(dbt_path, CFG_DIR); - dbt_path[sizeof(CFG_DIR)] = '/'; - strncpy(&dbt_path[sizeof(CFG_DIR)+1], _s.s, _s.len); - _s.len += sizeof(CFG_DIR); + if(dbt_path[sizeof(CFG_DIR)-2]!='/') { + dbt_path[sizeof(CFG_DIR)-1] = '/'; + strncpy(&dbt_path[sizeof(CFG_DIR)], _s.s, _s.len); + _s.len += sizeof(CFG_DIR); + } else { + strncpy(&dbt_path[sizeof(CFG_DIR)-1], _s.s, _s.len); + _s.len += sizeof(CFG_DIR) - 1; + } _s.s = dbt_path; + LM_DBG("updated db url: [%.*s]\n", _s.len, _s.s); } _res = pkg_malloc(sizeof(db1_con_t)+sizeof(dbt_con_t)); diff --git a/src/modules/db_text/dbt_file.c b/src/modules/db_text/dbt_file.c index 25dc087614..a2d35c2406 100644 --- a/src/modules/db_text/dbt_file.c +++ b/src/modules/db_text/dbt_file.c @@ -94,14 +94,15 @@ dbt_table_p dbt_load_file(const str *tbn, const str *dbn) enum {DBT_FLINE_ST, DBT_NLINE_ST, DBT_DATA_ST} state; - LM_DBG("request for table [%.*s]\n", tbn->len, tbn->s); - if(!tbn || !tbn->s || tbn->len<=0 || tbn->len>=255) return NULL; + + LM_DBG("request for table [%.*s] (len: %d)\n", tbn->len, tbn->s, tbn->len); + path[0] = 0; if(dbn && dbn->s && dbn->len>0) { - LM_DBG("db is [%.*s]\n", dbn->len, dbn->s); + LM_DBG("db is [%.*s] (len: %d)\n", dbn->len, dbn->s, dbn->len); if(dbn->len+tbn->len<511) { strncpy(path, dbn->s, dbn->len); @@ -118,8 +119,10 @@ dbt_table_p dbt_load_file(const str *tbn, const str *dbn) LM_DBG("loading file [%s]\n", path); fin = fopen(path, "rt"); - if(!fin) + if(!fin) { + LM_ERR("failed to open file [%s]\n", path); return NULL; + } buf = pkg_malloc(_db_text_read_buffer_size); if(!buf) {

1 0

git:4.4:40b2b43e: db_text: more details in log message when nr of columns is too small
by Daniel-Constantin Mierla 31 Aug '17

31 Aug '17

Module: kamailio Branch: 4.4 Commit: 40b2b43e5919f05ef07f15a5f6802d83a2d1ddb6 URL: https://github.com/kamailio/kamailio/commit/40b2b43e5919f05ef07f15a5f6802d8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T11:38:55+02:00 db_text: more details in log message when nr of columns is too small (cherry picked from commit 2683b20d7b62f60ce53ed6692a42ed6b19fee972) (cherry picked from commit 4e9921d78032a850ca07bd604aa388f73bc3256a) --- Modified: modules/db_text/dbt_base.c --- Diff: https://github.com/kamailio/kamailio/commit/40b2b43e5919f05ef07f15a5f6802d8… Patch: https://github.com/kamailio/kamailio/commit/40b2b43e5919f05ef07f15a5f6802d8… --- diff --git a/modules/db_text/dbt_base.c b/modules/db_text/dbt_base.c index f0ad7139ec..e8b3d1fc1d 100644 --- a/modules/db_text/dbt_base.c +++ b/modules/db_text/dbt_base.c @@ -210,9 +210,10 @@ int dbt_query(db1_con_t* _h, db_key_t* _k, db_op_t* _op, db_val_t* _v, } - if(!_tbc || _tbc->nrcols < _nc) + if(_tbc->nrcols < _nc) { - LM_ERR("table %s not loaded! (too few columns)\n", CON_TABLE(_h)->s); + LM_ERR("table %s - too few columns (%d < %d)\n", CON_TABLE(_h)->s, + _tbc->nrcols, _nc); goto error; } if(_k)

1 0

[kamailio/kamailio] cfg grammar incompatible with Google Compute Engine's node FQDN format (#1223)
by Ivan Saldarriaga 31 Aug '17

31 Aug '17

### Description Running kamailio in kubernetes (steps [here](https://github.com/CyCoreSystems/astricon-2016/issues/1)) but getting an "invalid host or interface name" error when parsing the alias in kamailio.cfg As per https://github.com/kamailio/kamailio/blob/9df27ff7afbf1cf8ee7b3afd1741355e9… DOTS and MINUS are not allowed? GCE FQDN of server nodes currently have a format like this: ```gke-foo-cluster-default-pool-4b9e42c9-50mh.c.foo-project-0.internal``` ### Troubleshooting Doesn't exist. node names in the cloud are not customizable. #### Reproduction set the alias in kamailio.cfg to ```my-server.my-domain.internal``` #### Debugging Data N/A #### Log Messages ``` 2017-08-31T03:34:27Z gke-foo-cluster-default-pool-4b9e42c9-50mh confd[15]: INFO Backend set to env 2017-08-31T03:34:27Z gke-foo-cluster-default-pool-4b9e42c9-50mh confd[15]: INFO Starting confd 2017-08-31T03:34:27Z gke-foo-cluster-default-pool-4b9e42c9-50mh confd[15]: INFO Backend nodes set to 2017-08-31T03:34:27Z gke-foo-cluster-default-pool-4b9e42c9-50mh confd[15]: INFO /etc/kamailio/kamailio.cfg has md5sum 17481ad2235ef9698da57c6e90d5ac2b should be fb5d75c2654ab2264b11fab5802bd4b7 2017-08-31T03:34:27Z gke-foo-cluster-default-pool-4b9e42c9-50mh confd[15]: INFO Target config /etc/kamailio/kamailio.cfg out of sync 2017-08-31T03:34:27Z gke-foo-cluster-default-pool-4b9e42c9-50mh confd[15]: INFO Target config /etc/kamailio/kamailio.cfg has been updated 0(1) CRITICAL: <core> [cfg.y:3372]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 35, column 30-36: syntax error 0(1) CRITICAL: <core> [cfg.y:3372]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 35, column 30-36: invalid host or interface name 0(1) CRITICAL: <core> [cfg.y:3375]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 35, column 37: ERROR: bad config file (3 errors) ``` #### SIP Traffic N/A ### Possible Solutions Let the parser accept server and domain names with "-" ### Additional Information Kamailio version: upstream? as per the Dockerfile the image is coming from: ``` FROM debian:jessie # Debian Linux RUN apt-get update && apt-get install -y curl && apt-get clean # Install kamailio RUN curl -qO http://deb.kamailio.org/kamailiodebkey.gpg && \ apt-key add kamailiodebkey.gpg && \ echo "deb http://deb.kamailio.org/kamailio jessie main\ndeb-src http://deb.kamailio.org/kamailio jessie main" > /etc/apt/sources.list.d/kamailio.list RUN apt-get update && apt-get install -y kamailio kamailio-json-modules kamailio-postgres-modules kamailio-redis-modules kamailio-utils-modules && apt-get clean # Install confd (we need at least 0.7.0 for the "exists" function RUN curl -o /usr/sbin/confd -O -J -L "https://github.com/kelseyhightower/confd/releases/download/v0.11.0/confd-0.…" RUN chmod +x /usr/sbin/confd ``` * **Operating System**: Debian Jessie ``` Linux gke-foo-cluster-default-pool-4b9e42c9-50mh 4.4.52+ #1 SMP Thu Jun 15 15:23:01 PDT 2017 x86_64 GNU/Linux ``` Please confirm if this docker image is built from the Kamailio's upstream version in order to fix it if not. tks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1223

2 2

git:5.0:4e9921d7: db_text: more details in log message when nr of columns is too small
by Daniel-Constantin Mierla 31 Aug '17

31 Aug '17

Module: kamailio Branch: 5.0 Commit: 4e9921d78032a850ca07bd604aa388f73bc3256a URL: https://github.com/kamailio/kamailio/commit/4e9921d78032a850ca07bd604aa388f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T11:32:22+02:00 db_text: more details in log message when nr of columns is too small (cherry picked from commit 2683b20d7b62f60ce53ed6692a42ed6b19fee972) --- Modified: src/modules/db_text/dbt_base.c --- Diff: https://github.com/kamailio/kamailio/commit/4e9921d78032a850ca07bd604aa388f… Patch: https://github.com/kamailio/kamailio/commit/4e9921d78032a850ca07bd604aa388f… --- diff --git a/src/modules/db_text/dbt_base.c b/src/modules/db_text/dbt_base.c index 425d351f15..667301268f 100644 --- a/src/modules/db_text/dbt_base.c +++ b/src/modules/db_text/dbt_base.c @@ -211,9 +211,10 @@ int dbt_query(db1_con_t* _h, db_key_t* _k, db_op_t* _op, db_val_t* _v, } - if(!_tbc || _tbc->nrcols < _nc) + if(_tbc->nrcols < _nc) { - LM_ERR("table %s not loaded! (too few columns)\n", CON_TABLE(_h)->s); + LM_ERR("table %s - too few columns (%d < %d)\n", CON_TABLE(_h)->s, + _tbc->nrcols, _nc); goto error; } if(_k)

1 0

git:master:2683b20d: db_text: more details in log message when nr of columns is too small
by Daniel-Constantin Mierla 31 Aug '17

31 Aug '17

Module: kamailio Branch: master Commit: 2683b20d7b62f60ce53ed6692a42ed6b19fee972 URL: https://github.com/kamailio/kamailio/commit/2683b20d7b62f60ce53ed6692a42ed6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T11:31:33+02:00 db_text: more details in log message when nr of columns is too small --- Modified: src/modules/db_text/dbt_base.c --- Diff: https://github.com/kamailio/kamailio/commit/2683b20d7b62f60ce53ed6692a42ed6… Patch: https://github.com/kamailio/kamailio/commit/2683b20d7b62f60ce53ed6692a42ed6… --- diff --git a/src/modules/db_text/dbt_base.c b/src/modules/db_text/dbt_base.c index e32f0d88ec..6db361679c 100644 --- a/src/modules/db_text/dbt_base.c +++ b/src/modules/db_text/dbt_base.c @@ -212,9 +212,10 @@ int dbt_query(db1_con_t* _h, db_key_t* _k, db_op_t* _op, db_val_t* _v, } - if(!_tbc || _tbc->nrcols < _nc) + if(_tbc->nrcols < _nc) { - LM_ERR("table %s not loaded! (too few columns)\n", CON_TABLE(_h)->s); + LM_ERR("table %s - too few columns (%d < %d)\n", CON_TABLE(_h)->s, + _tbc->nrcols, _nc); goto error; } if(_k)

1 0

git:master:53afec49: core: clist - helper macro to test if a clist is empty
by Daniel-Constantin Mierla 31 Aug '17

31 Aug '17

Module: kamailio Branch: master Commit: 53afec4962e2dc3ec0971ba97da94f37c57780d3 URL: https://github.com/kamailio/kamailio/commit/53afec4962e2dc3ec0971ba97da94f3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T11:19:50+02:00 core: clist - helper macro to test if a clist is empty --- Modified: src/core/clist.h --- Diff: https://github.com/kamailio/kamailio/commit/53afec4962e2dc3ec0971ba97da94f3… Patch: https://github.com/kamailio/kamailio/commit/53afec4962e2dc3ec0971ba97da94f3… --- diff --git a/src/core/clist.h b/src/core/clist.h index 2b796e6ff4..143c61951c 100644 --- a/src/core/clist.h +++ b/src/core/clist.h @@ -15,8 +15,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ @@ -121,4 +121,10 @@ #define clist_foreach_safe(head, v, bak, dir) \ for((v)=(head)->dir, (bak)=(v)->dir; (v)!=(void*)(head); \ (v)=(bak), (bak)=(v)->dir) + +/*! \brief test if clist is empty (1 - empty; 0 - not empty)*/ +#define clist_empty(head, dir) \ + (((head)->dir!=(void*)(head))?0:1) + + #endif

1 0

git:master:1d8c6e43: tm: skip empty lists when listing transactions via rpc tm.list
by Daniel-Constantin Mierla 31 Aug '17

31 Aug '17

Module: kamailio Branch: master Commit: 1d8c6e4330fc069ed6606e0b966ece76053909b8 URL: https://github.com/kamailio/kamailio/commit/1d8c6e4330fc069ed6606e0b966ece7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T11:20:17+02:00 tm: skip empty lists when listing transactions via rpc tm.list --- Modified: src/modules/tm/t_stats.c --- Diff: https://github.com/kamailio/kamailio/commit/1d8c6e4330fc069ed6606e0b966ece7… Patch: https://github.com/kamailio/kamailio/commit/1d8c6e4330fc069ed6606e0b966ece7… --- diff --git a/src/modules/tm/t_stats.c b/src/modules/tm/t_stats.c index 5b1cc5fbbc..d6ae5f52e4 100644 --- a/src/modules/tm/t_stats.c +++ b/src/modules/tm/t_stats.c @@ -260,34 +260,37 @@ void tm_rpc_list(rpc_t* rpc, void* c) tm_cell_t *tcell; for (r=0; r<TABLE_ENTRIES; r++) { - if(_tm_table->entries[r].next_c!=NULL) { - if (rpc->add(c, "{", &h) < 0) { - LM_ERR("failed to add transaction structure\n"); - return; - } - lock_hash(r); - clist_foreach(&_tm_table->entries[r], tcell, next_c) - { - rpc->struct_add(h, "ddSSSSSsdddd", - "tindex", (unsigned)tcell->hash_index, - "tlabel", (unsigned)tcell->label, - "method", &tcell->method, - "from", &tcell->from, - "to", &tcell->to, - "callid", &tcell->callid, - "cseq", &tcell->cseq_n, - "uas_request", (tcell->uas.request)?"yes":"no", - "tflags", (unsigned)tcell->flags, - "outgoings", (unsigned)tcell->nr_of_outgoings, + lock_hash(r); + if(clist_empty(&_tm_table->entries[r], next_c)) { + unlock_hash(r); + continue; + } + if (rpc->add(c, "{", &h) < 0) { + LM_ERR("failed to add transaction structure\n"); + unlock_hash(r); + return; + } + clist_foreach(&_tm_table->entries[r], tcell, next_c) + { + rpc->struct_add(h, "ddSSSSSsdddd", + "tindex", (unsigned)tcell->hash_index, + "tlabel", (unsigned)tcell->label, + "method", &tcell->method, + "from", &tcell->from, + "to", &tcell->to, + "callid", &tcell->callid, + "cseq", &tcell->cseq_n, + "uas_request", (tcell->uas.request)?"yes":"no", + "tflags", (unsigned)tcell->flags, + "outgoings", (unsigned)tcell->nr_of_outgoings, #ifdef TM_DEL_UNREF - "ref_count", (unsigned)atomic_get(&tcell->ref_count), + "ref_count", (unsigned)atomic_get(&tcell->ref_count), #else - "ref_count", tcell->ref_count, + "ref_count", tcell->ref_count, #endif - "lifetime", (unsigned)TICKS_TO_S(tcell->end_of_life) - ); - } - unlock_hash(r); + "lifetime", (unsigned)TICKS_TO_S(tcell->end_of_life) + ); } + unlock_hash(r); } }

1 0

git:master:e34d70fb: tm: show ref count, lifetime, uas request mode in rpc tm.list
by Daniel-Constantin Mierla 31 Aug '17

31 Aug '17

Module: kamailio Branch: master Commit: e34d70fbffc22f3c2173b960afcfbb6166060002 URL: https://github.com/kamailio/kamailio/commit/e34d70fbffc22f3c2173b960afcfbb6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T10:00:03+02:00 tm: show ref count, lifetime, uas request mode in rpc tm.list --- Modified: src/modules/tm/t_stats.c --- Diff: https://github.com/kamailio/kamailio/commit/e34d70fbffc22f3c2173b960afcfbb6… Patch: https://github.com/kamailio/kamailio/commit/e34d70fbffc22f3c2173b960afcfbb6… --- diff --git a/src/modules/tm/t_stats.c b/src/modules/tm/t_stats.c index 7643ac624c..5b1cc5fbbc 100644 --- a/src/modules/tm/t_stats.c +++ b/src/modules/tm/t_stats.c @@ -268,7 +268,7 @@ void tm_rpc_list(rpc_t* rpc, void* c) lock_hash(r); clist_foreach(&_tm_table->entries[r], tcell, next_c) { - rpc->struct_add(h, "ddSSSSSdd", + rpc->struct_add(h, "ddSSSSSsdddd", "tindex", (unsigned)tcell->hash_index, "tlabel", (unsigned)tcell->label, "method", &tcell->method, @@ -276,8 +276,15 @@ void tm_rpc_list(rpc_t* rpc, void* c) "to", &tcell->to, "callid", &tcell->callid, "cseq", &tcell->cseq_n, + "uas_request", (tcell->uas.request)?"yes":"no", "tflags", (unsigned)tcell->flags, - "outgoings", (unsigned)tcell->nr_of_outgoings + "outgoings", (unsigned)tcell->nr_of_outgoings, +#ifdef TM_DEL_UNREF + "ref_count", (unsigned)atomic_get(&tcell->ref_count), +#else + "ref_count", tcell->ref_count, +#endif + "lifetime", (unsigned)TICKS_TO_S(tcell->end_of_life) ); } unlock_hash(r);

1 0

git:5.0:fbad27e4: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 30 Aug '17

30 Aug '17

Module: kamailio Branch: 5.0 Commit: fbad27e40c3a10b81d7ff3bfe2c31082d28c6335 URL: https://github.com/kamailio/kamailio/commit/fbad27e40c3a10b81d7ff3bfe2c3108… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-31T00:31:29+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/avpops/README Modified: src/modules/pv/README Modified: src/modules/sdpops/README Modified: src/modules/textops/README Modified: src/modules/uac/README Modified: src/modules/xlog/README --- Diff: https://github.com/kamailio/kamailio/commit/fbad27e40c3a10b81d7ff3bfe2c3108… Patch: https://github.com/kamailio/kamailio/commit/fbad27e40c3a10b81d7ff3bfe2c3108…

1 0

git: new commits in branch 5.0
by Daniel-Constantin Mierla 30 Aug '17

30 Aug '17

- URL: https://github.com/kamailio/kamailio/commit/cf6c876d1203210c86f751cd9aeb3a6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:06:08+02:00 speeddial: add missing break when handling blob db result type (cherry picked from commit 59dde423db52e7a8c69072685c99cd6a11440017) - URL: https://github.com/kamailio/kamailio/commit/998b9e65ac404acbe84c15cf079eea0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:06:41+02:00 cnxcc: safety check for credit data search return value (cherry picked from commit 5a577ab37719d48fb9a6bc1b200c8892d95ccbdc) - URL: https://github.com/kamailio/kamailio/commit/ee77f90b9b649c3ab18380609353cad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:07:03+02:00 auth_xkeys: use the right size when initializing xkeys list (cherry picked from commit 6b82a103650fd0036490cf02dffcc5ad50c6f669) - URL: https://github.com/kamailio/kamailio/commit/ba1503535bda4bc20e8f443382306f6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:08:51+02:00 core: dns cache condition for both proto ws and wss (cherry picked from commit 19f37c944748c72a7069a4fd5e3d8c6160a1e557) - URL: https://github.com/kamailio/kamailio/commit/e134708bf7f453e9ba8a1c0eb033865… Author: grumvalski <federico.cabiddu(a)gmail.com> Date: 2017-08-30T21:09:14+02:00 core: build reply of core.sockets_list as an array (cherry picked from commit e3ea10ccfcd94af0e7ce6908a1e378b4a9555b93) - URL: https://github.com/kamailio/kamailio/commit/b127d8ddb1acc9d630ee98d503d3322… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:09:39+02:00 sdpops: more details for sdp_with_transport() docs (cherry picked from commit cad4b8f456d3508a2ec3196c89a4a8e3ce9d9d32) - URL: https://github.com/kamailio/kamailio/commit/e01ff341db4e6ed7bdc5276de260aa6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:09:54+02:00 avpops: several pkg free in case of errors in fixup functions - cleaner pkg usage summary in case of errors at start up (cherry picked from commit 51009ab4f4aa6a229fab5abb94d4340f1178868b) - URL: https://github.com/kamailio/kamailio/commit/0827f0e4017e224d51f83ba3369ca7c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:10:06+02:00 avpops: few more pkg free in case of errors in fixup functions (cherry picked from commit 5ea16d8de71324e2eeb3c833cde76c52bdc8ac67) - URL: https://github.com/kamailio/kamailio/commit/4b99fc28ea73dd5c34cfd66cccbc438… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:10:24+02:00 app_python: proper condition to free srcbuf in exception handling (cherry picked from commit 5250fa3302a4cb9bf9572ded6fb65fa9c067f08d) - URL: https://github.com/kamailio/kamailio/commit/b964b7be7b4acaa904f62259c055a6d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:10:43+02:00 core: handle error case also for socket fd 0 - avoid fd leak warnings by code analyzer (cherry picked from commit 2654fbb0c02fd8df82ecd6b8514e031952997104) - URL: https://github.com/kamailio/kamailio/commit/9431e8755a60e5ac34afd5bf90cf1fb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:10:54+02:00 core: msg translator - unified error handling to simplify freeing allocated memory (cherry picked from commit 882449e3c0b1ac44cf810d079f696187af007451) - URL: https://github.com/kamailio/kamailio/commit/56f1c8d9d29567284da6230913e1c82… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:11:47+02:00 core: tcp read - set own handling for ECONNRESET (cherry picked from commit 6090f7d9de0c71b25bd66c3525b25de7d02a5aa1) - URL: https://github.com/kamailio/kamailio/commit/de33cc0f9baad61d029b9f73c38e95e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:12:10+02:00 core: locking - rec lock init condition fixed (cherry picked from commit 27186f1d951c89c033bb02c6b446a630e1fce5d3) - URL: https://github.com/kamailio/kamailio/commit/973bf97d5bfe8ef3585c4feab1744f9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:12:24+02:00 core: cfg ctx - catch condition when there are no changes to be committed (cherry picked from commit 3deee5be0fa9c68f35ddb273fd86e22af91ced99) - URL: https://github.com/kamailio/kamailio/commit/ea331fc5185e1da916a867fb4f078ee… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:13:28+02:00 core: daemonize - proper chown for pgid file instead of pid file (cherry picked from commit 65593cc23bc89349fb42566cbd7eb2bbf8744db9) - URL: https://github.com/kamailio/kamailio/commit/ac21783e94782fac141c9801c83a2e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:13:43+02:00 core: dns - safety checks for port and proto pointers (cherry picked from commit febccd6808d0729fca1bbf452d43c253ca79249a) - URL: https://github.com/kamailio/kamailio/commit/e0078a5686ede14be0bdc2f4943f9bf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:14:02+02:00 core: pt - check to avoid two times closing unneeded sockets (cherry picked from commit 0225f89a658172d0652e0da14549ee03653114d2) - URL: https://github.com/kamailio/kamailio/commit/455d64cd027a79edd01f5794963c6af… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:15:05+02:00 siputils: log messages for error cases (cherry picked from commit 2a19f9e6f4203800707e0a63753e0ee1c4bb4685) - URL: https://github.com/kamailio/kamailio/commit/082767604baefdd1b203c98e38ebefc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:15:24+02:00 auth: use the dedicated types for return codes instead of generic int (cherry picked from commit 41e9af5833ff49e36a646a8cbe47d835f73661f0) - URL: https://github.com/kamailio/kamailio/commit/3e5e97f7ae67ea1248566dead7a2d87… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:15:36+02:00 auth_db: use the dedicated return types to avoid mixing values in int vars (cherry picked from commit e4ebacba9bfd7566436d72a77fd55a1b71066955) - URL: https://github.com/kamailio/kamailio/commit/41c0d250749515877f369f19fb7ba84… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:15:54+02:00 auth_ephemeral: use dedicated enum type for auth return codes - reorder safety checks not to access msg structure if null (cherry picked from commit 5937adf01f7c3e2382a1f2dc149a677fe6cd26f1) - URL: https://github.com/kamailio/kamailio/commit/c2f33cb7187d7d1bb87828e752cecfd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:17:07+02:00 core: dns case - init local proto to UDP if not provided for srv resolve (cherry picked from commit 01771c42d3b96678a2d0ba08bc1e5c83191ada8d) - URL: https://github.com/kamailio/kamailio/commit/5653d95b8b5e4d6dc0e6c706053e144… Author: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-08-30T21:17:37+02:00 modules/textops: msg_apply_changes() comes from textopsx module (cherry picked from commit 7a6d31935c7e8e29dd150412f1e6281fdf3efd53) - URL: https://github.com/kamailio/kamailio/commit/ad19902e6402a06978c8e85b844c6ad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:17:53+02:00 core: msg translator - switch condition to buf pointer instead of lenght - better correlation with returned value from functions (cherry picked from commit 1968b43731afdcec1bd40985176680c8af1be921) - URL: https://github.com/kamailio/kamailio/commit/badc783d132eea9fc7b6302a5fbae65… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:18:42+02:00 tls: free temporary buffer when fixing shm path name for config (cherry picked from commit 2dc19e5c78977416c15ebe93a4f4e6d72ed475a0) - URL: https://github.com/kamailio/kamailio/commit/3ce03c2765bc75857a3f7e860672c0b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:18:58+02:00 utils: handle error case for xcap auth status to free allocated structs (cherry picked from commit ae7dce434e10ef570e1c6daa8ca5d9f800239ddf) - URL: https://github.com/kamailio/kamailio/commit/3f4d1b6d3cd8b5b937e19501fff43a5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:19:11+02:00 xprint: safety checks for error cases (cherry picked from commit a859ff6e74b0cdc08f30c43adda865a74283b3c4) - URL: https://github.com/kamailio/kamailio/commit/7fff54711ba4672ce7214a26b4fa869… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:19:25+02:00 xmpp: close fd in case of write error (cherry picked from commit dadd54a46f81ef05478e622a89a3bb739907cade) - URL: https://github.com/kamailio/kamailio/commit/ff8c184ca339891bdb3ae2fc2861a20… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:19:37+02:00 uid_domain: avoid double free in case of error (cherry picked from commit c5cdd8dce66d94f69f773b5361ef2b477df47f06) - URL: https://github.com/kamailio/kamailio/commit/a41f7a1bc07b7ad920d38996bec4c43… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:19:51+02:00 uid_avp_db: better error handling (cherry picked from commit 42d74f35e4d7be9f46314c1805a77983a7cdf6fb) - URL: https://github.com/kamailio/kamailio/commit/28ea2cd708df099b6acb2d7c5499b68… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:20:39+02:00 alias_db: simplify error handling for db query function (cherry picked from commit ab627c14e6f06b8e568f9b6ab4e3cd396368d6bb) - URL: https://github.com/kamailio/kamailio/commit/8193904c074eaf630a22da10475106a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:39:35+02:00 ipops: replace return with goto error to release resources (cherry picked from commit a4ee0d3fd0c1b4147d462c8275d0150e8e934e2f) - URL: https://github.com/kamailio/kamailio/commit/d59f5db999c8247c6f656241c0eeec2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:40:25+02:00 core: pvapi - added free_pvname_list() (cherry picked from commit 5c883b5ff70ad24befd5191be41502e6e35fec88) - URL: https://github.com/kamailio/kamailio/commit/4f20ed9c1d711ec429df5eeb42c9af6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:40:36+02:00 app_python: free buf in case of get exception error (cherry picked from commit dc00778decd5a7c91208fb1ae31d875677a2b9de) - URL: https://github.com/kamailio/kamailio/commit/6f2783dd8e3bab21dba47f3835db07d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:40:55+02:00 avp: removed history, coherent indentation (cherry picked from commit b441903c6c109aaa35c3b4781c268f9497a00fc6) - URL: https://github.com/kamailio/kamailio/commit/5350087a275ea29e1997286c7d2775c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:41:09+02:00 db_cluster: free in case of error (cherry picked from commit cbc5502e23f58b50cb11124defe0b7ad618899b6) - URL: https://github.com/kamailio/kamailio/commit/5863363964f3ab4e7a65e0dacdf2258… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:41:21+02:00 db_postgres: handle return code for setsockopt() (cherry picked from commit 4363b863e9dcd3b31c1d2b2febd9b11c40ec3eec) - URL: https://github.com/kamailio/kamailio/commit/bff436f66b69501892d5c15aebc5463… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:41:36+02:00 debugger: fix orig offset computation inside w_dbg_sip_msg() (cherry picked from commit 06e1ad190ea62efc09a158f9c86d447d078d805b) - URL: https://github.com/kamailio/kamailio/commit/c07e616c0c6d972efa8818002b67e3e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:41:51+02:00 dialog: increase puid size for profile to ensure null termination (cherry picked from commit f2796ceb0a127c1a6580a9d9582ec9bc0fba6081) - URL: https://github.com/kamailio/kamailio/commit/58578c2ff907fa5bace119d7ce41a8b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:42:04+02:00 dialplan: free allocated vars in case of errors (cherry picked from commit bd5873c4e33188238633a8f6c48a0c5c28041179) - URL: https://github.com/kamailio/kamailio/commit/80fcc7dc3653dd2f5db98b0dd500cb5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:42:21+02:00 sqlops: free allocated pv list in case of error inside fixup_sql_pvquery() (cherry picked from commit 8f460d16e84b9bc0b01463113c6e7e79d297f64e) - URL: https://github.com/kamailio/kamailio/commit/e8fb0b1103ae96656ae404d7ac7a4b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:42:34+02:00 speeddial: simplified access to db_res and the free of it (cherry picked from commit 1ed223dcccf4c2ea623db75fdda16adc924b916e) - URL: https://github.com/kamailio/kamailio/commit/41ab1e8ad7fea0abddef1b557ab286d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:43:10+02:00 xcap_server: proper test of retun code for add lump rpl (cherry picked from commit 08c404f245e55b37f71d4326afd959ecf1ea831c) - URL: https://github.com/kamailio/kamailio/commit/707ab98e69a659335bf386b2bf91ae4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:43:39+02:00 xhttp: proper check for return of add lump rpl (cherry picked from commit 9136ce8017660e92f624de6f7b8a07e50620dfa1) - URL: https://github.com/kamailio/kamailio/commit/b3079e89ff88d20e65751b43a1a1a7f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:44:00+02:00 pdt: reorder checks to avoid null access (cherry picked from commit 1891dcb958100b5383f40278c4d675474d309df4) - URL: https://github.com/kamailio/kamailio/commit/59e263c97571a000a8a854d8e36ad9c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:44:16+02:00 nat_traversal: handle return values for errors (cherry picked from commit 449d435194338a4f3acf079774adcbef7ad7b794) - URL: https://github.com/kamailio/kamailio/commit/398162799d209d6f129dd32bcaf61ab… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:44:29+02:00 memcached: handle error cases and alloc enough for null termination (cherry picked from commit 5f9eba3eb42cdb8a5c2ec840cec29757d480e136) - URL: https://github.com/kamailio/kamailio/commit/3ad98055bb7ca86d09911a270f737c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:44:43+02:00 json: remove use of deprecated macro is_error() (cherry picked from commit 0efa76d80e159fd2a7516388fe2405ad4fb6c5b6) - URL: https://github.com/kamailio/kamailio/commit/43f8aee531c1f7991c7b3f471be00df… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:44:55+02:00 mediaproxy: handle return pointer values (cherry picked from commit 65ac6de1aebd6143c44f35ef28f46c2cd3a56723) - URL: https://github.com/kamailio/kamailio/commit/630988036c8e46fdd137e84a4070612… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:45:09+02:00 msilo: reorganized tests to free db_res and build of extra headers (cherry picked from commit dd0c6fb586a61cb7e2eed1093ccf8f5158761ae3) - URL: https://github.com/kamailio/kamailio/commit/4335647914d8fc0ee7d8ede5cec58ac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:45:20+02:00 presence_conference: free xml array in case of error (cherry picked from commit 9c34b68ee840880dd6be37694de8e8255f8bfb45) - URL: https://github.com/kamailio/kamailio/commit/931796dc743ba3bb39a0610a8231fc9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:46:01+02:00 uid_uri_db: safer check for accessing to header (cherry picked from commit 823bad5f3aad5c77ff9986ecf4be2517df043788) - URL: https://github.com/kamailio/kamailio/commit/1494ee425cd972088b2fe9551e52133… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:46:19+02:00 sst: add 0 after memcpy (cherry picked from commit 6997738a7098ef56becfd40cb6e7c7864d1975f0) - URL: https://github.com/kamailio/kamailio/commit/99340e1f8310b5e4336a9b3eb5867fb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:46:35+02:00 statistics: free vars in case of error in fixup function (cherry picked from commit 711a5600330793b2ca787ce451f2ad48620dd639) - URL: https://github.com/kamailio/kamailio/commit/b87bccdd01eba57db00de135f002d27… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:46:54+02:00 statsd: simplified error handling inside statsd_connect() (cherry picked from commit f75eba63a1f0176adc8cd38846a0d1943471e10c) - URL: https://github.com/kamailio/kamailio/commit/6d6a51ba60985c025b803c6c7faf447… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:47:13+02:00 stun: link attribute when calling stun_parse_body() with an existing list (cherry picked from commit 4ba402434449ec9cb426d5200b12c5cec4d07ab4) - URL: https://github.com/kamailio/kamailio/commit/5b7ce6ce1c6183b44840367a5462347… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:47:58+02:00 xcap_client: handle return code for strchr() (cherry picked from commit 8147009b34639304fb75d4f6c39269c49ee385ca) - URL: https://github.com/kamailio/kamailio/commit/0c9f93702ba708342cd598b476b22a9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:48:15+02:00 xcap_client: removed unused api function get_elem() (cherry picked from commit e6e04f4c96e5fdd7a3a90f265fd6cb7470f1135b) - URL: https://github.com/kamailio/kamailio/commit/31151c8eb61d74d55a6c86b9495a7fb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:48:29+02:00 xcap_client: safety check for namespace variable (cherry picked from commit 96582d77583719d7bb9c5e5437198800ae9e7a12) - URL: https://github.com/kamailio/kamailio/commit/9b41fd2b7d0cc2dc9f98e4b2e2d7364… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:48:44+02:00 xmlrpc: handle return codes (cherry picked from commit 0f3fb6b8cb04162be07e9246c23bcfa8b8e4e4e6) - URL: https://github.com/kamailio/kamailio/commit/fbb5e22c62c8ad4d4c5883de4ff140e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:48:56+02:00 app_perl: free on error cases for modf execution (cherry picked from commit 0cf4ad7b4e839856eef4dc2cd76adacd1627ce7c) - URL: https://github.com/kamailio/kamailio/commit/25689141e3901d9a882dd08ae80a27e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:49:29+02:00 dialplan: catch error case from macro used inside dp_trans_fixup() (cherry picked from commit 78722ff2f1e290dc6ae41a4d718e9c4cea20926b) - URL: https://github.com/kamailio/kamailio/commit/83e529c2e8d74c72e82691660ea6da8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:50:09+02:00 pv: support for dynamic params for var to xavp functions (cherry picked from commit 45506c4343ae03450e33a04b9f2e9a3196d57306) - URL: https://github.com/kamailio/kamailio/commit/698d92d5b7ad8da40987df78374ccab… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:50:22+02:00 pv: notes about dynamic parameters for xavp to var funtions (cherry picked from commit e9a132afc0fa4b02a7030c2c20ade65a1d693006) - URL: https://github.com/kamailio/kamailio/commit/65fe63dd524a53153944b99981ad7e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:50:57+02:00 dialplan: increased the size for dialplan attributes to 256 (cherry picked from commit 36b8c1a138548ea3689cac77e18ac304ec2ee0e5) - URL: https://github.com/kamailio/kamailio/commit/ac5ebf81413e7a77e6b26a840ca7cb0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T21:51:28+02:00 core: added helper fixup for int and str dynamic parameters (cherry picked from commit e049d6db78d9a86049f88acc27188d726974054f) - URL: https://github.com/kamailio/kamailio/commit/68ba0c1fbeb65a9444d3544d876c554… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:52:21+02:00 pv: added section ids in the docs (cherry picked from commit e95091700857ff96d9e7c6508104a5ba5d5487ff) - URL: https://github.com/kamailio/kamailio/commit/e31327d821edc577387799a1c1ad017… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:52:59+02:00 uac: added note about default value for reg_db_url (cherry picked from commit 7d414352e0544cfe1739f3e36cec2c23379ae902) - URL: https://github.com/kamailio/kamailio/commit/4a44757882e23f84183ddbd43b587a3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:53:23+02:00 auth_diameter: removed svn id, history (cherry picked from commit 2dc6e4700012336ac15dc9b6190f6750648854aa) - URL: https://github.com/kamailio/kamailio/commit/641b9f09ac783973ff2259fbdb7e04f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:53:45+02:00 core: cfg - removed unreachable code (cherry picked from commit f3c68a5013b5a33937dbf735453da29df75ae09e) - URL: https://github.com/kamailio/kamailio/commit/d887e6ab5ef9a6f6c666563f4b535a3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:54:00+02:00 core: dns cache - avoid bitshifting with more than the size - avoid undefined behaviour as per C specs (cherry picked from commit 107dc767391902d5d3b000deecafb804c1c68c1b) - URL: https://github.com/kamailio/kamailio/commit/e37fbf0ada489c97ddb65419ea9df31… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:54:14+02:00 core: mem/f_malloc - explicit set to 0 for bit shifting greater than size (cherry picked from commit 0cb33abe8b2196fb26baf459f66d9d7b9e920013) - URL: https://github.com/kamailio/kamailio/commit/520bb5c3c6219a7e50cdd96358bd84f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:54:27+02:00 core: pvapi - remove useless condition (cherry picked from commit e19c1ec58c8c51defd91f3e2581544bea224c0bf) - URL: https://github.com/kamailio/kamailio/commit/140a50822efc8a0437283cced7366d2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:54:40+02:00 app_python: remove condition on classname, being set to non-null (cherry picked from commit ec4d74ad7c1d1b14a4f33f995845ac7b299540cf) - URL: https://github.com/kamailio/kamailio/commit/505914407e105aca32407df3c06d980… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:54:51+02:00 auth_diameter: avoid passing large structs as params and better error handling (cherry picked from commit 67e87eb16059351f174fc6f4d740eed33b5ace6b) - URL: https://github.com/kamailio/kamailio/commit/dd27be05fff75d0bef85338bcc2181d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:55:04+02:00 avp: typedef hdr name struct to simplify memory allocation (cherry picked from commit a3d3239833a8ca91566a28de2217ec166601e64f) - URL: https://github.com/kamailio/kamailio/commit/414057818756f423ec8a68f7637ee8f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:55:29+02:00 ctl: close opened sockets in case of errors (cherry picked from commit a81a809897ff381526db38e71af38dfcdfa74f04) - URL: https://github.com/kamailio/kamailio/commit/ac92a5544057f73b3a6cfedfa96487f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:55:43+02:00 dialog: extra headers for dlg_bridge() built with memcpy (cherry picked from commit 220f2e3a36a7d7f00c77ef6f8cc495b3ff995b01) - URL: https://github.com/kamailio/kamailio/commit/792f8e1fa8d2fd7dfae2a0b4146abfe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:55:55+02:00 dmq_usrloc: remove useless condition (cherry picked from commit bda4f0a8f8c7f65360fa73f51fb4fac289a8d334) - URL: https://github.com/kamailio/kamailio/commit/20a61ab0857ae2bf33b58ad6855d103… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:56:07+02:00 domainpolicy: check if set dst uri fails (cherry picked from commit e238567daa77f68df05cce68051792c3d7559ab7) - URL: https://github.com/kamailio/kamailio/commit/e7e1fe4945d3dab11beee065e9bb0b5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:56:19+02:00 drouting: handle errors in fixup function (cherry picked from commit 36202503c531e5e6e865da018a59a494da6d9dc3) - URL: https://github.com/kamailio/kamailio/commit/11820d1698061229fe4777c365dd28a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:56:32+02:00 http_async_client: safety check for cell value (cherry picked from commit 00f2cfd1efb81030c705cf4b4f6aa3ac582d3059) - URL: https://github.com/kamailio/kamailio/commit/f62f38322778da69ce7ead2d11e6ebb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:56:45+02:00 http_client: safety check for lenght of retrieved headers (cherry picked from commit eb6c94626d02e5a6fc2c93328591c140853535da) - URL: https://github.com/kamailio/kamailio/commit/6872ead2818868fd9343f852d74f8be… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:56:56+02:00 imc: better check for buffer size limit (cherry picked from commit 0fd33d766c471e0f0710bd6f84898462420bfbaa) - URL: https://github.com/kamailio/kamailio/commit/fa2ff3aa155eb996c1ba6d41b0e0a46… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:57:13+02:00 lcr: check return for rewrite_uri() and do memset with size of alloc (cherry picked from commit 67bd080310c5b8371d9943fa964e81154c916356) - URL: https://github.com/kamailio/kamailio/commit/90955519081fa356057b12626bace88… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:57:24+02:00 ldap: free in case of error cases (cherry picked from commit 6d3a97d1c3e62f876bbb7a17927b2a40243ec268) - URL: https://github.com/kamailio/kamailio/commit/8e887d24a63049407d4f40ee276e9c6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:57:36+02:00 msrp: use formated string instead of complex sequence of concatenation (cherry picked from commit 2d68418a6df8d814e60f992b3ae1d74fbb13a2f3) - URL: https://github.com/kamailio/kamailio/commit/a7912e341581308a52be3fc083ad2e3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:57:52+02:00 pv: remove useless condition (cherry picked from commit 1f50cd26ba0db88fd5f2c33e2b44a461f471e760) - URL: https://github.com/kamailio/kamailio/commit/7f210023d8b7ad5d24b71a7a403fcc4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:58:13+02:00 core: dns cache - safety check for out of bounds index (cherry picked from commit 59234b8fae1295455e347e27519813e63bf8ffb0) - URL: https://github.com/kamailio/kamailio/commit/675abfb90d55e97021b20ce5f6243a9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:58:24+02:00 ctl: remove useless assignment (cherry picked from commit 6ddca2e08bc8159ed00c80f6857df58c81cbd97d) - URL: https://github.com/kamailio/kamailio/commit/9a8ef86e20322f6d51771eba75db097… Author: Emmanuel Schmidbauer <emmanuel(a)getweave.com> Date: 2017-08-30T23:59:20+02:00 db_postgres: fix typo and whitespace (cherry picked from commit 9219b2116fc2887c0c8c2ad39465087e324784fb) - URL: https://github.com/kamailio/kamailio/commit/07b35e90b610e0828d205676582fd80… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:59:36+02:00 app_python: removed condition on classname, it cannot be null (cherry picked from commit afe6d712d5ef52ac6f3fe8e6f69406779e3a740e) - URL: https://github.com/kamailio/kamailio/commit/8b8e83fe98f91db0a3b0ca63a73fc6e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T23:59:49+02:00 avp: clear code for unsupported parameter format (cherry picked from commit 22fc924aa928fe126156290a10c4be8048ba4f8b) - URL: https://github.com/kamailio/kamailio/commit/384b264cc3623f5121232bd3b228a14… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:00:02+02:00 db_mysql: safer conditions inside sb_add() for db api v2 (cherry picked from commit 97db3ee61079de6cc2466628dae0f5e489819e98) - URL: https://github.com/kamailio/kamailio/commit/aba92d92696736bed6d6aa70afd4156… Author: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-08-31T00:00:33+02:00 modules: use Docbook tag for Kamailio wiki URL (cherry picked from commit aabba8141410a25a19667a3aa750f88081a04bd9) - URL: https://github.com/kamailio/kamailio/commit/34124c3bed1de3c7778b05cf640e9f0… Author: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-08-31T00:00:48+02:00 sctp: remove svn tags and history notes (cherry picked from commit cbe051d7cd02b31c385b93284251d0a8daeeacc7) - URL: https://github.com/kamailio/kamailio/commit/0bec6b328fecb26d423e54ff6939f76… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:01:04+02:00 h350: coherent indentation, removed dead code and init lenght for str (cherry picked from commit b6c6da62fe9879a43a322ce7f9adac3eef5674e7) - URL: https://github.com/kamailio/kamailio/commit/a142db940ef379fed6afaf2a605744d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:01:29+02:00 http_client: use strcpy() instead of strncpy() with sizeof dest buffer - padding the rest of dest buffer with 0 is inneficient (cherry picked from commit 9fe84d4ad1ec1eae6bcf44b4067b948d9a16e4dc) - URL: https://github.com/kamailio/kamailio/commit/e176a7ed585f1f3710ee5865b70cea7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:01:42+02:00 janssonrpcc: couple of pkg free in case of errors (cherry picked from commit 73a288e14ec8f7a67662842140d5eb02819b7738) - URL: https://github.com/kamailio/kamailio/commit/8fe9b7118deb7c91767357094a7cb7b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:01:51+02:00 mangler: pkg free in case of errors (cherry picked from commit 4572a7b100f2eaddb2eb4dbe4aa81a4833f8467e) - URL: https://github.com/kamailio/kamailio/commit/bc0041f14cf4d023a8d11d0978977e0… Author: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-08-31T00:02:33+02:00 sipt: free pkg memory on error (cherry picked from commit 2ea19b82b5e21d4499929cb56964ed43035c6122) - URL: https://github.com/kamailio/kamailio/commit/a11d4575324402a67e339faaa22a690… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:02:46+02:00 xhttp_pi: several compiler warning fixes (cherry picked from commit 8b06397523c440fc20e509889c5fad01ed477d26) - URL: https://github.com/kamailio/kamailio/commit/fcaa84b6d7e1ba0c3a8746326e083d3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:02:57+02:00 websocket: use NAME in log message, removed unreachable code (cherry picked from commit 5c58ac726c1f96b6666cfd05e13a66328d46d020) - URL: https://github.com/kamailio/kamailio/commit/726d726ee037ee1b91dd21a843ece2d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:03:26+02:00 tls: removed useless checks (cherry picked from commit 590c8d9d23e578df38d332ebcfa64421bbedb604) - URL: https://github.com/kamailio/kamailio/commit/7de2ea05fb953d80a7d6cb22a420555… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:04:02+02:00 mangler: free on errors inside sdp_mangle_port() (cherry picked from commit 950a9fa428e24242671e83980192db48819d5da6) - URL: https://github.com/kamailio/kamailio/commit/c23c5b426e075a046a57cb06b749ab2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:04:28+02:00 ctl: safety check for closing fd (cherry picked from commit 24c4f357ecc83ded4c8890ed4440a0252191b0a9) - URL: https://github.com/kamailio/kamailio/commit/5f94960aae57de23f3505a1080204d2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:04:38+02:00 rls: avoid access to item after free (cherry picked from commit 4068ddd3ca01795e5378a738756b2735508f5864) - URL: https://github.com/kamailio/kamailio/commit/4b43735da8a5483b084d8eaa70267c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:04:52+02:00 auth_identity: code clarity adjustments (cherry picked from commit 2f29115d8280ccf04ea823d5cf8f6621b8624edc) - URL: https://github.com/kamailio/kamailio/commit/f3f388dfb9d96270b51947f8c75e5ab… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:05:02+02:00 cfgt: check error case for mkdir() (cherry picked from commit 9a7fee2dac2f59c277d2634937c7449b9659a20d) - URL: https://github.com/kamailio/kamailio/commit/77f9af46258cd1853379db683d55638… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:05:16+02:00 cplc: init structures, fix parameter number in fixup (cherry picked from commit 3f96ede632ce9ef945086a1f384677151209fcc6) - URL: https://github.com/kamailio/kamailio/commit/e7676ca77444936ff5bbd94479b9dd3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:08:56+02:00 cplc: init time switch structures (cherry picked from commit 44db76acb7523b3cd6816c77de45b71857b1a3c1) - URL: https://github.com/kamailio/kamailio/commit/91c5ad41d053e9ab398dd7b8ddd914b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:09:15+02:00 ctl: skip condition on already set name variable (cherry picked from commit fda8de91d80a2aee7a3ec5e44e6fc1d918541254) - URL: https://github.com/kamailio/kamailio/commit/9c7b176cb8aa71ace150e3b3d60d6f7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:09:33+02:00 presence_dialoginfo: safety checks to avoid accessing null values (cherry picked from commit 30014025157f9ac79c98f1361a86974858ef8022) - URL: https://github.com/kamailio/kamailio/commit/49c191789881f7acfa514940bf1f749… Author: Torrey Searle <torrey(a)voxbone.com> Date: 2017-08-31T00:10:16+02:00 modules/sipt: fix bug in setting NAI of called party (cherry picked from commit 676c96ed860be183bd69ad55c8062523afcc5248) - URL: https://github.com/kamailio/kamailio/commit/e86b803d4dee78e395d7ca1960c80f5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:10:49+02:00 uac: fixes for section ids in docs (cherry picked from commit d1d2dda40e1ac787a021c4ea9f9e179870dea99a) - URL: https://github.com/kamailio/kamailio/commit/0a5b94d53f59e8f59f8d7d976ca1485… Author: Alexander Lutay <alutay(a)sipwise.com> Date: 2017-08-31T00:11:09+02:00 kamctl: fix dangerous 'rm -rf' code in case if variables are not defined (cherry picked from commit 62f573d4ecbbebe5f0f2d3b39be7ad4c2b460e65) - URL: https://github.com/kamailio/kamailio/commit/0e075c47ad66464f28ef56b83f8cc8f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:11:46+02:00 tsilo: added section ids in docs (cherry picked from commit d302422982aab79ec9af9b9d54d33dbf98dc7b63) - URL: https://github.com/kamailio/kamailio/commit/23a0450268c601e920b287c9bddfd50… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:11:59+02:00 pipelimit: match algorithm name case insensitive (cherry picked from commit 7bb4b7dcc23c582ec666c71c9475e46e4ca12709) - URL: https://github.com/kamailio/kamailio/commit/e84a82eac27cac9d9381e7181564452… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:12:09+02:00 cplc: safety checks for parameters (cherry picked from commit b05f3637f9cc829470d04037f6f5b88e37819706) - URL: https://github.com/kamailio/kamailio/commit/edeb60a861ab90e20b6010b1a68e60d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:12:58+02:00 websocket: use route_lookup() instead of route_get() - avoid creating an empty route block structure if not defined in cfg (cherry picked from commit 6752351b69cd991cd11f389f80cf73bd68ff5bb9) - URL: https://github.com/kamailio/kamailio/commit/a7e5d2eca678d2e9f6ab11588cace72… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:13:16+02:00 tls: updated log macros for config code (cherry picked from commit 475ef89d6fc5780673c7e0091a78036e74f819db) - URL: https://github.com/kamailio/kamailio/commit/804ba55f2ff2762bf26f91624f3432a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:14:34+02:00 http_client: proper free for curl params in case of failover connection (cherry picked from commit 9ce38204d8a59e5d83cc50a2c809d1306346f9b7) - URL: https://github.com/kamailio/kamailio/commit/3c6ad9786012fc0f702209b7950d30a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:15:27+02:00 tm: terminate local uac buffers with 0 - received message buffer is terminated with 0 and many functions expect that, so use of them in event_route[tm:local-request] may have ended up in wrong behavior (cherry picked from commit 179a6e699a1021efa55d1ea097ceeb7a12575cc5) - URL: https://github.com/kamailio/kamailio/commit/2d13c140f0d84edb3ba90fbea0fcd9f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:16:14+02:00 http_async_client: safety check for shm malloc and do cfg_update() (cherry picked from commit 5f5697eac0089e9e2bc72323c6afa839b472ccbd) - URL: https://github.com/kamailio/kamailio/commit/4af7c9a6ada6b9bf1d5f2efe2a22daf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:17:47+02:00 pua_dialoginfo: goto error in case of failures inside build_dialoginfo() (cherry picked from commit e0ff472acfbae9ad1077a3dc6f2309ea01a8fdf0) - URL: https://github.com/kamailio/kamailio/commit/07da574ff05f014349f242f1aa6039d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:18:17+02:00 core: store advertise addr for new sockets created from interface name - reported by GH #1209 (cherry picked from commit a3e8003274ded1420d2af677246a48ef5c743a3c) - URL: https://github.com/kamailio/kamailio/commit/514d4d1bd2b22a8866a519da9f3752c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:18:32+02:00 sms: avoid overflowing ending 0 by sprintf() (cherry picked from commit 2415416df6bd4c599c7fde57fbaa541e2e37f9c7) - URL: https://github.com/kamailio/kamailio/commit/e7b2aed6f0d69bdefd199b5beafa1e3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:18:54+02:00 core: mem - fix printing shm memory manager name (cherry picked from commit fe441c4561a8be852c2baae6568e48ef8203210d) - URL: https://github.com/kamailio/kamailio/commit/af96836b4934af3b360795391eb2906… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:19:42+02:00 core: tcp - print str error in debug message if faling to write to connection (cherry picked from commit 85def4c200e216dce5d3d8e53461a69ab408fa3c) - URL: https://github.com/kamailio/kamailio/commit/de69b1c1212f7ee18578fbd9b0aec97… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:20:09+02:00 rls: proper handling of return code for parse from/to uri (cherry picked from commit bb536c3dae01865c42e556989e8aca5be85b20fe) - URL: https://github.com/kamailio/kamailio/commit/439daedbc700571aa71af94067eba10… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:20:21+02:00 rls: replace sprintf with safer snprintf - compact printing headers in 200ok function by doing it once in a snprintf, instead of combination of many sprintf and strncpy (cherry picked from commit 3d2359b5a349efe4d6571ec0953e5c4aae54a165) - URL: https://github.com/kamailio/kamailio/commit/c3ce7d218e3fdf2036421afad2a0b0d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:21:20+02:00 uac: use kam_rand() instead of rand() - do kam_srand() when module is initialized (cherry picked from commit 219ddbb54bb787a8f0673014c16e749eef40bdf4) - URL: https://github.com/kamailio/kamailio/commit/f05b6bca51c38ebea72fd7d4a956242… Author: Olle E. Johansson <oej(a)edvina.net> Date: 2017-08-31T00:21:48+02:00 http_client Move some logging to debug to avoid annoying messages (cherry picked from commit 4680086105bb41f03a1180be03d7acce113d465a) - URL: https://github.com/kamailio/kamailio/commit/672ea36889c2a7c1ae919b08447234e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-31T00:22:07+02:00 core: parser - use case insensitive comparison to get header by name - same for next sibling header - GH #1217 (cherry picked from commit 4072b0f9fbc084a4f4640e1b4272b7f8495cd1bb) - URL: https://github.com/kamailio/kamailio/commit/63eb5293a3ddcd7535e6b2545d76edb… Author: Olle E. Johansson <oej(a)edvina.net> Date: 2017-08-31T00:22:53+02:00 http_client Free the old object when the new can't be allocated properly (cherry picked from commit e129b809e258d94ea39d66c847db3a19eae2b708)

1 0

git:master:e6b9cfee: modules: readme files regenerated - tm ... [skip ci]
by Kamailio Dev 30 Aug '17

30 Aug '17

Module: kamailio Branch: master Commit: e6b9cfeea47c7e377bbd030543a94437aaa54467 URL: https://github.com/kamailio/kamailio/commit/e6b9cfeea47c7e377bbd030543a9443… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-30T21:01:25+02:00 modules: readme files regenerated - tm ... [skip ci] --- Modified: src/modules/tm/README --- Diff: https://github.com/kamailio/kamailio/commit/e6b9cfeea47c7e377bbd030543a9443… Patch: https://github.com/kamailio/kamailio/commit/e6b9cfeea47c7e377bbd030543a9443… --- diff --git a/src/modules/tm/README b/src/modules/tm/README index 6e7bc5ca3f..bec0630d95 100644 --- a/src/modules/tm/README +++ b/src/modules/tm/README @@ -133,12 +133,13 @@ Daniel-Constantin Mierla 5. RPC Commands - 5.1. tm.t_uac_start - 5.2. tm.t_uac_wait - 5.3. tm.cancel - 5.4. tm.hash_stats - 5.5. tm.reply - 5.6. tm.reply_callid + 5.1. tm.list + 5.2. tm.t_uac_start + 5.3. tm.t_uac_wait + 5.4. tm.cancel + 5.5. tm.hash_stats + 5.6. tm.reply + 5.7. tm.reply_callid 6. Event Routes @@ -371,12 +372,13 @@ Chapter 1. Admin Guide 5. RPC Commands - 5.1. tm.t_uac_start - 5.2. tm.t_uac_wait - 5.3. tm.cancel - 5.4. tm.hash_stats - 5.5. tm.reply - 5.6. tm.reply_callid + 5.1. tm.list + 5.2. tm.t_uac_start + 5.3. tm.t_uac_wait + 5.4. tm.cancel + 5.5. tm.hash_stats + 5.6. tm.reply + 5.7. tm.reply_callid 6. Event Routes @@ -2797,14 +2799,22 @@ t_uac_send("OPTIONS", "sip:alice@kamailio.org", "", "", 5. RPC Commands - 5.1. tm.t_uac_start - 5.2. tm.t_uac_wait - 5.3. tm.cancel - 5.4. tm.hash_stats - 5.5. tm.reply - 5.6. tm.reply_callid + 5.1. tm.list + 5.2. tm.t_uac_start + 5.3. tm.t_uac_wait + 5.4. tm.cancel + 5.5. tm.hash_stats + 5.6. tm.reply + 5.7. tm.reply_callid -5.1. tm.t_uac_start +5.1. tm.list + + List details of transactions. + + Parameters: + * none + +5.2. tm.t_uac_start Generates and sends a local SIP request. @@ -2819,12 +2829,12 @@ t_uac_send("OPTIONS", "sip:alice@kamailio.org", "", "", * body - (optional, may not be present) request body (if present, requires the “Content-Type” and “Content-length” headers) -5.2. tm.t_uac_wait +5.3. tm.t_uac_wait Similar to rm.t_uac_start, but waits for the SIP reponse and tries to provide its details via RPC response. -5.3. tm.cancel +5.4. tm.cancel Generates and sends a CANCEL for an existing local SIP request. @@ -2832,14 +2842,14 @@ t_uac_send("OPTIONS", "sip:alice@kamailio.org", "", "", * callid - callid of the INVITE request to be cancelled. * cseq - cseq of the INVITE request to be cancelled. -5.4. tm.hash_stats +5.5. tm.hash_stats Gets information about the load of TM internal hash table. Parameters: * none -5.5. tm.reply +5.6. tm.reply Generates and sends a reply for an existing inbound SIP transaction. @@ -2853,7 +2863,7 @@ t_uac_send("OPTIONS", "sip:alice@kamailio.org", "", "", * body - (optional, may not be present) reply body (if present, requires the “Content-Type” and “Content-length” headers) -5.6. tm.reply_callid +5.7. tm.reply_callid Generates and sends a reply for an existing inbound SIP transaction.

1 0

git:master:ec62424d: tm: documentation for tm.list rpc command
by Daniel-Constantin Mierla 30 Aug '17

30 Aug '17

Module: kamailio Branch: master Commit: ec62424d2e1a9ff697f077c90eda27c08515e75e URL: https://github.com/kamailio/kamailio/commit/ec62424d2e1a9ff697f077c90eda27c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T20:55:20+02:00 tm: documentation for tm.list rpc command --- Modified: src/modules/tm/doc/rpc.xml --- Diff: https://github.com/kamailio/kamailio/commit/ec62424d2e1a9ff697f077c90eda27c… Patch: https://github.com/kamailio/kamailio/commit/ec62424d2e1a9ff697f077c90eda27c… --- diff --git a/src/modules/tm/doc/rpc.xml b/src/modules/tm/doc/rpc.xml index a846e1a67e..bc3fe332c5 100644 --- a/src/modules/tm/doc/rpc.xml +++ b/src/modules/tm/doc/rpc.xml @@ -7,6 +7,21 @@ </sectioninfo> <title>RPC Commands</title> + <section id="tm.rpc.list"> + <title> + <function moreinfo="none">tm.list</function> + </title> + <para> + List details of transactions. + </para> + <para>Parameters: </para> + <itemizedlist> + <listitem><para> + <emphasis>none</emphasis> + </para></listitem> + </itemizedlist> + </section> + <section id="tm.rpc.t_uac_start"> <title> <function moreinfo="none">tm.t_uac_start</function>

1 0

git:master:9fe9543d: tm: new rpc command tm.list
by Daniel-Constantin Mierla 30 Aug '17

30 Aug '17

Module: kamailio Branch: master Commit: 9fe9543d3d9b700fc51e4227a2a08e9715aa4eb2 URL: https://github.com/kamailio/kamailio/commit/9fe9543d3d9b700fc51e4227a2a08e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T20:53:25+02:00 tm: new rpc command tm.list - list details of the transactions --- Modified: src/modules/tm/t_stats.c Modified: src/modules/tm/t_stats.h Modified: src/modules/tm/tm.c --- Diff: https://github.com/kamailio/kamailio/commit/9fe9543d3d9b700fc51e4227a2a08e9… Patch: https://github.com/kamailio/kamailio/commit/9fe9543d3d9b700fc51e4227a2a08e9…

1 0

[kamailio/kamailio] TOPOH module mask_ip errantly skips decoding encoded fields (#1222)
by Joshua Riffle 30 Aug '17

30 Aug '17

The topoh module uses its `mask_ip` parameter to tag and identify fields that have been encrypted with its header value. As of Kamailio 4.4.6 code has been added to make sure that `mask_ip` is properly used in the request URI, or `Via`, or any other appropriate SIP header variable before it attempts to perform decryption. Here is a code block that was added at line 738 in `modules/topoh/th_msg.c` ``` /* Do nothing if ruri is not encoded */ if ((REQ_LINE(msg).uri.len<th_uri_prefix.len) || (strncasecmp(REQ_LINE(msg).uri.s,th_uri_prefix.s,th_uri_prefix.len)!=0)) { LM_DBG("ruri [%.*s] is not encoded",REQ_LINE(msg).uri.len,REQ_LINE(msg).uri.s); return 0; } ``` This effectively skips any Request URIs that don't properly match the expected `th_uri_prefix` which is created using the `mask_ip` value assigned to `topoh`.  So if I set topoh's `mask_ip` and assume I have set a `mask_key`: ``` modparam("topoh", "mask_ip", "192.168.99.184") ``` Then an `ACK` message like this gets detected and decoded as expected: ``` ACK sip:192.168.99.184;line=sr-1IFG6oxISo4wSekmUolOBKVwbolIboxd6JdwS7xiUekISKPm10NH18Rz1uBZtTpG SIP/2.0 ``` However, if one of my incoming carriers decides to be extra special and append port `:5060` to the request URI like this: ``` ACK sip:192.168.99.184:5060;line=sr-1IFG6oxISo4wSekmUolOBKVwbolIboxd6JdwS7xiUekISKPm10NH18Rz1uBZtTpG SIP/2.0 ``` It gets skipped by topoh because it no longer detects this variation of the URI and I get a message like this: ``` Aug 29 21:36:10 ip-172-31-4-69 /usr/sbin/kamailio[4629]: DEBUG: topoh [th_msg.c:742]: th_unmask_ruri(): ruri [sip:192.168.99.184:5060;line=sr-1IFG 6oxISo4wSekmUolOBKVwbolIboxd6JdwS7xiUekISKPm10NH18Rz1uBZtTpG] is not encoded ``` ### Troubleshooting I thought I might be smart and tried to change the `mask_ip` to `192.168.99.184:5060` but this is additionally blocked by the code that validates `Via` headers in `/modules/topoh/th_msg.c` line 393: ``` /* Skip if via is not encoded */ if (via->host.len!=th_ip.len || strncasecmp(via->host.s, th_ip.s, th_ip.len)!=0) { LM_DBG("via %d is not encoded",i); continue; } ``` It only compares the `host` part of the VIA with the `mask_ip` parameter which is `192.168.99.184:5060` (including the port) and therefore doesn't match and is skipped in decoding. #### Reproduction 1. Set `topoh` module `mask_ip` to any acceptable IP address 2. Attempt to handle any traffic from a carrier that adds `:5060` automatically to the end of its request URIs 3. The call will go through and then drop ~90 seconds due to incessant attempts of the Kamailio server attempting to reach the bogus `mask_ip` address #### Debugging Data I believe the above information is fairly plain. I have included the pertinent debug logs, but it is fairly well describing why `topoh` is not decoding certain lines that it should be. #### Log Messages Example of a line that should be decoded which is not being decoded because the incoming carrier has added `:5060` to the `mask_ip` used in the Request URI. ``` Aug 29 21:36:10 ip-172-31-4-69 /usr/sbin/kamailio[4629]: DEBUG: topoh [th_msg.c:742]: th_unmask_ruri(): ruri [sip:192.168.99.184:5060;line=sr-1IFG 6oxISo4wSekmUolOBKVwbolIboxd6JdwS7xiUekISKPm10NH18Rz1uBZtTpG] is not encoded ``` #### SIP Traffic ![examplecall](https://user-images.githubusercontent.com/1807347/29846497-f65ed1e2-8ccb-11e7-9a16-b18cfb4365a9.png) Example of a call that repeatedly attempts to access bogus `mask_ip` in its route because it is not detected by topoh for decoding after it is passed through a carrier which adds `:5060` to its Request URIs. ### Possible Solutions No workarounds :( I also don't have the option of asking carriers to change their standing policy of appending the port ":5060" but the validation efforts in the `topoh` module could be expanded to accept an undesignated port number in the URI or `topoh` could include a `mask_port` parameter so that it builds its URI to expect one in the request URI and in `Via` header fields. When I have more time to work on the validation C code I will include some suggestions, but others may have a more informed philosophical approach. ### Additional Information To see all changes to `th_msg.c`: ``` git diff 4.4.5 4.4.6 -- modules/topoh/th_msg.c ``` ``` version: kamailio 4.4.6 (x86_64/linux) becbde flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: becbde compiled on 10:23:24 Jun 16 2017 with gcc 4.4.7 ``` * **Operating System**: ``` CentOS release 6.8 (Final) Linux ip-172-31-4-69.us-west-2.compute.internal 2.6.32-642.3.1.el6.x86_64 #1 SMP Tue Jul 12 18:30:56 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1222

2 5

git:4.4:897942d4: modules: readme files regenerated - topoh ... [skip ci]
by Kamailio Dev 30 Aug '17

30 Aug '17

Module: kamailio Branch: 4.4 Commit: 897942d47e404a17d235c7dcb6237f024b99e3eb URL: https://github.com/kamailio/kamailio/commit/897942d47e404a17d235c7dcb6237f0… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-30T13:16:09+02:00 modules: readme files regenerated - topoh ... [skip ci] --- Modified: modules/topoh/README --- Diff: https://github.com/kamailio/kamailio/commit/897942d47e404a17d235c7dcb6237f0… Patch: https://github.com/kamailio/kamailio/commit/897942d47e404a17d235c7dcb6237f0… --- diff --git a/modules/topoh/README b/modules/topoh/README index 213524545c..fb7442cc56 100644 --- a/modules/topoh/README +++ b/modules/topoh/README @@ -34,6 +34,7 @@ Daniel-Constantin Mierla 3.7. vparam_prefix (str) 3.8. callid_prefix (str) 3.9. sanity_checks (integer) + 3.10. uri_prefix_checks (integer) List of Examples @@ -46,6 +47,7 @@ Daniel-Constantin Mierla 1.7. Set vparam_prefix parameter 1.8. Set callid_prefix parameter 1.9. Set sanity_checks parameter + 1.10. Set uri_prefix_checks parameter Chapter 1. Admin Guide @@ -68,6 +70,7 @@ Chapter 1. Admin Guide 3.7. vparam_prefix (str) 3.8. callid_prefix (str) 3.9. sanity_checks (integer) + 3.10. uri_prefix_checks (integer) 1. Overview @@ -113,6 +116,7 @@ Chapter 1. Admin Guide 3.7. vparam_prefix (str) 3.8. callid_prefix (str) 3.9. sanity_checks (integer) + 3.10. uri_prefix_checks (integer) 3.1. mask_key (str) @@ -226,3 +230,22 @@ modparam("topoh", "callid_prefix", "***") ... modparam("topoh", "sanity_checks", 1) ... + +3.10. uri_prefix_checks (integer) + + If set to 1, topoh module will check if URIs to be decoded match the + expected prefix composed from mask IP and parameter name prefix. It can + make the topoh processing safer by avoiding to try decoding URIs which + were not encoded previously by topoh. + + Note: do not enable this option if you have SIP devices that can alter + the URI values it takes from Contact or Record-Route headers (like + adding port 5060 when no port is in received URIs, or thet introduce + new parameters at unknown position). + + Default value is 0. + + Example 1.10. Set uri_prefix_checks parameter +... +modparam("topoh", "uri_prefix_checks", 1) +...

1 0

git:4.4:01da6686: topoh: option to disable uri prefix checks
by Daniel-Constantin Mierla 30 Aug '17

30 Aug '17

Module: kamailio Branch: 4.4 Commit: 01da6686c00aefb930067bfcb8310cf869278527 URL: https://github.com/kamailio/kamailio/commit/01da6686c00aefb930067bfcb8310cf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T13:07:27+02:00 topoh: option to disable uri prefix checks - some devices do not copy the exact URI as received in headers (Contact, Record-Route) - they can add default port or mix parameters - reported by GH #1165 (cherry picked from commit de3386e4a303adecc3eee809c05e0654b7a05065) (cherry picked from commit a9d6ffa5f39e048642bf14129b9b484250cce3ae) --- Modified: modules/topoh/th_msg.c Modified: modules/topoh/topoh_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/01da6686c00aefb930067bfcb8310cf… Patch: https://github.com/kamailio/kamailio/commit/01da6686c00aefb930067bfcb8310cf… --- diff --git a/modules/topoh/th_msg.c b/modules/topoh/th_msg.c index 1d4287f44a..5519b8daac 100644 --- a/modules/topoh/th_msg.c +++ b/modules/topoh/th_msg.c @@ -57,6 +57,7 @@ extern str th_vparam_prefix; extern int th_param_mask_callid; extern int th_mask_addr_myself; +extern int th_uri_prefix_checks; int th_skip_rw(char *s, int len) { @@ -391,8 +392,8 @@ int th_unmask_via(sip_msg_t *msg, str *cookie) if(i!=1) { /* Skip if via is not encoded */ - if (via->host.len!=th_ip.len - || strncasecmp(via->host.s, th_ip.s, th_ip.len)!=0) + if (th_uri_prefix_checks && (via->host.len!=th_ip.len + || strncasecmp(via->host.s, th_ip.s, th_ip.len)!=0)) { LM_DBG("via %d is not encoded",i); continue; @@ -687,10 +688,13 @@ int th_unmask_route(sip_msg_t *msg) if(i!=1) { /* Skip if route is not encoded */ - if ((rr->nameaddr.uri.len<th_uri_prefix.len) || - (strncasecmp(rr->nameaddr.uri.s,th_uri_prefix.s,th_uri_prefix.len)!=0)) + if (th_uri_prefix_checks + && ((rr->nameaddr.uri.len<th_uri_prefix.len) || + (strncasecmp(rr->nameaddr.uri.s,th_uri_prefix.s, + th_uri_prefix.len)!=0))) { - LM_DBG("rr %d is not encoded: [%.*s]",i,rr->nameaddr.uri.len,rr->nameaddr.uri.s); + LM_DBG("rr %d is not encoded: [%.*s]", i, + rr->nameaddr.uri.len, rr->nameaddr.uri.s); rr = rr->next; continue; } @@ -736,8 +740,9 @@ int th_unmask_ruri(sip_msg_t *msg) str out; /* Do nothing if ruri is not encoded */ - if ((REQ_LINE(msg).uri.len<th_uri_prefix.len) || - (strncasecmp(REQ_LINE(msg).uri.s,th_uri_prefix.s,th_uri_prefix.len)!=0)) + if (th_uri_prefix_checks && ((REQ_LINE(msg).uri.len<th_uri_prefix.len) || + (strncasecmp(REQ_LINE(msg).uri.s, th_uri_prefix.s, + th_uri_prefix.len)!=0))) { LM_DBG("ruri [%.*s] is not encoded",REQ_LINE(msg).uri.len,REQ_LINE(msg).uri.s); return 0; @@ -798,8 +803,8 @@ int th_unmask_refer_to(sip_msg_t *msg) uri = &(get_refer_to(msg)->uri); /* Do nothing if refer_to is not encoded */ - if ((uri->len<th_uri_prefix.len) - || (strncasecmp(uri->s, th_uri_prefix.s, th_uri_prefix.len)!=0)) + if (th_uri_prefix_checks && ((uri->len<th_uri_prefix.len) + || (strncasecmp(uri->s, th_uri_prefix.s, th_uri_prefix.len)!=0))) { LM_DBG("refer-to [%.*s] is not encoded",uri->len,uri->s); return 0; diff --git a/modules/topoh/topoh_mod.c b/modules/topoh/topoh_mod.c index 266cc465a8..9742cef143 100644 --- a/modules/topoh/topoh_mod.c +++ b/modules/topoh/topoh_mod.c @@ -74,11 +74,12 @@ str th_uri_prefix = {0, 0}; int th_param_mask_callid = 0; int th_sanity_checks = 0; -sanity_api_t scb; +int th_uri_prefix_checks = 0; int th_mask_addr_myself = 0; int th_msg_received(void *data); int th_msg_sent(void *data); +sanity_api_t scb; /** module functions */ static int mod_init(void); @@ -93,6 +94,7 @@ static param_export_t params[]={ {"vparam_prefix", PARAM_STR, &th_vparam_prefix}, {"callid_prefix", PARAM_STR, &th_callid_prefix}, {"sanity_checks", PARAM_INT, &th_sanity_checks}, + {"uri_prefix_checks", PARAM_INT, &th_uri_prefix_checks}, {0,0,0} };

1 0

git:4.4:4b2c51a5: topoh: documented uri_prefix_checks parameter
by Daniel-Constantin Mierla 30 Aug '17

30 Aug '17

Module: kamailio Branch: 4.4 Commit: 4b2c51a527cb5e7810694ef64754608e8aca68a3 URL: https://github.com/kamailio/kamailio/commit/4b2c51a527cb5e7810694ef64754608… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T13:07:44+02:00 topoh: documented uri_prefix_checks parameter (cherry picked from commit ca3f2fc6dd2c94410b225d2efb82081b828ddd01) (cherry picked from commit 826b3cab606fb51c7139fe81463aeb2409f40b67) --- Modified: modules/topoh/doc/topoh_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/4b2c51a527cb5e7810694ef64754608… Patch: https://github.com/kamailio/kamailio/commit/4b2c51a527cb5e7810694ef64754608… --- diff --git a/modules/topoh/doc/topoh_admin.xml b/modules/topoh/doc/topoh_admin.xml index fd588cd5f3..f4f5702a06 100644 --- a/modules/topoh/doc/topoh_admin.xml +++ b/modules/topoh/doc/topoh_admin.xml @@ -10,9 +10,9 @@  <chapter> - + <title>&adminguide;</title> - + <section> <title>Overview</title> <para> @@ -253,7 +253,34 @@ modparam("topoh", "sanity_checks", 1) </programlisting> </example> </section> - + <section> + <title><varname>uri_prefix_checks</varname> (integer)</title> + <para> + If set to 1, topoh module will check if URIs to be decoded match + the expected prefix composed from mask IP and parameter name prefix. + It can make the topoh processing safer by avoiding to try decoding + URIs which were not encoded previously by topoh. + </para> + <para> + Note: do not enable this option if you have SIP devices that can + alter the URI values it takes from Contact or Record-Route headers + (like adding port 5060 when no port is in received URIs, or + thet introduce new parameters at unknown position). + </para> + <para> + <emphasis> + Default value is 0. + </emphasis> + </para> + <example> + <title>Set <varname>uri_prefix_checks</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("topoh", "uri_prefix_checks", 1) +... +</programlisting> + </example> + </section> </section> </chapter>

1 0

git:5.0:006d7953: kamdbctl: regenerated db creation scripts
by Daniel-Constantin Mierla 30 Aug '17

30 Aug '17

Module: kamailio Branch: 5.0 Commit: 006d79534711ce054ff45abce7978430cfab38a8 URL: https://github.com/kamailio/kamailio/commit/006d79534711ce054ff45abce797843… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T13:00:54+02:00 kamdbctl: regenerated db creation scripts --- Modified: utils/kamctl/db_berkeley/kamailio/rtpengine Modified: utils/kamctl/db_sqlite/rtpengine-create.sql Modified: utils/kamctl/dbtext/kamailio/rtpengine Modified: utils/kamctl/mongodb/kamailio/rtpengine.json Modified: utils/kamctl/mysql/rtpengine-create.sql Modified: utils/kamctl/oracle/rtpengine-create.sql Modified: utils/kamctl/postgres/rtpengine-create.sql Modified: utils/kamctl/xhttp_pi/pi_framework.xml Modified: utils/kamctl/xhttp_pi/rtpengine-mod Modified: utils/kamctl/xhttp_pi/rtpengine-table --- Diff: https://github.com/kamailio/kamailio/commit/006d79534711ce054ff45abce797843… Patch: https://github.com/kamailio/kamailio/commit/006d79534711ce054ff45abce797843…

1 0

git:5.0:68e1b32c: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 30 Aug '17

30 Aug '17

Module: kamailio Branch: 5.0 Commit: 68e1b32ca79454cb222ceac08b1ff78f9c265fc4 URL: https://github.com/kamailio/kamailio/commit/68e1b32ca79454cb222ceac08b1ff78… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-30T12:46:37+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/cplc/README Modified: src/modules/http_client/README Modified: src/modules/jsonrpcs/README Modified: src/modules/pua_reginfo/README Modified: src/modules/rr/README --- Diff: https://github.com/kamailio/kamailio/commit/68e1b32ca79454cb222ceac08b1ff78… Patch: https://github.com/kamailio/kamailio/commit/68e1b32ca79454cb222ceac08b1ff78…

1 0

git: new commits in branch 5.0
by Daniel-Constantin Mierla 30 Aug '17

30 Aug '17

- URL: https://github.com/kamailio/kamailio/commit/06a03ab05b6db405505eff0b7b1bb1d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-29T23:12:54+02:00 core: do not execute clear_branches() on next faked msg - the function clears the global variables for branches (cherry picked from commit 68db22bdfe50ff34df8e33bc06b80b5ad4844d7b) - URL: https://github.com/kamailio/kamailio/commit/852f2d9138dc94d6c49ddc86d062561… Author: Eloy Coto <eloy.coto(a)gmail.com> Date: 2017-08-29T23:15:35+02:00 evapi: Improved error message Signed-off-by: Eloy Coto <eloy.coto(a)gmail.com> (cherry picked from commit 5f249318adfe26b35426c2b43f4c3df31edc1de1) - URL: https://github.com/kamailio/kamailio/commit/a77351ebf01ab7d84259b729c543a9c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-29T23:15:57+02:00 core: faked msg - functions to get next fmsg with clear branches (cherry picked from commit 10129d056e3660a33b6ebc7b487b1de0f616dcc9) - URL: https://github.com/kamailio/kamailio/commit/cebcf91e1941d4d82d1ca503fe9cf4c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-29T23:20:05+02:00 htable: map $shtrecord() inner names over integer ids - avoid string comparison at runtime (cherry picked from commit 8ce1bcd52cd5117f920acce5f78683e974d4a3a4) - URL: https://github.com/kamailio/kamailio/commit/00d2cc7695fe97bc82c5d9b7c10b66f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:01:15+02:00 core: updated log macros for parse rpid (cherry picked from commit a526764c65ffea767fecbb13021ba48304524882) - URL: https://github.com/kamailio/kamailio/commit/bfeb32bd00f9eaaafcb6e90388bde7d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:04:52+02:00 pv: coherent whitespacing and indentation for pv time code (cherry picked from commit da07cc8c724724d89dfe02bbe8a980f241afc582) - URL: https://github.com/kamailio/kamailio/commit/cec019449abf718f2215cb99616a701… Author: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-08-30T00:05:58+02:00 modules/jsonrpcs: add missing apostrophe to example (cherry picked from commit f0f1a9a8db1f5238b0ace1d3f190d0d9f0b2628d) - URL: https://github.com/kamailio/kamailio/commit/662d1aac66a35c51e23c69fcb88b446… Author: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-08-30T00:06:57+02:00 core/socket_info: use internal str2int() instead of strtol() - strtol() works only for null terminated strings - fix for issue GH #1161 (cherry picked from commit baf2d095b1d4dcc932ece9d48a6a8c397fa7b1a7) - URL: https://github.com/kamailio/kamailio/commit/58656b7f158be13058e72df6779d5d9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:07:53+02:00 core: remove inline from implementation of functions declared without it (cherry picked from commit 9c9da87943ad86fd4ca3ba8b007cebfcb7d9bc61) - URL: https://github.com/kamailio/kamailio/commit/69bc83888cc8009d319957d24704bcd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:09:01+02:00 rr: small formatting adjustments to doc examples (cherry picked from commit e518e5e7a50be3510c896bd5f8a4cc38146631cc) - URL: https://github.com/kamailio/kamailio/commit/3526f30c0e9a882cfe870295d49cc0d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:10:52+02:00 tls: dynamic locks not needed for openssl v1.1.0+ - openssl v1.1.0 is thread safe - fixes the compile warnings for libssl 1.1.0 (cherry picked from commit e7c03ce6ce61119fbf5cb9f41b7abcd4c7138d58) - URL: https://github.com/kamailio/kamailio/commit/5f5c149395c78124f7a84875789d479… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:11:22+02:00 tls: updated tls version selection for libssl 1.1.0 api - fixes compile warnings for deprecated TLSXY_method() functions (cherry picked from commit 76efc9b7a1489007f9ff431e730ce4e86b446a6c) - URL: https://github.com/kamailio/kamailio/commit/1775e88e34acaa30dd0138d241eea06… Author: Ilya Shipitsin <chipitsine(a)gmail.com> Date: 2017-08-30T00:11:43+02:00 utils/db_berkeley: access variable after null pointer check (cherry picked from commit bbe0370939ff8a14e931595389b6678817ff1056) - URL: https://github.com/kamailio/kamailio/commit/55ed4b37da77e0d928078e6b9842325… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:12:55+02:00 core: dns cache - catch unknown record type to avoid compile warnings (cherry picked from commit f461081a400b398a8c47b1cb338ffc4bf8bd2ede) - URL: https://github.com/kamailio/kamailio/commit/4043bbc434ab7f80580c3f71b861bb4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:13:21+02:00 core: parse fline - cast number to char for print to avoid compile warning (cherry picked from commit ccb368e6420c1e4849867bcdbd136d0e9a8db67d) - URL: https://github.com/kamailio/kamailio/commit/ebe9387547a65f34b81b0184df4f284… Author: Olle E. Johansson <oej(a)edvina.net> Date: 2017-08-30T00:13:49+02:00 db_mysql Look for MariaDB as well as MySQL (cherry picked from commit 4f587124998e665c5ab9df7fe14cfbb3a39a9ec8) - URL: https://github.com/kamailio/kamailio/commit/efee46251f7da2007a4e6e563a6d4e4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:15:29+02:00 websocket: use sizeof over the type of the pointer to be allocated (cherry picked from commit 145d10f5a2dcad3cbdb477aaabdc853bb606b355) - URL: https://github.com/kamailio/kamailio/commit/db0e94f53acb6ab86eb8730043effcf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:16:22+02:00 http_client: move to next field before freeing item in fixup function (cherry picked from commit fce9044ece62d6b5e81330de62fa1fa402145e68) - URL: https://github.com/kamailio/kamailio/commit/f6ac44c5528c4a20e75a4e4b77d27f5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:16:43+02:00 http_client: allow providing headers to http_client_query() - lost from removed http_query() in utils (cherry picked from commit 9c1d4cec94b47cd0b2e69e646f2fd14b84e3cf03) - URL: https://github.com/kamailio/kamailio/commit/964ca6b32581f6af1ce1b97646d5796… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:17:04+02:00 http_client: updated docs for http_client_query() (cherry picked from commit 279e622b53b636d49b207907c8f3fe60ff9e2cd3) - URL: https://github.com/kamailio/kamailio/commit/29d871493601cb80c77f870aff94a7f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:21:31+02:00 Makefile.defs: compile with system malloc for pkg if MEMPKG=sys - if MEMDBGSYS=1, the use a debug variant for system malloc (cherry picked from commit cee1de72a2b28d002bc84dd205b7ecf9f285fdd4) - URL: https://github.com/kamailio/kamailio/commit/cd59fcf3fef3a1446a49d60ad636ff2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:22:26+02:00 core: mem - updated defines for sys malloc and mem error log messages (cherry picked from commit 1cc3f0ddfc517ed2b1f7820f9feedee8a91d0ac7) - URL: https://github.com/kamailio/kamailio/commit/1c82b218273bacaf1a6cfa93fdc2c8e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:23:55+02:00 http_client: move assign for download size after right side variable was set (cherry picked from commit 632380ff13dce5d5f1d1553797b7783fdc986c59) - URL: https://github.com/kamailio/kamailio/commit/f351ea29f2d561fbd4d362a795cf535… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:24:23+02:00 siptrace: proper varible in log message when af is unknown (cherry picked from commit b1a6830c414ddcfb21fc07bc4995b756d617558e) - URL: https://github.com/kamailio/kamailio/commit/e92b6ecc52cc6a64856c929043504c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T00:25:10+02:00 core: dns cachec- safety check in log message before abort (cherry picked from commit ff2e0d96a50eadf4e872865d43f0fbe15aef18bd) - URL: https://github.com/kamailio/kamailio/commit/3ba4cc6c039056c8cebd21911709ffa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:45:43+02:00 rr: use macro to get parsed From in record_route_preset() - safety check for parsed pointer (cherry picked from commit 8b0a42ab64c02a1fa253ce156442bab64a4fe3db) - URL: https://github.com/kamailio/kamailio/commit/09488d07231bd59f4466a681f2f792e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:46:54+02:00 seas: avoid double free and leak (cherry picked from commit 366104d2f79ccfa65850cd2e3bfb5ed8be467bc2) - URL: https://github.com/kamailio/kamailio/commit/571bba63f2cfbcbcd601d41a6d930d2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:47:50+02:00 enum: fixed code for country code length (cherry picked from commit b95e536335083ee6f1f67e2007463ac7e8403ec8) - URL: https://github.com/kamailio/kamailio/commit/e070571cf59a43b615690a3ec2fd919… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:48:18+02:00 core: avoid accessing freed structure in case of duplicated listen addresses (cherry picked from commit dbd52dacae17eca5a48359c605a2d93607b7c041) - URL: https://github.com/kamailio/kamailio/commit/2ff8e36250864e6a391bd9d0ebb28a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:49:05+02:00 core: parse rr - reset head in case of parse error - avoid acessing an invalid pointer - proper support if trying to parse into an existing rr list in a second attempt (not the case so far) (cherry picked from commit 8eb84f76a6d52598bb2fd5d13b96fba4c6326b7f) - URL: https://github.com/kamailio/kamailio/commit/5b727e0f2ee8d4abc6ba4694d545221… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:49:32+02:00 cfgutils: more log messages for locking functions - it was silent if locks set was not initialized properly which could mislead at runtime, but not showing any error message - if locks set size is too big, set it to 14 (this is used as power of 2) (cherry picked from commit 3ce65db8747ad7b382824f389c2b782a76dbb7a1) - URL: https://github.com/kamailio/kamailio/commit/1001a8333f8475f203d5a3951398297… Author: Vasiliy Ganchev <vance(a)ukr.net> Date: 2017-08-30T11:50:04+02:00 pua_reginfo: use outbound proxy for PUBLISH requests (cherry picked from commit 385995c27084bdca9ebc4a472f9ab41311416f35) - URL: https://github.com/kamailio/kamailio/commit/2590955b6176acef2633b65dbcc5946… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:50:58+02:00 core: cfg.y - fixed condition on case parsing (cherry picked from commit 52f728f73914ab960389ff8afbf1a223f91f07e2) - URL: https://github.com/kamailio/kamailio/commit/302cc81697d7b7a7b187cfb8c87a486… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:52:04+02:00 core: mem/qm - fixed pointer expressions in qm_check() debug function (cherry picked from commit 126e76dc035bd1320cb103c39ad52849844e7448) - URL: https://github.com/kamailio/kamailio/commit/0b940b8f3f5270336a17c8651477749… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:52:23+02:00 core: parser uri - add missing break to avoid useless assignments (cherry picked from commit 1a5662b212ddcbea40ca33e34bfda0459802b756) - URL: https://github.com/kamailio/kamailio/commit/a309561c6cc81187939234a524e5a9d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:52:46+02:00 core: proxy - free in case of errors making proxy only from ip (cherry picked from commit 0aa7571afe5c25bfffaf865595181470ac78f4d2) - URL: https://github.com/kamailio/kamailio/commit/3f076581e3b9ffc46aa82cfcfba3c0f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:53:16+02:00 core: free locl link structures not linked to listen sockets (cherry picked from commit 98a6ef19bcfe14b7150183a9bec98854f5c0063b) - URL: https://github.com/kamailio/kamailio/commit/eb71b7958cd8217bdc4099462fa3ae6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:53:34+02:00 core: msg translator - reworked error handling to free allocated buffers (cherry picked from commit 6118d832d3ba0efb96820915520af3c8a9bf29de) - URL: https://github.com/kamailio/kamailio/commit/01a93753d6240515872a9efc58c7eb8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:53:50+02:00 tmx: missing break in t_cancel_branches(others) (cherry picked from commit 2ab0adee57aa82487adf7d3776835eca071afa27) - URL: https://github.com/kamailio/kamailio/commit/301ee8bb20e5853783496f1080b9fc9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:54:07+02:00 dialog: safety checks and free of profiles in case of errors - free partial list of profiles in dlg_set_timeout_by_profile() when no more memory (cherry picked from commit 609297d62a08d1d75550c2f5e7f7fd19b98fd104) - URL: https://github.com/kamailio/kamailio/commit/2232c34ed2a0c5953161e7b17e0ca40… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:54:31+02:00 dispatcher: log messages for hashing auth username (cherry picked from commit e9cfb2bf5012cdbde36559f615b58e3a556bfc2d) - URL: https://github.com/kamailio/kamailio/commit/954fd81f7b0431f16b6a3112f7a421f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:54:57+02:00 mtree: access values before safety checks of variables (cherry picked from commit 56d1d317e4bac7130586541fed75be670ea0f9ce) - URL: https://github.com/kamailio/kamailio/commit/15de3bb82f609a1c055194eb9e505ae… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:55:13+02:00 xcap_server: reset server_name variable after free - avoid re-use in the loop (cherry picked from commit 22aa9043f179f4de8e90fc5946a7afb28060b6f6) - URL: https://github.com/kamailio/kamailio/commit/cd43bb023447ec47d9f83923995c1ae… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:55:28+02:00 avp: return in case of error in avp select (cherry picked from commit 9a6182fa8b535bc19c43e905d6b6a110b0e830d2) - URL: https://github.com/kamailio/kamailio/commit/c1e0910498dea28c6405ec0683e42d4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:55:44+02:00 presence: reset vars to avoid double free in case of error (cherry picked from commit 97ac3b910dc955058fa4c08ad22ac01a4f31fe74) - URL: https://github.com/kamailio/kamailio/commit/127cafe9eafdf8c3d8ed5926884cba5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:55:58+02:00 rls: reset vars to avoid double free in case of error (cherry picked from commit ceaafc67dae4f7e7424c8706ccea90c30eed45b6) - URL: https://github.com/kamailio/kamailio/commit/03e5f8af4bfcc5ea34cf678ac2d9b77… Author: Stefan Mititelu <stefan.mititelu(a)onem.com> Date: 2017-08-30T11:56:18+02:00 dispatcher: Increase line buffer size (cherry picked from commit 1391db0f349956795b8cf6936657fb974ec9b65f) - URL: https://github.com/kamailio/kamailio/commit/23162ffd62cffe78107625349a7dbde… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:56:35+02:00 rls: added missing license headers, coherent indentation (cherry picked from commit 61d3d4ad675032b7a1fc059acef68e81c40b4eba) - URL: https://github.com/kamailio/kamailio/commit/e87051951dcf5a4ea22714c0a1f5c95… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:56:53+02:00 msrp: safety checks to avoid analyzer reports (cherry picked from commit 74653204f45195944acc42979d0939cef9513cd4) - URL: https://github.com/kamailio/kamailio/commit/3850fe062d5ecbe4f7e9a9ae59192f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:57:08+02:00 textopsx: free in case of error inside sel_hf_value_name() (cherry picked from commit 7987122d25003dd4b5f0ce47caf3e5c9811917b3) - URL: https://github.com/kamailio/kamailio/commit/39956a5595110ac04e01ebd38c4f852… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:57:54+02:00 jsonrpcs: safety vars init and release checks (cherry picked from commit 080bffeb53181131f8fb8fab0ddcb771bbdd37dc) - URL: https://github.com/kamailio/kamailio/commit/8872413b981fb12c037ed08b39fbea7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:58:13+02:00 pv: free var in case pkg alloc failure (cherry picked from commit 86e349463c7d573e9a5e68bd3984ecc95808adb4) - URL: https://github.com/kamailio/kamailio/commit/54c83a86590e66d47470fd1690a03f8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:59:04+02:00 dispatcher: try to add sip: scheme to dst uri, if initial parse fails - operation done when records are loaded from database or file (cherry picked from commit 4220c41f9a443d275cf94e1db3a33fbd3ca14d1b) - URL: https://github.com/kamailio/kamailio/commit/5e36ab3a0028fa9f7c5857c866b0b43… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T11:59:44+02:00 lib: dtrie - removed duplicate check for same value (cherry picked from commit 5530fe31fe89a4dfe9e17cbe56c0cd83cb8f45ab) - URL: https://github.com/kamailio/kamailio/commit/58592f0069ccf35ae1a9cbd4c4500c9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:00:00+02:00 auth_db: small reorder to do the check before accessing the fields (cherry picked from commit 070057a5d66e2f5dd4bcf90d96f8f8ceeca3a433) - URL: https://github.com/kamailio/kamailio/commit/c5800bc37a629871476ed0a607a055f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:00:19+02:00 registrar: free var in case of pv name error (cherry picked from commit b28e2943b8d171628f81057a352507b2a56b91a4) - URL: https://github.com/kamailio/kamailio/commit/697d19eb23bf01c9c7aa83e8f563828… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:00:35+02:00 usrloc: rpc flush to return error in case of failure (cherry picked from commit 3cbae6841c80de89fc7c72b73c1695e3788c1819) - URL: https://github.com/kamailio/kamailio/commit/9e124c03cfcc33ca3f9090fb097353a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:00:46+02:00 async: free var in case of fixup error (cherry picked from commit bf9d697c31ad2c7614aa37997c4772df8e8d25a7) - URL: https://github.com/kamailio/kamailio/commit/046f0123879be21cd78430c6a46e977… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:00:58+02:00 evapi: handle return code for fcntl (cherry picked from commit c0125e049f1c34afe7411f763f9f57c7a00109a8) - URL: https://github.com/kamailio/kamailio/commit/273f233c18a56c87e566c9ee452c5ae… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:01:17+02:00 evapi: close server socket if fnctl() fails (cherry picked from commit 23ee80c8d71b9bac63ebe6117620cffc8900c2a9) - URL: https://github.com/kamailio/kamailio/commit/b3f228d143a0af32a58d73fc49f3664… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:02:00+02:00 xlog: free vars in case of errors in fixup functions (cherry picked from commit cd17ca9113031b979fe403255388105ecee0fe73) - URL: https://github.com/kamailio/kamailio/commit/93283a687dc77dfdae3f010035427c6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:02:32+02:00 lib/srdb1: added autoincrement id column for rtpengine (cherry picked from commit 9c74b35b06465c9dde23971e342846491fa41c2c) - URL: https://github.com/kamailio/kamailio/commit/adfc7f6033872d1a81b473df562981e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:02:51+02:00 lib/srdb1: make (setid,url) unique key instead of primary - conflicts with autoincrement in mysql (cherry picked from commit b8e9d2697a13c2cdb367aabf4966d6fa09a1319f) - URL: https://github.com/kamailio/kamailio/commit/4ce12109008528bcf03dba0901bf650… Author: Oriol Capsada <ocapsada(a)gmail.com> Date: 2017-08-30T12:04:06+02:00 cplc: use route names to set proxy_route modparam - Changed proxy_route modparam type to string. The route to be executed needs to be defined by name as the current id definition led to some unpredictable behavior. (cherry picked from commit 027871f7a91cf288d36029a4f339801e8b620d10) - URL: https://github.com/kamailio/kamailio/commit/40586c41d1f9f00210318de2a9862ad… Author: grumvalski <federico.cabiddu(a)gmail.com> Date: 2017-08-30T12:04:29+02:00 core: set RET_ARRAY flag for core.sockets_list command (cherry picked from commit 38f514064a326f759e0e88adeffd03b32b35d6c0) - URL: https://github.com/kamailio/kamailio/commit/d620b8e94832e2394fb1c48a7f062c7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:05:48+02:00 db_postgres: added missing break for INT8OID results - instead of DB1_BIGINT, the result type ended to be DB1_DOUBLE (cherry picked from commit d12f96af28e170c3197a47af5840e5e30639adf6) - URL: https://github.com/kamailio/kamailio/commit/b14d34d734fb5065350d35318e34bb9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:06:27+02:00 lib/srdb1: db_table_version() can handle DB1_BIGINT and DB1_DOUBLE values - in case of views or other database engine, the type for version value can be different that DB1_INT. If it is a number, cast it to int - extracted from GH #1186 by Emmanuel Schmidbauer <emmanuel(a)getweave.com> (cherry picked from commit d0ac74742f6aeb71492d2a9cab747162cdc5ddf8) - URL: https://github.com/kamailio/kamailio/commit/d40268a04de501dadc0f8629e521f3f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:17:14+02:00 pdb: avoid unaligned pointer address (cherry picked from commit 7c795adaf0f3899567a9769fecbbb300387837be) - URL: https://github.com/kamailio/kamailio/commit/d8f0d9e776000415720051fd6e55ed1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:32:49+02:00 app_lua: safer alloc size for hdr operations (cherry picked from commit 15de1f06b94588ed0764ab3a3b0cd1202b5c1cb6) - URL: https://github.com/kamailio/kamailio/commit/31d1fba458f941fb5b580d0220118ce… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-30T12:33:15+02:00 app_python: several free of allocated vars in case of errors (cherry picked from commit 8353b0341ada19d6f0611e0aa693bfa20db0b51c)

1 0

git:master:8d9459b7: tls: fix sanitization of log macros commit a8b30d340f9d
by Victor Seva 29 Aug '17

29 Aug '17

Module: kamailio Branch: master Commit: 8d9459b7de28de90993e7e26c827298c7b2d08a4 URL: https://github.com/kamailio/kamailio/commit/8d9459b7de28de90993e7e26c827298… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-08-29T12:58:41+02:00 tls: fix sanitization of log macros commit a8b30d340f9d --- Modified: src/modules/tls/tls_init.c --- Diff: https://github.com/kamailio/kamailio/commit/8d9459b7de28de90993e7e26c827298… Patch: https://github.com/kamailio/kamailio/commit/8d9459b7de28de90993e7e26c827298… --- diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c index 65704ff27e..936bec1f81 100644 --- a/src/modules/tls/tls_init.c +++ b/src/modules/tls/tls_init.c @@ -763,7 +763,6 @@ int init_tls_h(void) }else low_mem_threshold2*=1024; /* KB */ if ((low_mem_threshold1==0) || (low_mem_threshold2==0)) - :w LM_WARN("tls: openssl bug #1491 (crash/mem leaks on low memory)" " workarround disabled\n"); else

1 0

Broken: kamailio/kamailio#4766 (master - a8b30d3)
by Travis CI 29 Aug '17

29 Aug '17

Build Update for kamailio/kamailio ------------------------------------- Build: #4766 Status: Broken Duration: 5 minutes and 38 seconds Commit: a8b30d3 (master) Author: Daniel-Constantin Mierla Message: tls: sanitization of log macros View the changeset: https://github.com/kamailio/kamailio/compare/fcc4b8ed5377...a8b30d340f9d View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/269519919?utm_source=email&u… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

git:master:a8b30d34: tls: sanitization of log macros
by Daniel-Constantin Mierla 29 Aug '17

29 Aug '17

Module: kamailio Branch: master Commit: a8b30d340f9d19daac10ed987707adf7327ef420 URL: https://github.com/kamailio/kamailio/commit/a8b30d340f9d19daac10ed987707adf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-29T12:03:50+02:00 tls: sanitization of log macros --- Modified: src/modules/tls/fixed_c_zlib.h Modified: src/modules/tls/tls_init.c Modified: src/modules/tls/tls_mod.c Modified: src/modules/tls/tls_verify.c --- Diff: https://github.com/kamailio/kamailio/commit/a8b30d340f9d19daac10ed987707adf… Patch: https://github.com/kamailio/kamailio/commit/a8b30d340f9d19daac10ed987707adf…

1 0

[kamailio/kamailio] Document record-call option in rtpengine (#1221)
by aalba6675 29 Aug '17

29 Aug '17

### Description Document record-call option in rtpengine module  ### Troubleshooting rtpengine module has an undocumented option in rtpengine_manage and rtpengine_offer ``` rtpengine_manage("record-call=on") ``` The use case is to start the recording immediately so the recording structures are initialized in rtpengine. If we do not do this but use a sequence like ``` rtpengine_manage() /* A */ /* what happens is recording structures are no initialized so metadata for caller's SDP is not written ou */ start_recording() /* B */ ``` The metadata of the recording will omit the caller's SDP because this is written out during A but recording structures are only initialized in B. https://github.com/sipwise/rtpengine/issues/385 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1221

2 4

Accounting server with IMS Kamailio Solution
by Prasannakumar Merugu 28 Aug '17

28 Aug '17

Hi, We are developing proprietary kamailio-ims solution as shown in below configuration for our immediate requirement. Is this configuration with Accounting server between UA and P-Server workable? Later on we want to add standard solution. Thanks, Prasannakumar Merugu. 9010028290

1 1

git:master:fcc4b8ed: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 28 Aug '17

28 Aug '17

Module: kamailio Branch: master Commit: fcc4b8ed537714c2ab5bbb7de221e0218e913d24 URL: https://github.com/kamailio/kamailio/commit/fcc4b8ed537714c2ab5bbb7de221e02… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-28T12:31:32+02:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/fcc4b8ed537714c2ab5bbb7de221e02… Patch: https://github.com/kamailio/kamailio/commit/fcc4b8ed537714c2ab5bbb7de221e02… --- diff --git a/src/modules/rtpengine/README b/src/modules/rtpengine/README index 7d88a8be81..fd8a840716 100644 --- a/src/modules/rtpengine/README +++ b/src/modules/rtpengine/README @@ -1959,6 +1959,11 @@ rtpengine_offer(); the Sipwise rtpengine proxy. This is especially useful when the first call leg is handled by some rtpengine machine while the second call leg is handled by other rtpengine machine. + + record-call=on - instructs RTPEngine to record the session. + Use it in rtpengine_offer() to start recording immediately and + save the call metadata, as alternative to start_recording(). + Check also the documentation of RTPEngine, these flags are + documented there as well: https://github.com/sipwise/rtpengine. This function can be used from ANY_ROUTE. @@ -2077,8 +2082,10 @@ rtpengine_manage(); 5.7. start_recording() - This function will send a signal to the RTP proxy to record the RTP - stream on the RTP proxy. + This function will send a signal to the RTP relay to record the RTP + stream flowing through it. See also the option “record-call=on” for + rtpengine_manage()/rtpengine_offer(), which offers an alternative for + call recording, saving also call metadata from SDP. This function can be used from REQUEST_ROUTE and ONREPLY_ROUTE.

1 0

git:master:5272f4e4: rtpengine: documented the flag for call recording
by Daniel-Constantin Mierla 28 Aug '17

28 Aug '17

Module: kamailio Branch: master Commit: 5272f4e4e302e44ad870bd8b8936c2517848c0ca URL: https://github.com/kamailio/kamailio/commit/5272f4e4e302e44ad870bd8b8936c25… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-28T12:25:09+02:00 rtpengine: documented the flag for call recording - reported by GH #1221 --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/5272f4e4e302e44ad870bd8b8936c25… Patch: https://github.com/kamailio/kamailio/commit/5272f4e4e302e44ad870bd8b8936c25… --- diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml index 4a7272629a..15355bb8c0 100644 --- a/src/modules/rtpengine/doc/rtpengine_admin.xml +++ b/src/modules/rtpengine/doc/rtpengine_admin.xml @@ -2036,7 +2036,7 @@ rtpengine_offer(); <listitem><para> <emphasis>no-redis-update</emphasis> - this flag can be used by Kamailio in order to tell rtpengine not to persist the call into Redis upon receiving offer/answer() - control commands. If flag is not set, default action is rtpengine persists call + control commands. If flag is not set, default action is rtpengine persists call to redis. </para></listitem> <listitem><para> @@ -2273,7 +2273,16 @@ rtpengine_offer(); in the Sipwise rtpengine proxy. This is especially useful when the first call leg is handled by some rtpengine machine while the second call leg is handled by other rtpengine machine. </para></listitem> + <listitem><para> + <emphasis>record-call=on</emphasis> - instructs RTPEngine to record the session. Use + it in rtpengine_offer() to start recording immediately and save the call metadata, + as alternative to start_recording(). + </para></listitem> </itemizedlist> + <para> + Check also the documentation of RTPEngine, these flags are documented there as well: + <ulink url="https://github.com/sipwise/rtpengine">https://github.com/sipwise/rtpengine</ulink>. + </para> </listitem> </itemizedlist> <para> @@ -2466,8 +2475,11 @@ rtpengine_manage(); <function moreinfo="none">start_recording()</function> </title> <para> - This function will send a signal to the &rtp; proxy to record - the &rtp; stream on the &rtp; proxy. + This function will send a signal to the &rtp; relay to record + the &rtp; stream flowing through it. See also the option + <quote>record-call=on</quote> for rtpengine_manage()/rtpengine_offer(), + which offers an alternative for call recording, saving also call + metadata from SDP. </para> <para> This function can be used from REQUEST_ROUTE and ONREPLY_ROUTE.

1 0

git:master:2d79d1fc: auth: removed module and function names from logs
by Daniel-Constantin Mierla 28 Aug '17

28 Aug '17

Module: kamailio Branch: master Commit: 2d79d1fc20ee1cd056b1b4b453c557671ae99f08 URL: https://github.com/kamailio/kamailio/commit/2d79d1fc20ee1cd056b1b4b453c5576… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-27T11:11:17+02:00 auth: removed module and function names from logs --- Modified: src/modules/auth/api.c --- Diff: https://github.com/kamailio/kamailio/commit/2d79d1fc20ee1cd056b1b4b453c5576… Patch: https://github.com/kamailio/kamailio/commit/2d79d1fc20ee1cd056b1b4b453c5576…

1 0

git:master:08496ed4: core: cfg vars - updated log macros
by Daniel-Constantin Mierla 26 Aug '17

26 Aug '17

Module: kamailio Branch: master Commit: 08496ed43a4c99a082192a2d9d22eacfbb242a16 URL: https://github.com/kamailio/kamailio/commit/08496ed43a4c99a082192a2d9d22eac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-26T16:29:53+02:00 core: cfg vars - updated log macros --- Modified: src/core/cfg/cfg_ctx.c Modified: src/core/cfg/cfg_select.c --- Diff: https://github.com/kamailio/kamailio/commit/08496ed43a4c99a082192a2d9d22eac… Patch: https://github.com/kamailio/kamailio/commit/08496ed43a4c99a082192a2d9d22eac…

1 0

git:master:c2657fd4: core: cfg struct - updated log macros, coherent indentation
by Daniel-Constantin Mierla 25 Aug '17

25 Aug '17

Module: kamailio Branch: master Commit: c2657fd4a4e88e6f86ff9eef3b9fa2dd641c240c URL: https://github.com/kamailio/kamailio/commit/c2657fd4a4e88e6f86ff9eef3b9fa2d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-25T12:11:46+02:00 core: cfg struct - updated log macros, coherent indentation --- Modified: src/core/cfg/cfg_struct.c --- Diff: https://github.com/kamailio/kamailio/commit/c2657fd4a4e88e6f86ff9eef3b9fa2d… Patch: https://github.com/kamailio/kamailio/commit/c2657fd4a4e88e6f86ff9eef3b9fa2d…

1 0

git:5.0:ba6ec1a9: modules/lcr: fixed testing if dont_strip_or_prefix_flag is set
by Juha Heinanen 25 Aug '17

25 Aug '17

Module: kamailio Branch: 5.0 Commit: ba6ec1a9c651e43d4a0e89724ad5a7dfa6dafda7 URL: https://github.com/kamailio/kamailio/commit/ba6ec1a9c651e43d4a0e89724ad5a7d… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: 2017-08-25T10:32:26+03:00 modules/lcr: fixed testing if dont_strip_or_prefix_flag is set (cherry picked from commit b325a7711ac405e5598f7fbd224fb1b8e84221cf) --- Modified: src/modules/lcr/lcr_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/ba6ec1a9c651e43d4a0e89724ad5a7d… Patch: https://github.com/kamailio/kamailio/commit/ba6ec1a9c651e43d4a0e89724ad5a7d… --- diff --git a/src/modules/lcr/lcr_mod.c b/src/modules/lcr/lcr_mod.c index bb815f9b39..6fb0f1d26d 100644 --- a/src/modules/lcr/lcr_mod.c +++ b/src/modules/lcr/lcr_mod.c @@ -2149,7 +2149,7 @@ static int generate_uris(struct sip_msg* _m, char *r_uri, str *r_uri_user, } if ((dont_strip_or_prefix_flag_param != -1) && - isflagset(_m, dont_strip_or_prefix_flag_param)) { + (isflagset(_m, dont_strip_or_prefix_flag_param) == 1)) { strip = 0; prefix.len = 0; }

1 0

git:master:b325a771: modules/lcr: fixed testing if dont_strip_or_prefix_flag is set
by Juha Heinanen 25 Aug '17

25 Aug '17

Module: kamailio Branch: master Commit: b325a7711ac405e5598f7fbd224fb1b8e84221cf URL: https://github.com/kamailio/kamailio/commit/b325a7711ac405e5598f7fbd224fb1b… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: 2017-08-25T10:29:44+03:00 modules/lcr: fixed testing if dont_strip_or_prefix_flag is set --- Modified: src/modules/lcr/lcr_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b325a7711ac405e5598f7fbd224fb1b… Patch: https://github.com/kamailio/kamailio/commit/b325a7711ac405e5598f7fbd224fb1b… --- diff --git a/src/modules/lcr/lcr_mod.c b/src/modules/lcr/lcr_mod.c index 02bad0bb5e..5b4c99d865 100644 --- a/src/modules/lcr/lcr_mod.c +++ b/src/modules/lcr/lcr_mod.c @@ -2376,7 +2376,7 @@ static int generate_uris(struct sip_msg* _m, char *r_uri, str *r_uri_user, } if ((dont_strip_or_prefix_flag_param != -1) && - isflagset(_m, dont_strip_or_prefix_flag_param)) { + (isflagset(_m, dont_strip_or_prefix_flag_param) == 1)) { strip = 0; prefix.len = 0; }

1 0

[kamailio/kamailio] http_async_client: segfault at 0 (#1219)
by Eugen Biegler 24 Aug '17

24 Aug '17

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data ``` gdb kamailio core.kamailio.114.1503484559.29804 GNU gdb (Debian 7.7.1+dfsg-5) 7.7.1 Copyright (C) 2014 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from kamailio...(no debugging symbols found)...done. [New LWP 29804] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/sbin/kamailio -P /var/run/kamailio/kamailio.pid -f /etc/kamailio/kamailio.'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007f4b0a1c23e9 in notification_socket_cb () from /usr/lib/x86_64-linux-gnu/kamailio/modules/http_async_client.so (gdb) bt full #0 0x00007f4b0a1c23e9 in notification_socket_cb () from /usr/lib/x86_64-linux-gnu/kamailio/modules/http_async_client.so No symbol table info available. #1 0x00007f4b09cf23dc in event_base_loop () from /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5 No symbol table info available. #2 0x00007f4b0a1bec74 in async_http_run_worker () from /usr/lib/x86_64-linux-gnu/kamailio/modules/http_async_client.so No symbol table info available. #3 0x00007f4b0a1a886e in ?? () from /usr/lib/x86_64-linux-gnu/kamailio/modules/http_async_client.so No symbol table info available. #4 0x000000000053e25a in ?? () No symbol table info available. #5 0x000000000053df78 in ?? () No symbol table info available. #6 0x000000000053e588 in init_child () No symbol table info available. #7 0x0000000000423913 in main_loop () No symbol table info available. #8 0x000000000042a308 in main () No symbol table info available. (gdb) ``` #### Log Messages ``` kernel:[698859.513811] kamailio[29804]: segfault at 0 ip 00007f4b0a1c23e9 sp 00007ffeb48bdc00 error 4 in http_async_client.so[7f4b0a19e000+38000] /usr/sbin/kamailio[29777]: ALERT: <core> [main.c:743]: handle_sigs(): child process 29804 exited by a signal 11 /usr/sbin/kamailio[29777]: ALERT: <core> [main.c:746]: handle_sigs(): core was generated systemd[1]: kamailio.service: main process exited, code=exited, status=1/FAILURE systemd[1]: Unit kamailio.service entered failed state. ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio 5.0.2 (x86_64/linux) ``` * **Operating System**: ``` Linux 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u2 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1219

2 4

git:master:38f10f86: core: forward - coherent whitespacing and log macro update
by Daniel-Constantin Mierla 24 Aug '17

24 Aug '17

Module: kamailio Branch: master Commit: 38f10f867d8f234d7193eb47b9e176e50d5b021e URL: https://github.com/kamailio/kamailio/commit/38f10f867d8f234d7193eb47b9e176e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-24T12:20:29+02:00 core: forward - coherent whitespacing and log macro update --- Modified: src/core/forward.c --- Diff: https://github.com/kamailio/kamailio/commit/38f10f867d8f234d7193eb47b9e176e… Patch: https://github.com/kamailio/kamailio/commit/38f10f867d8f234d7193eb47b9e176e…

1 0

git:master:ec6850c1: core: cfg group vars - updated log macros
by Daniel-Constantin Mierla 23 Aug '17

23 Aug '17

Module: kamailio Branch: master Commit: ec6850c167a196c3f28d218b3ad1c31f7926b4fa URL: https://github.com/kamailio/kamailio/commit/ec6850c167a196c3f28d218b3ad1c31… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-23T11:18:54+02:00 core: cfg group vars - updated log macros --- Modified: src/core/cfg/cfg.c Modified: src/core/cfg/cfg_script.c --- Diff: https://github.com/kamailio/kamailio/commit/ec6850c167a196c3f28d218b3ad1c31… Patch: https://github.com/kamailio/kamailio/commit/ec6850c167a196c3f28d218b3ad1c31…

1 0

rtpproxy: One direction rtp not being relayed
by Jon Bonilla (Manwe) 22 Aug '17

22 Aug '17

Hi all After a migration, a customer is reporting one way audio on incoming calls. A tcpdump capture shows 65 rtp packets in both directions but rtpproxy log shows RTP stats: 1 in from callee, 64 in from caller, 65 relayed, 0 dropped Any thoughts? cheers, Jon

1 1

git:master:6a69220e: modules: readme files regenerated - statsc ... [skip ci]
by Kamailio Dev 22 Aug '17

22 Aug '17

Module: kamailio Branch: master Commit: 6a69220ec8f46528d1c02295452e59462d02d0f5 URL: https://github.com/kamailio/kamailio/commit/6a69220ec8f46528d1c02295452e594… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-22T12:31:44+02:00 modules: readme files regenerated - statsc ... [skip ci] --- Modified: src/modules/statsc/README Modified: src/modules/statsd/README Modified: src/modules/usrloc/README --- Diff: https://github.com/kamailio/kamailio/commit/6a69220ec8f46528d1c02295452e594… Patch: https://github.com/kamailio/kamailio/commit/6a69220ec8f46528d1c02295452e594… --- diff --git a/src/modules/statsc/README b/src/modules/statsc/README index a546b56db5..a753399731 100644 --- a/src/modules/statsc/README +++ b/src/modules/statsc/README @@ -31,7 +31,7 @@ Daniel-Constantin Mierla 4. RPC Commands - 4.1. statsc.exec + 4.1. statsc.report List of Examples @@ -57,7 +57,7 @@ Chapter 1. Admin Guide 4. RPC Commands - 4.1. statsc.exec + 4.1. statsc.report 1. Overview @@ -135,9 +135,9 @@ modparam("statsc", "track", "req.received=rcv_requests;rpl.received=rcv_replies" 4. RPC Commands - 4.1. statsc.exec + 4.1. statsc.report -4.1. statsc.exec +4.1. statsc.report Get the report of recorded statistics. diff --git a/src/modules/statsd/README b/src/modules/statsd/README index 58b3fd8ae1..5a414b7744 100644 --- a/src/modules/statsd/README +++ b/src/modules/statsd/README @@ -129,11 +129,10 @@ failure_route[tryagain] { 3.2. statsd_gauge(key, value) Gauges are a constant data type. They are not subject to averaging and - they donât change unless you change them. That is, once you set a - gauge value, it will be a flat line on the graph until you change it - again. + they don't change unless you change them. That is, once you set a gauge + value, it will be a flat line on the graph until you change it again. - Gauges are useful for things that are already averaged, or donât need + Gauges are useful for things that are already averaged, or don't need to reset periodically This function can be used in ALL ROUTES. @@ -141,10 +140,12 @@ failure_route[tryagain] { The statsd server collects gauges under the stats.gauges prefix. Example 1.4. statsd_set usage +... route [gauge_method]{ statsd_gauge("method"+$rm, "+1"); statsd_gauge("customer_credit"+$var(customer),"$var(customer_credit)"); } +... 3.3. statsd_start(key) @@ -158,7 +159,7 @@ route [gauge_method]{ The statsd server collects all timers under the stats.timers prefix and will calculate the lower bound, mean, 90th percentile, upper bound, and count of each timer for each period (by the time it can be seen in - graphite, thatâs usually per minute). + graphite, that's usually per minute). Example 1.5. statsd_start usage ... @@ -205,6 +206,6 @@ if(geoip_match("$si", "src")){ ... if (t_check_status("408")) { statsd_decr("kamailio.successfulCalls"); - statsd_incr("kamailio.reply.busy"); + statsd_incr("kamailio.reply.timeout"); } ... diff --git a/src/modules/usrloc/README b/src/modules/usrloc/README index fbddff49a1..131baca9c5 100644 --- a/src/modules/usrloc/README +++ b/src/modules/usrloc/README @@ -895,7 +895,7 @@ modparam("usrloc", "close_expired_tcp", 1) If set to 1, Kamailio expects to deal with BIGINT type on database columns for expires and last modified values. It allows to handle - better the daylight time adjustmens. If set to 0, those columns are + better the daylight time adjustments. If set to 0, those columns are expected to be on default type 'DATETIME'. When it is 1, the database columns types have to be changed manually to 'BIGINT'.

1 0

git:master:febcf7cd: usrloc Fix README typo
by Olle E. Johansson 22 Aug '17

22 Aug '17

Module: kamailio Branch: master Commit: febcf7cdb29896fb7bc02585b4ac36a5fba5e3ae URL: https://github.com/kamailio/kamailio/commit/febcf7cdb29896fb7bc02585b4ac36a… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2017-08-22T12:30:12+02:00 usrloc Fix README typo --- Modified: src/modules/usrloc/doc/usrloc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/febcf7cdb29896fb7bc02585b4ac36a… Patch: https://github.com/kamailio/kamailio/commit/febcf7cdb29896fb7bc02585b4ac36a… --- diff --git a/src/modules/usrloc/doc/usrloc_admin.xml b/src/modules/usrloc/doc/usrloc_admin.xml index 2ad2935a8d..1dd4ae378a 100644 --- a/src/modules/usrloc/doc/usrloc_admin.xml +++ b/src/modules/usrloc/doc/usrloc_admin.xml @@ -1040,7 +1040,7 @@ modparam("usrloc", "close_expired_tcp", 1) <para> If set to 1, &kamailio; expects to deal with BIGINT type on database columns for expires and last modified values. It - allows to handle better the daylight time adjustmens. If set + allows to handle better the daylight time adjustments. If set to 0, those columns are expected to be on default type 'DATETIME'. When it is 1, the database columns types have to be changed manually to 'BIGINT'.

1 0

git:master:4c7fbb1d: statsd Fix strange formatting for apostrophes in the html files by actually using an apostrophe
by Olle E. Johansson 22 Aug '17

22 Aug '17

Module: kamailio Branch: master Commit: 4c7fbb1d6c33ffa6b1630e2b15bcc60934e4dcb3 URL: https://github.com/kamailio/kamailio/commit/4c7fbb1d6c33ffa6b1630e2b15bcc60… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2017-08-22T12:22:58+02:00 statsd Fix strange formatting for apostrophes in the html files by actually using an apostrophe --- Modified: src/modules/statsd/doc/statsd_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/4c7fbb1d6c33ffa6b1630e2b15bcc60… Patch: https://github.com/kamailio/kamailio/commit/4c7fbb1d6c33ffa6b1630e2b15bcc60… --- diff --git a/src/modules/statsd/doc/statsd_admin.xml b/src/modules/statsd/doc/statsd_admin.xml index cd9e830a87..ccf6296fcd 100644 --- a/src/modules/statsd/doc/statsd_admin.xml +++ b/src/modules/statsd/doc/statsd_admin.xml @@ -101,11 +101,11 @@ failure_route[tryagain] { </title> <para> Gauges are a constant data type. They are not subject to averaging - and they don’t change unless you change them. That is, once you set + and they don't change unless you change them. That is, once you set a gauge value, it will be a flat line on the graph until you change it again. </para> <para> - Gauges are useful for things that are already averaged, or don’t need to reset periodically + Gauges are useful for things that are already averaged, or don't need to reset periodically </para> <para> This function can be used in ALL ROUTES. @@ -116,10 +116,12 @@ failure_route[tryagain] { <example> <title><function>statsd_set</function> usage</title> <programlisting format="linespecific"> +... route [gauge_method]{ statsd_gauge("method"+$rm, "+1"); statsd_gauge("customer_credit"+$var(customer),"$var(customer_credit)"); } +... </programlisting> </example> </section> @@ -139,7 +141,7 @@ route [gauge_method]{ <para> The statsd server collects all timers under the stats.timers prefix and will calculate the lower bound, mean, 90th percentile, upper bound, and count of each - timer for each period (by the time it can be seen in graphite, that’s usually per minute). + timer for each period (by the time it can be seen in graphite, that's usually per minute). </para> <example> <title><function>statsd_start</function> usage</title> @@ -215,7 +217,7 @@ if(geoip_match("$si", "src")){ ... if (t_check_status("408")) { statsd_decr("kamailio.successfulCalls"); - statsd_incr("kamailio.reply.busy"); + statsd_incr("kamailio.reply.timeout"); } ... </programlisting>

1 0

git:master:f2f6e7ec: statsc Fix typo in RPC command naming
by Olle E. Johansson 22 Aug '17

22 Aug '17

Module: kamailio Branch: master Commit: f2f6e7ec171fab9dcf8ad7d6c6b25438a54b32af URL: https://github.com/kamailio/kamailio/commit/f2f6e7ec171fab9dcf8ad7d6c6b2543… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2017-08-22T12:19:54+02:00 statsc Fix typo in RPC command naming --- Modified: src/modules/statsc/doc/statsc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/f2f6e7ec171fab9dcf8ad7d6c6b2543… Patch: https://github.com/kamailio/kamailio/commit/f2f6e7ec171fab9dcf8ad7d6c6b2543… --- diff --git a/src/modules/statsc/doc/statsc_admin.xml b/src/modules/statsc/doc/statsc_admin.xml index 4f6c15ace3..1ba4ec8202 100644 --- a/src/modules/statsc/doc/statsc_admin.xml +++ b/src/modules/statsc/doc/statsc_admin.xml @@ -149,9 +149,9 @@ modparam("statsc", "track", "req.received=rcv_requests;rpl.received=rcv_replies" <section> <title>RPC Commands</title> - <section id="statsc.rpc.exec"> + <section id="statsc.rpc.report"> <title> - <function moreinfo="none">statsc.exec</function> + <function moreinfo="none">statsc.report</function> </title> <para> Get the report of recorded statistics.

1 0

git:master:a91b2b68: modules: readme files regenerated - avp ... [skip ci]
by Kamailio Dev 21 Aug '17

21 Aug '17

Module: kamailio Branch: master Commit: a91b2b68c667afb39854ac94fbcfa9cbe6dc49cb URL: https://github.com/kamailio/kamailio/commit/a91b2b68c667afb39854ac94fbcfa9c… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-21T17:01:27+02:00 modules: readme files regenerated - avp ... [skip ci] --- Modified: src/modules/avp/README Modified: src/modules/nathelper/README Modified: src/modules/registrar/README Modified: src/modules/sipcapture/README Modified: src/modules/siputils/README Modified: src/modules/topoh/README --- Diff: https://github.com/kamailio/kamailio/commit/a91b2b68c667afb39854ac94fbcfa9c… Patch: https://github.com/kamailio/kamailio/commit/a91b2b68c667afb39854ac94fbcfa9c…

1 0

git:master:4e219eba: topoh: fix documentation typo
by Mikko Lehto 21 Aug '17

21 Aug '17

Module: kamailio Branch: master Commit: 4e219ebae59be64009dc59a28cb158ae4a51db50 URL: https://github.com/kamailio/kamailio/commit/4e219ebae59be64009dc59a28cb158a… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-08-21T17:49:38+03:00 topoh: fix documentation typo --- Modified: src/modules/topoh/doc/topoh_admin.xml Modified: src/modules/topoh/topoh_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/4e219ebae59be64009dc59a28cb158a… Patch: https://github.com/kamailio/kamailio/commit/4e219ebae59be64009dc59a28cb158a… --- diff --git a/src/modules/topoh/doc/topoh_admin.xml b/src/modules/topoh/doc/topoh_admin.xml index f421f8ce64..1732b77724 100644 --- a/src/modules/topoh/doc/topoh_admin.xml +++ b/src/modules/topoh/doc/topoh_admin.xml @@ -17,7 +17,7 @@ <title>Overview</title> <para> This module hides the SIP routing headers that show topology details. - It it is not affected by the server being transaction stateless or + It is not affected by the server being transaction stateless or stateful. The script interpreter gets the SIP messages decoded, so all existing functionality is preserved. </para> diff --git a/src/modules/topoh/topoh_mod.c b/src/modules/topoh/topoh_mod.c index 164087592a..4d41e229b6 100644 --- a/src/modules/topoh/topoh_mod.c +++ b/src/modules/topoh/topoh_mod.c @@ -26,7 +26,7 @@ /*! \defgroup topoh Kamailio :: Topology hiding * * This module hides the SIP routing headers that show topology details. - * It it is not affected by the server being transaction stateless or + * It is not affected by the server being transaction stateless or * stateful. The script interpreter gets the SIP messages decoded, so all * existing functionality is preserved. */

1 0

git:master:e6b6d26d: core, modules: fix common documentation typo
by Mikko Lehto 21 Aug '17

21 Aug '17

Module: kamailio Branch: master Commit: e6b6d26d831b937832969459692b3b06a776a033 URL: https://github.com/kamailio/kamailio/commit/e6b6d26d831b937832969459692b3b0… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-08-21T17:49:38+03:00 core, modules: fix common documentation typo --- Modified: src/core/select.c Modified: src/core/select.h Modified: src/modules/avp/doc/avp_functions.xml Modified: src/modules/seas/seas.c --- Diff: https://github.com/kamailio/kamailio/commit/e6b6d26d831b937832969459692b3b0… Patch: https://github.com/kamailio/kamailio/commit/e6b6d26d831b937832969459692b3b0…

1 0

git:master:c2e74aa2: nathelper: fix documentation typo
by Mikko Lehto 21 Aug '17

21 Aug '17

Module: kamailio Branch: master Commit: c2e74aa28ce20ec9f9eb19197aa829e9c9672a1d URL: https://github.com/kamailio/kamailio/commit/c2e74aa28ce20ec9f9eb19197aa829e… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-08-21T17:49:38+03:00 nathelper: fix documentation typo --- Modified: src/modules/nathelper/doc/nathelper_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c2e74aa28ce20ec9f9eb19197aa829e… Patch: https://github.com/kamailio/kamailio/commit/c2e74aa28ce20ec9f9eb19197aa829e… --- diff --git a/src/modules/nathelper/doc/nathelper_admin.xml b/src/modules/nathelper/doc/nathelper_admin.xml index d08f80c3a5..9c3373a9ec 100644 --- a/src/modules/nathelper/doc/nathelper_admin.xml +++ b/src/modules/nathelper/doc/nathelper_admin.xml @@ -592,7 +592,7 @@ add_rcv_param("1"); # add the parameter to the Contact URI The function creates a URI consisting of the source IP, port, and protocol and stores the URI in an Attribute-Value-Pair. The URI will be appended as "received" parameter to Contact in 200 OK and - registrar will store it in the received cloumn in the location table. + registrar will store it in the received column in the location table. </para> <para> Note: You have to set the <quote>received_avp</quote> parameter of the

1 0

git:master:ff6e3f4d: siputils: fix example typo
by Mikko Lehto 21 Aug '17

21 Aug '17

Module: kamailio Branch: master Commit: ff6e3f4d5a48f2673d4ec33b9a293ddc43c34781 URL: https://github.com/kamailio/kamailio/commit/ff6e3f4d5a48f2673d4ec33b9a293dd… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-08-21T17:49:38+03:00 siputils: fix example typo --- Modified: src/modules/siputils/doc/siputils_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ff6e3f4d5a48f2673d4ec33b9a293dd… Patch: https://github.com/kamailio/kamailio/commit/ff6e3f4d5a48f2673d4ec33b9a293dd… --- diff --git a/src/modules/siputils/doc/siputils_admin.xml b/src/modules/siputils/doc/siputils_admin.xml index 2031ad29e9..4b37d8109e 100644 --- a/src/modules/siputils/doc/siputils_admin.xml +++ b/src/modules/siputils/doc/siputils_admin.xml @@ -569,7 +569,7 @@ tel2sip("$ru", $fd", "$ru"); <title><function>is_e164</function> usage</title> <programlisting format="linespecific"> ... -if (is_164("$fU")) { # Check From header URI user part +if (is_e164("$fU")) { # Check From header URI user part ... } if (is_e164("$avp(i:705)") {

1 0

git:master:6452e86b: sipcapture: documentation typo
by Mikko Lehto 21 Aug '17

21 Aug '17

Module: kamailio Branch: master Commit: 6452e86bcc3e4b927a2e511f3c7a9f464a69ac66 URL: https://github.com/kamailio/kamailio/commit/6452e86bcc3e4b927a2e511f3c7a9f4… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-08-21T17:49:38+03:00 sipcapture: documentation typo --- Modified: src/modules/sipcapture/doc/sipcapture_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/6452e86bcc3e4b927a2e511f3c7a9f4… Patch: https://github.com/kamailio/kamailio/commit/6452e86bcc3e4b927a2e511f3c7a9f4… --- diff --git a/src/modules/sipcapture/doc/sipcapture_admin.xml b/src/modules/sipcapture/doc/sipcapture_admin.xml index d9d47cceda..c5590b3c1c 100644 --- a/src/modules/sipcapture/doc/sipcapture_admin.xml +++ b/src/modules/sipcapture/doc/sipcapture_admin.xml @@ -185,7 +185,7 @@ modparam("sipcapture", "db_insert_mode", 1) <section id="sipcapture.p.capture_on"> <title><varname>capture_on</varname> (integer)</title> <para> - Parameter to enable/disable capture globaly (on(1)/off(0)) + Parameter to enable/disable capture globally (on(1)/off(0)) </para> <para> <emphasis>

1 0

git:master:40d7308f: registrar: fix statistic documentation typo
by Mikko Lehto 21 Aug '17

21 Aug '17

Module: kamailio Branch: master Commit: 40d7308fb6d194a6c5c40c3a6b338cba9c87b253 URL: https://github.com/kamailio/kamailio/commit/40d7308fb6d194a6c5c40c3a6b338cb… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-08-21T17:49:38+03:00 registrar: fix statistic documentation typo --- Modified: src/modules/registrar/doc/registrar_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/40d7308fb6d194a6c5c40c3a6b338cb… Patch: https://github.com/kamailio/kamailio/commit/40d7308fb6d194a6c5c40c3a6b338cb… --- diff --git a/src/modules/registrar/doc/registrar_admin.xml b/src/modules/registrar/doc/registrar_admin.xml index 98a21dccea..58ea0346d1 100644 --- a/src/modules/registrar/doc/registrar_admin.xml +++ b/src/modules/registrar/doc/registrar_admin.xml @@ -1477,7 +1477,7 @@ event_route[usrloc:contact-expired] { </para> </section> <section> - <title><varname>defaults_expires</varname></title> + <title><varname>default_expires</varname></title> <para> The value of default_expires parameter. </para>

1 0

git:master:496f538e: modules: readme files regenerated - siptrace ... [skip ci]
by Kamailio Dev 21 Aug '17

21 Aug '17

Module: kamailio Branch: master Commit: 496f538e2ce8be9ed852a7bf8b1fe118b8971998 URL: https://github.com/kamailio/kamailio/commit/496f538e2ce8be9ed852a7bf8b1fe11… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-21T16:46:27+02:00 modules: readme files regenerated - siptrace ... [skip ci] --- Modified: src/modules/siptrace/README --- Diff: https://github.com/kamailio/kamailio/commit/496f538e2ce8be9ed852a7bf8b1fe11… Patch: https://github.com/kamailio/kamailio/commit/496f538e2ce8be9ed852a7bf8b1fe11… --- diff --git a/src/modules/siptrace/README b/src/modules/siptrace/README index edc71eb73c..383250d6f7 100644 --- a/src/modules/siptrace/README +++ b/src/modules/siptrace/README @@ -151,7 +151,7 @@ Chapter 1. Admin Guide SIP messages in a database and/or duplicate to the capturing server (using HEP, the Homer encapsulation protocol, or plain SIP mode) - There are two ways of storing information: + There are multiple ways of storing information: * by calling the sip_trace() method explicitely in the Kamailio configuration file. In this case the original message is processed. * by setting the flag equal with the value of “trace_flag” (e.g., @@ -159,6 +159,7 @@ Chapter 1. Admin Guide message sent forward is processed. The logging mechanism is based on TM/SL callbacks, so only messages processed with the TM module or sent statelessly are logged. + * by setting “trace_mode” to mirror all traffic. The tracing can be turned on/off using Kamailio RPC commands.

1 0

git:master:309895b0: siptrace: mention trace_mode in overview
by Mikko Lehto 21 Aug '17

21 Aug '17

Module: kamailio Branch: master Commit: 309895b0a3494f3ac476646779dfd0605e0857f1 URL: https://github.com/kamailio/kamailio/commit/309895b0a3494f3ac476646779dfd06… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-08-21T17:21:16+03:00 siptrace: mention trace_mode in overview - text by Daniel Tryba --- Modified: src/modules/siptrace/doc/siptrace_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/309895b0a3494f3ac476646779dfd06… Patch: https://github.com/kamailio/kamailio/commit/309895b0a3494f3ac476646779dfd06… --- diff --git a/src/modules/siptrace/doc/siptrace_admin.xml b/src/modules/siptrace/doc/siptrace_admin.xml index bceb75200c..32cdc924aa 100644 --- a/src/modules/siptrace/doc/siptrace_admin.xml +++ b/src/modules/siptrace/doc/siptrace_admin.xml @@ -21,7 +21,7 @@ the Homer encapsulation protocol, or plain SIP mode) </para> <para> - There are two ways of storing information: + There are multiple ways of storing information: <itemizedlist> <listitem> <para> @@ -38,6 +38,11 @@ are logged. </para> </listitem> + <listitem> + <para> + by setting <quote>trace_mode</quote> to mirror all traffic. + </para> + </listitem> </itemizedlist> </para>

1 0

git:master:e129b809: http_client Free the old object when the new can't be allocated properly
by Olle E. Johansson 21 Aug '17

21 Aug '17

Module: kamailio Branch: master Commit: e129b809e258d94ea39d66c847db3a19eae2b708 URL: https://github.com/kamailio/kamailio/commit/e129b809e258d94ea39d66c847db3a1… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2017-08-21T12:19:30+02:00 http_client Free the old object when the new can't be allocated properly --- Modified: src/modules/http_client/curlcon.c --- Diff: https://github.com/kamailio/kamailio/commit/e129b809e258d94ea39d66c847db3a1… Patch: https://github.com/kamailio/kamailio/commit/e129b809e258d94ea39d66c847db3a1… --- diff --git a/src/modules/http_client/curlcon.c b/src/modules/http_client/curlcon.c index 9a87865837..4789c73f30 100644 --- a/src/modules/http_client/curlcon.c +++ b/src/modules/http_client/curlcon.c @@ -172,7 +172,7 @@ curl_con_pkg_t* curl_get_pkg_connection(curl_con_t *con) } ccp = ccp->next; } - LM_DBG("curl_get_pkg_connection no success in looking for pkg memory for httpcon: [%.*s]\n", con->name.len, con->name.s); + LM_ERR("curl_get_pkg_connection no success in looking for pkg memory for httpcon: [%.*s]\n", con->name.len, con->name.s); return NULL; } @@ -751,8 +751,9 @@ curl_con_t *curl_init_con(str *name) ccp = (curl_con_pkg_t*) pkg_malloc(sizeof(curl_con_pkg_t)); if(ccp == NULL) { - shm_free(ccp); - LM_ERR("no shm memory\n"); + /* We failed to allocate ccp, so let's free cc and quit */ + shm_free(cc); + LM_ERR("no pkg memory available\n"); return NULL; }

1 0

git:master:4447dc86: core: parser contact - removed history, updated log macros
by Daniel-Constantin Mierla 21 Aug '17

21 Aug '17

Module: kamailio Branch: master Commit: 4447dc8619f7136bca127efadaad4bce6f8e0e91 URL: https://github.com/kamailio/kamailio/commit/4447dc8619f7136bca127efadaad4bc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-21T07:43:44+02:00 core: parser contact - removed history, updated log macros - coherent indentation --- Modified: src/core/parser/contact/contact.c Modified: src/core/parser/contact/parse_contact.c --- Diff: https://github.com/kamailio/kamailio/commit/4447dc8619f7136bca127efadaad4bc… Patch: https://github.com/kamailio/kamailio/commit/4447dc8619f7136bca127efadaad4bc…

1 0

git:master:12c57dbe: modules: readme files regenerated - kex ... [skip ci]
by Kamailio Dev 20 Aug '17

20 Aug '17

Module: kamailio Branch: master Commit: 12c57dbee20d809ee6b43fc56fdb37e38bd60916 URL: https://github.com/kamailio/kamailio/commit/12c57dbee20d809ee6b43fc56fdb37e… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-20T08:01:29+02:00 modules: readme files regenerated - kex ... [skip ci] --- Modified: src/modules/kex/README --- Diff: https://github.com/kamailio/kamailio/commit/12c57dbee20d809ee6b43fc56fdb37e… Patch: https://github.com/kamailio/kamailio/commit/12c57dbee20d809ee6b43fc56fdb37e…

1 0

git:master:804f9e85: kex: documentation for core.modules rpc command
by Daniel-Constantin Mierla 20 Aug '17

20 Aug '17

Module: kamailio Branch: master Commit: 804f9e85ce84d45dcb6a7b4d5202b050b5289cc4 URL: https://github.com/kamailio/kamailio/commit/804f9e85ce84d45dcb6a7b4d5202b05… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-20T08:00:41+02:00 kex: documentation for core.modules rpc command --- Modified: src/modules/kex/doc/kex_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/804f9e85ce84d45dcb6a7b4d5202b05… Patch: https://github.com/kamailio/kamailio/commit/804f9e85ce84d45dcb6a7b4d5202b05… --- diff --git a/src/modules/kex/doc/kex_admin.xml b/src/modules/kex/doc/kex_admin.xml index 6c588a31b5..7eabc02160 100644 --- a/src/modules/kex/doc/kex_admin.xml +++ b/src/modules/kex/doc/kex_admin.xml @@ -668,6 +668,26 @@ resetdebug(); ... </programlisting> </section> + <section id="kex.r.core.modules"> + <title> + <function moreinfo="none">core.modules</function> + </title> + <para> + List loaded modules in config. + </para> + <para> + Name: <emphasis>core.modules</emphasis> + </para> + <para>Parameters: <emphasis>none</emphasis>.</para> + <para> + RPC Command Format: + </para> + <programlisting format="linespecific"> +... +&kamcmd; core.modules +... + </programlisting> + </section> <section id="kex.r.pkg.stats"> <title>

1 0

git:master:5ead6c08: core: digest parser - converted old log macros
by Daniel-Constantin Mierla 19 Aug '17

19 Aug '17

Module: kamailio Branch: master Commit: 5ead6c080d2a9c3e5e6adc56a717003bef37c9dd URL: https://github.com/kamailio/kamailio/commit/5ead6c080d2a9c3e5e6adc56a717003… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-19T07:05:03+02:00 core: digest parser - converted old log macros - coherent indentation --- Modified: src/core/parser/digest/digest.c --- Diff: https://github.com/kamailio/kamailio/commit/5ead6c080d2a9c3e5e6adc56a717003… Patch: https://github.com/kamailio/kamailio/commit/5ead6c080d2a9c3e5e6adc56a717003…

1 0

git:master:1121ee05: core: added rpc command core.modules
by Daniel-Constantin Mierla 18 Aug '17

18 Aug '17

Module: kamailio Branch: master Commit: 1121ee05e982625e31045416473b00be1caf481c URL: https://github.com/kamailio/kamailio/commit/1121ee05e982625e31045416473b00b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-18T07:24:20+02:00 core: added rpc command core.modules - list the names of loaded modules --- Modified: src/core/core_cmd.c Modified: src/core/sr_module.c Modified: src/core/sr_module.h --- Diff: https://github.com/kamailio/kamailio/commit/1121ee05e982625e31045416473b00b… Patch: https://github.com/kamailio/kamailio/commit/1121ee05e982625e31045416473b00b… --- diff --git a/src/core/core_cmd.c b/src/core/core_cmd.c index ed8d71749e..a489a8975d 100644 --- a/src/core/core_cmd.c +++ b/src/core/core_cmd.c @@ -959,6 +959,26 @@ static void core_sockets_list(rpc_t* rpc, void* c) /** * */ +static const char* core_modules_doc[] = { + "List loaded modules", /* Documentation string */ + 0 /* Method signature(s) */ +}; + +/** + * list listen sockets for SIP server + */ +static void core_modules(rpc_t* rpc, void* c) +{ + sr_module_t* t; + + for(t = get_loaded_modules(); t; t = t->next) { + if (rpc->add(c, "s", t->exports.name) < 0) return; + } +} + +/** + * + */ static const char* core_ppdefines_doc[] = { "List preprocessor defines", /* Documentation string */ 0 /* Method signature(s) */ @@ -1014,7 +1034,8 @@ static rpc_export_t core_rpc_methods[] = { 0}, {"core.aliases_list", core_aliases_list, core_aliases_list_doc, 0}, {"core.sockets_list", core_sockets_list, core_sockets_list_doc, 0}, - {"core.ppdefines", core_ppdefines, core_ppdefines_doc, RET_ARRAY}, + {"core.modules", core_modules, core_modules_doc, RET_ARRAY}, + {"core.ppdefines", core_ppdefines, core_ppdefines_doc, RET_ARRAY}, #ifdef USE_DNS_CACHE {"dns.mem_info", dns_cache_mem_info, dns_cache_mem_info_doc, 0 }, diff --git a/src/core/sr_module.c b/src/core/sr_module.c index fe545378eb..489ae55593 100644 --- a/src/core/sr_module.c +++ b/src/core/sr_module.c @@ -781,6 +781,9 @@ struct sr_module* find_module_by_name(char* mod) { return 0; } +sr_module_t* get_loaded_modules(void) { + return modules; +} /*! * \brief Find a parameter with given type diff --git a/src/core/sr_module.h b/src/core/sr_module.h index e2bef74950..4dd6523f3b 100644 --- a/src/core/sr_module.h +++ b/src/core/sr_module.h @@ -435,13 +435,13 @@ union module_exports_u { }; -struct sr_module { +typedef struct sr_module { char* path; void* handle; unsigned int orig_mod_interface_ver; struct sr31_module_exports exports; struct sr_module* next; -}; +} sr_module_t; extern struct sr_module* modules; /**< global module list*/ @@ -459,6 +459,7 @@ void destroy_modules(void); int init_child(int rank); int init_modules(void); struct sr_module* find_module_by_name(char* mod); +sr_module_t* get_loaded_modules(void); /**< true if the module with name 'mod_name' is loaded */ #define module_loaded(mod_name) (find_module_by_name(mod_name)!=0)

1 0

append_branch and tls
by James Cloos 17 Aug '17

17 Aug '17

When using rewrite_ruri() and append_branch() to set a list of next hops to try, what is the proper syntax to specify that a given route should use tcp or tls/tcp? I've mostly used a single next hop via t_relay_to_tcp() or t_relay_to_tls(), but need route stacks now. -JimC -- James Cloos <cloos(a)jhcloos.com> OpenPGP: 0x997A9F17ED7DAEA6

1 0

Converting to kemi
by James Cloos 17 Aug '17

17 Aug '17

I'm working on converting some configs to kemi lua and have a couple of questions: First: Does KSR.pv.get() support multiple pseudos in a single call? The examples such as misc/examples/kemi/kamailio-basic-kemi-lua.lua make several calls, but also do things like KSR.pv.get("$T_branch_idx]") to avoid having the append "]" to the string. That makes me wonder why that file has code like this: KSR.dbg("new branch [".. KSR.pv.get("$T_branch_idx]") .. " to ".. KSR.pv.get("$ru") .. "\n"); instead of like: KSR.pv.get("[$T_branch_idx] to $ru\n") Second: Is it still the case that, eg, event_route[xhttp:request] cannot be in the kemi lua code? There was another. Perhaps I'll recall what it was... :( -JimC -- James Cloos <cloos(a)jhcloos.com> OpenPGP: 0x997A9F17ED7DAEA6

1 0

[kamailio/kamailio] pv: add string corehash transform (#1218)
by lazedo 17 Aug '17

17 Aug '17

#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  adds string transform with optional size parameter to return the slot if supplied `usage` - $(var(myvar){s.corehash}) `returns the hash` - $(var(myvar){s.corehash, 32}) `returns the slot` `would be great if this can be backported to branch 5.0 and included in next week release` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1218 -- Commit Summary -- * pv: add string corehash transform -- File Changes -- M src/modules/pv/pv_trans.c (48) M src/modules/pv/pv_trans.h (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1218.patch https://github.com/kamailio/kamailio/pull/1218.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1218

2 4

[kamailio/kamailio] make get_hdr_by_name/next_sibling_hdr_by_name case insensitive (#1217)
by nevian427 17 Aug '17

17 Aug '17

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description core: make get_hdr_by_name/next_sibling_hdr_by_name case insensitive - Credits goes to Alexandr Dubovikov You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1217 -- Commit Summary -- * caseinsensitive get_hdr_by_name/next_sibling_hdr_by_name -- File Changes -- M src/core/parser/msg_parser.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1217.patch https://github.com/kamailio/kamailio/pull/1217.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1217

2 9

git:master:4072b0f9: core: parser - use case insensitive comparison to get header by name
by Daniel-Constantin Mierla 17 Aug '17

17 Aug '17

Module: kamailio Branch: master Commit: 4072b0f9fbc084a4f4640e1b4272b7f8495cd1bb URL: https://github.com/kamailio/kamailio/commit/4072b0f9fbc084a4f4640e1b4272b7f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-17T13:42:59+02:00 core: parser - use case insensitive comparison to get header by name - same for next sibling header - GH #1217 --- Modified: src/core/parser/msg_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/4072b0f9fbc084a4f4640e1b4272b7f… Patch: https://github.com/kamailio/kamailio/commit/4072b0f9fbc084a4f4640e1b4272b7f… --- diff --git a/src/core/parser/msg_parser.c b/src/core/parser/msg_parser.c index be137652de..efad8f9f63 100644 --- a/src/core/parser/msg_parser.c +++ b/src/core/parser/msg_parser.c @@ -962,7 +962,7 @@ hdr_field_t* get_hdr_by_name(const sip_msg_t* const msg, const char* const name, for(hdr = msg->headers; hdr; hdr = hdr->next) { if(hdr->name.len == name_len && *hdr->name.s==*name - && strncmp(hdr->name.s, name, name_len)==0) + && strncasecmp(hdr->name.s, name, name_len)==0) return hdr; } return NULL; @@ -975,7 +975,7 @@ hdr_field_t* next_sibling_hdr_by_name(const hdr_field_t* const hf) for(hdr = hf->next; hdr; hdr = hdr->next) { if(hdr->name.len == hf->name.len && *hdr->name.s==*hf->name.s - && strncmp(hdr->name.s, hf->name.s, hf->name.len)==0) + && strncasecmp(hdr->name.s, hf->name.s, hf->name.len)==0) return hdr; } return NULL;

1 0

git:master:bf97c8ac: pv: small adjustments for {s.corehash} transformation
by Daniel-Constantin Mierla 17 Aug '17

17 Aug '17

Module: kamailio Branch: master Commit: bf97c8acd67c0151c70da812402d3eef79388f83 URL: https://github.com/kamailio/kamailio/commit/bf97c8acd67c0151c70da812402d3ee… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-17T13:23:08+02:00 pv: small adjustments for {s.corehash} transformation - use standard uint32_t type and internal function to convert to str --- Modified: src/modules/pv/pv_trans.c --- Diff: https://github.com/kamailio/kamailio/commit/bf97c8acd67c0151c70da812402d3ee… Patch: https://github.com/kamailio/kamailio/commit/bf97c8acd67c0151c70da812402d3ee… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index 603219bf4e..dd7d9a7f62 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -266,7 +266,7 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, str st, st2; pv_value_t v, w; time_t t; - uint sz1, sz2; + uint32_t sz1, sz2; if(val==NULL || val->flags&PV_VAL_NULL) return -1; @@ -1125,7 +1125,9 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, case TR_S_COREHASH: if(!(val->flags&PV_VAL_STR)) - val->rs.s = int2str(val->ri, &val->rs.len); + st.s = int2str(val->ri, &st.len); + else + st = val->rs; sz1 = 0; if(tp != NULL) { @@ -1143,13 +1145,15 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, } } - sz2 = core_hash(&val->rs, NULL, sz1); + sz2 = core_hash(&st, NULL, sz1); - j = sprintf(_tr_buffer, "%u", sz2); + if((val->rs.s = int2strbuf((unsigned long)sz2, _tr_buffer, + INT2STR_MAX_LEN, &val->rs.len))==NULL) { + LM_ERR("failed to convert core hash id to string\n"); + return -1; + } val->flags = PV_VAL_STR; val->ri = 0; - val->rs.s = _tr_buffer; - val->rs.len = j; break; default:

1 0

git:master:38c85975: Merge pull request #1218 from kamailio/corehash_trans
by GitHub 17 Aug '17

17 Aug '17

Module: kamailio Branch: master Commit: 38c85975e3b4a9f1dc548f7bda1f54726fba3d44 URL: https://github.com/kamailio/kamailio/commit/38c85975e3b4a9f1dc548f7bda1f547… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2017-08-17T12:46:01+02:00 Merge pull request #1218 from kamailio/corehash_trans pv: add string corehash transform --- Modified: src/modules/pv/pv_trans.c Modified: src/modules/pv/pv_trans.h --- Diff: https://github.com/kamailio/kamailio/commit/38c85975e3b4a9f1dc548f7bda1f547… Patch: https://github.com/kamailio/kamailio/commit/38c85975e3b4a9f1dc548f7bda1f547… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index eccf3b6377..603219bf4e 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -39,6 +39,7 @@ #include "../../core/dset.h" #include "../../core/basex.h" #include "../../core/action.h" +#include "../../core/hashes.h" #include "../../core/parser/parse_param.h" #include "../../core/parser/parse_uri.h" @@ -265,6 +266,7 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, str st, st2; pv_value_t v, w; time_t t; + uint sz1, sz2; if(val==NULL || val->flags&PV_VAL_NULL) return -1; @@ -1121,6 +1123,35 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, val->rs = st; break; + case TR_S_COREHASH: + if(!(val->flags&PV_VAL_STR)) + val->rs.s = int2str(val->ri, &val->rs.len); + + sz1 = 0; + if(tp != NULL) { + if(tp->type==TR_PARAM_NUMBER) { + sz1 = (uint) tp->v.n; + } else { + if(pv_get_spec_value(msg, (pv_spec_p)tp->v.data, &v)!=0 + || (!(v.flags&PV_VAL_INT))) + { + LM_ERR("corehash cannot get size (cfg line: %d)\n", + get_cfg_crt_line()); + return -1; + } + sz1 = (uint) v.ri; + } + } + + sz2 = core_hash(&val->rs, NULL, sz1); + + j = sprintf(_tr_buffer, "%u", sz2); + val->flags = PV_VAL_STR; + val->ri = 0; + val->rs.s = _tr_buffer; + val->rs.len = j; + break; + default: LM_ERR("unknown subtype %d (cfg line: %d)\n", subtype, get_cfg_crt_line()); @@ -2395,6 +2426,23 @@ char* tr_parse_string(str* in, trans_t *t) goto error; } goto done; + } else if(name.len==8 && strncasecmp(name.s, "corehash", 8)==0) { + t->subtype = TR_S_COREHASH; + if(*p==TR_PARAM_MARKER) + { + p++; + _tr_parse_nparam(p, p0, tp, spec, n, sign, in, s); + t->params = tp; + } + tp = 0; + while(*p && (*p==' ' || *p=='\t' || *p=='\n')) p++; + if(*p!=TR_RBRACKET) + { + LM_ERR("invalid corehash transformation: %.*s!!\n", + in->len, in->s); + goto error; + } + goto done; } else if(name.len==4 && strncasecmp(name.s, "trim", 4)==0) { t->subtype = TR_S_TRIM; goto done; diff --git a/src/modules/pv/pv_trans.h b/src/modules/pv/pv_trans.h index 764653e5e3..aacb722b95 100644 --- a/src/modules/pv/pv_trans.h +++ b/src/modules/pv/pv_trans.h @@ -41,7 +41,7 @@ enum _tr_s_subtype { TR_S_STRIP, TR_S_STRIPTAIL, TR_S_PREFIXES, TR_S_PREFIXES_QUOT, TR_S_REPLACE, TR_S_TIMEFORMAT, TR_S_TRIM, TR_S_RTRIM, TR_S_LTRIM, TR_S_RM, TR_S_STRIPTO, TR_S_URLENCODEPARAM, TR_S_URLDECODEPARAM, TR_S_NUMERIC, TR_S_ESCAPECSV, - TR_S_ENCODEBASE58, TR_S_DECODEBASE58 + TR_S_ENCODEBASE58, TR_S_DECODEBASE58, TR_S_COREHASH }; enum _tr_uri_subtype { TR_URI_NONE=0, TR_URI_USER, TR_URI_HOST, TR_URI_PASSWD, TR_URI_PORT,

1 0

git:master:74563696: pv: add string corehash transform
by lazedo 17 Aug '17

17 Aug '17

Module: kamailio Branch: master Commit: 74563696fa064b7cbe169e9af1020ba840c8b8ab URL: https://github.com/kamailio/kamailio/commit/74563696fa064b7cbe169e9af1020ba… Author: lazedo <luis.azedo(a)factorlusitano.com> Committer: lazedo <luis.azedo(a)factorlusitano.com> Date: 2017-08-17T03:04:20+01:00 pv: add string corehash transform optional size parameter to return the slot if supplied example $(var(myvar){s.corehash}) returns the hash $(var(myvar){s.corehash, 32}) returns the slot --- Modified: src/modules/pv/pv_trans.c Modified: src/modules/pv/pv_trans.h --- Diff: https://github.com/kamailio/kamailio/commit/74563696fa064b7cbe169e9af1020ba… Patch: https://github.com/kamailio/kamailio/commit/74563696fa064b7cbe169e9af1020ba… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index eccf3b6377..603219bf4e 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -39,6 +39,7 @@ #include "../../core/dset.h" #include "../../core/basex.h" #include "../../core/action.h" +#include "../../core/hashes.h" #include "../../core/parser/parse_param.h" #include "../../core/parser/parse_uri.h" @@ -265,6 +266,7 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, str st, st2; pv_value_t v, w; time_t t; + uint sz1, sz2; if(val==NULL || val->flags&PV_VAL_NULL) return -1; @@ -1121,6 +1123,35 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, val->rs = st; break; + case TR_S_COREHASH: + if(!(val->flags&PV_VAL_STR)) + val->rs.s = int2str(val->ri, &val->rs.len); + + sz1 = 0; + if(tp != NULL) { + if(tp->type==TR_PARAM_NUMBER) { + sz1 = (uint) tp->v.n; + } else { + if(pv_get_spec_value(msg, (pv_spec_p)tp->v.data, &v)!=0 + || (!(v.flags&PV_VAL_INT))) + { + LM_ERR("corehash cannot get size (cfg line: %d)\n", + get_cfg_crt_line()); + return -1; + } + sz1 = (uint) v.ri; + } + } + + sz2 = core_hash(&val->rs, NULL, sz1); + + j = sprintf(_tr_buffer, "%u", sz2); + val->flags = PV_VAL_STR; + val->ri = 0; + val->rs.s = _tr_buffer; + val->rs.len = j; + break; + default: LM_ERR("unknown subtype %d (cfg line: %d)\n", subtype, get_cfg_crt_line()); @@ -2395,6 +2426,23 @@ char* tr_parse_string(str* in, trans_t *t) goto error; } goto done; + } else if(name.len==8 && strncasecmp(name.s, "corehash", 8)==0) { + t->subtype = TR_S_COREHASH; + if(*p==TR_PARAM_MARKER) + { + p++; + _tr_parse_nparam(p, p0, tp, spec, n, sign, in, s); + t->params = tp; + } + tp = 0; + while(*p && (*p==' ' || *p=='\t' || *p=='\n')) p++; + if(*p!=TR_RBRACKET) + { + LM_ERR("invalid corehash transformation: %.*s!!\n", + in->len, in->s); + goto error; + } + goto done; } else if(name.len==4 && strncasecmp(name.s, "trim", 4)==0) { t->subtype = TR_S_TRIM; goto done; diff --git a/src/modules/pv/pv_trans.h b/src/modules/pv/pv_trans.h index 764653e5e3..aacb722b95 100644 --- a/src/modules/pv/pv_trans.h +++ b/src/modules/pv/pv_trans.h @@ -41,7 +41,7 @@ enum _tr_s_subtype { TR_S_STRIP, TR_S_STRIPTAIL, TR_S_PREFIXES, TR_S_PREFIXES_QUOT, TR_S_REPLACE, TR_S_TIMEFORMAT, TR_S_TRIM, TR_S_RTRIM, TR_S_LTRIM, TR_S_RM, TR_S_STRIPTO, TR_S_URLENCODEPARAM, TR_S_URLDECODEPARAM, TR_S_NUMERIC, TR_S_ESCAPECSV, - TR_S_ENCODEBASE58, TR_S_DECODEBASE58 + TR_S_ENCODEBASE58, TR_S_DECODEBASE58, TR_S_COREHASH }; enum _tr_uri_subtype { TR_URI_NONE=0, TR_URI_USER, TR_URI_HOST, TR_URI_PASSWD, TR_URI_PORT,

1 0

git:master:46800861: http_client Move some logging to debug to avoid annoying messages
by Olle E. Johansson 17 Aug '17

17 Aug '17

Module: kamailio Branch: master Commit: 4680086105bb41f03a1180be03d7acce113d465a URL: https://github.com/kamailio/kamailio/commit/4680086105bb41f03a1180be03d7acc… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2017-08-17T10:00:42+02:00 http_client Move some logging to debug to avoid annoying messages --- Modified: src/modules/http_client/curlcon.c --- Diff: https://github.com/kamailio/kamailio/commit/4680086105bb41f03a1180be03d7acc… Patch: https://github.com/kamailio/kamailio/commit/4680086105bb41f03a1180be03d7acc… --- diff --git a/src/modules/http_client/curlcon.c b/src/modules/http_client/curlcon.c index 8e73200f0e..9a87865837 100644 --- a/src/modules/http_client/curlcon.c +++ b/src/modules/http_client/curlcon.c @@ -228,7 +228,6 @@ int curl_parse_param(char *val) param_t *conparams = NULL; curl_con_t *cc = NULL; - LM_INFO("http_client modparam parsing starting\n"); LM_DBG("modparam httpcon: %s\n", val); LM_DBG(" *** Default httproxy: %s\n", http_proxy.s); @@ -770,6 +769,6 @@ curl_con_t *curl_init_con(str *name) ccp->curl = NULL; _curl_con_pkg_root = ccp; - LM_INFO("CURL: Added connection [%.*s]\n", name->len, name->s); + LM_DBG("CURL: Added connection [%.*s]\n", name->len, name->s); return cc; }

1 0

[kamailio/kamailio] kamailio 4.4.x: Abort and coredump (#604)
by Rick 17 Aug '17

17 Aug '17

Kamailio had an abort happend and does a coredump. Sorry I doesn't have debug symbols on this machine. Kamailio: ``` root@voip-integration-cust1:~ # kamailio -V version: kamailio 4.4.0 (amd64/freebsd) d4f23c flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_PTHREAD_MUTEX, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, select, kqueue. id: d4f23c compiled on 16:52:24 Apr 30 2016 with clang 3.4 ``` Log: ``` May 4 17:55:27 <local0.crit> voip-integration-cust1 kamailio[1177]: CRITICAL: <core> [pass_fd.c:275]: receive_fd(): EOF on 12 May 4 17:55:27 <kern.info> voip-integration-cust1 kernel: pid 1147 (kamailio), uid 986: exited on signal 6 (core dumped) May 4 17:55:27 <kern.info> voip-integration-cust1 kernel: pid 1146 (kamailio), uid 986: exited on signal 6 (core dumped) May 4 17:55:27 <local0.alert> voip-integration-cust1 kamailio[1145]: ALERT: <core> [main.c:739]: handle_sigs(): child process 1147 exited by a signal 6 May 4 17:55:27 <local0.alert> voip-integration-cust1 kamailio[1145]: ALERT: <core> [main.c:742]: handle_sigs(): core was generated May 4 17:55:27 <kern.info> voip-integration-cust1 kernel: pid 1148 (kamailio), uid 986: exited on signal 6 (core dumped) ``` Backtrace: ``` #0 0x000000080110235a in thr_kill () from /lib/libc.so.7 #1 0x0000000801102346 in raise () from /lib/libc.so.7 #2 0x00000008011022c9 in abort () from /lib/libc.so.7 #3 0x0000000800e3195a in pthread_attr_getaffinity_np () from /lib/libthr.so.3 #4 0x0000000800e2d046 in pthread_mutex_destroy () from /lib/libthr.so.3 #5 0x0000000805b436b5 in rpc_reply () from /usr/local/lib/kamailio/modules/tm.so #6 0x0000000805b23f18 in tm_reply_mutex_lock () from /usr/local/lib/kamailio/modules/tm.so #7 0x0000000805b34ba2 in reply_received () from /usr/local/lib/kamailio/modules/tm.so #8 0x000000000057146b in forward_reply () #9 0x0000000000570cca in forward_reply () #10 0x00000000004682a4 in receive_msg () #11 0x0000000000645023 in udp_rcv_loop () #12 0x0000000000543cad in main_loop () #13 0x00000000005519a5 in main () ``` --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/604

3 14

git:master:534546e6: modules: readme files regenerated - dialog ... [skip ci]
by Kamailio Dev 17 Aug '17

17 Aug '17

Module: kamailio Branch: master Commit: 534546e6514056eb5d7f2b46d9c6acf7cb4931ce URL: https://github.com/kamailio/kamailio/commit/534546e6514056eb5d7f2b46d9c6acf… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-17T07:31:41+02:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/534546e6514056eb5d7f2b46d9c6acf… Patch: https://github.com/kamailio/kamailio/commit/534546e6514056eb5d7f2b46d9c6acf… --- diff --git a/src/modules/dialog/README b/src/modules/dialog/README index a232ea61bd..f344c99b53 100644 --- a/src/modules/dialog/README +++ b/src/modules/dialog/README @@ -126,6 +126,7 @@ Olle E. Johansson 7.15. dlg_set_timeout_by_profile(profile, [value], timeout) 7.16. dlg_set_property(attr) 7.17. dlg_remote_profile(cmd, profile, value, uid, expires) + 7.18. dlg_set_ruri() 8. Statistics @@ -249,6 +250,7 @@ Olle E. Johansson 1.73. dlg_set_timeout_by_profile usage 1.74. dlg_set_property usage 1.75. dlg_remote_profile usage + 1.76. dlg_set_ruri() usage Chapter 1. Admin Guide @@ -343,6 +345,7 @@ Chapter 1. Admin Guide 7.15. dlg_set_timeout_by_profile(profile, [value], timeout) 7.16. dlg_set_property(attr) 7.17. dlg_remote_profile(cmd, profile, value, uid, expires) + 7.18. dlg_set_ruri() 8. Statistics @@ -1338,6 +1341,7 @@ end 7.15. dlg_set_timeout_by_profile(profile, [value], timeout) 7.16. dlg_set_property(attr) 7.17. dlg_remote_profile(cmd, profile, value, uid, expires) + 7.18. dlg_set_ruri() 7.1. set_dlg_profile(profile,[value]) @@ -1706,6 +1710,22 @@ $var(exp) = 3600 + $Ts; dlg_remote_profile("add", "caller", "test", "$sruid", "$var(exp)"); ... +7.18. dlg_set_ruri() + + This function sets the R-URI with the corresponding endpoint address + stored in dialog structure (i.e., its Contact field). + + This function can be used from ANY_ROUTE. + + Example 1.76. dlg_set_ruri() usage +... +if(has_totag() and is_present_hf("Route") and uri==myself ) { + if(dlg_set_ruri()) { + xlog("Request URI changed from [$ou] to dlg value: [$ru]\n"); + } +} +... + 8. Statistics 8.1. active_dialogs

1 0

git:master:87ca7a1b: dialog: added dlg_set_ruri()
by Daniel-Constantin Mierla 17 Aug '17

17 Aug '17

Module: kamailio Branch: master Commit: 87ca7a1b078f0c8d85b0d7e1cc43773cd238037e URL: https://github.com/kamailio/kamailio/commit/87ca7a1b078f0c8d85b0d7e1cc43773… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-17T07:17:49+02:00 dialog: added dlg_set_ruri() - sets the r-uri of requests within dialog with the correspondong contact address stored in dialog structure - convenient function as alternative to checking direction and then setting by assigning to $ru from $dlg(*contact) --- Modified: src/modules/dialog/dialog.c Modified: src/modules/dialog/dlg_profile.c Modified: src/modules/dialog/dlg_profile.h --- Diff: https://github.com/kamailio/kamailio/commit/87ca7a1b078f0c8d85b0d7e1cc43773… Patch: https://github.com/kamailio/kamailio/commit/87ca7a1b078f0c8d85b0d7e1cc43773…

1 0

git:master:afc678e9: dialog: documentation for dlg_set_ruri()
by Daniel-Constantin Mierla 17 Aug '17

17 Aug '17

Module: kamailio Branch: master Commit: afc678e9db29f3cf83aff0f24d7affdae5be6cba URL: https://github.com/kamailio/kamailio/commit/afc678e9db29f3cf83aff0f24d7affd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-17T07:28:07+02:00 dialog: documentation for dlg_set_ruri() --- Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/afc678e9db29f3cf83aff0f24d7affd… Patch: https://github.com/kamailio/kamailio/commit/afc678e9db29f3cf83aff0f24d7affd… --- diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml index 45ce5cc690..e451ce4b9d 100644 --- a/src/modules/dialog/doc/dialog_admin.xml +++ b/src/modules/dialog/doc/dialog_admin.xml @@ -32,7 +32,7 @@ The dialog module provides dialog awareness for the &kamailio; proxy. It's functionality is to keep track of the current dialogs, to offer information about them (e.g. how many dialogs are active), and to manage various - characteristics of dialogs. The module exports several functions that can be + characteristics of dialogs. The module exports several functions that can be used directly from the configuration route script as well as functions for the RPC interface. </para> @@ -1955,24 +1955,24 @@ if(dlg_get("abcdef", "123", "456")) </programlisting> </example> </section> - + <section id="dialog.f.is_known_dlg"> <title> <function moreinfo="none">is_known_dlg()</function> </title> <para> This function checks if the current SIP message being processed - belongs to any transaction within an active dialog that the - dialog module is currently tracking. This is a check for + belongs to any transaction within an active dialog that the + dialog module is currently tracking. This is a check for tracking of any kind, without regard to profiles. </para> <para> This function has numerous potential applications, among which - is that it can be used to strengthen security for + is that it can be used to strengthen security for loose-routing sequential (in-dialog) requests or responses to them, as by providing a preventative check against spoofing on the proxy level instead of leaving the issue - purely to the receiving UA. + purely to the receiving UA. </para> <para> This function can be used from REQUEST_ROUTE, BRANCH_ROUTE, @@ -2041,7 +2041,7 @@ if(dlg_set_timeout("180", "123", "456")) <function moreinfo="none">dlg_set_timeout_by_profile(profile, [value], timeout)</function> </title> <para> - Like <emphasis>dlg_set_timeout()</emphasis>, but + Like <emphasis>dlg_set_timeout()</emphasis>, but simultaneously sets the timeout of all dialogs in a given profile. Can be constrained by profile value. </para> @@ -2064,7 +2064,7 @@ if(dlg_set_timeout("180", "123", "456")) <title><function>dlg_set_timeout_by_profile</function> usage</title> <programlisting format="linespecific"> ... -# All dialogs belonging to user abc123 (tracked via set_dlg_profile()) +# All dialogs belonging to user abc123 (tracked via set_dlg_profile()) # will be timed out in 3 seconds. dlg_set_timeout_by_profile("users", "abc123", "3"); @@ -2178,6 +2178,30 @@ dlg_remote_profile("add", "caller", "test", "$sruid", "$var(exp)"); </programlisting> </example> </section> + <section id="dialog.f.dlg_set_ruri"> + <title> + <function moreinfo="none">dlg_set_ruri()</function> + </title> + <para> + This function sets the R-URI with the corresponding endpoint address + stored in dialog structure (i.e., its Contact field). + </para> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title><function>dlg_set_ruri()</function> usage</title> + <programlisting format="linespecific"> +... +if(has_totag() and is_present_hf("Route") and uri==myself ) { + if(dlg_set_ruri()) { + xlog("Request URI changed from [$ou] to dlg value: [$ru]\n"); + } +} +... +</programlisting> + </example> + </section> </section>

1 0

[kamailio/kamailio] ims_auth: fixed rare core dump, due to null ptr check (#1213)
by Christoph VALENTIN 16 Aug '17

16 Aug '17

The ims_auth module reads the value from the Content-Length header of a REGISTER request, before decoding the message body. Due to a missing null pointer check, reading this value leads to core dump in case the Content-Length header is missing.   #### Pre-Submission Checklist    - [ x] Commit message has the format required by CONTRIBUTING guide - [ x] Commits are split per component (core, individual modules, libs, utils, ...) - [ x] Each component has a single commit (if not, squash them into one commit) - [ x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ x] PR should be backported to stable branches - [ x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Added a null pointer check in function ims_get_body() - file utils.c of module ims_auth - to check whether Content-Length Header was present in REGISTER message. If Content-Length Header is not present, a Default value of 0 will be assumed. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1213 -- Commit Summary -- * ims_auth: fixed rare core dump, due to null ptr check -- File Changes -- M src/modules/ims_auth/utils.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1213.patch https://github.com/kamailio/kamailio/pull/1213.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1213

3 5

git:master:05988455: core: updated mailing list address in CONTRIBUTING.md
by GitHub 16 Aug '17

16 Aug '17

Module: kamailio Branch: master Commit: 059884554528731261d600adc9bc2f1a75583bfb URL: https://github.com/kamailio/kamailio/commit/059884554528731261d600adc9bc2f1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2017-08-16T12:33:51+02:00 core: updated mailing list address in CONTRIBUTING.md --- Modified: .github/CONTRIBUTING.md --- Diff: https://github.com/kamailio/kamailio/commit/059884554528731261d600adc9bc2f1… Patch: https://github.com/kamailio/kamailio/commit/059884554528731261d600adc9bc2f1… --- diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 1b23d8c52e..e74babc78f 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -169,4 +169,4 @@ released under BSD must be done under BSD as well. For any question, do not hesitate to contact other developers via mailing list: - * **[sr-dev [at] lists.sip-router.org](http://lists.sip-router.org/cgi-bin/mailman/listinfo/… + * **[sr-dev [at] lists.kamailio.org](http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-d…

1 0

[kamailio/kamailio] Wishlist #234: URI transformation to pick up URI scheme (#592)
by Olle E. Johansson 16 Aug '17

16 Aug '17

I would like the URI transformations to be more generic so one can pick up the URI scheme, like HTTP: or TEL: Just an idea --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/592

2 2

git:master:893c68d5: pv: implemented {uri.scheme} transformation
by Daniel-Constantin Mierla 16 Aug '17

16 Aug '17

Module: kamailio Branch: master Commit: 893c68d5cbbab35d842aa7275c57d692770e0fff URL: https://github.com/kamailio/kamailio/commit/893c68d5cbbab35d842aa7275c57d69… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-16T09:15:03+02:00 pv: implemented {uri.scheme} transformation - GH #592 --- Modified: src/modules/pv/pv_trans.c Modified: src/modules/pv/pv_trans.h --- Diff: https://github.com/kamailio/kamailio/commit/893c68d5cbbab35d842aa7275c57d69… Patch: https://github.com/kamailio/kamailio/commit/893c68d5cbbab35d842aa7275c57d69… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index 62574c46f5..eccf3b6377 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -1292,6 +1292,16 @@ int tr_eval_uri(struct sip_msg *msg, tr_param_t *tp, int subtype, val->rs = (_tr_parsed_uri.r2_val.s)? _tr_parsed_uri.r2_val:_tr_empty; break; + case TR_URI_SCHEME: + val->rs.s = _tr_uri.s; + val->rs.len = 0; + while(val->rs.len<_tr_uri.len) { + if(_tr_uri.s[val->rs.len]==':') { + break; + } + val->rs.len++; + } + break; default: LM_ERR("unknown subtype %d\n", subtype); @@ -2529,6 +2539,9 @@ char* tr_parse_uri(str* in, trans_t *t) } else if(name.len==2 && strncasecmp(name.s, "r2", 2)==0) { t->subtype = TR_URI_R2; goto done; + } else if(name.len==6 && strncasecmp(name.s, "scheme", 6)==0) { + t->subtype = TR_URI_SCHEME; + goto done; } LM_ERR("unknown transformation: %.*s/%.*s!\n", in->len, diff --git a/src/modules/pv/pv_trans.h b/src/modules/pv/pv_trans.h index 7b7b15fb03..764653e5e3 100644 --- a/src/modules/pv/pv_trans.h +++ b/src/modules/pv/pv_trans.h @@ -47,7 +47,7 @@ enum _tr_uri_subtype { TR_URI_NONE=0, TR_URI_USER, TR_URI_HOST, TR_URI_PASSWD, TR_URI_PORT, TR_URI_PARAMS, TR_URI_PARAM, TR_URI_HEADERS, TR_URI_TRANSPORT, TR_URI_TTL, TR_URI_UPARAM, TR_URI_MADDR, TR_URI_METHOD, TR_URI_LR, - TR_URI_R2 + TR_URI_R2, TR_URI_SCHEME }; enum _tr_param_subtype { TR_PL_NONE=0, TR_PL_VALUE, TR_PL_VALUEAT, TR_PL_NAME, TR_PL_COUNT

1 0

git:master:539a6eef: app_sqlang:
by Henning Westerholt 15 Aug '17

15 Aug '17

Module: kamailio Branch: master Commit: 539a6eefa469a4394f4e6dfbe6a9affba3e2f440 URL: https://github.com/kamailio/kamailio/commit/539a6eefa469a4394f4e6dfbe6a9aff… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2017-08-15T15:28:02+02:00 app_sqlang: - fix a few copy and paste errors in the docs (probably from app_jsdt) - regenerate README --- Modified: src/modules/app_sqlang/README Modified: src/modules/app_sqlang/doc/app_sqlang_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/539a6eefa469a4394f4e6dfbe6a9aff… Patch: https://github.com/kamailio/kamailio/commit/539a6eefa469a4394f4e6dfbe6a9aff…

2 2

git:master:219ddbb5: uac: use kam_rand() instead of rand()
by Daniel-Constantin Mierla 15 Aug '17

15 Aug '17

Module: kamailio Branch: master Commit: 219ddbb54bb787a8f0673014c16e749eef40bdf4 URL: https://github.com/kamailio/kamailio/commit/219ddbb54bb787a8f0673014c16e749… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-15T15:48:50+02:00 uac: use kam_rand() instead of rand() - do kam_srand() when module is initialized --- Modified: src/modules/uac/uac.c Modified: src/modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/219ddbb54bb787a8f0673014c16e749… Patch: https://github.com/kamailio/kamailio/commit/219ddbb54bb787a8f0673014c16e749… --- diff --git a/src/modules/uac/uac.c b/src/modules/uac/uac.c index d5ac59201d..844b6025ff 100644 --- a/src/modules/uac/uac.c +++ b/src/modules/uac/uac.c @@ -50,6 +50,7 @@ #include "../../core/kemi.h" #include "../../core/rpc.h" #include "../../core/rpc_lookup.h" +#include "../../core/rand/kam_rand.h" #include "../../core/cfg/cfg_struct.h" #include "../dialog/dlg_load.h" @@ -305,6 +306,7 @@ static int mod_init(void) if(reg_db_url.s && reg_db_url.len>=0) { + kam_srand(17 * getpid() + time(0)); if(!reg_contact_addr.s || reg_contact_addr.len<=0) { LM_ERR("contact address parameter not set\n"); @@ -343,6 +345,9 @@ static int mod_init(void) static int child_init(int rank) { int pid; + + kam_srand((11 + rank) * getpid() * 17 + time(0)); + if (rank!=PROC_MAIN) return 0; @@ -361,6 +366,7 @@ static int child_init(int rank) if (cfg_child_init()) return -1; + kam_srand(getpid() * 17 + time(0)); uac_reg_load_db(); uac_reg_timer(0); for(;;){ diff --git a/src/modules/uac/uac_reg.c b/src/modules/uac/uac_reg.c index cb7e4786af..d85d51c6a0 100644 --- a/src/modules/uac/uac_reg.c +++ b/src/modules/uac/uac_reg.c @@ -43,6 +43,7 @@ #include "../../core/parser/contact/parse_contact.h" #include "../../core/rpc.h" #include "../../core/rpc_lookup.h" +#include "../../core/rand/kam_rand.h" #include "../../modules/tm/tm_load.h" @@ -538,7 +539,7 @@ int reg_ht_add(reg_uac_t *reg) if (reg->reg_delay) nr->reg_delay = reg->reg_delay; else if (reg_random_delay>0) - nr->reg_delay = rand() % reg_random_delay; + nr->reg_delay = kam_rand() % reg_random_delay; nr->reg_init = time(NULL); nr->h_uuid = reg_compute_hash(&reg->l_uuid); nr->h_user = reg_compute_hash(&reg->l_username);

1 0

git:master:f3f3ed2b: modules: readme files regenerated - tls ... [skip ci]
by Kamailio Dev 15 Aug '17

15 Aug '17

Module: kamailio Branch: master Commit: f3f3ed2b343fc2f33f14e903f927a138e3c3adb4 URL: https://github.com/kamailio/kamailio/commit/f3f3ed2b343fc2f33f14e903f927a13… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-15T15:16:24+02:00 modules: readme files regenerated - tls ... [skip ci] --- Modified: src/modules/tls/README --- Diff: https://github.com/kamailio/kamailio/commit/f3f3ed2b343fc2f33f14e903f927a13… Patch: https://github.com/kamailio/kamailio/commit/f3f3ed2b343fc2f33f14e903f927a13… --- diff --git a/src/modules/tls/README b/src/modules/tls/README index f0d36b2758..dcdbfed6de 100644 --- a/src/modules/tls/README +++ b/src/modules/tls/README @@ -63,6 +63,7 @@ Olle E. Johansson 9.30. renegotiation (boolean) 9.31. config (string) 9.32. xavp_cfg (string) + 9.33. event_callback (str) 10. Functions @@ -80,6 +81,10 @@ Olle E. Johansson 12.1. License 12.2. History + 13. Event Routes + + 13.1. event_route[tls:connection-out] + List of Examples 1.1. Quick start config @@ -125,7 +130,9 @@ Olle E. Johansson 1.41. Set config parameter 1.42. Change and reload the TLS configuration at runtime 1.43. Set xavp_cfg parameter - 1.44. is_peer_verified usage + 1.44. Set event_callback parameter + 1.45. is_peer_verified usage + 1.46. Use of event_route[tls:connection-out] Chapter 1. Admin Guide @@ -173,6 +180,7 @@ Chapter 1. Admin Guide 9.30. renegotiation (boolean) 9.31. config (string) 9.32. xavp_cfg (string) + 9.33. event_callback (str) 10. Functions @@ -190,6 +198,10 @@ Chapter 1. Admin Guide 12.1. License 12.2. History + 13. Event Routes + + 13.1. event_route[tls:connection-out] + 1. Overview This module implements the TLS transport for Kamailio using the OpenSSL @@ -520,6 +532,7 @@ Revoking a certificate and using a CRL 9.30. renegotiation (boolean) 9.31. config (string) 9.32. xavp_cfg (string) + 9.33. event_callback (str) 9.1. tls_method (string) @@ -1267,6 +1280,28 @@ modparam("tls", "config", "/usr/local/etc/kamailio/tls.cfg") route(RELAY); ... +9.33. event_callback (str) + + The name of the function in the kemi configuration file (embedded + scripting language such as Lua, Python, ...) to be executed instead of + event_route[...] blocks specific for tls module. + + The function has one string parameter, the value is the name of the + event_route block, respectively "tls:connection-out". + + Default value is 'empty' (no function is executed for events). + + Example 1.44. Set event_callback parameter +... +modparam("tls", "event_callback", "ksr_tls_event") +... +-- event callback function implemented in Lua +function ksr_tls_event(evname) + KSR.info("===== tls module triggered event: " .. evname .. "\n"); + return 1; +end +... + 10. Functions 10.1. is_peer_verified() @@ -1277,7 +1312,7 @@ modparam("tls", "config", "/usr/local/etc/kamailio/tls.cfg") , the peer presented an X509 certificate and the certificate chain verified ok. It can be used only in a request route. - Example 1.44. is_peer_verified usage + Example 1.45. is_peer_verified usage if (proto==TLS && !is_peer_verified()){ sl_send_reply("400", "No certificate or verification failed"); drop; @@ -1343,3 +1378,22 @@ modparam("tls", "config", "/usr/local/etc/kamailio/tls.cfg") Install does not generate self-signed certificates by default anymore. In order to generate them now you should do "make install-tls-cert" + +13. Event Routes + + 13.1. event_route[tls:connection-out] + +13.1. event_route[tls:connection-out] + + Event route to be executed when a TLS connection is opened by Kamailio. + If drop() is executed in the event route, then the data is no longer + sent over the connection. + + Example 1.46. Use of event_route[tls:connection-out] +... +event_route[tls:connection-out] { + if($sndto(ip)=="1.2.3.4") { + drop; + } +} +...

1 0

git:master:cb7810c9: tls: docs for event_route[tls:connection-out] and event_callback param
by Daniel-Constantin Mierla 15 Aug '17

15 Aug '17

Module: kamailio Branch: master Commit: cb7810c939da9c8f4385b530539487528ac8705d URL: https://github.com/kamailio/kamailio/commit/cb7810c939da9c8f4385b5305394875… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-15T15:09:37+02:00 tls: docs for event_route[tls:connection-out] and event_callback param --- Modified: src/modules/tls/doc/params.xml Modified: src/modules/tls/doc/rpc.xml Modified: src/modules/tls/doc/tls.xml --- Diff: https://github.com/kamailio/kamailio/commit/cb7810c939da9c8f4385b5305394875… Patch: https://github.com/kamailio/kamailio/commit/cb7810c939da9c8f4385b5305394875… --- diff --git a/src/modules/tls/doc/params.xml b/src/modules/tls/doc/params.xml index 5ab2426e7b..e3d236dea4 100644 --- a/src/modules/tls/doc/params.xml +++ b/src/modules/tls/doc/params.xml @@ -1164,5 +1164,36 @@ modparam("tls", "config", "/usr/local/etc/kamailio/tls.cfg") </programlisting> </example> </section> + <section id="tls.p.event_callback"> + <title><varname>event_callback</varname> (str)</title> + <para> + The name of the function in the kemi configuration file (embedded + scripting language such as Lua, Python, ...) to be executed instead + of event_route[...] blocks specific for tls module. + </para> + <para> + The function has one string parameter, the value is the name of + the event_route block, respectively "tls:connection-out". + </para> + <para> + <emphasis> + Default value is 'empty' (no function is executed for events). + </emphasis> + </para> + <example> + <title>Set <varname>event_callback</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("tls", "event_callback", "ksr_tls_event") +... +-- event callback function implemented in Lua +function ksr_tls_event(evname) + KSR.info("===== tls module triggered event: " .. evname .. "\n"); + return 1; +end +... +</programlisting> + </example> + </section> </section> diff --git a/src/modules/tls/doc/rpc.xml b/src/modules/tls/doc/rpc.xml index cd432d85d9..8f3070648b 100644 --- a/src/modules/tls/doc/rpc.xml +++ b/src/modules/tls/doc/rpc.xml @@ -15,8 +15,8 @@ <section id="tls.r.tls.info"> <title><function>tls.info</function></title> <para> - List internal information related to the TLS module in - a short list - max connections, open connections and the + List internal information related to the TLS module in + a short list - max connections, open connections and the write queue size. </para> <para>Parameters: </para> @@ -53,7 +53,7 @@ <section id="tls.r.tls.reload"> <title><function>tls.reload</function></title> <para> - Reload the external TLS configuration file (aka tls.cfg). It does not reload + Reload the external TLS configuration file (aka tls.cfg). It does not reload modparam() parameters. Note that existing active TLS connections are not terminated and they continue to use the old certificates. The new configuration will be used for new connections. diff --git a/src/modules/tls/doc/tls.xml b/src/modules/tls/doc/tls.xml index 11c4aa7318..0c8fce400f 100644 --- a/src/modules/tls/doc/tls.xml +++ b/src/modules/tls/doc/tls.xml @@ -275,6 +275,31 @@ make -C modules/tls extra_defs="-DTLS_WR_DEBUG -DTLS_RD_DEBUG" <xi:include href="functions.xml"/> <xi:include href="rpc.xml"/> <xi:include href="history.xml"/> + + <section id="tls.event_routes"> + <title>Event Routes</title> + <section id="tls.evrt.connection_out"> + <title>event_route[tls:connection-out]</title> + <para> + Event route to be executed when a TLS connection is opened by + &kamailio;. If drop() is executed in the event route, then the + data is no longer sent over the connection. + </para> + <example> + <title>Use of <varname>event_route[tls:connection-out]</varname></title> + <programlisting> +... +event_route[tls:connection-out] { + if($sndto(ip)=="1.2.3.4") { + drop; + } +} +... + </programlisting> + </example> + + </section> + </section> </chapter> </book>

1 0

git:master:5a889756: tls: completed the code for event_route[tls:connection-out]
by Daniel-Constantin Mierla 15 Aug '17

15 Aug '17

Module: kamailio Branch: master Commit: 5a889756a5386d6df86bd2ae11ac68595200fd65 URL: https://github.com/kamailio/kamailio/commit/5a889756a5386d6df86bd2ae11ac685… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-15T14:56:40+02:00 tls: completed the code for event_route[tls:connection-out] - event route executed after the connect to destination is done - using drop() in the event route marks connection for no-send data, so nothing is sent over it, being also closed - added also support for kemi interface - new mod param: event_callback - specify the name of kemi callback function --- Modified: src/modules/tls/tls_dump_vf.c Modified: src/modules/tls/tls_mod.c Modified: src/modules/tls/tls_server.c --- Diff: https://github.com/kamailio/kamailio/commit/5a889756a5386d6df86bd2ae11ac685… Patch: https://github.com/kamailio/kamailio/commit/5a889756a5386d6df86bd2ae11ac685…

1 0

git:master:3214be45: core: tcp - new flag F_CONN_NOSEND (mark connection for no-send data)
by Daniel-Constantin Mierla 15 Aug '17

15 Aug '17

Module: kamailio Branch: master Commit: 3214be4589471cd2fff9a9a4b763fc05cdb71c6d URL: https://github.com/kamailio/kamailio/commit/3214be4589471cd2fff9a9a4b763fc0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-15T14:48:16+02:00 core: tcp - new flag F_CONN_NOSEND (mark connection for no-send data) - if flag set, the data is not sent over the connection - can be set by drop() inside event_route[tls:connection-out] --- Modified: src/core/tcp_conn.h Modified: src/core/tcp_main.c --- Diff: https://github.com/kamailio/kamailio/commit/3214be4589471cd2fff9a9a4b763fc0… Patch: https://github.com/kamailio/kamailio/commit/3214be4589471cd2fff9a9a4b763fc0…

1 0

git:master:b44fc529: core: forward - coherent indentation and whitespacing
by Daniel-Constantin Mierla 15 Aug '17

15 Aug '17

Module: kamailio Branch: master Commit: b44fc5293e343077db0bdea27501fd3aec3dfa11 URL: https://github.com/kamailio/kamailio/commit/b44fc5293e343077db0bdea27501fd3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-15T14:46:48+02:00 core: forward - coherent indentation and whitespacing --- Modified: src/core/forward.h --- Diff: https://github.com/kamailio/kamailio/commit/b44fc5293e343077db0bdea27501fd3… Patch: https://github.com/kamailio/kamailio/commit/b44fc5293e343077db0bdea27501fd3…

1 0

[kamailio/kamailio] Do not start Kamailio if no listener address is configured (#1098)
by Sarbyn 15 Aug '17

15 Aug '17

### Description During some test on my server I forgot to configure a valid listen network address. It's my fault but Kamailio crashed with a useless message: > kamailio[4739]: segfault at 0 ip 00007f022ede5e71 sp 00007fff94033f08 error 4 in libc-2.17.so[7f022ec82000+1b6000 I think it's better to abort the startup if no listen address is specified and with an explicit error message, instead of produce a segfault and a crash without any error -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1098

4 10

git:master:b3b95b5b: topos: use INVITE transaction record to route BYE if dlg has no B-contact
by Daniel-Constantin Mierla 15 Aug '17

15 Aug '17

Module: kamailio Branch: master Commit: b3b95b5b701a7f7ebf9532a172cd31b6dca699ff URL: https://github.com/kamailio/kamailio/commit/b3b95b5b701a7f7ebf9532a172cd31b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-15T09:50:35+02:00 topos: use INVITE transaction record to route BYE if dlg has no B-contact --- Modified: src/modules/topos/tps_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/b3b95b5b701a7f7ebf9532a172cd31b… Patch: https://github.com/kamailio/kamailio/commit/b3b95b5b701a7f7ebf9532a172cd31b… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index 22441b5fa9..75b6d02078 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -773,12 +773,25 @@ int tps_request_received(sip_msg_t *msg, int dialog) } use_branch = 1; } else { - if(tps_storage_load_dialog(msg, &mtsd, &stsd)<0) { + if(tps_storage_load_dialog(msg, &mtsd, &stsd) < 0) { goto error; } - /* detect direction - via from-tag */ - if(tps_dlg_detect_direction(msg, &stsd, &direction) < 0) { - goto error; + if(((get_cseq(msg)->method_id) & (METHOD_BYE)) + && stsd.b_contact.len <= 0) { + /* BYE but not B-side contact, look for INVITE transaction record */ + memset(&stsd, 0, sizeof(tps_data_t)); + if(tps_storage_link_msg(msg, &mtsd, TPS_DIR_DOWNSTREAM) < 0) { + goto error; + } + if(tps_storage_load_branch(msg, &mtsd, &stsd, 1) < 0) { + goto error; + } + use_branch = 1; + } else { + /* detect direction - via from-tag */ + if(tps_dlg_detect_direction(msg, &stsd, &direction) < 0) { + goto error; + } } }

1 0

Bug in subst() function
by Cléviton Mendes de Araújo 15 Aug '17

15 Aug '17

Hi fulks I try changing info value in PAI header-field by using subst() function into route block as below: route[3] { ... $var(fromU) = 22227777; ... subst('/^P-Asserted-Identity:(.*)sip:[^@]*@([a-zA-Z0-9.:]+)( .*)$/P-Asserted-Identity:\1sip:$var(fromU)@\2\3/ig'); ... ... forward(); exit; } But when I read ngrep command output I catch P-Asserted-Identity header as below: +++++++++++++++++++++++++++++++++++++++++++++++ before route[3] processing: INVITE sip:99992222@15.113.132.21:5060 SIP/2.0. ... P-Asserted-Identity: "Display Name 7777" <sip:7777@101.14.101.245>. ... +++++++++++++++++++++++++++++++++++++++++++++++ after route[3] processing: INVITE sip:99992222@15.113.132.21:5060 SIP/2.0. ... P-Asserted-Identity: "Display Name 7777" <sip:22227777@101.14.101.245>.P-Asserted-Identity: "Display Name 7777" <sip:7777@101.14.101.245>. ... +++++++++++++++++++++++++++++++++++++++++++++++ So, is it normal or bug behaviors? Regards CMA

2 1

unused var in rls/subscribe.c
by Juha Heinanen 15 Aug '17

15 Aug '17

CC (gcc) [M rls.so] subscribe.o subscribe.c: In function 'reply_200': subscribe.c:340:6: warning: unused variable 'len' [-Wunused-variable] int len; ^~~

2 1

git:master:f8c6ece3: rls: removed unused variable
by Daniel-Constantin Mierla 15 Aug '17

15 Aug '17

Module: kamailio Branch: master Commit: f8c6ece395a9601499c01f368c645d1d441a1789 URL: https://github.com/kamailio/kamailio/commit/f8c6ece395a9601499c01f368c645d1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-15T09:01:50+02:00 rls: removed unused variable - reported by Juha Heinanen --- Modified: src/modules/rls/subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/f8c6ece395a9601499c01f368c645d1… Patch: https://github.com/kamailio/kamailio/commit/f8c6ece395a9601499c01f368c645d1… --- diff --git a/src/modules/rls/subscribe.c b/src/modules/rls/subscribe.c index dc76e4fdba..655a9cde94 100644 --- a/src/modules/rls/subscribe.c +++ b/src/modules/rls/subscribe.c @@ -337,7 +337,6 @@ int reply_421(struct sip_msg* msg) int reply_200(struct sip_msg* msg, str* contact, int expires) { str hdr_append; - int len; hdr_append.s = (char *)pkg_malloc( sizeof(char)*(contact->len+70)); if(hdr_append.s == NULL)

1 0

git:master:1fe94fe8: pkg/kamailio/deb: version set to 5.1.0-dev6
by Victor Seva 14 Aug '17

14 Aug '17

Module: kamailio Branch: master Commit: 1fe94fe8129649703c92a87ebd402068faa66624 URL: https://github.com/kamailio/kamailio/commit/1fe94fe8129649703c92a87ebd40206… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-08-14T23:29:41+02:00 pkg/kamailio/deb: version set to 5.1.0-dev6 --- Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/1fe94fe8129649703c92a87ebd40206… Patch: https://github.com/kamailio/kamailio/commit/1fe94fe8129649703c92a87ebd40206… --- diff --git a/pkg/kamailio/deb/debian/changelog b/pkg/kamailio/deb/debian/changelog index 8174ad58ea..d2709ed68c 100644 --- a/pkg/kamailio/deb/debian/changelog +++ b/pkg/kamailio/deb/debian/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev6) unstable; urgency=medium + + * version set to 5.1.0-dev6 + + -- Victor Seva <vseva(a)debian.org> Mon, 14 Aug 2017 23:28:16 +0200 + kamailio (5.1.0~dev5) unstable; urgency=medium * version set to 5.1.0-dev5 diff --git a/pkg/kamailio/deb/jessie/changelog b/pkg/kamailio/deb/jessie/changelog index 8174ad58ea..d2709ed68c 100644 --- a/pkg/kamailio/deb/jessie/changelog +++ b/pkg/kamailio/deb/jessie/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev6) unstable; urgency=medium + + * version set to 5.1.0-dev6 + + -- Victor Seva <vseva(a)debian.org> Mon, 14 Aug 2017 23:28:16 +0200 + kamailio (5.1.0~dev5) unstable; urgency=medium * version set to 5.1.0-dev5 diff --git a/pkg/kamailio/deb/precise/changelog b/pkg/kamailio/deb/precise/changelog index 8174ad58ea..d2709ed68c 100644 --- a/pkg/kamailio/deb/precise/changelog +++ b/pkg/kamailio/deb/precise/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev6) unstable; urgency=medium + + * version set to 5.1.0-dev6 + + -- Victor Seva <vseva(a)debian.org> Mon, 14 Aug 2017 23:28:16 +0200 + kamailio (5.1.0~dev5) unstable; urgency=medium * version set to 5.1.0-dev5 diff --git a/pkg/kamailio/deb/sid/changelog b/pkg/kamailio/deb/sid/changelog index 8174ad58ea..d2709ed68c 100644 --- a/pkg/kamailio/deb/sid/changelog +++ b/pkg/kamailio/deb/sid/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev6) unstable; urgency=medium + + * version set to 5.1.0-dev6 + + -- Victor Seva <vseva(a)debian.org> Mon, 14 Aug 2017 23:28:16 +0200 + kamailio (5.1.0~dev5) unstable; urgency=medium * version set to 5.1.0-dev5 diff --git a/pkg/kamailio/deb/stretch/changelog b/pkg/kamailio/deb/stretch/changelog index 8174ad58ea..d2709ed68c 100644 --- a/pkg/kamailio/deb/stretch/changelog +++ b/pkg/kamailio/deb/stretch/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev6) unstable; urgency=medium + + * version set to 5.1.0-dev6 + + -- Victor Seva <vseva(a)debian.org> Mon, 14 Aug 2017 23:28:16 +0200 + kamailio (5.1.0~dev5) unstable; urgency=medium * version set to 5.1.0-dev5 diff --git a/pkg/kamailio/deb/trusty/changelog b/pkg/kamailio/deb/trusty/changelog index 8174ad58ea..d2709ed68c 100644 --- a/pkg/kamailio/deb/trusty/changelog +++ b/pkg/kamailio/deb/trusty/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev6) unstable; urgency=medium + + * version set to 5.1.0-dev6 + + -- Victor Seva <vseva(a)debian.org> Mon, 14 Aug 2017 23:28:16 +0200 + kamailio (5.1.0~dev5) unstable; urgency=medium * version set to 5.1.0-dev5 diff --git a/pkg/kamailio/deb/wheezy/changelog b/pkg/kamailio/deb/wheezy/changelog index 8174ad58ea..d2709ed68c 100644 --- a/pkg/kamailio/deb/wheezy/changelog +++ b/pkg/kamailio/deb/wheezy/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev6) unstable; urgency=medium + + * version set to 5.1.0-dev6 + + -- Victor Seva <vseva(a)debian.org> Mon, 14 Aug 2017 23:28:16 +0200 + kamailio (5.1.0~dev5) unstable; urgency=medium * version set to 5.1.0-dev5 diff --git a/pkg/kamailio/deb/xenial/changelog b/pkg/kamailio/deb/xenial/changelog index 8174ad58ea..d2709ed68c 100644 --- a/pkg/kamailio/deb/xenial/changelog +++ b/pkg/kamailio/deb/xenial/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev6) unstable; urgency=medium + + * version set to 5.1.0-dev6 + + -- Victor Seva <vseva(a)debian.org> Mon, 14 Aug 2017 23:28:16 +0200 + kamailio (5.1.0~dev5) unstable; urgency=medium * version set to 5.1.0-dev5

1 0

Re: [sr-dev] [kamailio/kamailio] dialog: updates for core events API changes (4eec934)
by dryvoip 14 Aug '17

14 Aug '17

Compiling fails on CentOS 6 after this change ``` CC (gcc) [M dialog.so] dlg_cseq.o dlg_cseq.c:273: error: expected ')' before '*' token dlg_cseq.c:350: error: expected ')' before '*' token dlg_cseq.c: In function 'dlg_register_cseq_callbacks': dlg_cseq.c:538: error: 'dlg_cseq_msg_received' undeclared (first use in this function) dlg_cseq.c:538: error: (Each undeclared identifier is reported only once dlg_cseq.c:538: error: for each function it appears in.) dlg_cseq.c:539: error: 'dlg_cseq_msg_sent' undeclared (first use in this function) make[2]: *** [dlg_cseq.o] Error 1 make[1]: *** [modules] Error 1 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/4eec934a537551d78e833769c182f80…

1 0

[kamailio/kamailio] topos: fix PRACK message handling (#1097)
by sergey-vb 14 Aug '17

14 Aug '17

Currently PRACK was not handling properly because topos_d.b_contact field are filling only after receiving 200 OK. But PRACK is sending to 183 Progress responce. So I sink that we must filled topos_d.b_contact field after receiving 183 Progress. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1097 -- Commit Summary -- * topos: fix PRACK message handling -- File Changes -- M src/modules/topos/tps_storage.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1097.patch https://github.com/kamailio/kamailio/pull/1097.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1097

2 4

git:master:bcff1c15: topos: added few debug messages when managing headers and ruri
by Daniel-Constantin Mierla 14 Aug '17

14 Aug '17

Module: kamailio Branch: master Commit: bcff1c15521b6841b747b6992e6ebb9850b7dd02 URL: https://github.com/kamailio/kamailio/commit/bcff1c15521b6841b747b6992e6ebb9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-14T14:51:09+02:00 topos: added few debug messages when managing headers and ruri --- Modified: src/modules/topos/tps_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/bcff1c15521b6841b747b6992e6ebb9… Patch: https://github.com/kamailio/kamailio/commit/bcff1c15521b6841b747b6992e6ebb9… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index 228996960e..22441b5fa9 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -179,6 +179,8 @@ int tps_add_headers(sip_msg_t *msg, str *hname, str *hbody, int hpos) hs.len += 2; } + LM_DBG("adding to headers(%d) - [%.*s]\n", hpos, hs.len, hs.s); + if (insert_new_lump_before(anchor, hs.s, hs.len, 0) == 0) { LM_ERR("can't insert lump\n"); pkg_free(hs.s); @@ -797,6 +799,8 @@ int tps_request_received(sip_msg_t *msg, int dialog) if(rewrite_uri(msg, &nuri)<0) { LM_ERR("failed to update r-uri\n"); return -1; + } else { + LM_DBG("r-uri updated to: [%.*s]\n", nuri.len, nuri.s); } }

1 0

git:master:9dc27fa6: topos_redis: load contact fileds for branch and insert INVITE extra branch
by Daniel-Constantin Mierla 14 Aug '17

14 Aug '17

Module: kamailio Branch: master Commit: 9dc27fa6615dc22050448ce592f63e9533afaaf2 URL: https://github.com/kamailio/kamailio/commit/9dc27fa6615dc22050448ce592f63e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-14T14:05:30+02:00 topos_redis: load contact fileds for branch and insert INVITE extra branch - for INVITE store branch value on a key with call-id and to-tag when the reply is received --- Modified: src/modules/topos_redis/topos_redis_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/9dc27fa6615dc22050448ce592f63e9… Patch: https://github.com/kamailio/kamailio/commit/9dc27fa6615dc22050448ce592f63e9…

1 0

git:master:ad7e226d: topos_redis: load INVITE branch record when dealing with PRACK
by Daniel-Constantin Mierla 14 Aug '17

14 Aug '17

Module: kamailio Branch: master Commit: ad7e226dfc9fd3398a891534cf67f0a02d64bf4d URL: https://github.com/kamailio/kamailio/commit/ad7e226dfc9fd3398a891534cf67f0a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-14T14:24:22+02:00 topos_redis: load INVITE branch record when dealing with PRACK --- Modified: src/modules/topos_redis/topos_redis_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/ad7e226dfc9fd3398a891534cf67f0a… Patch: https://github.com/kamailio/kamailio/commit/ad7e226dfc9fd3398a891534cf67f0a…

1 0

git:master:874a7d50: topos: increased defined value for tps nr keys
by Daniel-Constantin Mierla 14 Aug '17

14 Aug '17

Module: kamailio Branch: master Commit: 874a7d50779a582d1de809a3d57b4a07c3a1fbd9 URL: https://github.com/kamailio/kamailio/commit/874a7d50779a582d1de809a3d57b4a0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-14T13:26:22+02:00 topos: increased defined value for tps nr keys --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/874a7d50779a582d1de809a3d57b4a0… Patch: https://github.com/kamailio/kamailio/commit/874a7d50779a582d1de809a3d57b4a0… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index b114360739..5662b80654 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -444,7 +444,7 @@ str tt_col_b_tag = str_init("b_tag"); str tt_col_s_method = str_init("s_method"); str tt_col_s_cseq = str_init("s_cseq"); -#define TPS_NR_KEYS 32 +#define TPS_NR_KEYS 48 str _tps_empty = str_init("");

1 0

git:master:fbf8f68e: topos: load contact fields for transaction record
by Daniel-Constantin Mierla 14 Aug '17

14 Aug '17

Module: kamailio Branch: master Commit: fbf8f68ed1f8df9af7ed60cb14d379e571550a03 URL: https://github.com/kamailio/kamailio/commit/fbf8f68ed1f8df9af7ed60cb14d379e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-14T13:15:52+02:00 topos: load contact fields for transaction record --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/fbf8f68ed1f8df9af7ed60cb14d379e… Patch: https://github.com/kamailio/kamailio/commit/fbf8f68ed1f8df9af7ed60cb14d379e… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index 4f4397b918..b114360739 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -896,6 +896,8 @@ int tps_db_load_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, db_cols[nr_cols++] = &tt_col_x_tag; db_cols[nr_cols++] = &tt_col_s_method; db_cols[nr_cols++] = &tt_col_s_cseq; + db_cols[nr_cols++] = &tt_col_a_contact; + db_cols[nr_cols++] = &tt_col_b_contact; if (_tpsdbf.use_table(_tps_db_handle, &tt_table_name) < 0) { LM_ERR("failed to perform use table\n"); @@ -938,6 +940,8 @@ int tps_db_load_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, TPS_DATA_APPEND_DB(sd, db_res, n, &sd->x_tag); n++; TPS_DATA_APPEND_DB(sd, db_res, n, &sd->s_method); n++; TPS_DATA_APPEND_DB(sd, db_res, n, &sd->s_cseq); n++; + TPS_DATA_APPEND_DB(sd, db_res, n, &sd->a_contact); n++; + TPS_DATA_APPEND_DB(sd, db_res, n, &sd->b_contact); n++; done: if ((db_res!=NULL) && _tpsdbf.free_result(_tps_db_handle, db_res)<0)

1 0

git:master:5f4f5102: presence: pass pointer to subs_t for pres_update_status()
by Daniel-Constantin Mierla 14 Aug '17

14 Aug '17

Module: kamailio Branch: master Commit: 5f4f5102219ba2f3de820f795f8e1e9af64d5bf9 URL: https://github.com/kamailio/kamailio/commit/5f4f5102219ba2f3de820f795f8e1e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-14T09:10:26+02:00 presence: pass pointer to subs_t for pres_update_status() - passing content of a large structure may be inneficient at runtime --- Modified: src/modules/presence/presence.c --- Diff: https://github.com/kamailio/kamailio/commit/5f4f5102219ba2f3de820f795f8e1e9… Patch: https://github.com/kamailio/kamailio/commit/5f4f5102219ba2f3de820f795f8e1e9… --- diff --git a/src/modules/presence/presence.c b/src/modules/presence/presence.c index ad4275f64d..2b2079cc69 100644 --- a/src/modules/presence/presence.c +++ b/src/modules/presence/presence.c @@ -687,7 +687,7 @@ int ki_pres_refresh_watchers_file(sip_msg_t *msg, str *pres, str *event, return pres_refresh_watchers(pres, event, type, file_uri, filename); } -int pres_update_status(subs_t subs, str reason, db_key_t* query_cols, +int pres_update_status(subs_t *subs, str reason, db_key_t* query_cols, db_val_t* query_vals, int n_query_cols, subs_t** subs_array) { db_key_t update_cols[5]; @@ -715,29 +715,29 @@ int pres_update_status(subs_t subs, str reason, db_key_t* query_cols, update_vals[u_reason_col].type= DB1_STR; n_update_cols++; - status= subs.status; - if(subs.event->get_auth_status(&subs)< 0) + status= subs->status; + if(subs->event->get_auth_status(subs)< 0) { LM_ERR( "getting status from rules document\n"); return -1; } - LM_DBG("subs.status= %d\n", subs.status); - if(get_status_str(subs.status)== NULL) + LM_DBG("subs.status= %d\n", subs->status); + if(get_status_str(subs->status)== NULL) { - LM_ERR("wrong status: %d\n", subs.status); + LM_ERR("wrong status: %d\n", subs->status); return -1; } - if(subs.status!= status || reason.len!= subs.reason.len || - (reason.s && subs.reason.s && strncmp(reason.s, subs.reason.s, + if(subs->status!= status || reason.len!= subs->reason.len || + (reason.s && subs->reason.s && strncmp(reason.s, subs->reason.s, reason.len))) { /* update in watchers_table */ - query_vals[q_wuser_col].val.str_val= subs.watcher_user; - query_vals[q_wdomain_col].val.str_val= subs.watcher_domain; + query_vals[q_wuser_col].val.str_val= subs->watcher_user; + query_vals[q_wdomain_col].val.str_val= subs->watcher_domain; - update_vals[u_status_col].val.int_val= subs.status; - update_vals[u_reason_col].val.str_val= subs.reason; + update_vals[u_status_col].val.int_val= subs->status; + update_vals[u_reason_col].val.str_val= subs->reason; if (pa_dbf.use_table(pa_db, &watchers_table) < 0) { @@ -753,12 +753,12 @@ int pres_update_status(subs_t subs, str reason, db_key_t* query_cols, } /* save in the list all affected dialogs */ /* if status switches to terminated -> delete dialog */ - if(update_pw_dialogs(&subs, subs.db_flag, subs_array)< 0) + if(update_pw_dialogs(subs, subs->db_flag, subs_array)< 0) { LM_ERR( "extracting dialogs from [watcher]=%.*s(a)%.*s to" - " [presentity]=%.*s\n", subs.watcher_user.len, subs.watcher_user.s, - subs.watcher_domain.len, subs.watcher_domain.s, subs.pres_uri.len, - subs.pres_uri.s); + " [presentity]=%.*s\n", subs->watcher_user.len, subs->watcher_user.s, + subs->watcher_domain.len, subs->watcher_domain.s, subs->pres_uri.len, + subs->pres_uri.s); return -1; } } @@ -971,7 +971,7 @@ int update_watchers_status(str pres_uri, pres_ev_t* ev, str* rules_doc) subs.status = ws_list[i].status; memset(&subs.reason, 0, sizeof(str)); - if( pres_update_status(subs, reason, query_cols, query_vals, + if( pres_update_status(&subs, reason, query_cols, query_vals, n_query_cols, &subs_array)< 0) { LM_ERR("failed to update watcher status\n"); @@ -1014,7 +1014,7 @@ int update_watchers_status(str pres_uri, pres_ev_t* ev, str* rules_doc) subs.status= status; memset(&subs.reason, 0, sizeof(str)); - if( pres_update_status(subs,reason, query_cols, query_vals, + if( pres_update_status(&subs,reason, query_cols, query_vals, n_query_cols, &subs_array)< 0) { LM_ERR("failed to update watcher status\n");

1 0

git:master:30f1c139: modules: readme files regenerated - drouting ... [skip ci]
by Kamailio Dev 14 Aug '17

14 Aug '17

Module: kamailio Branch: master Commit: 30f1c139a144fd321f4c91928f2976a42d791733 URL: https://github.com/kamailio/kamailio/commit/30f1c139a144fd321f4c91928f2976a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-14T08:46:55+02:00 modules: readme files regenerated - drouting ... [skip ci] --- Modified: src/modules/drouting/README --- Diff: https://github.com/kamailio/kamailio/commit/30f1c139a144fd321f4c91928f2976a… Patch: https://github.com/kamailio/kamailio/commit/30f1c139a144fd321f4c91928f2976a… --- diff --git a/src/modules/drouting/README b/src/modules/drouting/README index e7e429500e..8e45c5ecf1 100644 --- a/src/modules/drouting/README +++ b/src/modules/drouting/README @@ -573,10 +573,11 @@ modparam("drouting", "drl_table", "my_gw_lists") tried in the given order; Ex: list 1,2;3,4,5;6 will lead to usage as 1,2,3,4,5,6 * 1 - the destinations from each group are randomly arranged (only - the two elements are randomly selected); groups do maintain their - order (as given); the resulting list is used (with all the defined - destinations). Ex: 1,2;3,4,5;6 -> randomizer -> (A) 2,1;4,3,5;6 -> - usage 2,1,4,3,5,6 (B) 1,2;3,5,4;6 -> usage 1,2,3,5,4,6 + the two first elements are randomly selected); groups do maintain + their order (as given); the resulting list is used (with all the + defined destinations). Ex: 1,2;3,4,5;6 -> randomizer -> (A) + 2,1;4,3,5;6 -> usage 2,1,4,3,5,6 (B) 1,2;3,5,4;6 -> usage + 1,2,3,5,4,6 * 2 - from each destination group, only a single destination is randomly selected; groups do maintain their order (as given); Ex: 1,2;3,4,5;6 -> randomizer -> @@ -699,10 +700,6 @@ modparam("drouting", "force_dns", 0) Enable monitoring of GW/destinations using keepalive module. Destinations found unavailable will not be used on do_routing() call. - NOTE: this option is only compatible with <em>sort_order</em> 0 - currently. With sort_order value of 1 or 2, destinations status will - simply be ignored. - Default value is “0 (disabled)”. Example 1.15. Set enable_keepalive parameter

1 0

git:master:361162ba: Merge pull request #1212 from gbour/drouting-w-keepalive
by GitHub 14 Aug '17

14 Aug '17

Module: kamailio Branch: master Commit: 361162ba1c5209890f2a8f1c60887a0aa7ed9783 URL: https://github.com/kamailio/kamailio/commit/361162ba1c5209890f2a8f1c60887a0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2017-08-14T08:45:24+02:00 Merge pull request #1212 from gbour/drouting-w-keepalive drouting: pull out unavailable destinations for sort_order 1 and 2 --- Modified: src/modules/drouting/doc/drouting_admin.xml Modified: src/modules/drouting/drouting.c --- Diff: https://github.com/kamailio/kamailio/commit/361162ba1c5209890f2a8f1c60887a0… Patch: https://github.com/kamailio/kamailio/commit/361162ba1c5209890f2a8f1c60887a0…

1 0

git:master:9875e64a: drouting: pull out unavailable destinations for sort_order 1 and 2
by Guillaume Bour 14 Aug '17

14 Aug '17

Module: kamailio Branch: master Commit: 9875e64a95da6186ab616f1c560fc245916ac517 URL: https://github.com/kamailio/kamailio/commit/9875e64a95da6186ab616f1c560fc24… Author: Guillaume Bour <guillaume(a)bour.cc> Committer: Guillaume Bour <guillaume(a)bour.cc> Date: 2017-08-10T21:35:54+02:00 drouting: pull out unavailable destinations for sort_order 1 and 2 - destinations are monitored with keepalive module (when 'enable_keepalive' option is set) - it was already supported for sort_order 0 in a previous commit --- Modified: src/modules/drouting/doc/drouting_admin.xml Modified: src/modules/drouting/drouting.c --- Diff: https://github.com/kamailio/kamailio/commit/9875e64a95da6186ab616f1c560fc24… Patch: https://github.com/kamailio/kamailio/commit/9875e64a95da6186ab616f1c560fc24…

1 0

[kamailio/kamailio] drouting: pull out unavailable destinations for sort_order 1 and 2 (#1212)
by Guillaume Bour 14 Aug '17

14 Aug '17

#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description When destinations monitoring is enabled with option 'enable_keepalive' set to 1, unavailable destinations will be ignored when calling do_routing() function It was already implemented for sort_order 0 in a previous commit. This one adds the support for sor_order 1 & 2 also You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1212 -- Commit Summary -- * drouting: pull out unavailable destinations for sort_order 1 and 2 -- File Changes -- M src/modules/drouting/doc/drouting_admin.xml (9) M src/modules/drouting/drouting.c (62) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1212.patch https://github.com/kamailio/kamailio/pull/1212.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1212

2 2

git:master:00b2d6a1: Merge pull request #1214 from sergey-safarov/spec_update10
by GitHub 14 Aug '17

14 Aug '17

Module: kamailio Branch: master Commit: 00b2d6a170848e9e354252f9f1c3d049619efcd6 URL: https://github.com/kamailio/kamailio/commit/00b2d6a170848e9e354252f9f1c3d04… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2017-08-14T08:43:35+02:00 Merge pull request #1214 from sergey-safarov/spec_update10 pkg/kamailio/centos/7: Update CentOS spec file --- Modified: pkg/kamailio/centos/7/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/00b2d6a170848e9e354252f9f1c3d04… Patch: https://github.com/kamailio/kamailio/commit/00b2d6a170848e9e354252f9f1c3d04… --- diff --git a/pkg/kamailio/centos/7/kamailio.spec b/pkg/kamailio/centos/7/kamailio.spec index d6410c7e99..2d0099b901 100644 --- a/pkg/kamailio/centos/7/kamailio.spec +++ b/pkg/kamailio/centos/7/kamailio.spec @@ -1,6 +1,6 @@ %define name kamailio %define ver 5.1.0 -%define rel dev1%{dist} +%define rel dev6%{dist} %bcond_with dnssec @@ -191,7 +191,6 @@ This module implements protocol functions that use the libcurl to communicate wi %package http_client Summary: HTTP client module for Kamailio. Group: System Environment/Daemons -Requires: libcrypto %description http_client This module implements protocol functions that use the libcurl to communicate with HTTP servers. @@ -668,6 +667,7 @@ fi %dir %{_docdir}/kamailio/modules %doc %{_docdir}/kamailio/modules/README.acc +%doc %{_docdir}/kamailio/modules/README.acc_diameter %doc %{_docdir}/kamailio/modules/README.alias_db %doc %{_docdir}/kamailio/modules/README.app_jsdt %doc %{_docdir}/kamailio/modules/README.async @@ -810,6 +810,7 @@ fi %dir %{_libdir}/kamailio/modules %{_libdir}/kamailio/modules/acc.so +%{_libdir}/kamailio/modules/acc_diameter.so %{_libdir}/kamailio/modules/alias_db.so %{_libdir}/kamailio/modules/app_jsdt.so %{_libdir}/kamailio/modules/async.so

1 0

git:master:363cc61d: pkg/kamailio/centos/7: Update CentOS spec file
by Sergey Safarov 14 Aug '17

14 Aug '17

Module: kamailio Branch: master Commit: 363cc61d63fac8e4a9bcf4f7994de30f6a30b73d URL: https://github.com/kamailio/kamailio/commit/363cc61d63fac8e4a9bcf4f7994de30… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2017-08-13T12:05:34-04:00 pkg/kamailio/centos/7: Update CentOS spec file --- Modified: pkg/kamailio/centos/7/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/363cc61d63fac8e4a9bcf4f7994de30… Patch: https://github.com/kamailio/kamailio/commit/363cc61d63fac8e4a9bcf4f7994de30… --- diff --git a/pkg/kamailio/centos/7/kamailio.spec b/pkg/kamailio/centos/7/kamailio.spec index d6410c7e99..2d0099b901 100644 --- a/pkg/kamailio/centos/7/kamailio.spec +++ b/pkg/kamailio/centos/7/kamailio.spec @@ -1,6 +1,6 @@ %define name kamailio %define ver 5.1.0 -%define rel dev1%{dist} +%define rel dev6%{dist} %bcond_with dnssec @@ -191,7 +191,6 @@ This module implements protocol functions that use the libcurl to communicate wi %package http_client Summary: HTTP client module for Kamailio. Group: System Environment/Daemons -Requires: libcrypto %description http_client This module implements protocol functions that use the libcurl to communicate with HTTP servers. @@ -668,6 +667,7 @@ fi %dir %{_docdir}/kamailio/modules %doc %{_docdir}/kamailio/modules/README.acc +%doc %{_docdir}/kamailio/modules/README.acc_diameter %doc %{_docdir}/kamailio/modules/README.alias_db %doc %{_docdir}/kamailio/modules/README.app_jsdt %doc %{_docdir}/kamailio/modules/README.async @@ -810,6 +810,7 @@ fi %dir %{_libdir}/kamailio/modules %{_libdir}/kamailio/modules/acc.so +%{_libdir}/kamailio/modules/acc_diameter.so %{_libdir}/kamailio/modules/alias_db.so %{_libdir}/kamailio/modules/app_jsdt.so %{_libdir}/kamailio/modules/async.so

1 0

[kamailio/kamailio] pkg/kamailio/centos/7: Update CentOS spec file (#1214)
by sergey-safarov 14 Aug '17

14 Aug '17

update version suffix added unpackaged `acc_diameter` files removed dependency to not existed package `libcrypto ` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1214 -- Commit Summary -- * pkg/kamailio/centos/7: Update CentOS spec file -- File Changes -- M pkg/kamailio/centos/7/kamailio.spec (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1214.patch https://github.com/kamailio/kamailio/pull/1214.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1214

2 2

[kamailio/kamailio] `advertise` keyword not take effect when `listen` is bounded NIC name (#1209)
by sergey-safarov 13 Aug '17

13 Aug '17

Tested on e5b8066e1e0f4a69a5d1161dd75aea67014314b5 commit -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1209

2 10

git:master:97d8ebc9: sipcapture: safety checks for values inside w_float2int()
by Daniel-Constantin Mierla 13 Aug '17

13 Aug '17

Module: kamailio Branch: master Commit: 97d8ebc966aba71efb3a964e71b00736db51401b URL: https://github.com/kamailio/kamailio/commit/97d8ebc966aba71efb3a964e71b0073… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-13T11:07:42+02:00 sipcapture: safety checks for values inside w_float2int() --- Modified: src/modules/sipcapture/sipcapture.c --- Diff: https://github.com/kamailio/kamailio/commit/97d8ebc966aba71efb3a964e71b0073… Patch: https://github.com/kamailio/kamailio/commit/97d8ebc966aba71efb3a964e71b0073… --- diff --git a/src/modules/sipcapture/sipcapture.c b/src/modules/sipcapture/sipcapture.c index 8fb9deb16b..fdd736e7f9 100644 --- a/src/modules/sipcapture/sipcapture.c +++ b/src/modules/sipcapture/sipcapture.c @@ -1039,6 +1039,9 @@ static int w_float2int(struct sip_msg* _m, char* _val, char* _coof, char* s2) return -1; } + if(value.s==NULL || coof.s==NULL) + return -1; + ret = (int) (atof (value.s) * atoi(coof.s)); return ret ? ret : -1;

1 0

git:master:bb536c3d: rls: proper handling of return code for parse from/to uri
by Daniel-Constantin Mierla 12 Aug '17

12 Aug '17

Module: kamailio Branch: master Commit: bb536c3dae01865c42e556989e8aca5be85b20fe URL: https://github.com/kamailio/kamailio/commit/bb536c3dae01865c42e556989e8aca5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-12T08:48:21+02:00 rls: proper handling of return code for parse from/to uri --- Modified: src/modules/rls/rls.c Modified: src/modules/rls/subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/bb536c3dae01865c42e556989e8aca5… Patch: https://github.com/kamailio/kamailio/commit/bb536c3dae01865c42e556989e8aca5… --- diff --git a/src/modules/rls/rls.c b/src/modules/rls/rls.c index 86f9bf3c9f..d16d3a24a4 100644 --- a/src/modules/rls/rls.c +++ b/src/modules/rls/rls.c @@ -1023,8 +1023,7 @@ int rls_restore_db_subs(void) return 0; error: - if(res) - rls_dbf.free_result(rls_db, res); + rls_dbf.free_result(rls_db, res); return -1; } diff --git a/src/modules/rls/subscribe.c b/src/modules/rls/subscribe.c index 6ce59d58e3..b08e55e6f2 100644 --- a/src/modules/rls/subscribe.c +++ b/src/modules/rls/subscribe.c @@ -440,7 +440,7 @@ int rls_handle_subscribe0(struct sip_msg* msg) { struct to_body *pfrom; - if (parse_from_uri(msg) < 0) + if (parse_from_uri(msg) == NULL) { LM_ERR("failed to find From header\n"); if (slb.freply(msg, 400, &pu_400_rpl) < 0) @@ -507,7 +507,7 @@ int rls_handle_subscribe(struct sip_msg* msg, str watcher_user, str watcher_doma return 0; } /* check for To and From headesr */ - if(parse_to_uri(msg)<0 || parse_from_uri(msg)<0) + if(parse_to_uri(msg)==NULL || parse_from_uri(msg)==NULL) { LM_ERR("failed to find To or From headers\n"); if (slb.freply(msg, 400, &pu_400_rpl) < 0)

1 0

git:master:3d2359b5: rls: replace sprintf with safer snprintf
by Daniel-Constantin Mierla 12 Aug '17

12 Aug '17

Module: kamailio Branch: master Commit: 3d2359b5a349efe4d6571ec0953e5c4aae54a165 URL: https://github.com/kamailio/kamailio/commit/3d2359b5a349efe4d6571ec0953e5c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-12T08:59:06+02:00 rls: replace sprintf with safer snprintf - compact printing headers in 200ok function by doing it once in a snprintf, instead of combination of many sprintf and strncpy --- Modified: src/modules/rls/subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/3d2359b5a349efe4d6571ec0953e5c4… Patch: https://github.com/kamailio/kamailio/commit/3d2359b5a349efe4d6571ec0953e5c4… --- diff --git a/src/modules/rls/subscribe.c b/src/modules/rls/subscribe.c index b08e55e6f2..dc76e4fdba 100644 --- a/src/modules/rls/subscribe.c +++ b/src/modules/rls/subscribe.c @@ -339,35 +339,24 @@ int reply_200(struct sip_msg* msg, str* contact, int expires) str hdr_append; int len; - hdr_append.s = (char *)pkg_malloc( sizeof(char)*(contact->len+ 70)); + hdr_append.s = (char *)pkg_malloc( sizeof(char)*(contact->len+70)); if(hdr_append.s == NULL) { LM_ERR("no more pkg memory\n"); return -1; } - hdr_append.len = sprintf(hdr_append.s, "Expires: %d\r\n", expires); - if(hdr_append.len< 0) + hdr_append.len = snprintf(hdr_append.s, contact->len+70, + "Expires: %d" CRLF + "Contact: <%.*s>" CRLF + "Require: eventlist" CRLF, + expires, + contact->len, contact->s + ); + if(hdr_append.len<0 || hdr_append.len>=contact->len+70) { - LM_ERR("unsuccessful sprintf\n"); + LM_ERR("unsuccessful snprintf\n"); goto error; } - strncpy(hdr_append.s+hdr_append.len ,"Contact: <", 10); - hdr_append.len += 10; - strncpy(hdr_append.s+hdr_append.len, contact->s, contact->len); - hdr_append.len+= contact->len; - strncpy(hdr_append.s+hdr_append.len, ">", 1); - hdr_append.len += 1; - strncpy(hdr_append.s+hdr_append.len, CRLF, CRLF_LEN); - hdr_append.len += CRLF_LEN; - - len = sprintf(hdr_append.s+ hdr_append.len, "Require: eventlist\r\n"); - if(len < 0) - { - LM_ERR("unsuccessful sprintf\n"); - goto error; - } - hdr_append.len+= len; - hdr_append.s[hdr_append.len]= '\0'; if (add_lump_rpl( msg, hdr_append.s, hdr_append.len, LUMP_RPL_HDR)==0 ) {

1 0

git:master:92daa0bb: evapi: removed unused variable
by Daniel-Constantin Mierla 12 Aug '17

12 Aug '17

Module: kamailio Branch: master Commit: 92daa0bb98e9d7c997e9f6ca4994d48134e07acc URL: https://github.com/kamailio/kamailio/commit/92daa0bb98e9d7c997e9f6ca4994d48… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-12T08:26:55+02:00 evapi: removed unused variable --- Modified: src/modules/evapi/evapi_dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/92daa0bb98e9d7c997e9f6ca4994d48… Patch: https://github.com/kamailio/kamailio/commit/92daa0bb98e9d7c997e9f6ca4994d48… --- diff --git a/src/modules/evapi/evapi_dispatch.c b/src/modules/evapi/evapi_dispatch.c index 04eab30e50..2aaaf1e6c9 100644 --- a/src/modules/evapi/evapi_dispatch.c +++ b/src/modules/evapi/evapi_dispatch.c @@ -138,8 +138,6 @@ int evapi_run_cfg_route(evapi_env_t *evenv, int rt, str *rtname) sip_msg_t *fmsg; sip_msg_t tmsg; sr_kemi_eng_t *keng = NULL; - str evname; - if(evenv==0 || evenv->eset==0) { LM_ERR("evapi env not set\n");

1 0

git:master:5be6d11e: topos_redis: removed unused variables
by Daniel-Constantin Mierla 12 Aug '17

12 Aug '17

Module: kamailio Branch: master Commit: 5be6d11ecd99670cf85cece3a534e10f3f015c52 URL: https://github.com/kamailio/kamailio/commit/5be6d11ecd99670cf85cece3a534e10… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-12T08:27:15+02:00 topos_redis: removed unused variables --- Modified: src/modules/topos_redis/topos_redis_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/5be6d11ecd99670cf85cece3a534e10… Patch: https://github.com/kamailio/kamailio/commit/5be6d11ecd99670cf85cece3a534e10… --- diff --git a/src/modules/topos_redis/topos_redis_storage.c b/src/modules/topos_redis/topos_redis_storage.c index 7753cd89c8..51c839487d 100644 --- a/src/modules/topos_redis/topos_redis_storage.c +++ b/src/modules/topos_redis/topos_redis_storage.c @@ -825,10 +825,8 @@ int tps_redis_update_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, str rcmd = str_init("HMSET"); str rkey = STR_NULL; char *rp; - str rval = STR_NULL; redisc_server_t *rsrv = NULL; redisReply *rrpl = NULL; - int32_t liflags; if(sd->a_uuid.len<=0 && sd->b_uuid.len<=0) { LM_INFO("no uuid for this message\n");

1 0

git:master:41f6d98c: acc_diameter: removed unused variable
by Daniel-Constantin Mierla 12 Aug '17

12 Aug '17

Module: kamailio Branch: master Commit: 41f6d98cc19e514de6d0aea05cc1d17be3d95065 URL: https://github.com/kamailio/kamailio/commit/41f6d98cc19e514de6d0aea05cc1d17… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-12T08:26:22+02:00 acc_diameter: removed unused variable --- Modified: src/modules/acc_diameter/diam_tcp.c --- Diff: https://github.com/kamailio/kamailio/commit/41f6d98cc19e514de6d0aea05cc1d17… Patch: https://github.com/kamailio/kamailio/commit/41f6d98cc19e514de6d0aea05cc1d17… --- diff --git a/src/modules/acc_diameter/diam_tcp.c b/src/modules/acc_diameter/diam_tcp.c index 77525479c5..59b8755ce2 100644 --- a/src/modules/acc_diameter/diam_tcp.c +++ b/src/modules/acc_diameter/diam_tcp.c @@ -95,7 +95,6 @@ int tcp_send_recv(int sfd, char* buf, int len, rd_buf_t* rb, unsigned long int result_code; AAAMessage *msg; AAA_AVP *avp; - char serviceType; unsigned int m_id; /* try to write the message to the Diameter client */ @@ -184,7 +183,6 @@ int tcp_send_recv(int sfd, char* buf, int len, rd_buf_t* rb, LM_ERR("AVP_Service_Type not found\n"); return AAA_ERROR; } - serviceType = avp->data.s[0]; result_code = ntohl(*((unsigned long int*)(msg->res_code->data.s))); switch(result_code)

1 0

git:master:85def4c2: core: tcp - print str error in debug message if faling to write to connection
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: 85def4c200e216dce5d3d8e53461a69ab408fa3c URL: https://github.com/kamailio/kamailio/commit/85def4c200e216dce5d3d8e53461a69… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T16:11:19+02:00 core: tcp - print str error in debug message if faling to write to connection --- Modified: src/core/tcp_main.c --- Diff: https://github.com/kamailio/kamailio/commit/85def4c200e216dce5d3d8e53461a69… Patch: https://github.com/kamailio/kamailio/commit/85def4c200e216dce5d3d8e53461a69… --- diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index 06812db509..09f7f4301b 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -2621,8 +2621,14 @@ static int tcpconn_1st_send(int fd, struct tcp_connection* c, ENOTCONN appears on newer FreeBSD versions (non-blocking socket, connect() & send immediately) */ if ((n>=0) || errno==EAGAIN || errno==EWOULDBLOCK || errno==ENOTCONN){ - LM_DBG("pending write on new connection %p " - "(%d/%d bytes written)\n", c, n, len); + if(n<0) { + LM_DBG("pending write on new connection %p " + "(%d/%d bytes written) (err: %d - %s)\n", c, n, len, + errno, strerror(errno)); + } else { + LM_DBG("pending write on new connection %p " + "(%d/%d bytes written)\n", c, n, len); + } if (unlikely(n<0)) n=0; else{ if (likely(c->state == S_CONN_CONNECT))

1 0

git:master:125db2c3: Merge pull request #1213 from christoph-v/ims_get_body_coredump
by GitHub 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: 125db2c3650843aae2927a4625e3d42a755fa309 URL: https://github.com/kamailio/kamailio/commit/125db2c3650843aae2927a4625e3d42… Author: ng-voice GmbH <info(a)ng-voice.com> Committer: GitHub <noreply(a)github.com> Date: 2017-08-11T15:54:28+02:00 Merge pull request #1213 from christoph-v/ims_get_body_coredump ims_auth: fixed rare core dump, due to null ptr check --- Modified: src/modules/ims_auth/utils.c --- Diff: https://github.com/kamailio/kamailio/commit/125db2c3650843aae2927a4625e3d42… Patch: https://github.com/kamailio/kamailio/commit/125db2c3650843aae2927a4625e3d42… --- diff --git a/src/modules/ims_auth/utils.c b/src/modules/ims_auth/utils.c index 2e40cf8c46..94d02e3fe7 100644 --- a/src/modules/ims_auth/utils.c +++ b/src/modules/ims_auth/utils.c @@ -204,7 +204,9 @@ str ims_get_body(struct sip_msg * msg) LM_DBG("Error parsing until header Content-Length: \n"); return x; } - x.len = (int)(long)msg->content_length->parsed; + if (msg->content_length) + // Content-Length header might be missing + x.len = (int)(long)msg->content_length->parsed; if (x.len>0) x.s = get_body(msg);

1 0

git:master:4e760394: ims_auth: fixed rare core dump, due to null ptr check
by Valentin Christoph 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: 4e760394b63ab0bf3ca6deb1d527c96f800a834d URL: https://github.com/kamailio/kamailio/commit/4e760394b63ab0bf3ca6deb1d527c96… Author: Valentin Christoph <valentin(a)kapsch.net> Committer: Valentin Christoph <valentin(a)kapsch.net> Date: 2017-08-11T14:43:36+02:00 ims_auth: fixed rare core dump, due to null ptr check The ims_auth module reads the value from the Content-Length header of a REGISTER request, before decoding the message body. Due to a missing null pointer check, reading this value leads to core dump in case the Content-Length header is missing. --- Modified: src/modules/ims_auth/utils.c --- Diff: https://github.com/kamailio/kamailio/commit/4e760394b63ab0bf3ca6deb1d527c96… Patch: https://github.com/kamailio/kamailio/commit/4e760394b63ab0bf3ca6deb1d527c96… --- diff --git a/src/modules/ims_auth/utils.c b/src/modules/ims_auth/utils.c index 2e40cf8c46..94d02e3fe7 100644 --- a/src/modules/ims_auth/utils.c +++ b/src/modules/ims_auth/utils.c @@ -204,7 +204,9 @@ str ims_get_body(struct sip_msg * msg) LM_DBG("Error parsing until header Content-Length: \n"); return x; } - x.len = (int)(long)msg->content_length->parsed; + if (msg->content_length) + // Content-Length header might be missing + x.len = (int)(long)msg->content_length->parsed; if (x.len>0) x.s = get_body(msg);

1 0

git:master:9df27ff7: tm: updated for the new shm global locking functions
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: 9df27ff7afbf1cf8ee7b3afd1741355e9f6f866e URL: https://github.com/kamailio/kamailio/commit/9df27ff7afbf1cf8ee7b3afd1741355… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T15:38:39+02:00 tm: updated for the new shm global locking functions --- Modified: src/modules/tm/h_table.c --- Diff: https://github.com/kamailio/kamailio/commit/9df27ff7afbf1cf8ee7b3afd1741355… Patch: https://github.com/kamailio/kamailio/commit/9df27ff7afbf1cf8ee7b3afd1741355… --- diff --git a/src/modules/tm/h_table.c b/src/modules/tm/h_table.c index 2e8e8e7717..19b5daec0b 100644 --- a/src/modules/tm/h_table.c +++ b/src/modules/tm/h_table.c @@ -147,7 +147,7 @@ void free_cell_helper( if(unlikely(has_tran_tmcbs(dead_cell, TMCB_DESTROY))) run_trans_callbacks(TMCB_DESTROY, dead_cell, 0, 0, 0); - shm_lock(); + shm_global_lock(); /* UA Server */ if(dead_cell->uas.request) sip_msg_free_unsafe(dead_cell->uas.request); @@ -167,9 +167,9 @@ void free_cell_helper( * otherwise the release function must to be aware of * the lock state (Miklos) */ - shm_unlock(); + shm_global_unlock(); cbs_tmp->release(cbs_tmp->param); - shm_lock(); + shm_global_lock(); } shm_free_unsafe(cbs_tmp); } @@ -250,7 +250,7 @@ void free_cell_helper( /* the cell's body */ shm_free_unsafe(dead_cell); - shm_unlock(); + shm_global_unlock(); t_stats_freed(); }

1 0

git:master:1ec69642: core: main.c - updates for shm unlock in shutdown cleanup
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: 1ec6964249dc5db4bd69c612b626466cae896c41 URL: https://github.com/kamailio/kamailio/commit/1ec6964249dc5db4bd69c612b626466… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T15:37:33+02:00 core: main.c - updates for shm unlock in shutdown cleanup - test if shm was initialized before global unlock --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/1ec6964249dc5db4bd69c612b626466… Patch: https://github.com/kamailio/kamailio/commit/1ec6964249dc5db4bd69c612b626466… --- diff --git a/src/main.c b/src/main.c index a98a35693f..b65b0020ca 100644 --- a/src/main.c +++ b/src/main.c @@ -518,10 +518,11 @@ void cleanup(int show_status) /*clean-up*/ #ifndef SHM_SAFE_MALLOC - if (_shm_lock) - shm_unlock(); /* hack: force-unlock the shared memory lock in case - some process crashed and let it locked; this will - allow an almost gracious shutdown */ + if(shm_initialized()) { + /* force-unlock the shared memory lock in case some process crashed + * and let it locked; this will allow an almost gracious shutdown */ + shm_global_unlock(); + } #endif destroy_rpcs(); destroy_modules();

1 0

git:master:13a1e6c2: core: mem/tlsf_malloc - shared memory locking implemented internally
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: 13a1e6c23576ab3797af6fefde6fcbbd2d0b83e3 URL: https://github.com/kamailio/kamailio/commit/13a1e6c23576ab3797af6fefde6fcbb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T15:31:40+02:00 core: mem/tlsf_malloc - shared memory locking implemented internally --- Modified: src/core/mem/tlsf_malloc.c --- Diff: https://github.com/kamailio/kamailio/commit/13a1e6c23576ab3797af6fefde6fcbb… Patch: https://github.com/kamailio/kamailio/commit/13a1e6c23576ab3797af6fefde6fcbb…

1 0

git:master:bccdcf3c: core: mem/q_malloc - shared memory locking implemented internally
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: bccdcf3c456ef450399be337131fcf33e97eb57a URL: https://github.com/kamailio/kamailio/commit/bccdcf3c456ef450399be337131fcf3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T15:26:25+02:00 core: mem/q_malloc - shared memory locking implemented internally --- Modified: src/core/mem/q_malloc.c --- Diff: https://github.com/kamailio/kamailio/commit/bccdcf3c456ef450399be337131fcf3… Patch: https://github.com/kamailio/kamailio/commit/bccdcf3c456ef450399be337131fcf3…

1 0

git:master:13bdd0e1: core: mem/shm - shared memory api updated to allow locking by manager
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: 13bdd0e15883a07d396210b8a372c1b51786f2a9 URL: https://github.com/kamailio/kamailio/commit/13bdd0e15883a07d396210b8a372c1b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T15:21:59+02:00 core: mem/shm - shared memory api updated to allow locking by manager - instead of generic global lock, allow memory manager to handle locking for shared memory --- Modified: src/core/mem/memapi.h Modified: src/core/mem/shm.c Modified: src/core/mem/shm.h --- Diff: https://github.com/kamailio/kamailio/commit/13bdd0e15883a07d396210b8a372c1b… Patch: https://github.com/kamailio/kamailio/commit/13bdd0e15883a07d396210b8a372c1b… --- diff --git a/src/core/mem/memapi.h b/src/core/mem/memapi.h index 198bd4d25a..dc1cd80f03 100644 --- a/src/core/mem/memapi.h +++ b/src/core/mem/memapi.h @@ -46,6 +46,9 @@ typedef void* (*sr_resize_f)(void* mbp, void* p, size_t size); #endif /*DBG_SR_MEMORY*/ +typedef void (*sr_shm_glock_f)(void* mbp); +typedef void (*sr_shm_gunlock_f)(void* mbp); + typedef void (*sr_mem_status_f)(void* mbp); typedef void (*sr_mem_info_f)(void* mbp, struct mem_info* info); typedef unsigned long (*sr_mem_available_f)(void* mbp); @@ -128,6 +131,10 @@ typedef struct sr_shm_api { sr_mem_mod_get_stats_f xmodstats; /*memory stats free per module*/ sr_mem_mod_free_stats_f xfmodstats; + /*memory managing global lock*/ + sr_shm_glock_f xglock; + /*memory managing global unlock*/ + sr_shm_gunlock_f xgunlock; } sr_shm_api_t; #endif diff --git a/src/core/mem/shm.c b/src/core/mem/shm.c index f48cf3baad..3dbc34f11a 100644 --- a/src/core/mem/shm.c +++ b/src/core/mem/shm.c @@ -48,8 +48,6 @@ void shm_core_destroy(void); static int _shm_core_shmid[SHM_CORE_POOLS_SIZE] = { -1 }; /*shared memory id*/ #endif -gen_lock_t* _shm_lock=0; - static void* _shm_core_pools_mem[SHM_CORE_POOLS_SIZE] = { (void*)-1 }; static int _shm_core_pools_num = 1; @@ -168,41 +166,6 @@ void* shm_core_get_pool(void) } /** - * init the core lock - */ -int shm_core_lock_init(void) -{ - if (_shm_lock) { - LM_DBG("shared memory lock initialized\n"); - return 0; - } - _shm_lock=shm_malloc_unsafe(sizeof(gen_lock_t)); /* skip lock_alloc, - race cond*/ - if (_shm_lock==0){ - LOG(L_CRIT, "could not allocate lock\n"); - shm_core_destroy(); - return -1; - } - if (lock_init(_shm_lock)==0){ - LOG(L_CRIT, "could not initialize lock\n"); - shm_core_destroy(); - return -1; - } - return 0; -} - -/** - * - */ -void shm_core_lock_destroy(void) -{ - if (_shm_lock){ - DBG("destroying the shared memory lock\n"); - lock_destroy(_shm_lock); /* we don't need to dealloc it*/ - } -} - -/** * */ void shm_core_destroy(void) @@ -255,6 +218,8 @@ int shm_init_api(sr_shm_api_t *ap) _shm_root.xdestroy = ap->xdestroy; _shm_root.xmodstats = ap->xmodstats; _shm_root.xfmodstats = ap->xfmodstats; + _shm_root.xglock = ap->xglock; + _shm_root.xgunlock = ap->xgunlock; return 0; } @@ -291,11 +256,10 @@ int shm_init_manager(char *name) */ void shm_destroy_manager(void) { - shm_core_lock_destroy(); if(_shm_root.xdestroy) { - _shm_root.xdestroy(); LM_DBG("destroying memory manager: %s\n", (_shm_root.mname)?_shm_root.mname:"unknown"); + _shm_root.xdestroy(); } shm_core_destroy(); } diff --git a/src/core/mem/shm.h b/src/core/mem/shm.h index 7af16be766..5d58071359 100644 --- a/src/core/mem/shm.h +++ b/src/core/mem/shm.h @@ -38,12 +38,6 @@ #include "../dprint.h" #include "../lock_ops.h" /* we don't include locking.h on purpose */ -extern gen_lock_t* _shm_lock; -#define shm_lock() lock_get(_shm_lock) -#define shm_unlock() lock_release(_shm_lock) -int shm_core_lock_init(void); -void shm_core_lock_destroy(void); - extern sr_shm_api_t _shm_root; #ifdef DBG_SR_MEMORY @@ -82,6 +76,9 @@ extern sr_shm_api_t _shm_root; # define shm_mod_get_stats(x) _shm_root.xmodstats(_shm_root.mem_block, x) # define shm_mod_free_stats(x) _shm_root.xfmodstats(x) +# define shm_global_lock() _shm_root.xglock(_shm_root.mem_block) +# define shm_global_unlock() _shm_root.xgunlock(_shm_root.mem_block) + void* shm_core_get_pool(void); int shm_init_api(sr_shm_api_t *ap);

1 0

git:master:fcff3426: core: mem/f_malloc - shared memory locking implemented internally
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: fcff3426798a925dffd32b75569b9d86e0f131c3 URL: https://github.com/kamailio/kamailio/commit/fcff3426798a925dffd32b75569b9d8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T15:24:29+02:00 core: mem/f_malloc - shared memory locking implemented internally --- Modified: src/core/mem/f_malloc.c --- Diff: https://github.com/kamailio/kamailio/commit/fcff3426798a925dffd32b75569b9d8… Patch: https://github.com/kamailio/kamailio/commit/fcff3426798a925dffd32b75569b9d8…

1 0

git:master:cc9033be: tm: use standard shm malloc to store to-tag set
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: cc9033be4cbbd5330febecaec3c5718703c0267c URL: https://github.com/kamailio/kamailio/commit/cc9033be4cbbd5330febecaec3c5718… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T15:10:38+02:00 tm: use standard shm malloc to store to-tag set --- Modified: src/modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/cc9033be4cbbd5330febecaec3c5718… Patch: https://github.com/kamailio/kamailio/commit/cc9033be4cbbd5330febecaec3c5718… --- diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index 795da9cb14..c26b5eca32 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -306,10 +306,8 @@ inline static int update_totag_set(struct cell *t, struct sip_msg *ok) } } /* that's a new to-tag -- record it */ - shm_lock(); - n=(struct totag_elem*) shm_malloc_unsafe(sizeof(struct totag_elem)); - s=(char *)shm_malloc_unsafe(tag->len); - shm_unlock(); + n=(struct totag_elem*) shm_malloc(sizeof(struct totag_elem)); + s=(char *)shm_malloc(tag->len); if (!s || !n) { LM_ERR("no more shm memory \n"); if (n) shm_free(n);

1 0

git:master:fe441c45: core: mem - fix printing shm memory manager name
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: fe441c4561a8be852c2baae6568e48ef8203210d URL: https://github.com/kamailio/kamailio/commit/fe441c4561a8be852c2baae6568e48e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T12:03:54+02:00 core: mem - fix printing shm memory manager name --- Modified: src/core/mem/shm.c --- Diff: https://github.com/kamailio/kamailio/commit/fe441c4561a8be852c2baae6568e48e… Patch: https://github.com/kamailio/kamailio/commit/fe441c4561a8be852c2baae6568e48e… --- diff --git a/src/core/mem/shm.c b/src/core/mem/shm.c index 320f3366b0..f48cf3baad 100644 --- a/src/core/mem/shm.c +++ b/src/core/mem/shm.c @@ -306,5 +306,5 @@ void shm_destroy_manager(void) void shm_print_manager(void) { LM_DBG("shm - using memory manager: %s\n", - (_pkg_root.mname)?_pkg_root.mname:"unknown"); + (_shm_root.mname)?_shm_root.mname:"unknown"); }

1 0

git:master:751c181f: core: new parameter - verbose_startup
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: 751c181fe4477861e3aa300b78e115b8642d12f4 URL: https://github.com/kamailio/kamailio/commit/751c181fe4477861e3aa300b78e115b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T12:07:27+02:00 core: new parameter - verbose_startup - control if printing routing tree and udp probing buffer debug messages should be printed at startup - default 0 (don't print); set to 1 to get those debug messages --- Modified: src/core/cfg.lex Modified: src/core/cfg.y Modified: src/core/globals.h Modified: src/core/route.c Modified: src/core/udp_server.c Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/751c181fe4477861e3aa300b78e115b… Patch: https://github.com/kamailio/kamailio/commit/751c181fe4477861e3aa300b78e115b…

1 0

git:master:401ec2f7: core: mem - initial framework to support many shm pools
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: 401ec2f71fd237b3974114803cb61030172240ae URL: https://github.com/kamailio/kamailio/commit/401ec2f71fd237b3974114803cb6103… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T11:36:58+02:00 core: mem - initial framework to support many shm pools --- Modified: src/core/mem/shm.c --- Diff: https://github.com/kamailio/kamailio/commit/401ec2f71fd237b3974114803cb6103… Patch: https://github.com/kamailio/kamailio/commit/401ec2f71fd237b3974114803cb6103…

1 0

git:master:eb277e85: core: mem - extend pkg/shm init function for latest api fields
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: eb277e854d94eaca3a29d0856e9c903d04df0fd5 URL: https://github.com/kamailio/kamailio/commit/eb277e854d94eaca3a29d0856e9c903… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T11:06:24+02:00 core: mem - extend pkg/shm init function for latest api fields --- Modified: src/core/mem/pkg.c Modified: src/core/mem/shm.c --- Diff: https://github.com/kamailio/kamailio/commit/eb277e854d94eaca3a29d0856e9c903… Patch: https://github.com/kamailio/kamailio/commit/eb277e854d94eaca3a29d0856e9c903… --- diff --git a/src/core/mem/pkg.c b/src/core/mem/pkg.c index 53166ac932..f1e616eca6 100644 --- a/src/core/mem/pkg.c +++ b/src/core/mem/pkg.c @@ -39,8 +39,10 @@ int pkg_init_api(sr_pkg_api_t *ap) _pkg_root.mem_pool = ap->mem_pool; _pkg_root.mem_block = ap->mem_block; _pkg_root.xmalloc = ap->xmalloc; + _pkg_root.xmallocxz = ap->xmallocxz; _pkg_root.xfree = ap->xfree; _pkg_root.xrealloc = ap->xrealloc; + _pkg_root.xreallocxf = ap->xreallocxf; _pkg_root.xstatus = ap->xstatus; _pkg_root.xinfo = ap->xinfo; _pkg_root.xavailable = ap->xavailable; diff --git a/src/core/mem/shm.c b/src/core/mem/shm.c index e4f4ad6f17..8a2e93b92f 100644 --- a/src/core/mem/shm.c +++ b/src/core/mem/shm.c @@ -211,10 +211,12 @@ int shm_init_api(sr_shm_api_t *ap) _shm_root.mem_pool = ap->mem_pool; _shm_root.mem_block = ap->mem_block; _shm_root.xmalloc = ap->xmalloc; + _shm_root.xmallocxz = ap->xmallocxz; _shm_root.xmalloc_unsafe = ap->xmalloc_unsafe; _shm_root.xfree = ap->xfree; _shm_root.xfree_unsafe = ap->xfree_unsafe; _shm_root.xrealloc = ap->xrealloc; + _shm_root.xreallocxf = ap->xreallocxf; _shm_root.xresize = ap->xresize; _shm_root.xstatus = ap->xstatus; _shm_root.xinfo = ap->xinfo;

1 0

git:master:2415416d: sms: avoid overflowing ending 0 by sprintf()
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: 2415416df6bd4c599c7fde57fbaa541e2e37f9c7 URL: https://github.com/kamailio/kamailio/commit/2415416df6bd4c599c7fde57fbaa541… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T10:21:08+02:00 sms: avoid overflowing ending 0 by sprintf() --- Modified: src/modules/sms/libsms_getsms.c --- Diff: https://github.com/kamailio/kamailio/commit/2415416df6bd4c599c7fde57fbaa541… Patch: https://github.com/kamailio/kamailio/commit/2415416df6bd4c599c7fde57fbaa541… --- diff --git a/src/modules/sms/libsms_getsms.c b/src/modules/sms/libsms_getsms.c index 62efe0bfb6..e8c7590456 100644 --- a/src/modules/sms/libsms_getsms.c +++ b/src/modules/sms/libsms_getsms.c @@ -275,6 +275,8 @@ static int splitascii(struct modem *mdm, char *source, struct incame_sms *sms) { char* start; char* end; + char tbuf[TIME_LEN+1]; + char dbuf[DATE_LEN+1]; /* the text is after the \r */ for( start=source ; *start && *start!='\r' ; start++ ); @@ -312,12 +314,14 @@ static int splitascii(struct modem *mdm, char *source, struct incame_sms *sms) } /* Get the date */ start=end+3; - sprintf(sms->date,"%c%c-%c%c-%c%c",start[3],start[4],start[0],start[1], + sprintf(dbuf,"%c%c-%c%c-%c%c",start[3],start[4],start[0],start[1], start[6],start[7]); + memcpy(sms->date, dbuf, DATE_LEN); /* Get the time */ start+=9; - sprintf(sms->time,"%c%c:%c%c:%c%c",start[0],start[1],start[3],start[4], + sprintf(tbuf,"%c%c:%c%c:%c%c",start[0],start[1],start[3],start[4], start[7],start[7]); + memcpy(sms->time, tbuf, TIME_LEN); sms->userdatalength=strlen(sms->ascii); return 1; } @@ -418,9 +422,13 @@ static int splitpdu(struct modem *mdm, char* pdu, struct incame_sms *sms) if (end!=0) { memcpy(sms->name,start,end-start); sms->name[end-start]=0; + } else { + /*Unsupported type*/ + return -1; } - } else + } else { end=pdu; + } /* the pdu is after the first \r */ for( start=end+1 ; *start && *start!='\r' ; start++ );

1 0

git:master:617e8c40: acc_diameter: few updates to make cleaner avp handling
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: 617e8c40608c5e2ac97dd4b39d9ab739a779b9bb URL: https://github.com/kamailio/kamailio/commit/617e8c40608c5e2ac97dd4b39d9ab73… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T09:46:29+02:00 acc_diameter: few updates to make cleaner avp handling --- Modified: src/modules/acc_diameter/diam_avp.c Modified: src/modules/acc_diameter/diam_message.c Modified: src/modules/acc_diameter/diam_tcp.c --- Diff: https://github.com/kamailio/kamailio/commit/617e8c40608c5e2ac97dd4b39d9ab73… Patch: https://github.com/kamailio/kamailio/commit/617e8c40608c5e2ac97dd4b39d9ab73… --- diff --git a/src/modules/acc_diameter/diam_avp.c b/src/modules/acc_diameter/diam_avp.c index f9d98dc61d..2ea5a577fa 100644 --- a/src/modules/acc_diameter/diam_avp.c +++ b/src/modules/acc_diameter/diam_avp.c @@ -107,7 +107,7 @@ AAA_AVP* AAACreateAVP( size_t length, AVPDataStatus data_status) { - AAA_AVP *avp; + AAA_AVP *avp = NULL; /* first check the params */ if( data==0 || length==0) { @@ -146,7 +146,8 @@ AAA_AVP* AAACreateAVP( return avp; error: - LM_ERR("no more free memoryfor a new AVP!\n"); + LM_ERR("no more free memory for a new AVP!\n"); + if(avp) ad_free(avp); return 0; } diff --git a/src/modules/acc_diameter/diam_message.c b/src/modules/acc_diameter/diam_message.c index 07b441d969..614318b26d 100644 --- a/src/modules/acc_diameter/diam_message.c +++ b/src/modules/acc_diameter/diam_message.c @@ -293,11 +293,15 @@ AAAMessage* AAATranslateMessage( unsigned char* source, unsigned int sourceLen, /* create the AVP */ avp = AAACreateAVP( avp_code, avp_flags, avp_vendorID, (char*)ptr, avp_data_len, AVP_DONT_FREE_DATA); - if (!avp) + if (!avp) { + LM_ERR("failed to create aaa avp\n"); goto error; + } /* link the avp into aaa message to the end */ - AAAAddAVPToMessage( msg, avp, msg->avpList.tail); + if(AAAAddAVPToMessage( msg, avp, msg->avpList.tail)!= AAA_ERR_SUCCESS) { + LM_ERR("failed to add aaa avp to message\n"); + goto error; } ptr += to_32x_len( avp_data_len ); } diff --git a/src/modules/acc_diameter/diam_tcp.c b/src/modules/acc_diameter/diam_tcp.c index 724383d682..77525479c5 100644 --- a/src/modules/acc_diameter/diam_tcp.c +++ b/src/modules/acc_diameter/diam_tcp.c @@ -48,13 +48,13 @@ /*! \brief TCP connection setup */ int init_mytcp(char* host, int port) { - int sockfd; + int sfd; struct sockaddr_in serv_addr; struct hostent *server; - sockfd = socket(PF_INET, SOCK_STREAM, 0); + sfd = socket(PF_INET, SOCK_STREAM, 0); - if (sockfd < 0) + if (sfd < 0) { LM_ERR("failed to create the socket\n"); return -1; @@ -64,6 +64,7 @@ int init_mytcp(char* host, int port) if (server == NULL) { LM_ERR("failed to find the host\n"); + close(sfd); return -1; } @@ -73,18 +74,19 @@ int init_mytcp(char* host, int port) server->h_length); serv_addr.sin_port = htons(port); - if (connect(sockfd, (const struct sockaddr *)&serv_addr, + if (connect(sfd, (const struct sockaddr *)&serv_addr, sizeof(serv_addr)) < 0) { LM_ERR("failed to connec to the DIAMETER client\n"); + close(sfd); return -1; } - return sockfd; + return sfd; } /*! \brief send a message over an already opened TCP connection */ -int tcp_send_recv(int sockfd, char* buf, int len, rd_buf_t* rb, +int tcp_send_recv(int sfd, char* buf, int len, rd_buf_t* rb, unsigned int waited_id) { int n, number_of_tries; @@ -97,7 +99,7 @@ int tcp_send_recv(int sockfd, char* buf, int len, rd_buf_t* rb, unsigned int m_id; /* try to write the message to the Diameter client */ - while( (n=write(sockfd, buf, len))==-1 ) + while( (n=write(sfd, buf, len))==-1 ) { if (errno==EINTR) continue; @@ -116,26 +118,26 @@ int tcp_send_recv(int sockfd, char* buf, int len, rd_buf_t* rb, /* Initialize the set of active sockets. */ FD_ZERO (&active_fd_set); - FD_SET (sockfd, &active_fd_set); + FD_SET (sfd, &active_fd_set); number_of_tries = 0; while(number_of_tries<MAX_TRIES) { read_fd_set = active_fd_set; - if (select (sockfd+1, &read_fd_set, NULL, NULL, &tv) < 0) + if (select (sfd+1, &read_fd_set, NULL, NULL, &tv) < 0) { LM_ERR("select function failed\n"); return AAA_ERROR; } - /* if (!FD_ISSET (sockfd, &read_fd_set)) + /* if (!FD_ISSET (sfd, &read_fd_set)) { LM_ERR("no response received\n"); // return AAA_ERROR; } */ /* Data arriving on a already-connected socket. */ reset_read_buffer(rb); - switch( do_read(sockfd, rb) ) + switch( do_read(sfd, rb) ) { case CONN_ERROR: LM_ERR("failed to read from socket\n");

1 0

git:master:26c94b32: topos: per contact and rr specific processing for receiving PRACK
by Daniel-Constantin Mierla 11 Aug '17

11 Aug '17

Module: kamailio Branch: master Commit: 26c94b32baec05a064beca7064e2f44eff9ca3ef URL: https://github.com/kamailio/kamailio/commit/26c94b32baec05a064beca7064e2f44… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-11T09:14:27+02:00 topos: per contact and rr specific processing for receiving PRACK - records are taken from INVITE branch record --- Modified: src/modules/topos/tps_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/26c94b32baec05a064beca7064e2f44… Patch: https://github.com/kamailio/kamailio/commit/26c94b32baec05a064beca7064e2f44… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index ca360a975c..228996960e 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -774,20 +774,24 @@ int tps_request_received(sip_msg_t *msg, int dialog) if(tps_storage_load_dialog(msg, &mtsd, &stsd)<0) { goto error; } + /* detect direction - via from-tag */ + if(tps_dlg_detect_direction(msg, &stsd, &direction) < 0) { + goto error; + } } - /* detect direction - via from-tag */ - if(tps_dlg_detect_direction(msg, &stsd, &direction)<0) { - goto error; - } mtsd.direction = direction; tps_storage_lock_release(&lkey); - if(direction == TPS_DIR_UPSTREAM) { - nuri = stsd.a_contact; - } else { + if(use_branch) { nuri = stsd.b_contact; + } else { + if(direction == TPS_DIR_UPSTREAM) { + nuri = stsd.a_contact; + } else { + nuri = stsd.b_contact; + } } if(nuri.len>0) { if(rewrite_uri(msg, &nuri)<0) { @@ -796,31 +800,28 @@ int tps_request_received(sip_msg_t *msg, int dialog) } } - if(tps_reappend_route(msg, &stsd, &stsd.s_rr, - (direction==TPS_DIR_UPSTREAM)?0:1)<0) { - LM_ERR("failed to reappend s-route\n"); - return -1; - } - if(direction == TPS_DIR_UPSTREAM) { - if(use_branch) { - if(tps_reappend_route(msg, &stsd, &stsd.x_rr, 0)<0) { - LM_ERR("failed to reappend x-route\n"); - return -1; - } - } else { - if(tps_reappend_route(msg, &stsd, &stsd.a_rr, 0)<0) { - LM_ERR("failed to reappend a-route\n"); - return -1; - } + if(use_branch) { + if(tps_reappend_route(msg, &stsd, &stsd.s_rr, 1) < 0) { + LM_ERR("failed to reappend s-route\n"); + return -1; + } + if(tps_reappend_route(msg, &stsd, &stsd.y_rr, 1) < 0) { + LM_ERR("failed to reappend b-route\n"); + return -1; } } else { - if(use_branch) { - if(tps_reappend_route(msg, &stsd, &stsd.y_rr, 1)<0) { - LM_ERR("failed to reappend b-route\n"); + if(tps_reappend_route(msg, &stsd, &stsd.s_rr, + (direction == TPS_DIR_UPSTREAM) ? 0 : 1) < 0) { + LM_ERR("failed to reappend s-route\n"); + return -1; + } + if(direction == TPS_DIR_UPSTREAM) { + if(tps_reappend_route(msg, &stsd, &stsd.a_rr, 0) < 0) { + LM_ERR("failed to reappend a-route\n"); return -1; } } else { - if(tps_reappend_route(msg, &stsd, &stsd.b_rr, 1)<0) { + if(tps_reappend_route(msg, &stsd, &stsd.b_rr, 1) < 0) { LM_ERR("failed to reappend b-route\n"); return -1; }

1 0

[kamailio/kamailio] Kamailio 5.0.2 suddenly stops processing traffic, then generates a core when restarting. (#1172)
by Joel Serrano 10 Aug '17

10 Aug '17

### Description Kamailio suddenly stops working (this is a production server so debug logging is disabled), when we restart it a core is generated and a segfault is logged. ### Troubleshooting The only thing I have seen is some reference to IPv6 in the backtrace. But no idea where to start looking. I'm pretty sure we will need more information, but I don't know how to read or understand backtraces, please let me know what you see in it so I can dig deeper into this problem. #### Reproduction I don't know how to reproduce yet, first I have to understand the cause. #### Debugging Data Backtrace: ``` [New LWP 12052] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/sbin/kamailio -P /var/run/kamailio/kamailio.pid -f /etc/kamailio/sbc.cfg -'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007efcf3b5df69 in ?? () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1 #0 0x00007efcf3b5df69 in ?? () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1 No symbol table info available. #1 0x00007efcf3b5e234 in OPENSSL_cleanup () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1 No symbol table info available. #2 0x00007efcf7721910 in __run_exit_handlers (status=0, listp=0x7efcf7a855d8 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:83 atfct = <optimized out> onfct = <optimized out> cxafct = <optimized out> f = <optimized out> #3 0x00007efcf772196a in __GI_exit (status=<optimized out>) at exit.c:105 No locals. #4 0x000055f0a9483d54 in handle_sigs () at main.c:699 chld = 845005216 chld_status = 845005248 any_chld_stopped = 32766 memlog = 0 __func__ = "handle_sigs" #5 0x000055f0a948ea43 in main_loop () at main.c:1758 i = 8 pid = 12091 si = 0x0 si_desc = "udp receiver child=7 sock=[2602:FF37:0:1:0:0:C601:377A]:5060\000\367v\215\200\262+\363\372~\000\000\025\067\236\003\000\000\000\000\300\017H\251\360U\000\000\340\305]2\376\177", '\000' <repeats 18 times>, "\020\303]2\376\177\000\000a\202g\251\360U\000" nrprocs = 8 woneinit = 1 __func__ = "main_loop" #6 0x000055f0a9494fb9 in main (argc=13, argv=0x7ffe325dc5e8) at main.c:2646 cfg_stream = 0x55f0aa7fb010 c = -1 r = 0 tmp = 0x7ffe325dceb6 "" tmp_len = -133383536 port = 32508 proto = 845006016 options = 0x55f0a97d80e8 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 3679304743 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x0 p = 0xffffffff <error: Cannot access memory at address 0xffffffff> st = {st_dev = 19, st_ino = 14769, st_nlink = 2, st_mode = 16832, st_uid = 109, st_gid = 113, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1498523393, tv_nsec = 731915583}, st_mtim = {tv_sec = 1498533865, tv_nsec = 274210743}, st_ctim = {tv_sec = 1498533865, tv_nsec = 274210743}, __glibc_reserved = {0, 0, 0}} __func__ = "main" ``` Info locals: ``` [New LWP 12052] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/sbin/kamailio -P /var/run/kamailio/kamailio.pid -f /etc/kamailio/sbc.cfg -'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007efcf3b5df69 in ?? () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1 No symbol table info available. ``` List: ``` [New LWP 12052] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/sbin/kamailio -P /var/run/kamailio/kamailio.pid -f /etc/kamailio/sbc.cfg -'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007efcf3b5df69 in ?? () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1 ``` #### Log Messages We have regular logging with no issues, then suddenly we get: ``` Jun 28 01:57:51 kam-1 sbc[12075]: WARNING: <script>: [DISPATCHER] - Destination down: OPTIONS sip:A.A.A.A:5060 (<null>) Jun 28 01:57:51 kam-1 sbc[12075]: WARNING: <script>: [DISPATCHER] - Destination down: OPTIONS sip:B.B.B.B:5060 (<null>) Jun 28 01:58:40 kam-1 sbc[12076]: NOTICE: <script>: Node unavailable, trying next sip:A.A.A.A:5060 - M=INVITE R=sip:+12345678900@A.A.A.A:5060 ID=334f3vqDtj Jun 28 01:58:40 kam-1 sbc[12076]: NOTICE: <script>: Forwarding request - M=INVITE R=sip:+12345678900@A.A.A.A:5060 ID=334f3vqDtj Jun 28 01:58:55 kam-1 sbc[12075]: WARNING: dialog [dlg_handlers.c:1574]: dlg_ontimeout(): timeout for dlg with CallID '00g4gNy5KZ' and tags 'FHmrD-CM3' 'SZ3a5Sg58c5pB' Jun 28 01:58:55 kam-1 sbc[12075]: WARNING: dialog [dlg_handlers.c:1574]: dlg_ontimeout(): timeout for dlg with CallID 'Kj7uLRzJfd' and tags 'wRSVjfGaT' 'yQHvjNaZ5Z3rc' Jun 28 01:58:55 kam-1 sbc[12075]: WARNING: dialog [dlg_handlers.c:1574]: dlg_ontimeout(): timeout for dlg with CallID 'S5QUIXtS6-' and tags 'FV4ySEouz' 'eS7F910ycNg8H' Jun 28 01:59:10 kam-1 sbc[12075]: ERROR: <script>: No available gateways - M=INVITE R=sip:+12345678900@B.B.B.B:5060 ID=334f3vqDtj Jun 28 02:01:45 kam-1 sbc[12080]: NOTICE: dialog [dlg_hash.c:248]: dlg_clean_run(): dialog in delete state is too old (0x7efaf3904008 ref 1) Jun 28 02:03:15 kam-1 sbc[12080]: NOTICE: dialog [dlg_hash.c:248]: dlg_clean_run(): dialog in delete state is too old (0x7efaf40f0f50 ref 1) Jun 28 02:04:45 kam-1 sbc[12080]: NOTICE: dialog [dlg_hash.c:248]: dlg_clean_run(): dialog in delete state is too old (0x7efaf4d92108 ref 1) Jun 28 02:55:59 kam-1 sbc[12071]: INFO: <core> [main.c:823]: sig_usr(): signal 15 received Jun 28 02:55:59 kam-1 sbc[12052]: NOTICE: <core> [main.c:696]: handle_sigs(): Thank you for flying kamailio!!! ``` NOTE: The process stops logging at 02:04:45, then at 02:55:59 we manually restart kamailio and a core is generated. Also, in `dmesg` we have: ``` [138953.744199] kamailio[12052]: segfault at 7efaf32f51b8 ip 00007efcf3b5df69 sp 00007ffe325dc0c0 error 4 in libcrypto.so.1.1[7efcf39f6000+265000] ``` #### SIP Traffic I don't have sip traffic, If required I can start capturing it. ### Additional Information ``` # kamailio -v version: kamailio 5.0.2 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 # ``` ``` # dpkg -l | grep kamailio ii kamailio 5.0.2+stretch amd64 very fast, dynamic and configurable SIP server ii kamailio-dbg:amd64 5.0.2+stretch amd64 very fast and configurable SIP server [debug symbols] ii kamailio-extra-modules:amd64 5.0.2+stretch amd64 Extra modules for the Kamailio SIP Server ii kamailio-tls-modules:amd64 5.0.2+stretch amd64 TLS support for the Kamailio SIP server (authentication, transport) # ``` ``` # dpkg -l |grep libssl ii libssl1.0.2:amd64 1.0.2l-2 amd64 Secure Sockets Layer toolkit - shared libraries ii libssl1.1:amd64 1.1.0f-3 amd64 Secure Sockets Layer toolkit - shared libraries# ``` * **Operating System**: ``` # uname -a Linux kam-1 4.9.0-3-amd64 #1 SMP Debian 4.9.30-2+deb9u1 (2017-06-18) x86_64 GNU/Linux ``` ``` # lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 9.0 (stretch) Release: 9.0 Codename: stretch # ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1172

2 25

git:master:a3e80032: core: store advertise addr for new sockets created from interface name
by Daniel-Constantin Mierla 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: a3e8003274ded1420d2af677246a48ef5c743a3c URL: https://github.com/kamailio/kamailio/commit/a3e8003274ded1420d2af677246a48e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T14:05:13+02:00 core: store advertise addr for new sockets created from interface name - reported by GH #1209 --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/a3e8003274ded1420d2af677246a48e… Patch: https://github.com/kamailio/kamailio/commit/a3e8003274ded1420d2af677246a48e… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index ee33d915f4..a50cfe3e59 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -1353,13 +1353,15 @@ static int fix_hostname(str* name, struct ip_addr* address, str* address_str, * return 0 on succes, -1 on error */ static int addr_info_to_si_lst(struct addr_info* ai_lst, unsigned short port, - char proto, enum si_flags flags, + char proto, char *usename, + unsigned short useport, + enum si_flags flags, struct socket_info** list) { struct addr_info* ail; for (ail=ai_lst; ail; ail=ail->next){ - if(new_sock2list(ail->name.s, 0, port, proto, 0, 0, + if(new_sock2list(ail->name.s, 0, port, proto, usename, useport, ail->flags | flags, list)==0) return -1; } @@ -1374,7 +1376,10 @@ static int addr_info_to_si_lst(struct addr_info* ai_lst, unsigned short port, */ static int addr_info_to_si_lst_after(struct addr_info* ai_lst, unsigned short port, - char proto, enum si_flags flags, + char proto, + char *usename, + unsigned short useport, + enum si_flags flags, struct socket_info* el) { struct addr_info* ail; @@ -1382,7 +1387,7 @@ static int addr_info_to_si_lst_after(struct addr_info* ai_lst, for (ail=ai_lst; ail; ail=ail->next){ if((new_si=new_sock2list_after(ail->name.s, 0, port, proto, - 0, 0, ail->flags | flags, el))==0) + usename, useport, ail->flags | flags, el))==0) return -1; el=new_si; } @@ -1447,7 +1452,8 @@ static int fix_socket_list(struct socket_info **list, int* type_flags) }else{ /* add all addr. as separate interfaces */ if (addr_info_to_si_lst_after(ai_lst, si->port_no, si->proto, - si->flags, si)!=0) + si->useinfo.name.s, si->useinfo.port_no, + si->flags, si)!=0) goto error; /* ai_lst not needed anymore */ free_addr_info_lst(&ai_lst); @@ -1758,7 +1764,7 @@ int fix_all_socket_lists() #else && ( !auto_bind_ipv6 || add_interfaces(0, AF_INET6, 0, PROTO_UDP, &ai_lst) ==0 ) /* add_interface does not work for IPv6 on Linux */ #endif /* __OS_linux */ - ) && (addr_info_to_si_lst(ai_lst, 0, PROTO_UDP, 0, &udp_listen)==0)){ + ) && (addr_info_to_si_lst(ai_lst, 0, PROTO_UDP, 0, 0, 0, &udp_listen)==0)){ free_addr_info_lst(&ai_lst); ai_lst=0; /* if ok, try to add the others too */ @@ -1770,7 +1776,7 @@ int fix_all_socket_lists() #else || (auto_bind_ipv6 && add_interfaces(0, AF_INET6, 0, PROTO_TCP, &ai_lst) !=0 ) #endif /* __OS_linux */ - ) || (addr_info_to_si_lst(ai_lst, 0, PROTO_TCP, 0, + ) || (addr_info_to_si_lst(ai_lst, 0, PROTO_TCP, 0, 0, 0, &tcp_listen)!=0)) goto error; free_addr_info_lst(&ai_lst); @@ -1784,7 +1790,7 @@ int fix_all_socket_lists() #else || (auto_bind_ipv6 && add_interfaces(0, AF_INET6, 0, PROTO_TLS, &ai_lst)!=0) #endif /* __OS_linux */ - ) || (addr_info_to_si_lst(ai_lst, 0, PROTO_TLS, 0, + ) || (addr_info_to_si_lst(ai_lst, 0, PROTO_TLS, 0, 0, 0, &tls_listen)!=0)) goto error; } @@ -1801,7 +1807,7 @@ int fix_all_socket_lists() #else || (auto_bind_ipv6 && add_interfaces(0, AF_INET6, 0, PROTO_SCTP, &ai_lst) != 0) #endif /* __OS_linux */ - ) || (addr_info_to_si_lst(ai_lst, 0, PROTO_SCTP, 0, + ) || (addr_info_to_si_lst(ai_lst, 0, PROTO_SCTP, 0, 0, 0, &sctp_listen)!=0)) goto error; free_addr_info_lst(&ai_lst);

1 0

git:master:10be0865: modules: readme files regenerated - carrierroute ... [skip ci]
by Kamailio Dev 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: 10be086500d37d19674235b04cb302a0f34983fc URL: https://github.com/kamailio/kamailio/commit/10be086500d37d19674235b04cb302a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-10T13:01:57+02:00 modules: readme files regenerated - carrierroute ... [skip ci] --- Modified: src/modules/carrierroute/README --- Diff: https://github.com/kamailio/kamailio/commit/10be086500d37d19674235b04cb302a… Patch: https://github.com/kamailio/kamailio/commit/10be086500d37d19674235b04cb302a… --- diff --git a/src/modules/carrierroute/README b/src/modules/carrierroute/README index b766dac0fb..633c63e0d6 100644 --- a/src/modules/carrierroute/README +++ b/src/modules/carrierroute/README @@ -578,8 +578,8 @@ descavp) contiguous range starting at 1, limited by the configuration parameter max_targets. Possible values for hash_source are: call_id, from_uri, from_user, to_uri, to_user and rand - * decsavp - Name of the AVP where to store the description. This - parameter is optional. + * decsavp - AVP where to store the description. This parameter is + optional. 4.3. cr_nofallback_route(carrier, domain, prefix_matching, rewrite_user, hash_source, descavp)

1 0

git:master:bc3666ba: Merge pull request #1211 from dunst0/fix/carrierroute-README
by GitHub 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: bc3666ba9ff46fbaafa97483d5c9ee2f574a2d2c URL: https://github.com/kamailio/kamailio/commit/bc3666ba9ff46fbaafa97483d5c9ee2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2017-08-10T13:00:57+02:00 Merge pull request #1211 from dunst0/fix/carrierroute-README carrierroute: update to readme to precise that decsavp need to be an avp --- Modified: src/modules/carrierroute/doc/carrierroute_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/bc3666ba9ff46fbaafa97483d5c9ee2… Patch: https://github.com/kamailio/kamailio/commit/bc3666ba9ff46fbaafa97483d5c9ee2… --- diff --git a/src/modules/carrierroute/doc/carrierroute_admin.xml b/src/modules/carrierroute/doc/carrierroute_admin.xml index 7d11d5365b..ecebcee57a 100644 --- a/src/modules/carrierroute/doc/carrierroute_admin.xml +++ b/src/modules/carrierroute/doc/carrierroute_admin.xml @@ -514,7 +514,7 @@ cr_tree_rewrite_uri(tree, domain) </para> </listitem> <listitem> - <para><emphasis>decsavp</emphasis> - Name of the AVP where to store the description. + <para><emphasis>decsavp</emphasis> - AVP where to store the description. This parameter is optional. </para> </listitem>

1 0

git:master:5328dc6d: carrierroute: update to readme to precise that decsavp need to be an avp
by Rick Barenthin 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: 5328dc6d511a57ef47600f2724813124e082e53e URL: https://github.com/kamailio/kamailio/commit/5328dc6d511a57ef47600f272481312… Author: Rick Barenthin <dunst0(a)gmail.com> Committer: Rick Barenthin <dunst0(a)gmail.com> Date: 2017-08-10T11:31:30+02:00 carrierroute: update to readme to precise that decsavp need to be an avp --- Modified: src/modules/carrierroute/doc/carrierroute_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/5328dc6d511a57ef47600f272481312… Patch: https://github.com/kamailio/kamailio/commit/5328dc6d511a57ef47600f272481312… --- diff --git a/src/modules/carrierroute/doc/carrierroute_admin.xml b/src/modules/carrierroute/doc/carrierroute_admin.xml index 7d11d5365b..ecebcee57a 100644 --- a/src/modules/carrierroute/doc/carrierroute_admin.xml +++ b/src/modules/carrierroute/doc/carrierroute_admin.xml @@ -514,7 +514,7 @@ cr_tree_rewrite_uri(tree, domain) </para> </listitem> <listitem> - <para><emphasis>decsavp</emphasis> - Name of the AVP where to store the description. + <para><emphasis>decsavp</emphasis> - AVP where to store the description. This parameter is optional. </para> </listitem>

1 0

[kamailio/kamailio] carrierroute: update to readme to precise that decsavp need to be an avp (#1211)
by Rick 10 Aug '17

10 Aug '17

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issue #1210 (replace XXXX with an open issue number) #### Description  Make documentation of parameters description more clear that it has to be an avp not just the name. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1211 -- Commit Summary -- * carrierroute: update to readme to precise that decsavp need to be an avp -- File Changes -- M src/modules/carrierroute/doc/carrierroute_admin.xml (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1211.patch https://github.com/kamailio/kamailio/pull/1211.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1211

2 1

git:master:4e8eeaf9: Makefile.defs: version set to 5.1.0-dev6
by Daniel-Constantin Mierla 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: 4e8eeaf99dd024182d860f59207ae47c609093ca URL: https://github.com/kamailio/kamailio/commit/4e8eeaf99dd024182d860f59207ae47… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:55:11+02:00 Makefile.defs: version set to 5.1.0-dev6 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/4e8eeaf99dd024182d860f59207ae47… Patch: https://github.com/kamailio/kamailio/commit/4e8eeaf99dd024182d860f59207ae47… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index ac7aafcc38..5ffbc5dba7 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 1 SUBLEVEL = 0 -EXTRAVERSION = -dev5 +EXTRAVERSION = -dev6 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

git: new commits in branch master
by Daniel-Constantin Mierla 10 Aug '17

10 Aug '17

- URL: https://github.com/kamailio/kamailio/commit/e02990b561e306507a56b1557b44b6e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T11:48:50+02:00 xmlrpc: use reallocxf() to free old pointer in case of failure - URL: https://github.com/kamailio/kamailio/commit/444894cb9a26ba2a33c5a49e6507ac9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T11:49:37+02:00 core: mem - avoid free(0) when realloc(0, size) fails - URL: https://github.com/kamailio/kamailio/commit/027728ef16dd57383fe9ed62dff6143… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T11:50:29+02:00 lib/ims: use reallocxf() to cope properly with realloc failure - URL: https://github.com/kamailio/kamailio/commit/27b6801ba4f6bffa80c52ad6edf1c8e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:12:31+02:00 app_java: use reallocxf() to handle realloc failure - URL: https://github.com/kamailio/kamailio/commit/76ef8d98051971c4c46afe598afd920… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:13:18+02:00 app_lua: use reallocxf() to handle realloc failure - URL: https://github.com/kamailio/kamailio/commit/810f4196ab4ad0f0c72cbd31d8b54a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:13:36+02:00 app_python: use reallocxf() to handle realloc failure - URL: https://github.com/kamailio/kamailio/commit/1486a47f018eb322957cc9e481e8765… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:13:57+02:00 cnxcc: use reallocxf() to handle realloc failure - URL: https://github.com/kamailio/kamailio/commit/21e9d2c77264ebae6f7349fe97ef21e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:14:18+02:00 clt: proper handling of ctl_realloc() failure - URL: https://github.com/kamailio/kamailio/commit/20012fa12f9db6b4c51bdc4f3e69692… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:15:09+02:00 db_sqlite: use reallocxf() to handle realloc failure - URL: https://github.com/kamailio/kamailio/commit/46d1799fa37f12bd453c110b5e2c480… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:15:23+02:00 db_text: use reallocxf() to handle realloc failure - URL: https://github.com/kamailio/kamailio/commit/4a58b48876b829756c2bb6e483feb55… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:15:36+02:00 rtpengine: use reallocxf() to handle realloc failure - URL: https://github.com/kamailio/kamailio/commit/8ffd7473d46e5229cde1ab7623c3fa5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:15:47+02:00 rtpproxy: use reallocxf() to handle realloc failure - URL: https://github.com/kamailio/kamailio/commit/6f6bff7aae8192d1715c501708d7672… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:35:43+02:00 http_async_client: use reallocxf() to handle realloc failure - URL: https://github.com/kamailio/kamailio/commit/9b2229471a4e7b01b88a31ef9869c1e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:36:22+02:00 rls: use reallocxf() to handle realloc failure - URL: https://github.com/kamailio/kamailio/commit/c50e80d19dc9f6099e03db973be7e66… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:36:38+02:00 uid_auth_db: use reallocxf() to handle realloc failure - URL: https://github.com/kamailio/kamailio/commit/e0ff472acfbae9ad1077a3dc6f2309e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T12:52:58+02:00 pua_dialoginfo: goto error in case of failures inside build_dialoginfo()

1 0

[kamailio/kamailio] carrierroute: segfault while fixup cr_route params (#1210)
by Rick 10 Aug '17

10 Aug '17

### Description  I tried to configure the carrierroute module with the description loaded from the database into an avp. But it crashes with a segfault while startup. ### Troubleshooting #### Reproduction  ``` /* ----- carrierroute params ----------------------------------------------- */ modparam("carrierroute", "config_source", "db") modparam("carrierroute", "db_url", ....) modparam("carrierroute", "fetch_rows", 2000) modparam("carrierroute", "db_load_description", 1) modparam("carrierroute", "match_mode", 10) modparam("carrierroute", "avoid_failed_destinations", 1) ``` ``` if (cr_route("default", "default", "$(rU{s.strip,1})", "$rU", "call_id", "destination")) { .... } ``` #### Debugging Data  ``` #0 avp_name_fixup (param=0x8018d1330) at cr_fixup.c:187 187 if (((gparam_p)(*param))->v.pve->spec->type == PVT_AVP && [New Thread 80165a600 (LWP 100186/<unknown>)] (gdb) bt full #0 avp_name_fixup (param=0x8018d1330) at cr_fixup.c:187 No locals. #1 0x00000008072f0256 in cr_route_fixup (param=0x8018d1330, param_no=6) at cr_fixup.c:242 my_hash_source = shs_call_id #2 0x000000000073238e in fix_actions (a=0x8018d1258) at core/route.c:919 t = (struct action *) 0x8018d1258 p = (struct proxy_l *) 0xffffffff00000048 tmp = 0x0 tmp_p = (void *) 0x8018d1660 ret = 0 i = 5 cmd = (sr31_cmd_export_t *) 0x80186dcd0 s = {s = 0xffffffff00000000 <Address 0xffffffff00000000 out of bounds>, len = 0} he = (struct hostent *) 0x4 ip = {af = 4859304, len = 0, u = {addrl = 0x7fffffff9be0, addr32 = 0x7fffffff9be0, addr16 = 0x7fffffff9be0, addr = 0x7fffffff9be0 "?"}} si = (struct socket_info *) 0x7fffffff9c10 lval = (struct lvalue *) 0xffffffff00000001 rve = (struct rval_expr *) 0x0 err_rve = (struct rval_expr *) 0x1 rve_type = RV_NONE err_type = 48625432 expected_type = RV_NONE rv = (struct rvalue *) 0x9b6cf7 rve_param_no = 0 #3 0x000000000068a1c4 in fix_rval (rv=0x8018d36c8, rve=0x8018d36c0) at core/rvalue.c:2873 No locals. #4 0x000000000068843e in fix_rval_expr (p=0x8018d36c0) at core/rvalue.c:3797 rve = (struct rval_expr *) 0x8018d36c0 ret = 32767 #5 0x000000000072aa08 in fix_actions (a=0x8018c94d0) at core/route.c:706 t = (struct action *) 0x8018d1d18 p = (struct proxy_l *) 0x68341cdd25 tmp = 0x3 <Address 0x3 out of bounds> tmp_p = (void *) 0x8018cc9c0 ret = 0 i = 1 cmd = (sr31_cmd_export_t *) 0x801869de0 s = {s = 0x8018cc9c0 "", len = 5} he = (struct hostent *) 0x9b6cf7 ip = {af = 6302080, len = 0, u = {addrl = 0x7fffffffcfc0, addr32 = 0x7fffffffcfc0, addr16 = 0x7fffffffcfc0, addr = 0x7fffffffcfc0 ""}} si = (struct socket_info *) 0x7fffffffd0a0 lval = (struct lvalue *) 0x800f42023 rve = (struct rval_expr *) 0x8018d36c0 err_rve = (struct rval_expr *) 0x0 rve_type = RV_INT err_type = 9938251 expected_type = 32767 rv = (struct rvalue *) 0x8018ccf20 rve_param_no = 0 #6 0x000000000073fd6d in fix_rl (rt=0xce3830) at core/route.c:2088 i = 0 ret = -12096 #7 0x000000000073fc37 in fix_rls () at core/route.c:2104 ret = 4 #8 0x000000000043b0ae in main (argc=4, argv=0x7fffffffeb30) at main.c:2635 cfg_stream = (FILE *) 0x8011fdc90 c = -1 r = 1 tmp = 0x800f84aa2 "H\213\vH;M?u\aH\203?([]??\225!??f\017\037\204" tmp_len = 32767 port = -5424 proto = 0 options = 0x979297 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 2763663412 rfd = 4 debug_save = 3 debug_flag = 1 dont_fork_cnt = 1 n_lst = (struct name_lst *) 0x7fffffffeaa0 p = 0x4 <Address 0x4 out of bounds> st = {st_dev = 93, st_ino = 160517, st_mode = 16832, st_nlink = 2, st_uid = 986, st_gid = 986, st_rdev = 332063, st_atim = {tv_sec = 1459764184, tv_nsec = 513386000}, st_mtim = {tv_sec = 1502352532, tv_nsec = 990638000}, st_ctim = {tv_sec = 1502352532, tv_nsec = 990638000}, st_size = 512, st_blocks = 8, st_blksize = 32768, st_flags = 0, st_gen = 3958570559, st_lspare = 0, st_birthtim = {tv_sec = 1459764184, tv_nsec = 513356000}} Current language: auto; currently minimal ``` #### Log Messages  ``` 0(45720) DEBUG: <core> [core/route.c:872]: fix_actions(): fixing cr_route() 0(45720) DEBUG: <core> [core/pvapi.c:419]: pv_spec_lookup(): PV <$(rU{s.strip,1})> is not in cache 0(45720) DEBUG: <core> [core/pvapi.c:293]: pv_cache_add(): pvar [$(rU{s.strip,1})] added in cache 0(45720) DEBUG: <core> [core/pvapi.c:321]: pv_cache_lookup(): pvar [$rU] found in cache Segmentation fault (core dumped) ``` #### SIP Traffic  ``` none ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` # kamailio -v version: kamailio 5.1.0-dev5 (x86_64/freebsd) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, select, kqueue. id: unknown compiled on 16:54:24 Aug 9 2017 with clang 3.8 ``` * **Operating System**:  ``` # uname -a FreeBSD hostname.com 11.0-RELEASE-p9 FreeBSD 11.0-RELEASE-p9 #0: Tue Apr 11 08:48:40 UTC 2017 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1210

3 4

git:master:49217fb1: carrierroute: safety checks inside avp_name_fixup
by Daniel-Constantin Mierla 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: 49217fb14e7cc5794c8a0a2774c33337c33438ab URL: https://github.com/kamailio/kamailio/commit/49217fb14e7cc5794c8a0a2774c3333… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T11:19:19+02:00 carrierroute: safety checks inside avp_name_fixup - reported by GH #1210 --- Modified: src/modules/carrierroute/cr_fixup.c --- Diff: https://github.com/kamailio/kamailio/commit/49217fb14e7cc5794c8a0a2774c3333… Patch: https://github.com/kamailio/kamailio/commit/49217fb14e7cc5794c8a0a2774c3333… --- diff --git a/src/modules/carrierroute/cr_fixup.c b/src/modules/carrierroute/cr_fixup.c index ac363e9e9e..92c751047c 100644 --- a/src/modules/carrierroute/cr_fixup.c +++ b/src/modules/carrierroute/cr_fixup.c @@ -184,6 +184,11 @@ static int avp_name_fixup(void ** param) { LM_ERR("could not fixup parameter"); return -1; } + if(*param==NULL || ((gparam_p)(*param))->v.pve==NULL + || ((gparam_p)(*param))->v.pve->spec==NULL) { + LM_ERR("invalid AVP type definition\n"); + return -1; + } if (((gparam_p)(*param))->v.pve->spec->type == PVT_AVP && ((gparam_p)(*param))->v.pve->spec->pvp.pvn.u.isname.name.s.len == 0 && ((gparam_p)(*param))->v.pve->spec->pvp.pvn.u.isname.name.s.s == 0) {

1 0

git:master:2a80448b: xprint: use pkg_reallocxf() to ensure old pointer is freed in case of failure
by Daniel-Constantin Mierla 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: 2a80448b07b39dece0770bd04014a12e2d0390d8 URL: https://github.com/kamailio/kamailio/commit/2a80448b07b39dece0770bd04014a12… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T10:55:07+02:00 xprint: use pkg_reallocxf() to ensure old pointer is freed in case of failure - fix also potential free of null --- Modified: src/modules/xprint/xp_lib.c --- Diff: https://github.com/kamailio/kamailio/commit/2a80448b07b39dece0770bd04014a12… Patch: https://github.com/kamailio/kamailio/commit/2a80448b07b39dece0770bd04014a12… --- diff --git a/src/modules/xprint/xp_lib.c b/src/modules/xprint/xp_lib.c index d68bd64c05..068608a304 100644 --- a/src/modules/xprint/xp_lib.c +++ b/src/modules/xprint/xp_lib.c @@ -1862,9 +1862,8 @@ int xl_mod_init() str_domainname.s = NULL; } else { str_fullname.len = strlen(s); - s = pkg_realloc(s, str_fullname.len+1); /* this will leave the ending \0 */ + s = pkg_reallocxf(s, str_fullname.len+1); /* this will leave the ending \0 */ if (!s) { /* should never happen because decreasing size */ - pkg_free(s); return -1; } str_fullname.s = s;

1 0

git:master:7bf71edc: tm: relocated the crit log when branch was not set for reply transaction
by Daniel-Constantin Mierla 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: 7bf71edc62b26a4812b19f13f5c01f980c8e55b3 URL: https://github.com/kamailio/kamailio/commit/7bf71edc62b26a4812b19f13f5c01f9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T10:39:36+02:00 tm: relocated the crit log when branch was not set for reply transaction - added after the safety check on not accessing invalid branch indexed structure --- Modified: src/modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/7bf71edc62b26a4812b19f13f5c01f9… Patch: https://github.com/kamailio/kamailio/commit/7bf71edc62b26a4812b19f13f5c01f9… --- diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index 14939ec29b..795da9cb14 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -2180,14 +2180,18 @@ int reply_received( struct sip_msg *p_msg ) branch = T_BR_UNDEFINED; if (t_check(p_msg , &branch)==-1) goto trans_not_found; - if (unlikely(branch==T_BR_UNDEFINED)) { - LM_CRIT("BUG: invalid branch - report to developers\n"); - goto trans_not_found; - } /*... if there is none, tell the core router to fwd statelessly */ t=get_t(); - if ( (t==0)||(t==T_UNDEFINED)) + if ( (t==0)||(t==T_UNDEFINED)) { + LM_DBG("transaction not found - (branch %d)\n", branch); goto trans_not_found; + } + if (unlikely(branch==T_BR_UNDEFINED)) { + LM_CRIT("BUG: transaction found, but no branch matched\n"); + /* t_check() referenced the transaction */ + t_unref(p_msg); + goto trans_not_found; + } /* if transaction found, increment the rpl_received counter */ t_stats_rpl_received();

1 0

git:master:d5fa8ec4: modules: readme files regenerated - kex ... [skip ci]
by Kamailio Dev 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: d5fa8ec41292e0cc1aaf3454fde6a251eff07fed URL: https://github.com/kamailio/kamailio/commit/d5fa8ec41292e0cc1aaf3454fde6a25… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-10T09:16:28+02:00 modules: readme files regenerated - kex ... [skip ci] --- Modified: src/modules/kex/README --- Diff: https://github.com/kamailio/kamailio/commit/d5fa8ec41292e0cc1aaf3454fde6a25… Patch: https://github.com/kamailio/kamailio/commit/d5fa8ec41292e0cc1aaf3454fde6a25…

1 0

git:master:c06b1890: kex: documentation for rpc command core.ppdefines
by Daniel-Constantin Mierla 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: c06b1890a59fe6998fdef8d26def3568816ab8d7 URL: https://github.com/kamailio/kamailio/commit/c06b1890a59fe6998fdef8d26def356… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T09:08:13+02:00 kex: documentation for rpc command core.ppdefines --- Modified: src/modules/kex/doc/kex_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c06b1890a59fe6998fdef8d26def356… Patch: https://github.com/kamailio/kamailio/commit/c06b1890a59fe6998fdef8d26def356… --- diff --git a/src/modules/kex/doc/kex_admin.xml b/src/modules/kex/doc/kex_admin.xml index 49414ed1a9..6c588a31b5 100644 --- a/src/modules/kex/doc/kex_admin.xml +++ b/src/modules/kex/doc/kex_admin.xml @@ -10,9 +10,9 @@  <chapter> - + <title>&adminguide;</title> - + <section> <title>Overview</title> <para> @@ -22,7 +22,7 @@ &kamailio; Core Cookbook is available at: &kamwikilink; </para> </section> - + <section> <title>Dependencies</title> <section> @@ -648,6 +648,26 @@ resetdebug(); ... </programlisting> </section> + <section id="kex.r.core.ppdefines"> + <title> + <function moreinfo="none">core.ppdefines</function> + </title> + <para> + List preprocessor defines enabled in config. + </para> + <para> + Name: <emphasis>core.ppdefines</emphasis> + </para> + <para>Parameters: <emphasis>none</emphasis>.</para> + <para> + RPC Command Format: + </para> + <programlisting format="linespecific"> +... +&kamcmd; core.ppdefines +... + </programlisting> + </section> <section id="kex.r.pkg.stats"> <title>

1 0

git:master:3324b33c: core: added rpc command core.ppdefines
by Daniel-Constantin Mierla 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: 3324b33c7eb6036a984666e4294323f2cb015032 URL: https://github.com/kamailio/kamailio/commit/3324b33c7eb6036a984666e4294323f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T09:04:29+02:00 core: added rpc command core.ppdefines - list preprocessor defines enabled in config --- Modified: src/core/cfg.lex Modified: src/core/core_cmd.c Modified: src/core/ppcfg.c Modified: src/core/ppcfg.h --- Diff: https://github.com/kamailio/kamailio/commit/3324b33c7eb6036a984666e4294323f… Patch: https://github.com/kamailio/kamailio/commit/3324b33c7eb6036a984666e4294323f…

1 0

git:master:3469156e: Makefile.groups: added acc_diameter to extra group
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: 3469156e29565c03ea4a8e8bafe746eec06e3a83 URL: https://github.com/kamailio/kamailio/commit/3469156e29565c03ea4a8e8bafe746e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T19:23:41+02:00 Makefile.groups: added acc_diameter to extra group --- Modified: src/Makefile.groups --- Diff: https://github.com/kamailio/kamailio/commit/3469156e29565c03ea4a8e8bafe746e… Patch: https://github.com/kamailio/kamailio/commit/3469156e29565c03ea4a8e8bafe746e… --- diff --git a/src/Makefile.groups b/src/Makefile.groups index d7074cbc65..ab82466413 100644 --- a/src/Makefile.groups +++ b/src/Makefile.groups @@ -21,7 +21,7 @@ mod_list_basic=async auth benchmark blst cfg_rpc cfgutils corex counters \ mod_list_extra=avp auth_diameter call_control call_obj dmq domainpolicy msrp \ pdb qos sca seas sms sst timer tmrec uac_redirect xhttp \ xhttp_rpc xprint jsonrpcs nosip dmq_usrloc statsd rtjson \ - log_custom keepalive ss7ops app_sqlang + log_custom keepalive ss7ops app_sqlang acc_diameter # - common modules depending on database mod_list_db=acc alias_db auth_db avpops cfg_db db_text db_flatstore \

1 0

IMPORTANT: acc module - SQL define removed and diameter code relocated
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Hello, I just pushed a bit of clean up to acc module, therefore be aware of following changes: 1) the define conditions on SQL_ACC were removed -- this was enabled for more than 10 years and only made the code look complex and hard to follow up its logic. 2) the code related to DIAMETER accounting was relocated to acc_diameter (new) module. It was a consistent size of code that was not enabled for sooo... long. It is now a dedicated module, similar to acc_radius. The diameter accounting code, even a new module now, is in the same stage, compiling but not tested, in pair with auth_diameter module, it may work, but very likely not. In summary, what's important for those using the acc module -- it offers the same functionality as it was enabled by default in the past 10 years or more, only the unused code was relocated. It offers the functionality of writing accounting records to syslog and sql databases. The acc module is now slimmer, only with the code that it needs, therefore easier to maintain and enhance for the future. Hopefully, there was no side effect with this update -- anyhow, if you find any issue, just open a bug report on github project. Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - www.asipto.com Kamailio World Conference - www.kamailioworld.com

1 0

git:master:d05e4bff: acc_radius: coherent indentation and whitespacing
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: d05e4bffa921cb7daac24eda2ff7ddb09cde942d URL: https://github.com/kamailio/kamailio/commit/d05e4bffa921cb7daac24eda2ff7ddb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T15:28:59+02:00 acc_radius: coherent indentation and whitespacing --- Modified: src/modules/acc_radius/acc_radius_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/d05e4bffa921cb7daac24eda2ff7ddb… Patch: https://github.com/kamailio/kamailio/commit/d05e4bffa921cb7daac24eda2ff7ddb… --- diff --git a/src/modules/acc_radius/acc_radius_mod.c b/src/modules/acc_radius/acc_radius_mod.c index df5dbdf5f8..94e521f537 100644 --- a/src/modules/acc_radius/acc_radius_mod.c +++ b/src/modules/acc_radius/acc_radius_mod.c @@ -67,7 +67,7 @@ acc_api_t accb; acc_engine_t _acc_radius_engine; /* ----- RADIUS acc variables ----------- */ -/*! \name AccRadiusVariables Radius Variables */ +/*! \name AccRadiusVariables Radius Variables */ /*@{*/ static char *radius_config = 0; @@ -324,7 +324,7 @@ int acc_radius_send_request(struct sip_msg *req, acc_info_t *inf) int rc_result=-1; double tsecmicro; char smicrosec[18]; - + send=NULL; attr_cnt = accb.get_core_attrs( req, inf->varr, inf->iarr, inf->tarr ); @@ -344,16 +344,16 @@ int acc_radius_send_request(struct sip_msg *req, acc_info_t *inf) ADD_RAD_AVPAIR( RA_SIP_METHOD, &av_type, -1); // Event Time Stamp with Microseconds - if(rad_time_mode==1){ - gettimeofday(&inf->env->tv, NULL); - tsecmicro=inf->env->tv.tv_sec+((double)inf->env->tv.tv_usec/1000000.0); - //radius client doesn t support double so convert it - sprintf(smicrosec,"%17.6f",tsecmicro); - ADD_RAD_AVPAIR(RA_TIME_STAMP, &smicrosec, -1); - }else{ - av_type = (uint32_t)inf->env->ts; - ADD_RAD_AVPAIR(RA_TIME_STAMP, &av_type, -1); - } + if(rad_time_mode==1){ + gettimeofday(&inf->env->tv, NULL); + tsecmicro=inf->env->tv.tv_sec+((double)inf->env->tv.tv_usec/1000000.0); + //radius client doesn t support double so convert it + sprintf(smicrosec,"%17.6f",tsecmicro); + ADD_RAD_AVPAIR(RA_TIME_STAMP, &smicrosec, -1); + }else{ + av_type = (uint32_t)inf->env->ts; + ADD_RAD_AVPAIR(RA_TIME_STAMP, &av_type, -1); + } /* add extra also */ @@ -392,29 +392,29 @@ int acc_radius_send_request(struct sip_msg *req, acc_info_t *inf) rc_result=rc_acct(rh, SIP_PORT, send); - if (rc_result==ERROR_RC) { - LM_ERR("Radius accounting - ERROR - \n"); - goto error; - }else if(rc_result==BADRESP_RC){ - LM_ERR("Radius accounting - BAD RESPONSE \n"); - goto error; - }else if(rc_result==TIMEOUT_RC){ - LM_ERR("Radius accounting - TIMEOUT \n"); - goto error; - }else if(rc_result==REJECT_RC){ - LM_ERR("Radius accounting - REJECTED \n"); - goto error; - }else if(rc_result==OK_RC){ - LM_DBG("Radius accounting - OK \n"); - }else{ - LM_ERR("Radius accounting - Unknown response \n"); - goto error; - } - - rc_avpair_free(send); - /* free memory allocated by extra2strar */ - free_strar_mem( &(inf->tarr[m-o]), &(inf->varr[m-o]), o, m); - return 1; + if (rc_result==ERROR_RC) { + LM_ERR("Radius accounting - ERROR - \n"); + goto error; + }else if(rc_result==BADRESP_RC){ + LM_ERR("Radius accounting - BAD RESPONSE \n"); + goto error; + }else if(rc_result==TIMEOUT_RC){ + LM_ERR("Radius accounting - TIMEOUT \n"); + goto error; + }else if(rc_result==REJECT_RC){ + LM_ERR("Radius accounting - REJECTED \n"); + goto error; + }else if(rc_result==OK_RC){ + LM_DBG("Radius accounting - OK \n"); + }else{ + LM_ERR("Radius accounting - Unknown response \n"); + goto error; + } + + rc_avpair_free(send); + /* free memory allocated by extra2strar */ + free_strar_mem( &(inf->tarr[m-o]), &(inf->varr[m-o]), o, m); + return 1; error: rc_avpair_free(send);

1 0

git:master:5cb612b7: acc: relocated the code related to diameter accounting to acc_diameter
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: 5cb612b7ff9bba75ec8e48dade06561810a77ccd URL: https://github.com/kamailio/kamailio/commit/5cb612b7ff9bba75ec8e48dade06561… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T15:28:25+02:00 acc: relocated the code related to diameter accounting to acc_diameter --- Modified: src/modules/acc/Makefile Modified: src/modules/acc/acc.c Modified: src/modules/acc/acc.h Modified: src/modules/acc/acc_api.h Modified: src/modules/acc/acc_cdr.c Modified: src/modules/acc/acc_extra.c Modified: src/modules/acc/acc_logic.c Modified: src/modules/acc/acc_logic.h Modified: src/modules/acc/acc_mod.c Modified: src/modules/acc/acc_mod.h Removed: src/modules/acc/diam_avp.c Removed: src/modules/acc/diam_dict.h Removed: src/modules/acc/diam_message.c Removed: src/modules/acc/diam_message.h Removed: src/modules/acc/diam_tcp.c Removed: src/modules/acc/diam_tcp.h --- Diff: https://github.com/kamailio/kamailio/commit/5cb612b7ff9bba75ec8e48dade06561… Patch: https://github.com/kamailio/kamailio/commit/5cb612b7ff9bba75ec8e48dade06561…

1 0

git:master:560c52cb: acc_diameter: diameter accounting module with code relocated from acc
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: 560c52cbd4f6f4f934cd907621979ce33a676821 URL: https://github.com/kamailio/kamailio/commit/560c52cbd4f6f4f934cd907621979ce… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T15:27:47+02:00 acc_diameter: diameter accounting module with code relocated from acc --- Added: src/modules/acc_diameter/Makefile Added: src/modules/acc_diameter/README Added: src/modules/acc_diameter/acc_diameter_mod.c Added: src/modules/acc_diameter/diam_avp.c Added: src/modules/acc_diameter/diam_dict.h Added: src/modules/acc_diameter/diam_message.c Added: src/modules/acc_diameter/diam_message.h Added: src/modules/acc_diameter/diam_tcp.c Added: src/modules/acc_diameter/diam_tcp.h Added: src/modules/acc_diameter/doc/Makefile Added: src/modules/acc_diameter/doc/acc_diameter.xml Added: src/modules/acc_diameter/doc/acc_diameter_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/560c52cbd4f6f4f934cd907621979ce… Patch: https://github.com/kamailio/kamailio/commit/560c52cbd4f6f4f934cd907621979ce…

1 0

git:master:60a35d4e: acc_radius: removed unused code left when split from acc module
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: 60a35d4ea83fc0a6d2a29aa56ff94afc57eff9af URL: https://github.com/kamailio/kamailio/commit/60a35d4ea83fc0a6d2a29aa56ff94af… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T13:38:16+02:00 acc_radius: removed unused code left when split from acc module --- Modified: src/modules/acc_radius/acc_radius_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/60a35d4ea83fc0a6d2a29aa56ff94af… Patch: https://github.com/kamailio/kamailio/commit/60a35d4ea83fc0a6d2a29aa56ff94af… --- diff --git a/src/modules/acc_radius/acc_radius_mod.c b/src/modules/acc_radius/acc_radius_mod.c index 05adfb1b11..df5dbdf5f8 100644 --- a/src/modules/acc_radius/acc_radius_mod.c +++ b/src/modules/acc_radius/acc_radius_mod.c @@ -203,14 +203,6 @@ static int acc_api_fixup(void** param, int param_no) accp->reason.len = strlen(accp->reason.s); } *param = (void*)accp; -#ifdef SQL_ACC - } else if (param_no == 2) { - /* only for db acc - the table name */ - if (db_url.s==0) { - pkg_free(p); - *param = 0; - } -#endif } return 0; }

1 0

git:master:8eb6e6a0: acc: removed define for SQL_ACC
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: 8eb6e6a01d435955939ceddee82b3ba0a3ee93f8 URL: https://github.com/kamailio/kamailio/commit/8eb6e6a01d435955939ceddee82b3ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T13:37:20+02:00 acc: removed define for SQL_ACC - it was enabled for more than 10 years and the module links to lib/srdb1 anyhow --- Modified: src/modules/acc/Makefile Modified: src/modules/acc/acc.c Modified: src/modules/acc/acc.h Modified: src/modules/acc/acc_cdr.c Modified: src/modules/acc/acc_logic.c Modified: src/modules/acc/acc_logic.h Modified: src/modules/acc/acc_mod.c Modified: src/modules/acc/acc_mod.h --- Diff: https://github.com/kamailio/kamailio/commit/8eb6e6a01d435955939ceddee82b3ba… Patch: https://github.com/kamailio/kamailio/commit/8eb6e6a01d435955939ceddee82b3ba…

1 0

RFC: Moving misc/obsolete/ to its own git repository
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Hello, trying to make the git repository a bit slimmer and avoid unuseful indexing of unused modules, I am considering to move misc/obsolete to its own github repository (planned to be named kamailio-obsolete). The initial idea was to keep there modules that were duplicated or no longer maintained, just in case someone will come later and wants to revive it. However, iirc, it is more than 4 years and nobody touched them, so very likely it requires a bit of work to revive any of them, so a fresh re-import will be the same from an external repository. If anyone still wants to keep them in the main kamailio repository, respond on the mailing list and present the benefits. If not, I will do the operation in the next several days. Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - www.asipto.com Kamailio World Conference - www.kamailioworld.com

1 1

git:master:eff1e2c6: misc: removed obsolete folder
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: eff1e2c6a2ccceae1ddfc81298cbdcc789fcf6dd URL: https://github.com/kamailio/kamailio/commit/eff1e2c6a2ccceae1ddfc81298cbdcc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T12:34:46+02:00 misc: removed obsolete folder - content relocated to its own github repo: kamailio-obsolete --- Removed: misc/obsolete/acc_db/.cvsignore Removed: misc/obsolete/acc_db/Makefile Removed: misc/obsolete/acc_db/acc_db.c Removed: misc/obsolete/acc_db/acc_db.xml Removed: misc/obsolete/acc_radius/Makefile Removed: misc/obsolete/acc_radius/acc_radius.c Removed: misc/obsolete/acc_syslog/.cvsignore Removed: misc/obsolete/acc_syslog/Makefile Removed: misc/obsolete/acc_syslog/README Removed: misc/obsolete/acc_syslog/acc_syslog.c Removed: misc/obsolete/acc_syslog/acc_syslog.xml Removed: misc/obsolete/acc_syslog/attrs.h Removed: misc/obsolete/acc_syslog/doc/Makefile Removed: misc/obsolete/acc_syslog/doc/acc_syslog.xml Removed: misc/obsolete/acc_syslog/doc/functions.xml Removed: misc/obsolete/acc_syslog/doc/params.xml Removed: misc/obsolete/auth_radius/Makefile Removed: misc/obsolete/auth_radius/README Removed: misc/obsolete/auth_radius/authorize.c Removed: misc/obsolete/auth_radius/authorize.h Removed: misc/obsolete/auth_radius/authrad_mod.c Removed: misc/obsolete/auth_radius/authrad_mod.h Removed: misc/obsolete/auth_radius/doc/Makefile Removed: misc/obsolete/auth_radius/doc/auth_radius.xml Removed: misc/obsolete/auth_radius/doc/functions.xml Removed: misc/obsolete/auth_radius/doc/params.xml Removed: misc/obsolete/auth_radius/sterman.c Removed: misc/obsolete/auth_radius/sterman.h Removed: misc/obsolete/avp_radius/Makefile Removed: misc/obsolete/avp_radius/README Removed: misc/obsolete/avp_radius/avp_radius.c Removed: misc/obsolete/avp_radius/doc/Makefile Removed: misc/obsolete/avp_radius/doc/avp_radius.xml Removed: misc/obsolete/avp_radius/doc/functions.xml Removed: misc/obsolete/avp_radius/doc/params.xml Removed: misc/obsolete/bdb/Makefile Removed: misc/obsolete/bdb/README Removed: misc/obsolete/bdb/bdb.c Removed: misc/obsolete/bdb/bdb.h Removed: misc/obsolete/bdb/bdb_api.c Removed: misc/obsolete/bdb/bdb_api.h Removed: misc/obsolete/bdb/bdb_base.c Removed: misc/obsolete/bdb/bdb_res.h Removed: misc/obsolete/bdb/bdb_rval.c Removed: misc/obsolete/bdb/bdb_sval.c Removed: misc/obsolete/bdb/bdb_uval.c Removed: misc/obsolete/bdb/bdb_val.c Removed: misc/obsolete/bdb/bdb_vals.h Removed: misc/obsolete/bdb/doc/Makefile Removed: misc/obsolete/bdb/doc/bdb.xml Removed: misc/obsolete/bdb/version.dump Removed: misc/obsolete/cpl-c/CPL_tree.h Removed: misc/obsolete/cpl-c/Makefile Removed: misc/obsolete/cpl-c/README Removed: misc/obsolete/cpl-c/cpl-06.dtd Removed: misc/obsolete/cpl-c/cpl.c Removed: misc/obsolete/cpl-c/cpl_db.c Removed: misc/obsolete/cpl-c/cpl_db.h Removed: misc/obsolete/cpl-c/cpl_env.h Removed: misc/obsolete/cpl-c/cpl_loader.c Removed: misc/obsolete/cpl-c/cpl_loader.h Removed: misc/obsolete/cpl-c/cpl_log.c Removed: misc/obsolete/cpl-c/cpl_log.h Removed: misc/obsolete/cpl-c/cpl_nonsig.c Removed: misc/obsolete/cpl-c/cpl_nonsig.h Removed: misc/obsolete/cpl-c/cpl_parser.c Removed: misc/obsolete/cpl-c/cpl_parser.h Removed: misc/obsolete/cpl-c/cpl_proxy.h Removed: misc/obsolete/cpl-c/cpl_rpc.c Removed: misc/obsolete/cpl-c/cpl_rpc.h Removed: misc/obsolete/cpl-c/cpl_run.c Removed: misc/obsolete/cpl-c/cpl_run.h Removed: misc/obsolete/cpl-c/cpl_sig.c Removed: misc/obsolete/cpl-c/cpl_sig.h Removed: misc/obsolete/cpl-c/cpl_switches.h Removed: misc/obsolete/cpl-c/cpl_time.c Removed: misc/obsolete/cpl-c/cpl_time.h Removed: misc/obsolete/cpl-c/cpl_utils.h Removed: misc/obsolete/cpl-c/doc/Makefile Removed: misc/obsolete/cpl-c/doc/cpl-c.xml Removed: misc/obsolete/cpl-c/doc/functions.xml Removed: misc/obsolete/cpl-c/doc/params.xml Removed: misc/obsolete/cpl-c/init.mysql Removed: misc/obsolete/cpl-c/loc_set.h Removed: misc/obsolete/cpl-c/ser-cpl.cfg Removed: misc/obsolete/cpl-c/sub_list.c Removed: misc/obsolete/cpl-c/sub_list.h Removed: misc/obsolete/dbtext/Makefile Removed: misc/obsolete/dbtext/README Removed: misc/obsolete/dbtext/dbt_api.c Removed: misc/obsolete/dbtext/dbt_api.h Removed: misc/obsolete/dbtext/dbt_base.c Removed: misc/obsolete/dbtext/dbt_file.c Removed: misc/obsolete/dbtext/dbt_lib.c Removed: misc/obsolete/dbtext/dbt_lib.h Removed: misc/obsolete/dbtext/dbt_res.c Removed: misc/obsolete/dbtext/dbt_res.h Removed: misc/obsolete/dbtext/dbt_tb.c Removed: misc/obsolete/dbtext/dbt_util.c Removed: misc/obsolete/dbtext/dbt_util.h Removed: misc/obsolete/dbtext/dbtex/Makefile Removed: misc/obsolete/dbtext/dbtex/db/location Removed: misc/obsolete/dbtext/dbtex/db/test Removed: misc/obsolete/dbtext/dbtex/dbtex.c Removed: misc/obsolete/dbtext/dbtext.c Removed: misc/obsolete/dbtext/dbtext.h Removed: misc/obsolete/dbtext/doc/Makefile Removed: misc/obsolete/dbtext/doc/dbtext-ser.cfg Removed: misc/obsolete/dbtext/doc/dbtext.xml Removed: misc/obsolete/dialog/Makefile Removed: misc/obsolete/dialog/db_dlg.c Removed: misc/obsolete/dialog/db_dlg.h Removed: misc/obsolete/dialog/dlg_mod.c Removed: misc/obsolete/dialog/dlg_mod.h Removed: misc/obsolete/dialog/dlg_mod_internal.h Removed: misc/obsolete/dialog/dlg_request.c Removed: misc/obsolete/dialog/dlg_request.h Removed: misc/obsolete/dialog/dlg_utils.c Removed: misc/obsolete/dialog/dlg_utils.h Removed: misc/obsolete/dialog/serialize_dlg.c Removed: misc/obsolete/dialog/serialize_dlg.h Removed: misc/obsolete/dispatcher/Makefile Removed: misc/obsolete/dispatcher/README Removed: misc/obsolete/dispatcher/dispatch.h Removed: misc/obsolete/dispatcher/dispatcher.c Removed: misc/obsolete/dispatcher/dispatcher.h Removed: misc/obsolete/dispatcher/doc/Makefile Removed: misc/obsolete/dispatcher/doc/dispatcher.cfg Removed: misc/obsolete/dispatcher/doc/dispatcher.list Removed: misc/obsolete/dispatcher/doc/dispatcher.xml Removed: misc/obsolete/dispatcher/doc/fifo.xml Removed: misc/obsolete/dispatcher/doc/functions.xml Removed: misc/obsolete/dispatcher/doc/params.xml Removed: misc/obsolete/dispatcher/ds_backend.c Removed: misc/obsolete/dispatcher/ds_rpc.c Removed: misc/obsolete/dispatcher/ds_rpc.h Removed: misc/obsolete/diversion/Makefile Removed: misc/obsolete/diversion/README Removed: misc/obsolete/diversion/diversion.c Removed: misc/obsolete/eval/Makefile Removed: misc/obsolete/eval/README Removed: misc/obsolete/eval/eval.c Removed: misc/obsolete/exec/Makefile Removed: misc/obsolete/exec/README Removed: misc/obsolete/exec/config.h Removed: misc/obsolete/exec/doc/Makefile Removed: misc/obsolete/exec/doc/exec.xml Removed: misc/obsolete/exec/doc/functions.xml Removed: misc/obsolete/exec/doc/params.xml Removed: misc/obsolete/exec/exec.c Removed: misc/obsolete/exec/exec.h Removed: misc/obsolete/exec/exec_hf.c Removed: misc/obsolete/exec/exec_hf.h Removed: misc/obsolete/exec/exec_mod.c Removed: misc/obsolete/exec/kill.c Removed: misc/obsolete/exec/kill.h Removed: misc/obsolete/fifo/Makefile Removed: misc/obsolete/fifo/README Removed: misc/obsolete/fifo/fifo.c Removed: misc/obsolete/fifo/fifo.h Removed: misc/obsolete/fifo/fifo_server.c Removed: misc/obsolete/fifo/fifo_server.h Removed: misc/obsolete/iptrtpproxy/Makefile Removed: misc/obsolete/iptrtpproxy/README Removed: misc/obsolete/iptrtpproxy/doc/Makefile Removed: misc/obsolete/iptrtpproxy/doc/iptrtpproxy.xml Removed: misc/obsolete/iptrtpproxy/doc/iptrtpproxy_admin.xml Removed: misc/obsolete/iptrtpproxy/iptrtpproxy.c Removed: misc/obsolete/iptrtpproxy/oob/clean_rtpproxy_attrs Removed: misc/obsolete/iptrtpproxy/oob/rtpproxy_attrs.sql Removed: misc/obsolete/iptrtpproxy/oob/sip-router-oob-RTPPROXY.cfg.inc Removed: misc/obsolete/iptrtpproxy/oob/sip-router-oob-RTPPROXY.cfg.patch Removed: misc/obsolete/jabber_k/Makefile Removed: misc/obsolete/jabber_k/README Removed: misc/obsolete/jabber_k/doc/Makefile Removed: misc/obsolete/jabber_k/doc/jabber.cfg Removed: misc/obsolete/jabber_k/doc/jabber.gws Removed: misc/obsolete/jabber_k/doc/jabber.sql Removed: misc/obsolete/jabber_k/doc/jabber.xml Removed: misc/obsolete/jabber_k/doc/jabber_admin.xml Removed: misc/obsolete/jabber_k/doc/jabberreg.pl Removed: misc/obsolete/jabber_k/doc/jabberx.cfg Removed: misc/obsolete/jabber_k/doc/web/libjab.php Removed: misc/obsolete/jabber_k/doc/web/subscribe.php Removed: misc/obsolete/jabber_k/jabber.c Removed: misc/obsolete/jabber_k/mdefines.h Removed: misc/obsolete/jabber_k/sha.c Removed: misc/obsolete/jabber_k/tree234.c Removed: misc/obsolete/jabber_k/tree234.h Removed: misc/obsolete/jabber_k/xjab_base.c Removed: misc/obsolete/jabber_k/xjab_base.h Removed: misc/obsolete/jabber_k/xjab_dmsg.h Removed: misc/obsolete/jabber_k/xjab_jcon.c Removed: misc/obsolete/jabber_k/xjab_jcon.h Removed: misc/obsolete/jabber_k/xjab_jconf.c Removed: misc/obsolete/jabber_k/xjab_jconf.h Removed: misc/obsolete/jabber_k/xjab_load.c Removed: misc/obsolete/jabber_k/xjab_load.h Removed: misc/obsolete/jabber_k/xjab_presence.c Removed: misc/obsolete/jabber_k/xjab_presence.h Removed: misc/obsolete/jabber_k/xjab_util.c Removed: misc/obsolete/jabber_k/xjab_util.h Removed: misc/obsolete/jabber_k/xjab_wlist.c Removed: misc/obsolete/jabber_k/xjab_worker.c Removed: misc/obsolete/jabber_k/xjab_worker.h Removed: misc/obsolete/jabber_k/xode.c Removed: misc/obsolete/jabber_k/xode.h Removed: misc/obsolete/jabber_k/xode_from.c Removed: misc/obsolete/jabber_k/xode_str.c Removed: misc/obsolete/jabber_k/xpool.c Removed: misc/obsolete/jabber_k/xsnprintf.c Removed: misc/obsolete/jabber_k/xstream.c Removed: misc/obsolete/jabber_s/Makefile Removed: misc/obsolete/jabber_s/README Removed: misc/obsolete/jabber_s/doc/Makefile Removed: misc/obsolete/jabber_s/doc/admin.xml Removed: misc/obsolete/jabber_s/doc/faq.txt Removed: misc/obsolete/jabber_s/doc/functions.xml Removed: misc/obsolete/jabber_s/doc/gateways.txt Removed: misc/obsolete/jabber_s/doc/jabber.xml Removed: misc/obsolete/jabber_s/doc/params.xml Removed: misc/obsolete/jabber_s/doc/regjab.pl Removed: misc/obsolete/jabber_s/doc/web/libjab.php Removed: misc/obsolete/jabber_s/doc/web/subscribe.php Removed: misc/obsolete/jabber_s/doc/xjab.cfg Removed: misc/obsolete/jabber_s/doc/xjab.sql Removed: misc/obsolete/jabber_s/doc/xxjab.cfg Removed: misc/obsolete/jabber_s/jabber.c Removed: misc/obsolete/jabber_s/mdefines.h Removed: misc/obsolete/jabber_s/ser-jabber.cfg Removed: misc/obsolete/jabber_s/sha.c Removed: misc/obsolete/jabber_s/tree234.c Removed: misc/obsolete/jabber_s/tree234.h Removed: misc/obsolete/jabber_s/xjab_base.c Removed: misc/obsolete/jabber_s/xjab_base.h Removed: misc/obsolete/jabber_s/xjab_dmsg.h Removed: misc/obsolete/jabber_s/xjab_jcon.c Removed: misc/obsolete/jabber_s/xjab_jcon.h Removed: misc/obsolete/jabber_s/xjab_jconf.c Removed: misc/obsolete/jabber_s/xjab_jconf.h Removed: misc/obsolete/jabber_s/xjab_load.c Removed: misc/obsolete/jabber_s/xjab_load.h Removed: misc/obsolete/jabber_s/xjab_presence.c Removed: misc/obsolete/jabber_s/xjab_presence.h Removed: misc/obsolete/jabber_s/xjab_util.c Removed: misc/obsolete/jabber_s/xjab_util.h Removed: misc/obsolete/jabber_s/xjab_wlist.c Removed: misc/obsolete/jabber_s/xjab_worker.c Removed: misc/obsolete/jabber_s/xjab_worker.h Removed: misc/obsolete/jabber_s/xode.c Removed: misc/obsolete/jabber_s/xode.h Removed: misc/obsolete/jabber_s/xode_from.c Removed: misc/obsolete/jabber_s/xode_str.c Removed: misc/obsolete/jabber_s/xpool.c Removed: misc/obsolete/jabber_s/xsnprintf.c Removed: misc/obsolete/jabber_s/xstream.c Removed: misc/obsolete/maxfwd/Makefile Removed: misc/obsolete/maxfwd/README Removed: misc/obsolete/maxfwd/doc/Makefile Removed: misc/obsolete/maxfwd/doc/functions.xml Removed: misc/obsolete/maxfwd/doc/maxfwd.xml Removed: misc/obsolete/maxfwd/doc/params.xml Removed: misc/obsolete/maxfwd/maxfwd.c Removed: misc/obsolete/maxfwd/mf_funcs.c Removed: misc/obsolete/maxfwd/mf_funcs.h Removed: misc/obsolete/msilo/Makefile Removed: misc/obsolete/msilo/README Removed: misc/obsolete/msilo/doc/Makefile Removed: misc/obsolete/msilo/doc/functions.xml Removed: misc/obsolete/msilo/doc/msilo.cfg Removed: misc/obsolete/msilo/doc/msilo.xml Removed: misc/obsolete/msilo/doc/params.xml Removed: misc/obsolete/msilo/ms_msg_list.c Removed: misc/obsolete/msilo/ms_msg_list.h Removed: misc/obsolete/msilo/msfuncs.c Removed: misc/obsolete/msilo/msfuncs.h Removed: misc/obsolete/msilo/msilo.c Removed: misc/obsolete/msilo/ser-msilo.cfg Removed: misc/obsolete/nathelper/Makefile Removed: misc/obsolete/nathelper/README Removed: misc/obsolete/nathelper/TODO Removed: misc/obsolete/nathelper/doc/Makefile Removed: misc/obsolete/nathelper/doc/functions.xml Removed: misc/obsolete/nathelper/doc/nathelper.xml Removed: misc/obsolete/nathelper/doc/params.xml Removed: misc/obsolete/nathelper/nathelper.c Removed: misc/obsolete/nathelper/nathelper.cfg Removed: misc/obsolete/nathelper/nathelper.h Removed: misc/obsolete/nathelper/natping.c Removed: misc/obsolete/nathelper/nhelpr_funcs.c Removed: misc/obsolete/nathelper/nhelpr_funcs.h Removed: misc/obsolete/options/Makefile Removed: misc/obsolete/options/README Removed: misc/obsolete/options/doc/Makefile Removed: misc/obsolete/options/doc/functions.xml Removed: misc/obsolete/options/doc/options.xml Removed: misc/obsolete/options/doc/params.xml Removed: misc/obsolete/options/mod_options.c Removed: misc/obsolete/options/mod_options.h Removed: misc/obsolete/oracle/Makefile Removed: misc/obsolete/oracle/README Removed: misc/obsolete/oracle/common.h Removed: misc/obsolete/oracle/db_mod.c Removed: misc/obsolete/oracle/dbase.c Removed: misc/obsolete/oracle/dbase.h Removed: misc/obsolete/oracle/prepare.c Removed: misc/obsolete/oracle/prepare.h Removed: misc/obsolete/oracle/utils.c Removed: misc/obsolete/oracle/utils.h Removed: misc/obsolete/osp/Makefile Removed: misc/obsolete/osp/README Removed: misc/obsolete/osp/RELEASE-NOTES.txt Removed: misc/obsolete/osp/destination.c Removed: misc/obsolete/osp/destination.h Removed: misc/obsolete/osp/doc/Makefile Removed: misc/obsolete/osp/doc/osp.xml Removed: misc/obsolete/osp/doc/osp_admin.xml Removed: misc/obsolete/osp/doc/osp_devel.xml Removed: misc/obsolete/osp/doc/osp_faq.xml Removed: misc/obsolete/osp/etc/cacert_0.pem Removed: misc/obsolete/osp/etc/localcert.pem Removed: misc/obsolete/osp/etc/pkey.pem Removed: misc/obsolete/osp/etc/sample-osp-ser.cfg Removed: misc/obsolete/osp/globals.c Removed: misc/obsolete/osp/orig_transaction.c Removed: misc/obsolete/osp/orig_transaction.h Removed: misc/obsolete/osp/osp_mod.c Removed: misc/obsolete/osp/osp_mod.h Removed: misc/obsolete/osp/osptoolkit.c Removed: misc/obsolete/osp/osptoolkit.h Removed: misc/obsolete/osp/provider.c Removed: misc/obsolete/osp/provider.h Removed: misc/obsolete/osp/sipheader.c Removed: misc/obsolete/osp/sipheader.h Removed: misc/obsolete/osp/term_transaction.c Removed: misc/obsolete/osp/term_transaction.h Removed: misc/obsolete/osp/tm.c Removed: misc/obsolete/osp/tm.h Removed: misc/obsolete/osp/usage.c Removed: misc/obsolete/osp/usage.h Removed: misc/obsolete/pa/ChangeLog Removed: misc/obsolete/pa/Makefile Removed: misc/obsolete/pa/README Removed: misc/obsolete/pa/async_auth.c Removed: misc/obsolete/pa/async_auth.h Removed: misc/obsolete/pa/auth.c Removed: misc/obsolete/pa/auth.h Removed: misc/obsolete/pa/dlist.c Removed: misc/obsolete/pa/dlist.h Removed: misc/obsolete/pa/doc/Makefile Removed: misc/obsolete/pa/doc/auth.xml Removed: misc/obsolete/pa/doc/functions.xml Removed: misc/obsolete/pa/doc/pa.xml Removed: misc/obsolete/pa/doc/pa_base.xml Removed: misc/obsolete/pa/doc/pa_db_src.xml Removed: misc/obsolete/pa/doc/pa_incl.xml Removed: misc/obsolete/pa/doc/params.xml Removed: misc/obsolete/pa/doc/xcap.xml Removed: misc/obsolete/pa/extension_elements.c Removed: misc/obsolete/pa/extension_elements.h Removed: misc/obsolete/pa/hslot.c Removed: misc/obsolete/pa/hslot.h Removed: misc/obsolete/pa/message.c Removed: misc/obsolete/pa/message.h Removed: misc/obsolete/pa/mimetypes.c Removed: misc/obsolete/pa/mimetypes.h Removed: misc/obsolete/pa/notify.c Removed: misc/obsolete/pa/notify.h Removed: misc/obsolete/pa/offline_winfo.c Removed: misc/obsolete/pa/offline_winfo.h Removed: misc/obsolete/pa/pa_mod.c Removed: misc/obsolete/pa/pa_mod.h Removed: misc/obsolete/pa/paerrno.c Removed: misc/obsolete/pa/paerrno.h Removed: misc/obsolete/pa/pdomain.c Removed: misc/obsolete/pa/pdomain.h Removed: misc/obsolete/pa/pres_notes.c Removed: misc/obsolete/pa/pres_notes.h Removed: misc/obsolete/pa/pres_timer.c Removed: misc/obsolete/pa/presentity.c Removed: misc/obsolete/pa/presentity.h Removed: misc/obsolete/pa/ptime.c Removed: misc/obsolete/pa/ptime.h Removed: misc/obsolete/pa/publish.c Removed: misc/obsolete/pa/publish.h Removed: misc/obsolete/pa/qsa_interface.c Removed: misc/obsolete/pa/qsa_interface.h Removed: misc/obsolete/pa/reply.c Removed: misc/obsolete/pa/reply.h Removed: misc/obsolete/pa/rpc.c Removed: misc/obsolete/pa/rpc.h Removed: misc/obsolete/pa/status_query.c Removed: misc/obsolete/pa/status_query.h Removed: misc/obsolete/pa/subscribe.c Removed: misc/obsolete/pa/subscribe.h Removed: misc/obsolete/pa/trace.h Removed: misc/obsolete/pa/tuple.c Removed: misc/obsolete/pa/tuple.h Removed: misc/obsolete/pa/tuple_extensions.c Removed: misc/obsolete/pa/tuple_extensions.h Removed: misc/obsolete/pa/tuple_notes.c Removed: misc/obsolete/pa/tuple_notes.h Removed: misc/obsolete/pa/watcher.c Removed: misc/obsolete/pa/watcher.h Removed: misc/obsolete/pa/winfo_doc.c Removed: misc/obsolete/pa/winfo_doc.h Removed: misc/obsolete/pdt/Makefile Removed: misc/obsolete/pdt/README Removed: misc/obsolete/pdt/doc/Makefile Removed: misc/obsolete/pdt/doc/admin.sql Removed: misc/obsolete/pdt/doc/fifo.sh Removed: misc/obsolete/pdt/doc/fifo.xml Removed: misc/obsolete/pdt/doc/functions.xml Removed: misc/obsolete/pdt/doc/params.xml Removed: misc/obsolete/pdt/doc/pdt.cfg Removed: misc/obsolete/pdt/doc/pdt.sql Removed: misc/obsolete/pdt/doc/pdt.xml Removed: misc/obsolete/pdt/doc/pdt_fifo_add.sh Removed: misc/obsolete/pdt/doc/pdt_fifo_delete.sh Removed: misc/obsolete/pdt/doc/pdt_fifo_list.sh Removed: misc/obsolete/pdt/doc/web/index.php Removed: misc/obsolete/pdt/doc/web/request.php Removed: misc/obsolete/pdt/domains.c Removed: misc/obsolete/pdt/domains.h Removed: misc/obsolete/pdt/pdt.c Removed: misc/obsolete/pdt/pdtree.c Removed: misc/obsolete/pdt/pdtree.h Removed: misc/obsolete/pdt/ser-pdt.cfg Removed: misc/obsolete/permissions/Makefile Removed: misc/obsolete/permissions/README Removed: misc/obsolete/permissions/allow_files.c Removed: misc/obsolete/permissions/allow_files.h Removed: misc/obsolete/permissions/config/permissions.allow Removed: misc/obsolete/permissions/config/permissions.deny Removed: misc/obsolete/permissions/config/register.allow Removed: misc/obsolete/permissions/config/register.deny Removed: misc/obsolete/permissions/doc/Makefile Removed: misc/obsolete/permissions/doc/functions.xml Removed: misc/obsolete/permissions/doc/params.xml Removed: misc/obsolete/permissions/doc/permissions.xml Removed: misc/obsolete/permissions/doc/xmlrpc.xml Removed: misc/obsolete/permissions/im_db.c Removed: misc/obsolete/permissions/im_db.h Removed: misc/obsolete/permissions/im_hash.c Removed: misc/obsolete/permissions/im_hash.h Removed: misc/obsolete/permissions/im_locks.c Removed: misc/obsolete/permissions/im_locks.h Removed: misc/obsolete/permissions/im_rpc.c Removed: misc/obsolete/permissions/im_rpc.h Removed: misc/obsolete/permissions/ip_set.c Removed: misc/obsolete/permissions/ip_set.h Removed: misc/obsolete/permissions/ip_set_rpc.c Removed: misc/obsolete/permissions/ip_set_rpc.h Removed: misc/obsolete/permissions/ip_tree.c Removed: misc/obsolete/permissions/ip_tree.h Removed: misc/obsolete/permissions/ipmatch.c Removed: misc/obsolete/permissions/ipmatch.h Removed: misc/obsolete/permissions/parse_config.c Removed: misc/obsolete/permissions/parse_config.h Removed: misc/obsolete/permissions/permissions.c Removed: misc/obsolete/permissions/permissions.h Removed: misc/obsolete/permissions/permissions_rpc.h Removed: misc/obsolete/permissions/rule.c Removed: misc/obsolete/permissions/rule.h Removed: misc/obsolete/permissions/trusted.c Removed: misc/obsolete/permissions/trusted.h Removed: misc/obsolete/permissions/trusted_hash.c Removed: misc/obsolete/permissions/trusted_hash.h Removed: misc/obsolete/permissions/trusted_rpc.c Removed: misc/obsolete/permissions/trusted_rpc.h Removed: misc/obsolete/pike/Makefile Removed: misc/obsolete/pike/README Removed: misc/obsolete/pike/doc/Makefile Removed: misc/obsolete/pike/doc/devel.xml Removed: misc/obsolete/pike/doc/functions.xml Removed: misc/obsolete/pike/doc/params.xml Removed: misc/obsolete/pike/doc/pike.xml Removed: misc/obsolete/pike/doc/rpc.xml Removed: misc/obsolete/pike/ip_tree.c Removed: misc/obsolete/pike/ip_tree.h Removed: misc/obsolete/pike/pike.c Removed: misc/obsolete/pike/pike_funcs.c Removed: misc/obsolete/pike/pike_funcs.h Removed: misc/obsolete/pike/rpc.c Removed: misc/obsolete/pike/rpc.h Removed: misc/obsolete/pike/timer.c Removed: misc/obsolete/pike/timer.h Removed: misc/obsolete/pike/top.c Removed: misc/obsolete/pike/top.h Removed: misc/obsolete/presence_b2b/ChangeLog Removed: misc/obsolete/presence_b2b/Makefile Removed: misc/obsolete/presence_b2b/README Removed: misc/obsolete/presence_b2b/doc/Makefile Removed: misc/obsolete/presence_b2b/doc/functions.xml Removed: misc/obsolete/presence_b2b/doc/params.xml Removed: misc/obsolete/presence_b2b/doc/presence_b2b.xml Removed: misc/obsolete/presence_b2b/euac_funcs.c Removed: misc/obsolete/presence_b2b/euac_funcs.h Removed: misc/obsolete/presence_b2b/euac_internals.c Removed: misc/obsolete/presence_b2b/euac_internals.h Removed: misc/obsolete/presence_b2b/euac_state_machine.c Removed: misc/obsolete/presence_b2b/euac_state_machine.h Removed: misc/obsolete/presence_b2b/events_mod.c Removed: misc/obsolete/presence_b2b/events_mod.h Removed: misc/obsolete/presence_b2b/events_uac.c Removed: misc/obsolete/presence_b2b/events_uac.h Removed: misc/obsolete/presence_b2b/qsa_events.c Removed: misc/obsolete/presence_b2b/qsa_events.h Removed: misc/obsolete/presence_b2b/rpc.c Removed: misc/obsolete/presence_b2b/rpc.h Removed: misc/obsolete/presence_b2b/trace.h Removed: misc/obsolete/purple/LICENSE Removed: misc/obsolete/purple/Makefile Removed: misc/obsolete/purple/README Removed: misc/obsolete/purple/clientaccount.c Removed: misc/obsolete/purple/clientaccount.h Removed: misc/obsolete/purple/clientops.c Removed: misc/obsolete/purple/clientops.h Removed: misc/obsolete/purple/clientpipe.c Removed: misc/obsolete/purple/clientpipe.h Removed: misc/obsolete/purple/clientsig.c Removed: misc/obsolete/purple/clientsig.h Removed: misc/obsolete/purple/defines.h Removed: misc/obsolete/purple/doc/Makefile Removed: misc/obsolete/purple/doc/purple.xml Removed: misc/obsolete/purple/doc/purple_admin.xml Removed: misc/obsolete/purple/hashtable.c Removed: misc/obsolete/purple/hashtable.h Removed: misc/obsolete/purple/mapping.c Removed: misc/obsolete/purple/mapping.h Removed: misc/obsolete/purple/miniclient.c Removed: misc/obsolete/purple/miniclient.h Removed: misc/obsolete/purple/namespaces.h Removed: misc/obsolete/purple/purple.c Removed: misc/obsolete/purple/purple.h Removed: misc/obsolete/purple/purple_sip.c Removed: misc/obsolete/purple/purple_sip.h Removed: misc/obsolete/purple/purplepipe.c Removed: misc/obsolete/purple/purplepipe.h Removed: misc/obsolete/purple/utils.c Removed: misc/obsolete/purple/utils.h Removed: misc/obsolete/ratelimit/Makefile Removed: misc/obsolete/ratelimit/README Removed: misc/obsolete/ratelimit/doc/Makefile Removed: misc/obsolete/ratelimit/doc/fifo.xml Removed: misc/obsolete/ratelimit/doc/functions.xml Removed: misc/obsolete/ratelimit/doc/params.xml Removed: misc/obsolete/ratelimit/doc/ratelimit.xml Removed: misc/obsolete/ratelimit/ratelimit.c Removed: misc/obsolete/registrar/Makefile Removed: misc/obsolete/registrar/README Removed: misc/obsolete/registrar/common.c Removed: misc/obsolete/registrar/common.h Removed: misc/obsolete/registrar/doc/Makefile Removed: misc/obsolete/registrar/doc/functions.xml Removed: misc/obsolete/registrar/doc/params.xml Removed: misc/obsolete/registrar/doc/registrar.xml Removed: misc/obsolete/registrar/lookup.c Removed: misc/obsolete/registrar/lookup.h Removed: misc/obsolete/registrar/reg_mod.c Removed: misc/obsolete/registrar/reg_mod.h Removed: misc/obsolete/registrar/regtime.c Removed: misc/obsolete/registrar/regtime.h Removed: misc/obsolete/registrar/reply.c Removed: misc/obsolete/registrar/reply.h Removed: misc/obsolete/registrar/rerrno.c Removed: misc/obsolete/registrar/rerrno.h Removed: misc/obsolete/registrar/save.c Removed: misc/obsolete/registrar/save.h Removed: misc/obsolete/registrar/sip_msg.c Removed: misc/obsolete/registrar/sip_msg.h Removed: misc/obsolete/rls/ChangeLog Removed: misc/obsolete/rls/Makefile Removed: misc/obsolete/rls/README Removed: misc/obsolete/rls/db_rls.c Removed: misc/obsolete/rls/doc/Makefile Removed: misc/obsolete/rls/doc/functions.xml Removed: misc/obsolete/rls/doc/params.xml Removed: misc/obsolete/rls/doc/rls.xml Removed: misc/obsolete/rls/doc/rls_base.xml Removed: misc/obsolete/rls/doc/rls_incl.xml Removed: misc/obsolete/rls/doc/xcap.xml Removed: misc/obsolete/rls/result_codes.h Removed: misc/obsolete/rls/rl_subscription.c Removed: misc/obsolete/rls/rl_subscription.h Removed: misc/obsolete/rls/rlmi_doc.c Removed: misc/obsolete/rls/rlmi_doc.h Removed: misc/obsolete/rls/rls.sql Removed: misc/obsolete/rls/rls_auth.c Removed: misc/obsolete/rls/rls_auth.h Removed: misc/obsolete/rls/rls_data.c Removed: misc/obsolete/rls/rls_data.h Removed: misc/obsolete/rls/rls_handler.c Removed: misc/obsolete/rls/rls_handler.h Removed: misc/obsolete/rls/rls_mod.c Removed: misc/obsolete/rls/rls_mod.h Removed: misc/obsolete/rls/rpc.c Removed: misc/obsolete/rls/rpc.h Removed: misc/obsolete/rls/subscription_manager.c Removed: misc/obsolete/rls/subscription_manager.h Removed: misc/obsolete/rls/time_event_manager.c Removed: misc/obsolete/rls/time_event_manager.h Removed: misc/obsolete/rls/trace.h Removed: misc/obsolete/rls/uri_ops.c Removed: misc/obsolete/rls/uri_ops.h Removed: misc/obsolete/rls/virtual_subscription.c Removed: misc/obsolete/rr/Makefile Removed: misc/obsolete/rr/README Removed: misc/obsolete/rr/avp_cookie.c Removed: misc/obsolete/rr/avp_cookie.h Removed: misc/obsolete/rr/doc/Makefile Removed: misc/obsolete/rr/doc/functions.xml Removed: misc/obsolete/rr/doc/loose_vs_strict_routing.dia Removed: misc/obsolete/rr/doc/loose_vs_strict_routing.png Removed: misc/obsolete/rr/doc/params.xml Removed: misc/obsolete/rr/doc/rr.xml Removed: misc/obsolete/rr/fix_lumps.h Removed: misc/obsolete/rr/loose.c Removed: misc/obsolete/rr/loose.h Removed: misc/obsolete/rr/record.c Removed: misc/obsolete/rr/record.h Removed: misc/obsolete/rr/rr_mod.c Removed: misc/obsolete/rr/rr_mod.h Removed: misc/obsolete/speeddial/Makefile Removed: misc/obsolete/speeddial/README Removed: misc/obsolete/speeddial/doc/Makefile Removed: misc/obsolete/speeddial/doc/faq.xml Removed: misc/obsolete/speeddial/doc/functions.xml Removed: misc/obsolete/speeddial/doc/params.xml Removed: misc/obsolete/speeddial/doc/speeddial.cfg Removed: misc/obsolete/speeddial/doc/speeddial.sql Removed: misc/obsolete/speeddial/doc/speeddial.xml Removed: misc/obsolete/speeddial/sdlookup.c Removed: misc/obsolete/speeddial/sdlookup.h Removed: misc/obsolete/speeddial/speeddial.c Removed: misc/obsolete/speeddial/speeddial.h Removed: misc/obsolete/textops/Makefile Removed: misc/obsolete/textops/README Removed: misc/obsolete/textops/doc/Makefile Removed: misc/obsolete/textops/doc/functions.xml Removed: misc/obsolete/textops/doc/params.xml Removed: misc/obsolete/textops/doc/textops.xml Removed: misc/obsolete/textops/textops.c Removed: misc/obsolete/uac/Makefile Removed: misc/obsolete/uac/README Removed: misc/obsolete/uac/auth.c Removed: misc/obsolete/uac/auth.h Removed: misc/obsolete/uac/auth_alg.c Removed: misc/obsolete/uac/auth_alg.h Removed: misc/obsolete/uac/auth_hdr.c Removed: misc/obsolete/uac/auth_hdr.h Removed: misc/obsolete/uac/doc/Makefile Removed: misc/obsolete/uac/doc/functions.xml Removed: misc/obsolete/uac/doc/params.xml Removed: misc/obsolete/uac/doc/replace_from.patch Removed: misc/obsolete/uac/doc/uac.xml Removed: misc/obsolete/uac/from.c Removed: misc/obsolete/uac/from.h Removed: misc/obsolete/uac/uac.c Removed: misc/obsolete/unixsock/Makefile Removed: misc/obsolete/unixsock/README Removed: misc/obsolete/unixsock/unixsock.c Removed: misc/obsolete/unixsock/unixsock_server.c Removed: misc/obsolete/unixsock/unixsock_server.h Removed: misc/obsolete/uri/Makefile Removed: misc/obsolete/uri/README Removed: misc/obsolete/uri/checks.c Removed: misc/obsolete/uri/checks.h Removed: misc/obsolete/uri/doc/Makefile Removed: misc/obsolete/uri/doc/functions.xml Removed: misc/obsolete/uri/doc/params.xml Removed: misc/obsolete/uri/doc/uri.xml Removed: misc/obsolete/uri/uri_mod.c Removed: misc/obsolete/uri/uri_mod.h Removed: misc/obsolete/uri_radius/Makefile Removed: misc/obsolete/uri_radius/README Removed: misc/obsolete/uri_radius/checks.c Removed: misc/obsolete/uri_radius/checks.h Removed: misc/obsolete/uri_radius/doc/Makefile Removed: misc/obsolete/uri_radius/doc/functions.xml Removed: misc/obsolete/uri_radius/doc/params.xml Removed: misc/obsolete/uri_radius/doc/uri_radius.xml Removed: misc/obsolete/uri_radius/urirad_mod.c Removed: misc/obsolete/uri_radius/urirad_mod.h Removed: misc/obsolete/usrloc/Makefile Removed: misc/obsolete/usrloc/README Removed: misc/obsolete/usrloc/dlist.c Removed: misc/obsolete/usrloc/dlist.h Removed: misc/obsolete/usrloc/doc/Makefile Removed: misc/obsolete/usrloc/doc/api.xml Removed: misc/obsolete/usrloc/doc/functions.xml Removed: misc/obsolete/usrloc/doc/params.xml Removed: misc/obsolete/usrloc/doc/usrloc.xml Removed: misc/obsolete/usrloc/doc/usrloc_states_w_zombie.png Removed: misc/obsolete/usrloc/doc/usrloc_states_w_zombie.vsd Removed: misc/obsolete/usrloc/hslot.c Removed: misc/obsolete/usrloc/hslot.h Removed: misc/obsolete/usrloc/notify.c Removed: misc/obsolete/usrloc/notify.h Removed: misc/obsolete/usrloc/reg_avps.c Removed: misc/obsolete/usrloc/reg_avps.h Removed: misc/obsolete/usrloc/reg_avps_db.c Removed: misc/obsolete/usrloc/reg_avps_db.h Removed: misc/obsolete/usrloc/ucontact.c Removed: misc/obsolete/usrloc/ucontact.h Removed: misc/obsolete/usrloc/udomain.c Removed: misc/obsolete/usrloc/udomain.h Removed: misc/obsolete/usrloc/ul_callback.c Removed: misc/obsolete/usrloc/ul_callback.h Removed: misc/obsolete/usrloc/ul_mod.c Removed: misc/obsolete/usrloc/ul_mod.h Removed: misc/obsolete/usrloc/ul_rpc.c Removed: misc/obsolete/usrloc/ul_rpc.h Removed: misc/obsolete/usrloc/urecord.c Removed: misc/obsolete/usrloc/urecord.h Removed: misc/obsolete/usrloc/usrloc.c Removed: misc/obsolete/usrloc/usrloc.h Removed: misc/obsolete/usrloc/utime.c Removed: misc/obsolete/usrloc/utime.h Removed: misc/obsolete/xcap/ChangeLog Removed: misc/obsolete/xcap/Makefile Removed: misc/obsolete/xcap/README Removed: misc/obsolete/xcap/doc/Makefile Removed: misc/obsolete/xcap/doc/functions.xml Removed: misc/obsolete/xcap/doc/params.xml Removed: misc/obsolete/xcap/doc/xcap.xml Removed: misc/obsolete/xcap/xcap_mod.c Removed: misc/obsolete/xcap/xcap_mod.h Removed: misc/obsolete/xcap/xcap_params.c Removed: misc/obsolete/xcap/xcap_params.h --- Diff: https://github.com/kamailio/kamailio/commit/eff1e2c6a2ccceae1ddfc81298cbdcc… Patch: https://github.com/kamailio/kamailio/commit/eff1e2c6a2ccceae1ddfc81298cbdcc…

1 0

git:master:8deecb1a: modules: readme files regenerated - acc ... [skip ci]
by Kamailio Dev 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: 8deecb1aef4ee33d12ee0da68bf3585162284820 URL: https://github.com/kamailio/kamailio/commit/8deecb1aef4ee33d12ee0da68bf3585… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-09T09:16:30+02:00 modules: readme files regenerated - acc ... [skip ci] --- Modified: src/modules/acc/README --- Diff: https://github.com/kamailio/kamailio/commit/8deecb1aef4ee33d12ee0da68bf3585… Patch: https://github.com/kamailio/kamailio/commit/8deecb1aef4ee33d12ee0da68bf3585… --- diff --git a/src/modules/acc/README b/src/modules/acc/README index 07362dd852..581aaca80a 100644 --- a/src/modules/acc/README +++ b/src/modules/acc/README @@ -134,7 +134,8 @@ Sven Knoblich 7.1. acc_log_request(comment) 7.2. acc_db_request(comment, table) - 7.3. acc_diam_request(comment) + 7.3. acc_request(comment, table) + 7.4. acc_diam_request(comment) 2. Frequently Asked Questions @@ -192,7 +193,8 @@ Sven Knoblich 1.50. cdr_on_failed 1.51. acc_log_request usage 1.52. acc_db_request usage - 1.53. acc_diam_request usage + 1.53. acc_db_request usage + 1.54. acc_diam_request usage Chapter 1. Admin Guide @@ -292,7 +294,8 @@ Chapter 1. Admin Guide 7.1. acc_log_request(comment) 7.2. acc_db_request(comment, table) - 7.3. acc_diam_request(comment) + 7.3. acc_request(comment, table) + 7.4. acc_diam_request(comment) 1. Overview @@ -1342,7 +1345,8 @@ modparam("acc", "cdr_on_failed", 0) 7.1. acc_log_request(comment) 7.2. acc_db_request(comment, table) - 7.3. acc_diam_request(comment) + 7.3. acc_request(comment, table) + 7.4. acc_diam_request(comment) 7.1. acc_log_request(comment) @@ -1386,7 +1390,31 @@ acc_db_request("Some comment", "acc_$time(year)_$time(mon)"); acc_db_request("$var(code) Error: $avp(reason)", "SomeTable"); ... -7.3. acc_diam_request(comment) +7.3. acc_request(comment, table) + + Warapper around acc_log_request and acc_db_request functions, writing + the accounting record to LOG and DATABASE backends. If “db_url” + parameter is not set, the acc record is written only to LOG backend. + + Meaning of the parameters is as follows: + * comment - Comment to be used for generating the SIP response code + and text fields, if in the format “CODE TEXT”. The CODE should be a + valid SIP response code (100..699). The TEXT can be one or many + words. If CODE is missing, then 0 is used. The parameter can + contain pseudo-variables. + * table - Database table to be used. It can contain config variables + that are evaluated at runtime. + + This function can be used from ANY_ROUTE. + + Example 1.53. acc_db_request usage +... +acc_request("100 Received", "acc"); +acc_request("100 Received", "acc_$time(year)_$time(mon)"); +acc_db_request("$var(code) $avp(reason)", "acc"); +... + +7.4. acc_diam_request(comment) Like acc_log_request, acc_diam_request reports on a request. It reports to the configured Diameter server. @@ -1397,7 +1425,7 @@ acc_db_request("$var(code) Error: $avp(reason)", "SomeTable"); This function can be used from ANY_ROUTE. - Example 1.53. acc_diam_request usage + Example 1.54. acc_diam_request usage ... acc_diam_request("Some comment"); acc_diam_request("$var(code) Error: $avp(reason)");

1 0

git:master:4a545bac: acc: documented acc_request() function
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: 4a545bacf6517663830ca455b61a12ff38b22fe8 URL: https://github.com/kamailio/kamailio/commit/4a545bacf6517663830ca455b61a12f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T09:12:50+02:00 acc: documented acc_request() function --- Modified: src/modules/acc/doc/acc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/4a545bacf6517663830ca455b61a12f… Patch: https://github.com/kamailio/kamailio/commit/4a545bacf6517663830ca455b61a12f…

1 0

git:master:42bdac92: acc: added acc_request(reason, table)
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: 42bdac92d1ad2f58d7c21f98c3b8483e86a39fb8 URL: https://github.com/kamailio/kamailio/commit/42bdac92d1ad2f58d7c21f98c3b8483… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T08:59:00+02:00 acc: added acc_request(reason, table) - wrapper around acc_log_request() and acc_db_request(), writting acc record to log and db backend (if db_url is set) --- Modified: src/modules/acc/acc.c Modified: src/modules/acc/acc.h Modified: src/modules/acc/acc_logic.c Modified: src/modules/acc/acc_logic.h Modified: src/modules/acc/acc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/42bdac92d1ad2f58d7c21f98c3b8483… Patch: https://github.com/kamailio/kamailio/commit/42bdac92d1ad2f58d7c21f98c3b8483…

1 0

[kamailio/kamailio] path: rr_callback wrong dst uri (#1205)
by Rick 09 Aug '17

09 Aug '17

### Description Im using the path module on loadbalancer, the update to the path module, seems to break the default behavior.  ### Troubleshooting #### Reproduction ``` /* ----- rr params --------------------------------------------------------- */ /** add value to ;lr param (helps with some UAs) */ modparam("rr", "enable_full_lr", 1) modparam("rr", "append_fromtag", 1) /* ----- maxfwd params ----------------------------------------------------- */ modparam("maxfwd", "max_limit", 70) /* ----- path params ------------------------------------------------------- */ modparam("path", "use_received", 1) ``` #### Debugging Data #### Log Messages  ``` 2(71369) DEBUG: rr [loose.c:85]: is_preloaded(): is_preloaded: Yes 2(71369) DEBUG: <core> [core/socket_info.c:564]: grep_sock_info(): checking if host==us: 12==12 && [x.x.x.126] == [x.x.x.126] 2(71369) DEBUG: <core> [core/socket_info.c:567]: grep_sock_info(): checking if port 5060 (advertise 0) matches port 5060 2(71369) DEBUG: rr [loose.c:788]: after_loose(): Topmost route URI: 'sip:x.x.x.126;lr;received=sip:y.y.y.y:47056%3Btransport%3Dtls' is me 2(71369) DEBUG: <core> [core/parser/msg_parser.c:89]: get_hdr_field(): found end of header 2(71369) DEBUG: rr [loose.c:180]: find_next_route(): No next Route HF found 2(71369) DEBUG: rr [loose.c:813]: after_loose(): No next URI found 2(71369) DEBUG: rr [rr_cb.c:95]: run_rr_callbacks(): callback id 0 entered with <lr;received=sip:y.y.y.y:47056%3Btransport%3Dtls> 2(71369) DEBUG: <core> [core/strutils.c:214]: unescape_user(): unescaped string is <sip:y.y.y.y:47056;transport=tls> 2(71369) DEBUG: path [path.c:424]: path_rr_callback(): setting dst uri: sip:sip:y.y.y.y:47056%3Btranspo 2(71369) DEBUG: pv [pv_core.c:951]: pv_get_useragent(): no User-Agent header 2(71369) DEBUG: rr [loose.c:1068]: check_route_param(): route params checking against [;lr;received=sip:y.y.y.y:47056%3Btransport%3Dtls] (orig: [lr;received=sip:y.y.y.y:47056%3Btransport%3Dtls]) 2(71369) DEBUG: rr [loose.c:1073]: check_route_param(): params are <;lr;received=sip:y.y.y.y:47056%3Btransport%3Dtls> 2(71369) DEBUG: tm [t_lookup.c:1302]: t_newtran(): msg id=4 , global msg id=4 , T on entrance=0x0 2(71369) DEBUG: tm [t_lookup.c:459]: t_lookup_request(): start searching: hash=16463, isACK=0 2(71369) DEBUG: tm [t_lookup.c:417]: matching_3261(): RFC3261 transaction matching failed 2(71369) DEBUG: tm [t_lookup.c:641]: t_lookup_request(): no transaction found 2(71369) DEBUG: <core> [core/md5utils.c:67]: MD5StringArray(): MD5 calculated: 076837eff630cf1e80bed191da066432 2(71369) DEBUG: <core> [core/parser/parse_uri.c:1262]: parse_uri(): parse_uri: bad char ':' in state 3 parsed: <sip:sip:y.y.y.y> (21) / <sip:sip:y.y.y.y:47056%3Btranspo> (37) 2(71369) ERROR: tm [./ut.h:245]: uri2dst2(): bad_uri: [sip:sip:y.y.y.y:47056%3Btranspo] 2(71369) ERROR: tm [t_fwd.c:1735]: t_forward_nonack(): failure to add branches 2(71369) DEBUG: tm [t_funcs.c:330]: t_relay_to(): t_forward_nonack returned error -478 (-478) 2(71369) DEBUG: tm [t_funcs.c:348]: t_relay_to(): -478 error reply generation delayed 2(71369) DEBUG: <core> [core/msg_translator.c:159]: check_via_address(): (x.x.x.124, x.x.x.124, 0) 2(71369) ERROR: sl [sl_funcs.c:362]: sl_reply_error(): stateless error reply used: Unresolvable destination (478/SL) 2(71369) DEBUG: <core> [core/receive.c:283]: receive_msg(): request-route executed in: 2594 usec 2(71369) DEBUG: tm [t_lookup.c:1458]: t_unref(): delayed error reply generation(-478) 2(71369) DEBUG: <core> [core/msg_translator.c:159]: check_via_address(): (x.x.x.124, x.x.x.124, 0) 2(71369) DEBUG: tm [t_reply.c:1631]: cleanup_uac_timers(): RETR/FR timers reset 2(71369) DEBUG: tm [t_reply.c:598]: _reply_light(): reply sent out. buf=0x8018e77b0: SIP/2.0 478 Unresolv..., shmem=0x8086bbc30: SIP/2.0 478 Unresolv 2(71369) DEBUG: tm [t_reply.c:608]: _reply_light(): finished ``` #### SIP Traffic  ``` 2017/08/04 10:27:55.690224 x.x.x.124:5060 -> x.x.x.126:5060 OPTIONS sip:user@y.y.y.y:43098;transport=TLS SIP/2.0 Via: SIP/2.0/UDP x.x.x.124:5060;branch=z9hG4bK2840489 Route: <sip:x.x.x.126;lr;received=sip:y.y.y.y:43098%3Btransport%3Dtls> From: sip:pinger@hostname-xxx;tag=uloc-7c-5982da6d-4c09-11-0-7d68 To: sip:user@y.y.y.y:43098;transport=TLS Call-ID: 1e57ca12-c3d5f614-8b5c49(a)5.159.56.124 CSeq: 1 OPTIONS Content-Length: 0 ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` # kamailio -v version: kamailio 5.1.0-dev5 (x86_64/freebsd) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, select, kqueue. id: unknown compiled on 23:35:16 Aug 3 2017 with clang 3.8 ``` * **Operating System**:  ``` # uname -a FreeBSD hostname-xxx 11.0-RELEASE-p9 FreeBSD 11.0-RELEASE-p9 #0: Tue Apr 11 08:48:40 UTC 2017 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1205

2 9

git:master:5989ab74: path: fix offset to set ending 0 for received_format=1
by Daniel-Constantin Mierla 08 Aug '17

08 Aug '17

Module: kamailio Branch: master Commit: 5989ab742685840019dea65c34df7a535d3950b8 URL: https://github.com/kamailio/kamailio/commit/5989ab742685840019dea65c34df7a5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-08T21:35:06+02:00 path: fix offset to set ending 0 for received_format=1 --- Modified: src/modules/path/path.c --- Diff: https://github.com/kamailio/kamailio/commit/5989ab742685840019dea65c34df7a5… Patch: https://github.com/kamailio/kamailio/commit/5989ab742685840019dea65c34df7a5… --- diff --git a/src/modules/path/path.c b/src/modules/path/path.c index 01d49253ec..2f1d84e8e2 100644 --- a/src/modules/path/path.c +++ b/src/modules/path/path.c @@ -387,7 +387,7 @@ void path_rr_callback(struct sip_msg *_m, str *r_param, void *cb_param) strncpy(dst_uri_buf, "sip:", 4); strncpy(dst_uri_buf+4, hooks.contact.received->body.s, hooks.contact.received->body.len); - dst_uri_buf[hooks.contact.received->body.len] = '\0'; + dst_uri_buf[4+hooks.contact.received->body.len] = '\0'; p = dst_uri_buf + 4; n = 0; while(*p!='\0') {

1 0

git:master:557bbe30: http_async_client: named addition processes http async worker
by Daniel-Constantin Mierla 08 Aug '17

08 Aug '17

Module: kamailio Branch: master Commit: 557bbe3042b31b8087d40a41b9d304e731ce06b9 URL: https://github.com/kamailio/kamailio/commit/557bbe3042b31b8087d40a41b9d304e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-08T17:19:47+02:00 http_async_client: named addition processes http async worker - reflects better the module --- Modified: src/modules/http_async_client/http_async_client_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/557bbe3042b31b8087d40a41b9d304e… Patch: https://github.com/kamailio/kamailio/commit/557bbe3042b31b8087d40a41b9d304e… --- diff --git a/src/modules/http_async_client/http_async_client_mod.c b/src/modules/http_async_client/http_async_client_mod.c index c1f0f1d1df..ed52110d04 100644 --- a/src/modules/http_async_client/http_async_client_mod.c +++ b/src/modules/http_async_client/http_async_client_mod.c @@ -346,7 +346,7 @@ static int child_init(int rank) LM_ERR("failed to initialize worker process: %d\n", i); return -1; } - pid=fork_process(PROC_RPC, "Http Worker", 1); + pid=fork_process(PROC_RPC, "Http Async Worker", 1); if (pid<0) return -1; /* error */ if(pid==0) {

1 0

git:master:5f5697ea: http_async_client: safety check for shm malloc and do cfg_update()
by Daniel-Constantin Mierla 08 Aug '17

08 Aug '17

Module: kamailio Branch: master Commit: 5f5697eac0089e9e2bc72323c6afa839b472ccbd URL: https://github.com/kamailio/kamailio/commit/5f5697eac0089e9e2bc72323c6afa83… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-08T17:20:33+02:00 http_async_client: safety check for shm malloc and do cfg_update() --- Modified: src/modules/http_async_client/async_http.c --- Diff: https://github.com/kamailio/kamailio/commit/5f5697eac0089e9e2bc72323c6afa83… Patch: https://github.com/kamailio/kamailio/commit/5f5697eac0089e9e2bc72323c6afa83… --- diff --git a/src/modules/http_async_client/async_http.c b/src/modules/http_async_client/async_http.c index 5c1d249ff3..5057908478 100644 --- a/src/modules/http_async_client/async_http.c +++ b/src/modules/http_async_client/async_http.c @@ -70,6 +70,10 @@ int async_http_init_worker(int prank, async_http_worker_t* worker) LM_DBG("base event %p created\n", worker->evbase); worker->g = shm_malloc(sizeof(struct http_m_global)); + if(worker->g==NULL) { + LM_ERR("out of shared memory\n"); + return -1; + } memset(worker->g, 0, sizeof(http_m_global_t)); LM_DBG("initialized global struct %p\n", worker->g); @@ -189,6 +193,7 @@ void async_http_cb(struct http_m_reply *reply, void *param) strncpy(q_id, aq->id, strlen(aq->id)); act = (cfg_action_t*)aq->param; + cfg_update(); if (aq->query_params.suspend_transaction) { tindex = aq->tindex;

1 0

git:master:f4fa3104: topos: link sip message attributes before PRACK handling
by Daniel-Constantin Mierla 08 Aug '17

08 Aug '17

Module: kamailio Branch: master Commit: f4fa310479ce824c9fd68a7ef443102c30a0c171 URL: https://github.com/kamailio/kamailio/commit/f4fa310479ce824c9fd68a7ef443102… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-08T17:02:38+02:00 topos: link sip message attributes before PRACK handling --- Modified: src/modules/topos/tps_msg.c Modified: src/modules/topos/tps_storage.h --- Diff: https://github.com/kamailio/kamailio/commit/f4fa310479ce824c9fd68a7ef443102… Patch: https://github.com/kamailio/kamailio/commit/f4fa310479ce824c9fd68a7ef443102… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index 8adfa31129..ca360a975c 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -763,6 +763,9 @@ int tps_request_received(sip_msg_t *msg, int dialog) tps_storage_lock_get(&lkey); if((get_cseq(msg)->method_id)&(METHOD_PRACK)) { + if(tps_storage_link_msg(msg, &mtsd, TPS_DIR_DOWNSTREAM)<0) { + goto error; + } if(tps_storage_load_branch(msg, &mtsd, &stsd, 1)<0) { goto error; } diff --git a/src/modules/topos/tps_storage.h b/src/modules/topos/tps_storage.h index 2336687a75..c10c3f2699 100644 --- a/src/modules/topos/tps_storage.h +++ b/src/modules/topos/tps_storage.h @@ -102,6 +102,8 @@ int tps_storage_lock_get(str *lkey); int tps_storage_lock_release(str *lkey); int tps_storage_lock_set_destroy(void); +int tps_storage_link_msg(sip_msg_t *msg, tps_data_t *td, int dir); + void tps_storage_clean(unsigned int ticks, void* param); #endif

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev