<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This adds RPC command to view and/or change the timeout value for PDB queries. The documentation is also updated accordingly.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4254
-- Commit Summary --
* pdb: added rpc command to view/update the pdb query timeout
* pdb: add documentation for rpc command to view/update the pdb query timeout
-- File Changes --
M src/modules/pdb/doc/pdb.xml (55)
M src/modules/pdb/doc/pdb_admin.xml (334)
M src/modules/pdb/pdb.c (49)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4254.patchhttps://github.com/kamailio/kamailio/pull/4254.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4254
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4254(a)github.com>
- [x ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
Added missing kemi exports for RTP Engine module play_dtmf event_callback functions and Dialog module dlg_req_within function
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4245
-- Commit Summary --
* Add support for playing DTMF tones in RTP engine module using Kemi
* Add support for KEMI callbacks in RTP engine events
* Add `ki_dlg_req_within4` handling for dialog requests
-- File Changes --
M src/modules/dialog/dialog.c (24)
M src/modules/rtpengine/rtpengine.c (215)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4245.patchhttps://github.com/kamailio/kamailio/pull/4245.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4245
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4245(a)github.com>
Module: kamailio
Branch: master
Commit: df8e38958a3fa0a2e356bec727bb8d7ce19bec43
URL: https://github.com/kamailio/kamailio/commit/df8e38958a3fa0a2e356bec727bb8d7…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2025-05-27T08:58:17+02:00
secfilter: remove unnecessary check on clean up
---
Modified: src/modules/secfilter/secfilter_db.c
---
Diff: https://github.com/kamailio/kamailio/commit/df8e38958a3fa0a2e356bec727bb8d7…
Patch: https://github.com/kamailio/kamailio/commit/df8e38958a3fa0a2e356bec727bb8d7…
---
diff --git a/src/modules/secfilter/secfilter_db.c b/src/modules/secfilter/secfilter_db.c
index 1c0138b0193..24884b231c9 100644
--- a/src/modules/secfilter/secfilter_db.c
+++ b/src/modules/secfilter/secfilter_db.c
@@ -185,9 +185,9 @@ int secf_append_rule(int action, int type, str *value)
/**
* @brief Removes entries from a whitelist or blacklist based on action, type, and value.
*
- * The function validates the action and type, locates the relevant list, and iterates
- * through its nodes to find and remove all matches for the given value. If matches are found,
- * the corresponding memory is freed, and the list pointers are updated. Logs are generated
+ * The function validates the action and type, locates the relevant list, and iterates
+ * through its nodes to find and remove all matches for the given value. If matches are found,
+ * the corresponding memory is freed, and the list pointers are updated. Logs are generated
* for each removal and at the end of the process to summarize the result.
* @param action: Specifies the target list (0 = blacklist, 1 = whitelist, 2 = destination blacklist).
* @param type: Indicates the type of rule to be removed (e.g., domain, IP, user, etc.).
@@ -358,10 +358,8 @@ int secf_load_db(void)
lock_release(&(*secf_data)->lock);
clean:
- if(db_res) {
- if(db_funcs.free_result(db_handle, db_res) < 0) {
- LM_DBG("Failed to free the result\n");
- }
+ if(db_funcs.free_result(db_handle, db_res) < 0) {
+ LM_DBG("Failed to free the result\n");
}
db_funcs.close(db_handle);
return res;
sergey-safarov created an issue (kamailio/kamailio#4255)
### Description
I now make testing `cmake` packaging and see this error
```
RPM build errors:
Directory not found: /root/rpmbuild/BUILDROOT/kamailio-6.1.0-dev1.0.el10.centos.x86_64/usr/share/kamailio/postgres
File not found: /root/rpmbuild/BUILDROOT/kamailio-6.1.0-dev1.0.el10.centos.x86_64/usr/share/kamailio/postgres/*
```
### Troubleshooting
#### Reproduction
I use this module list for build
https://github.com/sergey-safarov/kamailio/blob/master/pkg/kamailio/obs/kam…
@xkaraman could you look?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4255
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4255(a)github.com>