sr-dev May 2025

sr-dev@lists.kamailio.org

15 participants
192 discussions

[kamailio/kamailio] PDB: add RPC command to get and set PDB query timeout (PR #4254)
by Muhammad Shahzad Shafi 27 May '25

27 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This adds RPC command to view and/or change the timeout value for PDB queries. The documentation is also updated accordingly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4254 -- Commit Summary -- * pdb: added rpc command to view/update the pdb query timeout * pdb: add documentation for rpc command to view/update the pdb query timeout -- File Changes -- M src/modules/pdb/doc/pdb.xml (55) M src/modules/pdb/doc/pdb_admin.xml (334) M src/modules/pdb/pdb.c (49) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4254.patch https://github.com/kamailio/kamailio/pull/4254.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4254 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4254(a)github.com>

3 8

[kamailio/kamailio] Adding kemi exports for play_dtmf event_callback and dlg_req_within functions (PR #4245)
by ggontariu 27 May '25

27 May '25

- [x ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Added missing kemi exports for RTP Engine module play_dtmf event_callback functions and Dialog module dlg_req_within function You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4245 -- Commit Summary -- * Add support for playing DTMF tones in RTP engine module using Kemi * Add support for KEMI callbacks in RTP engine events * Add `ki_dlg_req_within4` handling for dialog requests -- File Changes -- M src/modules/dialog/dialog.c (24) M src/modules/rtpengine/rtpengine.c (215) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4245.patch https://github.com/kamailio/kamailio/pull/4245.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4245 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4245(a)github.com>

2 17

git:master:472dbb59: dialog: Kemi export dlg_req_within
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 472dbb59006207629e9724b7d7155719cb653969 URL: https://github.com/kamailio/kamailio/commit/472dbb59006207629e9724b7d715571… Author: gabrielgontariu <114484712+gabrielgontariu(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T09:31:56+02:00 dialog: Kemi export dlg_req_within --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/472dbb59006207629e9724b7d715571… Patch: https://github.com/kamailio/kamailio/commit/472dbb59006207629e9724b7d715571… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 4539d1657e2..36af6f54404 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -2615,6 +2615,27 @@ static int ki_dlg_var_is_null(sip_msg_t *msg, str *name) return -1; } +/** + * + */ +static int ki_dlg_req_within4(struct sip_msg *msg, str *side, str *method, + str *content_type, str *content) +{ + int n = 0; + if(side && side->len > 0) { + if(side->len == 6 && strncasecmp(side->s, "caller", 6) == 0) { + n = 1; + } else if(side->len == 6 && strncasecmp(side->s, "callee", 6) == 0) { + n = 2; + } else { + return -1; + } + } + + return ki_dlg_req_with_headers_and_content( + msg, n, method, NULL, content_type, content); +} + /** * */ @@ -2780,6 +2801,11 @@ static sr_kemi_t sr_kemi_dialog_exports[] = { { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("dialog"), str_init("dlg_req_within4"), + SR_KEMIP_INT, ki_dlg_req_within4, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, + SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

1 0

git:master:c52bf0aa: rtpengine: Kemi export play_dtmf and event_callback. Enhance support for dtmf event by adding support for source_label, tags, source_ip, type, volume and duration
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: c52bf0aaa4ad2bc53ede2eeb5df0d8a9bff0e140 URL: https://github.com/kamailio/kamailio/commit/c52bf0aaa4ad2bc53ede2eeb5df0d8a… Author: gabrielgontariu <114484712+gabrielgontariu(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T09:31:56+02:00 rtpengine: Kemi export play_dtmf and event_callback. Enhance support for dtmf event by adding support for source_label, tags, source_ip, type, volume and duration --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/c52bf0aaa4ad2bc53ede2eeb5df0d8a… Patch: https://github.com/kamailio/kamailio/commit/c52bf0aaa4ad2bc53ede2eeb5df0d8a…

1 0

git:master:25daa044: pv_headers: set value after checking if src is set
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 25daa0445ebc611cda3e47fd34aefc74494550d7 URL: https://github.com/kamailio/kamailio/commit/25daa0445ebc611cda3e47fd34aefc7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T08:59:16+02:00 pv_headers: set value after checking if src is set --- Modified: src/modules/pv_headers/pvh_str.c --- Diff: https://github.com/kamailio/kamailio/commit/25daa0445ebc611cda3e47fd34aefc7… Patch: https://github.com/kamailio/kamailio/commit/25daa0445ebc611cda3e47fd34aefc7… --- diff --git a/src/modules/pv_headers/pvh_str.c b/src/modules/pv_headers/pvh_str.c index 28908a37069..1916f93e002 100644 --- a/src/modules/pv_headers/pvh_str.c +++ b/src/modules/pv_headers/pvh_str.c @@ -50,11 +50,12 @@ int pvh_str_free(str *s) int pvh_str_copy(str *dst, str *src, unsigned int max_size) { - unsigned int src_len = src->len + 1 >= max_size ? max_size - 1 : src->len; + unsigned int src_len = 0; if(src == NULL || dst == NULL || src->len <= 0) return -1; + src_len = src->len + 1 >= max_size ? max_size - 1 : src->len; memset(dst->s, 0, dst->len); memcpy(dst->s, src->s, src_len); dst->s[src_len] = '\0';

1 0

git:master:df8e3895: secfilter: remove unnecessary check on clean up
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: df8e38958a3fa0a2e356bec727bb8d7ce19bec43 URL: https://github.com/kamailio/kamailio/commit/df8e38958a3fa0a2e356bec727bb8d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T08:58:17+02:00 secfilter: remove unnecessary check on clean up --- Modified: src/modules/secfilter/secfilter_db.c --- Diff: https://github.com/kamailio/kamailio/commit/df8e38958a3fa0a2e356bec727bb8d7… Patch: https://github.com/kamailio/kamailio/commit/df8e38958a3fa0a2e356bec727bb8d7… --- diff --git a/src/modules/secfilter/secfilter_db.c b/src/modules/secfilter/secfilter_db.c index 1c0138b0193..24884b231c9 100644 --- a/src/modules/secfilter/secfilter_db.c +++ b/src/modules/secfilter/secfilter_db.c @@ -185,9 +185,9 @@ int secf_append_rule(int action, int type, str *value) /** * @brief Removes entries from a whitelist or blacklist based on action, type, and value. * - * The function validates the action and type, locates the relevant list, and iterates - * through its nodes to find and remove all matches for the given value. If matches are found, - * the corresponding memory is freed, and the list pointers are updated. Logs are generated + * The function validates the action and type, locates the relevant list, and iterates + * through its nodes to find and remove all matches for the given value. If matches are found, + * the corresponding memory is freed, and the list pointers are updated. Logs are generated * for each removal and at the end of the process to summarize the result. * @param action: Specifies the target list (0 = blacklist, 1 = whitelist, 2 = destination blacklist). * @param type: Indicates the type of rule to be removed (e.g., domain, IP, user, etc.). @@ -358,10 +358,8 @@ int secf_load_db(void) lock_release(&(*secf_data)->lock); clean: - if(db_res) { - if(db_funcs.free_result(db_handle, db_res) < 0) { - LM_DBG("Failed to free the result\n"); - } + if(db_funcs.free_result(db_handle, db_res) < 0) { + LM_DBG("Failed to free the result\n"); } db_funcs.close(db_handle); return res;

1 0

git:master:5c38b53b: dialog: check for message struct before accessing the fields
by Daniel-Constantin Mierla 26 May '25

26 May '25

Module: kamailio Branch: master Commit: 5c38b53b902949fa48c3bc60288514cd7c555d5b URL: https://github.com/kamailio/kamailio/commit/5c38b53b902949fa48c3bc60288514c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-26T19:24:49+02:00 dialog: check for message struct before accessing the fields - for build_dlg_t_early() --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/5c38b53b902949fa48c3bc60288514c… Patch: https://github.com/kamailio/kamailio/commit/5c38b53b902949fa48c3bc60288514c… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 7645ebeca37..9ffd65e9526 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -494,7 +494,12 @@ dlg_t *build_dlg_t_early( goto error; } - if(msg == NULL || msg->first_line.type != SIP_REPLY) { + if(msg == NULL) { + LM_ERR("no sip message\n"); + goto error; + } + + if(msg->first_line.type != SIP_REPLY) { if(!cell->t) { LM_ERR("no transaction associated\n"); goto error;

1 0

git:master:46548193: pua_dialoginfo.c: fix condition for refresh_pubruri_avps_flag
by Daniel-Constantin Mierla 26 May '25

26 May '25

Module: kamailio Branch: master Commit: 46548193144c0b8ab0bf2e3ecdfd7feb79bc3b2f URL: https://github.com/kamailio/kamailio/commit/46548193144c0b8ab0bf2e3ecdfd7fe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-26T19:16:55+02:00 pua_dialoginfo.c: fix condition for refresh_pubruri_avps_flag --- Modified: src/modules/pua_dialoginfo/pua_dialoginfo.c --- Diff: https://github.com/kamailio/kamailio/commit/46548193144c0b8ab0bf2e3ecdfd7fe… Patch: https://github.com/kamailio/kamailio/commit/46548193144c0b8ab0bf2e3ecdfd7fe… --- diff --git a/src/modules/pua_dialoginfo/pua_dialoginfo.c b/src/modules/pua_dialoginfo/pua_dialoginfo.c index 26883cc27ad..09d25a67ea3 100644 --- a/src/modules/pua_dialoginfo/pua_dialoginfo.c +++ b/src/modules/pua_dialoginfo/pua_dialoginfo.c @@ -381,12 +381,9 @@ static void __dialog_sendpublish( uri = callee_entity_when_publish_disabled; } - if(use_pubruri_avps - && (refresh_pubruri_avps_flag > -1 - || (request - && (request->flags - & (1U << (unsigned int) - refresh_pubruri_avps_flag))))) { + if(use_pubruri_avps && (refresh_pubruri_avps_flag > -1) && (request != NULL) + && (request->flags + & (1U << (unsigned int)refresh_pubruri_avps_flag))) { lock_get(&dlginfo->lock); refresh_pubruri_avps(dlginfo, &uri); } @@ -584,12 +581,9 @@ static void __dialog_sendpublish( } } - if(use_pubruri_avps - && (refresh_pubruri_avps_flag > -1 - || (request - && (request->flags - & (1U << (unsigned int) - refresh_pubruri_avps_flag))))) { + if(use_pubruri_avps && (refresh_pubruri_avps_flag > -1) && (request != NULL) + && (request->flags + & (1U << (unsigned int)refresh_pubruri_avps_flag))) { lock_release(&dlginfo->lock); } }

1 0

git:master:423f46e6: carrierroute: check pointer and length for str value
by Daniel-Constantin Mierla 26 May '25

26 May '25

Module: kamailio Branch: master Commit: 423f46e6a68e241ef03f59f863ecf6dee92c07db URL: https://github.com/kamailio/kamailio/commit/423f46e6a68e241ef03f59f863ecf6d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-26T18:58:59+02:00 carrierroute: check pointer and length for str value --- Modified: src/modules/carrierroute/cr_rpc_helper.c --- Diff: https://github.com/kamailio/kamailio/commit/423f46e6a68e241ef03f59f863ecf6d… Patch: https://github.com/kamailio/kamailio/commit/423f46e6a68e241ef03f59f863ecf6d… --- diff --git a/src/modules/carrierroute/cr_rpc_helper.c b/src/modules/carrierroute/cr_rpc_helper.c index fa1537151df..5077875bce5 100644 --- a/src/modules/carrierroute/cr_rpc_helper.c +++ b/src/modules/carrierroute/cr_rpc_helper.c @@ -107,7 +107,7 @@ static int update_route_data_recursor( if(rr->host.s) { shm_free(rr->host.s); } - if(opts->new_host.len) { + if(opts->new_host.s && opts->new_host.len) { if((rr->host.s = shm_malloc(opts->new_host.len + 1)) == NULL) { SHM_MEM_ERROR; @@ -132,12 +132,10 @@ static int update_route_data_recursor( FIFO_ERR(E_RESET); return -1; } - if(opts->new_host.len > 0) { + if(opts->new_host.s && opts->new_host.len > 0) { LM_INFO("deactivating host %.*s\n", rr->host.len, rr->host.s); - if(opts->new_host.s - && (strcmp(opts->new_host.s, rr->host.s) - == 0)) { + if(strcmp(opts->new_host.s, rr->host.s) == 0) { LM_ERR("Backup host the same as initial host " "%.*s", rr->host.len, rr->host.s);

1 0

[kamailio/kamailio] cmake: do not packaged (Issue #4255)
by sergey-safarov 23 May '25

23 May '25

sergey-safarov created an issue (kamailio/kamailio#4255) ### Description I now make testing `cmake` packaging and see this error ``` RPM build errors: Directory not found: /root/rpmbuild/BUILDROOT/kamailio-6.1.0-dev1.0.el10.centos.x86_64/usr/share/kamailio/postgres File not found: /root/rpmbuild/BUILDROOT/kamailio-6.1.0-dev1.0.el10.centos.x86_64/usr/share/kamailio/postgres/* ``` ### Troubleshooting #### Reproduction I use this module list for build https://github.com/sergey-safarov/kamailio/blob/master/pkg/kamailio/obs/kam… @xkaraman could you look? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4255 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4255(a)github.com>

2 6

← Newer
1
...
6
7
8
9
10
11
12
...
20
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2025