sr-dev May 2025

sr-dev@lists.kamailio.org

13 participants
125 discussions

git:master:9a8ab319: core: docs - Update type identifiers that can be used in the RPC API
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 9a8ab3199488f02bd01e39bb6e13ef192321b37c URL: https://github.com/kamailio/kamailio/commit/9a8ab3199488f02bd01e39bb6e13ef1… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:31:05+02:00 core: docs - Update type identifiers that can be used in the RPC API - format as well --- Modified: doc/tutorials/rpc/kamailio_rpc.xml --- Diff: https://github.com/kamailio/kamailio/commit/9a8ab3199488f02bd01e39bb6e13ef1… Patch: https://github.com/kamailio/kamailio/commit/9a8ab3199488f02bd01e39bb6e13ef1…

1 0

[kamailio/kamailio] core: sdp - update start pointer only after len adjustment (PR #4230)
by space88man 06 May '25

06 May '25

- len is first adjusted by the amount of chars consumed so far - start pointer is then adjusted to begin new search #### Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [X] Related to issue #4229 #### Description Small logic tweak — we adjust `len` by the amount of chars consumed first, then adjust the `start` pointer to begin the new search. Existing: ``` start = space + 1; len = len - (space - start + 1); // this is a no-op // as the pointer was adjusted first ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4230 -- Commit Summary -- * core: sdp - update start pointer only after len adjustment -- File Changes -- M src/core/parser/sdp/sdp_helpr_funcs.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4230.patch https://github.com/kamailio/kamailio/pull/4230.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4230 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4230(a)github.com>

2 2

git:master:c9fbf6f4: core: sdp - update start pointer only after len adjustment
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: c9fbf6f46898dbb2a8413a1c9d824a56241f2288 URL: https://github.com/kamailio/kamailio/commit/c9fbf6f46898dbb2a8413a1c9d824a5… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:29:44+02:00 core: sdp - update start pointer only after len adjustment - len is adjusted first by the amount of chars consumed so far - start pointer is adjusted to start new search --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/c9fbf6f46898dbb2a8413a1c9d824a5… Patch: https://github.com/kamailio/kamailio/commit/c9fbf6f46898dbb2a8413a1c9d824a5… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 2e7d996bc54..0d18d787242 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -330,8 +330,8 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) fl = space - start; - start = space + 1; len = len - (space - start + 1); + start = space + 1; space = memchr(start, 32, len); if(space == NULL) {

1 0

[kamailio/kamailio] Memory usage increases everytime tls.reload is executed (Issue #3823)
by Sebastian Denz 06 May '25

06 May '25

### Description We are using Kamailio 5.7.4 on Debian 12 (from http://deb.kamailio.org/kamailio57) with rtpengine as an Edgeproxy for our clients. The instance terminates SIP/TLS (with Cliencertificates) and forwards the SIP Traffic to internal systems. After some days we are getting errors like this `tls_complete_init(): tls: ssl bug #1491 workaround: not enough memory for safe operation: shm=7318616 threshold1=8912896` First we thought Kamailio just doesnt have enough memory, so we doubled it.. But after some days the Logmessage (and Userissues) occured again. So we monitored the shmmem statistics and found that used and max_used are constantly growing til it reaches the limit. As i mentioned we are using client-certificates and so we are also using the CRL feature. We do have a systemd-timer which fetches the CRL every hour and runs 'kamcmd tls.reload' when finished. Our tls.cfg looks like this: ``` [server:default] method = TLSv1.2+ private_key = /etc/letsencrypt/live/hostname.de/privkey.pem certificate = /etc/letsencrypt/live/hostname.de/fullchain.pem ca_list = /etc/kamailio/ca_list.pem ca_path = /etc/kamailio/ca_list.pem crl = /etc/kamailio/combined.crl.pem verify_certificate = yes require_certificate = yes [client:default] verify_certificate = yes require_certificate = yes ``` After testing a bit we found that every time tls.reload is executed Kamailio consumes a bit more memory which eventually leads to all the memory being consumed which leads to issues for our users. See following example: ``` [0][root@edgar-dev:~]# while true ; do /usr/sbin/kamcmd tls.reload ; /usr/sbin/kamcmd core.shmmem ; sleep 1 ; done Ok. TLS configuration reloaded. { total: 268435456 free: 223001520 used: 41352552 real_used: 45433936 max_used: 45445968 fragments: 73 } Ok. TLS configuration reloaded. { total: 268435456 free: 222377960 used: 41975592 real_used: 46057496 max_used: 46069232 fragments: 78 } Ok. TLS configuration reloaded. { total: 268435456 free: 221748664 used: 42604992 real_used: 46686792 max_used: 46698080 fragments: 77 } Ok. TLS configuration reloaded. { total: 268435456 free: 221110832 used: 43242408 real_used: 47324624 max_used: 47335608 fragments: 81 } ^C [130][root@edgar-dev:~]# ``` ### Troubleshooting #### Reproduction Everytime tls.reload is called the memory consumptions grows.. #### Debugging Data  ``` If you let me know what would be interesting for tracking this down, i am happy to provide logs/debugging data! ``` #### Log Messages  ``` If you let me know what would be interesting for tracking this down, i am happy to provide logs/debugging data! ``` #### SIP Traffic SIP doesnt seem to be relevant here ### Possible Solutions Calling tls.reload less often or restart kamailio before memory is consumed ;) ### Additional Information ``` version: kamailio 5.7.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**: ``` * Debian GNU/Linux 12 (bookworm) * Linux edgar-dev 6.1.0-20-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.85-1 (2024-04-11) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3823 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3823(a)github.com>

9 31

[kamailio/kamailio] core(sdp_helpr_funcs.c): always parsing a=candidate: as "no component … " (Issue #4229)
by space88man 06 May '25

06 May '25

space88man created an issue (kamailio/kamailio#4229)  ### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4229 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4229(a)github.com>

2 3

[kamailio/kamailio] cmake format options and naming styles (Issue #4075)
by Daniel-Constantin Mierla 06 May '25

06 May '25

Discussion to define cmake format options and coding/naming styles. It is better to define most of them now to have coherency in the future. Started from the discussion on #4066. Comment with what you would like to have, describing when useful why your proposal is a good/better option. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4075 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4075(a)github.com>

5 9

git:master:444fef80: core: sdp - removed invalid condition
by Daniel-Constantin Mierla 05 May '25

05 May '25

Module: kamailio Branch: master Commit: 444fef809c21b250402cfdbd48de65926ac6286a URL: https://github.com/kamailio/kamailio/commit/444fef809c21b250402cfdbd48de659… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-05T16:48:21+02:00 core: sdp - removed invalid condition - introduced in commit 3198b66 - GH #4229 --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/444fef809c21b250402cfdbd48de659… Patch: https://github.com/kamailio/kamailio/commit/444fef809c21b250402cfdbd48de659… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 5e9b3f121ab..2e7d996bc54 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -332,10 +332,7 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) start = space + 1; len = len - (space - start + 1); - if(start + len > body->s + body->len) { - LM_ERR("no component in `a=candidate'\n"); - return -1; - } + space = memchr(start, 32, len); if(space == NULL) { LM_ERR("no component in `a=candidate'\n");

1 0

git:master:cd2db38b: presence: use internal wraper for signed int time
by Daniel-Constantin Mierla 05 May '25

05 May '25

Module: kamailio Branch: master Commit: cd2db38bb3f8f3926cac7e7c5cd58af8f5143fe1 URL: https://github.com/kamailio/kamailio/commit/cd2db38bb3f8f3926cac7e7c5cd58af… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-04T21:03:27+02:00 presence: use internal wraper for signed int time --- Modified: src/modules/presence/hash.c --- Diff: https://github.com/kamailio/kamailio/commit/cd2db38bb3f8f3926cac7e7c5cd58af… Patch: https://github.com/kamailio/kamailio/commit/cd2db38bb3f8f3926cac7e7c5cd58af… --- diff --git a/src/modules/presence/hash.c b/src/modules/presence/hash.c index 39878ac08d9..1d998ca4294 100644 --- a/src/modules/presence/hash.c +++ b/src/modules/presence/hash.c @@ -309,7 +309,7 @@ int insert_shtable(shtable_t htable, unsigned int hash_code, subs_t *subs) LM_ERR("copying in share memory a subs_t structure\n"); return -1; } - new_rec->expires += (int)time(NULL); + new_rec->expires += ksr_time_sint(NULL, NULL); lock_get(&htable[hash_code].lock); new_rec->next = htable[hash_code].entries->next; @@ -417,7 +417,7 @@ int update_shtable( } if(type & REMOTE_TYPE) { - s->expires = subs->expires + (int)time(NULL); + s->expires = subs->expires + ksr_time_sint(NULL, NULL); s->remote_cseq = subs->remote_cseq; } else { subs->local_cseq = ++s->local_cseq;

1 0

git:master:2dd6dcfb: dmq: use internal wrapper for signed int time
by Daniel-Constantin Mierla 05 May '25

05 May '25

Module: kamailio Branch: master Commit: 2dd6dcfb0e4fe353536c411a25d44fa8a796672f URL: https://github.com/kamailio/kamailio/commit/2dd6dcfb0e4fe353536c411a25d44fa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-04T20:58:36+02:00 dmq: use internal wrapper for signed int time --- Modified: src/modules/dmq/dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/2dd6dcfb0e4fe353536c411a25d44fa… Patch: https://github.com/kamailio/kamailio/commit/2dd6dcfb0e4fe353536c411a25d44fa… --- diff --git a/src/modules/dmq/dmq.c b/src/modules/dmq/dmq.c index 0022f569008..c01c38ba13b 100644 --- a/src/modules/dmq/dmq.c +++ b/src/modules/dmq/dmq.c @@ -277,7 +277,7 @@ static int mod_init(void) return -1; } - dmq_startup_time = (int)time(NULL); + dmq_startup_time = ksr_time_sint(NULL, NULL); /** * add the ping timer

1 0

[kamailio/kamailio] Topoh module does not hide 180 Ringing and 200 Ok to the caller UE in IMS config (Issue #4164)
by Farzaneh Soltanzadeh 05 May '25

05 May '25

Fr-Soltanzadeh created an issue (kamailio/kamailio#4164) ### Description In a IMS lab using Kamailio PCSCF, ICSCF and SCSCF default configs, I have used TOPOH module in PCSCF for topology hiding. Topoh config is as follows: ``` modparam("topoh", "mask_key", "my-key") modparam("topoh", "mask_ip", "127.0.0.2") modparam("topoh", "sanity_checks", 1) ``` As shown in attached traffic, SCSCF IP is not hided in 180 ringing and 200ok messages to the caller. In invite, ack and bye messages hiding is performed well. [topoh.zip](https://github.com/user-attachments/files/19086420/topoh.zip) [topoh.zip](https://github.com/user-attachments/files/19086428/topoh.zip) [topoh.zip](https://github.com/user-attachments/files/19086431/topoh.zip)  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4164 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4164(a)github.com>

3 4

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2025