sr-dev May 2025

sr-dev@lists.kamailio.org

13 participants
122 discussions

git:master:0afea1fd: cmake: Forbid in-source builds
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 0afea1fd170a79d3f260c18a293bac1ce8fd8527 URL: https://github.com/kamailio/kamailio/commit/0afea1fd170a79d3f260c18a293bac1… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T08:14:54Z cmake: Forbid in-source builds --- Modified: CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/0afea1fd170a79d3f260c18a293bac1… Patch: https://github.com/kamailio/kamailio/commit/0afea1fd170a79d3f260c18a293bac1… --- diff --git a/CMakeLists.txt b/CMakeLists.txt index 6d68b5da980..22ee9a8e3a2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -10,6 +10,17 @@ project( HOMEPAGE_URL "https://www.kamailio.org" ) +# ---- Include guards ---- + +if(PROJECT_SOURCE_DIR STREQUAL PROJECT_BINARY_DIR) + message( + FATAL_ERROR + "In-source builds not allowed. Please make a new directory (called a build directory) \ +and run CMake again accordingly.") +endif() + +# ---- Project settings ---- + # Set the version number set(EXTRAVERSION "-dev1") set(RELEASE "${PROJECT_VERSION}${EXTRAVERSION}")

1 0

[kamailio/kamailio] rtpengine hash table dmq replication (PR #4240)
by vlitvinov 18 May '25

18 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Adding KDMQ replication for rtpengine hash table (call -> rtpengine instance assignment) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4240 -- Commit Summary -- * rtpegnine hash table dmq replication -- File Changes -- M src/modules/rtpengine/rtpengine.c (49) M src/modules/rtpengine/rtpengine.h (4) M src/modules/rtpengine/rtpengine_db.c (2) A src/modules/rtpengine/rtpengine_dmq.c (310) A src/modules/rtpengine/rtpengine_dmq.h (54) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4240.patch https://github.com/kamailio/kamailio/pull/4240.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4240 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4240(a)github.com>

1 1

[kamailio/kamailio] rtpengine: fix race condn (same ip:port) in parallel forks due to gencookie (PR #4139)
by Souradeep Bera 18 May '25

18 May '25

- avoid parallel calls to gencookie from generating the same cookie for rtpengine #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4139 -- Commit Summary -- * rtpengine: fix race condn assigning same ip:port due to gencookie in parallel forks -- File Changes -- M src/modules/rtpengine/rtpengine.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4139.patch https://github.com/kamailio/kamailio/pull/4139.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4139 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4139(a)github.com>

4 5

[kamailio/kamailio] generate rpm packages using github actions (PR #4194)
by sergey-safarov 17 May '25

17 May '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description I have refactored the rpm packaging and am now using the GitHub actions. Now `tar.gz` archive with rpm packages, source rpm and deps rpm files attached to the release message like. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4194 -- Commit Summary -- * generate rpm packages using github actions -- File Changes -- A .github/workflows/rpm.yml (57) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4194.patch https://github.com/kamailio/kamailio/pull/4194.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4194 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4194(a)github.com>

2 5

git:master:afa2d017: github: generate rpm packages
by Victor Seva 17 May '25

17 May '25

Module: kamailio Branch: master Commit: afa2d017e3b5a1f5a776935767e485c1158be461 URL: https://github.com/kamailio/kamailio/commit/afa2d017e3b5a1f5a776935767e485c… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-17T20:41:05+02:00 github: generate rpm packages --- Added: .github/workflows/rpm.yml --- Diff: https://github.com/kamailio/kamailio/commit/afa2d017e3b5a1f5a776935767e485c… Patch: https://github.com/kamailio/kamailio/commit/afa2d017e3b5a1f5a776935767e485c… --- diff --git a/.github/workflows/rpm.yml b/.github/workflows/rpm.yml new file mode 100644 index 00000000000..0d890b63a8c --- /dev/null +++ b/.github/workflows/rpm.yml @@ -0,0 +1,89 @@ +--- +name: build_rpm +'on': + schedule: + - cron: '41 6 * * 0' + push: + tags: + - '[0-9]+.[0-9]+.[0-9]+' +jobs: + # is required nightly build? + # More info at https://stackoverflow.com/questions/63014786/how-to-schedule-a-github-actio… + # looking commit_id of the last successful daily build + check: + runs-on: ubuntu-latest + permissions: + contents: read + steps: + - uses: octokit/request-action(a)v2.x + id: check_last_run + with: + route: GET /repos/{owner}/{repo}/actions/workflows/rpm.yml/runs?per_page=1&status=success + owner: ${{ github.repository_owner }} + repo: kamailio + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Show last execution info + run: | + echo "Last daily build: ${{ fromJson(steps.check_last_run.outputs.data).workflow_runs[0].head_sha }}" + + outputs: + last_sha: ${{ fromJson(steps.check_last_run.outputs.data).workflow_runs[0].head_sha }} + + native: + needs: [check] + if: needs.check.outputs.last_sha != github.sha + strategy: + matrix: + os: + - centos-10 + - rhel-10 + - centos-9 + - rhel-9 + - centos-8 + - rhel-8 + runner: + - ubuntu-latest + - ubuntu-24.04-arm + runs-on: ${{ matrix.runner }} + permissions: + contents: write + steps: + - name: checkout sources + uses: actions/checkout@v4 + + - name: print commit info and init hosttype var + id: init + run: | + echo ${{ github.sha }} + echo "hosttype=${HOSTTYPE}" >> $GITHUB_OUTPUT + + - name: build rpm files + uses: addnab/docker-run-action@v3 + with: + image: safarov/kamailio-builder:${{ matrix.os }} + options: -v ${{ github.workspace }}:/usr/src/kamailio + run: | + cd /usr/src/kamailio + make cfg + make -C pkg/kamailio src.rpm + rpmbuild -ra /usr/src/kamailio/kamailio*.src.rpm + cp -R /deps ~/rpmbuild/RPMS + mv ~/rpmbuild/SRPMS/* ~/rpmbuild/RPMS + mv ~/rpmbuild/RPMS . + tar czf kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm.tar.gz RPMS + + - name: Push artifacts + uses: actions/upload-artifact@v4 + if: "! startsWith(github.ref, 'refs/tags/')" + with: + name: kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm + path: | + RPMS/* + + - name: Release + uses: softprops/action-gh-release@v2 + if: "startsWith(github.ref, 'refs/tags/')" + with: + files: | + kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm.tar.gz

1 0

[kamailio/kamailio] ims_auth: replaced t_continue_skip_timer with t_continue in cxdx_mar.c (PR #4206)
by Amin Nazari 17 May '25

17 May '25

- fixed log message in MAR Async CDP callback - fixed executing cfg_action after sending MAR Diameter request - cfg_action is the callback parameter of the ims_www_challenge function   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #4205 (replace XXXX with an open issue number) #### Description Based on the description in issue #4205, this PR will fix a bug in ims_auth module related to MAR Diameter request callbacks, by replacing the call to t_continue function with t_continue_skip_timer, after the MAR request is sent, the control will successfully move to the cfg action in Kamailio scripts. Just like what we already have in ims_registrar_scscf module, using t_continue_skip_timer instead of t_continue cause the transaction to be found and resumed. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4206 -- Commit Summary -- * ims_auth: replaced t_continue_skip_timer with t_continue in cxdx_mar.c -- File Changes -- M src/modules/ims_auth/cxdx_mar.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4206.patch https://github.com/kamailio/kamailio/pull/4206.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4206 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4206(a)github.com>

2 1

git:master:74709677: ims_auth: replaced t_continue_skip_timer with t_continue in cxdx_mar.c
by Victor Seva 17 May '25

17 May '25

Module: kamailio Branch: master Commit: 7470967790a78ba67ef7acb7c87d94482fbea0cb URL: https://github.com/kamailio/kamailio/commit/7470967790a78ba67ef7acb7c87d944… Author: amnapa <marvelousvip(a)live.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-17T20:34:43+02:00 ims_auth: replaced t_continue_skip_timer with t_continue in cxdx_mar.c - fixed log message in MAR Async CDP callback - fixed executing cfg_action after sending MAR Diameter request - cfg_action is the callback parameter of the ims_www_challenge function --- Modified: src/modules/ims_auth/cxdx_mar.c --- Diff: https://github.com/kamailio/kamailio/commit/7470967790a78ba67ef7acb7c87d944… Patch: https://github.com/kamailio/kamailio/commit/7470967790a78ba67ef7acb7c87d944… --- diff --git a/src/modules/ims_auth/cxdx_mar.c b/src/modules/ims_auth/cxdx_mar.c index 51e05ce7a27..3868dee4f60 100644 --- a/src/modules/ims_auth/cxdx_mar.c +++ b/src/modules/ims_auth/cxdx_mar.c @@ -479,7 +479,7 @@ void async_cdp_callback( adi_list = 0; } - LM_DBG("DBG:UAR Async CDP callback: ... Done resuming transaction\n"); + LM_DBG("DBG:MAR Async CDP callback: ... Done resuming transaction\n"); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, &t->uri_avps_from); set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, &t->uri_avps_to); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, &t->user_avps_from); @@ -493,7 +493,7 @@ void async_cdp_callback( //del_nonshm_lump_rpl(&req->reply_lump); tmb.unref_cell(t); } - tmb.t_continue(data->tindex, data->tlabel, data->act); + tmb.t_continue_skip_timer(data->tindex, data->tlabel, data->act); free_saved_transaction_data(data); return; @@ -504,7 +504,7 @@ void async_cdp_callback( //del_nonshm_lump_rpl(&t->uas.request->reply_lump); tmb.unref_cell(t); } - tmb.t_continue(data->tindex, data->tlabel, data->act); + tmb.t_continue_skip_timer(data->tindex, data->tlabel, data->act); error1: free_saved_transaction_data(data);

1 0

[kamailio/kamailio] kafka_send in event_route not work (Issue #4198)
by wangduanduan 17 May '25

17 May '25

wangduanduan created an issue (kamailio/kamailio#4198)  ### Description kafka_send in event_route like tcp:timeout, tcp:closed not work ``` event_route[tcp:closed] { if (kafka_send("my_topic", "tcp:closed")) { xlog("L_INFO", "send success tcp:closed"); } } event_route[tcp:timeout] { if (kafka_send("my_topic", "tcp:timeout")) { xlog("L_INFO", "send success tcp:timeout"); } } ``` in log, its show "send success tcp:closed", "send success tcp:timeout", but in kafka web ui, in the **my_topic**, can't find the "tcp:closed" or " tcp:timeout" message. --- but if the kafka_send in onreply_route, message will be send ok, in the kafka web ui, the "some_route" can be find. ``` onreplay_route[some_route]{ if (kafka_send("my_topic", "some_routet")) { xlog("L_INFO", "send success some_routet"); } } ```  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic i use tcpdump to capture the traffic between kamailio and kafka. - when use kafka_send in event_route, no packages captured.  ``` ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 5.6.1 ``` * **Operating System**: centos7  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4198 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4198(a)github.com>

5 9

[kamailio/kamailio] dispatcher: weight documentation and workaround for limitations (PR #4158)
by Christian Berger 17 May '25

17 May '25

- describe limitation of weight parameter - describe a potential workaround against those limitations  #### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  We had problems understanding the weight parameter of the dispatcher module and wrote a little workaround against the problems we have found. This workaround in the configuration file improves behavior for setups with many dispatcher targets at the cost of more CPU load. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4158 -- Commit Summary -- * dispatcher: weight documentation and workaround for limitations -- File Changes -- M src/modules/dispatcher/doc/dispatcher_admin.xml (28) A src/modules/dispatcher/doc/weights.cfg (49) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4158.patch https://github.com/kamailio/kamailio/pull/4158.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4158 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4158(a)github.com>

4 3

git:master:b51c78ba: usrloc: use the internal wrappers for time value
by Daniel-Constantin Mierla 16 May '25

16 May '25

Module: kamailio Branch: master Commit: b51c78ba27ca552893ba88cefe2d941246322a69 URL: https://github.com/kamailio/kamailio/commit/b51c78ba27ca552893ba88cefe2d941… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-16T11:05:47+02:00 usrloc: use the internal wrappers for time value --- Modified: src/modules/usrloc/ul_keepalive.c --- Diff: https://github.com/kamailio/kamailio/commit/b51c78ba27ca552893ba88cefe2d941… Patch: https://github.com/kamailio/kamailio/commit/b51c78ba27ca552893ba88cefe2d941… --- diff --git a/src/modules/usrloc/ul_keepalive.c b/src/modules/usrloc/ul_keepalive.c index 5ea58f25a9f..a0704da2a69 100644 --- a/src/modules/usrloc/ul_keepalive.c +++ b/src/modules/usrloc/ul_keepalive.c @@ -156,9 +156,10 @@ int ul_ka_urecord(urecord_t *ur) /* set contact as expired in 10s */ LM_DBG("set expired contact on keepalive (%u + %u < %u)" " - aor: %.*s c: %.*s\n", - (unsigned int)uc->last_keepalive, - (unsigned int)ul_keepalive_timeout, (unsigned int)tnow, - ur->aor.len, ur->aor.s, uc->c.len, uc->c.s); + ksr_time_uint(&uc->last_keepalive, NULL), + (unsigned int)ul_keepalive_timeout, + ksr_time_sint(&tnow, NULL), ur->aor.len, ur->aor.s, + uc->c.len, uc->c.s); if(uc->expires > tnow + 10) { uc->expires = tnow + 10; continue;

1 0

← Newer
1
2
3
4
5
6
7
8
...
13
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2025