sr-dev March 2025

sr-dev@lists.kamailio.org

10 participants
176 discussions

git:6.0:f24315c2: microhttpd: handle all incoming body data
by Daniel-Constantin Mierla 20 Mar '25

20 Mar '25

Module: kamailio Branch: 6.0 Commit: f24315c2bc4ec7b9507516a96603e91ae2ce0fd1 URL: https://github.com/kamailio/kamailio/commit/f24315c2bc4ec7b9507516a96603e91… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-20T07:16:47+01:00 microhttpd: handle all incoming body data - GH #4176 (cherry picked from commit 96392eda8fac1cb075e7f407c0155085acc92c5f) --- Modified: src/modules/microhttpd/microhttpd_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/f24315c2bc4ec7b9507516a96603e91… Patch: https://github.com/kamailio/kamailio/commit/f24315c2bc4ec7b9507516a96603e91… --- diff --git a/src/modules/microhttpd/microhttpd_mod.c b/src/modules/microhttpd/microhttpd_mod.c index eaf2820ce68..2853b7b1b5a 100644 --- a/src/modules/microhttpd/microhttpd_mod.c +++ b/src/modules/microhttpd/microhttpd_mod.c @@ -177,6 +177,13 @@ static void mod_destroy(void) { } +typedef struct ksr_mhd_cstream +{ + int ctype; + int rcvmode; + str data; +} ksr_mhd_cstream_t; + typedef struct ksr_mhttpd_ctx { struct MHD_Connection *connection; @@ -450,23 +457,68 @@ static int fixup_free_mhttpd_send_reply(void **param, int param_no) return 0; } + static enum MHD_Result ksr_microhttpd_request(void *cls, struct MHD_Connection *connection, const char *url, const char *method, const char *version, const char *upload_data, size_t *upload_data_size, void **ptr) { - static int _first_callback; sr_kemi_eng_t *keng = NULL; str evname = str_init("microhttpd:request"); sip_msg_t *fmsg = NULL; run_act_ctx_t ctx; int rtb; + ksr_mhd_cstream_t *cstream = NULL; + + cstream = (ksr_mhd_cstream_t *)*ptr; + if(cstream == NULL) { + cstream = (ksr_mhd_cstream_t *)malloc(sizeof(ksr_mhd_cstream_t)); + if(cstream == NULL) { + LM_ERR("no more system memroy\n"); + return MHD_NO; + } + memset(cstream, 0, sizeof(ksr_mhd_cstream_t)); + *ptr = cstream; + } - if(&_first_callback != *ptr) { + if(cstream->rcvmode == 0) { + cstream->rcvmode = 1; /* the first time only the headers are valid, - do not respond in the first round... */ - *ptr = &_first_callback; + * do not respond in the first round */ return MHD_YES; + } else { + if(*upload_data_size != 0) { + char *buf = NULL; + int bsize = 0; + if(cstream->data.s != NULL) { + bsize = *upload_data_size + cstream->data.len + 1; + } else { + bsize = *upload_data_size + 1; + } + buf = (char *)malloc(sizeof(char) * bsize); + if(buf == NULL) { + if(cstream->data.s != NULL) { + free(cstream->data.s); + free(cstream); + *ptr = NULL; + return MHD_NO; + } + } + if(cstream->data.s != NULL) { + snprintf(buf, bsize, "%s%s", cstream->data.s, upload_data); + free(cstream->data.s); + } else { + snprintf(buf, bsize, "%s", upload_data); + } + cstream->data.s = buf; + cstream->data.len = bsize - 1; + *upload_data_size = 0; + return MHD_YES; + } else { + LM_DBG("incoming data: [%.*s]\n", + cstream->data.len <= 64 ? cstream->data.len : 64, + cstream->data.s); + } } *ptr = NULL; /* clear context pointer */ @@ -477,13 +529,19 @@ static enum MHD_Result ksr_microhttpd_request(void *cls, _ksr_mhttpd_ctx.url.len = strlen(_ksr_mhttpd_ctx.url.s); _ksr_mhttpd_ctx.httpversion.s = (char *)version; _ksr_mhttpd_ctx.httpversion.len = strlen(_ksr_mhttpd_ctx.httpversion.s); - if(*upload_data_size > 0) { - _ksr_mhttpd_ctx.data.s = (char *)upload_data; - _ksr_mhttpd_ctx.data.len = (int)(*upload_data_size); + if(_ksr_mhttpd_ctx.data.s != NULL) { + free(_ksr_mhttpd_ctx.data.s); + } + if(cstream->data.len > 0) { + if(_ksr_mhttpd_ctx.data.s != NULL) { + free(_ksr_mhttpd_ctx.data.s); + } + _ksr_mhttpd_ctx.data = cstream->data; } else { _ksr_mhttpd_ctx.data.s = NULL; _ksr_mhttpd_ctx.data.len = 0; } + free(cstream); _ksr_mhttpd_ctx.cinfo = MHD_get_connection_info( connection, MHD_CONNECTION_INFO_CLIENT_ADDRESS); _ksr_mhttpd_ctx.srcip.s = NULL;

1 0

git:6.0:f761cad5: microhttpd: create response with MHD_RESPMEM_MUST_COPY flag
by Daniel-Constantin Mierla 20 Mar '25

20 Mar '25

Module: kamailio Branch: 6.0 Commit: f761cad5b462820af060d6e07410f0dd84c1a52f URL: https://github.com/kamailio/kamailio/commit/f761cad5b462820af060d6e07410f0d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-20T07:16:38+01:00 microhttpd: create response with MHD_RESPMEM_MUST_COPY flag (cherry picked from commit 1569a7b71af26f5b3cb7cb25de7d2425c75f5587) --- Modified: src/modules/microhttpd/microhttpd_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/f761cad5b462820af060d6e07410f0d… Patch: https://github.com/kamailio/kamailio/commit/f761cad5b462820af060d6e07410f0d… --- diff --git a/src/modules/microhttpd/microhttpd_mod.c b/src/modules/microhttpd/microhttpd_mod.c index 9a913b449bb..eaf2820ce68 100644 --- a/src/modules/microhttpd/microhttpd_mod.c +++ b/src/modules/microhttpd/microhttpd_mod.c @@ -360,7 +360,7 @@ static int ksr_mhttpd_send_reply( } response = MHD_create_response_from_buffer( - sbody->len, sbody->s, MHD_RESPMEM_PERSISTENT); + sbody->len, sbody->s, MHD_RESPMEM_MUST_COPY); if(response == NULL) { LM_ERR("failed to create the response\n"); return -1;

1 0

git:6.0:813d3ed6: microhttpd: debug message for http response queue
by Daniel-Constantin Mierla 20 Mar '25

20 Mar '25

Module: kamailio Branch: 6.0 Commit: 813d3ed6a532cc0baa98d27ef9eea579e5ca1688 URL: https://github.com/kamailio/kamailio/commit/813d3ed6a532cc0baa98d27ef9eea57… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-20T07:16:28+01:00 microhttpd: debug message for http response queue (cherry picked from commit 7a793a257b12f946e54bca3d3d92b6c07602fb20) --- Modified: src/modules/microhttpd/microhttpd_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/813d3ed6a532cc0baa98d27ef9eea57… Patch: https://github.com/kamailio/kamailio/commit/813d3ed6a532cc0baa98d27ef9eea57… --- diff --git a/src/modules/microhttpd/microhttpd_mod.c b/src/modules/microhttpd/microhttpd_mod.c index 0ef4b36284e..9a913b449bb 100644 --- a/src/modules/microhttpd/microhttpd_mod.c +++ b/src/modules/microhttpd/microhttpd_mod.c @@ -372,6 +372,9 @@ static int ksr_mhttpd_send_reply( _ksr_mhttpd_ctx.connection, (unsigned int)rcode, response); MHD_destroy_response(response); + LM_DBG("queue response return: %d (%s)\n", ret, + (ret == MHD_YES) ? "YES" : "XYZ"); + return (ret == MHD_YES) ? 1 : -1; }

1 0

git:6.0:b3cb2b38: tls: get wss connections as well for selects and vars
by Daniel-Constantin Mierla 20 Mar '25

20 Mar '25

Module: kamailio Branch: 6.0 Commit: b3cb2b38c5d81c48b0b6315cb7feb99d236d15e3 URL: https://github.com/kamailio/kamailio/commit/b3cb2b38c5d81c48b0b6315cb7feb99… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-20T07:16:15+01:00 tls: get wss connections as well for selects and vars - GH #4167 (cherry picked from commit 3a3856c68cf0cc04385921f8bbec72420cf8f656) --- Modified: src/modules/tls/tls_select.c --- Diff: https://github.com/kamailio/kamailio/commit/b3cb2b38c5d81c48b0b6315cb7feb99… Patch: https://github.com/kamailio/kamailio/commit/b3cb2b38c5d81c48b0b6315cb7feb99… --- diff --git a/src/modules/tls/tls_select.c b/src/modules/tls/tls_select.c index 7945b23275a..6a2711bd36a 100644 --- a/src/modules/tls/tls_select.c +++ b/src/modules/tls/tls_select.c @@ -129,14 +129,14 @@ struct tcp_connection *get_cur_connection(struct sip_msg *msg) if(_tls_pv_con != 0) return _tls_pv_con; - if(msg->rcv.proto != PROTO_TLS) { + if(msg->rcv.proto != PROTO_TLS && msg->rcv.proto != PROTO_WSS) { ERR("Transport protocol is not TLS (bug in config)\n"); return 0; } c = tcpconn_get(msg->rcv.proto_reserved1, 0, 0, 0, cfg_get(tls, tls_cfg, con_lifetime)); - if(c && c->type != PROTO_TLS) { + if(c && c->type != PROTO_TLS && msg->rcv.proto != PROTO_WSS) { ERR("Connection found but is not TLS\n"); tcpconn_put(c); return 0;

1 0

git:6.0:0cbf7eed: dialog: enforce second bye towards callee for dlg_bye()
by Daniel-Constantin Mierla 20 Mar '25

20 Mar '25

Module: kamailio Branch: 6.0 Commit: 0cbf7eede6dbd3198664160b77d1b4d0337833b8 URL: https://github.com/kamailio/kamailio/commit/0cbf7eede6dbd3198664160b77d1b4d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-20T07:16:03+01:00 dialog: enforce second bye towards callee for dlg_bye() - GH #4169 (cherry picked from commit 7de1693573fc08e54db1955095d66c495b2051b9) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/0cbf7eede6dbd3198664160b77d1b4d… Patch: https://github.com/kamailio/kamailio/commit/0cbf7eede6dbd3198664160b77d1b4d… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 62b6aea1a9c..7645ebeca37 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -376,7 +376,8 @@ static inline int build_extra_hdr( * DLG_CALLER_LEG (0): caller * DLG_CALLEE_LEG (1): callee */ -static inline int send_bye(struct dlg_cell *cell, int dir, str *hdrs) +static inline int send_bye( + struct dlg_cell *cell, int dir, str *hdrs, int enforce) { uac_req_t uac_r; dlg_t *dialog_info; @@ -386,16 +387,15 @@ static inline int send_bye(struct dlg_cell *cell, int dir, str *hdrs) str lhdrs; /* dialog is already in deleted state, nothing to do */ - if(cell->state == DLG_STATE_DELETED) { + if(cell->state == DLG_STATE_DELETED && enforce == 0) { LM_WARN("dlg [%u:%u] with callid %.*s already in deleted state, BYE " "not sent.\n", cell->h_entry, cell->h_id, cell->callid.len, cell->callid.s); - return 0; + return 1; } /* Send Cancel or final response for non-confirmed dialogs */ - if(cell->state != DLG_STATE_CONFIRMED_NA - && cell->state != DLG_STATE_CONFIRMED) { + if(cell->state < DLG_STATE_CONFIRMED_NA) { if(cell->t) { if(dir == DLG_CALLER_LEG) { if(d_tmb.t_reply(cell->t->uas.request, bye_early_code, @@ -843,7 +843,7 @@ int dlg_bye(struct dlg_cell *dlg, str *hdrs, int side) LM_ERR("failed to build dlg headers\n"); return -1; } - ret = send_bye(dlg, side, &all_hdrs); + ret = send_bye(dlg, side, &all_hdrs, 0); pkg_free(all_hdrs.s); dlg_run_event_route(dlg, NULL, dlg->state, DLG_STATE_DELETED); @@ -864,8 +864,10 @@ int dlg_bye_all(struct dlg_cell *dlg, str *hdrs) return -1; } - ret = send_bye(dlg, DLG_CALLER_LEG, &all_hdrs); - ret |= send_bye(dlg, DLG_CALLEE_LEG, &all_hdrs); + ret = send_bye(dlg, DLG_CALLER_LEG, &all_hdrs, 0); + if(ret == 0) { + ret |= send_bye(dlg, DLG_CALLEE_LEG, &all_hdrs, 1); + } pkg_free(all_hdrs.s);

1 0

git:master:3e9842cb: modules: readme files regenerated - tcpops ... [skip ci]
by Kamailio Dev 19 Mar '25

19 Mar '25

Module: kamailio Branch: master Commit: 3e9842cb1206d39588f7be11a678bbcbc6e3f5d4 URL: https://github.com/kamailio/kamailio/commit/3e9842cb1206d39588f7be11a678bbc… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-03-19T08:01:10+01:00 modules: readme files regenerated - tcpops ... [skip ci] --- Modified: src/modules/tcpops/README --- Diff: https://github.com/kamailio/kamailio/commit/3e9842cb1206d39588f7be11a678bbc… Patch: https://github.com/kamailio/kamailio/commit/3e9842cb1206d39588f7be11a678bbc…

1 0

git:master:41a48b51: tcpops: docs for tcp_con_alive()
by Daniel-Constantin Mierla 19 Mar '25

19 Mar '25

Module: kamailio Branch: master Commit: 41a48b519c238945b40cf1570e68abaf347fba07 URL: https://github.com/kamailio/kamailio/commit/41a48b519c238945b40cf1570e68aba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-19T07:59:32+01:00 tcpops: docs for tcp_con_alive() --- Modified: src/modules/tcpops/doc/functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/41a48b519c238945b40cf1570e68aba… Patch: https://github.com/kamailio/kamailio/commit/41a48b519c238945b40cf1570e68aba… --- diff --git a/src/modules/tcpops/doc/functions.xml b/src/modules/tcpops/doc/functions.xml index 85f7369f88b..2ee00a58525 100644 --- a/src/modules/tcpops/doc/functions.xml +++ b/src/modules/tcpops/doc/functions.xml @@ -40,6 +40,36 @@ if(!tcp_conid_alive("$var(conid)")) { xlog("L_ERR", "Connection $conid can no longer be used\n"); } +... + ]]></programlisting> + </example> + </section> + <section id="tcpops.f.tcp_con_alive"> + <title> + <function>tcp_con_alive(hostport)</function> + </title> + <para> + Check the connection based on target host:port. + </para> + <para>Meaning of the parameters is as follows:</para> + <itemizedlist> + <listitem> + <para><emphasis>hostport</emphasis> - target "host:port" address, + the port can be omitted (default to 5060) and the parameter can + contain variables. + </para> + </listitem> + </itemizedlist> + <para>Return values:</para> + <para>1: connection was found</para> + <para>-1: connection was not found or an error occurred</para> + <example> + <title><function>tcp_con_alive</function> usage</title> + <programlisting><![CDATA[ +... + if(!tcp_con_alive("1.2.3.4:5060")) { + xlog("connection not found\n"); + } ... ]]></programlisting> </example>

1 0

git:master:79eb690e: tcpops: function to check if a connection is alive by remote addr:port
by Daniel-Constantin Mierla 19 Mar '25

19 Mar '25

Module: kamailio Branch: master Commit: 79eb690e4838aa270983e3326779068ee8bbda80 URL: https://github.com/kamailio/kamailio/commit/79eb690e4838aa270983e3326779068… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-19T06:55:20+01:00 tcpops: function to check if a connection is alive by remote addr:port --- Modified: src/modules/tcpops/tcpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/79eb690e4838aa270983e3326779068… Patch: https://github.com/kamailio/kamailio/commit/79eb690e4838aa270983e3326779068… --- diff --git a/src/modules/tcpops/tcpops_mod.c b/src/modules/tcpops/tcpops_mod.c index a89a18992aa..a8c9e940d85 100644 --- a/src/modules/tcpops/tcpops_mod.c +++ b/src/modules/tcpops/tcpops_mod.c @@ -61,6 +61,7 @@ static int w_tcpops_enable_closed_event1(sip_msg_t *msg, char *con, char *p2); static int w_tcpops_enable_closed_event0(sip_msg_t *msg, char *p1, char *p2); static int w_tcp_conid_state(sip_msg_t *msg, char *con, char *p2); static int w_tcp_conid_alive(sip_msg_t *msg, char *con, char *p2); +static int w_tcp_con_alive(sip_msg_t *msg, char *paddr, char *p2); static int w_tcp_get_conid(sip_msg_t *msg, char *paddr, char *pvn); static int w_tcp_set_otcpid(sip_msg_t *msg, char *conid, char *p2); static int w_tcp_set_otcpid_flag(sip_msg_t *msg, char *mode, char *p2); @@ -106,6 +107,8 @@ static cmd_export_t cmds[] = { fixup_free_spve_pvar, ANY_ROUTE}, {"tcp_conid_alive", (cmd_function)w_tcp_conid_alive, 1, fixup_igp_all, fixup_free_igp_all, ANY_ROUTE}, + {"tcp_con_alive", (cmd_function)w_tcp_con_alive, 1, fixup_spve_null, + fixup_free_spve_null, ANY_ROUTE}, {"tcp_set_otcpid", (cmd_function)w_tcp_set_otcpid, 1, fixup_igp_all, fixup_free_igp_all, ANY_ROUTE}, {"tcp_set_otcpid_flag", (cmd_function)w_tcp_set_otcpid_flag, 1, @@ -546,7 +549,7 @@ static int ki_tcp_get_conid_helper(sip_msg_t *msg, str *saddr, pv_spec_t *pvs) int port; pv_value_t val; - if(pvs->setf == NULL) { + if(pvs != NULL && pvs->setf == NULL) { LM_ERR("output variable is read only\n"); return -1; } @@ -583,21 +586,23 @@ static int ki_tcp_get_conid_helper(sip_msg_t *msg, str *saddr, pv_spec_t *pvs) port = su_getport(&dst.to); c = tcpconn_get(dst.id, &ip, port, NULL, clifetime); - if(unlikely(c == 0)) { + if(unlikely(c <= 0)) { goto setvalue; } conid = c->id; tcpconn_put(c); setvalue: - memset(&val, 0, sizeof(pv_value_t)); - val.ri = conid; - val.flags = PV_VAL_INT | PV_TYPE_INT; - if(pvs->setf(msg, &pvs->pvp, (int)EQ_T, &val) < 0) { - LM_ERR("failed to set the output var\n"); - return -1; + if(pvs != NULL) { + memset(&val, 0, sizeof(pv_value_t)); + val.ri = conid; + val.flags = PV_VAL_INT | PV_TYPE_INT; + if(pvs->setf(msg, &pvs->pvp, (int)EQ_T, &val) < 0) { + LM_ERR("failed to set the output var\n"); + return -1; + } } - if(conid == 0) { + if(conid <= 0) { return -1; } return 1; @@ -638,6 +643,29 @@ static int w_tcp_get_conid(sip_msg_t *msg, char *paddr, char *pvn) return ki_tcp_get_conid_helper(msg, &saddr, (pv_spec_t *)pvn); } +/** + * + */ +static int ki_tcp_con_alive(sip_msg_t *msg, str *saddr) +{ + return ki_tcp_get_conid_helper(msg, saddr, NULL); +} + +/** + * + */ +static int w_tcp_con_alive(sip_msg_t *msg, char *paddr, char *p2) +{ + str saddr; + + if(fixup_get_svalue(msg, (gparam_t *)paddr, &saddr) < 0) { + LM_ERR("failed to get address parameter\n"); + return -1; + } + + return ki_tcp_get_conid_helper(msg, &saddr, NULL); +} + /** * */ @@ -923,6 +951,11 @@ static sr_kemi_t sr_kemi_tcpops_exports[] = { { SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("tcpops"), str_init("tcp_con_alive"), + SR_KEMIP_INT, ki_tcp_con_alive, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("tcpops"), str_init("tcp_get_conid"), SR_KEMIP_INT, ki_tcp_get_conid, { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE,

1 0

DMQ improvements for detecting inactive nodes
by Stefan Mititelu 18 Mar '25

18 Mar '25

Hi, Currently there is ping mechanism in DMQ for detecting inactive nodes. However this triggers only on "ping_interval". DMQ exposes API functions to other modules for sending dmq messages or broadcasting them. This API functions require "dmq_resp_cback_t" to be passed as parameter. Most of the other modules just log a DBG msg in it. There are two improvement ideas: 1. other modules that use DMQ, to detect node failures too, as they are sending/bcasting messages. This, in addition to DMQ module "ping_interval" mechanism. 2. don't set inactive state of nodes on first failure, but have per node counter of fails, and modparam to tune this check. To do this either: A. Implement the response callback in each module that use DMQ, to check response code and set inactive state of dmq node => duplicate same code across different modules B. Send NULL for that "dmq_resp_cback_t" from other modules that use DMQ. In DMQ module itself, check if NULL and if so, use a default callback that checks response code and set inactive state of dmq nodes => cleaner approach Any opinions on this? Do you see any possible problems with this? Thanks, Stefan

2 1

[kamailio/kamailio] secfilter‌: support remove rule in Whitelist and Blacklist (PR #4089)
by AsedMorteza 18 Mar '25

18 Mar '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description ##### **Summary** This update introduces new functionality to the `secfilter` module, enabling the removal of entries from both the Blacklist and Whitelist. It also includes automatic detection and removal of duplicate values from these lists. ##### **Details** * Users can now remove specific entries from the Blacklist or Whitelist based on type (e.g., IP, domain, user) and a given value. * Supports removal of single or multiple matching entries in one operation. ##### **Benefits** - Improves the usability and flexibility of the `secfilter` module by allowing fine-grained control over list management. - Ensures that the Blacklist and Whitelist are kept clean and free from redundant entries. - Enhances performance by reducing unnecessary duplication in the lists. ##### Testing This feature was tested using `kmcmd` commands in various scenarios: - Removing the **first element** in the list. - Removing an element from the **middle** of the list. - Removing the **last element** in the list. - Removing **all matching elements** in the list. In all cases, the commands worked correctly, and the lists were updated and cleaned as expected. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4089 -- Commit Summary -- * secfilter‌: support remove rule in Whitelist and Blacklist -- File Changes -- M src/modules/secfilter/secfilter.c (8) M src/modules/secfilter/secfilter.h (3) M src/modules/secfilter/secfilter_db.c (106) M src/modules/secfilter/secfilter_rpc.c (95) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4089.patch https://github.com/kamailio/kamailio/pull/4089.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4089 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4089(a)github.com>

4 6

← Newer
1
...
6
7
8
9
10
11
12
...
18
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2025