<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
##### **Summary**
This update introduces new functionality to the `secfilter` module, enabling the removal of entries from both the Blacklist and Whitelist. It also includes automatic detection and removal of duplicate values from these lists.
##### **Details**
* Users can now remove specific entries from the Blacklist or Whitelist based on type (e.g., IP, domain, user) and a given value.
* Supports removal of single or multiple matching entries in one operation.
##### **Benefits**
- Improves the usability and flexibility of the `secfilter` module by allowing fine-grained control over list management.
- Ensures that the Blacklist and Whitelist are kept clean and free from redundant entries.
- Enhances performance by reducing unnecessary duplication in the lists.
##### Testing
This feature was tested using `kmcmd` commands in various scenarios:
- Removing the **first element** in the list.
- Removing an element from the **middle** of the list.
- Removing the **last element** in the list.
- Removing **all matching elements** in the list.
In all cases, the commands worked correctly, and the lists were updated and cleaned as expected.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4089
-- Commit Summary --
* secfilter: support remove rule in Whitelist and Blacklist
-- File Changes --
M src/modules/secfilter/secfilter.c (8)
M src/modules/secfilter/secfilter.h (3)
M src/modules/secfilter/secfilter_db.c (106)
M src/modules/secfilter/secfilter_rpc.c (95)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4089.patchhttps://github.com/kamailio/kamailio/pull/4089.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4089
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4089(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #4174
#### Description
Extend the return value of dns_cache_print_entry with the parameter `rr_skip_record` for NAPTR records. The parameter `rr_skip_record` indicates, whether the NAPTR record is skipped due to issues reaching the destinations. Once a NAPTR record is marked as skipped, it will no longer be used.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4175
-- Commit Summary --
* core: Include parameter skip_record in dns_cache_print_entry
-- File Changes --
M src/core/dns_cache.c (7)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4175.patchhttps://github.com/kamailio/kamailio/pull/4175.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4175
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4175(a)github.com>
[View Less]
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/…
[View More]lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
When `auto_bind_ipv6` is enabled on a system without ipv6, kamailio starts, enumerates all interfaces but does not perform no listening at all. In addition, no errors are reported, see below from final part of boot log, no other infos are logged.
While this can be worked around by putting that config value behind a definition and autodetection by an external script, should not it work and just start on ipv4 if ipv6 is not available?
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
Just start Kam as root, with no `listen` directives (to let it listen on all ipv4) and `auto_bind_ipv6` set to 1.
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: lo Fam: 2 Flg: 10049 Adr: 127.0.0.1
0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: enp81s0u1u4 Fam: 2 Flg: 11043 Adr: 192.168.1.222
0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: wlp0s20f3 Fam: 2 Flg: 11043 Adr: 192.168.1.196
0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: br-65b842ff8266 Fam: 2 Flg: 1003 Adr: 192.168.49.1
0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: br-kamnet Fam: 2 Flg: 11043 Adr: 172.23.42.1
0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: br-f1829eb65bac Fam: 2 Flg: 1003 Adr: 172.18.0.1
0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: br-f521fee918b4 Fam: 2 Flg: 1003 Adr: 172.19.0.1
0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: docker0 Fam: 2 Flg: 1003 Adr: 172.17.0.1
0(1) DEBUG: <core> [core/socket_info.c:1507]: build_iface_list(): received 728 byles
0(1) DEBUG: <core> [core/socket_info.c:1507]: build_iface_list(): received 20 byles
0(1) DEBUG: <core> [core/socket_info.c:1510]: build_iface_list(): done receiving netlink info
0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 1 (n: 0)
0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '127.0.0.1'
0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '127.0.0.1'
0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is lo
0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 3 (n: 1)
0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '192.168.1.222'
0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '192.168.1.222'
0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is enp81s0u1u4
0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 4 (n: 2)
0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '192.168.1.196'
0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '192.168.1.196'
0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is wlp0s20f3
0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 5 (n: 3)
0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '192.168.49.1'
0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '192.168.49.1'
0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is br-65b842ff8266
0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 6 (n: 4)
0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '172.23.42.1'
0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '172.23.42.1'
0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is br-kamnet
0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 7 (n: 5)
0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '172.18.0.1'
0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '172.18.0.1'
0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is br-f1829eb65bac
0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 8 (n: 6)
0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '172.19.0.1'
0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '172.19.0.1'
0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is br-f521fee918b4
0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 9 (n: 7)
0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '172.17.0.1'
0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '172.17.0.1'
0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is docker0
0(1) DEBUG: <core> [core/socket_info.c:1507]: build_iface_list(): received 1740 byles
```
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
head of 5.8 branch as of today
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
ubuntu noble (in a docker container)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4098
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4098(a)github.com>
[View Less]
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature …
[View More](non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #3264
#### Description
The proposed patch adds KEMI support to SIPT module, include KEMI functions:
- `destination()` for `sipt_destination()` with default `terminator=1`;
- `destination_terminator()` for `sipt_destination()` with various `terminator`;
- `forwarding()` for `sipt_forwarding()`;
- `has_isup_body()` for `sipt_has_isup_body()`;
- `set_bci_1()` for `sipt_set_bci_1()`;
- `set_calling()` for `sipt_set_calling()`.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4172
-- Commit Summary --
* sipt: KEMI support
-- File Changes --
M src/modules/sipt/sipt.c (118)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4172.patchhttps://github.com/kamailio/kamailio/pull/4172.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4172
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4172(a)github.com>
[View Less]
ChristianBergerSipgate created an issue (kamailio/kamailio#4167)
Hi,
we have found a potential bug. The pseudo variables return null for WSS connections.
Example config:
`xlog("L_INFO", "<mainLogic> REGISTER: TLS or WSS detected: fU=$fU tls_version=$tls_version tls_cipher_info=$tls_cipher_info ua=$ua\n");`
Log output:
`Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "ERROR", "module": "tls", "file": "tls_select.c", "line": 131, "function": "…
[View More]get_cur_connection", "message": "Transport protocol is not TLS (bug in config)\n" }
Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "INFO", "module": "tls", "file": "tls_select.c", "line": 310, "function": "get_version", "message": "TLS connection not found in select_version\n" }
Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "ERROR", "module": "tls", "file": "tls_select.c", "line": 131, "function": "get_cur_connection", "message": "Transport protocol is not TLS (bug in config)\n" }
Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "INFO", "module": "tls", "file": "tls_select.c", "line": 201, "function": "get_cipher", "message": "TLS connection not found in select_cipher\n" }
Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "INFO", "module": "xlog", "file": "xlog.c", "line": 278, "function": "", "message": "<mainLogic> REGISTER: TLS or WSS detected: fU=1125411e0 tls_version=<null> tls_cipher_info=<null> ua=webphone\n" }`
As you can see both tls_version and tls_cipher_info return <null> even though the underlying connection is via WSS.
We have looked into it, and it seems like `get_cur_connection` in `modules/tls/tls_select.c` only checks for TLS, but not WSS.
```
struct tcp_connection *get_cur_connection(struct sip_msg *msg)
{
struct tcp_connection *c;
if(_tls_pv_con != 0)
return _tls_pv_con;
if(msg->rcv.proto != PROTO_TLS) {
ERR("Transport protocol is not TLS (bug in config)\n");
return 0;
}
c = tcpconn_get(msg->rcv.proto_reserved1, 0, 0, 0,
cfg_get(tls, tls_cfg, con_lifetime));
if(c && c->type != PROTO_TLS) {
ERR("Connection found but is not TLS\n");
tcpconn_put(c);
return 0;
}
return c;
}
```
We think that checking for `PROTO_WSS` might solve the issue.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4167
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4167(a)github.com>
[View Less]
sergey-safarov created an issue (kamailio/kamailio#4180)
### Description
I have installed two `rtpengine` instances and want to use them as an `active backup`. I want to use `backup` only when `active` is unavailable.
Closest settings for this rtpengine node `weight` and want to use settings like
```
MariaDB [kamailio]> select * from rtpengine;
+----+-------+---------------------------------+--------+----------+---------------------+
| id | setid | url | weight |…
[View More] disabled | stamp |
+----+-------+---------------------------------+--------+----------+---------------------+
| 1 | 0 | udp6:[2005:84c0:bf:11::20]:2223 | 1 | 0 | 1900-01-01 00:00:01 |
| 2 | 0 | udp6:[2005:84c0:bf:11::21]:2223 | 0 | 0 | 1900-01-01 00:00:01 |
+----+-------+---------------------------------+--------+----------+---------------------+
```
But in case `weight=0` node is not selected and handled as disabled.
It will be fine do not use rtpengine nodes with `weight=0` when other rtpengine with `weight!=0` are available. But if no other nodes are available, use `weight=0` nodes as last resort.
### Expected behavior
Do not use rtpengine nodes with `weight=0` when other rtpengine with `weight!=0` are available. But if no other nodes are available, use `weight=0` nodes as last resort.
#### Actual observed behavior
The node is not selected and handled as disabled when `weight=0`.
#### Log Messages
```
rtpengine [rtpengine.c:3430]: rtpp_test(): rtpengine instance <udp6:[2005:84c0:bf:11::21]:2223> found, support for it enabled
rtpengine [rtpengine.c:3883]: select_rtpp_node(): rtpengine failed to select new for calllen=27 callid=1-10824@2005:84c0:bf:11::22
rtpengine [rtpengine.c:3183]: rtpp_function_call(): no available proxies
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4180
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4180(a)github.com>
[View Less]