sr-dev July 2024

sr-dev@lists.kamailio.org

4 participants
31 discussions

Start a nNew thread

[kamailio/kamailio] sqlops: Don't truncated sql command when logging. (PR #3903)

by Xenofon Karamanos

8 hours, 24 minutes

[kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)

by Oded Arbel

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #### Description In `send_rtpp_command()` if socket operations fail with an error other than `EINTR` or `ENOBUFS`, the actual error is not reported - we just get a generic "Can't send command to/read reply from RTPEngine". Other places in the module report `errno` and `strerror(errno)` using the log format "`(%s:%d)`" so added that to the error log. Also fixed `bind_force_send_ip()` error log to use the same semantic as the other places. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3899 -- Commit Summary -- * rtpengine: show errno and error string in more places where it is useful -- File Changes -- M src/modules/rtpengine/rtpengine.c (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3899.patch https://github.com/kamailio/kamailio/pull/3899.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3899 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3899(a)github.com>

9 hours, 13 minutes

git:master:fae2a467: rtpengine: show errno and error string in more places where it is useful (#3899)

by GitHub

Module: kamailio Branch: master Commit: fae2a467cb7b543920cf8bea3ce655ad07b70969 URL: https://github.com/kamailio/kamailio/commit/fae2a467cb7b543920cf8bea3ce655a… Author: Oded Arbel <oded(a)geek.co.il> Committer: GitHub <noreply(a)github.com> Date: 2024-07-02T08:19:11-04:00 rtpengine: show errno and error string in more places where it is useful (#3899) Also fixed bind_force_send_ip() error log to use the same semantic as other places --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/fae2a467cb7b543920cf8bea3ce655a… Patch: https://github.com/kamailio/kamailio/commit/fae2a467cb7b543920cf8bea3ce655a… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 54f22b1843f..7b97a2ae1ee 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -830,7 +830,7 @@ static int bind_force_send_ip(int sock_idx) sizeof(ip6addr))) < 0) { LM_ERR("can't bind socket to required ipv6 interface\n"); - LM_ERR("ret=%d errno=%d\n", ret, errno); + LM_ERR("ret=%d (%s:%d)\n", ret, strerror(errno), errno); return -1; } @@ -3598,7 +3598,7 @@ static char *send_rtpp_command( struct rtpp_node *node, bencode_item_t *dict, int *outlen) { struct sockaddr_un addr; - int fd, len, i, vcnt; + int fd = -1, len, i, vcnt; int rtpengine_retr, rtpengine_tout_ms = 1000; char *cp; static char buf[0x40000]; @@ -3632,8 +3632,8 @@ static char *send_rtpp_command( goto badproxy; } if(connect(fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) { - close(fd); - LM_ERR("can't connect to RTPEngine <%s>\n", node->rn_url.s); + LM_ERR("can't connect to RTPEngine <%s> (%s:%d)\n", node->rn_url.s, + strerror(errno), errno); goto badproxy; } @@ -3641,18 +3641,19 @@ static char *send_rtpp_command( len = writev(fd, v + 1, vcnt); } while(len == -1 && errno == EINTR); if(len <= 0) { - close(fd); - LM_ERR("can't send command to RTPEngine <%s>\n", node->rn_url.s); + LM_ERR("can't send command to RTPEngine <%s> (%s:%d)\n", + node->rn_url.s, strerror(errno), errno); goto badproxy; } do { len = read(fd, buf, sizeof(buf) - 1); } while(len == -1 && errno == EINTR); - close(fd); if(len <= 0) { - LM_ERR("can't read reply from RTPEngine <%s>\n", node->rn_url.s); + LM_ERR("can't read reply from RTPEngine <%s> (%s:%d)\n", + node->rn_url.s, strerror(errno), errno); goto badproxy; } + close(fd); } else if(node->rn_umode == RNU_WS || node->rn_umode == RNU_WSS) { /* assemble full request string, flatten iovec */ v[0].iov_base = gencookie(); @@ -3721,8 +3722,9 @@ static char *send_rtpp_command( } while(len == -1 && (errno == EINTR || errno == ENOBUFS)); if(len <= 0) { bencode_get_str(bencode_dictionary_get(dict, "command"), &cmd); - LM_ERR("can't send command \"%.*s\" to RTPEngine <%s>\n", - cmd.len, cmd.s, node->rn_url.s); + LM_ERR("can't send command \"%.*s\" to RTPEngine <%s> " + "(%s:%d)\n", + cmd.len, cmd.s, node->rn_url.s, strerror(errno), errno); goto badproxy; } while((poll(fds, 1, rtpengine_tout_ms) == 1) @@ -3734,8 +3736,9 @@ static char *send_rtpp_command( bencode_get_str( bencode_dictionary_get(dict, "command"), &cmd); LM_ERR("can't read reply for command \"%.*s\" from " - "RTPEngine <%s>\n", - cmd.len, cmd.s, node->rn_url.s); + "RTPEngine <%s> (%s:%d)\n", + cmd.len, cmd.s, node->rn_url.s, strerror(errno), + errno); goto badproxy; } if(len >= (v[0].iov_len - 1) @@ -3767,6 +3770,7 @@ static char *send_rtpp_command( return cp; badproxy: + close(fd); return NULL; }

9 hours, 14 minutes

[kamailio/kamailio] core: add support for custom log function (PR #3902)

by Nirv.Ana

10 hours, 33 minutes

[kamailio/kamailio] misc/examples/ims/icscf: fix bad prefix added on all incoming requests (PR #3900)

by Dragos Vingarzan

11 hours, 51 minutes

git:master:b753682b: misc/examples/ims/icscf: removed always adding a plus as a prefix on requests arriving to the I-CSCF (#3900)

by GitHub

Module: kamailio Branch: master Commit: b753682bdfa722280ed2dd3ca79b790f5c7529d1 URL: https://github.com/kamailio/kamailio/commit/b753682bdfa722280ed2dd3ca79b790… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2024-07-02T11:41:25+02:00 misc/examples/ims/icscf: removed always adding a plus as a prefix on requests arriving to the I-CSCF (#3900) --- Modified: misc/examples/ims/icscf/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/b753682bdfa722280ed2dd3ca79b790… Patch: https://github.com/kamailio/kamailio/commit/b753682bdfa722280ed2dd3ca79b790… --- diff --git a/misc/examples/ims/icscf/kamailio.cfg b/misc/examples/ims/icscf/kamailio.cfg index 4434e6a25d6..1fb51fef680 100644 --- a/misc/examples/ims/icscf/kamailio.cfg +++ b/misc/examples/ims/icscf/kamailio.cfg @@ -238,10 +238,6 @@ route{ xlog("I-CSCF >>>>>>>>>>>>>>>>>>>> $rm $ru ($fu => $tu ($si:$sp) to $tu, $ci)\n"); #!endif - if !($rU =~ "\+.*") { - prefix("+"); - } - # per request initial checks route(REQINIT);

11 hours, 52 minutes

[kamailio/kamailio] ims_registrar_pcscf,ims_qos: support for trusting bottom via (PR #3901)

by Dragos Vingarzan

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to PR https://github.com/kamailio/kamailio/pull/3891 #### Description  Normally, the IMS P-CSCF should identify the clients (UEs) by the received IP address and ports on Rx. The current code is using a mix of that, plus using Contact and Via headers, with arguable potential security issues. This patch adds a new parameter to `ims_registrar_pcscf` and `ims_qos` modules, allowing for an optional outsource of the IPsec functionality to another element, which is also in charge of checking/enforcing correct UE Via header. The existing code is allowed to work as before, with the default value of the flag being towards that. List of functional changes: - `ims_qos` - added `trust_bottom_via` parameter - used it on `w_rx_aar_register()` - `ims_registrar_pcscf` - added `trust_bottom_via` parameter - used it on `update_contacts()`, `save_pending()`, `check_contact()`, `getContactP()`, `check_service_routes()`, `enforce_service_routes()` - made `ims_ipsec_pcscf` dependency optional, with checks when used - skipped checks of `port-uc` in `checkcontact()` if the `ims_ipsec_pcscf` module was not loaded - added `ignore_contact_rxproto_check` parameter - IMS devices open IPsec Security Associations just between IPs and ports, with both UDP and TCP protocols allowed. The default then was set here to always ignore protocol checks. Before, the `ignore_contact_rxport_check` was used to skip this and still make it work, but that seemed like a typo/mistake with hidden effects. List of indirect changes: - `core/ut.h`: added a `str2ushort()` macro, since code was using some dangerous casting and macros with a larger type - `ims_registrar_pcscf`: added `Route` headers in `SUBSCRIBE` to `reginfo`, with values from `Service-Route`s, as per 3GPP specs. - `ims_usrloc_pcscf`: small log fixes You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3901 -- Commit Summary -- * core: added str2ushort() to avoid some questionable casting in ims_qos * lib/ims: fixed a typo in a log message * ims_usrloc_pcscf: small log fixes * ims_qos: added trust_bottom_via parameter * ims_registrar_pcscf: added trust_bottom_via parameter, added ignore_contact_rxproto_check, fixes for logging, fixes for SUBSCRIBE to reginfo for including Service-Route, allow use without ims_ipsec_pcscf -- File Changes -- M src/core/ut.h (8) M src/lib/ims/ims_getters.c (2) M src/modules/ims_qos/doc/ims_qos.xml (6) M src/modules/ims_qos/doc/ims_qos_admin.xml (41) M src/modules/ims_qos/ims_qos_mod.c (27) M src/modules/ims_qos/rx_aar.h (4) M src/modules/ims_qos/rx_authdata.h (2) M src/modules/ims_qos/rx_avp.c (2) M src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf.xml (6) M src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml (73) M src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c (26) M src/modules/ims_registrar_pcscf/notify.c (2) M src/modules/ims_registrar_pcscf/save.c (80) M src/modules/ims_registrar_pcscf/service_routes.c (136) M src/modules/ims_registrar_pcscf/subscribe.c (74) M src/modules/ims_registrar_pcscf/subscribe.h (4) M src/modules/ims_usrloc_pcscf/udomain.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3901.patch https://github.com/kamailio/kamailio/pull/3901.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3901 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3901(a)github.com>

12 hours, 44 minutes

Kamailio v5.7.6 Released

by Daniel-Constantin Mierla

Hello, Kamailio SIP Server v5.7.6 stable release is out. This is a maintenance release of the latest stable branch, 5.7, that includes fixes since the release of v5.7.5. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.7.x. Deployments running previous v5.7.x versions are strongly recommended to be upgraded to v5.7.6. For more details about version 5.7.6 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2024/07/kamailio-v5-7-6-released/ RPM, Debian/Ubuntu packages will be available soon as well. Note that 5.7.x is currently the previous stable release series, the latest is 5.8.x and v5.8.2 was released on June 12, 2024. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

13 hours, 8 minutes

[kamailio/kamailio] usrloc: refactor some db queries using global usrloc_columns variable (PR #3888)

by Lucian Balaceanu

13 hours, 13 minutes

[kamailio/kamailio] db_redis: change logs on delete (PR #3892)

by Stefan Mititelu

13 hours, 17 minutes

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2024