sr-dev May 2024

sr-dev@lists.kamailio.org

15 participants
166 discussions

by tyler moore

Sergey, Is the build toolchain for the RPM packages using an old version of openssl? I am seeing incompatibility errors when testing with 5.8.1 RPM and openssl-devel from system, or appstream repos. These are the version differences I see in the logs: |CRITICAL: tls [tls_init.c:870]: tls_h_mod_init_f(): installed openssl library version is too different from the library the kamailio tls module was compiled with: installed "OpenSSL 3.2.1 30 Jan 2024" (0x30200010), compiled "OpenSSL 3.0.7 1 Nov 2022" (0x30000070).#012 Please make sure a compatible version is used (tls_force_run in kamailio.cfg will override this check) | Here is what I see in the system RPMs for openssl on centos9: |[root@cent9-v075 ~]# dnf info openssl-devel Last metadata expiration check: 0:03:11 ago on Tue 21 May 2024 08:31:12 PM UTC. Installed Packages Name : openssl-devel Epoch : 1 Version : 3.2.1 Release : 1.el9 Architecture : x86_64 Size : 4.9 M Source : openssl-3.2.1-1.el9.src.rpm Repository : @System From repo : appstream Summary : Files for development of applications which will use OpenSSL URL : http://www.openssl.org/ License : ASL 2.0 Description : OpenSSL is a toolkit for supporting cryptography. The openssl-devel : package contains include files needed to develop applications which : support various cryptographic algorithms and protocols. | Regards, Tyler Moore Full Stack Software Engineer dOpenSource Office: 888-907-2085, ext: 34 Cell: 248-909-2769 Email:tmoore@dopensource.com

7 months

[kamailio/kamailio] Segfault in pua_dialoginfo.c when starting up with a dialog in the database (Issue #3743)

by Gianluca Nitti

### Description Kamailio segfaults on startup. After a bit of digging, it looks like the issue is caused by trying to publish something related to an expired dalog which is present in the database: ``` kamailio=# select * from dialog; id | hash_entry | hash_id | callid | from_uri | from_tag | to_uri | to_tag | caller_cseq | callee_cseq | caller_route_set | callee_route_set | caller_contact | callee_contact | caller_sock | callee_sock | state | start_time | timeout | sflags | iflags | toroute_name | req_ur i | xdata ----+------------+---------+---------------------------+------------------------------+----------+-------------------------------------------+---------------+-------------+- ------------+--------------------------------------------+------------------+---------------------------------------------------------------------------+-------------------- -----------------------------------+----------------------+----------------------+-------+------------+------------+--------+--------+--------------+------------------------ -------------------+------- 90 | 3720 | 11295 | msowdcchfzrlapg@localhost | sip:101@example.voismart.com | msfvz | sip:*9001*0039123456@example.voismart.com | HBQj442BFrH0N | 131 | 0 | <sip:172.23.42.1;lr=on;ftag=msfvz;nat=yes> | | sip:101_example_voismart_com@172.23.42.1:5065;alias=192.168.1.201~32878~1 | sip:*9001*003912345 6@172.23.42.211:5060;transport=udp | udp:172.23.42.3:5060 | udp:172.23.42.3:5060 | 4 | 1706715542 | 1706801943 | 0 | 1 | | sip:*9001*0039123456@ex ample.voismart.com | (1 row) ``` ### Troubleshooting #### Debugging Data  ``` (gdb) bt full #0 0x00007f193de1bc93 in free_str_list_all (del_current=0x2e656c706d617865) at /usr/local/src/pkg/src/modules/pua_dialoginfo/pua_dialoginfo.c:1109 del_next = <optimized out> __func__ = "free_str_list_all" #1 0x00007f193de1ebc6 in free_dlginfo_cell (param=0x7f1942265dc8) at /usr/local/src/pkg/src/modules/pua_dialoginfo/pua_dialoginfo.c:1079 cell = 0x7f1942265dc8 cell = <optimized out> __func__ = <optimized out> #2 free_dlginfo_cell (param=0x7f1942265dc8) at /usr/local/src/pkg/src/modules/pua_dialoginfo/pua_dialoginfo.c:1070 cell = 0x0 __func__ = "free_dlginfo_cell" #3 0x00007f1940b7120b in destroy_dlg_callbacks_list (cb=0x0) at /usr/local/src/pkg/src/modules/dialog/dlg_cb.c:74 cb_t = 0x7f1942266050 __func__ = "destroy_dlg_callbacks_list" #4 0x00007f1940ba5229 in destroy_dlg (dlg=0x7f1941b1a8a0) at /usr/local/src/pkg/src/modules/dialog/dlg_hash.c:369 ret = <optimized out> var = <optimized out> __func__ = "destroy_dlg" #5 0x00007f1940ba6b08 in destroy_dlg_table () at /usr/local/src/pkg/src/modules/dialog/dlg_hash.c:436 dlg = 0x0 l_dlg = <optimized out> i = 3720 __func__ = <optimized out> #6 destroy_dlg_table () at /usr/local/src/pkg/src/modules/dialog/dlg_hash.c:422 dlg = <optimized out> l_dlg = <optimized out> i = <optimized out> __func__ = "destroy_dlg_table" #7 0x00007f1940b57b06 in mod_destroy () at /usr/local/src/pkg/src/modules/dialog/dialog.c:871 No locals. #8 0x000055dd96a6d1e2 in destroy_modules () at core/sr_module.c:872 t = 0x7f1949d9d5f0 foo = 0x7f1949d94710 __func__ = "destroy_modules" #9 0x000055dd96864d01 in cleanup (show_status=1) at /usr/local/src/pkg/src/main.c:573 memlog = <optimized out> --Type <RET> for more, q to quit, c to continue without paging-- __func__ = "cleanup" #10 0x000055dd96c92a4d in shutdown_children.constprop.0 (show_status=show_status@entry=1, sig=15) at /usr/local/src/pkg/src/main.c:721 __func__ = <optimized out> #11 0x000055dd9685fcd5 in handle_sigs () at /usr/local/src/pkg/src/main.c:821 chld = <optimized out> chld_status = 139 any_chld_stopped = <optimized out> memlog = <optimized out> __func__ = "handle_sigs" #12 0x000055dd96868aa4 in main_loop () at /usr/local/src/pkg/src/main.c:1988 i = <optimized out> pid = <optimized out> si = <optimized out> si_desc = "udp receiver child=31 sock=172.23.42.3:9999\000\335U\000\000\000\260\312I\031\177\000\000\003\000\000\000\377\377\377\377\004\220\312\226\335U\000\000\004\000\000\000\031\177\000\000\003\000\000\000\000\000\000\000\t\000\000\000\000\000\000\000Tue Feb \000\023&\252U\314\342\207:34 2024\005\000\000\000\000\000\000" nrprocs = <optimized out> woneinit = 1 error = <optimized out> __func__ = "main_loop" #13 0x000055dd96859ffc in main (argc=<optimized out>, argv=<optimized out>) at /usr/local/src/pkg/src/main.c:3212 cfg_stream = <optimized out> c = <optimized out> r = <optimized out> tmp = 0x7ffe9d9b7db4 "" tmp_len = 1274056464 port = 32537 proto = 1275323104 ahost = 0x0 aport = 0 options = 0x55dd96cac300 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 3377142042 rfd = <optimized out> debug_save = <optimized out> debug_flag = <optimized out> --Type <RET> for more, q to quit, c to continue without paging-- dont_fork_cnt = <optimized out> n_lst = <optimized out> p = <optimized out> st = {st_dev = 194, st_ino = 570312884, st_nlink = 2, st_mode = 16872, st_uid = 101, st_gid = 101, __pad0 = 0, st_rdev = 0, st_size = 6, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1707216241, tv_nsec = 46870706}, st_mtim = {tv_sec = 1707216227, tv_nsec = 573144090}, st_ctim = {tv_sec = 1707216227, tv_nsec = 573144090}, __glibc_reserved = {0, 0, 0}} tbuf = '\000' <repeats 16 times>, '/' <repeats 16 times>, "\230\r", '\000' <repeats 14 times>, "`", '\000' <repeats 15 times>, "\001", '\000' <repeats 143 times>... option_index = 12 __func__ = "main" long_options = {{name = 0x55dd96cabfe2 "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0x55dd96cb3dc8 "version", has_arg = 0, flag = 0x0, val = 118}, { name = 0x55dd96cc3731 "alias", has_arg = 1, flag = 0x0, val = 1024}, {name = 0x55dd96cabfe7 "subst", has_arg = 1, flag = 0x0, val = 1025}, { name = 0x55dd96cabfed "substdef", has_arg = 1, flag = 0x0, val = 1026}, {name = 0x55dd96cabff6 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, { name = 0x55dd96cac000 "server-id", has_arg = 1, flag = 0x0, val = 1028}, {name = 0x55dd96cac00a "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, { name = 0x55dd96cac015 "modparam", has_arg = 1, flag = 0x0, val = 1030}, {name = 0x55dd96cac01e "log-engine", has_arg = 1, flag = 0x0, val = 1031}, { name = 0x55dd96cb3ee5 "debug", has_arg = 1, flag = 0x0, val = 1032}, {name = 0x55dd96cac029 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, { name = 0x55dd96cac033 "atexit", has_arg = 1, flag = 0x0, val = 1034}, {name = 0x55dd96cac03a "all-errors", has_arg = 0, flag = 0x0, val = 1035}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}} (gdb) info locals del_next = <optimized out> __func__ = "free_str_list_all" (gdb) list 1104 in /usr/local/src/pkg/src/modules/pua_dialoginfo/pua_dialoginfo.c ``` #### Log Messages  ``` 65(75) DEBUG: dialog [dlg_timer.c:232]: get_expired_dlgs(): start with tl=0x7f1941b1a900 tl->prev=0x7f1941a084d8 tl->next=0x7f1941a084d8 (45536602) at 45536603 and end with end=0x7f1941a084d8 end->prev=0x7f1941b1a900 end->next=0x7f1941b1a900 65(75) DEBUG: dialog [dlg_timer.c:237]: get_expired_dlgs(): getting tl=0x7f1941b1a900 tl->prev=0x7f1941a084d8 tl->next=0x7f1941a084d8 with 45536602 65(75) DEBUG: dialog [dlg_timer.c:243]: get_expired_dlgs(): end with tl=0x7f1941a084d8 tl->prev=0x7f1941b1a900 tl->next=0x7f1941b1a900 and d_timer->first.next->prev=(nil) 65(75) DEBUG: dialog [dlg_timer.c:280]: dlg_timer_routine(): tl=0x7f1941b1a900 next=(nil) 65(75) DEBUG: dialog [dlg_cb.c:267]: run_dlg_callbacks(): dialog=0x7f1941b1a8a0, type=64 65(75) DEBUG: pua_dialoginfo [pua_dialoginfo.c:395]: __dialog_sendpublish(): dialog over, from=sip:101@example.voismart.com 65(75) DEBUG: pua_dialoginfo [dialog_publish.c:410]: dialog_publish_multi(): CALLING dialog_publish for URI 65(75) DEBUG: <core> [core/parser/parse_uri.c:1389]: parse_uri(): bad uri, state 0 parsed: <> (4) / <> (28) 65(75) ERROR: pua_dialoginfo [dialog_publish.c:303]: dialog_publish(): failed to parse the PUBLISH R-URI 123(133) CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 133 123(133) DEBUG: <core> [core/tcp_main.c:3955]: handle_ser_child(): dead child 65, pid 75 (shutting down?) 123(133) DEBUG: <core> [core/io_wait.h:597]: io_watch_del(): DBG: io_watch_del (0x55dd96e1fba0, 133, -1, 0x0) fd_no=157 called 0(1) ALERT: <core> [main.c:791]: handle_sigs(): child process 75 exited by a signal 11 0(1) ALERT: <core> [main.c:795]: handle_sigs(): core was generated 0(1) INFO: <core> [main.c:818]: handle_sigs(): terminating due to SIGCHLD 2(12) INFO: <core> [main.c:874]: sig_usr(): signal 15 received 3(13) INFO: <core> [main.c:874]: sig_usr(): signal 15 received ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.4 (x86_64/linux) dc393e flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: dc393e compiled with gcc 11.4.0 ``` * **Operating System**:  ``` Linux c7a9e0ef942e 6.6.13-200.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Sat Jan 20 18:03:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux ``` Running in a Docker container based on Ubuntu Jammy which builds kamailio from git tag 5.7.4. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3743 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3743(a)github.com>

7 months

CPU 100% with TLS

by David Villasmil

Hello, I'm in a situation where i have 5 proxies (5.5.7) deployed on AWS on 6cni.xlarge instances (4 cpu/8gb), all they're doing is taking TLS connections and forwarding everything to the proxy-dialogs (5.5.2). We opened traffic on these 5 proxies for about 20k clients. CPU just goes to 100% and stays there... (actually moving from core to core 100%). We were doing tls offloading on AWS but routing was a bit of a mess (receiving tls traffic on a non-tls, etc) and we never saw a problem CPU-wise there. config looks like #!define WORKERS 32 #!define MAX_TCP_TLS_CONNECTIONS 30000 #!define OPEN_FILES 65535 #!define TCP_CHILDREN_PROCESS 16 tcp_accept_no_cl=no # Needed for HTTP ( https://www.kamailio.org/wiki/cookbooks/devel/core#tcp_accept_no_cl) enable_tls=yes tls_port_no=TLS_PORT auto_aliases=no tcp_children=32 # socket_workers=WORKERS listen=EXTERNAL_LISTEN_SOCKET listen=EXTERNAL_LISTEN_SOCKET_TLS # socket_workers=WORKERS listen=INTERNAL_UDP_SOCKET I even attached gdb and all i see is: (gdb) bt #0 0x00001499de9e9853 in __libc_pause () at ../sysdeps/unix/sysv/linux/pause.c:29 #1 0x000055a58c1a8e6f in main_loop () #2 0x000055a58c1b29a1 in main () (gdb) #0 0x00001499de9e9853 in __libc_pause () at ../sysdeps/unix/sysv/linux/pause.c:29 #1 0x000055a58c1a8e6f in main_loop () #2 0x000055a58c1b29a1 in main () (gdb) #0 0x00001499de9e9853 in __libc_pause () at ../sysdeps/unix/sysv/linux/pause.c:29 #1 0x000055a58c1a8e6f in main_loop () #2 0x000055a58c1b29a1 in main () (gdb) #0 0x00001499de9e9853 in __libc_pause () at ../sysdeps/unix/sysv/linux/pause.c:29 #1 0x000055a58c1a8e6f in main_loop () #2 0x000055a58c1b29a1 in main () which doesn't seem like it's doing much, and stats look ok: kamcmd> stats.fetch all { core.bad_URIs_rcvd: 0 core.bad_msg_hdr: 0 core.drop_replies: 0 core.drop_requests: 0 core.err_replies: 0 core.err_requests: 0 core.fwd_replies: 0 core.fwd_requests: 72 core.rcv_replies: 4134 core.rcv_replies_18x: 159 core.rcv_replies_1xx: 279 core.rcv_replies_1xx_bye: 0 core.rcv_replies_1xx_cancel: 0 core.rcv_replies_1xx_invite: 279 core.rcv_replies_1xx_message: 0 core.rcv_replies_1xx_prack: 0 core.rcv_replies_1xx_refer: 0 core.rcv_replies_1xx_reg: 0 core.rcv_replies_1xx_update: 0 core.rcv_replies_2xx: 3068 core.rcv_replies_2xx_bye: 68 core.rcv_replies_2xx_cancel: 39 core.rcv_replies_2xx_invite: 72 core.rcv_replies_2xx_message: 0 core.rcv_replies_2xx_prack: 0 core.rcv_replies_2xx_refer: 0 core.rcv_replies_2xx_reg: 975 core.rcv_replies_2xx_update: 0 core.rcv_replies_3xx: 0 core.rcv_replies_3xx_bye: 0 core.rcv_replies_3xx_cancel: 0 core.rcv_replies_3xx_invite: 0 core.rcv_replies_3xx_message: 0 core.rcv_replies_3xx_prack: 0 core.rcv_replies_3xx_refer: 0 core.rcv_replies_3xx_reg: 0 core.rcv_replies_3xx_update: 0 core.rcv_replies_401: 658 core.rcv_replies_404: 0 core.rcv_replies_407: 72 core.rcv_replies_480: 4 core.rcv_replies_486: 0 core.rcv_replies_4xx: 776 core.rcv_replies_4xx_bye: 2 core.rcv_replies_4xx_cancel: 1 core.rcv_replies_4xx_invite: 115 core.rcv_replies_4xx_message: 0 core.rcv_replies_4xx_prack: 0 core.rcv_replies_4xx_refer: 0 core.rcv_replies_4xx_reg: 658 core.rcv_replies_4xx_update: 0 core.rcv_replies_5xx: 0 core.rcv_replies_5xx_bye: 0 core.rcv_replies_5xx_cancel: 0 core.rcv_replies_5xx_invite: 0 core.rcv_replies_5xx_message: 0 core.rcv_replies_5xx_prack: 0 core.rcv_replies_5xx_refer: 0 core.rcv_replies_5xx_reg: 0 core.rcv_replies_5xx_update: 0 core.rcv_replies_6xx: 11 core.rcv_replies_6xx_bye: 0 core.rcv_replies_6xx_cancel: 0 core.rcv_replies_6xx_invite: 11 core.rcv_replies_6xx_message: 0 core.rcv_replies_6xx_prack: 0 core.rcv_replies_6xx_refer: 0 core.rcv_replies_6xx_reg: 0 core.rcv_replies_6xx_update: 0 core.rcv_requests: 2170 core.rcv_requests_ack: 210 core.rcv_requests_bye: 83 core.rcv_requests_cancel: 45 core.rcv_requests_info: 0 core.rcv_requests_invite: 196 core.rcv_requests_message: 0 core.rcv_requests_notify: 0 core.rcv_requests_options: 0 core.rcv_requests_prack: 0 core.rcv_requests_publish: 0 core.rcv_requests_refer: 0 core.rcv_requests_register: 1636 core.rcv_requests_subscribe: 0 core.rcv_requests_update: 0 core.unsupported_methods: 0 dns.failed_dns_request: 0 dns.slow_dns_request: 0 shmem.fragments: 270 shmem.free_size: 4283453736 shmem.max_used_size: 13711272 shmem.real_used_size: 11513560 shmem.total_size: 4294967296 shmem.used_size: 8167352 sl.1xx_replies: 0 sl.200_replies: 0 sl.202_replies: 0 sl.2xx_replies: 0 sl.300_replies: 0 sl.301_replies: 0 sl.302_replies: 0 sl.3xx_replies: 0 sl.400_replies: 0 sl.401_replies: 0 sl.403_replies: 0 sl.404_replies: 0 sl.407_replies: 0 sl.408_replies: 0 sl.483_replies: 0 sl.4xx_replies: 0 sl.500_replies: 0 sl.5xx_replies: 0 sl.6xx_replies: 0 sl.failures: 0 sl.received_ACKs: 0 sl.sent_err_replies: 0 sl.sent_replies: 0 sl.xxx_replies: 0 tcp.con_reset: 5 tcp.con_timeout: 54 tcp.connect_failed: 3 tcp.connect_success: 0 tcp.current_opened_connections: 44 tcp.current_write_queue_size: 0 tcp.established: 295 tcp.local_reject: 0 tcp.passive_open: 295 tcp.send_timeout: 0 tcp.sendq_full: 0 tmx.2xx_transactions: 3074 tmx.3xx_transactions: 0 tmx.4xx_transactions: 780 tmx.5xx_transactions: 0 tmx.6xx_transactions: 11 tmx.UAC_transactions: 1914 tmx.UAS_transactions: 3860 tmx.active_transactions: 1 tmx.inuse_transactions: 12 tmx.rpl_absorbed: 162 tmx.rpl_generated: 247 tmx.rpl_received: 4134 tmx.rpl_relayed: 3972 tmx.rpl_sent: 4219 } any ideas? thanks!, David Villasmil email: david.villasmil.work(a)gmail.com phone: +34669448337

7 months

Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local AC (3a34b46)

by Victor Seva

@juha-h please use ``cherry-pick -x <SHA>`` when back-porting -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/3a34b468ad93904c507bd0fc7ef592b… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/3a34b468ad93904c507bd0fc7ef592b25321807f/142208292(a)github.com>

7 months

[kamailio/kamailio] Add mandatory Max-Forwards header to local ACK (PR #3856)

by juha-h

#### Type Of Change - [ x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x ] PR should be backported to stable branches - [ x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Add mandatory Max-Forwards header to local ACK You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3856 -- Commit Summary -- * Add mandatory Max-Forwards header to local AC -- File Changes -- M src/modules/tm/t_msgbuilder.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3856.patch https://github.com/kamailio/kamailio/pull/3856.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3856(a)github.com>

7 months

git:5.8:3a34b468: tm: add mandatory Max-Forwards header to local AC

by Juha Heinanen

Module: kamailio Branch: 5.8 Commit: 3a34b468ad93904c507bd0fc7ef592b25321807f URL: https://github.com/kamailio/kamailio/commit/3a34b468ad93904c507bd0fc7ef592b… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: 2024-05-20T19:54:45+03:00 tm: add mandatory Max-Forwards header to local AC --- Modified: src/modules/tm/t_msgbuilder.c --- Diff: https://github.com/kamailio/kamailio/commit/3a34b468ad93904c507bd0fc7ef592b… Patch: https://github.com/kamailio/kamailio/commit/3a34b468ad93904c507bd0fc7ef592b… --- diff --git a/src/modules/tm/t_msgbuilder.c b/src/modules/tm/t_msgbuilder.c index 362ff6c5eb5..1aa680aa9a4 100644 --- a/src/modules/tm/t_msgbuilder.c +++ b/src/modules/tm/t_msgbuilder.c @@ -1246,7 +1246,8 @@ char *build_dlg_ack(struct sip_msg *rpl, struct cell *Trans, /* headers */ *len += Trans->from_hdr.len + Trans->callid_hdr.len + to->len - + Trans->cseq_hdr_n.len + 1 + ACK_LEN + CRLF_LEN; + + Trans->cseq_hdr_n.len + 1 + ACK_LEN + +MAXFWD_HEADER_LEN + + CRLF_LEN; /* copy'n'paste Route headers */ @@ -1291,6 +1292,8 @@ char *build_dlg_ack(struct sip_msg *rpl, struct cell *Trans, append_str(p, Trans->callid_hdr.s, Trans->callid_hdr.len); append_str(p, to->s, to->len); + append_str(p, MAXFWD_HEADER, MAXFWD_HEADER_LEN); + append_str(p, Trans->cseq_hdr_n.s, Trans->cseq_hdr_n.len); append_str(p, " ", 1); append_str(p, ACK, ACK_LEN);

7 months

git:master:d4629be2: tm: add mandatory Max-Forwards header to local AC

by Victor Seva

Module: kamailio Branch: master Commit: d4629be286fc6d3cf61574e34ee877b2c5e9ee4a URL: https://github.com/kamailio/kamailio/commit/d4629be286fc6d3cf61574e34ee877b… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-05-20T12:18:38+02:00 tm: add mandatory Max-Forwards header to local AC --- Modified: src/modules/tm/t_msgbuilder.c --- Diff: https://github.com/kamailio/kamailio/commit/d4629be286fc6d3cf61574e34ee877b… Patch: https://github.com/kamailio/kamailio/commit/d4629be286fc6d3cf61574e34ee877b… --- diff --git a/src/modules/tm/t_msgbuilder.c b/src/modules/tm/t_msgbuilder.c index 362ff6c5eb5..1aa680aa9a4 100644 --- a/src/modules/tm/t_msgbuilder.c +++ b/src/modules/tm/t_msgbuilder.c @@ -1246,7 +1246,8 @@ char *build_dlg_ack(struct sip_msg *rpl, struct cell *Trans, /* headers */ *len += Trans->from_hdr.len + Trans->callid_hdr.len + to->len - + Trans->cseq_hdr_n.len + 1 + ACK_LEN + CRLF_LEN; + + Trans->cseq_hdr_n.len + 1 + ACK_LEN + +MAXFWD_HEADER_LEN + + CRLF_LEN; /* copy'n'paste Route headers */ @@ -1291,6 +1292,8 @@ char *build_dlg_ack(struct sip_msg *rpl, struct cell *Trans, append_str(p, Trans->callid_hdr.s, Trans->callid_hdr.len); append_str(p, to->s, to->len); + append_str(p, MAXFWD_HEADER, MAXFWD_HEADER_LEN); + append_str(p, Trans->cseq_hdr_n.s, Trans->cseq_hdr_n.len); append_str(p, " ", 1); append_str(p, ACK, ACK_LEN);

7 months

git:master:4eb39425: pv: added $cts - contact header star status

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 4eb39425e2bb9322e0cc4f0c013aaeab1fcfb9dd URL: https://github.com/kamailio/kamailio/commit/4eb39425e2bb9322e0cc4f0c013aaea… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-05-17T10:40:54+02:00 pv: added $cts - contact header star status - 1 if it is *, 0 otherwise --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_core.c Modified: src/modules/pv/pv_core.h --- Diff: https://github.com/kamailio/kamailio/commit/4eb39425e2bb9322e0cc4f0c013aaea… Patch: https://github.com/kamailio/kamailio/commit/4eb39425e2bb9322e0cc4f0c013aaea… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index 3226c773a2e..ec6488d1f04 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -163,6 +163,8 @@ static pv_export_t mod_pvs[] = { PVT_OTHER, pv_get_cseq_body, 0, 0, 0, 0, 0}, {{"ct", (sizeof("ct") - 1)}, /* */ PVT_OTHER, pv_get_contact, 0, 0, 0, 0, 0}, + {{"cts", (sizeof("cts") - 1)}, /* */ + PVT_OTHER, pv_get_contact_star, 0, 0, 0, 0, 0}, {{"ctu", (sizeof("ctu") - 1)}, /* */ PVT_OTHER, pv_get_contact_uri, 0, 0, 0, 0, 0}, {{"cT", (sizeof("cT") - 1)}, /* */ diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 8eed3c2e019..87345490af1 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -404,6 +404,29 @@ int pv_get_contact_uri(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) return pv_get_strval(msg, param, res, &cb->contacts->uri); } +int pv_get_contact_star(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) +{ + contact_body_t *cb = NULL; + + if(msg == NULL) + return -1; + + if(msg->contact == NULL && parse_headers(msg, HDR_CONTACT_F, 0) == -1) { + LM_DBG("no contact header\n"); + return pv_get_null(msg, param, res); + } + if(parse_contact_headers(msg) < 0) { + return pv_get_null(msg, param, res); + } + + cb = (contact_body_t *)msg->contact->parsed; + + if(cb->star == 1) { + return pv_get_uintval(msg, param, res, 1); + } + return pv_get_uintval(msg, param, res, 0); +} + int pv_get_xto_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res, struct to_body *xto, int type) { diff --git a/src/modules/pv/pv_core.h b/src/modules/pv/pv_core.h index 7d4681dab96..53951340db1 100644 --- a/src/modules/pv/pv_core.h +++ b/src/modules/pv/pv_core.h @@ -67,6 +67,9 @@ int pv_get_contact(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); int pv_get_contact_uri(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); +int pv_get_contact_star( + struct sip_msg *msg, pv_param_t *param, pv_value_t *res); + int pv_get_xto_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res, struct to_body *xto, int type);

7 months, 1 week

git:master:e738bd08: pv: added $ctu - return contact header uri

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e738bd08b14bfc765a8317267d738a8b1b574c64 URL: https://github.com/kamailio/kamailio/commit/e738bd08b14bfc765a8317267d738a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-05-16T21:24:24+02:00 pv: added $ctu - return contact header uri --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_core.c Modified: src/modules/pv/pv_core.h --- Diff: https://github.com/kamailio/kamailio/commit/e738bd08b14bfc765a8317267d738a8… Patch: https://github.com/kamailio/kamailio/commit/e738bd08b14bfc765a8317267d738a8… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index 5e9da2703e0..3226c773a2e 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -163,6 +163,8 @@ static pv_export_t mod_pvs[] = { PVT_OTHER, pv_get_cseq_body, 0, 0, 0, 0, 0}, {{"ct", (sizeof("ct") - 1)}, /* */ PVT_OTHER, pv_get_contact, 0, 0, 0, 0, 0}, + {{"ctu", (sizeof("ctu") - 1)}, /* */ + PVT_OTHER, pv_get_contact_uri, 0, 0, 0, 0, 0}, {{"cT", (sizeof("cT") - 1)}, /* */ PVT_OTHER, pv_get_content_type, 0, 0, 0, 0, 0}, {{"dd", (sizeof("dd") - 1)}, /* */ diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index b10b7513a6f..8eed3c2e019 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -381,6 +381,29 @@ int pv_get_contact(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) return pv_get_strval(msg, param, res, &msg->contact->body); } +int pv_get_contact_uri(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) +{ + contact_body_t *cb = NULL; + + if(msg == NULL) + return -1; + + if(msg->contact == NULL && parse_headers(msg, HDR_CONTACT_F, 0) == -1) { + LM_DBG("no contact header\n"); + return pv_get_null(msg, param, res); + } + if(parse_contact_headers(msg) < 0) { + return pv_get_null(msg, param, res); + } + + cb = (contact_body_t *)msg->contact->parsed; + if(cb->star == 1 || cb->contacts == NULL) { + return pv_get_null(msg, param, res); + } + + return pv_get_strval(msg, param, res, &cb->contacts->uri); +} + int pv_get_xto_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res, struct to_body *xto, int type) { diff --git a/src/modules/pv/pv_core.h b/src/modules/pv/pv_core.h index caaa12e54d1..7d4681dab96 100644 --- a/src/modules/pv/pv_core.h +++ b/src/modules/pv/pv_core.h @@ -65,6 +65,8 @@ int pv_get_errinfo_attr( int pv_get_contact(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); +int pv_get_contact_uri(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); + int pv_get_xto_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res, struct to_body *xto, int type);

7 months, 1 week

[kamailio/kamailio] usrloc: delete location_attrs in db_only mode on delete_urecord (PR #3827)

by Rick Barenthin

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  When calling delete_urecord in DB_ONLY mode the location_attrs are not deleted. This fix makes sure to delete location_attrs when calling db_delete_urecord is called. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3827 -- Commit Summary -- * usrloc: delete location_attrs in db_only mode on delete_urecord -- File Changes -- M src/modules/usrloc/ucontact.c (36) M src/modules/usrloc/urecord.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3827.patch https://github.com/kamailio/kamailio/pull/3827.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3827 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3827(a)github.com>

7 months, 1 week

← Newer
1
...
5
6
7
8
9
10
11
...
17
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2024