sr-dev May 2024

sr-dev@lists.kamailio.org

15 participants
163 discussions

git:5.8:c8e4fe87: dialplan: don't call free on empty pcre pointer

by Victor Seva

Module: kamailio Branch: 5.8 Commit: c8e4fe87985a413dfe6871463c31375750d3a6f2 URL: https://github.com/kamailio/kamailio/commit/c8e4fe87985a413dfe6871463c31375… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-05-30T15:42:01+02:00 dialplan: don't call free on empty pcre pointer fixes #3851 (cherry picked from commit 630a6f2c11c10c4f3be3570553d86486942d60fe) --- Modified: src/modules/dialplan/dp_repl.c --- Diff: https://github.com/kamailio/kamailio/commit/c8e4fe87985a413dfe6871463c31375… Patch: https://github.com/kamailio/kamailio/commit/c8e4fe87985a413dfe6871463c31375… --- diff --git a/src/modules/dialplan/dp_repl.c b/src/modules/dialplan/dp_repl.c index 42ba3b4abe6..51cab404710 100644 --- a/src/modules/dialplan/dp_repl.c +++ b/src/modules/dialplan/dp_repl.c @@ -648,7 +648,8 @@ int dp_translate_helper( LM_DBG("match check skipped: [%.*s] %d\n", re_list->expr.len, re_list->expr.s, rez); rt = re_list->next; - pcre2_match_data_free(pcre_md); + if(pcre_md) + pcre2_match_data_free(pcre_md); pcre2_code_free(re_list->re); pkg_free(re_list); re_list = rt;

3 months, 3 weeks

git:master:630a6f2c: dialplan: don't call free on empty pcre pointer

by Victor Seva

Module: kamailio Branch: master Commit: 630a6f2c11c10c4f3be3570553d86486942d60fe URL: https://github.com/kamailio/kamailio/commit/630a6f2c11c10c4f3be3570553d8648… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-05-30T14:59:05+02:00 dialplan: don't call free on empty pcre pointer fixes #3851 --- Modified: src/modules/dialplan/dp_repl.c --- Diff: https://github.com/kamailio/kamailio/commit/630a6f2c11c10c4f3be3570553d8648… Patch: https://github.com/kamailio/kamailio/commit/630a6f2c11c10c4f3be3570553d8648… --- diff --git a/src/modules/dialplan/dp_repl.c b/src/modules/dialplan/dp_repl.c index 42ba3b4abe6..51cab404710 100644 --- a/src/modules/dialplan/dp_repl.c +++ b/src/modules/dialplan/dp_repl.c @@ -648,7 +648,8 @@ int dp_translate_helper( LM_DBG("match check skipped: [%.*s] %d\n", re_list->expr.len, re_list->expr.s, rez); rt = re_list->next; - pcre2_match_data_free(pcre_md); + if(pcre_md) + pcre2_match_data_free(pcre_md); pcre2_code_free(re_list->re); pkg_free(re_list); re_list = rt;

3 months, 3 weeks

git:master:8363208f: siputils: free head of params list for get_uri_param()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 8363208fff7c101a2779ff64783e5b7dbf8ffd7c URL: https://github.com/kamailio/kamailio/commit/8363208fff7c101a2779ff64783e5b7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-05-29T10:18:44+02:00 siputils: free head of params list for get_uri_param() - GH #3857 --- Modified: src/modules/siputils/checks.c --- Diff: https://github.com/kamailio/kamailio/commit/8363208fff7c101a2779ff64783e5b7… Patch: https://github.com/kamailio/kamailio/commit/8363208fff7c101a2779ff64783e5b7… --- diff --git a/src/modules/siputils/checks.c b/src/modules/siputils/checks.c index 4e28aef8e8d..2822e24b7c8 100644 --- a/src/modules/siputils/checks.c +++ b/src/modules/siputils/checks.c @@ -1165,7 +1165,7 @@ int get_uri_param(struct sip_msg *_msg, char *_param, char *_value) pv_value_t val; param_hooks_t hooks; - param_t *list = NULL; + param_t *plist = NULL; param_t *params; param = (str *)_param; @@ -1178,12 +1178,12 @@ int get_uri_param(struct sip_msg *_msg, char *_param, char *_value) t = _msg->parsed_uri.params; - if(parse_params(&t, CLASS_ANY, &hooks, &list) < 0) { + if(parse_params(&t, CLASS_ANY, &hooks, &plist) < 0) { LM_ERR("ruri parameter parsing failed\n"); return -1; } - params = list; + params = plist; while(params) { if((params->name.len == param->len) && (strncmp(params->name.s, param->s, param->len) == 0)) { @@ -1198,11 +1198,11 @@ int get_uri_param(struct sip_msg *_msg, char *_param, char *_value) } } - free_params(list); + free_params(plist); return -1; found: - free_params(list); + free_params(plist); return 1; }

3 months, 3 weeks

git:master:d72a3fbc: siputils: free head of params list for get_uri_param()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d72a3fbc903da02ae3b26f3aae2ea228c9f8b255 URL: https://github.com/kamailio/kamailio/commit/d72a3fbc903da02ae3b26f3aae2ea22… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-05-29T10:15:21+02:00 siputils: free head of params list for get_uri_param() - GH #3857 --- Modified: src/modules/siputils/checks.c --- Diff: https://github.com/kamailio/kamailio/commit/d72a3fbc903da02ae3b26f3aae2ea22… Patch: https://github.com/kamailio/kamailio/commit/d72a3fbc903da02ae3b26f3aae2ea22… --- diff --git a/src/modules/siputils/checks.c b/src/modules/siputils/checks.c index 6cc977197fb..4e28aef8e8d 100644 --- a/src/modules/siputils/checks.c +++ b/src/modules/siputils/checks.c @@ -1165,6 +1165,7 @@ int get_uri_param(struct sip_msg *_msg, char *_param, char *_value) pv_value_t val; param_hooks_t hooks; + param_t *list = NULL; param_t *params; param = (str *)_param; @@ -1177,11 +1178,12 @@ int get_uri_param(struct sip_msg *_msg, char *_param, char *_value) t = _msg->parsed_uri.params; - if(parse_params(&t, CLASS_ANY, &hooks, &params) < 0) { + if(parse_params(&t, CLASS_ANY, &hooks, &list) < 0) { LM_ERR("ruri parameter parsing failed\n"); return -1; } + params = list; while(params) { if((params->name.len == param->len) && (strncmp(params->name.s, param->s, param->len) == 0)) { @@ -1196,11 +1198,11 @@ int get_uri_param(struct sip_msg *_msg, char *_param, char *_value) } } - free_params(params); + free_params(list); return -1; found: - free_params(params); + free_params(list); return 1; }

3 months, 3 weeks

[kamailio/kamailio] Problem loadmodule secsipid on kamailio 5.6.5 (Issue #3860)

by sondesbough

failed to find command secsipid_build_identity (params 6) parse error in config file /etc/kamailio/kamailio.cfg, line 799, column 125: unknown command, missing loadmodule? parser: failed to find command secsipid_add_identity (params 6) May 24 11:26:36 vps-3471ad99 kamailio: CRITICAL: [core/cfg.y:3539]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 802, column 125: unknown command, missing loadmodule?https://github.com/asipto/secsipidx/issues/12 May 24 11:26:36 vps-3471ad99 kamailio[70519]: ERROR: bad config file (2 errors) May 24 11:26:36 vps-3471ad99 kamailio: INFO: [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized May 24 11:26:36 vps-3471ad99 systemd[1]: kamailio.service: Control process exited, code=exited, status=255/EXCEPTION May 24 11:26:36 vps-3471ad99 systemd[1]: kamailio.service: Failed with result 'exit-code'. May 24 11:26:36 vps-3471ad99 systemd[1]: Failed to start Kamailio (OpenSER) - the Open Source SIP Server. May 24 11:26:36 vps-3471ad99 systemd[1]: kamailio.service: Scheduled restart job, restart counter is at 3. May 24 11:26:36 vps-3471ad99 systemd[1]: Stopped Kamailio (OpenSER) - the Open Source SIP Server. May 24 11:26:36 vps-3471ad99 systemd[1]: Starting Kamailio (OpenSER) - the Open Source SIP Server... May 24 11:26:36 vps-3471ad99 kamailio: ERROR: [core/cfg.y:3399]: yyparse(): cfg. parser: failed to find command secsipid_build_identity (params 6) May 24 11:26:36 vps-3471ad99 kamailio: CRITICAL: [core/cfg.y:3539]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 799, column 125: unknown command, missing loadmodule?https://github.com/asipto/secsipidx/issues/12 May 24 11:26:36 vps-3471ad99 kamailio: ERROR: [core/cfg.y:3399]: yyparse(): cfg. parser: failed to find command secsipid_add_identity (params 6) May 24 11:26:36 vps-3471ad99 kamailio[70521]: ERROR: bad config file (2 errors) May 24 11:26:36 vps-3471ad99 kamailio: CRITICAL: [core/cfg.y:3539]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 802, column 125: unknown command, missing loadmodule?https://github.com/asipto/secsipidx/issues/12 May 24 11:26:36 vps-3471ad99 kamailio: INFO: [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized May 24 11:26:36 vps-3471ad99 systemd[1]: kamailio.service: Control process exited, code=exited, status=255/EXCEPTION May 24 11:26:36 vps-3471ad99 systemd[1]: kamailio.service: Failed with result 'exit-code'. May 24 11:26:36 vps-3471ad99 systemd[1]: Failed to start Kamailio (OpenSER) - the Open Source SIP Server. May 24 11:26:37 vps-3471ad99 systemd[1]: kamailio.service: Scheduled restart job, restart counter is at 4. May 24 11:26:37 vps-3471ad99 systemd[1]: Stopped Kamailio (OpenSER) - the Open Source SIP Server. May 24 11:26:37 vps-3471ad99 systemd[1]: Starting Kamailio (OpenSER) - the Open Source SIP Server... May 24 11:26:37 vps-3471ad99 kamailio: ERROR: [core/cfg.y:3399]: yyparse(): cfg. parser: failed to find command secsipid_build_identity (params 6) May 24 11:26:37 vps-3471ad99 kamailio: CRITICAL: [core/cfg.y:3539]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 799, column 125: unknown command, missing loadmodule?https://github.com/asipto/secsipidx/issues/12 May 24 11:26:37 vps-3471ad99 kamailio[70522]: ERROR: bad config file (2 errors) May 24 11:26:37 vps-3471ad99 kamailio: ERROR: [core/cfg.y:3399]: yyparse(): cfg. parser: failed to find command secsipid_add_identity (params 6) May 24 11:26:37 vps-3471ad99 kamailio: CRITICAL: [core/cfg.y:3539]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 802, column 125: unknown command, missing loadmodule?https://github.com/asipto/secsipidx/issues/12 May 24 11:26:37 vps-3471ad99 kamailio: INFO: [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized May 24 11:26:37 vps-3471ad99 systemd[1]: kamailio.service: Control process exited, code=exited, status=255/EXCEPTION May 24 11:26:37 vps-3471ad99 systemd[1]: kamailio.service: Failed with result 'exit-code'. May 24 11:26:37 vps-3471ad99 systemd[1]: Failed to start Kamailio (OpenSER) - the Open Source SIP Server. May 24 11:26:37 vps-3471ad99 systemd[1]: kamailio.service: Scheduled restart job, restart counter is at 5. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3860 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3860(a)github.com>

3 months, 3 weeks

[kamailio/kamailio] dispatcher not proxy sip on websocket (Issue #3864)

by liaoxingang

I want to proxy a sip server on websocket. but it's not working. I set dispatcher destination "sip:10.100.67.95:5066;transport=ws", it has some error . logs: 2024-05-29T02:49:15.436088156Z 11(22) WARNING: <core> [core/msg_translator.c:3007]: via_builder(): TCP/TLS connection (id: 0) for WebSocket could not be found 2024-05-29T02:49:15.436124584Z 11(22) ERROR: tm [t_msgbuilder.c:1420]: assemble_via(): via building failed 2024-05-29T02:49:15.436132262Z 11(22) ERROR: tm [t_msgbuilder.c:1611]: build_uac_req(): error while assembling Via 2024-05-29T02:49:15.436138638Z 11(22) ERROR: tm [uac.c:552]: t_uac_prepare(): Error while building message 2024-05-29T02:49:15.436145000Z 11(22) ERROR: dispatcher [dispatch.c:3981]: ds_ping_set(): unable to ping [sip:10.100.67.95:5066;transport=ws] in group [3] -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3864 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3864(a)github.com>

3 months, 3 weeks

[kamailio/kamailio] rtpengine: Fix extra process in pkg.stats (PR #3862)

by Bastian Triller

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  When DTMF events socket is not configured, pkg.stats RPC method returns an empty entry. { entry: 13 pid: 0 rank: -128 used: 0 free: 0 real_used: 0 total_size: 67108864 total_frags: 0 desc: } Fixes: 26f6e57c8f ("Register a new worker process for dtmf event listener") You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3862 -- Commit Summary -- * rtpengine: Fix extra process in pkg.stats -- File Changes -- M src/modules/rtpengine/rtpengine.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3862.patch https://github.com/kamailio/kamailio/pull/3862.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3862 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3862(a)github.com>

3 months, 3 weeks

git:master:e67f6048: rtpengine: Fix extra process in pkg.stats

by Victor Seva

Module: kamailio Branch: master Commit: e67f6048f4883d446df2d88fe7a7d7f2ff6daf8c URL: https://github.com/kamailio/kamailio/commit/e67f6048f4883d446df2d88fe7a7d7f… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-05-28T19:55:35+02:00 rtpengine: Fix extra process in pkg.stats When DTMF events socket is not configured, pkg.stats RPC method returns an empty entry. { entry: 13 pid: 0 rank: -128 used: 0 free: 0 real_used: 0 total_size: 67108864 total_frags: 0 desc: } Fixes: 26f6e57c8f ("Register a new worker process for dtmf event listener") --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/e67f6048f4883d446df2d88fe7a7d7f… Patch: https://github.com/kamailio/kamailio/commit/e67f6048f4883d446df2d88fe7a7d7f… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 6d62b92900d..c26f61e2483 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -2234,8 +2234,10 @@ static int mod_init(void) } } - register_procs(1); - cfg_register_child(1); + if(rtpengine_dtmf_event_sock.len > 0) { + register_procs(1); + cfg_register_child(1); + } } return 0;

3 months, 3 weeks

git:master:24b27214: htable: error on not finding htable in pv get

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 24b27214231166366cceb88fcb3724298cc53b32 URL: https://github.com/kamailio/kamailio/commit/24b27214231166366cceb88fcb37242… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-05-28T11:45:37+02:00 htable: error on not finding htable in pv get --- Modified: src/modules/htable/ht_var.c --- Diff: https://github.com/kamailio/kamailio/commit/24b27214231166366cceb88fcb37242… Patch: https://github.com/kamailio/kamailio/commit/24b27214231166366cceb88fcb37242… --- diff --git a/src/modules/htable/ht_var.c b/src/modules/htable/ht_var.c index 9770e51fd19..e79c7869ee5 100644 --- a/src/modules/htable/ht_var.c +++ b/src/modules/htable/ht_var.c @@ -37,8 +37,11 @@ int pv_get_ht_cell(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) if(hpv->ht == NULL) { hpv->ht = ht_get_table(&hpv->htname); - if(hpv->ht == NULL) + if(hpv->ht == NULL) { + LM_ERR("htable not found for getting $sht(%.*s=>%.*s)\n", + hpv->htname.len, hpv->htname.s, htname.len, htname.s); return pv_get_null(msg, param, res); + } } if(pv_printf_s(msg, hpv->pve, &htname) != 0) { LM_ERR("cannot get $sht name\n");

3 months, 3 weeks

git:master:6a8eb982: modules: readme files regenerated - permissions ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 6a8eb982be8d8f0c731dd423827480a1a27c2d8f URL: https://github.com/kamailio/kamailio/commit/6a8eb982be8d8f0c731dd423827480a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-05-27T15:31:11+02:00 modules: readme files regenerated - permissions ... [skip ci] --- Modified: src/modules/permissions/README --- Diff: https://github.com/kamailio/kamailio/commit/6a8eb982be8d8f0c731dd423827480a… Patch: https://github.com/kamailio/kamailio/commit/6a8eb982be8d8f0c731dd423827480a…

3 months, 3 weeks

← Newer
1
2
3
4
5
6
7
8
9
...
17
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2024