### Description
partition is now a reserved word in MariaDB 10.
the column name is correctly quoted with native libmysqlclient/libmariadb so works
the column name is not quoted with unixodbc+(libmyodbc8|libmaodbc) and so fails
### Troubleshooting
try unquoted insert
-- fails unixodbc+libmaodbc
insert into location (partition) values (1000);
-- works native libmysqlclient|libmariadb
insert into location (`partition`) values (1000);
#### Reproduction
1. config enable usrloc / registrar with unixodbc + MySQL/MariaDB connector
#### Debugging Data
SQL insert into statement fails
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3742
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3742(a)github.com>
Hello,
the formal notification that the development for the next major version
5.8.0 is now frozen. The focus has to be on testing the master branch.
Also, the master branch should not get commits with new features till
the branch 5.8 is created, expected to happen in 2-4 weeks, a matter of
how testing goes on. Meanwhile, the commits with new features in the C
code can be pushed to personal branches, new pull requests can still be
done, but they will be merged after branching 5.8.
Can still be done commits with documentation improvements, enhancements
to related tools (e.g., kamctl, kamcmd), merging exiting pull requests
at this moment, exporting missing KEMI functions and completing the
functionality of the new modules added for 5.8.
Once the branch 5.8 is created, new features can be pushed again to
master branch as usual. From that moment, the v5.8.0 should be out very
soon, time used for further testing but also preparing the release of
packages.
If someone is not sure if a commit brings a new feature, just make a
pull request and it can be discussed there on github portal or via
sr-dev mailing list.
A summary of what is new in upcoming 5.8 is going to be built at:
* https://www.kamailio.org/wikidocs/features/new-in-5.8.x/
Upgrade guidelines will be collected at:
* https://www.kamailio.org/wikidocs/install/upgrade/5.7.x-to-5.8.0/
Everyone is more than welcome to contribute to the above wiki pages,
especially to the upgrade guidelines, to help everyone else during the
migration process from v5.7.x to 5.8.x.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
Kamailio Advanced Training, February 20-22, 2024 -- asipto.com
Kamailio World Conference, April 18-19, 2024, Berlin -- kamailioworld.com
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR fixes an issue regarding KEMI framework for onsend_route.
KSR.set_drop() in [ksr_onsend_route](https://www.kamailio.org/wikidocs/cookbooks/5.7.x/core/#o… does not make kamailio dropping the message when using kemi (python3) (probably holds true for other engines too):
This is exactly the example from [documentation](https://kamailio.org/docs/tutorials/devel/kamailio-kemi-fram…:
```
def ksr_onsend_route(self, msg):
KSR.set_drop()
exit()
```
The issue arises because we are not setting `ret = 0` when the drop flag is set, but instead check if it's not set to return `ret=1` (The case for native that returns `0` but no `DROP_R_F` was set).
**Note**:
KEMI Case: `ret = 1` always See [app_python3/apy_kemi.c](https://github.com/kamailio/kamailio/blob/79697b4d5…
Native case: `ret` can be `0` for drop, or `1` for success
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3718
-- Commit Summary --
* core: Fix check to also work for KEMI framework
-- File Changes --
M src/core/onsend.c (13)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3718.patchhttps://github.com/kamailio/kamailio/pull/3718.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3718
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3718(a)github.com>