[kamailio/kamailio] callout from event_route [tm:local-response] only occurs once (Issue #3064)
version: kamailio 5.5.2 (arm6/linux) 55e232 raspberry pi 3b I initially stated that I was running on 5.5.3 but I was mistaken. However I checked the 5.5.3 source and it appears to be the same. I think that there is a bug in the tm module with respect to the "tm:local-response" event route. In the "t_reply.c" file, there is a static variable called '_tm_local_response_set_lookup'. This variable is initialized at load time to zero. It is checked in the '_reply_light()' routine and will initiate a local callback from the config script if "armed". The problem as I see it is that if the callback is readied, the variable is set to one. But it is never reset. So the observed behavior is as follows. A REGISTER is received and the request_route arms the callback. The REGISTER requires an authorization (local database sqlite). After the 401 is sent back, the callback via the event route is called as expected. All good except that the event route script fragment is never executed again after the first call... ever, even if it's a new REGISTER request. I would think that somewhere in the tm module, the variable should be reset to zero so that subsequent transactions can initiate the event route again. Or maybe the variable ought to live somewhere in the transaction cell??? . . . t_on_reply ("MY_FRAG"); t_on_failure ("MY_FRAG"); . . . event_route [tm:local-response] { xlog ("L_NOTICE", IN tm:local-response\n"); my_function(); } . . . So 'my_function()' is only called once. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3064 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3064@github.com>
This appears to be occurring in 5.6, 5.7, and devel- branch as well. Simple example config: ``` #!KAMAILIO loadmodule "pv" loadmodule "tm" loadmodule "xlog" route { xinfo("[$rm $ci-$cs] Src:[$si:$sp] RURI:[$ru] To:[$tu] From:[$fu]\n"); t_send_reply("404", "Not Found"); exit; } event_route[tm:local-response] { xcrit("[$rm $ci-$cs] tm:local-response replied locally\n"); } ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3064#issuecomment-1629203660 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3064/1629203660@github.com>
This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3064#issuecomment-1801301384 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3064/1801301384@github.com>
Will have a look if it can be still reproduced. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3064#issuecomment-1820375528 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3064/1820375528@github.com>
Hey @dpaape and @whosgonna, A PR has opened to fix this. Can you help and verify whether this solved the problem? Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3064#issuecomment-1867679030 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3064/1867679030@github.com>
I'll try to get around to this. It was pretty simple to test if memory serves. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3064#issuecomment-1867686329 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3064/1867686329@github.com>
I pushed an alternative commit to master branch, to avoid event route lookup every time on replies (more comments in PR #3687). Should master fail to work, it has to be investigated further. If ok, commit will be backported. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3064#issuecomment-1867724465 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3064/1867724465@github.com>
This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3064#issuecomment-1925028025 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3064/1925028025@github.com>
Closed #3064 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3064#event-11692088574 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issue/3064/issue_event/11692088574@github.com>
There was a PR proposed and an alternative implementation added. So this should be fixed, close. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3064#issuecomment-1925217505 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3064/1925217505@github.com>
participants (6)
-
Ben Kaufman -
Daniel-Constantin Mierla
-
dpaape
-
github-actions[bot]
-
Henning Westerholt
-
Xenofon Karamanos