#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [ ] Tested changes locally
- [x] Related to issue https://lists.kamailio.org/mailman3/hyperkitty/list/sr-users@lists.kamailio…
#### Description
``current_msg_id_repl is only`` changed if ``$diameter_reponse`` is changed by via ``pv_set_response()``. The event_route is executed with a ``fake_msg`` so it will not match if is setted outside anyways.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4069
-- Commit Summary --
* ims_diameter_server: fix retrieval ``$diameter_response`` value
-- File Changes --
M src/modules/ims_diameter_server/avp_helper.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4069.patchhttps://github.com/kamailio/kamailio/pull/4069.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4069
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4069(a)github.com>
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
The function isc_match_filter uses a local variable "firstflag",
to handle the case of an HSS based terminating unregistered service.
In that case, the S-CSCF exchanges SAR/SAA with the HSS in order
to learn the subscription data and the iFC for an unregistered
user or for a PSI.
The firstflag is necessary to make a distiction between the
FAILURE ROUTE that is used for this case and the FAILURE ROUTE
that is used for transaction failure towards the AS.
The error is, the firstflag is set for the latter case, too,
which leads to a wrong handling of communication errors towards
the AS.
This PR introduces a new function that looks for the old
ISCMARK in the lumps of the stored message and hence can make a
distinction between the SAR/SAA case and the AS failure case.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4018
-- Commit Summary --
* ims_isc: bugfix: firstflag incorrect in isc_match_filter
-- File Changes --
M src/modules/ims_isc/ims_isc_mod.c (24)
M src/modules/ims_isc/mark.c (51)
M src/modules/ims_isc/mark.h (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4018.patchhttps://github.com/kamailio/kamailio/pull/4018.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4018
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4018(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Looks like htable module already exports API functions, but currently no other module uses them.
Added 2 more API functions for table creation (so other modules can be able to create their own hash tables if they want to)
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4010
-- Commit Summary --
* htable: export table create api functions
-- File Changes --
M src/modules/htable/api.c (10)
M src/modules/htable/api.h (4)
M src/modules/htable/ht_api.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4010.patchhttps://github.com/kamailio/kamailio/pull/4010.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4010
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4010(a)github.com>