sr-dev December 2024

sr-dev@lists.kamailio.org

17 participants
347 discussions

Re: [kamailio/kamailio] cmake: modules - set the SUFFIX property to .so (4bf2c96)
by Xenofon Karamanos 19 Dec '24

19 Dec '24

What you mean by included? Right now we have, two way to modify directly modules properties. 1. `cmake/defs.cmake` : there is a target called `common_modules` that is an INTERFACE. We can use this for whatever compiler options, definitions and more. and target propagates all these to each module. This is best to use when there is no usage of the `module_name` since we don't know it yet. 2. `src/modules/CMakeLists.txt`: Add options to each module as well but with extra ability when we need to specify also the `module_name` in the option. Do you have something else in mind with the template inclusion? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/4bf2c9634ab19ac76c12c33ddc3d422… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/4bf2c9634ab19ac76c12c33ddc3d4220631d38ef/150535472(a)github.com>

1 0

Re: [kamailio/kamailio] cmake: set runtime dir based on RUN_PREFIX and RUN_DIR (1860420)
by Xenofon Karamanos 19 Dec '24

19 Dec '24

Regarding this, we had some discussion with @linuxmaniac about the paths in general. CMake offers https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html that has the standard definitions for the usual paths. Therefore I am not really sure if we need to introduce new variables like `prefix` and `run_dir`. User can supply the `LOCALSTATEDIR` or `RUNSTATEDIR` via `-Dvar='path'` and then figure the best way to provide that to kamailio. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/1860420fea7ed57d25bc7d735b46c11… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/1860420fea7ed57d25bc7d735b46c11c739aa0c4/150534991(a)github.com>

1 0

Re: [kamailio/kamailio] cmake: modules - set the SUFFIX property to .so (4bf2c96)
by Daniel-Constantin Mierla 19 Dec '24

19 Dec '24

@xkaraman: you can replace the files for modules as you consider better. I said in another comment that making a common template for modules to be included would be likely good, but I was not sure if it is going to slow down, or if that is the best option, and not recalling any further decisions on this, I pushed with a script that I have for such repetitive updates for CMakeLists.txt in module folders. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/4bf2c9634ab19ac76c12c33ddc3d422… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/4bf2c9634ab19ac76c12c33ddc3d4220631d38ef/150534486(a)github.com>

1 0

git:master:1860420f: cmake: set runtime dir based on RUN_PREFIX and RUN_DIR
by Daniel-Constantin Mierla 19 Dec '24

19 Dec '24

Module: kamailio Branch: master Commit: 1860420fea7ed57d25bc7d735b46c11c739aa0c4 URL: https://github.com/kamailio/kamailio/commit/1860420fea7ed57d25bc7d735b46c11… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-19T16:34:53+01:00 cmake: set runtime dir based on RUN_PREFIX and RUN_DIR - it is a different system path than installation prefix, usually is either in /run/kamailio or /var/run/kamailio - follows the same concept as the old-makefiles --- Modified: cmake/defs.cmake Modified: cmake/os-specific/darwin.cmake --- Diff: https://github.com/kamailio/kamailio/commit/1860420fea7ed57d25bc7d735b46c11… Patch: https://github.com/kamailio/kamailio/commit/1860420fea7ed57d25bc7d735b46c11… --- diff --git a/cmake/defs.cmake b/cmake/defs.cmake index 0509cad4fca..bc08b2ce4ac 100644 --- a/cmake/defs.cmake +++ b/cmake/defs.cmake @@ -14,9 +14,9 @@ message(STATUS "OS version: ${OSREL}") # set(HOST_ARCH "__CPU_${CMAKE_HOST_SYSTEM_PROCESSOR}") if(CMAKE_SYSTEM_PROCESSOR MATCHES "i386|i486|i586|i686") - set(TARGET_ARCH "i386") + set(TARGET_ARCH "i386") else() - set(TARGET_ARCH "${CMAKE_SYSTEM_PROCESSOR}") + set(TARGET_ARCH "${CMAKE_SYSTEM_PROCESSOR}") endif() message(STATUS "Host Processor: ${CMAKE_HOST_SYSTEM_PROCESSOR}") @@ -305,7 +305,9 @@ if(CMAKE_C_COMPILER_ID STREQUAL "GNU") elseif(CMAKE_C_COMPILER_ID STREQUAL "Clang") set(COMPILER_NAME "clang") endif() - +if(NOT DEFINED RUN_DIR) + set(RUN_DIR "run/${MAIN_NAME}") +endif() string(TOLOWER ${OS} OS_LOWER) target_compile_definitions( common @@ -324,7 +326,7 @@ target_compile_definitions( SHARE_DIR="${CMAKE_INSTALL_FULL_DATADIR}/${MAIN_NAME}/" # Absolute path this run is always /var/run/kamailio either for local or # system installs - RUN_DIR="${CMAKE_INSTALL_FULL_LOCALSTATEDIR}/run/${MAIN_NAME}" + RUN_DIR="${RUN_PREFIX}/${RUN_DIR}" ${LOCK_METHOD} # Module stuff? PIC diff --git a/cmake/os-specific/darwin.cmake b/cmake/os-specific/darwin.cmake index 5af299c2681..b9963a77ef0 100644 --- a/cmake/os-specific/darwin.cmake +++ b/cmake/os-specific/darwin.cmake @@ -40,3 +40,7 @@ endif() if(NOT DEFINED ${NO_KQUEUE}) target_compile_definitions(common INTERFACE HAVE_KQUEUE) endif() + +if(NOT DEFINED RUN_PREFIX) + set(RUN_PREFIX "/var") +endif()

1 0

Re: [kamailio/kamailio] cmake: modules - set the SUFFIX property to .so (4bf2c96)
by Xenofon Karamanos 19 Dec '24

19 Dec '24

@miconda Mind if i revert this and the one with `-ffile-prefix` commits, so that we adjust this in `modules/CMakelists.txt` or `common_modules INTERFACE` since it's common for all modules? It will be cleaner I believe and have a more central way to change it for all of them? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/4bf2c9634ab19ac76c12c33ddc3d422… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/4bf2c9634ab19ac76c12c33ddc3d4220631d38ef/150533398(a)github.com>

1 0

git:master:7c1cfb31: cmake/groups.cmake: added topos_htable to basic group
by Daniel-Constantin Mierla 19 Dec '24

19 Dec '24

Module: kamailio Branch: master Commit: 7c1cfb312260ddd42d48231fc9c8049b4c38fe8f URL: https://github.com/kamailio/kamailio/commit/7c1cfb312260ddd42d48231fc9c8049… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-19T13:22:22+01:00 cmake/groups.cmake: added topos_htable to basic group --- Modified: cmake/groups.cmake --- Diff: https://github.com/kamailio/kamailio/commit/7c1cfb312260ddd42d48231fc9c8049… Patch: https://github.com/kamailio/kamailio/commit/7c1cfb312260ddd42d48231fc9c8049… --- diff --git a/cmake/groups.cmake b/cmake/groups.cmake index d955581f66a..a2ca9ab48c2 100644 --- a/cmake/groups.cmake +++ b/cmake/groups.cmake @@ -57,6 +57,7 @@ set(MOD_LIST_BASIC cfgt statsc topos + topos_htable sipdump pv_headers kemix

1 0

git:master:4bf2c963: cmake: modules - set the SUFFIX property to .so
by Daniel-Constantin Mierla 19 Dec '24

19 Dec '24

Module: kamailio Branch: master Commit: 4bf2c9634ab19ac76c12c33ddc3d4220631d38ef URL: https://github.com/kamailio/kamailio/commit/4bf2c9634ab19ac76c12c33ddc3d422… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-19T13:15:42+01:00 cmake: modules - set the SUFFIX property to .so - on some OSes, the extension for dynamic libs is different, but the code expects .so for modules (old-makefiles output was always with .so no matter the OS) --- Modified: src/modules/acc/CMakeLists.txt Modified: src/modules/acc_diameter/CMakeLists.txt Modified: src/modules/acc_json/CMakeLists.txt Modified: src/modules/acc_radius/CMakeLists.txt Modified: src/modules/alias_db/CMakeLists.txt Modified: src/modules/app_java/CMakeLists.txt Modified: src/modules/app_jsdt/CMakeLists.txt Modified: src/modules/app_lua/CMakeLists.txt Modified: src/modules/app_perl/CMakeLists.txt Modified: src/modules/app_python/CMakeLists.txt Modified: src/modules/app_python3/CMakeLists.txt Modified: src/modules/app_python3s/CMakeLists.txt Modified: src/modules/app_ruby/CMakeLists.txt Modified: src/modules/app_ruby_proc/CMakeLists.txt Modified: src/modules/async/CMakeLists.txt Modified: src/modules/auth/CMakeLists.txt Modified: src/modules/auth_db/CMakeLists.txt Modified: src/modules/auth_diameter/CMakeLists.txt Modified: src/modules/auth_ephemeral/CMakeLists.txt Modified: src/modules/auth_radius/CMakeLists.txt Modified: src/modules/auth_xkeys/CMakeLists.txt Modified: src/modules/avp/CMakeLists.txt Modified: src/modules/avpops/CMakeLists.txt Modified: src/modules/benchmark/CMakeLists.txt Modified: src/modules/blst/CMakeLists.txt Modified: src/modules/call_control/CMakeLists.txt Modified: src/modules/call_obj/CMakeLists.txt Modified: src/modules/carrierroute/CMakeLists.txt Modified: src/modules/cdp/CMakeLists.txt Modified: src/modules/cdp_avp/CMakeLists.txt Modified: src/modules/cfg_db/CMakeLists.txt Modified: src/modules/cfg_rpc/CMakeLists.txt Modified: src/modules/cfgt/CMakeLists.txt Modified: src/modules/cfgutils/CMakeLists.txt Modified: src/modules/cnxcc/CMakeLists.txt Modified: src/modules/corex/CMakeLists.txt Modified: src/modules/counters/CMakeLists.txt Modified: src/modules/cplc/CMakeLists.txt Modified: src/modules/crypto/CMakeLists.txt Modified: src/modules/ctl/CMakeLists.txt Modified: src/modules/db2_ldap/CMakeLists.txt Modified: src/modules/db2_ops/CMakeLists.txt Modified: src/modules/db_berkeley/CMakeLists.txt Modified: src/modules/db_cluster/CMakeLists.txt Modified: src/modules/db_flatstore/CMakeLists.txt Modified: src/modules/db_mongodb/CMakeLists.txt Modified: src/modules/db_mysql/CMakeLists.txt Modified: src/modules/db_oracle/CMakeLists.txt Modified: src/modules/db_perlvdb/CMakeLists.txt Modified: src/modules/db_postgres/CMakeLists.txt Modified: src/modules/db_redis/CMakeLists.txt Modified: src/modules/db_sqlite/CMakeLists.txt Modified: src/modules/db_text/CMakeLists.txt Modified: src/modules/db_unixodbc/CMakeLists.txt Modified: src/modules/debugger/CMakeLists.txt Modified: src/modules/dialog/CMakeLists.txt Modified: src/modules/dialplan/CMakeLists.txt Modified: src/modules/dispatcher/CMakeLists.txt Modified: src/modules/diversion/CMakeLists.txt Modified: src/modules/dlgs/CMakeLists.txt Modified: src/modules/dmq/CMakeLists.txt Modified: src/modules/dmq_usrloc/CMakeLists.txt Modified: src/modules/dnssec/CMakeLists.txt Modified: src/modules/domain/CMakeLists.txt Modified: src/modules/domainpolicy/CMakeLists.txt Modified: src/modules/drouting/CMakeLists.txt Modified: src/modules/enum/CMakeLists.txt Modified: src/modules/erlang/CMakeLists.txt Modified: src/modules/evapi/CMakeLists.txt Modified: src/modules/evrexec/CMakeLists.txt Modified: src/modules/exec/CMakeLists.txt Modified: src/modules/file_out/CMakeLists.txt Modified: src/modules/gcrypt/CMakeLists.txt Modified: src/modules/geoip/CMakeLists.txt Modified: src/modules/geoip2/CMakeLists.txt Modified: src/modules/group/CMakeLists.txt Modified: src/modules/gzcompress/CMakeLists.txt Modified: src/modules/h350/CMakeLists.txt Modified: src/modules/htable/CMakeLists.txt Modified: src/modules/http_async_client/CMakeLists.txt Modified: src/modules/http_client/CMakeLists.txt Modified: src/modules/imc/CMakeLists.txt Modified: src/modules/ims_auth/CMakeLists.txt Modified: src/modules/ims_charging/CMakeLists.txt Modified: src/modules/ims_dialog/CMakeLists.txt Modified: src/modules/ims_diameter_server/CMakeLists.txt Modified: src/modules/ims_icscf/CMakeLists.txt Modified: src/modules/ims_ipsec_pcscf/CMakeLists.txt Modified: src/modules/ims_isc/CMakeLists.txt Modified: src/modules/ims_ocs/CMakeLists.txt Modified: src/modules/ims_qos/CMakeLists.txt Modified: src/modules/ims_qos_npn/CMakeLists.txt Modified: src/modules/ims_registrar_pcscf/CMakeLists.txt Modified: src/modules/ims_registrar_scscf/CMakeLists.txt Modified: src/modules/ims_usrloc_pcscf/CMakeLists.txt Modified: src/modules/ims_usrloc_scscf/CMakeLists.txt Modified: src/modules/influxdbc/CMakeLists.txt Modified: src/modules/ipops/CMakeLists.txt Modified: src/modules/jansson/CMakeLists.txt Modified: src/modules/janssonrpcc/CMakeLists.txt Modified: src/modules/json/CMakeLists.txt Modified: src/modules/jsonrpcc/CMakeLists.txt Modified: src/modules/jsonrpcs/CMakeLists.txt Modified: src/modules/jwt/CMakeLists.txt Modified: src/modules/kafka/CMakeLists.txt Modified: src/modules/kazoo/CMakeLists.txt Modified: src/modules/keepalive/CMakeLists.txt Modified: src/modules/kemix/CMakeLists.txt Modified: src/modules/kex/CMakeLists.txt Modified: src/modules/lcr/CMakeLists.txt Modified: src/modules/ldap/CMakeLists.txt Modified: src/modules/log_custom/CMakeLists.txt Modified: src/modules/log_systemd/CMakeLists.txt Modified: src/modules/lost/CMakeLists.txt Modified: src/modules/lrkproxy/CMakeLists.txt Modified: src/modules/lwsc/CMakeLists.txt Modified: src/modules/mangler/CMakeLists.txt Modified: src/modules/math/CMakeLists.txt Modified: src/modules/matrix/CMakeLists.txt Modified: src/modules/maxfwd/CMakeLists.txt Modified: src/modules/mediaproxy/CMakeLists.txt Modified: src/modules/memcached/CMakeLists.txt Modified: src/modules/microhttpd/CMakeLists.txt Modified: src/modules/misc_radius/CMakeLists.txt Modified: src/modules/misctest/CMakeLists.txt Modified: src/modules/mohqueue/CMakeLists.txt Modified: src/modules/mqtt/CMakeLists.txt Modified: src/modules/mqueue/CMakeLists.txt Modified: src/modules/msilo/CMakeLists.txt Modified: src/modules/msrp/CMakeLists.txt Modified: src/modules/mtree/CMakeLists.txt Modified: src/modules/nat_traversal/CMakeLists.txt Modified: src/modules/nathelper/CMakeLists.txt Modified: src/modules/nats/CMakeLists.txt Modified: src/modules/ndb_cassandra/CMakeLists.txt Modified: src/modules/ndb_mongodb/CMakeLists.txt Modified: src/modules/ndb_redis/CMakeLists.txt Modified: src/modules/nghttp2/CMakeLists.txt Modified: src/modules/nosip/CMakeLists.txt Modified: src/modules/nsq/CMakeLists.txt Modified: src/modules/outbound/CMakeLists.txt Modified: src/modules/p_usrloc/CMakeLists.txt Modified: src/modules/path/CMakeLists.txt Modified: src/modules/pdb/CMakeLists.txt Modified: src/modules/pdt/CMakeLists.txt Modified: src/modules/peering/CMakeLists.txt Modified: src/modules/permissions/CMakeLists.txt Modified: src/modules/phonenum/CMakeLists.txt Modified: src/modules/pike/CMakeLists.txt Modified: src/modules/pipelimit/CMakeLists.txt Modified: src/modules/posops/CMakeLists.txt Modified: src/modules/prefix_route/CMakeLists.txt Modified: src/modules/presence/CMakeLists.txt Modified: src/modules/presence_conference/CMakeLists.txt Modified: src/modules/presence_dfks/CMakeLists.txt Modified: src/modules/presence_dialoginfo/CMakeLists.txt Modified: src/modules/presence_mwi/CMakeLists.txt Modified: src/modules/presence_profile/CMakeLists.txt Modified: src/modules/presence_reginfo/CMakeLists.txt Modified: src/modules/presence_xml/CMakeLists.txt Modified: src/modules/pua/CMakeLists.txt Modified: src/modules/pua_bla/CMakeLists.txt Modified: src/modules/pua_dialoginfo/CMakeLists.txt Modified: src/modules/pua_json/CMakeLists.txt Modified: src/modules/pua_reginfo/CMakeLists.txt Modified: src/modules/pua_rpc/CMakeLists.txt Modified: src/modules/pua_usrloc/CMakeLists.txt Modified: src/modules/pua_xmpp/CMakeLists.txt Modified: src/modules/pv/CMakeLists.txt Modified: src/modules/pv_headers/CMakeLists.txt Modified: src/modules/pvtpl/CMakeLists.txt Modified: src/modules/qos/CMakeLists.txt Modified: src/modules/rabbitmq/CMakeLists.txt Modified: src/modules/ratelimit/CMakeLists.txt Modified: src/modules/regex/CMakeLists.txt Modified: src/modules/registrar/CMakeLists.txt Modified: src/modules/rls/CMakeLists.txt Modified: src/modules/rr/CMakeLists.txt Modified: src/modules/rtimer/CMakeLists.txt Modified: src/modules/rtjson/CMakeLists.txt Modified: src/modules/rtp_media_server/CMakeLists.txt Modified: src/modules/rtpengine/CMakeLists.txt Modified: src/modules/rtpproxy/CMakeLists.txt Modified: src/modules/ruxc/CMakeLists.txt Modified: src/modules/sanity/CMakeLists.txt Modified: src/modules/sca/CMakeLists.txt Modified: src/modules/sctp/CMakeLists.txt Modified: src/modules/sdpops/CMakeLists.txt Modified: src/modules/seas/CMakeLists.txt Modified: src/modules/secfilter/CMakeLists.txt Modified: src/modules/secsipid/CMakeLists.txt Modified: src/modules/secsipid_proc/CMakeLists.txt Modified: src/modules/sipcapture/CMakeLists.txt Modified: src/modules/sipdump/CMakeLists.txt Modified: src/modules/sipjson/CMakeLists.txt Modified: src/modules/siprepo/CMakeLists.txt Modified: src/modules/sipt/CMakeLists.txt Modified: src/modules/siptrace/CMakeLists.txt Modified: src/modules/siputils/CMakeLists.txt Modified: src/modules/sl/CMakeLists.txt Modified: src/modules/slack/CMakeLists.txt Modified: src/modules/sms/CMakeLists.txt Modified: src/modules/smsops/CMakeLists.txt Modified: src/modules/snmpstats/CMakeLists.txt Modified: src/modules/speeddial/CMakeLists.txt Modified: src/modules/sqlops/CMakeLists.txt Modified: src/modules/ss7ops/CMakeLists.txt Modified: src/modules/sst/CMakeLists.txt Modified: src/modules/statistics/CMakeLists.txt Modified: src/modules/statsc/CMakeLists.txt Modified: src/modules/statsd/CMakeLists.txt Modified: src/modules/stirshaken/CMakeLists.txt Modified: src/modules/stun/CMakeLists.txt Modified: src/modules/sworker/CMakeLists.txt Modified: src/modules/systemdops/CMakeLists.txt Modified: src/modules/tcpops/CMakeLists.txt Modified: src/modules/textops/CMakeLists.txt Modified: src/modules/textopsx/CMakeLists.txt Modified: src/modules/timer/CMakeLists.txt Modified: src/modules/tls/CMakeLists.txt Modified: src/modules/tls_wolfssl/CMakeLists.txt Modified: src/modules/tlsa/CMakeLists.txt Modified: src/modules/tm/CMakeLists.txt Modified: src/modules/tmrec/CMakeLists.txt Modified: src/modules/tmx/CMakeLists.txt Modified: src/modules/topoh/CMakeLists.txt Modified: src/modules/topos/CMakeLists.txt Modified: src/modules/topos_redis/CMakeLists.txt Modified: src/modules/tsilo/CMakeLists.txt Modified: src/modules/uac/CMakeLists.txt Modified: src/modules/uac_redirect/CMakeLists.txt Modified: src/modules/uid_auth_db/CMakeLists.txt Modified: src/modules/uid_avp_db/CMakeLists.txt Modified: src/modules/uid_domain/CMakeLists.txt Modified: src/modules/uid_gflags/CMakeLists.txt Modified: src/modules/uid_uri_db/CMakeLists.txt Modified: src/modules/uri_db/CMakeLists.txt Modified: src/modules/userblocklist/CMakeLists.txt Modified: src/modules/usrloc/CMakeLists.txt Modified: src/modules/utils/CMakeLists.txt Modified: src/modules/uuid/CMakeLists.txt Modified: src/modules/websocket/CMakeLists.txt Modified: src/modules/xcap_client/CMakeLists.txt Modified: src/modules/xcap_server/CMakeLists.txt Modified: src/modules/xhttp/CMakeLists.txt Modified: src/modules/xhttp_pi/CMakeLists.txt Modified: src/modules/xhttp_prom/CMakeLists.txt Modified: src/modules/xhttp_rpc/CMakeLists.txt Modified: src/modules/xlog/CMakeLists.txt Modified: src/modules/xmlops/CMakeLists.txt Modified: src/modules/xmlrpc/CMakeLists.txt Modified: src/modules/xmpp/CMakeLists.txt Modified: src/modules/xprint/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/4bf2c9634ab19ac76c12c33ddc3d422… Patch: https://github.com/kamailio/kamailio/commit/4bf2c9634ab19ac76c12c33ddc3d422…

1 0

git:master:302782df: topos_htable: added CMakeLists.txt
by Daniel-Constantin Mierla 19 Dec '24

19 Dec '24

Module: kamailio Branch: master Commit: 302782dff65469630ced250d65aaa52d0f9dc7fa URL: https://github.com/kamailio/kamailio/commit/302782dff65469630ced250d65aaa52… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-19T13:13:39+01:00 topos_htable: added CMakeLists.txt --- Added: src/modules/topos_htable/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/302782dff65469630ced250d65aaa52… Patch: https://github.com/kamailio/kamailio/commit/302782dff65469630ced250d65aaa52… --- diff --git a/src/modules/topos_htable/CMakeLists.txt b/src/modules/topos_htable/CMakeLists.txt new file mode 100644 index 00000000000..75727aabb2d --- /dev/null +++ b/src/modules/topos_htable/CMakeLists.txt @@ -0,0 +1,8 @@ +file(GLOB topos_htable_SRC "*.c") + +add_library(topos_htable SHARED ${topos_htable_SRC}) + +target_compile_options( + topos_htable + PUBLIC "-ffile-prefix-map=${CMAKE_SOURCE_DIR}/src/modules/topos_htable/=") +set_target_properties(topos_htable PROPERTIES SUFFIX ".so")

1 0

git:master:f0095466: core: info log when no r-uri or branches found for print_dset()
by Daniel-Constantin Mierla 19 Dec '24

19 Dec '24

Module: kamailio Branch: master Commit: f0095466c2847c996440c45a8f728adc16f09579 URL: https://github.com/kamailio/kamailio/commit/f0095466c2847c996440c45a8f728ad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-19T09:24:41+01:00 core: info log when no r-uri or branches found for print_dset() --- Modified: src/core/dset.c --- Diff: https://github.com/kamailio/kamailio/commit/f0095466c2847c996440c45a8f728ad… Patch: https://github.com/kamailio/kamailio/commit/f0095466c2847c996440c45a8f728ad… --- diff --git a/src/core/dset.c b/src/core/dset.c index 88b477cdff1..e30277eb7ea 100644 --- a/src/core/dset.c +++ b/src/core/dset.c @@ -739,8 +739,8 @@ char *print_dset(struct sip_msg *msg, int *len, int options) } if(cnt == 0) { - LM_WARN("no r-uri or branches\n"); - goto error; + LM_INFO("no new r-uri or branches\n"); + goto notfound; } if(p + CRLF_LEN + 1 > end) { @@ -753,7 +753,7 @@ char *print_dset(struct sip_msg *msg, int *len, int options) memfail: LM_ERR("redirection buffer length exceed\n"); -error: +notfound: *len = 0; set_branch_iterator(crt_branch); return 0;

1 0

[kamailio/kamailio] pre-commit: cmake-format and cmake-lint hooks [skip ci] (PR #4066)
by Victor Seva 18 Dec '24

18 Dec '24

@xkaraman I hope you will agree to add this jobs related to cmake files to keep things tidy. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4066 -- Commit Summary -- * pre-commit: cmake-format and cmake-lint hooks [skip ci] -- File Changes -- M .pre-commit-config.yaml (7) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4066.patch https://github.com/kamailio/kamailio/pull/4066.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4066 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4066(a)github.com>

3 8

← Newer
1
...
7
8
9
10
11
12
13
...
35
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2024