sr-dev August 2023

sr-dev@lists.kamailio.org

15 participants
208 discussions

Question for not_empty() config function
by Stefan-Cristian Mititelu 09 Aug '23

09 Aug '23

Hello, I have a question for [1] config function. Can I extend it to work with INTs too? e.g. if pv not NULL and INT flag, return 1. This would help, because one won't need to know the type of the pvar beforehand, for using this function. Or is it meant to be used only with string pv only? [1] https://www.kamailio.org/docs/modules/devel/modules/pv.html#pv.f.not_empty Thank you, Stefan

2 2

git:master:d893f3af: core: Add TCP_USER_TIMEOUT socket option on listening socket.
by Daniel-Constantin Mierla 07 Aug '23

07 Aug '23

Module: kamailio Branch: master Commit: d893f3af1444c8c4c5db6cd53fb577703007c90c URL: https://github.com/kamailio/kamailio/commit/d893f3af1444c8c4c5db6cd53fb5777… Author: Walter Schober <walter.schober(a)neotel.at> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-08-07T19:32:53+02:00 core: Add TCP_USER_TIMEOUT socket option on listening socket. Use tcp_send_timeout config option also on listening socket to timeout outbound messages sent on passive inbound connections. --- Modified: src/core/tcp_main.c Modified: src/core/tcp_options.h --- Diff: https://github.com/kamailio/kamailio/commit/d893f3af1444c8c4c5db6cd53fb5777… Patch: https://github.com/kamailio/kamailio/commit/d893f3af1444c8c4c5db6cd53fb5777… --- diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index e96d68c40b2..7f07d724108 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -3172,6 +3172,18 @@ int tcp_init(struct socket_info *sock_info) } #endif init_sock_keepalive(sock_info->socket); +#ifdef HAVE_TCP_USER_TIMEOUT + if((optval = TICKS_TO_S(cfg_get(tcp, tcp_cfg, send_timeout)))) { + optval *= 1000; + if(setsockopt(sock_info->socket, IPPROTO_TCP, TCP_USER_TIMEOUT, &optval, + sizeof(optval)) + < 0) { + LM_WARN("failed to set TCP_USER_TIMEOUT: %s\n", strerror(errno)); + } else { + LM_INFO("Set TCP_USER_TIMEOUT=%d ms\n", optval); + } + } +#endif if(bind(sock_info->socket, &addr->s, sockaddru_len(*addr)) == -1) { LM_ERR("bind(%x, %p, %d) on %s:%d : %s\n", sock_info->socket, &addr->s, (unsigned)sockaddru_len(*addr), sock_info->address_str.s, diff --git a/src/core/tcp_options.h b/src/core/tcp_options.h index d5a628a1128..84c551e2a3b 100644 --- a/src/core/tcp_options.h +++ b/src/core/tcp_options.h @@ -68,6 +68,13 @@ #endif /* __OS_ */ #endif /* NO_TCP_LINGER2 */ +/* tcp user_timeout */ +#ifndef NO_TCP_USER_TIMEOUT +#ifdef __OS_linux +#define HAVE_TCP_USER_TIMEOUT +#endif /* __OS_ */ +#endif /* NO_TCP_LINGER2 */ + /* keepalive */ #ifndef NO_TCP_KEEPALIVE #define HAVE_SO_KEEPALIVE

1 0

git:master:63445544: modules: readme files regenerated - acc ... [skip ci]
by Kamailio Dev 07 Aug '23

07 Aug '23

Module: kamailio Branch: master Commit: 63445544d994d7876ff76eb66203400c5a3a4b91 URL: https://github.com/kamailio/kamailio/commit/63445544d994d7876ff76eb66203400… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-08-07T15:49:07+02:00 modules: readme files regenerated - acc ... [skip ci] --- Modified: src/modules/acc/README Modified: src/modules/app_perl/README Modified: src/modules/cdp/README Modified: src/modules/cdp_avp/README Modified: src/modules/dialog/README Modified: src/modules/dispatcher/README Modified: src/modules/ims_dialog/README Modified: src/modules/ims_registrar_scscf/README Modified: src/modules/ims_usrloc_pcscf/README Modified: src/modules/ims_usrloc_scscf/README Modified: src/modules/nathelper/README Modified: src/modules/registrar/README Modified: src/modules/rtpengine/README Modified: src/modules/rtpproxy/README Modified: src/modules/snmpstats/README --- Diff: https://github.com/kamailio/kamailio/commit/63445544d994d7876ff76eb66203400… Patch: https://github.com/kamailio/kamailio/commit/63445544d994d7876ff76eb66203400…

1 0

[kamailio/kamailio] Typos (PR #3520)
by Дилян Палаузов 07 Aug '23

07 Aug '23

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3520 -- Commit Summary -- * docs/ : typos * etc/ typos -- File Changes -- M INSTALL (2) M doc/docbook/catalog.xml (2) M doc/docbook/dep.xsl (4) M doc/docbook/entities.xml (10) M doc/docbook/html.chunked.xsl (2) M doc/doxygen/main.dox (2) M doc/man/kamailio.cfg.5 (2) M doc/misc/HISTORY (10) M doc/misc/NEWS (58) M doc/misc/TODO (10) M doc/misc/cvs-commit-rules.txt (6) M doc/stylesheets/dbschema_k/catalog.xml (2) M doc/stylesheets/dbschema_k/xsl/db_berkeley.xsl (4) M doc/stylesheets/dbschema_k/xsl/db_redis.xsl (4) M doc/stylesheets/dbschema_k/xsl/dbtext.xsl (4) M doc/stylesheets/dbschema_k/xsl/mysql.xsl (2) M doc/stylesheets/dbschema_k/xsl/pi_framework_mod.xsl (2) M doc/tutorials/presence/cfg/ps.cfg (2) M doc/tutorials/presence/install.xml (2) M doc/tutorials/presence/intro.xml (4) M doc/tutorials/serdev/routing_engine.xml (2) M doc/tutorials/seruser/otherapps.xml (2) M etc/kamailio.cfg (4) M etc/sip-router.cfg (16) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3520.patch https://github.com/kamailio/kamailio/pull/3520.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3520 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3520(a)github.com>

2 1

git:master:6e9335ff: etc/ typos
by Daniel-Constantin Mierla 07 Aug '23

07 Aug '23

Module: kamailio Branch: master Commit: 6e9335ff2245596b74bc1c749d1e7805bf186f02 URL: https://github.com/kamailio/kamailio/commit/6e9335ff2245596b74bc1c749d1e780… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-08-07T15:32:56+02:00 etc/ typos --- Modified: etc/kamailio.cfg Modified: etc/sip-router.cfg --- Diff: https://github.com/kamailio/kamailio/commit/6e9335ff2245596b74bc1c749d1e780… Patch: https://github.com/kamailio/kamailio/commit/6e9335ff2245596b74bc1c749d1e780… --- diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index 68493736d41..715c289af1e 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -227,7 +227,7 @@ enable_sctp=no ####### Custom Parameters ######### -/* These parameters can be modified runtime via RPC interface +/* These parameters can be modified at runtime via RPC interface * - see the documentation of 'cfg_rpc' module. * * Format: group.id = value 'desc' description @@ -389,7 +389,7 @@ modparam("registrar", "path_mode", 0) modparam("acc", "early_media", 0) modparam("acc", "report_ack", 0) modparam("acc", "report_cancels", 0) -/* by default ww do not adjust the direct of the sequential requests. +/* by default we do not adjust the direct of the sequential requests. * if you enable this parameter, be sure the enable "append_fromtag" * in "rr" module */ modparam("acc", "detect_direction", 0) diff --git a/etc/sip-router.cfg b/etc/sip-router.cfg index 0390ef7ec57..8669ea63d79 100644 --- a/etc/sip-router.cfg +++ b/etc/sip-router.cfg @@ -1,7 +1,7 @@ # # $Id$ # -# Example configuration file (simpler then ser-oob.cfg, but more +# Example configuration file (simpler than ser-oob.cfg, but more # complex then ser-basic.cfg). # # First start SER sample config script with: @@ -73,7 +73,7 @@ rev_dns=no # (cmd. line: -R) #group=ser #disable_core=yes #disables core dumping #open_fd_limit=1024 # sets the open file descriptors limit -#mhomed=yes # usefull for multihomed hosts, small performance penalty +#mhomed=yes # useful for multihomed hosts, small performance penalty #disable_tcp=yes #tcp_accept_aliases=yes # accepts the tcp alias via option (see NEWS) sip_warning=yes @@ -172,7 +172,7 @@ modparam("ctl", "binrpc", "tcp:127.0.0.1:2046") # failed transactions (=negative responses) should be logged to modparam("acc_db", "failed_transactions", 1) -# comment the next line if you dont want to have accounting to DB +# comment the next line if you don't want to have accounting to DB modparam("acc_db", "log_flag", "FLAG_ACC") # -- tm params -- @@ -197,7 +197,7 @@ modparam("tls", "private_key", "ser-selfsigned.key") # -- xmlrpc params -- -# using a sub-route from the module is a lot safer then relying on the +# using a sub-route from the module is a lot safer than relying on the # request method to distinguish HTTP from SIP modparam("xmlrpc", "route", "RPC"); @@ -358,8 +358,8 @@ route[RR] # particularly good if upstream and downstream entities # use different transport protocol - # if the inital INVITE got the ACC flag store this in - # an RR AVP cookie. this is more for demonstration purpose + # if the initial INVITE got the ACC flag store this in + # an RR AVP cookie. This is more for demonstration purpose if (isflagset(FLAG_ACC)) { $account = "yes"; setavpflag($account, "dialog_cookie"); @@ -377,7 +377,7 @@ route[DOMAIN] # check if the callee is at a local domain lookup_domain("$td", "@ruri.host"); - # we dont know the domain of the caller and also not + # we don't know the domain of the caller and also not # the domain of the callee -> somone uses our proxy as # a relay if (strempty($t.did) && strempty($f.did)) { @@ -528,7 +528,7 @@ route[INBOUND] if (lookup_contacts("location")) { append_hf("P-hint: usrloc applied\r\n"); - # we set the TM module timers according to the prefences + # we set the TM module timers according to the preferences # of the callee (avoid too long ringing of his phones) # Note1: timer values have to be in ms now! # Note2: this makes even more sense if you switch to a voicemail

1 0

git:master:9fba6779: docs/ : typos
by Daniel-Constantin Mierla 07 Aug '23

07 Aug '23

Module: kamailio Branch: master Commit: 9fba67792382b53ccd4851764505ee3b119531b1 URL: https://github.com/kamailio/kamailio/commit/9fba67792382b53ccd4851764505ee3… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-08-07T15:32:56+02:00 docs/ : typos --- Modified: INSTALL Modified: doc/docbook/catalog.xml Modified: doc/docbook/dep.xsl Modified: doc/docbook/entities.xml Modified: doc/docbook/html.chunked.xsl Modified: doc/doxygen/main.dox Modified: doc/man/kamailio.cfg.5 Modified: doc/misc/HISTORY Modified: doc/misc/NEWS Modified: doc/misc/TODO Modified: doc/misc/cvs-commit-rules.txt Modified: doc/stylesheets/dbschema_k/catalog.xml Modified: doc/stylesheets/dbschema_k/xsl/db_berkeley.xsl Modified: doc/stylesheets/dbschema_k/xsl/db_redis.xsl Modified: doc/stylesheets/dbschema_k/xsl/dbtext.xsl Modified: doc/stylesheets/dbschema_k/xsl/mysql.xsl Modified: doc/stylesheets/dbschema_k/xsl/pi_framework_mod.xsl Modified: doc/tutorials/presence/cfg/ps.cfg Modified: doc/tutorials/presence/install.xml Modified: doc/tutorials/presence/intro.xml Modified: doc/tutorials/serdev/routing_engine.xml Modified: doc/tutorials/seruser/otherapps.xml --- Diff: https://github.com/kamailio/kamailio/commit/9fba67792382b53ccd4851764505ee3… Patch: https://github.com/kamailio/kamailio/commit/9fba67792382b53ccd4851764505ee3…

1 0

Re: Performances issue when freeing shared memory in custom module (Kamailio 5.5.2)
by Henning Westerholt 04 Aug '23

04 Aug '23

Hello, (Adding sr-dev to CC) This looks indeed a bit strange. Do you get any error messages in the log? In which process you are freeing the memory, one of the worker processes or the RPC process? You could also try to use another memory manager to see if you get better performance. There is a command line parameter to choose one during startup. Cheers, Henning -- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://gilawa.com<https://gilawa.com/> From: Chaigneau, Nicolas <nicolas.chaigneau(a)capgemini.com> Sent: Wednesday, January 18, 2023 6:49 PM To: Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org> Subject: [SR-Users] Performances issue when freeing shared memory in custom module (Kamailio 5.5.2) Hello, I'm encountering performance issues with Kamailio (5.5.2). I'm using a custom Kamailio module that loads routing data in memory, using Kamailio shared memory. This routing data is very large. It can be fully reloaded through a Kamailio RPC command (which is done once each day). When reloading, two sets of data are maintained, one "loading" and another "current" (the latter being used to handle SIP requests). When loading of the new data is finished, it is swapped to "current". Then, memory of the old (now unused) data is freed. I've noticed that when Kamailio is freeing the old data, there is a very significant performance impact on SIP requests. This is surprising to me, because the SIP requests do not use this old data. This is not a CPU issue, idle CPU% is at about 99% at that moment. I'm using the following functions : - shm_mallocxz - shm_free From what I understand, shm_free is actually "qm_shm_free" defined in "src\core\mem\q_malloc.c" (the default shared memory manager being "qm"). I've noticed that there is also a variant shm_free_unsafe ("qm_free"), which does not perform locking. I'm wondering if the lock could be the cause of my performances issues ? (But I'm not sure how this could be possible, because although the SIP requests need to access the shared memory allocated, they do not use directly the functions from the share memory manager.) If the performances issues are causes by the lock, could I use the unsafe version "safely" ? (considering that it is guaranteed that the old data cannot be used by anyone else) Thanks for your help. Regards, Nicolas. This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.

3 13

[kamailio/kamailio] Kamailio sending CCR TERMINATE request without waiting for the CCR INITIAL request response (#2143)
by harishyadav1465 03 Aug '23

03 Aug '23

**Description** We are using ims_charging module and Freediameter as diameter server for billing process....recently we faced one issue...For Initial **INVITEs** kamailio sending **CCR request (INITIAL_REQUEST)** to **diameter server** but if we receive Immediate **CANCLE** for the **INVITE**, kamailio sending **CCR request ( TERMINATE_REQUEST )** without waiting for the **CCR request (INITIAL_REQUEST) response** from the **Diameter server.**.. **Expected behavior** Kamailio has to send **CCR request ( TERMINATE_REQUEST )** after getting the **response** from the **INITIAL_REQUEST.** **Additional Info** kamailio server : 4.2 platform : linux -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2143

3 6

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2023