sr-dev August 2023

sr-dev@lists.kamailio.org

15 participants
208 discussions

[kamailio/kamailio] ims_ipsec_pcscf: typo in spi_add function definition (Issue #3513)
by jbipre2 15 Aug '23

15 Aug '23

### Description  Migrating from Kamailio 5.6.4 IMS to Kamailio 5.7.1 IMS; using Open5GS CN, Amarisoft CallBox eNB, and Huawei UE to implement VoLTE infrastructure for lab testing. VoLTE works in Kamailio 5.6.4 IMS with IPSEC and non-IPSEC UE's; but Kamailio 5.7.1 IMS not working yet with IPSEC UE. Client and server port settings in P-CSCF kamailio.cfg: ... modparam("ims_ipsec_pcscf", "ipsec_client_port", 5100) modparam("ims_ipsec_pcscf", "ipsec_server_port", 6100) ... Debug log shows ports are exchanged (server port used as client port and vice-versa): ... Jul 18 12:15:30 corsa03 p-cscf[58287]: DEBUG: ims_ipsec_pcscf [cmd.c:460]: create_ipsec_tunnel(): Creating security associations: Local IP: 10.169.138.17 **port_pc: 6100 port_ps: 5100**; UE IP: 10.46.0.6; port_uc 31409 port_us 31894; spi_pc 4096, spi_ps 4097, spi_uc 48734730, spi_us 96335982, alg hmac-md5-96, ealg null ... ### Troubleshooting spi_add function definition and declaration differ: From src/modules/ims_ipsec_pcscf/spi_list.h: int spi_add(spi_list_t *list, uint32_t spi_cid, uint32_t spi_sid, **uint16_t cport, uint16_t sport**); But in spi_list.c: int spi_add(spi_list_t *list, uint32_t spi_cid, uint32_t spi_sid, **uint16_t sport, uint16_t cport**) #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  Applied following patch: --- a/src/modules/ims_ipsec_pcscf/spi_list.c 2023-06-28 09:40:45.000000000 +0200 +++ b/src/modules/ims_ipsec_pcscf/spi_list.c 2023-07-18 16:12:11.166476076 +0200 @@ -51,7 +51,7 @@ } int spi_add(spi_list_t *list, uint32_t spi_cid, uint32_t spi_sid, - uint16_t sport, uint16_t cport) + uint16_t cport, uint16_t sport) { if(!list) { return 1; Log now shows expected client and server port: ... Jul 18 17:45:22 corsa03 p-cscf[82076]: DEBUG: ims_ipsec_pcscf [cmd.c:460]: create_ipsec_tunnel(): Creating security associations: Local IP: 10.169.138.17 **port_pc: 5100 port_ps: 6100**; UE IP: 10.46.0.6; port_uc 31411 port_us 31896; spi_pc 4096, spi_ps 4097, spi_uc 48734732, spi_us 96335984, alg hmac-md5-96, ealg null ... ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.1 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 16:22:26 Jul 18 2023 with x86_64-pc-linux-gnu-gcc 13.1.1 ``` * **Operating System**:  ``` Linux corsa03 6.4.2-gentoo-x86_64 #2 SMP PREEMPT_DYNAMIC Tue Jul 11 14:35:45 CEST 2023 x86_64 AMD EPYC 7513 32-Core Processor AuthenticAMD GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3513 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3513(a)github.com> [View Less]

2 3

git:master:a053bcc3: ims_ipsec_pcscf: typo in spi_add function definition, GH #3513
by Henning Westerholt 15 Aug '23

15 Aug '23

Module: kamailio Branch: master Commit: a053bcc391f0680ecd5f458d2512e57f69499d39 URL: https://github.com/kamailio/kamailio/commit/a053bcc391f0680ecd5f458d2512e57… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-08-15T14:17:38Z ims_ipsec_pcscf: typo in spi_add function definition, GH #3513 - fix typo in spi_add function definition - patch from jbipre2, GH #3513 --- Modified: src/modules/ims_ipsec_pcscf/spi_list.c --- Diff:… [View More]

1 0

git:master:9becbcb1: modules: readme files regenerated - htable ... [skip ci]
by Kamailio Dev 15 Aug '23

15 Aug '23

Module: kamailio Branch: master Commit: 9becbcb11005377b9925386e5c0de89d20e39b26 URL: https://github.com/kamailio/kamailio/commit/9becbcb11005377b9925386e5c0de89… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-08-15T16:01:18+02:00 modules: readme files regenerated - htable ... [skip ci] --- Modified: src/modules/htable/README --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:4d285806: htable: spelling fix related to commit b612f0791821
by Henning Westerholt 15 Aug '23

15 Aug '23

Module: kamailio Branch: master Commit: 4d285806b4bb9197c58e0d6e1d4fb33a65865138 URL: https://github.com/kamailio/kamailio/commit/4d285806b4bb9197c58e0d6e1d4fb33… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-08-15T13:49:56Z htable: spelling fix related to commit b612f0791821 --- Modified: src/modules/htable/doc/htable_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/4d285806b4bb9197c58e0d6e1d4fb33… … [View More]

1 0

git:master:0e11b4e8: modules: readme files regenerated - htable ... [skip ci]
by Kamailio Dev 15 Aug '23

15 Aug '23

Module: kamailio Branch: master Commit: 0e11b4e8f3b1380043034ea9e66f7643e4623960 URL: https://github.com/kamailio/kamailio/commit/0e11b4e8f3b1380043034ea9e66f764… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-08-15T15:01:14+02:00 modules: readme files regenerated - htable ... [skip ci] --- Modified: src/modules/htable/README --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:a50aa868: htable: rpc command to permorm a dmq sync action
by Daniel-Constantin Mierla 15 Aug '23

15 Aug '23

Module: kamailio Branch: master Commit: a50aa8688afdca9e3c4e34e8d3929e96e6f5b3fa URL: https://github.com/kamailio/kamailio/commit/a50aa8688afdca9e3c4e34e8d3929e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-08-15T14:52:56+02:00 htable: rpc command to permorm a dmq sync action --- Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:8bdc40e0: modules: readme files regenerated - dispatcher ... [skip ci]
by Kamailio Dev 14 Aug '23

14 Aug '23

Module: kamailio Branch: master Commit: 8bdc40e085edddf1e58d8946e06983707fb15770 URL: https://github.com/kamailio/kamailio/commit/8bdc40e085edddf1e58d8946e069837… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-08-14T17:16:24+02:00 modules: readme files regenerated - dispatcher ... [skip ci] --- Modified: src/modules/dispatcher/README Modified: src/modules/ims_qos/README --- Diff: https://github.com/kamailio/… [View More]

1 0

git:master:20634fcc: ims_qos: doc and logs update
by Henning Westerholt 14 Aug '23

14 Aug '23

Module: kamailio Branch: master Commit: 20634fccc59c82a35b45a3da0b8e6a0e64acb37e URL: https://github.com/kamailio/kamailio/commit/20634fccc59c82a35b45a3da0b8e6a0… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-08-14T17:08:35+02:00 ims_qos: doc and logs update --- Modified: src/modules/ims_qos/doc/ims_qos_admin.xml Modified: src/modules/ims_qos/ims_qos_mod.c --- Diff: https://github.com/kamailio/kamailio/… [View More]commit/20634fccc59c82a35b45a3da0b8e6a0… Patch: https://github.com/kamailio/kamailio/commit/20634fccc59c82a35b45a3da0b8e6a0… --- diff --git a/src/modules/ims_qos/doc/ims_qos_admin.xml b/src/modules/ims_qos/doc/ims_qos_admin.xml index b8a36c7b136..7755a963abd 100644 --- a/src/modules/ims_qos/doc/ims_qos_admin.xml +++ b/src/modules/ims_qos/doc/ims_qos_admin.xml @@ -29,7 +29,7 @@ <itemizedlist> <listitem> - <para>Dialog</para> + <para>IMS Dialog</para> </listitem> <listitem> @@ -625,8 +625,8 @@ route[REG_AAR_REPLY] </listitem> </itemizedlist> - <para>This function can be used from REQUEST_ROUTE or - ONREPLY_ROUTE.</para> + <para>This function can be used only from ONREPLY_ROUTE, only for replies to INVITE, UPDATE, PRACK. + The reply and request must have SDP, for this function to work properly.</para> <para>p.s. this is executed asynchronously. See example on how to retrieve return value</para> diff --git a/src/modules/ims_qos/ims_qos_mod.c b/src/modules/ims_qos/ims_qos_mod.c index d2502020450..9ff174f03eb 100644 --- a/src/modules/ims_qos/ims_qos_mod.c +++ b/src/modules/ims_qos/ims_qos_mod.c @@ -205,8 +205,8 @@ static int pv_t_copy_msg(struct sip_msg *src, struct sip_msg *dst) } -static cmd_export_t cmds[] = {{"Rx_AAR", (cmd_function)w_rx_aar, 4, fixup_aar, - 0, REQUEST_ROUTE | ONREPLY_ROUTE}, +static cmd_export_t cmds[] = { + {"Rx_AAR", (cmd_function)w_rx_aar, 4, fixup_aar, 0, ONREPLY_ROUTE}, {"Rx_AAR_Register", (cmd_function)w_rx_aar_register, 2, fixup_aar_register, 0, REQUEST_ROUTE}, {0, 0, 0, 0, 0, 0}}; @@ -801,7 +801,7 @@ static int w_rx_aar( } if(t->uas.status >= 200) { - LM_DBG("transaction sent out a final response already - %d\n", + LM_WARN("transaction sent out a final response already - %d\n", t->uas.status); return result; } @@ -864,13 +864,13 @@ static int w_rx_aar( || memcmp(t->method.s, "UPDATE", 6) == 0))) { if(cscf_get_content_length(msg) == 0 || cscf_get_content_length(orig_sip_request_msg) == 0) { - LM_DBG("No SDP offer answer -> therefore we can not do Rx AAR"); + LM_WARN("No SDP offer answer -> therefore we can not do Rx AAR"); //goto aarna; //AAR na if we don't have offer/answer pair return result; } } else { - LM_DBG("Message is not response to INVITE, PRACK or UPDATE -> " - "therefore we do not Rx AAR"); + LM_WARN("Message is not response to INVITE, PRACK or UPDATE -> " + "therefore we do not Rx AAR"); return result; } @@ -1162,7 +1162,7 @@ static int w_rx_aar( int ret = create_new_callsessiondata(&callid, &ftag, &ttag, &identifier, identifier_type, &ip, ip_version, &rx_authdata_p); if(!ret) { - LM_DBG("Unable to create new media session data parcel\n"); + LM_ERR("Unable to create new media session data parcel\n"); goto error; } [View Less]

1 0

git:master:2a1a65db: dispatcher: add option to retain existing latency stats when reloading destinations
by Henning Westerholt 14 Aug '23

14 Aug '23

Module: kamailio Branch: master Commit: 2a1a65dba78665b9d663e2e8335cff11a1116ec2 URL: https://github.com/kamailio/kamailio/commit/2a1a65dba78665b9d663e2e8335cff1… Author: Charles Chance <charles.chance(a)sipcentric.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-08-14T17:06:36+02:00 dispatcher: add option to retain existing latency stats when reloading destinations - also retain when adding/removing individual destinations via RPC --- Modified: src/modules/… [View More]

1 0

git:master:2fd5d881: modules: readme files regenerated - rabbitmq ... [skip ci]
by Kamailio Dev 12 Aug '23

12 Aug '23

Module: kamailio Branch: master Commit: 2fd5d881563126f7425730f798afcbfc2feeac65 URL: https://github.com/kamailio/kamailio/commit/2fd5d881563126f7425730f798afcbf… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-08-12T13:46:24+02:00 modules: readme files regenerated - rabbitmq ... [skip ci] --- Modified: src/modules/rabbitmq/README Modified: src/modules/xhttp/README --- Diff: https://github.com/kamailio/… [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2023