sr-dev May 2023

sr-dev@lists.kamailio.org

16 participants
324 discussions

git:master:c5d846d4: dlgs: use PRIu64 to print uint64_t
by Daniel-Constantin Mierla 04 May '23

04 May '23

Module: kamailio Branch: master Commit: c5d846d499cdc4fa6829c3bf4d7a120d9dbe16da URL: https://github.com/kamailio/kamailio/commit/c5d846d499cdc4fa6829c3bf4d7a120… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-05-04T14:11:06+02:00 dlgs: use PRIu64 to print uint64_t --- Modified: src/modules/dlgs/dlgs_records.c --- Diff: https://github.com/kamailio/kamailio/commit/c5d846d499cdc4fa6829c3bf4d7a120… Patch: https://github.com/kamailio/kamailio/commit/c5d846d499cdc4fa6829c3bf4d7a120… --- diff --git a/src/modules/dlgs/dlgs_records.c b/src/modules/dlgs/dlgs_records.c index 2f0bb65b6ce..25026136b21 100644 --- a/src/modules/dlgs/dlgs_records.c +++ b/src/modules/dlgs/dlgs_records.c @@ -27,6 +27,7 @@ #include <stdint.h> #include <regex.h> #include <fnmatch.h> +#include <inttypes.h> #include "../../core/dprint.h" #include "../../core/ut.h" @@ -658,7 +659,7 @@ int dlgs_ht_dbg(void) LM_ERR("\tdst: %.*s\n", it->dst.len, it->dst.s); LM_ERR("\tdata: %.*s\n", it->data.len, it->data.s); LM_ERR("\truid: %.*s\n", it->ruid.len, it->ruid.s); - LM_ERR("\thashid: %u ts_init: %llu ts_answer: %llu\n", it->hashid, + LM_ERR("\thashid: %u ts_init: %" PRIu64 " ts_answer: %" PRIu64 "\n", it->hashid, (uint64_t)it->ts_init, (uint64_t)it->ts_answer); it = it->next; }

1 0

Branching 5.7 on git repo for 5.7.x releases
by Daniel-Constantin Mierla 04 May '23

04 May '23

Hello, I am planning to split 5.7.x series on its own git branch 5.7 on Thursday, May 4, 2023. After that, master branch will be open for new features (to become part of 5.8 or what ever version will be decided to be next). Usually testing should continue for branch 5.7 for another 1-2 weeks, then, if no relevant road blockers pop up, we should release 5.7.0 as first stable version in the 5.7.x series. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - June 5-7, 2023 - www.kamailioworld.com

1 1

[kamailio/kamailio] Getting error while configuring kamailio. (Issue #3433)
by rutujasm 04 May '23

04 May '23

### Description  I have installed kamailio and also mariadb server with mysql.I also updated kamctlrc file values with my actual hostname and the user ,database,tables its password .But grtting errors while configuring kamailio. ### Troubleshooting #### Reproduction  root@jigasi:/# sudo vi /etc/kamailio/kamailio.cfg root@jigasi:/# sudo systemctl restart kamailio.service Job for kamailio.service failed because the control process exited with error code. See "systemctl status kamailio.service" and "journalctl -xeu kamailio.service" for details. root@jigasi:/# sudo systemctl status kamailio.service × kamailio.service - Kamailio - the Open Source SIP Server Loaded: loaded (/lib/systemd/system/kamailio.service; enabled; vendor preset: enabled) Active: failed (Result: exit-code) since Thu 2023-05-04 08:45:03 UTC; 10s ago Process: 29245 ExecStart=/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f $CFGFILE -m $SHM_MEMORY -M $PKG_MEMORY --atexit=no (code=exited, status=255/EXCEPTION) CPU: 32ms May 04 08:45:03 jigasi.pune.cdac.in systemd[1]: kamailio.service: Scheduled restart job, restart counter is at 5. May 04 08:45:03 jigasi.pune.cdac.in systemd[1]: Stopped Kamailio - the Open Source SIP Server. May 04 08:45:03 jigasi.pune.cdac.in systemd[1]: kamailio.service: Start request repeated too quickly. May 04 08:45:03 jigasi.pune.cdac.in systemd[1]: kamailio.service: Failed with result 'exit-code'. May 04 08:45:03 jigasi.pune.cdac.in systemd[1]: Failed to start Kamailio - the Open Source SIP Server. root@jigasi:/# kamailio -c 0(29260) ERROR: <core> [core/modparam.c:175]: set_mod_param_regex(): parameter <host> of type <1:string> not found in module <db_mysql> 0(29260) CRITICAL: <core> [core/cfg.y:3686]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 259, column 51: Can't set module parameter 0(29260) ERROR: <core> [core/modparam.c:175]: set_mod_param_regex(): parameter <port> of type <2:int> not found in module <db_mysql> 0(29260) CRITICAL: <core> [core/cfg.y:3686]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 260, column 34: Can't set module parameter 0(29260) ERROR: <core> [core/modparam.c:175]: set_mod_param_regex(): parameter <dbname> of type <1:string> not found in module <db_mysql> 0(29260) CRITICAL: <core> [core/cfg.y:3686]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 261, column 42: Can't set module parameter 0(29260) ERROR: <core> [core/modparam.c:175]: set_mod_param_regex(): parameter <table> of type <1:string> not found in module <db_mysql> 0(29260) CRITICAL: <core> [core/cfg.y:3686]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 262, column 43: Can't set module parameter 0(29260) ERROR: <core> [core/modparam.c:175]: set_mod_param_regex(): parameter <username> of type <1:string> not found in module <db_mysql> 0(29260) CRITICAL: <core> [core/cfg.y:3686]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 263, column 44: Can't set module parameter 0(29260) ERROR: <core> [core/modparam.c:175]: set_mod_param_regex(): parameter <password> of type <1:string> not found in module <db_mysql> 0(29260) CRITICAL: <core> [core/cfg.y:3686]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 264, column 47: Can't set module parameter 0(29260) ERROR: <core> [core/modparam.c:175]: set_mod_param_regex(): parameter <db_url> of type <1:string> not found in module <db_mysql> 0(29260) CRITICAL: <core> [core/cfg.y:3686]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 265, column 91: Can't set module parameter 0(29260) ERROR: <core> [core/modparam.c:175]: set_mod_param_regex(): parameter <username_column> of type <1:string> not found in module <auth_db> 0(29260) CRITICAL: <core> [core/cfg.y:3686]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 299, column 50: Can't set module parameter ERROR: bad config file (8 errors) (parsing code: 0) 0(29260) INFO: <core> [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ```root@jigasi:/# kamailio -v version: kamailio 5.5.6 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 9.4.0 root@jigasi:/# * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3433 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3433(a)github.com>

2 4

[kamailio/kamailio] Slow service restart on FreeBSD (Issue #3431)
by tbswork1 04 May '23

04 May '23

### Description Restarting kamailio service on FreeBSD takes a one minute to complete. With default config in place. ### Troubleshooting #### Reproduction ``` service kamailio restart ``` #### Debugging Data #### Log Messages ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` 5.5.4 ``` sudo service kamailio restart Performing sanity check on kamailio configuration: 0(14393) WARNING: <core> [core/socket_info.c:1480]: fix_hostname(): could not rev. resolve 192.168.0.18 0(14393) WARNING: <core> [core/socket_info.c:1480]: fix_hostname(): could not rev. resolve 192.168.0.18 config file ok, exiting... Stopping kamailio. Waiting for PIDS: 14307. Starting kamailio. ``` * **Operating System**: FreeBSD  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3431 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3431(a)github.com>

2 2

git:master:c394d9b2: textopsx: convert to memory error logging helper, add missing logging for allocation errors
by Henning Westerholt 04 May '23

04 May '23

Module: kamailio Branch: master Commit: c394d9b2108443f9cd6146d88f77f51a2a059ba5 URL: https://github.com/kamailio/kamailio/commit/c394d9b2108443f9cd6146d88f77f51… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-05-04T08:06:38Z textopsx: convert to memory error logging helper, add missing logging for allocation errors --- Modified: src/modules/textopsx/textopsx.c --- Diff: https://github.com/kamailio/kamailio/commit/c394d9b2108443f9cd6146d88f77f51… Patch: https://github.com/kamailio/kamailio/commit/c394d9b2108443f9cd6146d88f77f51…

1 0

git:master:b6c3a155: kafka: convert to memory error logging helper
by Henning Westerholt 04 May '23

04 May '23

Module: kamailio Branch: master Commit: b6c3a15518e9b6c7259be7c906193aa0cd510449 URL: https://github.com/kamailio/kamailio/commit/b6c3a15518e9b6c7259be7c906193aa… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-05-04T08:06:37Z kafka: convert to memory error logging helper --- Modified: src/modules/kafka/kfk.c --- Diff: https://github.com/kamailio/kamailio/commit/b6c3a15518e9b6c7259be7c906193aa… Patch: https://github.com/kamailio/kamailio/commit/b6c3a15518e9b6c7259be7c906193aa… --- diff --git a/src/modules/kafka/kfk.c b/src/modules/kafka/kfk.c index 555351710b7..4b892942af1 100644 --- a/src/modules/kafka/kfk.c +++ b/src/modules/kafka/kfk.c @@ -352,7 +352,7 @@ int kfk_conf_parse(char *spec) kconf = (kfk_conf_t*)pkg_malloc(sizeof(kfk_conf_t)); if (kconf == NULL) { - LM_ERR("No more pkg memory\n"); + PKG_MEM_ERROR; goto error; } memset(kconf, 0, sizeof(kfk_conf_t)); @@ -364,7 +364,7 @@ int kfk_conf_parse(char *spec) kfk_conf_node_t *knode = NULL; knode = (kfk_conf_node_t*)pkg_malloc(sizeof(kfk_conf_node_t)); if (knode == NULL) { - LM_ERR("No more pkg memory\n"); + PKG_MEM_ERROR; goto error; } memset(knode, 0, sizeof(kfk_conf_node_t)); @@ -504,7 +504,7 @@ int kfk_topic_parse(char *spec) ktopic = (kfk_topic_t*)pkg_malloc(sizeof(kfk_topic_t)); if (ktopic == NULL) { - LM_ERR("No more pkg memory\n"); + PKG_MEM_ERROR; goto error; } memset(ktopic, 0, sizeof(kfk_topic_t)); @@ -527,7 +527,7 @@ int kfk_topic_parse(char *spec) kfk_conf_node_t *knode = NULL; knode = (kfk_conf_node_t*)pkg_malloc(sizeof(kfk_conf_node_t)); if (knode == NULL) { - LM_ERR("No more pkg memory\n"); + PKG_MEM_ERROR; goto error; } memset(knode, 0, sizeof(kfk_conf_node_t)); @@ -898,7 +898,7 @@ int kfk_stats_init() stats_general = shm_malloc(sizeof(kfk_stats_t)); if (!stats_general) { - LM_ERR("Out of shared memory\n"); + SHM_MEM_ERROR; return -1; } memset(stats_general, 0, sizeof(kfk_stats_t)); @@ -971,21 +971,21 @@ static kfk_stats_t* kfk_stats_topic_new(const char *topic, rd_kafka_resp_err_t e st = shm_malloc(sizeof(kfk_stats_t)); if (!st) { - LM_ERR("Out of shared memory\n"); + SHM_MEM_ERROR; goto error; } memset(st, 0, sizeof(kfk_stats_t)); st->topic_name = shm_malloc(sizeof(str)); if (!st->topic_name) { - LM_ERR("Out of shared memory\n"); + SHM_MEM_ERROR; goto error; } memset(st->topic_name, 0, sizeof(str)); st->topic_name->s = shm_malloc(topic_len + 1); if (!st->topic_name->s) { - LM_ERR("Out of shared memory\n"); + SHM_MEM_ERROR; goto error; } memcpy(st->topic_name->s, topic, topic_len);

1 0

git:master:40b18ddf: secfilter: convert to memory error logging helper, add missing mem cleanup on errors
by Henning Westerholt 04 May '23

04 May '23

Module: kamailio Branch: master Commit: 40b18ddfe3eca3170ef6c535d39332b2e3c6ce5d URL: https://github.com/kamailio/kamailio/commit/40b18ddfe3eca3170ef6c535d39332b… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-05-04T08:06:37Z secfilter: convert to memory error logging helper, add missing mem cleanup on errors --- Modified: src/modules/secfilter/secfilter.c --- Diff: https://github.com/kamailio/kamailio/commit/40b18ddfe3eca3170ef6c535d39332b… Patch: https://github.com/kamailio/kamailio/commit/40b18ddfe3eca3170ef6c535d39332b… --- diff --git a/src/modules/secfilter/secfilter.c b/src/modules/secfilter/secfilter.c index 5e967b2204b..061a1eb7445 100644 --- a/src/modules/secfilter/secfilter.c +++ b/src/modules/secfilter/secfilter.c @@ -276,7 +276,7 @@ static int w_check_sqli(str val) cval = (char *)pkg_malloc(val.len + 1); if(cval == NULL) { - LM_CRIT("Cannot allocate pkg memory\n"); + PKG_MEM_CRITICAL; return -2; } memset(cval, 0, val.len + 1); @@ -752,6 +752,7 @@ int secf_init_data(void) secf_data_2 = (secf_data_p)shm_malloc(sizeof(secf_data_t)); if(!secf_data_2) { SHM_MEM_ERROR; + shm_free(secf_data_1); return -1; } memset(secf_data_2, 0, sizeof(secf_data_t)); @@ -759,10 +760,20 @@ int secf_init_data(void) secf_data = shm_malloc(sizeof(secf_data_t)); if(secf_data == NULL) { SHM_MEM_ERROR; + shm_free(secf_data_1); + shm_free(secf_data_2); return -1; } secf_stats = shm_malloc(total_data * sizeof(int)); + if(!secf_stats) + { + SHM_MEM_ERROR; + shm_free(secf_data_1); + shm_free(secf_data_2); + shm_free(secf_data); + return -1; + } memset(secf_stats, 0, total_data * sizeof(int)); if(secf_dst_exact_match != 0)

1 0

git:master:d031d1e4: ims_registrar_pcscf: convert to memory error log helper, add missing mem cleanup during errors
by Henning Westerholt 04 May '23

04 May '23

Module: kamailio Branch: master Commit: d031d1e483f4c025074e6a6bc95728dc88193c7b URL: https://github.com/kamailio/kamailio/commit/d031d1e483f4c025074e6a6bc95728d… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-05-04T08:06:37Z ims_registrar_pcscf: convert to memory error log helper, add missing mem cleanup during errors --- Modified: src/modules/ims_registrar_pcscf/async_reginfo.c Modified: src/modules/ims_registrar_pcscf/sec_agree.c Modified: src/modules/ims_registrar_pcscf/service_routes.c Modified: src/modules/ims_registrar_pcscf/subscribe.c Modified: src/modules/ims_registrar_pcscf/ul_callback.c --- Diff: https://github.com/kamailio/kamailio/commit/d031d1e483f4c025074e6a6bc95728d… Patch: https://github.com/kamailio/kamailio/commit/d031d1e483f4c025074e6a6bc95728d…

1 0

git:master:8b9e4dbc: lcr: convert to memory error logging helper, add some missing mem cleanup on error
by Henning Westerholt 04 May '23

04 May '23

Module: kamailio Branch: master Commit: 8b9e4dbcc29a4ff913039adf1ce1eae941976533 URL: https://github.com/kamailio/kamailio/commit/8b9e4dbcc29a4ff913039adf1ce1eae… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-05-04T08:06:37Z lcr: convert to memory error logging helper, add some missing mem cleanup on error --- Modified: src/modules/lcr/hash.c Modified: src/modules/lcr/lcr_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/8b9e4dbcc29a4ff913039adf1ce1eae… Patch: https://github.com/kamailio/kamailio/commit/8b9e4dbcc29a4ff913039adf1ce1eae…

1 0

RFC: selective backports to latest stable as a dedicated git branch
by Daniel-Constantin Mierla 03 May '23

03 May '23

Hello, during past on-site/online devel meetings as well as on mailing lists or tracker, there were various discussions around the idea or requests to make new features available quicker to stable branches. Of course, one can do local git cherry-picking, but I thought to bring this in discussion and see if makes sense to get something more coordinated between developers and community. Therefore I am cross-posting to sr-dev and sr-users to see if there is interest for it from both communities. Somehow inspired from Debian, my first idea would be to create a "x.y-backports" branch, where "x.y" is the branch for the stable release series. For example, with 5.6 release series built from branch "5.6", there could be "5.6-backports" branch which is kept in sync in "5.6" but also can get "selected" new features from devel (master branch) backported. The "selected" new features should be mostly a matter of the people willing to put effort in backporting, but I would consider a list recommendations not to end up with devel and backports branches being more or less the same. For example, in the "no-backporting" list: - no backporting of completely new modules - no backporting of significant changes to the config file language and native scripting interpreter In the "ok-to-backport": - updates to enable use with newer versions of external libraries - changes to make some functions/modules to cope better with the core infrastructure or end points Commits to the backports branch can be proposed via pull requests. The backports branch should be done only for latest stable version, picking from the development version. Right now it would be 5.6, but we can wait till 5.7 is released and then have it for it. No packaging and no official releases should be made from backports branch, only a git branch to be maintained as a community effort. Of course, if someone wants to put more resources into it, we can discuss about. Anyhow, the first questions would be if such branch sounds good to have and if there are people that think they can also contribute to maintain it. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - June 5-7, 2023 - www.kamailioworld.com

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2023