sr-dev May 2023

sr-dev@lists.kamailio.org

16 participants
323 discussions

[kamailio/kamailio] Invoking jwt_verify causing TLS termination (Issue #3434)
by obarash 08 May '23

08 May '23

### Description When invoking jwt_verify with an expired JWT, it causes TLS termination with log print from the tls_server and tls_util. While trying to debug the issue, I tried to give the method an invalid key path. I got the following log (as expected): ``` failed to read key file ``` Then the flow continued just fine (fallback to proxy_authorization). When I gave it a correct file path, but the content is wrong, the problem still occurred. This makes me think the problem is in the … [View More]method : ``` static int ki_jwt_verify_key(sip_msg_t* msg, str *key, str *alg, str *claims, str *jwtval) ``` ### Troubleshooting #### Reproduction Use an expired JWT #### Log Messages ``` May 4 12:52:37 kamailio01 /usr/sbin/kamailio[21921]: INFO: {1 13605 INVITE 71a5d88a-b485-43c0-bac4-a2723333efeb} <script>: request_route: method [INVITE] from [sip:1234@barash.com] to [sip:pre-arranged-conf-factory@barash.com] May 4 12:52:37 kamailio01 /usr/sbin/kamailio[21921]: ERROR: {1 13605 INVITE 71a5d88a-b485-43c0-bac4-a2723333efeb} jwt [jwt_mod.c:514]: ki_jwt_verify(): failed to decode jwt value May 4 12:52:37 kamailio01 /usr/sbin/kamailio[21921]: INFO: {1 13605 INVITE 71a5d88a-b485-43c0-bac4-a2723333efeb} <script>: route[AUTH] failed to verify jwt token. May 4 12:52:37 kamailio01 /usr/sbin/kamailio[21921]: ERROR: tls [tls_server.c:1330]: tls_h_read_f(): protocol level error May 4 12:52:37 kamailio01 /usr/sbin/kamailio[21921]: ERROR: tls [tls_util.h:51]: tls_err_ret(): TLS read:error:0407008A:rsa routines:RSA_padding_check_PKCS1_type_1:invalid padding (sni: dev-proxy.barash.com) May 4 12:52:37 kamailio01 /usr/sbin/kamailio[21921]: ERROR: tls [tls_util.h:51]: tls_err_ret(): TLS read:error:04067072:rsa routines:rsa_ossl_public_decrypt:padding check failed (sni: dev-proxy.barash.com) May 4 12:52:37 kamailio01 /usr/sbin/kamailio[21921]: ERROR: tls [tls_server.c:1334]: tls_h_read_f(): src addr: 172.19.140.11:37188 May 4 12:52:37 kamailio01 /usr/sbin/kamailio[21921]: ERROR: tls [tls_server.c:1337]: tls_h_read_f(): dst addr: 172.19.140.70:5061 May 4 12:52:37 kamailio01 /usr/sbin/kamailio[21921]: ERROR: <core> [core/tcp_read.c:1478]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0x7f731ec677f8 r: 0x7f731ec67920 (-1) ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.6.4 (x86_64/linux) a004cf flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: a004cf compiled on 09:56:56 Mar 22 2023 with gcc 8.3.0 ``` * **Operating System**: ``` No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 10 (buster) Release: 10 Codename: buster Linux kamailio01.dev.wb.internal 4.19.0-23-amd64 #1 SMP Debian 4.19.269-1 (2022-12-20) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3434 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3434(a)github.com> [View Less]

2 2

git:master:5ec8c403: siptrace: reworked sip_trace_msg() to specify source and target addresses
by Daniel-Constantin Mierla 08 May '23

08 May '23

Module: kamailio Branch: master Commit: 5ec8c403e0a49ec752d5b10f330f53a97d625822 URL: https://github.com/kamailio/kamailio/commit/5ec8c403e0a49ec752d5b10f330f53a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-05-08T14:11:08+02:00 siptrace: reworked sip_trace_msg() to specify source and target addresses - implemented for hep mirroring only - prototype: sip_trace_msg(data, saddr, taddr, duri, corrid) --- … [View More]

1 0

git:master:43e76ead: siptrace: sip_trace_msg() exported with 3 parameters
by Daniel-Constantin Mierla 08 May '23

08 May '23

Module: kamailio Branch: master Commit: 43e76ead36e9d09d462ebc0ba2fc88d06c4d9ac4 URL: https://github.com/kamailio/kamailio/commit/43e76ead36e9d09d462ebc0ba2fc88d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-05-08T14:11:08+02:00 siptrace: sip_trace_msg() exported with 3 parameters --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:7532e92b: siptrace; fix parameter inside sip_trace_msg()
by Daniel-Constantin Mierla 08 May '23

08 May '23

Module: kamailio Branch: master Commit: 7532e92bc45f35348a34f9e7bd39fc00db4118dd URL: https://github.com/kamailio/kamailio/commit/7532e92bc45f35348a34f9e7bd39fc0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-05-08T14:11:08+02:00 siptrace; fix parameter inside sip_trace_msg() --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:b6d03564: siptrace: added sip_trace_msg(dst, corlid, vmsg)
by Daniel-Constantin Mierla 08 May '23

08 May '23

Module: kamailio Branch: master Commit: b6d03564570839553bd0eeed28c06102bfa9fc46 URL: https://github.com/kamailio/kamailio/commit/b6d03564570839553bd0eeed28c0610… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-05-08T14:11:08+02:00 siptrace: added sip_trace_msg(dst, corlid, vmsg) - send sip trace with the message provided as parmameter --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://… [View More]github.com/kamailio/kamailio/commit/b6d03564570839553bd0eeed28c0610… Patch: https://github.com/kamailio/kamailio/commit/b6d03564570839553bd0eeed28c0610… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 81926cc1ba..b2638137c4 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -90,6 +90,7 @@ static int w_sip_trace0(struct sip_msg *, char *p1, char *p2); static int w_sip_trace1(struct sip_msg *, char *dest, char *p2); static int w_sip_trace2(struct sip_msg *, char *dest, char *correlation_id); static int w_sip_trace3(struct sip_msg *, char *dest, char *correlation_id, char *trace_type); +static int w_sip_trace_msg(sip_msg_t *msg, char *dest, char *correlation_id, char *vmsg); static int fixup_siptrace(void **param, int param_no); static int fixup_free_siptrace(void **param, int param_no); static int w_sip_trace_mode(sip_msg_t *msg, char *pmode, char *p2); @@ -216,6 +217,8 @@ static cmd_export_t cmds[] = { ANY_ROUTE}, {"sip_trace", (cmd_function)w_sip_trace3, 3, fixup_siptrace, fixup_free_siptrace, ANY_ROUTE}, + {"sip_trace_msg", (cmd_function)w_sip_trace_msg, 4, fixup_spve_all, fixup_free_spve_all, + ANY_ROUTE}, {"hlog", (cmd_function)w_hlog1, 1, fixup_spve_null, 0, ANY_ROUTE}, {"hlog", (cmd_function)w_hlog2, 2, fixup_spve_spve, 0, @@ -774,12 +777,12 @@ static int fixup_siptrace(void **param, int param_no) str sflags; enum siptrace_type_t trace_type; - if(param_no < 1 || param_no > 3) { + if(param_no < 1 || param_no > 4) { LM_DBG("params:%s\n", (char *)*param); return 0; } - if (param_no == 1 || param_no == 2) { + if (param_no == 1 || param_no == 2 || param_no == 4) { /* correlation id */ return fixup_spve_all(param, param_no); } else if (param_no == 3) { @@ -806,7 +809,7 @@ static int fixup_siptrace(void **param, int param_no) static int fixup_free_siptrace(void **param, int param_no) { - if (param_no == 1 || param_no == 2) { + if (param_no == 1 || param_no == 2 || param_no == 4) { /* correlation id */ return fixup_free_spve_all(param, param_no); } if (param_no == 3) { @@ -1163,6 +1166,67 @@ static int w_sip_trace3(sip_msg_t *msg, char *dest, char *correlation_id, char * (correlation_id)?&correlation_id_str:NULL, NULL, trace_type); } +/** + * + */ +static int w_sip_trace_msg(sip_msg_t *msg, char *dest, char *correlation_id, char *vmsg) +{ + str vmsg_str = {0, 0}; + sip_msg_t *nmsg = NULL; + sip_msg_t tmsg; + char tbuf[BUF_SIZE]; + int ret; + + if (vmsg) { + if(fixup_get_svalue(msg, (gparam_t*)vmsg, &vmsg_str) != 0) { + LM_ERR("unable to parse the msg data parameter\n"); + return -1; + } + memset(&tmsg, 0, sizeof(sip_msg_t)); + memcpy(tbuf, vmsg_str.s, vmsg_str.len); + tbuf[vmsg_str.len] = 0; + tmsg.buf = tbuf; + tmsg.len = vmsg_str.len; + if (parse_msg(tmsg.buf, tmsg.len, &tmsg)!=0) { + LM_ERR("parse msg failed\n"); + return -1; + } + if (parse_headers(msg, HDR_EOH_F, 0)==-1) { + LM_DBG("parsing headers failed [[%.*s]]\n", + msg->len, msg->buf); + goto error; + } + + if(parse_from_header(msg)<0) { + LM_ERR("cannot parse FROM header\n"); + goto error; + } + + if(parse_to_header(msg)<0 || msg->to==NULL) { + LM_ERR("cannot parse TO header\n"); + goto error; + } + tmsg.id = msg->id; + tmsg.pid = msg->pid; + tmsg.rcv = msg->rcv; + nmsg = &tmsg; + } else { + nmsg = msg; + } + + ret = w_sip_trace3(msg, dest, correlation_id, NULL); + + if(nmsg != msg) { + free_sip_msg(&tmsg); + } + + return ret; + +error: + free_sip_msg(&tmsg); + return -1; +} + /** * link call-id, method, from-tag and to-tag */ [View Less]

1 0

[kamailio/kamailio] siptrace - custom sip message hep replication (PR #3442)
by Daniel-Constantin Mierla 08 May '23

08 May '23

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual … [View More]

1 1

git:master:f9cbe7ad: pkg/kamailio/deb: version set 5.8.0~dev0 [skip ci]
by Victor Seva 04 May '23

04 May '23

Module: kamailio Branch: master Commit: f9cbe7ad01331e97852872c29b612409bf571c8d URL: https://github.com/kamailio/kamailio/commit/f9cbe7ad01331e97852872c29b61240… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-05-04T21:46:22+02:00 pkg/kamailio/deb: version set 5.8.0~dev0 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/… [View More]

1 0

git:5.7:14cb08ed: pkg/kamailio/deb: version set 5.7.0~rc0 [skip ci]
by Victor Seva 04 May '23

04 May '23

Module: kamailio Branch: 5.7 Commit: 14cb08ed98740bd286b89edb2b0555aebd7d69c2 URL: https://github.com/kamailio/kamailio/commit/14cb08ed98740bd286b89edb2b0555a… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-05-04T21:44:23+02:00 pkg/kamailio/deb: version set 5.7.0~rc0 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/… [View More]

1 0

[kamailio/kamailio] lcr: crash on ki_load_gws*() if called via KEMI (Issue #3435)
by Victor Seva 04 May '23

04 May '23

### Description crash happens if `lcr_id` passed to any of the functions ``KSR.lcr.load_gws*()`` is not defined in the lcr_gw table. ### Debugging Data ``` Core was generated by `/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f /etc/kamailio/kamailio.cfg'. Program terminated with signal SIGSEGV, Segmentation fault. (gdb) bt #0 ki_load_gws_furi (_m=0x7f1e66521100, lcr_id=3, ruri_user=0x7ffe1f856360, from_uri=0x7ffe1f856370) at lcr_mod.c:2312 #1 0x00007f1e65d8ca35 in … [View More]sr_apy_kemi_exec_func_ex (ket=0x7f1e655c27f0 <sr_kemi_lcr_exports+144>, self=0x7f1e60ecd090, args=0x7f1e60dd07c0, idx=544) at apy_kemi.c:1354 #2 0x00007f1e65d90477 in sr_apy_kemi_exec_func (self=0x7f1e60ecd090, args=0x7f1e60dd07c0, idx=544) at apy_kemi.c:1829 #3 0x00007f1e65d9b6ff in sr_apy_kemi_exec_func_544 (self=0x7f1e60ecd090, args=0x7f1e60dd07c0) at apy_kemi_export.c:4395 #4 0x00007f1e658d4c74 in ?? () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0 #5 0x00007f1e6588ea50 in _PyObject_MakeTpCall () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0 #6 0x00007f1e658402f2 in _PyEval_EvalFrameDefault () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0 #7 0x00007f1e65837033 in ?? () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0 #8 0x00007f1e6583f4b7 in _PyEval_EvalFrameDefault () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0 #9 0x00007f1e65837033 in ?? () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0 #10 0x00007f1e6583f4b7 in _PyEval_EvalFrameDefault () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0 #11 0x00007f1e65837033 in ?? () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0 #12 0x00007f1e658916a4 in ?? () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0 #13 0x00007f1e65da52fc in apy_exec (_msg=0x7f1e66521100, fname=0x7f1e65dae11d "ksr_request_route", fparam=0x0, emode=1) at python_exec.c:139 #14 0x00007f1e65d62cae in sr_kemi_config_engine_python (msg=0x7f1e66521100, rtype=1, rname=0x0, rparam=0x0) at apy_kemi.c:66 #15 0x000056247fc0a6e4 in sr_kemi_route (keng=0x562480066420 <_sr_kemi_eng_list>, msg=0x7f1e66521100, rtype=1, ename=0x0, edata=0x0) at core/kemi.c:3784 #16 0x000056247fc9da66 in receive_msg (buf=0x562480105280 <buf> "INVITE sip:0031686807515@34.91.122.173 SIP/2.0\r\nRecord-Route: <sip:94.247.7.211;lr;ftag=tj0p4Q1r8H5ap>\r\nVia: SIP/2.0/UDP 94.247.7.211;TH=div;branch=z9hG4bKdc26.e6a724746d6ff0bf5231906a5f1c8734.0\r\nVia:"..., len=1202, rcv_info=0x7ffe1f857090) at core/receive.c:502 #17 0x000056247fe01a5d in udp_rcv_loop () at core/udp_server.c:544 #18 0x000056247fb1a09b in main_loop () at main.c:1722 #19 0x000056247fb2720c in main (argc=10, argv=0x7ffe1f857ab8) at main.c:3078 (gdb) p lcr_count_param $1 = 1 (gdb) p lcr_id $2 = 3 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3435 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3435(a)github.com> [View Less]

4 7

Development is open for future release of v5.8.x series
by Daniel-Constantin Mierla 04 May '23

04 May '23

Hello, the branch 5.7 was created, therefore the master branch is open for adding new features, to be part of future release series v5.8.x (or whatever version is decided for next series). Any bug fix committed to master that applies to 5.7.x or older stable branches should be backported as usual with "git cherry-pick -x ..." to appropriate branches like 5.7 or 5.6. Expect that v5.7.0 will be released in a few weeks from now. Based on the workflow used during the past years, the next future … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2023