sr-dev May 2023

sr-dev@lists.kamailio.org

16 participants
322 discussions

git:master:e6dcc146: auth_radius: print radius config path on failure to load

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e6dcc14646f00aa71fc08368b268e7356d3343c7 URL: https://github.com/kamailio/kamailio/commit/e6dcc14646f00aa71fc08368b268e73… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-05-11T08:16:09+02:00 auth_radius: print radius config path on failure to load --- Modified: src/modules/auth_radius/auth_radius.c --- Diff: https://github.com/kamailio/kamailio/commit/e6dcc14646f00aa71fc08368b268e73… Patch: https://github.com/kamailio/kamailio/commit/e6dcc14646f00aa71fc08368b268e73… --- diff --git a/src/modules/auth_radius/auth_radius.c b/src/modules/auth_radius/auth_radius.c index 387f58d30d1..cbf5acaa5eb 100644 --- a/src/modules/auth_radius/auth_radius.c +++ b/src/modules/auth_radius/auth_radius.c @@ -120,7 +120,8 @@ static int mod_init(void) int n; if ((rh = rc_read_config(radius_config)) == NULL) { - LM_ERR("failed to open configuration file \n"); + LM_ERR("failed to open configuration file: %s\n", + (radius_config)?radius_config:"none"); return -1; }

1 year, 7 months

git:master:6d26825f: modules: readme files regenerated - pipelimit ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 6d26825f1e147713694fdb74d25e506b0626b249 URL: https://github.com/kamailio/kamailio/commit/6d26825f1e147713694fdb74d25e506… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-05-11T00:01:21+02:00 modules: readme files regenerated - pipelimit ... [skip ci] --- Modified: src/modules/pipelimit/README --- Diff: https://github.com/kamailio/kamailio/commit/6d26825f1e147713694fdb74d25e506… Patch: https://github.com/kamailio/kamailio/commit/6d26825f1e147713694fdb74d25e506… --- diff --git a/src/modules/pipelimit/README b/src/modules/pipelimit/README index 18f5ff48214..717f28f6cd8 100644 --- a/src/modules/pipelimit/README +++ b/src/modules/pipelimit/README @@ -273,7 +273,7 @@ modparam("pipelimit", "plp_pipeid_column", "name") Name of 'limit' column. - Default value is ��limit��. + Default value is ��plimit��. Example 1.5. Set plp_limit_column parameter ...

1 year, 7 months

[kamailio/kamailio] pipelimit module - typo in documentation (Issue #3449)

by arkadiam

Module doc says: 4.5. plp_limit_column (string) Name of 'limit' column. Default value is “limit”. According to source src/modules/pipelimit/pl_db.c default value is plimit #define RLP_LIMIT_COL "plimit" So the doc should say: Default value is “plimit”. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3449 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3449(a)github.com>

1 year, 7 months

git:master:7438bfd8: pipelimit: fix documentation on default value of plp_limit_column [skip ci]

by Victor Seva

Module: kamailio Branch: master Commit: 7438bfd8405ab98f48a96138183675cf799c7386 URL: https://github.com/kamailio/kamailio/commit/7438bfd8405ab98f48a96138183675c… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-05-10T23:48:23+02:00 pipelimit: fix documentation on default value of plp_limit_column [skip ci] fixes #3449 --- Modified: src/modules/pipelimit/doc/pipelimit_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7438bfd8405ab98f48a96138183675c… Patch: https://github.com/kamailio/kamailio/commit/7438bfd8405ab98f48a96138183675c… --- diff --git a/src/modules/pipelimit/doc/pipelimit_admin.xml b/src/modules/pipelimit/doc/pipelimit_admin.xml index 3ddd69ce3e..ebcf861669 100644 --- a/src/modules/pipelimit/doc/pipelimit_admin.xml +++ b/src/modules/pipelimit/doc/pipelimit_admin.xml @@ -218,7 +218,7 @@ modparam("pipelimit", "plp_pipeid_column", "name") </para> <para> <emphasis> - Default value is <quote>limit</quote>. + Default value is <quote>plimit</quote>. </emphasis> </para> <example>

1 year, 7 months

[kamailio/kamailio] rtpengine: google sanitizer aligment warning (Issue #3058)

by sergey-safarov

``` bencode.c:149:14: runtime error: member access within misaligned address 0xffff9f18937f for type 'struct bencode_item_t', which requires 8 byte alignment 0xffff9f18937f: note: pointer points here 9f ff ff 00 00 14 00 00 00 00 00 00 00 98 1b 21 9f ff ff 00 00 f0 8b 9a fe ff ff 00 00 18 26 9c ^ bencode.c:50:64: runtime error: member access within misaligned address 0xffff9f18937f for type 'struct bencode_item_t', which requires 8 byte alignment 0xffff9f18937f: note: pointer points here 9f ff ff 00 00 14 00 00 00 00 00 00 00 98 1b 21 9f ff ff 00 00 f0 8b 9a fe ff ff 00 00 18 26 9c ^ bencode.c:50:54: runtime error: member access within misaligned address 0xffff9f18937f for type 'struct bencode_item_t', which requires 8 byte alignment 0xffff9f18937f: note: pointer points here 9f ff ff 00 00 14 00 00 00 00 00 00 00 98 1b 21 9f ff ff 00 00 f0 8b 9a fe ff ff 00 00 00 00 00 ^ bencode.c:50:48: runtime error: member access within misaligned address 0xffff9f18937f for type 'struct bencode_item_t', which requires 8 byte alignment 0xffff9f18937f: note: pointer points here 9f ff ff 00 00 14 00 00 00 00 00 00 00 98 1b 21 9f ff ff 00 00 f0 8b 9a fe ff ff 00 00 00 00 00 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3058 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3058(a)github.com>

1 year, 7 months

git:master:eca3bf75: registrar: do not walk xavp list twice to get tcp connection id

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: eca3bf7570290854561ecd4ef71dc093941e2d72 URL: https://github.com/kamailio/kamailio/commit/eca3bf7570290854561ecd4ef71dc09… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-05-10T13:38:23+02:00 registrar: do not walk xavp list twice to get tcp connection id --- Modified: src/modules/registrar/save.c --- Diff: https://github.com/kamailio/kamailio/commit/eca3bf7570290854561ecd4ef71dc09… Patch: https://github.com/kamailio/kamailio/commit/eca3bf7570290854561ecd4ef71dc09… --- diff --git a/src/modules/registrar/save.c b/src/modules/registrar/save.c index 878f22224b..15be2331b8 100644 --- a/src/modules/registrar/save.c +++ b/src/modules/registrar/save.c @@ -71,7 +71,11 @@ extern sruid_t _reg_sruid; static int q_override_msg_id; static qvalue_t q_override_value; -int reg_get_cfg_tcpconnid(void) + +/** + * + */ +static int reg_get_cfg_tcpconnid(void) { int n; sr_xavp_t *vavp=NULL; @@ -254,6 +258,7 @@ static inline ucontact_info_t* pack_ci( struct sip_msg* _m, contact_t* _c, static struct sip_msg *m = 0; static struct socket_info si = {0}; int_str val; + int tcid; if (_m!=0) { memset( &ci, 0, sizeof(ucontact_info_t)); @@ -298,9 +303,11 @@ static inline ucontact_info_t* pack_ci( struct sip_msg* _m, contact_t* _c, } else { ci.tcpconn_id = -1; } - /* if a tcp connectionid is set, use it */ - if (reg_get_cfg_tcpconnid()) - ci.tcpconn_id = reg_get_cfg_tcpconnid(); + /* if a tcp connectionid is set via xavp, use it */ + tcid = reg_get_cfg_tcpconnid(); + if(tcid > 0) { + ci.tcpconn_id = tcid; + } /* additional info from message */ if (parse_headers(_m, HDR_USERAGENT_F, 0) != -1 && _m->user_agent &&

1 year, 7 months

git:master:9326cff7: htable: use long types for expires operations

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 9326cff7f67604a27049ee1cae0c9a5b965efd9d URL: https://github.com/kamailio/kamailio/commit/9326cff7f67604a27049ee1cae0c9a5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-05-10T13:34:32+02:00 htable: use long types for expires operations --- Modified: src/modules/htable/ht_api.c Modified: src/modules/htable/ht_db.c --- Diff: https://github.com/kamailio/kamailio/commit/9326cff7f67604a27049ee1cae0c9a5… Patch: https://github.com/kamailio/kamailio/commit/9326cff7f67604a27049ee1cae0c9a5… --- diff --git a/src/modules/htable/ht_api.c b/src/modules/htable/ht_api.c index 13e29ae5cd..432d224aab 100644 --- a/src/modules/htable/ht_api.c +++ b/src/modules/htable/ht_api.c @@ -970,8 +970,8 @@ int ht_dbg(void) while(it) { LM_ERR("\tcell: %.*s\n", it->name.len, it->name.s); - LM_ERR("\thid: %u msize: %u flags: %d expire: %u\n", it->cellid, - it->msize, it->flags, (unsigned int)it->expire); + LM_ERR("\thid: %u msize: %u flags: %d expire: %llu\n", it->cellid, + it->msize, it->flags, (unsigned long long)it->expire); if(it->flags&AVP_VAL_STR) LM_ERR("\tv-s:%.*s\n", it->value.s.len, it->value.s.s); else @@ -1268,7 +1268,7 @@ int ht_set_cell_expire(ht_t *ht, str *name, int type, int_str *val) now = 0; if(val->n>0) now = time(NULL) + val->n; - LM_DBG("set auto-expire to %u (%ld)\n", (unsigned int)now, + LM_DBG("set auto-expire to %llu (%ld)\n", (unsigned long long)now, val->n); ht_slot_lock(ht, idx); diff --git a/src/modules/htable/ht_db.c b/src/modules/htable/ht_db.c index db2a52ce8b..2b2eb25bfd 100644 --- a/src/modules/htable/ht_db.c +++ b/src/modules/htable/ht_db.c @@ -196,7 +196,7 @@ int ht_db_load_table(ht_t *ht, str *dbtable, int mode) int i; int ret; int cnt; - int now; + long now; int ncols; int c; @@ -272,7 +272,7 @@ int ht_db_load_table(ht_t *ht, str *dbtable, int mode) pname.s = ""; n = 0; last_ktype = 0; - now = (int)time(NULL); + now = (long)time(NULL); do { for(i=0; i<RES_ROW_N(db_res); i++) {

1 year, 7 months

git:master:35e27960: cplc: use time_t field for proper storage size

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 35e279603f37aec4e8cba6a321726dfee958fc94 URL: https://github.com/kamailio/kamailio/commit/35e279603f37aec4e8cba6a321726df… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-05-10T12:04:08+02:00 cplc: use time_t field for proper storage size --- Modified: src/modules/cplc/cpl_run.h Modified: src/modules/cplc/cpl_switches.h --- Diff: https://github.com/kamailio/kamailio/commit/35e279603f37aec4e8cba6a321726df… Patch: https://github.com/kamailio/kamailio/commit/35e279603f37aec4e8cba6a321726df… --- diff --git a/src/modules/cplc/cpl_run.h b/src/modules/cplc/cpl_run.h index 6ec52beb708..f11db2a6a90 100644 --- a/src/modules/cplc/cpl_run.h +++ b/src/modules/cplc/cpl_run.h @@ -55,7 +55,7 @@ struct cpl_interpreter { str user; /* user */ str script; /* CPL script */ char *ip; /* instruction pointer */ - int recv_time; /* receiving time stamp */ + time_t recv_time; /* receiving time stamp */ struct sip_msg *msg; struct location *loc_set; /* location set */ /* pointers to the string-headers needed for switches; can point directly diff --git a/src/modules/cplc/cpl_switches.h b/src/modules/cplc/cpl_switches.h index e2d15bfbb36..19d26f7048c 100644 --- a/src/modules/cplc/cpl_switches.h +++ b/src/modules/cplc/cpl_switches.h @@ -689,8 +689,8 @@ static inline char *run_time_switch( struct cpl_interpreter *intr ) memset(&att, 0, sizeof(cpl_ac_tm_t)); memset(&trt, 0, sizeof(cpl_tmrec_t)); - LM_DBG("checking recv. time stamp <%d>\n", - intr->recv_time); + LM_DBG("checking recv. time stamp <%llu>\n", + (unsigned long long)intr->recv_time); switch (NR_OF_ATTR(intr->ip)) { case 1: p = ATTR_PTR(intr->ip);

1 year, 7 months

git:master:88a1340f: cnxcc: cast time_t to get rid of newer compiler warnings

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 88a1340f0a9ec3408a61625e3621be82a4975940 URL: https://github.com/kamailio/kamailio/commit/88a1340f0a9ec3408a61625e3621be8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-05-10T11:49:12+02:00 cnxcc: cast time_t to get rid of newer compiler warnings --- Modified: src/modules/cnxcc/cnxcc.h --- Diff: https://github.com/kamailio/kamailio/commit/88a1340f0a9ec3408a61625e3621be8… Patch: https://github.com/kamailio/kamailio/commit/88a1340f0a9ec3408a61625e3621be8… --- diff --git a/src/modules/cnxcc/cnxcc.h b/src/modules/cnxcc/cnxcc.h index 8c73dde2c9..e4ce5e2621 100644 --- a/src/modules/cnxcc/cnxcc.h +++ b/src/modules/cnxcc/cnxcc.h @@ -33,7 +33,7 @@ static inline unsigned int get_current_timestamp() { - return time(NULL); + return (unsigned int)(unsigned long long)time(NULL); } static inline int timestamp2isodt(str *dest, unsigned int timestamp)

1 year, 7 months

git:5.5:ce08c374: rtpengine: fix unaligned memory access

by Stefan Mititelu

Module: kamailio Branch: 5.5 Commit: ce08c374e46532591ce54e29f3629554e9e3b011 URL: https://github.com/kamailio/kamailio/commit/ce08c374e46532591ce54e29f362955… Author: Richard Fuchs <rfuchs(a)sipwise.com> Committer: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Date: 2023-05-10T11:07:51+03:00 rtpengine: fix unaligned memory access Make sure the pointers we return from our continuous memory buffer is always 64-bit aligned as it's used not only for strings, but also for structs/objects, and such unaligned memory access is undefined on some archs and flagged as such by ASAN. From https://github.com/sipwise/rtpengine/commit/ade8100d3b10308f1ff63f8cb06fdf2… fixes #3444 (cherry-picked from commit 43ac6b27d7ca7bc522f362c25ebb3c22ab918280) --- Modified: src/modules/rtpengine/bencode.c --- Diff: https://github.com/kamailio/kamailio/commit/ce08c374e46532591ce54e29f362955… Patch: https://github.com/kamailio/kamailio/commit/ce08c374e46532591ce54e29f362955… --- diff --git a/src/modules/rtpengine/bencode.c b/src/modules/rtpengine/bencode.c index 7a4b2ed0da2..cca17326242 100644 --- a/src/modules/rtpengine/bencode.c +++ b/src/modules/rtpengine/bencode.c @@ -12,6 +12,8 @@ #define BENCODE_HASH_BUCKETS 31 /* prime numbers work best */ +#define BENCODE_ALLOC_ALIGN 8 + struct __bencode_buffer_piece { char *tail; unsigned int left; @@ -76,7 +78,7 @@ static struct __bencode_buffer_piece *__bencode_piece_new(unsigned int size) { if (size < BENCODE_MIN_BUFFER_PIECE_LEN) size = BENCODE_MIN_BUFFER_PIECE_LEN; - ret = BENCODE_MALLOC(sizeof(*ret) + size); + ret = BENCODE_MALLOC(sizeof(*ret) + size + BENCODE_ALLOC_ALIGN); if (!ret) return NULL; @@ -99,6 +101,7 @@ int bencode_buffer_init(bencode_buffer_t *buf) { static void *__bencode_alloc(bencode_buffer_t *buf, unsigned int size) { struct __bencode_buffer_piece *piece; void *ret; + unsigned int align_size = ((size + BENCODE_ALLOC_ALIGN - 1) / BENCODE_ALLOC_ALIGN) * BENCODE_ALLOC_ALIGN; if (!buf) return NULL; @@ -121,9 +124,12 @@ static void *__bencode_alloc(bencode_buffer_t *buf, unsigned int size) { assert(size <= piece->left); alloc: - piece->left -= size; + if (piece->left >= align_size) + piece->left -= align_size; + else + piece->left = 0; ret = piece->tail; - piece->tail += size; + piece->tail += align_size; return ret; }

1 year, 7 months

← Newer
1
...
23
24
25
26
27
28
29
...
33
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2023