sr-dev May 2023

sr-dev@lists.kamailio.org

16 participants
322 discussions

git:master:4a20e2fd: kamctl/xhttp_pi: regenerated content from db xml schema

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 4a20e2fdb2f0c0fa7366f7646ed35b80df87fa07 URL: https://github.com/kamailio/kamailio/commit/4a20e2fdb2f0c0fa7366f7646ed35b8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-05-15T11:24:04+02:00 kamctl/xhttp_pi: regenerated content from db xml schema --- Modified: utils/kamctl/xhttp_pi/acc-mod Modified: utils/kamctl/xhttp_pi/alias_db-mod Modified: utils/kamctl/xhttp_pi/auth_db-mod Modified: utils/kamctl/xhttp_pi/avpops-mod Modified: utils/kamctl/xhttp_pi/carrierroute-mod Modified: utils/kamctl/xhttp_pi/cpl-mod Modified: utils/kamctl/xhttp_pi/dialog-mod Modified: utils/kamctl/xhttp_pi/dialplan-mod Modified: utils/kamctl/xhttp_pi/dispatcher-mod Modified: utils/kamctl/xhttp_pi/domain-mod Modified: utils/kamctl/xhttp_pi/domainpolicy-mod Modified: utils/kamctl/xhttp_pi/drouting-mod Modified: utils/kamctl/xhttp_pi/group-mod Modified: utils/kamctl/xhttp_pi/htable-mod Modified: utils/kamctl/xhttp_pi/imc-mod Modified: utils/kamctl/xhttp_pi/lcr-mod Modified: utils/kamctl/xhttp_pi/matrix-mod Modified: utils/kamctl/xhttp_pi/mohqueue-mod Modified: utils/kamctl/xhttp_pi/msilo-mod Modified: utils/kamctl/xhttp_pi/mtree-mod Modified: utils/kamctl/xhttp_pi/pdt-mod Modified: utils/kamctl/xhttp_pi/permissions-mod Modified: utils/kamctl/xhttp_pi/pi_framework.xml Modified: utils/kamctl/xhttp_pi/pipelimit-mod Modified: utils/kamctl/xhttp_pi/presence-mod Modified: utils/kamctl/xhttp_pi/purple-mod Modified: utils/kamctl/xhttp_pi/registrar-mod Modified: utils/kamctl/xhttp_pi/rls-mod Modified: utils/kamctl/xhttp_pi/rtpengine-mod Modified: utils/kamctl/xhttp_pi/rtpproxy-mod Modified: utils/kamctl/xhttp_pi/sca-mod Modified: utils/kamctl/xhttp_pi/secfilter-mod Modified: utils/kamctl/xhttp_pi/siptrace-mod Modified: utils/kamctl/xhttp_pi/speeddial-mod Modified: utils/kamctl/xhttp_pi/standard-mod Modified: utils/kamctl/xhttp_pi/topos-mod Modified: utils/kamctl/xhttp_pi/uac-mod Modified: utils/kamctl/xhttp_pi/uid_auth_db-mod Modified: utils/kamctl/xhttp_pi/uid_avp_db-mod Modified: utils/kamctl/xhttp_pi/uid_domain-mod Modified: utils/kamctl/xhttp_pi/uid_gflags-mod Modified: utils/kamctl/xhttp_pi/uid_uri_db-mod Modified: utils/kamctl/xhttp_pi/uri_db-mod Modified: utils/kamctl/xhttp_pi/userblocklist-mod Modified: utils/kamctl/xhttp_pi/usrloc-mod --- Diff: https://github.com/kamailio/kamailio/commit/4a20e2fdb2f0c0fa7366f7646ed35b8… Patch: https://github.com/kamailio/kamailio/commit/4a20e2fdb2f0c0fa7366f7646ed35b8…

1 year, 7 months

SHM and PKG memory mixup during tracing in onsend_route for localy generated request leads to memory leaks

by Ovidiu Sas

Hello, While troubleshooting a memory leak, I noticed that we are mixing SHM memory with PKG memory during hep tracing. When the dispatcher timer is scheduled for OPTION pings, the ds_ping_set() is called and the tm module is engaged to handle the ping. dispatcher: dispatcher.c ds_ping_set() tmb.t_request Inside the tm module, a new cell is created and the SIP message is cloned for further processing via sip_msg_cloner() and later on the onsend_route is engaged: tm: uac.c: request() t_uac() t_uac_with_ids() t_uac_prepare() new_cell->uas.request = sip_msg_cloner(&lreq, &sip_msg_len); core: sip_msg_shm_clone() (we are cloning the msg in SHM) send_prepared_request_impl(SHM pointer) run_onsend(SHM pointer) Inside the onsend_route we call siptrace() and we go like this: siptrace: siptrace_send.c sip_trace_prepare(SHM pointer) parser: parse_from_header(SHM pointer) we allocate PKG mem that is leaked parse_to() parse_addr_spec() we allocate PKG mem that is leaked Later on, the SHM memory block is released by the free_cell_helper(): sip_msg_free_unsafe(dead_cell->uas.request); This was a misconfiguration, because the siptrace was configured to automatically mirror all SIP traffic and the call for siptrace() in the onsend_route was not necessary. Perhaps siptrace() should be a noop when trace_mode is not 0. Here are the siptrace params: loadmodule "siptrace.so" modparam("siptrace", "db_url", DBMYSQL) modparam("siptrace", "duplicate_uri", SIPTRACE_SVR_IP) modparam("siptrace", "send_sock_addr", SIPTRACE_OUT_IP) modparam("siptrace", "hep_mode_on", 1) modparam("siptrace", "hep_version", 3) modparam("siptrace", "trace_to_database", 0) modparam("siptrace", "trace_flag", 22) modparam("siptrace", "trace_on", 1) modparam("siptrace", "evcb_msg", "ksr_siptrace_msg") modparam("siptrace", "trace_mode", 1) This is happening on the latest version of kamailio 5.6. -ovidiu

1 year, 7 months

git:master:8f7c0893: modules: readme files regenerated - tls ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 8f7c0893f0c53b9f399cfa0989fecd9bd15b344d URL: https://github.com/kamailio/kamailio/commit/8f7c0893f0c53b9f399cfa0989fecd9… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-05-12T17:31:24+02:00 modules: readme files regenerated - tls ... [skip ci] --- Modified: src/modules/tls/README --- Diff: https://github.com/kamailio/kamailio/commit/8f7c0893f0c53b9f399cfa0989fecd9… Patch: https://github.com/kamailio/kamailio/commit/8f7c0893f0c53b9f399cfa0989fecd9… --- diff --git a/src/modules/tls/README b/src/modules/tls/README index 7198c455293..f721ba81d61 100644 --- a/src/modules/tls/README +++ b/src/modules/tls/README @@ -676,11 +676,12 @@ Place holder If RFC 3261 conformance is desired, at least TLSv1 must be used. For compatibility with older clients SSLv23 is the option, but again, be - aware of security concerns, SSLv2/3 being considered very insecure by - 2014. For current information about what's considered secure, please - consult, IETF BCP 195, currently RFC 7525 - "Recommendations for Secure - Use of Transport Layer Security (TLS) and Datagram Transport Layer - Security (DTLS)" + aware of security concerns, SSLv2/3 as well as TLS v1.0 and v1.1 are + being considered very insecure and are therefore deprecated since March + 2021 (RFC 8996). For current information about what's considered + secure, please consult, IETF BCP 195, currently RFC 9325 - + "Recommendations for Secure Use of Transport Layer Security (TLS) and + Datagram Transport Layer Security (DTLS)" Example 1.3. Set tls_method parameter ...

1 year, 7 months

git:master:1fd57e57: tls: update documentation (TLS v1.0 & 1.1 deprecation)

by Henning Westerholt

Module: kamailio Branch: master Commit: 1fd57e57255cb7f6d76326a255a3a91d107cba89 URL: https://github.com/kamailio/kamailio/commit/1fd57e57255cb7f6d76326a255a3a91… Author: Florian Floimair <f.floimair(a)commend.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-05-12T17:26:03+02:00 tls: update documentation (TLS v1.0 & 1.1 deprecation) --- Modified: src/modules/tls/doc/params.xml --- Diff: https://github.com/kamailio/kamailio/commit/1fd57e57255cb7f6d76326a255a3a91… Patch: https://github.com/kamailio/kamailio/commit/1fd57e57255cb7f6d76326a255a3a91… --- diff --git a/src/modules/tls/doc/params.xml b/src/modules/tls/doc/params.xml index b51e5ce99a0..1e8ca7f3e94 100644 --- a/src/modules/tls/doc/params.xml +++ b/src/modules/tls/doc/params.xml @@ -105,9 +105,10 @@ <para> If RFC 3261 conformance is desired, at least TLSv1 must be used. For compatibility with older clients SSLv23 is the option, but again, be aware - of security concerns, SSLv2/3 being considered very insecure by 2014. + of security concerns, SSLv2/3 as well as TLS v1.0 and v1.1 are being considered very insecure + and are therefore deprecated since March 2021 (RFC 8996). For current information about what's considered secure, please consult, - IETF BCP 195, currently RFC 7525 - "Recommendations for Secure Use of + IETF BCP 195, currently RFC 9325 - "Recommendations for Secure Use of Transport Layer Security (TLS) and Datagram Transport Layer Security (DTLS)" </para> <example>

1 year, 7 months

Manage authentication with kamailio

by aaron.soto＠dialapplet.com

Hi everybody, I'm new to Kamailio and I want to know the best way to manage SIP authentication with a Kamailio proxy. Currently, I'm using htables with DDI as key_value, but this configuration is causing my database to become overly extensive. For each DDI, I need three rows in the database. If anyone can suggest a better solution to handle the issue of large credential tables, I would greatly appreciate it. Thank you.

1 year, 7 months

[kamailio/kamailio] lost: HELD request with broken sip uri (Issue #3426)

by sergey-safarov

### Description Kamailio sending HELD request with broken sip uri when the INVITE message contains a display name or display name with special character "&". ``` P-Asserted-Identity: "User &" <sip:+12001112233@206.147.236.78:5060> ``` or ``` P-Asserted-Identity: "User" <sip:+12001112233@206.147.236.78:5060> ``` For the first case, HELD request body looks like ```xml <?xml version="1.0" encoding="UTF-8"?> <locationRequest xmlns="urn:ietf:params:xml:ns:geopriv:held" responseTime="5000"> <locationType exact="true">geodetic locationURI</locationType> <device xmlns="urn:ietf:params:xml:ns:geopriv:held:id"> <uri /> </device> </locationRequest> ``` Here `uri` element is empty. For the second case, HELD request body looks like (ident formatted) ``` <?xml version="1.0" encoding="UTF-8"?> <locationRequest xmlns="urn:ietf:params:xml:ns:geopriv:held" responseTime="5000"> <locationType exact="true">geodetic locationURI</locationType> <device xmlns="urn:ietf:params:xml:ns:geopriv:held:id"> <uri>"User" <sip:+12001112233@206.147.236.78:5060></uri> </device> </locationRequest> ``` In [HELD schema](https://datatracker.ietf.org/doc/html/rfc6155#section-6) the 'uri' element specified as ``` <xs:element name="uri" type="xs:anyURI"/> ``` For me looks like here `display name` cannot be used. Moreover, if an inbound call does not contain `P-Asserted-Identity` header then `lost` properly extracts uri from the `From` header. For me look like need to improve `P-Asserted-Identity` parsing in the `lost` module and properly extract uri from header value. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3426 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3426(a)github.com>

1 year, 7 months

git:5.6:8d7dee8b: modules: readme files regenerated - modules ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: 5.6 Commit: 8d7dee8bb08ef7f44394c0add165dea66bf9c316 URL: https://github.com/kamailio/kamailio/commit/8d7dee8bb08ef7f44394c0add165dea… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-05-11T14:31:43+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/geoip2/README --- Diff: https://github.com/kamailio/kamailio/commit/8d7dee8bb08ef7f44394c0add165dea… Patch: https://github.com/kamailio/kamailio/commit/8d7dee8bb08ef7f44394c0add165dea… --- diff --git a/src/modules/geoip2/README b/src/modules/geoip2/README index 80691c55168..a8ebc98adfb 100644 --- a/src/modules/geoip2/README +++ b/src/modules/geoip2/README @@ -30,6 +30,7 @@ Henning Westerholt 3. Parameters 3.1. path (string) + 3.2. resid (str) 4. Functions @@ -44,8 +45,9 @@ Henning Westerholt List of Examples 1.1. Set path parameter - 1.2. geoip2_match usage - 1.3. geoip2.reload usage + 1.2. Set resid parameter + 1.3. geoip2_match usage + 1.4. geoip2.reload usage Chapter 1. Admin Guide @@ -60,6 +62,7 @@ Chapter 1. Admin Guide 3. Parameters 3.1. path (string) + 3.2. resid (str) 4. Functions @@ -115,6 +118,7 @@ Chapter 1. Admin Guide 3. Parameters 3.1. path (string) + 3.2. resid (str) 3.1. path (string) @@ -127,6 +131,23 @@ Chapter 1. Admin Guide modparam("geoip2", "path", "/usr/local/share/GeoIP/GeoLite2-City.mmdb") ... +3.2. resid (str) + + Preregister result container id during initialization, enabling the use + of the module in KEMI scripts. In native Kamailio.cfg file, + registration is done when parsing config and finding variables. + + Default value is �� (empty). + + Example 1.2. Set resid parameter +... +modparam("geoip2", "resid", "src") +... +if(geoip2_match("$si", "src")) { + ... +} +... + 4. Functions 4.1. geoip2_match(ipaddr, pvc) @@ -135,8 +156,10 @@ modparam("geoip2", "path", "/usr/local/share/GeoIP/GeoLite2-City.mmdb") Match ipaddr against the GeoIP database and set the pvc container. The function has to be called before accessing a key via: $gip2(pvc=>key). + At least one function needs to be present that access the pvc + container, otherwise this function will not work. - Example 1.2. geoip2_match usage + Example 1.3. geoip2_match usage ... if(geoip2_match("$si", "src")) xlog("SIP message from: $gip2(src=>cc)\n"); @@ -151,7 +174,7 @@ if(geoip2_match("$si", "src")) Reload the internal GeoIP database. This is necessary after the database file has been changed on the disk. - Example 1.3. geoip2.reload usage + Example 1.4. geoip2.reload usage ... kamcmd geoip2.reload ...

1 year, 7 months

Re: [SR-Users] GeoIP2 and KEMI

by Henning Westerholt

(also adding sr-dev) Hello, I have cherry-picked the commit. Its technically a new feature addition, which would not qualify for a backport to a stable branch. On the other hand, if KEMI is not usable without that, we certainly import KEMI changes into stable branches so it would qualify for a backport. This unclear status was probably the reason that it was not included into the backports so far. If somebody is against adding this change, I will revert it of course. I did not cherry-picked it to 5.5 branch. Cheers, Henning From: Michal Hajek <michal.hajek(a)daktela.com> Sent: Donnerstag, 11. Mai 2023 12:16 To: Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org> Subject: [SR-Users] GeoIP2 and KEMI Hello, why this commit is not in branch 5.6? https://github.com/kamailio/kamailio/commit/21817906853140322c701f8cbb82010… Without this, is KEMI and GeoIP2 incompatible. Thanks Michal

1 year, 7 months

git:5.6:916abbb5: geoip2: new parameter to register result id to get pv work in kemi

by Henning Westerholt

Module: kamailio Branch: 5.6 Commit: 916abbb53aff22ff9214b9f7677904564ca021b3 URL: https://github.com/kamailio/kamailio/commit/916abbb53aff22ff9214b9f76779045… Author: Vadim Gaysin <gaysin(a)zvonok.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-05-11T12:18:41Z geoip2: new parameter to register result id to get pv work in kemi (cherry picked from commit 21817906853140322c701f8cbb8201049d2b58f0) --- Modified: src/modules/geoip2/doc/geoip2_admin.xml Modified: src/modules/geoip2/geoip2_mod.c Modified: src/modules/geoip2/geoip2_pv.c Modified: src/modules/geoip2/geoip2_pv.h --- Diff: https://github.com/kamailio/kamailio/commit/916abbb53aff22ff9214b9f76779045… Patch: https://github.com/kamailio/kamailio/commit/916abbb53aff22ff9214b9f76779045… --- diff --git a/src/modules/geoip2/doc/geoip2_admin.xml b/src/modules/geoip2/doc/geoip2_admin.xml index a82b1a9a293..76e59055fa2 100644 --- a/src/modules/geoip2/doc/geoip2_admin.xml +++ b/src/modules/geoip2/doc/geoip2_admin.xml @@ -81,7 +81,7 @@ </section> <section> <title>Parameters</title> - <section> + <section id="geoip2.p.path"> <title><varname>path</varname> (string)</title> <para> Path to the GeoIP2 database file. @@ -100,7 +100,31 @@ modparam("geoip2", "path", "/usr/local/share/GeoIP/GeoLite2-City.mmdb") </programlisting> </example> </section> - + <section id="geoip2.p.resid"> + <title><varname>resid</varname> (str)</title> + <para> + Preregister result container id during initialization, enabling the use + of the module in KEMI scripts. In native &kamailio;.cfg file, registration + is done when parsing config and finding variables. + </para> + <para> + <emphasis> + Default value is <quote></quote> (empty). + </emphasis> + </para> + <example> + <title>Set <varname>resid</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("geoip2", "resid", "src") +... +if(geoip2_match("$si", "src")) { + ... +} +... +</programlisting> + </example> + </section> </section> <section> diff --git a/src/modules/geoip2/geoip2_mod.c b/src/modules/geoip2/geoip2_mod.c index 96285592425..b5b5e7db6c4 100644 --- a/src/modules/geoip2/geoip2_mod.c +++ b/src/modules/geoip2/geoip2_mod.c @@ -44,6 +44,7 @@ static int geoip2_rpc_init(void); static int w_geoip2_match(struct sip_msg* msg, char* str1, char* str2); static int geoip2_match(sip_msg_t *msg, str *tomatch, str *pvclass); +static int geoip2_resid_param(modparam_t type, void* val); static pv_export_t mod_pvs[] = { { {"gip2", sizeof("gip2")-1}, PVT_OTHER, pv_get_geoip2, 0, @@ -51,7 +52,6 @@ static pv_export_t mod_pvs[] = { { {0, 0}, 0, 0, 0, 0, 0, 0, 0 } }; - static cmd_export_t cmds[]={ {"geoip2_match", (cmd_function)w_geoip2_match, 2, fixup_spve_spve, 0, ANY_ROUTE}, @@ -59,7 +59,8 @@ static cmd_export_t cmds[]={ }; static param_export_t params[]={ - {"path", PARAM_STRING, &geoip2_path}, + {"path", PARAM_STRING, &geoip2_path}, + {"resid", PARAM_STR|PARAM_USE_FUNC, &geoip2_resid_param}, {0, 0, 0} }; @@ -76,7 +77,6 @@ struct module_exports exports = { mod_destroy /* module destroy function */ }; - /** * init module function */ @@ -113,6 +113,19 @@ static void mod_destroy(void) geoip2_destroy_pv(); } +static int geoip2_resid_param(modparam_t type, void* val) +{ + str rname; + + rname = *((str*)val); + if(sr_geoip2_add_resid(&rname) < 0) { + LM_ERR("failed to register result container with id: %.*s\n", + rname.len, rname.s); + return -1; + } + return 0; +} + static int geoip2_match(sip_msg_t *msg, str *tomatch, str *pvclass) { geoip2_pv_reset(pvclass); @@ -192,4 +205,4 @@ static sr_kemi_t sr_kemi_geoip2_exports[] = { int mod_register(char *path, int *dlflags, void *p1, void *p2) { sr_kemi_modules_add(sr_kemi_geoip2_exports); return 0; -} \ No newline at end of file +} diff --git a/src/modules/geoip2/geoip2_pv.c b/src/modules/geoip2/geoip2_pv.c index ff427f259f6..71b814e9ad3 100644 --- a/src/modules/geoip2/geoip2_pv.c +++ b/src/modules/geoip2/geoip2_pv.c @@ -124,6 +124,13 @@ sr_geoip2_item_t *sr_geoip2_add_item(str *name) return it; } +int sr_geoip2_add_resid(str *rname) +{ + if(sr_geoip2_add_item(rname)==NULL) { + return -1; + } + return 0; +} int pv_parse_geoip2_name(pv_spec_p sp, str *in) { diff --git a/src/modules/geoip2/geoip2_pv.h b/src/modules/geoip2/geoip2_pv.h index d616461673a..fbd25c00440 100644 --- a/src/modules/geoip2/geoip2_pv.h +++ b/src/modules/geoip2/geoip2_pv.h @@ -35,6 +35,7 @@ void geoip2_destroy_pv(void); int geoip2_reload_pv(char *path); void geoip2_pv_reset(str *pvclass); int geoip2_update_pv(str *tomatch, str *pvclass); +int sr_geoip2_add_resid(str *rname); #endif

1 year, 7 months

Re: [SR-Users] kamailio/kamailio-ci docker image

by Henning Westerholt

Hi Sergey, I am not the one that works on the Kamailio docker packages, so others can probably comment more. But I think after we switched the kamailio docker to the github repository, it also make sense to move the other smaller “special” Kamailio repositories from docker hub to github. Just to have it in one place and to be less confusing for users and developers. Cheers, Henning From: Sergey Safarov <s.safarov(a)gmail.com> Sent: Freitag, 28. April 2023 19:59 To: Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org> Subject: [SR-Users] kamailio/kamailio-ci docker image Hi Now "kamailio/kamailio-ci" docker image is pushed to GitHub packages<https://github.com/kamailio/kamailio-ci/pkgs/container/kamailio-ci> only. I have a question should we completely switch to using the GitHub docker repo and remove the "kamailio/kamailio-ci" docker image from Docker Hub<https://hub.docker.com/repository/docker/kamailio/kamailio-ci>? Or required to push the "kamailio/kamailio-ci" docker image to GitHub packages and Docker Hub repos? Sergey

1 year, 7 months

← Newer
1
...
22
23
24
25
26
27
28
...
33
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2023