sr-dev February 2023

sr-dev@lists.kamailio.org

10 participants
293 discussions

git:master:51fa3da9: core: typos in comments and EoL after log when parse msg fails

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 51fa3da96c1eacd4d679598a3305180c9e818cfb URL: https://github.com/kamailio/kamailio/commit/51fa3da96c1eacd4d679598a3305180… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-03T09:28:58+01:00 core: typos in comments and EoL after log when parse msg fails - GH #3348 --- Modified: src/core/msg_translator.c --- Diff: https://github.com/kamailio/kamailio/commit/51fa3da96c1eacd4d679598a3305180… Patch: https://github.com/kamailio/kamailio/commit/51fa3da96c1eacd4d679598a3305180… --- diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c index bc1b9736df..3ab6fae472 100644 --- a/src/core/msg_translator.c +++ b/src/core/msg_translator.c @@ -53,7 +53,7 @@ * lookup is performed on the host part and the reply is sent to the * resulting ip. If a port is present or the host part is an ip address * the dns lookup will be a "normal" one (A or AAAA). - * - if rport is present, it's value will be used as the destination port + * - if rport is present, its value will be used as the destination port * (and this will also disable srv lookups) * - if no port is present the destination port will be taken from the srv * lookup. If the srv lookup fails or is not performed (e.g. ip address @@ -1459,7 +1459,7 @@ void process_lumps( struct sip_msg* msg, /* skip len bytes from orig msg */ s_offset+=t->len; } else if (t->op==LUMP_DEL && flag == FLAG_MSG_LUMPS_ONLY) { - /* copy lump value and indent as necessarely */ + /* copy lump value and indent as necessarily */ memcpy(new_buf+offset, orig + t->u.offset, t->len); offset+=t->len; if (new_buf[offset-1] != '\n') { @@ -1592,7 +1592,7 @@ static inline int adjust_clen(struct sip_msg* msg, int body_delta, int proto) /* The body has been changed, try to find * existing Content-Length */ - /* no need for Content-Length if it's and UDP packet and + /* no need for Content-Length if it's an UDP packet and * it hasn't Content-Length already */ if (msg->content_length==0){ /* content-length doesn't exist, append it */ @@ -1938,7 +1938,7 @@ int check_boundaries(struct sip_msg *msg, struct dest_info *send_info) /** builds a request in memory from another sip request. * * Side-effects: - it adds lumps to the msg which are _not_ cleaned. - * The added lumps are HDR_VIA_T (almost always added), HDR_CONTENLENGTH_T + * The added lumps are HDR_VIA_T (almost always added), HDR_CONTENTLENGTH_T * and HDR_ROUTE_T (when a Route: header is added as a result of a non-null * msg->path_vec). * - it might change send_info->proto and send_info->send_socket @@ -2109,7 +2109,7 @@ char * build_req_buf_from_sip_req(struct sip_msg* msg, } received_buf = NULL; } - /* if rport needs to be updated, delete it if present and add it's value */ + /* if rport needs to be updated, delete it if present and add its value */ if (rport_buf){ if (msg->via1->rport){ /* rport already present */ via_insert_param=del_lump(msg, @@ -3075,7 +3075,7 @@ char* create_via_hf(unsigned int *len, /* builds a char* buffer from message headers without body * first line is excluded in case of skip_first_line=1 - * error is set -1 if the memory allocation failes + * error is set -1 if the memory allocation fails */ char * build_only_headers( struct sip_msg* msg, int skip_first_line, unsigned int *returned_len, @@ -3127,7 +3127,7 @@ char * build_only_headers( struct sip_msg* msg, int skip_first_line, } /* builds a char* buffer from message body - * error is set -1 if the memory allocation failes + * error is set -1 if the memory allocation fails */ char * build_body( struct sip_msg* msg, unsigned int *returned_len, @@ -3253,7 +3253,7 @@ int build_sip_msg_from_buf(struct sip_msg *msg, char *buf, int len, msg->buf = buf; msg->len = len; if (parse_msg(buf, len, msg)!=0) { - LM_ERR("parsing failed"); + LM_ERR("parsing failed\n"); return -1; } msg->set_global_address=default_global_address;

1 year, 2 months

[kamailio/kamailio] doc/tutorials/dns: USE_NAPTR is on by default (PR #3353)

by Дилян Палаузов

My reading of the original text: > USE_NAPTR - if defined the naptr lookup support will be compiled in. > NAPTR support still has to be enabled from Kamailio's config file (it's > off by default). was that USE_NAPTR was by default off (undefined). This change clarifies that by default USE_NAPTR is defined, but naptr support is by default disabled from the cofiguration file. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3353 -- Commit Summary -- * doc/tutorials/dns: USE_NAPTR is on by default -- File Changes -- M doc/tutorials/dns.txt (13) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3353.patch https://github.com/kamailio/kamailio/pull/3353.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3353 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3353(a)github.com>

1 year, 2 months

git:master:8821d9a9: doc/tutorials/dns: USE_NAPTR is on by default

by Henning Westerholt

Module: kamailio Branch: master Commit: 8821d9a91ab3823d5b1d78d84332ab9965a7c6b2 URL: https://github.com/kamailio/kamailio/commit/8821d9a91ab3823d5b1d78d84332ab9… Author: �� <git-dpa(a)aegee.org> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-02-01T18:06:44+01:00 doc/tutorials/dns: USE_NAPTR is on by default --- Modified: doc/tutorials/dns.txt --- Diff: https://github.com/kamailio/kamailio/commit/8821d9a91ab3823d5b1d78d84332ab9… Patch: https://github.com/kamailio/kamailio/commit/8821d9a91ab3823d5b1d78d84332ab9… --- diff --git a/doc/tutorials/dns.txt b/doc/tutorials/dns.txt index 442f0900f6..0cfebff3f7 100644 --- a/doc/tutorials/dns.txt +++ b/doc/tutorials/dns.txt @@ -143,7 +143,7 @@ DNS Resolver Options If set to yes - the additional part is checked against the search list. The maximum time a DNS request can take (before failing) is: - (dns_retr_time*dns_retr_no) * (search_list_domains) If dns_try_ipv6 is yes, + (dns_retr_time*dns_retr_no) * (search_list_domains). If dns_try_ipv6 is yes, multiply it again by 2. The option combination that produces the "fastest" DNS resolver config @@ -167,8 +167,9 @@ DNS Resolver Compile Options ---------------------------- USE_NAPTR - if defined the naptr lookup support will be compiled in. - NAPTR support still has to be enabled from Kamailio's config file (it's - off by default). + NAPTR support still has to be enabled from Kamailio's config file. + USE_NAPTR is defined by default. NAPTR support is disabled from the + config file by default. DNS Cache and Failover Config Variables @@ -182,7 +183,7 @@ DNS Cache and Failover Config Variables server. Default: on. - use_dns_failover = on |off - if on and sending a request fails (due to not + use_dns_failover = on | off - if on and sending a request fails (due to not being allowed from an onsend_route, send failure, blocklisted destination or, when using tm, invite timeout), and the destination resolves to multiple ip addresses and/or multiple SRV records, the send will be @@ -260,7 +261,7 @@ DNS Cache and Failover Config Variables Default: no dns_cache_init = on | off - if off, the DNS cache is not initialized - at startup and cannot be enabled runtime, that saves some memory. + at startup and cannot be enabled at runtime, that saves some memory. Default: on DNS Cache Compile Options @@ -301,7 +302,7 @@ DNS Cache Compile Options If this option is not defined (experimental), everything in the AR section will be added to the cache. - Note: To remove a compile options, edit Kamailio's Makefile.defs and remove it + Note: To remove a compile options, edit Kamailio's Makefile.defs and remove it from DEFS list. To add a compile options add it to the make command line, e.g.: make proper; make all extra_defs=-DUSE_DNS_FAILOVER or for a permanent solution, edit Makefile.defs and add it to DEFS

1 year, 2 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2023