Module: kamailio
Branch: master
Commit: 609b689e6071c272e8230901e95db183334391d1
URL: https://github.com/kamailio/kamailio/commit/609b689e6071c272e8230901e95db18…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2023-02-03T09:46:31+01:00
modules: readme files regenerated - rr ... [skip ci]
---
Modified: src/modules/rr/README
---
Diff: https://github.com/kamailio/kamailio/commit/609b689e6071c272e8230901e95db18…
Patch: https://github.com/kamailio/kamailio/commit/609b689e6071c272e8230901e95db18…
---
diff --git a/src/modules/rr/README b/src/modules/rr/README
index c31f0c8ee8..efaf0df8e3 100644
--- a/src/modules/rr/README
+++ b/src/modules/rr/README
@@ -152,13 +152,13 @@ Chapter 1. Admin Guide
1. Overview
- The module contains record routing logic
+ The module contains record routing logic.
2. Dialog support
Kamailio is basically only a transaction stateful proxy, without any
dialog support build in. There are many features/services which
- actually requires a dialog awareness, like storing the information in
+ actually require a dialog awareness, like storing the information in
the dialog creation stage, information which will be used during the
whole dialog existence.
@@ -327,7 +327,7 @@ modparam("rr", "enable_socket_mismatch_warning", 0)
4.6. custom_user_avp (avp string)
- When enable_username is enabled, a call to record_route will add the
+ When add_username is enabled, a call to record_route will add the
username of the RequestURI to the Record-Route URI. This parameter
allows you to setup an AVP with which you can customise the username to
be added in the Record-Route URI.
@@ -614,7 +614,7 @@ add_rr_param(";nat=yes");
The function checks if the URI parameters of the local Route header
(corresponding to the local server) matches the given regular
- expression. It must be call after loose_route() (see Section 5.1,
+ expression. It must be called after loose_route() (see Section 5.1,
���loose_route()���).
Meaning of the parameters is as follows:
@@ -780,7 +780,7 @@ record_route_advertised_address("1.2.3.4:5090");
The function checks for the request ���msg��� if the URI parameters of the
local Route header (corresponding to the local server) matches the
- given regular expression ���re���. It must be call after the loose_route
+ given regular expression ���re���. It must be called after the loose_route
was done.
The function returns 0 on success. Otherwise, -1 is returned.
@@ -796,7 +796,7 @@ record_route_advertised_address("1.2.3.4:5090");
The function checks the flow direction of the request ���msg���. As for
checking it's used the ���ftag��� Route header parameter, the
append_fromtag (see ??? module parameter must be enables. Also this
- must be call only after the loose_route is done.
+ must be called only after the loose_route is done.
The function returns 0 if the ���dir��� is the same with the request's flow
direction. Otherwise, -1 is returned.
@@ -808,9 +808,9 @@ record_route_advertised_address("1.2.3.4:5090");
1.6. get_route_param(msg, name, val)
- The function search in to the ���msg���'s Route header parameters the
+ The function searches in the ���msg���'s Route header parameters the
parameter called ���name��� and returns its value into ���val���. It must be
- call only after the loose_route is done.
+ called only after the loose_route is done.
The function returns 0 if parameter was found (even if it has no
value). Otherwise, -1 is returned.
@@ -824,7 +824,7 @@ record_route_advertised_address("1.2.3.4:5090");
1.7. register_rrcb(callback, param)
- The function register a new callback (along with its parameter). The
+ The function registers a new callback (along with its parameter). The
callback will be called when a loose route will be performed for the
local address.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3344
-- Commit Summary --
* test/ : typos
* snmpstats: typos
-- File Changes --
M src/modules/snmpstats/doc/snmpstats_admin.xml (8)
M src/modules/snmpstats/hashTable.c (2)
M src/modules/snmpstats/hashTable.h (2)
M src/modules/snmpstats/interprocess_buffer.c (6)
M src/modules/snmpstats/mibs/KAMAILIO-MIB (10)
M src/modules/snmpstats/mibs/KAMAILIO-REG-MIB (6)
M src/modules/snmpstats/mibs/KAMAILIO-SIP-COMMON-MIB (4)
M src/modules/snmpstats/mibs/KAMAILIO-SIP-SERVER-MIB (6)
M src/modules/snmpstats/mibs/KAMAILIO-TC (4)
M src/modules/snmpstats/snmpObjects.c (2)
M src/modules/snmpstats/snmpSIPContactTable.c (2)
M src/modules/snmpstats/snmpSIPContactTable.h (2)
M src/modules/snmpstats/snmpSIPRegUserLookupTable.c (4)
M src/modules/snmpstats/snmpSIPRegUserLookupTable.h (2)
M src/modules/snmpstats/snmpSIPStatusCodesTable.c (4)
M src/modules/snmpstats/sub_agent.c (2)
M test/misc/cfg/mobile61.cfg (2)
M test/misc/cfg/nc.cfg (8)
M test/misc/cfg/struas.cfg (2)
M test/misc/cfg/test1.cfg (2)
M test/misc/cfg/use_jab.cfg (2)
M test/misc/code/atomic_test.c (2)
M test/misc/code/atomic_test2.c (2)
M test/misc/code/basex.c (2)
M test/misc/code/shoot.c (2)
M test/misc/code/shoot2.c (2)
M test/misc/code/udp.c (6)
M test/misc/extra/gcc_version.sh (2)
M test/unit/5.cfg (8)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3344.patchhttps://github.com/kamailio/kamailio/pull/3344.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3344
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3344(a)github.com>
The documentation of rr.custom_user_avp speaks about option `enable_username`, but there is no such option.
I assume the documentation means `add_username`.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3352
-- Commit Summary --
* rr: doc — replace enable_username with add_username
-- File Changes --
M src/modules/rr/doc/rr_admin.xml (6)
M src/modules/rr/doc/rr_devel.xml (10)
M src/modules/rr/loose.c (10)
M src/modules/rr/loose.h (6)
M src/modules/rr/rr_mod.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3352.patchhttps://github.com/kamailio/kamailio/pull/3352.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3352
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3352(a)github.com>
Module: kamailio
Branch: master
Commit: 022fa0cfc75d150fde219b8ae4f9a99b3fa2f132
URL: https://github.com/kamailio/kamailio/commit/022fa0cfc75d150fde219b8ae4f9a99…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-02-03T09:38:26+01:00
rr: doc - fixed typos and use the proper param name add_username instead of enable_username
---
Modified: src/modules/rr/doc/rr_admin.xml
Modified: src/modules/rr/doc/rr_devel.xml
---
Diff: https://github.com/kamailio/kamailio/commit/022fa0cfc75d150fde219b8ae4f9a99…
Patch: https://github.com/kamailio/kamailio/commit/022fa0cfc75d150fde219b8ae4f9a99…
---
diff --git a/src/modules/rr/doc/rr_admin.xml b/src/modules/rr/doc/rr_admin.xml
index 691e3d07df..2456450e4f 100644
--- a/src/modules/rr/doc/rr_admin.xml
+++ b/src/modules/rr/doc/rr_admin.xml
@@ -12,7 +12,7 @@
<section>
<title>Overview</title>
- <para>The module contains record routing logic</para>
+ <para>The module contains record routing logic.</para>
</section>
<section id="RR-dialog-id">
@@ -20,7 +20,7 @@
<para>&kamailio; is basically <emphasis>only</emphasis> a transaction
stateful proxy, without any dialog support build in. There are many
- features/services which actually requires a dialog awareness, like storing
+ features/services which actually require a dialog awareness, like storing
the information in the dialog creation stage, information which will be
used during the whole dialog existence.</para>
@@ -246,7 +246,7 @@ modparam("rr", "enable_socket_mismatch_warning", 0)
<section id="rr.p.custom_user_avp">
<title><varname>custom_user_avp</varname> (avp string)</title>
- <para>When enable_username is enabled, a call to record_route will add
+ <para>When add_username is enabled, a call to record_route will add
the username of the RequestURI to the Record-Route URI. This parameter
allows you to setup an AVP with which you can customise the username to
be added in the Record-Route URI.</para>
@@ -664,7 +664,7 @@ add_rr_param(";nat=yes");
<para>The function checks if the URI parameters of the local Route
header (corresponding to the local server) matches the given regular
- expression. It must be call after loose_route() (see <xref
+ expression. It must be called after loose_route() (see <xref
linkend="rr.f.loose_route"/>).</para>
<para>Meaning of the parameters is as follows:</para>
diff --git a/src/modules/rr/doc/rr_devel.xml b/src/modules/rr/doc/rr_devel.xml
index 516eb5a3aa..aa6f9c4b69 100644
--- a/src/modules/rr/doc/rr_devel.xml
+++ b/src/modules/rr/doc/rr_devel.xml
@@ -128,7 +128,7 @@ record_route_advertised_address("1.2.3.4:5090");
The function checks for the request <quote>msg</quote> if the URI
parameters of the local Route header (corresponding to the local
server) matches the given regular expression <quote>re</quote>.
- It must be call after the loose_route was done.
+ It must be called after the loose_route was done.
</para>
<para>
The function returns 0 on success. Otherwise, -1 is returned.
@@ -157,7 +157,7 @@ record_route_advertised_address("1.2.3.4:5090");
<quote>msg</quote>. As for checking it's used the <quote>ftag</quote>
Route header parameter, the append_fromtag (see
<xref linkend="append-fromtag-id"/> module parameter
- must be enables. Also this must be call only after the loose_route is
+ must be enables. Also this must be called only after the loose_route is
done.
</para>
<para>
@@ -185,9 +185,9 @@ record_route_advertised_address("1.2.3.4:5090");
<function moreinfo="none">get_route_param(msg, name, val)</function>
</title>
<para>
- The function search in to the <quote>msg</quote>'s Route header
+ The function searches in the <quote>msg</quote>'s Route header
parameters the parameter called <quote>name</quote> and returns its
- value into <quote>val</quote>. It must be call only after the
+ value into <quote>val</quote>. It must be called only after the
loose_route is done.
</para>
<para>
@@ -220,7 +220,7 @@ record_route_advertised_address("1.2.3.4:5090");
<function moreinfo="none">register_rrcb(callback, param)</function>
</title>
<para>
- The function register a new callback (along with its parameter). The
+ The function registers a new callback (along with its parameter). The
callback will be called when a loose route will be performed for the
local address.
</para>
I use Kamailio with `log_stderror=yes`. When Kamailio receives confirmation from the Websocket reverse proxy, it logs on stderr
```
23(24) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 22)
23(24) ERROR: <core> [core/parser/msg_parser.c:749]: parse_msg(): ERROR: parse_msg: message=<HTTP/1.1 101 Switching Protocols
Sia: SIP/2.0/TCP 111.11.111.11:47418
Sec-WebSocket-Protocol: sip
Upgrade: websocket
Connection: upgrade
Sec-WebSocket-Accept: Ak3/c/aw3iyHnFkDDHabw1iXcqY=
Content-Length: 0
>
23(24) ERROR: <core> [core/msg_translator.c:3256]: build_sip_msg_from_buf(): parsing failed
```
Without the included `\n` here the subsequent messages are logged on the same line as `parsing failed`.
For the record, I use this NGINX configuration:
```
location /sip {
proxy_http_version 1.1;
proxy_set_header "Accept-Encoding" ""; # delete header before sending it to Kamailio
proxy_set_header "Pragma" "";
proxy_set_header "Cache-control" "";
proxy_set_header "User-Agent" "";
proxy_set_header Host $host;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection $http_connection;
proxy_pass http://123.12.123.12:5060;
proxy_read_timeout 86400;
}
```
and it leads to that unparsable message above.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3348
-- Commit Summary --
* core: msg_translator.c put new line after «parsing failed» error message
-- File Changes --
M src/core/msg_translator.c (16)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3348.patchhttps://github.com/kamailio/kamailio/pull/3348.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3348
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3348(a)github.com>