sr-dev June 2022

sr-dev@lists.kamailio.org

20 participants
280 discussions

git:master:1ac02d9f: dispatcher: fix for checking reply code class rule

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 1ac02d9f0b436602cfc8bf72037ca7f84be3d67f URL: https://github.com/kamailio/kamailio/commit/1ac02d9f0b436602cfc8bf72037ca7f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-06-03T11:21:14+02:00 dispatcher: fix for checking reply code class rule --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/1ac02d9f0b436602cfc8bf72037ca7f… Patch: https://github.com/kamailio/kamailio/commit/1ac02d9f0b436602cfc8bf72037ca7f… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 827d925ed8..30620553a4 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -1247,7 +1247,7 @@ int ds_ping_check_rplcode(int code) } } else { /* reply class */ - if(((*ds_ping_reply_codes)[i] / 100) == code) { + if((*ds_ping_reply_codes)[i] == code / 100) { return 1; } }

1 year, 11 months

[kamailio/kamailio] ims_qos: fix compilation warning (PR #3127)

by Atanas Bakalov

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3127 -- Commit Summary -- * ims_qos: fix compilation warning -- File Changes -- M src/modules/ims_qos/rx_aar.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3127.patch https://github.com/kamailio/kamailio/pull/3127.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3127 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3127(a)github.com>

1 year, 11 months

git:master:bd4cc486: ims_qos: fix compilation warning

by Atanas Bakalov

Module: kamailio Branch: master Commit: bd4cc486879616d502362dd464b04d7d3c2865c4 URL: https://github.com/kamailio/kamailio/commit/bd4cc486879616d502362dd464b04d7… Author: Atanas Bakalov <atanas(a)wgtwo.com> Committer: Atanas Bakalov <atanas(a)wgtwo.com> Date: 2022-05-31T12:52:49+02:00 ims_qos: fix compilation warning --- Modified: src/modules/ims_qos/rx_aar.c --- Diff: https://github.com/kamailio/kamailio/commit/bd4cc486879616d502362dd464b04d7… Patch: https://github.com/kamailio/kamailio/commit/bd4cc486879616d502362dd464b04d7… --- diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c index afd7ba3e74..da4a0e42dd 100644 --- a/src/modules/ims_qos/rx_aar.c +++ b/src/modules/ims_qos/rx_aar.c @@ -53,6 +53,7 @@ #include "../cdp_avp/cdp_avp_mod.h" #include "../../modules/ims_dialog/dlg_load.h" +#include "../../modules/ims_dialog/dlg_hash.h" #include "../../modules/tm/tm_load.h" #include "../ims_usrloc_pcscf/usrloc.h" #include "rx_authdata.h"

1 year, 11 months

git:master:0550a3d4: Merge pull request #3127 from atanasdb/ims_qos_fix

by GitHub

Module: kamailio Branch: master Commit: 0550a3d44b2addc160b6a20bd2c9bf2831187400 URL: https://github.com/kamailio/kamailio/commit/0550a3d44b2addc160b6a20bd2c9bf2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2022-06-02T21:17:11+02:00 Merge pull request #3127 from atanasdb/ims_qos_fix ims_qos: fix module loading crash --- Modified: src/modules/ims_qos/rx_aar.c --- Diff: https://github.com/kamailio/kamailio/commit/0550a3d44b2addc160b6a20bd2c9bf2… Patch: https://github.com/kamailio/kamailio/commit/0550a3d44b2addc160b6a20bd2c9bf2… --- diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c index afd7ba3e74..da4a0e42dd 100644 --- a/src/modules/ims_qos/rx_aar.c +++ b/src/modules/ims_qos/rx_aar.c @@ -53,6 +53,7 @@ #include "../cdp_avp/cdp_avp_mod.h" #include "../../modules/ims_dialog/dlg_load.h" +#include "../../modules/ims_dialog/dlg_hash.h" #include "../../modules/tm/tm_load.h" #include "../ims_usrloc_pcscf/usrloc.h" #include "rx_authdata.h"

1 year, 11 months

[kamailio/kamailio] DNS Failover try next destinations on receiving code other than 503 (Issue #3122)

by patrickarton

### Description All ips destination of DNS Failover are tried only if either no response or 503 response. I woud like to try others ips when receiving code other than 503 response (example when receiving 408 from a previous one).  ### Expected behavior #### Actual observed behavior #### Debugging Data ``` None ``` #### Log Messages  ``` None ``` #### SIP Traffic  ``` obvious ``` ### Possible Solutions A possible solution will be to modify the reply_received function of tm's t_reply.c file. ``` int reply_received( struct sip_msg *p_msg ) { } ```  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3122 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3122(a)github.com>

1 year, 11 months

[kamailio/kamailio] 'kamcmd ul.dump' error on 5.6 (Issue #3123)

by MayamaTakeshi

### Description If there are no usrloc registrations, all is good: ``` [root@lab002194-flip-server install]$ kamcmd ul.dump { Domains: { Domain: { Domain: devflip_location Size: 1024 AoRs: { } Stats: { Records: 0 Max-Slots: 0 } } } } ```` But if there are registered SIP endpoints, we get: ``` [root@lab002194-flip-server install]$ kamcmd ul.dump { Domains: { Domain: { Domain: devflip_location Size: 1024 AoRs: { Info: { AoR: oweruaodsiflwosdfjoe(a)lsjfoasjdfosaodfsdfafolekodc.com HashID: -2013386516 Contacts: { Contact: { Address: sip:oweruaodsiflwosdfjoe@10.255.255.195:6060 Expires: 96 Q: 0 ERROR:: while parsing the record 14, @140: ff : bad record ``` #### Reproduction Just register some SIP endpoints against kamailio and issue 'kamcmd ul.dump' ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.6.0 (x86_64/linux) 61e86a flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 61e86a compiled on 06:54:55 May 26 2022 with gcc 10.2.1 ``` * **Operating System**:  ``` [root@lab002194-flip-server kamailio-5.6]$ lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye [root@lab002194-flip-server kamailio-5.6]$ uname -a Linux lab002194-flip-server 5.10.0-14-amd64 #1 SMP Debian 5.10.113-1 (2022-04-29) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3123 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3123(a)github.com>

1 year, 11 months

git:5.6:92e0dc0c: ctl: skip checking end tag for BINRPC_T_DOUBLE values

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.6 Commit: 92e0dc0c3a8fe17d18fad944bfeb3d9102c2ca6c URL: https://github.com/kamailio/kamailio/commit/92e0dc0c3a8fe17d18fad944bfeb3d9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-06-02T13:49:05+02:00 ctl: skip checking end tag for BINRPC_T_DOUBLE values - related to GH #3123 (cherry picked from commit 72901b7822c5684f8a10faa91118f3fd6de6c01a) --- Modified: src/modules/ctl/binrpc.h --- Diff: https://github.com/kamailio/kamailio/commit/92e0dc0c3a8fe17d18fad944bfeb3d9… Patch: https://github.com/kamailio/kamailio/commit/92e0dc0c3a8fe17d18fad944bfeb3d9… --- diff --git a/src/modules/ctl/binrpc.h b/src/modules/ctl/binrpc.h index da4524878c..94ced22ea2 100644 --- a/src/modules/ctl/binrpc.h +++ b/src/modules/ctl/binrpc.h @@ -730,7 +730,7 @@ inline static unsigned char* binrpc_read_record(struct binrpc_parse_ctx* ctx, type=*p & 0xf; len=*p>>4; p++; - if (len & 8){ + if ((type!=BINRPC_T_DOUBLE) && (len & 8)){ end_tag=1; /* possible end mark for array or structs */ /* we have to read len bytes and use them as the new len */ p=binrpc_read_int(&len, len&7, p, end, err);

1 year, 11 months

git:master:72901b78: ctl: skip checking end tag for BINRPC_T_DOUBLE values

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 72901b7822c5684f8a10faa91118f3fd6de6c01a URL: https://github.com/kamailio/kamailio/commit/72901b7822c5684f8a10faa91118f3f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-06-02T12:48:38+02:00 ctl: skip checking end tag for BINRPC_T_DOUBLE values - related to GH #3123 --- Modified: src/modules/ctl/binrpc.h --- Diff: https://github.com/kamailio/kamailio/commit/72901b7822c5684f8a10faa91118f3f… Patch: https://github.com/kamailio/kamailio/commit/72901b7822c5684f8a10faa91118f3f… --- diff --git a/src/modules/ctl/binrpc.h b/src/modules/ctl/binrpc.h index da4524878c..94ced22ea2 100644 --- a/src/modules/ctl/binrpc.h +++ b/src/modules/ctl/binrpc.h @@ -730,7 +730,7 @@ inline static unsigned char* binrpc_read_record(struct binrpc_parse_ctx* ctx, type=*p & 0xf; len=*p>>4; p++; - if (len & 8){ + if ((type!=BINRPC_T_DOUBLE) && (len & 8)){ end_tag=1; /* possible end mark for array or structs */ /* we have to read len bytes and use them as the new len */ p=binrpc_read_int(&len, len&7, p, end, err);

1 year, 11 months

git:master:a81266d3: modules: readme files regenerated - ims_ipsec_pcscf ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: a81266d38d500dfc7f7fda4c3903d375fabe8d24 URL: https://github.com/kamailio/kamailio/commit/a81266d38d500dfc7f7fda4c3903d37… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-06-01T18:16:21+02:00 modules: readme files regenerated - ims_ipsec_pcscf ... [skip ci] --- Modified: src/modules/ims_ipsec_pcscf/README --- Diff: https://github.com/kamailio/kamailio/commit/a81266d38d500dfc7f7fda4c3903d37… Patch: https://github.com/kamailio/kamailio/commit/a81266d38d500dfc7f7fda4c3903d37… --- diff --git a/src/modules/ims_ipsec_pcscf/README b/src/modules/ims_ipsec_pcscf/README index 4a1aba9a15..d895e972a5 100644 --- a/src/modules/ims_ipsec_pcscf/README +++ b/src/modules/ims_ipsec_pcscf/README @@ -314,6 +314,8 @@ ipsec_create("location", "1"); + 0x20 (32) - do not reset the destination URI. + 0x40 (64) - use user equipment client port as target for TCP requests. + + 0x80 (128) - set transport parameter in the new dst uri for + TCP requests. This is an optional parameter, default value - 0. Example 1.12. ipsec_forward

1 year, 11 months

git:master:f3bdccdf: ims_ipsec_pcscf: docs for the ipsec_forward() flag to set tcp transport parameter

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f3bdccdf08acde773aaa5731bcf47b8ec7fa798b URL: https://github.com/kamailio/kamailio/commit/f3bdccdf08acde773aaa5731bcf47b8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-06-01T18:15:43+02:00 ims_ipsec_pcscf: docs for the ipsec_forward() flag to set tcp transport parameter --- Modified: src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/f3bdccdf08acde773aaa5731bcf47b8… Patch: https://github.com/kamailio/kamailio/commit/f3bdccdf08acde773aaa5731bcf47b8… --- diff --git a/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml b/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml index e602275960..ea1fc34ca9 100644 --- a/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml +++ b/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml @@ -319,6 +319,11 @@ ipsec_create("location", "1"); <emphasis>0x40</emphasis> (64) - use user equipment client port as target for TCP requests. </para> </listitem> + <listitem> + <para> + <emphasis>0x80</emphasis> (128) - set transport parameter in the new dst uri for TCP requests. + </para> + </listitem> </itemizedlist> </para> <para>

1 year, 11 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2022