sr-dev June 2022

sr-dev@lists.kamailio.org

20 participants
282 discussions

[kamailio/kamailio] Crash when length($uac_req(callid)) > 128 (Issue #3135)
by hance2010 07 Jun '22

07 Jun '22

### Description Crash when length($uac_req(callid)) > 128 ### Troubleshooting #### Reproduction ``` function send_options() local KAM_DOMAIN = "192.168.100.131" -- length(callid) is 129 local callid = "0123456789-0123456789-0123456789-0123456789-0123456789-0123456789-0123456789-0123456789-0123456789-0123456789-0123456789-0000000" local tu = "sip:1001@" .. KAM_DOMAIN local sut = "sip:192.168.100.132:5080" KSR.pv.sets("$uac_req(method)", "OPTIONS") KSR.pv.sets("$uac_req(callid)", callid) KSR.pv.sets("$uac_req(furi)", "sip:" .. "kamailio" .. "@" .. KAM_DOMAIN) KSR.pv.sets("$uac_req(ruri)", tu) KSR.pv.sets("$uac_req(turi)", tu) KSR.pv.sets("$uac_req(ouri)", sut) KSR.pv.seti("$uac_req(evroute)", 1) KSR.uac.uac_req_send() end ``` #### Debugging Data  #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions https://github.com/kamailio/kamailio/blob/5.5/src/modules/uac/uac_send.c#L4… check len ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` Kamailio5.5.4 ``` * **Operating System**:  ``` Debian11 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3135 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3135(a)github.com>

2 2

git:5.4:fb20b043: uac: check new callid value for setting $uac_req() field
by Daniel-Constantin Mierla 07 Jun '22

07 Jun '22

Module: kamailio Branch: 5.4 Commit: fb20b043862b5146f4e4ea34e921a334783ad03d URL: https://github.com/kamailio/kamailio/commit/fb20b043862b5146f4e4ea34e921a33… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-06-07T09:19:41+02:00 uac: check new callid value for setting $uac_req() field - GH #3135 (cherry picked from commit 0eeb4cc61f4a340ef5f8d4acf1d4ea20eb711f73) (cherry picked from commit 69b4b6222edd43a935524e69497c1e7ab1148488) (cherry picked from commit 4694656f12179f9bdc6a5d608c45487d67a3aee0) --- Modified: src/modules/uac/uac_send.c --- Diff: https://github.com/kamailio/kamailio/commit/fb20b043862b5146f4e4ea34e921a33… Patch: https://github.com/kamailio/kamailio/commit/fb20b043862b5146f4e4ea34e921a33… --- diff --git a/src/modules/uac/uac_send.c b/src/modules/uac/uac_send.c index d906a1c27f..0161f667ed 100644 --- a/src/modules/uac/uac_send.c +++ b/src/modules/uac/uac_send.c @@ -422,6 +422,11 @@ int pv_set_uac_req(struct sip_msg* msg, pv_param_t *param, LM_ERR("Invalid value type\n"); return -1; } + if(tval->rs.len>=128) + { + LM_ERR("Value size too big\n"); + return -1; + } memcpy(_uac_req.s_callid.s, tval->rs.s, tval->rs.len); _uac_req.s_callid.s[tval->rs.len] = '\0'; _uac_req.s_callid.len = tval->rs.len;

1 0

git:5.5:4694656f: uac: check new callid value for setting $uac_req() field
by Daniel-Constantin Mierla 07 Jun '22

07 Jun '22

Module: kamailio Branch: 5.5 Commit: 4694656f12179f9bdc6a5d608c45487d67a3aee0 URL: https://github.com/kamailio/kamailio/commit/4694656f12179f9bdc6a5d608c45487… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-06-07T09:19:00+02:00 uac: check new callid value for setting $uac_req() field - GH #3135 (cherry picked from commit 0eeb4cc61f4a340ef5f8d4acf1d4ea20eb711f73) (cherry picked from commit 69b4b6222edd43a935524e69497c1e7ab1148488) --- Modified: src/modules/uac/uac_send.c --- Diff: https://github.com/kamailio/kamailio/commit/4694656f12179f9bdc6a5d608c45487… Patch: https://github.com/kamailio/kamailio/commit/4694656f12179f9bdc6a5d608c45487… --- diff --git a/src/modules/uac/uac_send.c b/src/modules/uac/uac_send.c index d906a1c27f..0161f667ed 100644 --- a/src/modules/uac/uac_send.c +++ b/src/modules/uac/uac_send.c @@ -422,6 +422,11 @@ int pv_set_uac_req(struct sip_msg* msg, pv_param_t *param, LM_ERR("Invalid value type\n"); return -1; } + if(tval->rs.len>=128) + { + LM_ERR("Value size too big\n"); + return -1; + } memcpy(_uac_req.s_callid.s, tval->rs.s, tval->rs.len); _uac_req.s_callid.s[tval->rs.len] = '\0'; _uac_req.s_callid.len = tval->rs.len;

1 0

git:5.6:69b4b622: uac: check new callid value for setting $uac_req() field
by Daniel-Constantin Mierla 07 Jun '22

07 Jun '22

Module: kamailio Branch: 5.6 Commit: 69b4b6222edd43a935524e69497c1e7ab1148488 URL: https://github.com/kamailio/kamailio/commit/69b4b6222edd43a935524e69497c1e7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-06-07T09:18:20+02:00 uac: check new callid value for setting $uac_req() field - GH #3135 (cherry picked from commit 0eeb4cc61f4a340ef5f8d4acf1d4ea20eb711f73) --- Modified: src/modules/uac/uac_send.c --- Diff: https://github.com/kamailio/kamailio/commit/69b4b6222edd43a935524e69497c1e7… Patch: https://github.com/kamailio/kamailio/commit/69b4b6222edd43a935524e69497c1e7… --- diff --git a/src/modules/uac/uac_send.c b/src/modules/uac/uac_send.c index be04464cae..7a43cdcc4d 100644 --- a/src/modules/uac/uac_send.c +++ b/src/modules/uac/uac_send.c @@ -424,6 +424,11 @@ int pv_set_uac_req(struct sip_msg* msg, pv_param_t *param, LM_ERR("Invalid value type\n"); return -1; } + if(tval->rs.len>=128) + { + LM_ERR("Value size too big\n"); + return -1; + } memcpy(_uac_req.s_callid.s, tval->rs.s, tval->rs.len); _uac_req.s_callid.s[tval->rs.len] = '\0'; _uac_req.s_callid.len = tval->rs.len;

1 0

git:master:0eeb4cc6: uac: check new callid value for setting $uac_req() field
by Daniel-Constantin Mierla 07 Jun '22

07 Jun '22

Module: kamailio Branch: master Commit: 0eeb4cc61f4a340ef5f8d4acf1d4ea20eb711f73 URL: https://github.com/kamailio/kamailio/commit/0eeb4cc61f4a340ef5f8d4acf1d4ea2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-06-07T09:15:35+02:00 uac: check new callid value for setting $uac_req() field - GH #3135 --- Modified: src/modules/uac/uac_send.c --- Diff: https://github.com/kamailio/kamailio/commit/0eeb4cc61f4a340ef5f8d4acf1d4ea2… Patch: https://github.com/kamailio/kamailio/commit/0eeb4cc61f4a340ef5f8d4acf1d4ea2… --- diff --git a/src/modules/uac/uac_send.c b/src/modules/uac/uac_send.c index be04464cae..7a43cdcc4d 100644 --- a/src/modules/uac/uac_send.c +++ b/src/modules/uac/uac_send.c @@ -424,6 +424,11 @@ int pv_set_uac_req(struct sip_msg* msg, pv_param_t *param, LM_ERR("Invalid value type\n"); return -1; } + if(tval->rs.len>=128) + { + LM_ERR("Value size too big\n"); + return -1; + } memcpy(_uac_req.s_callid.s, tval->rs.s, tval->rs.len); _uac_req.s_callid.s[tval->rs.len] = '\0'; _uac_req.s_callid.len = tval->rs.len;

1 0

[kamailio/kamailio] auth: Add pv_auth_check overload with second passwd parameter (PR #3126)
by Jon Bergli Heier 03 Jun '22

03 Jun '22

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This change modifies the `pv_auth_check` function to take an optional second password argument `passwd2`. The motivation for this change is to allow authenticating against two passwords, which is useful if you want to eg. rotate passwords periodically and still allow using the previous password during a transition period. You can technically do this with two calls to `pv_auth_check`, but with `nonce_count` enabled the first call will invalidate nc which will always cause the second call to fail. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3126 -- Commit Summary -- * auth: Add pv_auth_check overload with second passwd parameter -- File Changes -- M src/modules/auth/auth_mod.c (143) M src/modules/auth/doc/auth_functions.xml (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3126.patch https://github.com/kamailio/kamailio/pull/3126.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3126 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3126(a)github.com>

2 4

git:5.5:acdf0729: pkg/kamailio/deb: update Maintainer and Vcs fields [skip ci]
by Victor Seva 03 Jun '22

03 Jun '22

Module: kamailio Branch: 5.5 Commit: acdf07299ed28bc867b25de9f538d20faddac62c URL: https://github.com/kamailio/kamailio/commit/acdf07299ed28bc867b25de9f538d20… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-06-03T11:48:28+02:00 pkg/kamailio/deb: update Maintainer and Vcs fields [skip ci] In order to be more clear of who is the origin of the packages (cherry picked from commit 1225d7fda1d8c3eb82c403dcd0cd38d57fc4ad2a) --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bullseye/control Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/precise/control Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/wheezy/control Modified: pkg/kamailio/deb/xenial/control --- Diff: https://github.com/kamailio/kamailio/commit/acdf07299ed28bc867b25de9f538d20… Patch: https://github.com/kamailio/kamailio/commit/acdf07299ed28bc867b25de9f538d20…

1 0

git:5.6:30c14ac9: pkg/kamailio/deb: update Maintainer and Vcs fields [skip ci]
by Victor Seva 03 Jun '22

03 Jun '22

Module: kamailio Branch: 5.6 Commit: 30c14ac9d71414f11a7c4a48c292496cd5d0145f URL: https://github.com/kamailio/kamailio/commit/30c14ac9d71414f11a7c4a48c292496… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-06-03T11:45:30+02:00 pkg/kamailio/deb: update Maintainer and Vcs fields [skip ci] In order to be more clear of who is the origin of the packages (cherry picked from commit 1225d7fda1d8c3eb82c403dcd0cd38d57fc4ad2a) --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bookworm/control Modified: pkg/kamailio/deb/bullseye/control Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/precise/control Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/wheezy/control Modified: pkg/kamailio/deb/xenial/control --- Diff: https://github.com/kamailio/kamailio/commit/30c14ac9d71414f11a7c4a48c292496… Patch: https://github.com/kamailio/kamailio/commit/30c14ac9d71414f11a7c4a48c292496…

1 0

[kamailio/kamailio] tm: try next ip on receiving code other than 503 if dns failover (PR #3129)
by Mvondo Eric 03 Jun '22

03 Jun '22

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  By default when doing dns failover the tm module will try next ips only when receiving 503 code or no response. the new failover_reply_codes provides a way to try next ip when receiving specific codes or class code. for example try next ip even if the previous one returned 408 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3129 -- Commit Summary -- * Enable tm dns failover to try next ip on receiving code other than 503 -- File Changes -- M src/modules/tm/doc/params.xml (25) M src/modules/tm/t_funcs.c (11) M src/modules/tm/t_reply.c (12) M src/modules/tm/t_reply.h (4) M src/modules/tm/tm.c (139) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3129.patch https://github.com/kamailio/kamailio/pull/3129.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3129 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3129(a)github.com>

3 5

git:master:1225d7fd: pkg/kamailio/deb: update Maintainer and Vcs fields [skip ci]
by Victor Seva 03 Jun '22

03 Jun '22

Module: kamailio Branch: master Commit: 1225d7fda1d8c3eb82c403dcd0cd38d57fc4ad2a URL: https://github.com/kamailio/kamailio/commit/1225d7fda1d8c3eb82c403dcd0cd38d… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-06-03T11:40:46+02:00 pkg/kamailio/deb: update Maintainer and Vcs fields [skip ci] In order to be more clear of who is the origin of the packages --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bookworm/control Modified: pkg/kamailio/deb/bullseye/control Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/precise/control Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/wheezy/control Modified: pkg/kamailio/deb/xenial/control --- Diff: https://github.com/kamailio/kamailio/commit/1225d7fda1d8c3eb82c403dcd0cd38d… Patch: https://github.com/kamailio/kamailio/commit/1225d7fda1d8c3eb82c403dcd0cd38d…

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2022