sr-dev April 2022

sr-dev@lists.kamailio.org

17 participants
283 discussions

git:master:9fd0cae9: lrkproxy: init value for compiler warning

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 9fd0cae960b0795a5e511c37f768f0962b7a15c1 URL: https://github.com/kamailio/kamailio/commit/9fd0cae960b0795a5e511c37f768f09… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T13:10:23+02:00 lrkproxy: init value for compiler warning --- Modified: src/modules/lrkproxy/lrkproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/9fd0cae960b0795a5e511c37f768f09… Patch: https://github.com/kamailio/kamailio/commit/9fd0cae960b0795a5e511c37f768f09… --- diff --git a/src/modules/lrkproxy/lrkproxy.c b/src/modules/lrkproxy/lrkproxy.c index e30f4e976b..157048c350 100644 --- a/src/modules/lrkproxy/lrkproxy.c +++ b/src/modules/lrkproxy/lrkproxy.c @@ -1284,7 +1284,7 @@ static int change_media_sdp(sip_msg_t *msg, struct lrkproxy_hash_entry *e, const e->snat_ipv4.len = strlen(e->snat_ipv4.s); str current_port; - unsigned int snat_port; + unsigned int snat_port = 0; str2int(&e->dst_port, &snat_port);

2 years, 1 month

git:master:cfb50124: xcap_client: init structure

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: cfb50124e67b68552520e418a20ad2dfec96117b URL: https://github.com/kamailio/kamailio/commit/cfb50124e67b68552520e418a20ad2d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T13:04:37+02:00 xcap_client: init structure --- Modified: src/modules/xcap_client/xcap_client.c --- Diff: https://github.com/kamailio/kamailio/commit/cfb50124e67b68552520e418a20ad2d… Patch: https://github.com/kamailio/kamailio/commit/cfb50124e67b68552520e418a20ad2d… --- diff --git a/src/modules/xcap_client/xcap_client.c b/src/modules/xcap_client/xcap_client.c index 607628dbb4..efd434c2ab 100644 --- a/src/modules/xcap_client/xcap_client.c +++ b/src/modules/xcap_client/xcap_client.c @@ -309,6 +309,7 @@ int parse_doc_url(str doc_url, char** serv_addr, xcap_doc_sel_t* doc_sel) { char* sl, *str_type; + memset(doc_sel, 0, sizeof(xcap_doc_sel_t)); sl= strchr(doc_url.s, '/'); if(sl==NULL) { return -1;

2 years, 1 month

git:master:b5aae4f5: rls: safety check for dialog structur

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b5aae4f5afd07db114c3ff7712b484f743663b26 URL: https://github.com/kamailio/kamailio/commit/b5aae4f5afd07db114c3ff7712b484f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T12:15:12+02:00 rls: safety check for dialog structur --- Modified: src/modules/rls/resource_notify.c --- Diff: https://github.com/kamailio/kamailio/commit/b5aae4f5afd07db114c3ff7712b484f… Patch: https://github.com/kamailio/kamailio/commit/b5aae4f5afd07db114c3ff7712b484f… --- diff --git a/src/modules/rls/resource_notify.c b/src/modules/rls/resource_notify.c index d3ad4fd1fc..0343a5c665 100644 --- a/src/modules/rls/resource_notify.c +++ b/src/modules/rls/resource_notify.c @@ -420,8 +420,9 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, if(rlmi_doc) { - LM_DBG("timer_send_notify at end len_est = %d resource_added = %d\n", len_est, resource_added); - if (resource_added == 1) + LM_DBG("timer notify at end len_est = %d resource_added = %d dlg = %p\n", + len_est, resource_added, dialog); + if (resource_added == 1 && dialog != NULL) { send_notify(&rlmi_doc, buf, buf_len, bstr, dialog, hash_code); }

2 years, 1 month

git:master:f6620aa5: pkg/kamailio/deb: set version 5.6.0~pre1

by Victor Seva

Module: kamailio Branch: master Commit: f6620aa5fe7ef65ddd7fa232829ea9cfb3f0f774 URL: https://github.com/kamailio/kamailio/commit/f6620aa5fe7ef65ddd7fa232829ea9c… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-28T09:46:31+02:00 pkg/kamailio/deb: set version 5.6.0~pre1 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/f6620aa5fe7ef65ddd7fa232829ea9c… Patch: https://github.com/kamailio/kamailio/commit/f6620aa5fe7ef65ddd7fa232829ea9c…

2 years, 1 month

git:master:67da7301: topos: catch INFO requests during early dialog phase

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 67da7301f1eb74b6fff9e6e73b43f08dbc9c53bf URL: https://github.com/kamailio/kamailio/commit/67da7301f1eb74b6fff9e6e73b43f08… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T09:36:09+02:00 topos: catch INFO requests during early dialog phase --- Modified: src/modules/topos/tps_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/67da7301f1eb74b6fff9e6e73b43f08… Patch: https://github.com/kamailio/kamailio/commit/67da7301f1eb74b6fff9e6e73b43f08… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index cd781328e5..83d5f5fddf 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -837,7 +837,7 @@ int tps_request_received(sip_msg_t *msg, int dialog) goto error; } metid = get_cseq(msg)->method_id; - if((metid & (METHOD_BYE|METHOD_PRACK|METHOD_UPDATE)) + if((metid & (METHOD_BYE|METHOD_INFO|METHOD_PRACK|METHOD_UPDATE)) && stsd.b_contact.len <= 0) { /* no B-side contact, look for INVITE transaction record */ if(metid & (METHOD_BYE|METHOD_UPDATE)) {

2 years, 1 month

git:master:dc2ef8ed: async: proper pv function name

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: dc2ef8edaacb6947019cbde0a4c3ca238bee56c2 URL: https://github.com/kamailio/kamailio/commit/dc2ef8edaacb6947019cbde0a4c3ca2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T09:20:08+02:00 async: proper pv function name --- Modified: src/modules/async/async_sleep.c --- Diff: https://github.com/kamailio/kamailio/commit/dc2ef8edaacb6947019cbde0a4c3ca2… Patch: https://github.com/kamailio/kamailio/commit/dc2ef8edaacb6947019cbde0a4c3ca2… --- diff --git a/src/modules/async/async_sleep.c b/src/modules/async/async_sleep.c index b51887e351..02c3b8d488 100644 --- a/src/modules/async/async_sleep.c +++ b/src/modules/async/async_sleep.c @@ -649,7 +649,7 @@ int pv_get_async(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) /** * */ -int pv_parse_geoip_name(pv_spec_t *sp, str *in) +int pv_parse_async_name(pv_spec_t *sp, str *in) { if(sp==NULL || in==NULL || in->len<=0) return -1;

2 years, 1 month

git:master:bd71add6: Makefile.defs: version set to 5.6.0-pre1

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: bd71add6616e283f9f60a28785170c41c439f905 URL: https://github.com/kamailio/kamailio/commit/bd71add6616e283f9f60a28785170c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T09:02:07+02:00 Makefile.defs: version set to 5.6.0-pre1 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/bd71add6616e283f9f60a28785170c4… Patch: https://github.com/kamailio/kamailio/commit/bd71add6616e283f9f60a28785170c4… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 90aa777782..41c7b31652 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 6 SUBLEVEL = 0 -EXTRAVERSION = -pre0 +EXTRAVERSION = -pre1 # memory manager switcher # 0 - f_malloc (fast malloc)

2 years, 1 month

dlg_isflagset not working on CANCEL request

by David Escartín

hello all Using kamailio 5.4 version, we have seen that dlg_isflagset is not detecting a dialog flag set in the request route for the initial INVITE, when a CANCEL request arrives. We have applied this change to set the dialog context unique ide for this request. Since it's done on dlg_onreply, dlg_onroute and dlg_ontimeout functions. This way, dlg_get_by_iuid(&dctx->iuid) in the function ki_dlg_isflagset is not NULL and dialog flags are detected. Is this change correct? Or can it generate any kind of issues? diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index 3f8adefb79..f1df4a76c5 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -1255,6 +1255,9 @@ dlg_cell_t *dlg_lookup_msg_dialog(sip_msg_t *msg, unsigned int *dir) msg->callid->body.len, msg->callid->body.s); return NULL; } + if(msg->first_line.u.request.method_value == METHOD_CANCEL) { + dlg_set_ctx_iuid(dlg); + } if(dir) *dir = vdir; return dlg; } thanks a lot and regards David -- <http://www.sonoc.io/> David Escartín NOC engineer *www.sonoc.io* <http://www.sonoc.io/> [image: LinkedIn] <https://www.linkedin.com/company/sonoc> [image: Twitter] <https://twitter.com/sonoc_> [image: Facebook] <https://www.facebook.com/SONOCio/> This e-mail is for the exclusive use of its recipients and may contain business secrets or other confidential or privileged information. Any unauthorised use, copying, publication or distribution of this e-mail is strictly prohibited. If you are not the intended recipient, please inform us immediately by replying to this e-mail and delete it, including any attachments or copies on your system. In accordance with the GDPR (EU) 2016/679 and the LOPDGDD 3/2018, we inform you that this e-mail address and/or any other personal data you have provided us with will be treated by SONOC with absolute confidentiality and with the only purpose of providing you with the requested services, due to your condition as a client, supplier or because you have requested information from us at any time. These data will only be kept for as long as required to comply with legal obligations. You can exercise your rights at any time by sending an e-mail to: *dataprotection(a)sonoc.io* <dataprotection(a)sonoc.io>*.* <dataprotection(a)sonoc.io>

2 years, 1 month

git:master:a49a0177: cfgt: fix memory leaks

by Victor Seva

Module: kamailio Branch: master Commit: a49a017764bf7a6cdb3ff4ecd885b0a51c87dc15 URL: https://github.com/kamailio/kamailio/commit/a49a017764bf7a6cdb3ff4ecd885b0a… Author: Victor Seva <vseva(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-27T15:59:44+02:00 cfgt: fix memory leaks - free parsed message - free srjson object left behind + remove unused headers + remove unused function + parse only HDR_CALLID_F --- Modified: src/modules/cfgt/cfgt_int.c Modified: src/modules/cfgt/cfgt_json.c --- Diff: https://github.com/kamailio/kamailio/commit/a49a017764bf7a6cdb3ff4ecd885b0a… Patch: https://github.com/kamailio/kamailio/commit/a49a017764bf7a6cdb3ff4ecd885b0a…

2 years, 1 month

git:master:cfca8106: cfgt: improve detection of dynamic format

by Victor Seva

Module: kamailio Branch: master Commit: cfca81063c36ff2f1fe5578f89ccf9c0701e818a URL: https://github.com/kamailio/kamailio/commit/cfca81063c36ff2f1fe5578f89ccf9c… Author: Victor Seva <vseva(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-27T15:59:43+02:00 cfgt: improve detection of dynamic format * skip tm vars $T_* --- Modified: src/modules/cfgt/cfgt_json.c --- Diff: https://github.com/kamailio/kamailio/commit/cfca81063c36ff2f1fe5578f89ccf9c… Patch: https://github.com/kamailio/kamailio/commit/cfca81063c36ff2f1fe5578f89ccf9c… --- diff --git a/src/modules/cfgt/cfgt_json.c b/src/modules/cfgt/cfgt_json.c index b3dea63de4..d3aca8d305 100644 --- a/src/modules/cfgt/cfgt_json.c +++ b/src/modules/cfgt/cfgt_json.c @@ -43,6 +43,10 @@ int _cfgt_get_array_avp_vals(struct sip_msg *msg, pv_param_t *param, LM_ERR("invalid name\n"); return -1; } + if(name_type == 0 && avp_name.n == 0) { + LM_DBG("skip name_type:%d avp_name:%d\n", name_type, avp_name.n); + return 0; + } *jobj = srjson_CreateArray(jdoc); if(*jobj == NULL) { LM_ERR("cannot create json object\n"); @@ -286,8 +290,8 @@ int cfgt_get_json(struct sip_msg *msg, unsigned int mask, srjson_doc_t *jdoc, el = el->next; continue; } - if(srjson_GetArraySize(jdoc, jobj) == 0 - && !(mask & CFGT_DP_NULL)) { + if(jobj == NULL || (srjson_GetArraySize(jdoc, jobj) == 0 + && !(mask & CFGT_DP_NULL))) { el = el->next; continue; } @@ -314,6 +318,16 @@ int cfgt_get_json(struct sip_msg *msg, unsigned int mask, srjson_doc_t *jdoc, } snprintf(iname, 128, "$xavp(%.*s)", item_name.len, item_name.s); } else { + if(el->pvname.len > 3 && strncmp("$T_", el->pvname.s, 3) == 0) { + LM_DBG("skip tm var[%.*s]\n", el->pvname.len, el->pvname.s); + el = el->next; + continue; + } + if(strchr(el->pvname.s + 1, 36) != NULL) { + LM_DBG("skip dynamic format [%.*s]\n", el->pvname.len, el->pvname.s); + el = el->next; + continue; + } if(pv_get_spec_value(msg, &el->spec, &value) != 0) { LM_WARN("can't get value[%.*s]\n", el->pvname.len, el->pvname.s);

2 years, 1 month

← Newer
1
...
9
10
11
12
13
14
15
...
29
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2022