sr-dev April 2022

sr-dev@lists.kamailio.org

17 participants
290 discussions

git:master:2799782c: mqueue: add mqueue_mode modparam
by Daniel-Constantin Mierla 01 Apr '22

01 Apr '22

Module: kamailio Branch: master Commit: 2799782c530927de5db3c69df18b8248b8055ee2 URL: https://github.com/kamailio/kamailio/commit/2799782c530927de5db3c69df18b824… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-01T14:01:41+02:00 mqueue: add mqueue_mode modparam --- Modified: src/modules/mqueue/doc/mqueue_admin.xml Modified: src/modules/mqueue/mqueue_api.c Modified: src/modules/mqueue/mqueue_api.h Modified: src/modules/mqueue/mqueue_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/2799782c530927de5db3c69df18b824… Patch: https://github.com/kamailio/kamailio/commit/2799782c530927de5db3c69df18b824…

1 0

git:master:e2383b74: modules: readme files regenerated - ims_qos ... [skip ci]
by Kamailio Dev 01 Apr '22

01 Apr '22

Module: kamailio Branch: master Commit: e2383b74f79107aed232ffb8e6a311c56f64ff46 URL: https://github.com/kamailio/kamailio/commit/e2383b74f79107aed232ffb8e6a311c… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-04-01T14:01:12+02:00 modules: readme files regenerated - ims_qos ... [skip ci] --- Modified: src/modules/ims_qos/README Modified: src/modules/stirshaken/README --- Diff: https://github.com/kamailio/kamailio/commit/e2383b74f79107aed232ffb8e6a311c… Patch: https://github.com/kamailio/kamailio/commit/e2383b74f79107aed232ffb8e6a311c…

1 0

[kamailio/kamailio] uac: fix shm leak (PR #3065)
by Stefan Mititelu 01 Apr '22

01 Apr '22

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Setup: uac_req_send() with evroute=2 and tm module enable_uac_fr=1 Noticed following shm errors while intensively testing uac_req_send(), happening quite soon after a fresh restart (e.g. 10 min): ``` kamailio[5384]: ERROR: <core> [core/mem/q_malloc.c:297]: qm_find_free(): qm_find_free(0x7fe8943bc000, 40632); Free fragment not found! kamailio[5384]: ERROR: <core> [core/mem/q_malloc.c:430]: qm_malloc(): qm_malloc(0x7fe8943bc000, 40632) called from uac: uac_send.c: uac_send_info_clone(105), module: uac; Free fragment not found! kamailio[5384]: ERROR: uac [uac_send.c:108]: uac_send_info_clone(): no more shm memory kamailio[5384]: ERROR: uac [uac_send.c:837]: uac_req_send(): cannot clone the uac structure ``` I tried monitoring system memory using `free` tool and noticed that the "used" memory didn't grow alot. However, I noticed the "buff/cached" memory had a steep growth when 200OK(s) started to come, for my setup. Noticed that, for my setup, when 200OK come, event_route[uac:reply] is not called, so the tm callback set by UAC module is not called. => the "tp" callback parameter shm allocated by UAC module is not freed. By analogy, when using uac_req_send() with evroute=1 and timeout happens (e.g. no reply comes), event_route[uac:reply] won't be called and same leak should happen => *i didn;t tested that*, was just an analogy. I updated the code to call the callback on TMCB_DESTROY, and make sure tp parameter is freed, *one time*. Let me know what you think of this... in my setup/tests I got no kamailio shm logs anymore. Also "buff/cached" memory didn't have that steep growth anymore. Thank you, Stefan You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3065 -- Commit Summary -- * uac: fix shm leak -- File Changes -- M src/modules/uac/uac_send.c (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3065.patch https://github.com/kamailio/kamailio/pull/3065.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3065 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3065(a)github.com>

3 4

git:master:1ff0a9c4: uac: fix shm leak
by Daniel-Constantin Mierla 01 Apr '22

01 Apr '22

Module: kamailio Branch: master Commit: 1ff0a9c4cee17a68a54c7002a528710ce85b96da URL: https://github.com/kamailio/kamailio/commit/1ff0a9c4cee17a68a54c7002a528710… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-01T13:55:44+02:00 uac: fix shm leak --- Modified: src/modules/uac/uac_send.c --- Diff: https://github.com/kamailio/kamailio/commit/1ff0a9c4cee17a68a54c7002a528710… Patch: https://github.com/kamailio/kamailio/commit/1ff0a9c4cee17a68a54c7002a528710… --- diff --git a/src/modules/uac/uac_send.c b/src/modules/uac/uac_send.c index 887dc1b4a4..be04464cae 100644 --- a/src/modules/uac/uac_send.c +++ b/src/modules/uac/uac_send.c @@ -717,14 +717,16 @@ void uac_resend_tm_callback(struct cell *t, int type, struct tmcb_params *ps) } tp = (uac_send_info_t*)(*ps->param); - if(tp->evroute!=0) { + if(tp->evroute!=0 && ps->code > 0) { uac_req_run_event_route((ps->rpl==FAKED_REPLY)?NULL:ps->rpl, tp, ps->code); } done: - if(tp!=NULL) + if(tp!=NULL){ shm_free(tp); + *ps->param = NULL; + } return; } @@ -755,7 +757,7 @@ void uac_send_tm_callback(struct cell *t, int type, struct tmcb_params *ps) } tp = (uac_send_info_t*)(*ps->param); - if(tp->evroute!=0) { + if(tp->evroute!=0 && ps->code > 0) { uac_req_run_event_route((ps->rpl==FAKED_REPLY)?NULL:ps->rpl, tp, ps->code); } @@ -829,7 +831,7 @@ void uac_send_tm_callback(struct cell *t, int type, struct tmcb_params *ps) uac_r.body = (tp->s_body.len <= 0) ? NULL : &tp->s_body; uac_r.ssock = (tp->s_sock.len <= 0) ? NULL : &tp->s_sock; uac_r.dialog = &tmdlg; - uac_r.cb_flags = TMCB_LOCAL_COMPLETED; + uac_r.cb_flags = TMCB_LOCAL_COMPLETED|TMCB_DESTROY; if(tp->evroute!=0) { /* Callback function */ uac_r.cb = uac_resend_tm_callback; @@ -849,8 +851,10 @@ void uac_send_tm_callback(struct cell *t, int type, struct tmcb_params *ps) done: error: - if(tp!=NULL) + if(tp!=NULL){ shm_free(tp); + *ps->param = NULL; + } return; } @@ -890,13 +894,13 @@ int uac_req_send(void) { case 2: - uac_r.cb_flags = TMCB_ON_FAILURE; + uac_r.cb_flags = TMCB_ON_FAILURE|TMCB_DESTROY; /* Callback function */ uac_r.cb = uac_resend_tm_callback; break; case 1: default: - uac_r.cb_flags = TMCB_LOCAL_COMPLETED; + uac_r.cb_flags = TMCB_LOCAL_COMPLETED|TMCB_DESTROY; /* Callback function */ uac_r.cb = uac_send_tm_callback; break;

1 0

[kamailio/kamailio] ims_qos: Added new parameters for AAR, AVP517 (PR #3066)
by alexyosifov 01 Apr '22

01 Apr '22

- Added new parameters: af_signaling_ip6, component_media_type, flow_protocol, omit_flow_ports, rs_default_bandwidth, rr_default_bandwidth. Check doc for details.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3066 -- Commit Summary -- * ims_qos: Added new parameters for AAR,AVP517 -- File Changes -- M src/modules/ims_qos/doc/ims_qos_admin.xml (134) M src/modules/ims_qos/ims_qos_mod.c (13) M src/modules/ims_qos/rx_aar.c (29) M src/modules/ims_qos/rx_avp.c (67) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3066.patch https://github.com/kamailio/kamailio/pull/3066.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3066 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3066(a)github.com>

2 2

git:master:5a85767e: ims_qos: Added new parameters for AAR, AVP517
by Daniel-Constantin Mierla 01 Apr '22

01 Apr '22

Module: kamailio Branch: master Commit: 5a85767ef3371dd6443e9cc0caebf3b68980dc07 URL: https://github.com/kamailio/kamailio/commit/5a85767ef3371dd6443e9cc0caebf3b… Author: Aleksandar Yosifov <alexander.yosifov(a)circles.bz> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-01T13:54:38+02:00 ims_qos: Added new parameters for AAR,AVP517 - Added new parameters: af_signaling_ip6, component_media_type, flow_protocol, omit_flow_ports, rs_default_bandwidth, rr_default_bandwidth. Check doc for details. --- Modified: src/modules/ims_qos/doc/ims_qos_admin.xml Modified: src/modules/ims_qos/ims_qos_mod.c Modified: src/modules/ims_qos/rx_aar.c Modified: src/modules/ims_qos/rx_avp.c --- Diff: https://github.com/kamailio/kamailio/commit/5a85767ef3371dd6443e9cc0caebf3b… Patch: https://github.com/kamailio/kamailio/commit/5a85767ef3371dd6443e9cc0caebf3b…

1 0

[kamailio/kamailio] stirshaken: fix doc typos (PR #3067)
by mrtrev 01 Apr '22

01 Apr '22

2 1

git:master:1986ac41: stirshaken: fix doc typos
by Daniel-Constantin Mierla 01 Apr '22

01 Apr '22

Module: kamailio Branch: master Commit: 1986ac41e38d2bd7600a19527cf00164876e77e3 URL: https://github.com/kamailio/kamailio/commit/1986ac41e38d2bd7600a19527cf0016… Author: Trevor Peirce <trev(a)acrovoice.ca> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-01T13:52:31+02:00 stirshaken: fix doc typos --- Modified: src/modules/stirshaken/doc/stirshaken_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1986ac41e38d2bd7600a19527cf0016… Patch: https://github.com/kamailio/kamailio/commit/1986ac41e38d2bd7600a19527cf0016… --- diff --git a/src/modules/stirshaken/doc/stirshaken_admin.xml b/src/modules/stirshaken/doc/stirshaken_admin.xml index 1e7c7001ef..f54747d0cf 100644 --- a/src/modules/stirshaken/doc/stirshaken_admin.xml +++ b/src/modules/stirshaken/doc/stirshaken_admin.xml @@ -275,8 +275,7 @@ modparam("stirshaken", "vs_certsubject_pvname", "$vn(certsubject)") </programlisting> </example> </section> - </section> - <section> + <section> <title><varname>vs_pptgrants_pvname</varname> (str)</title> <para> If vs_pptgrants_pvname is set then the JSON string of the authenticated PASSporT's grants will be written to this pseudo-variable when @@ -422,7 +421,7 @@ request_route { </para> <para> The parameters can contain pseudo-variables. - If origid is empty, an unique identifier will be generated wih libuuid, e.g. "3f31bd2b-9fc4-4084-b0b0-566506c46292". + If origid is empty, an unique identifier will be generated with libuuid, e.g. "3f31bd2b-9fc4-4084-b0b0-566506c46292". </para> <para> This function can be used from ANY_ROUTE.

1 0

git:master:58fde684: modules: readme files regenerated - evrexec ... [skip ci]
by Kamailio Dev 01 Apr '22

01 Apr '22

Module: kamailio Branch: master Commit: 58fde6844ca5b6f98ca12693d59e22722635cf16 URL: https://github.com/kamailio/kamailio/commit/58fde6844ca5b6f98ca12693d59e227… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-04-01T09:01:22+02:00 modules: readme files regenerated - evrexec ... [skip ci] --- Modified: src/modules/evrexec/README --- Diff: https://github.com/kamailio/kamailio/commit/58fde6844ca5b6f98ca12693d59e227… Patch: https://github.com/kamailio/kamailio/commit/58fde6844ca5b6f98ca12693d59e227… --- diff --git a/src/modules/evrexec/README b/src/modules/evrexec/README index 4d80d4c006..059b8d7bea 100644 --- a/src/modules/evrexec/README +++ b/src/modules/evrexec/README @@ -104,7 +104,8 @@ Chapter 1. Admin Guide * wait - timer interval in micro-seconds to wait inside the dedicated process before executing the task. * sockaddr - full UDP socket address in format 'udp:ip:port' - (example: 'udp:127.0.0.1:54321'). + (example: 'udp:127.0.0.1:54321'). Received data is made available + in the event route via $evr(data). Default value is NULL. @@ -124,7 +125,7 @@ event_route[evrexec:timer] { } event_route[evrexec:udp] { - xinfo("udp socket data: [$evr(data)]\n"); + xinfo("udp socket data: [$evr(data)] from [$evr(srcip)]\n"); } ...

1 0

git:master:ba98cbb7: evrexec: docs update with variable example
by Daniel-Constantin Mierla 01 Apr '22

01 Apr '22

Module: kamailio Branch: master Commit: ba98cbb78e0e2b9f4075bf548bb8e9bc3c3c8b48 URL: https://github.com/kamailio/kamailio/commit/ba98cbb78e0e2b9f4075bf548bb8e9b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-01T08:50:16+02:00 evrexec: docs update with variable example --- Modified: src/modules/evrexec/doc/evrexec_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ba98cbb78e0e2b9f4075bf548bb8e9b… Patch: https://github.com/kamailio/kamailio/commit/ba98cbb78e0e2b9f4075bf548bb8e9b… --- diff --git a/src/modules/evrexec/doc/evrexec_admin.xml b/src/modules/evrexec/doc/evrexec_admin.xml index 565b33f560..a2bcfe1403 100644 --- a/src/modules/evrexec/doc/evrexec_admin.xml +++ b/src/modules/evrexec/doc/evrexec_admin.xml @@ -102,7 +102,8 @@ <listitem> <para> <emphasis>sockaddr</emphasis> - full UDP socket address in format - 'udp:ip:port' (example: 'udp:127.0.0.1:54321'). + 'udp:ip:port' (example: 'udp:127.0.0.1:54321'). Received data is + made available in the event route via $evr(data). </para> </listitem> @@ -129,7 +130,7 @@ event_route[evrexec:timer] { } event_route[evrexec:udp] { - xinfo("udp socket data: [$evr(data)]\n"); + xinfo("udp socket data: [$evr(data)] from [$evr(srcip)]\n"); } ...

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2022