sr-dev September 2021

sr-dev@lists.kamailio.org

18 participants
306 discussions

git:master:f485a1b2: posops: new module with functions working with the position in message buffer

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f485a1b2d4aacce80dc819c0a987c192c0a0cc97 URL: https://github.com/kamailio/kamailio/commit/f485a1b2d4aacce80dc819c0a987c19… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-09-15T14:54:59+02:00 posops: new module with functions working with the position in message buffer - add/remove content at a specific position in the sip message buffer --- Added: src/modules/posops/Makefile Added: src/modules/posops/README Added: src/modules/posops/doc/Makefile Added: src/modules/posops/doc/posops.xml Added: src/modules/posops/doc/posops_admin.xml Added: src/modules/posops/posops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/f485a1b2d4aacce80dc819c0a987c19… Patch: https://github.com/kamailio/kamailio/commit/f485a1b2d4aacce80dc819c0a987c19…

2 years, 9 months

[kamailio/kamailio] Random segfault or general protection crash on siptrace.so module (#2718)

by Joshua Riffle

### Description After upgrading from Kamailio 5.2.x, a high volume Kamailio 5.4.4 instance randomly crashes with either a general protection or segfault error message in `siptrace.so` during use of `sip_trace` function from one of its child processes (which cascades to the parent crashing). This appears to occur once about every 36 hours on average, but has not yet appeared to correspond with any particular event. We are continuing to collect debug information and will be populating this ticket as more information becomes available. However, this issue has been observed. Sip trace function is applied in this example snippet: ``` # ------- siptrace -------- modparam("siptrace", "hep_mode_on", 1) modparam("siptrace", "hep_version", 3) modparam("siptrace", "trace_to_database", 0) modparam("siptrace", "trace_flag", 22) modparam("siptrace", "trace_on", 1) request_route { #.... if ( is_method("INVITE") && !has_totag() ) { # Only start sip_trace on initial INVITE sip_trace("HEP_URL","$ci-MY_IP","d"); } setflag(22); #... } ``` ### Troubleshooting We attempted packet collection with Homer v5 and Homer v7 and changed between HEP protocol v2 and v3. #### Reproduction We have not determined a means of reproducing this issue without simply letting the server run until a crash occurs. There are four almost identical servers all experiencing the same random crashing but not at the same time. #### Debugging Data Our next troubleshooting case will be to simply comment out the `sip_trace` function, but this effectively disables the `siptrace` module completely rather than addressing an underlying problem. Core dumps are still in-progress for retrieval. Debug logs should also be more readily available soon. There will be delays since these are high volume production servers.  #### Log Messages All of them have randomly crashed with the following example log entry. Regardless of troubleshooting tactics to date: ``` kernel: traps: kamailio[7579] general protection ip:7fb1a64e2dbf sp:7ffc60f04180 error:0 in siptrace.so[7fb1a64b8000+4e000] systemd: kamailio.service: main process exited, code=exited, status=1/FAILURE systemd: Unit kamailio.service entered failed state. systemd: kamailio.service failed. ``` #### SIP Traffic To date, there is no corresponding SIP Traffic with the crash. ### Possible Solutions To date, only disabling the `siptrace` module seems to be the solution. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.4.4 (x86_64/linux) e16352 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: e16352 compiled on 15:56:46 Feb 15 2021 with gcc 4.8.5 ``` * **Operating System**:  ``` Linux <hostname> 3.10.0-957.27.2.el7.x86_64 #1 SMP Mon Jul 29 17:46:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2718

2 years, 9 months

git:master:1d9a9726: misc/fuzz: deeper parsing for From/To

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 1d9a972692a44210884137c5d941909022ce6183 URL: https://github.com/kamailio/kamailio/commit/1d9a972692a44210884137c5d941909… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-09-15T11:01:45+02:00 misc/fuzz: deeper parsing for From/To --- Modified: misc/fuzz/fuzz_parse_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/1d9a972692a44210884137c5d941909… Patch: https://github.com/kamailio/kamailio/commit/1d9a972692a44210884137c5d941909… --- diff --git a/misc/fuzz/fuzz_parse_msg.c b/misc/fuzz/fuzz_parse_msg.c index 8de9175549..1c813fd715 100644 --- a/misc/fuzz/fuzz_parse_msg.c +++ b/misc/fuzz/fuzz_parse_msg.c @@ -2,6 +2,8 @@ #include "../parser/parse_uri.c" #include "../parser/parse_hname2.h" #include "../parser/contact/parse_contact.h" +#include "../parser/parse_from.h" +#include "../parser/parse_to.h" #include "../parser/parse_refer_to.h" #include "../parser/parse_ppi_pai.h" #include "../parser/parse_privacy.h" @@ -19,22 +21,29 @@ LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { sip_msg_t orig_inv = { }; orig_inv.buf = (char*)data; orig_inv.len = size; + if (parse_msg(orig_inv.buf, orig_inv.len, &orig_inv) < 0) { goto cleanup; } - + + parse_headers(&orig_inv, HDR_EOH_F, 0); + parse_sdp(&orig_inv); - parse_headers(&orig_inv, HDR_TO_F, 0); + parse_from_header(&orig_inv); + + parse_from_uri(&orig_inv); + + parse_to_header(&orig_inv); + + parse_to_uri(&orig_inv); parse_contact_header(&orig_inv); parse_refer_to_header(&orig_inv); - parse_to_header(&orig_inv); - parse_pai_header(&orig_inv); - + parse_diversion_header(&orig_inv); parse_privacy(&orig_inv);

2 years, 9 months

[kamailio/kamailio] db_redis: add support for native redis cluster (#1997)

by George Diamantopoulos

The db_redis module seems to only support connecting with a single redis instance. It is not evident from the documentation if it implements support for native redis cluster by honouring 'MOVED' replies. ndb_redis seems to have support for native redis clusters, and supports both automatic (see allow_dynamic_nodes parameter of ndb_redis) and manual configuration of redis nodes. Since both modules are based on the hiredis library, is it safe to assume this support could be easily implemented, with some code sharing between the two modules perhaps? If db_redis supports clusters with automatic configuration only (by processing MOVED replies), perhaps the module's documentation should be updated to reflect that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1997

2 years, 9 months

[kamailio/kamailio] JSON CEE structured logging (#2797)

by Daniel Pocock

### Description Kamailio recently added JSON logging support, described on these two pages: https://www.kamailio.org/w/2020/04/structured-json-logging/ https://www.kamailio.org/wiki/cookbooks/devel/core#log_engine_cli_parameter Structured logging is particularly useful when: 1. there are multiple applications involved in a call (e.g. Kamailio, Kurento, coTurn, Apache) 2. all the applications create JSON logs using identical field names I recently made contributions to reSIProcate, GStreamer and Kurento to support the JSON CEE field names. It would be very easy to replicate in Kamailio. https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/847 https://github.com/Kurento/kurento-media-server/pull/17 https://github.com/resiprocate/resiprocate/commit/d1df9aeb956be79253560fe36… Notice that ```rsyslog``` can receive legacy Syslog events from VoIP hardware, Cisco and Polycom phones and it can convert them to JSON CEE and push them into the document store where they will meet the records from Kamailio. This is another case where it is really useful if all the JSON from different applications is using CEE. Here are the JSON CEE field names: https://cee.mitre.org/language/1.0-beta1/core-profile.html ### Expected behavior Extend the config setting so that people can request CEE on the command line. #### Actual observed behavior #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2797

2 years, 9 months

git:master:cbca34c6: sipt: use helper function to check for valid ISUP/ACM/CPG

by Henning Westerholt

Module: kamailio Branch: master Commit: cbca34c67bec1ba8581a6f7d2de83a71f1fefcd3 URL: https://github.com/kamailio/kamailio/commit/cbca34c67bec1ba8581a6f7d2de83a7… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2021-09-14T15:39:57Z sipt: use helper function to check for valid ISUP/ACM/CPG --- Modified: src/modules/sipt/sipt.c --- Diff: https://github.com/kamailio/kamailio/commit/cbca34c67bec1ba8581a6f7d2de83a7… Patch: https://github.com/kamailio/kamailio/commit/cbca34c67bec1ba8581a6f7d2de83a7… --- diff --git a/src/modules/sipt/sipt.c b/src/modules/sipt/sipt.c index e0324e3f8a..b5e596d077 100644 --- a/src/modules/sipt/sipt.c +++ b/src/modules/sipt/sipt.c @@ -264,6 +264,25 @@ static inline int sipt_check_IAM(struct sip_msg *msg, str *body) return 1; } +static inline int sipt_check_ACM_CPG(struct sip_msg *msg, str *body) +{ + body->s = get_body_part(msg, TYPE_APPLICATION,SUBTYPE_ISUP, &body->len); + + if(body->s == NULL) + { + LM_INFO("No ISUP Message Found"); + return -1; + } + + if((body->s[0] != ISUP_ACM) && (body->s[0] != ISUP_CPG)) + { + LM_DBG("message not an ACM or CPG\n"); + return -1; + } + return 1; +} + + static int sipt_get_hop_counter(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { str body; @@ -353,17 +372,9 @@ static int sipt_get_calling_party(struct sip_msg *msg, pv_param_t *param, pv_val static int sipt_get_redirection_info(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { str body; - body.s = get_body_part(msg, TYPE_APPLICATION,SUBTYPE_ISUP,&body.len); - - if(body.s == NULL) - { - LM_INFO("No ISUP Message Found"); - return -1; - } - - if((body.s[0] != ISUP_ACM) && (body.s[0] != ISUP_CPG)) + if(sipt_check_ACM_CPG(msg, &body) != 1) { - LM_DBG("message not an ACM or CPG\n"); + LM_INFO("could not check ACM or CPG\n"); return -1; } @@ -374,17 +385,9 @@ static int sipt_get_redirection_info(struct sip_msg *msg, pv_param_t *param, pv_ static int sipt_get_redirection_number_nai(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { str body; - body.s = get_body_part(msg, TYPE_APPLICATION,SUBTYPE_ISUP,&body.len); - - if(body.s == NULL) - { - LM_INFO("No ISUP Message Found"); - return -1; - } - - if((body.s[0] != ISUP_ACM) && (body.s[0] != ISUP_CPG)) + if(sipt_check_ACM_CPG(msg, &body) != 1) { - LM_DBG("message not an ACM or CPG\n"); + LM_INFO("could not check ACM or CPG\n"); return -1; } @@ -396,18 +399,10 @@ static int sipt_get_redirection_number(struct sip_msg *msg, pv_param_t *param, p { static char sb_s_buf[26]; str body; - body.s = get_body_part(msg, TYPE_APPLICATION,SUBTYPE_ISUP,&body.len); - memset(sb_s_buf, 0, 26); - if(body.s == NULL) + if(sipt_check_ACM_CPG(msg, &body) != 1) { - LM_INFO("No ISUP Message Found"); - return -1; - } - - if((body.s[0] != ISUP_ACM) && (body.s[0] != ISUP_CPG)) - { - LM_DBG("message not an ACM or CPG\n"); + LM_INFO("could not check ACM or CPG\n"); return -1; }

2 years, 9 months

git:master:0cc471e0: sipt: use helper function to check for valid ISUP/IAM

by Henning Westerholt

Module: kamailio Branch: master Commit: 0cc471e0c12c33044a0be6b41cbf63ee12a5d5c1 URL: https://github.com/kamailio/kamailio/commit/0cc471e0c12c33044a0be6b41cbf63e… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2021-09-14T15:32:50Z sipt: use helper function to check for valid ISUP/IAM --- Modified: src/modules/sipt/sipt.c --- Diff: https://github.com/kamailio/kamailio/commit/0cc471e0c12c33044a0be6b41cbf63e… Patch: https://github.com/kamailio/kamailio/commit/0cc471e0c12c33044a0be6b41cbf63e…

2 years, 9 months

[kamailio/kamailio] Kamailio was not accepting TLS connections (#2796)

by aatif218

we are getting the following errors in Kamailio logs **kamailio.log** Jun 29 08:08:14 fep-1 /usr/local/fep-kamailio/sbin/kamailio[14111]: ERROR: <core> [core/tcp_main.c:4451]: handle_tcpconn_ev(): io_watch_del(3) failed: for 0x7f524f7862d0, fd 30406 Jun 29 08:08:14 fep-1 /usr/local/fep-kamailio/sbin/kamailio[14111]: ERROR: <core> [core/tcp_main.c:4451]: handle_tcpconn_ev(): io_watch_del(3) failed: for 0x7f525a6c5f90, fd 30407 Jun 29 08:08:14 fep-1 /usr/local/fep-kamailio/sbin/kamailio[14111]: ERROR: <core> [core/tcp_main.c:4451]: handle_tcpconn_ev(): io_watch_del(3) failed: for 0x7f52449e0978, fd 30415 Jun 29 08:06:27 fep-1 /usr/local/fep-kamailio/sbin/kamailio[14111]: CRITICAL: <core> [core/io_wait.h:596]: io_watch_del(): invalid fd 30355, not in [0, 4607) Jun 29 08:06:27 fep-1 /usr/local/fep-kamailio/sbin/kamailio[14111]: CRITICAL: <core> [core/io_wait.h:596]: io_watch_del(): invalid fd 30356, not in [0, 4607) Jun 29 08:06:27 fep-1 /usr/local/fep-kamailio/sbin/kamailio[14111]: CRITICAL: <core> [core/io_wait.h:596]: io_watch_del(): invalid fd 30358, not in [0, 4607) **Description** On checking this issue we found that Kamailio was not accepting TLS connections. We were getting an error which is mentioned above. We double-checked TLS and TCP connections and they were normal. We have 5000+ TLS connections and the max connection limit is 30,000. So we were not exceeding the TLS connection limit. We also verified open_files_limits. It is around 1 million which is more than enough. **Kamailio Version** - output of kamailio -v version: kamailio 5.4.2 (x86_64/linux) f8885c flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: f8885c **Operating System:** NAME="CentOS Linux" VERSION="7 (Core)" ID="centos" ID_LIKE="rhel fedora" VERSION_ID="7" PRETTY_NAME="CentOS Linux 7 (Core)" ANSI_COLOR="0;31" CPE_NAME="cpe:/o:centos:centos:7" HOME_URL="https://www.centos.org/" BUG_REPORT_URL="https://bugs.centos.org/" CENTOS_MANTISBT_PROJECT="CentOS-7" CENTOS_MANTISBT_PROJECT_VERSION="7" REDHAT_SUPPORT_PRODUCT="centos" REDHAT_SUPPORT_PRODUCT_VERSION="7" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2796

2 years, 9 months

[kamailio/kamailio] kamailio log socket error (#2806)

by nihaomatmat

I have some problems。the kamailio version is 5.3.0. My linux version is centos 7. the kamailio log: ERROR: <core> [core/tcp_main.c:3508]: send_fd_queue_run(): send_fd failed on socket 63 , queue entry 1, retries 90, connection 0x7ff46e6b1b60, tcp socket 218, errno=11 (Resource temporarily unavailable) ERROR: {1 12529 MESSAGE 359bf0410a7e471c950623e3f7a3b17b} <core> [core/kemi.c:94]: sr_kemi_core_err(): 202->408 CRITICAL: <core> [core/tcp_main.c:4218]: send2child(): tcp child 6, socket 65: queue full, 291 requests queued (total handled 10665748) This problem does not happen every time。When the number of user registrations increases significantly, errors will appear。I tried to set the parameter tcp_children is adjusted to 8, it will not appear frequently, but when the number of user registrations increases to about 5000, errors will still appear. My kamailio.cfg global parameters are set as follows：tls_max_connections=65536,tcp_max_connections=65536,open_max_files=65536。 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2806

2 years, 9 months

[kamailio/kamailio] misc: fuzz: extend msg parsing fuzzer (#2851)

by DavidKorczynski

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Extends the msg parsing fuzzer to reach some of the parsing routines we currently miss. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2851 -- Commit Summary -- * misc: fuzz: extend msg parsing fuzzer -- File Changes -- M misc/fuzz/fuzz_parse_msg.c (12) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2851.patch https://github.com/kamailio/kamailio/pull/2851.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2851

2 years, 9 months

← Newer
1
...
17
18
19
20
21
22
23
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2021