sr-dev September 2021

sr-dev@lists.kamailio.org

18 participants
306 discussions

[kamailio/kamailio] KSR.sqlops.sql_xquery() return 0 when successful, but 1 expected (#2856)

by hance2010

### Description  ### Troubleshooting ``` # kamailio.cfg sql = "select * from subscriber"; sql_xquery("ca", sql, "ra"); xinfo("returncode = $rc"); /* 1 */ # kamailio.lua sql = "select * from subscriber" rc = KSR.sqlops.sql_xquery("ca", sql, "ra") KSR.info("returncode = " .. rc .. "\n") -- 0, but 1 expected ``` #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio 5.5.1 ``` * **Operating System**:  ``` debian10 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2856

2 years, 9 months

git:master:32bf3eb2: sqlops: return 1 on success for kemi sql_xquery()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 32bf3eb2b27fbefe991a4aabc829f21ecc4e8829 URL: https://github.com/kamailio/kamailio/commit/32bf3eb2b27fbefe991a4aabc829f21… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-09-16T13:00:20+02:00 sqlops: return 1 on success for kemi sql_xquery() - GH #2856 --- Modified: src/modules/sqlops/sql_api.c --- Diff: https://github.com/kamailio/kamailio/commit/32bf3eb2b27fbefe991a4aabc829f21… Patch: https://github.com/kamailio/kamailio/commit/32bf3eb2b27fbefe991a4aabc829f21… --- diff --git a/src/modules/sqlops/sql_api.c b/src/modules/sqlops/sql_api.c index d67f30ccef..63c035ca89 100644 --- a/src/modules/sqlops/sql_api.c +++ b/src/modules/sqlops/sql_api.c @@ -954,7 +954,7 @@ int sqlops_do_xquery(sip_msg_t *msg, str *scon, str *squery, str *xavp) if(sql_exec_xquery(msg, con, squery, xavp)<0) goto error; - return 0; + return 1; error: return -1; }

2 years, 9 months

git:master:b8d3971a: slack: reuse http_client api

by Arsen Semenov

Module: kamailio Branch: master Commit: b8d3971ab7d2d5d913f629b142dded6322a82172 URL: https://github.com/kamailio/kamailio/commit/b8d3971ab7d2d5d913f629b142dded6… Author: Arsen Semenov <arsperger(a)gmail.com> Committer: Arsen Semenov <arsperger(a)gmail.com> Date: 2021-09-16T15:42:24+05:00 slack: reuse http_client api --- Modified: src/modules/slack/Makefile Modified: src/modules/slack/slack.c Modified: src/modules/slack/slack.h --- Diff: https://github.com/kamailio/kamailio/commit/b8d3971ab7d2d5d913f629b142dded6… Patch: https://github.com/kamailio/kamailio/commit/b8d3971ab7d2d5d913f629b142dded6…

2 years, 9 months

[kamailio/kamailio] `rpc dispatcher.add group address flags` not work (#2854)

by hance2010

### Description  kamcmd dispatcher add 1 sip:1.2.3.4 # work kamcmd dispatcher add 1 sip:1.2.3.4 8 maxload=20 # work but, kamcmd dispatcher add 1 sip:1.2.3.4 8 # not work ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` kamailio 5.5.2 ``` (paste your output here) ``` * **Operating System**: Debian10  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2854

2 years, 9 months

git:master:63ecb827: core: parser - print what is left in buffer if no EoH in get_body()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 63ecb827631189d27da6a85d41149985d95fc479 URL: https://github.com/kamailio/kamailio/commit/63ecb827631189d27da6a85d4114998… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-09-16T11:03:52+02:00 core: parser - print what is left in buffer if no EoH in get_body() --- Modified: src/core/parser/msg_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/63ecb827631189d27da6a85d4114998… Patch: https://github.com/kamailio/kamailio/commit/63ecb827631189d27da6a85d4114998… --- diff --git a/src/core/parser/msg_parser.c b/src/core/parser/msg_parser.c index 795c96a350..5b7fab524d 100644 --- a/src/core/parser/msg_parser.c +++ b/src/core/parser/msg_parser.c @@ -1356,8 +1356,10 @@ char* get_body(sip_msg_t* const msg) (*(msg->unparsed)=='\n' || *(msg->unparsed)=='\r' ) ) { offset = 1; } else { - LM_ERR("failed to locate end of headers (%p %p - %d %d [%s])\n", - msg->buf, msg->unparsed, msg->len, len, msg->unparsed); + LM_ERR("failed to locate end of headers (%p %p - %d %d [%.*s])\n", + msg->buf, msg->unparsed, msg->len, len, + (len<msg->len)?(msg->len-len):0, + (len<msg->len)?msg->unparsed:""); return 0; }

2 years, 9 months

git:master:489eb674: misctest: sync with fuzz msg code

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 489eb6742997f8e4f2dc56c894af6b8ed5ef4d33 URL: https://github.com/kamailio/kamailio/commit/489eb6742997f8e4f2dc56c894af6b8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-09-16T11:00:56+02:00 misctest: sync with fuzz msg code --- Modified: src/modules/misctest/misctest_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/489eb6742997f8e4f2dc56c894af6b8… Patch: https://github.com/kamailio/kamailio/commit/489eb6742997f8e4f2dc56c894af6b8… --- diff --git a/src/modules/misctest/misctest_mod.c b/src/modules/misctest/misctest_mod.c index 68f70718fc..0867c1ae46 100644 --- a/src/modules/misctest/misctest_mod.c +++ b/src/modules/misctest/misctest_mod.c @@ -39,10 +39,14 @@ #include "../../core/parser/parse_uri.c" #include "../../core/parser/parse_hname2.h" #include "../../core/parser/contact/parse_contact.h" +#include "../../core/parser/parse_to.h" +#include "../../core/parser/parse_from.h" #include "../../core/parser/parse_refer_to.h" #include "../../core/parser/parse_ppi_pai.h" #include "../../core/parser/parse_privacy.h" #include "../../core/parser/parse_diversion.h" +#include "../../core/parser/parse_identityinfo.h" +#include "../../core/parser/parse_disposition.h" MODULE_VERSION @@ -325,22 +329,38 @@ static int misctest_message_init(void) goto cleanup; } + parse_headers(&tmsg, HDR_EOH_F, 0); + parse_sdp(&tmsg); - parse_headers(&tmsg, HDR_TO_F, 0); + parse_from_header(&tmsg); + + parse_from_uri(&tmsg); + + parse_to_header(&tmsg); + + parse_to_uri(&tmsg); parse_contact_header(&tmsg); parse_refer_to_header(&tmsg); - parse_to_header(&tmsg); - parse_pai_header(&tmsg); parse_diversion_header(&tmsg); parse_privacy(&tmsg); + parse_content_disposition(&tmsg); + + parse_identityinfo_header(&tmsg); + + str uri; + get_src_uri(&tmsg, 0, &uri); + + str ssock; + get_src_address_socket(&tmsg, &ssock); + cleanup: free_sip_msg(&tmsg);

2 years, 9 months

git:master:7894fb47: dispatcher: init attrs value when param not given to rpc add

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 7894fb470e707622b077d565763c9cfb7c654da5 URL: https://github.com/kamailio/kamailio/commit/7894fb470e707622b077d565763c9cf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-09-16T08:37:55+02:00 dispatcher: init attrs value when param not given to rpc add - GH #2854 --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/7894fb470e707622b077d565763c9cf… Patch: https://github.com/kamailio/kamailio/commit/7894fb470e707622b077d565763c9cf… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 679acbe2aa..4ed98919b7 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -1854,7 +1854,7 @@ static void dispatcher_rpc_add(rpc_t *rpc, void *ctx) { int group, flags, nparams; str dest; - str attrs; + str attrs = STR_NULL; flags = 0; @@ -1862,7 +1862,7 @@ static void dispatcher_rpc_add(rpc_t *rpc, void *ctx) if(nparams < 2) { rpc->fault(ctx, 500, "Invalid Parameters"); return; - } else if (nparams < 3) { + } else if (nparams <= 3) { attrs.s = 0; attrs.len = 0; }

2 years, 9 months

git:master:f2b133e2: core: free params list at end on error state inside parse_addr_spec

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f2b133e24e29f9f0ce7ba568a5d4564c7b0f8f31 URL: https://github.com/kamailio/kamailio/commit/f2b133e24e29f9f0ce7ba568a5d4564… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-09-16T08:08:18+02:00 core: free params list at end on error state inside parse_addr_spec --- Modified: src/core/parser/parse_addr_spec.c --- Diff: https://github.com/kamailio/kamailio/commit/f2b133e24e29f9f0ce7ba568a5d4564… Patch: https://github.com/kamailio/kamailio/commit/f2b133e24e29f9f0ce7ba568a5d4564… --- diff --git a/src/core/parser/parse_addr_spec.c b/src/core/parser/parse_addr_spec.c index 99138dcaf4..1ff5a16908 100644 --- a/src/core/parser/parse_addr_spec.c +++ b/src/core/parser/parse_addr_spec.c @@ -896,6 +896,9 @@ char *parse_addr_spec(char *const buffer, const char *const end, status); goto error; } + if(to_b->error == PARSE_ERROR) { + free_to_params(to_b); + } return tmp; error:

2 years, 9 months

[kamailio/kamailio] kazoo application may send zero string to kamailio this trigers crash (#2794)

by sergey-safarov

### Description I can see Kamailio cush then kazoo sends zero string as payload. Crush happens Kamailio start. #### Debugging Data ``` (gdb) bt full #0 strlen () at ../sysdeps/aarch64/strlen.S:94 No locals. #1 0x0000ffff98237274 in json_tokener_parse_ex (tok=0x1fe5a930, str=0x0, len=-1) at json_tokener.c:259 obj = 0x0 c = 1 '\001' oldlocale = 0xffffffffffffffff newloc = <optimized out> #2 0x0000ffff982b7c34 in kz_json_parse (str=0x0) at kz_json.c:285 tok = 0x1fe5a930 obj = 0x0 __func__ = "kz_json_parse" #3 0x0000ffff982a4550 in kz_amqp_consumer_event (Evt=0xffff9ce07a60) at kz_amqp.c:2427 json_obj = 0x0 #4 0x0000ffff982b1450 in kz_amqp_consumer_worker_cb (fd=16, event=2, arg=0xffffc5e8b350) at kz_amqp.c:3277 cmd = 0x0 Evt = 0xffff9ce07a60 __func__ = "kz_amqp_consumer_worker_cb" #5 0x0000ffff98193628 in event_process_active_single_queue () from /lib64/libevent-2.1.so.6 No symbol table info available. #6 0x0000ffff98193ee8 in event_base_loop () from /lib64/libevent-2.1.so.6 No symbol table info available. #7 0x0000ffff982b1878 in kz_amqp_consumer_worker_proc (cmd_pipe=16) at kz_amqp.c:3292 pipe_ev = {ev_evcallback = {evcb_active_next = {tqe_next = 0x0, tqe_prev = 0x1fb68f40}, evcb_flags = 130, evcb_pri = 0 '\000', evcb_closure = 2 '\002', evcb_cb_union = {evcb_callback = 0xffff982b080c <kz_amqp_consumer_worker_cb>, evcb_selfcb = 0xffff982b080c <kz_amqp_consumer_worker_cb>, evcb_evfinalize = 0xffff982b080c <kz_amqp_consumer_worker_cb>, evcb_cbfinalize = 0xffff982b080c <kz_amqp_consumer_worker_cb>}, evcb_arg = 0xffffc5e8b350}, ev_timeout_pos = {ev_next_with_common_timeout = {tqe_next = 0xffffffffffff, tqe_prev = 0xffffc5e8b5c0}, min_heap_idx = -1}, ev_fd = 16, ev_base = 0x1fe4e360, ev_ = {ev_io = {ev_io_next = {le_next = 0x0, le_prev = 0x1fdd0ec0}, ev_timeout = {tv_sec = 0, tv_usec = 0}}, ev_signal = {ev_signal_next = {le_next = 0x0, le_prev = 0x1fdd0ec0}, ev_ncalls = 0, ev_pncalls = 0x0}}, ev_events = 18, ev_res = 2, ev_timeout = {tv_sec = 281473255792648, tv_usec = 0}} #8 0x0000ffff98279a94 in mod_child_init (rank=0) at kazoo.c:412 pid = 0 i = 2 g = 0xffff9e491868 s = 0x8e2210 __func__ = "mod_child_init" #9 0x00000000005c93a8 in init_mod_child (m=0xffff9defe638, rank=0) at core/sr_module.c:864 __func__ = "init_mod_child" #10 0x00000000005c8f5c in init_mod_child (m=0xffff9df16b30, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #11 0x00000000005c8f5c in init_mod_child (m=0xffff9df9fde0, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #12 0x00000000005c8f5c in init_mod_child (m=0xffff9dfa03a0, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #13 0x00000000005c8f5c in init_mod_child (m=0xffff9dfa2750, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #14 0x00000000005c8f5c in init_mod_child (m=0xffff9dfa4e70, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #15 0x00000000005c8f5c in init_mod_child (m=0xffff9e09c900, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #16 0x00000000005c8f5c in init_mod_child (m=0xffff9e09df60, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #17 0x00000000005c8f5c in init_mod_child (m=0xffff9e09e608, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #18 0x00000000005c8f5c in init_mod_child (m=0xffff9e09e978, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #19 0x00000000005c8f5c in init_mod_child (m=0xffff9e09ece8, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #20 0x00000000005c8f5c in init_mod_child (m=0xffff9e3577a8, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #21 0x00000000005c8f5c in init_mod_child (m=0xffff9e358888, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #22 0x00000000005c8f5c in init_mod_child (m=0xffff9e391358, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #23 0x00000000005c8f5c in init_mod_child (m=0xffff9e45dc90, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #24 0x00000000005c8f5c in init_mod_child (m=0xffff9e483c60, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #25 0x00000000005c8f5c in init_mod_child (m=0xffff9e484190, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #26 0x00000000005c8f5c in init_mod_child (m=0xffff9e484e38, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #27 0x00000000005c8f5c in init_mod_child (m=0xffff9e4868c8, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #28 0x00000000005c8f5c in init_mod_child (m=0xffff9e4c1fb8, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #29 0x00000000005c8f5c in init_mod_child (m=0xffff9e51d880, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #30 0x00000000005c8f5c in init_mod_child (m=0xffff9e54c6c0, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #31 0x00000000005c8f5c in init_mod_child (m=0xffff9e5b3130, rank=0) at core/sr_module.c:860 __func__ = "init_mod_child" #32 0x00000000005c9d8c in init_child (rank=0) at core/sr_module.c:909 ret = -974598928 type = 0x8e4180 "PROC_MAIN" __func__ = "init_child" #33 0x0000000000431f70 in main_loop () at main.c:1849 i = 8 pid = 174778 si = 0x0 si_desc = "udp receiver child=7 sock=[2600:1f1c:6d5:aa02::c6]:5080\000\230\352\356\235\377\377\000\000\360\315\350\305\377\377\000\000\340\004S\236\377\377\000\000\020\316\350\305\377\377\000\000 \316\350\305\377\377\000\000 \316\350\305\377\377\000\000\360\315\350\305\377\377\000\000\320\377\377\377\200\377\377\377\000\355w\200t\232'\376" nrprocs = 8 woneinit = 1 __func__ = "main_loop" #34 0x000000000043de90 in main (argc=11, argv=0xffffc5e8d3c8) at main.c:3053 cfg_stream = 0x1fae02d0 c = -1 r = 0 tmp = 0xffffc5e8fee1 "" tmp_len = 65535 port = 1 proto = 0 ahost = 0x0 aport = 0 options = 0x8ae128 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 2101103603 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 2 n_lst = 0x0 p = 0xffff9f660da8 <__libc_start_main+168> "" st = {st_dev = 25, st_ino = 18714, st_mode = 16832, st_nlink = 2, st_uid = 991, st_gid = 986, st_rdev = 0, __pad1 = 0, st_size = 60, st_blksize = 65536, __pad2 = 0, st_blocks = 0, st_atim = {tv_sec = 1624850771, tv_nsec = 439999983}, st_mtim = {tv_sec = 1625171374, tv_nsec = 987883153}, st_ctim = {tv_sec = 1625171374, tv_nsec = 987883153}, __glibc_reserved = {0, 0}} tbuf = "\000\000\000\000\000\000\000\000\000\000\230\237\377\377\000\000\000\000\000\000\000\000\000\000\330\375\233\237\377\377", '\000' <repeats 58 times>, "x\376\233\237\377\377\000\000h\376\233\237\377\377\000\000\b\376\233\237\377\377\000\000(\376\233\237\377\377\000\000\070\376\233\237\377\377\000\000\250\376\233\237\377\377\000\000\270\376\233\237\377\377\000\000\310\376\233\237\377\377\000\000H\376\233\237\377\377\000\000X\376\233\237\377\377", '\000' <repeats 18 times>, "\330\375\233\237\377\377", '\000' <repeats 42 times>... option_index = 12 long_options = {{name = 0x8b04e8 "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0x8ab520 "version", has_arg = 0, flag = 0x0, val = 118}, {name = 0x8b04f0 "alias", has_arg = 1, flag = 0x0, val = 1024}, {name = 0x8b04f8 "subst", has_arg = 1, flag = 0x0, val = 1025}, {name = 0x8b0500 "substdef", has_arg = 1, flag = 0x0, val = 1026}, {name = 0x8b0510 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, {name = 0x8b0520 "server-id", has_arg = 1, flag = 0x0, val = 1028}, {name = 0x8b0530 "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, {name = 0x8b0540 "modparam", has_arg = 1, flag = 0x0, val = 1030}, {name = 0x8b0550 "log-engine", has_arg = 1, flag = 0x0, val = 1031}, {name = 0x8b0560 "debug", has_arg = 1, flag = 0x0, val = 1032}, {name = 0x8b0568 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, {name = 0x8b0578 "atexit", has_arg = 1, flag = 0x0, val = 1034}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}} __func__ = "main" ``` Variables vlaues ``` (gdb) f 2 #2 0x0000ffff982b7c34 in kz_json_parse (str=0x0) at kz_json.c:285 285 obj = json_tokener_parse_ex(tok, str, -1); (gdb) p obj $3 = (struct json_object *) 0x0 (gdb) p *obj Cannot access memory at address 0x0 (gdb) f 3 #3 0x0000ffff982a4550 in kz_amqp_consumer_event (Evt=0xffff9ce07a60) at kz_amqp.c:2427 2427 json_obj = kz_json_parse(Evt->payload); (gdb) p *Evt $4 = {payload = 0x0, delivery_tag = 1819, channel = 6, event_key = 0x0, event_subkey = 0x0, message_id = 0xffff9cfdd600, routing_key = 0x0, cmd = 0x0} (gdb) p Evt->payload $5 = 0x0 (gdb) p *Evt->payload Cannot access memory at address 0x0 ``` ### Possible Solutions Check empty string zero inside `kz_json_parse` function and NULL if received empty string. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` [root@bcf-e-0 ~]# kamailio -v version: kamailio 5.6.0-dev0 (aarch64/linux) f03900 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT-NOSMP, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: f03900 compiled on 17:17:36 Jun 26 2021 with gcc 8.4.1 ``` Here is master branch with my customization * **Operating System**: ``` [root@bcf-e-0 ~]# uname -a Linux bcf-e-0.la.cal911.net 4.18.0-305.3.1.el8.aarch64 #1 SMP Tue Jun 1 16:22:50 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux [root@bcf-e-0 ~]# cat /etc/os-release NAME="CentOS Linux" VERSION="8" ID="centos" ID_LIKE="rhel fedora" VERSION_ID="8" PLATFORM_ID="platform:el8" PRETTY_NAME="CentOS Linux 8" ANSI_COLOR="0;31" CPE_NAME="cpe:/o:centos:centos:8" HOME_URL="https://centos.org/" BUG_REPORT_URL="https://bugs.centos.org/" CENTOS_MANTISBT_PROJECT="CentOS-8" CENTOS_MANTISBT_PROJECT_VERSION="8" ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2794

2 years, 9 months

git:master:d8955fc3: kazoo: fixed crash when json body is NULL

by Sergey Safarov

Module: kamailio Branch: master Commit: d8955fc350b48d0c4ca359d03cb9954a48998658 URL: https://github.com/kamailio/kamailio/commit/d8955fc350b48d0c4ca359d03cb9954… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2021-09-15T16:14:13+03:00 kazoo: fixed crash when json body is NULL fixes GH #2794 --- Modified: src/modules/kazoo/kz_json.c --- Diff: https://github.com/kamailio/kamailio/commit/d8955fc350b48d0c4ca359d03cb9954… Patch: https://github.com/kamailio/kamailio/commit/d8955fc350b48d0c4ca359d03cb9954… --- diff --git a/src/modules/kazoo/kz_json.c b/src/modules/kazoo/kz_json.c index 5ab8f68c79..0e5f2e8b10 100644 --- a/src/modules/kazoo/kz_json.c +++ b/src/modules/kazoo/kz_json.c @@ -276,6 +276,11 @@ struct json_object* kz_json_parse(const char *str) struct json_tokener* tok; struct json_object* obj; + if (str == NULL || str[0] == 0) { + LM_ERR("Error parsing json: empty string\n"); + return NULL; + } + tok = json_tokener_new(); if (!tok) { LM_ERR("Error parsing json: could not allocate tokener\n");

2 years, 9 months

← Newer
1
...
16
17
18
19
20
21
22
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2021