sr-dev June 2021

sr-dev@lists.kamailio.org

15 participants
313 discussions

git:master:10bc5b24: pv: new variable $hflc(hname)
by Daniel-Constantin Mierla 08 Jun '21

08 Jun '21

Module: kamailio Branch: master Commit: 10bc5b244db34e57beb9e5b4ec546396fb12a76b URL: https://github.com/kamailio/kamailio/commit/10bc5b244db34e57beb9e5b4ec54639… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-08T13:25:54+02:00 pv: new variable $hflc(hname) - return the number of bodies for known headers that can also be as a comma separated list - supported now is Via header --- Modified: src/… [View More]modules/pv/pv.c Modified: src/modules/pv/pv_core.c Modified: src/modules/pv/pv_core.h --- Diff: https://github.com/kamailio/kamailio/commit/10bc5b244db34e57beb9e5b4ec54639… Patch: https://github.com/kamailio/kamailio/commit/10bc5b244db34e57beb9e5b4ec54639… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index 2738a8b7a2..3a904e3161 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -110,6 +110,8 @@ static pv_export_t mod_pvs[] = { 0, 0, 0}, {{"hfl", (sizeof("hfl")-1)}, PVT_HDR, pv_get_hfl, 0, pv_parse_hfl_name, pv_parse_index, 0, 0}, + {{"hflc", (sizeof("hflc")-1)}, PVT_HDRC, pv_get_hflc, 0, pv_parse_hfl_name, + 0, 0, 0}, {{"var", (sizeof("var")-1)}, PVT_SCRIPTVAR, pv_get_scriptvar, pv_set_scriptvar, pv_parse_scriptvar_name, 0, 0, 0}, {{"vz", (sizeof("vz")-1)}, PVT_SCRIPTVAR, pv_get_scriptvar, diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 1b39ef3fb8..a4bfe21985 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -2421,6 +2421,70 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) return pv_get_hdr_helper(msg, param, res, &tv, idx, idxf); } +/** + * + */ +int pv_get_hflc(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) +{ + pv_value_t tv = {0}; + via_body_t *vb = NULL; + hdr_field_t *hf = NULL; + int n = 0; + + if(msg==NULL || res==NULL || param==NULL) + return -1; + + /* get the name */ + if(param->pvn.type == PV_NAME_PVAR) { + if(pv_get_spec_name(msg, param, &tv)!=0 || (!(tv.flags&PV_VAL_STR))) { + LM_ERR("invalid name\n"); + return pv_get_sintval(msg, param, res, 0); + } + } else { + if(param->pvn.u.isname.type == AVP_NAME_STR) { + tv.flags = PV_VAL_STR; + tv.rs = param->pvn.u.isname.name.s; + } else { + tv.flags = 0; + tv.ri = param->pvn.u.isname.name.n; + } + } + + if (parse_headers(msg, HDR_EOH_F, 0)<0) { + LM_DBG("failed to parse sip headers\n"); + return pv_get_sintval(msg, param, res, 0); + } + + if((tv.flags == 0) && (tv.ri==HDR_VIA_T)) { + if(msg->h_via1==NULL) { + LM_WARN("no Via header\n"); + return pv_get_sintval(msg, param, res, 0); + } + /* count Via header bodies */ + for(hf=msg->h_via1; hf!=NULL; hf=hf->next) { + if(hf->type==HDR_VIA_T) { + for(vb=(via_body_t*)hf->parsed; vb!=NULL; vb=vb->next) { + n++; + } + } + } + return pv_get_sintval(msg, param, res, n); + } + + for (hf=msg->headers; hf; hf=hf->next) { + if(tv.flags == 0) { + if (tv.ri==hf->type) { + n++; + } + } else { + if (cmp_hdrname_str(&hf->name, &tv.rs)==0) { + n++; + } + } + } + return pv_get_sintval(msg, param, res, n); +} + /** * */ diff --git a/src/modules/pv/pv_core.h b/src/modules/pv/pv_core.h index 179df8fd0b..d001104647 100644 --- a/src/modules/pv/pv_core.h +++ b/src/modules/pv/pv_core.h @@ -255,6 +255,8 @@ int pv_get_hdrc(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res); +int pv_get_hflc(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); + int pv_get_scriptvar(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); [View Less]

1 0

[kamailio/kamailio] tm: prevent t_suspend memory leak (#2763)
by Julien Chavanton 07 Jun '21

07 Jun '21

When suspending while already in t_continue when processing a reply / suspending twice in a reply. Thanks to @giavac https://github.com/kamailio/kamailio/pull/2721 we can now suspend more then once in a reply route. This is working well, however a memory leak was detected. This modification is proposing a solution that will prevent calling `sip_msg_cloner` over an already twice over the same pointer, creating the memory leak.  <!… [View More]-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception --> #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) I assume this is a non "breaking change" since it can only trigger in a very the specific case that was not supported anyway. Conditions when this alternate behavior can trigger: 1- must be in t_suspend 2- must be in a reply `if (msg->first_line.type == SIP_REPLY) {` 3- must have an already cloned `if (t->uac[branch].reply) {` An alternate solution would be to free everything in the cloned message and recreate it. #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) load test done that included connections, failures and timeouts while suspending multiple times. ``` 6(31) INFO: tm [t_suspend.c:126]: t_suspend(): [>>>SUSPEND<<<] cloning message ! 53(78) INFO: tm [t_suspend.c:136]: t_suspend(): [>>>SUSPEND<<<] message already cloned, re-using ! ``` ``` Total 100000 INVITE calls sent in 1710825 ms at rate of 58/sec Total 100000 connection responses received in 1714999 ms at rate of 58/sec: >> Detailed connection responses received: - 200 connection responses: 24924 (OK) - 404 connection responses: 25145 (Not Found) - 408 connection responses: 24912 (Request Timeout) - 500 connection responses: 25019 (Internal Server Error) >> Detailed disconnection responses received: - 200 disconnection responses: 24924 (OK) ------ TOTAL responses: 24924 (rate=14/sec) ``` #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2763 -- Commit Summary -- * tm: prevent t_suspend memory leak -- File Changes -- M src/modules/tm/t_suspend.c (21) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2763.patch https://github.com/kamailio/kamailio/pull/2763.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2763 [View Less]

2 4

git:master:09218156: tm: prevent t_suspend memory leak (#2763)
by GitHub 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: 09218156f3831ec9642d9ebf20d8668229ab16d6 URL: https://github.com/kamailio/kamailio/commit/09218156f3831ec9642d9ebf20d8668… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2021-06-07T08:13:36-07:00 tm: prevent t_suspend memory leak (#2763) When suspending while already in t_continue when processing a reply / suspending twice in a reply. Co-authored-by: Julien Chavanton <jchavanton(a)… [View More]

1 0

git:master:7747872f: mtree: docs - section id for mt_match() function
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: 7747872f066ead3488cbfc854873506bda4f7390 URL: https://github.com/kamailio/kamailio/commit/7747872f066ead3488cbfc854873506… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:23:50+02:00 mtree: docs - section id for mt_match() function --- Modified: src/modules/mtree/doc/mtree_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

[kamailio/kamailio] Sl (#2767)
by sergey-safarov 07 Jun '21

07 Jun '21

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature … [View More]

2 1

git:master:4168d7c5: sl: disabled SREV_NET_DATA_SENT for HTTP respones
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: 4168d7c55955a01c3a30c67d5e8a510be52120ff URL: https://github.com/kamailio/kamailio/commit/4168d7c55955a01c3a30c67d5e8a510… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:17:32+02:00 sl: disabled SREV_NET_DATA_SENT for HTTP respones more details at GH #2767 --- Modified: src/modules/sl/sl_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:c336eed3: core: published sip_check_fline function in .h file
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: c336eed393f2fedae16dbcf004e143fdd38c46e2 URL: https://github.com/kamailio/kamailio/commit/c336eed393f2fedae16dbcf004e143f… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:17:32+02:00 core: published sip_check_fline function in .h file --- Modified: src/core/receive.h --- Diff: https://github.com/kamailio/kamailio/commit/c336eed393f2fedae16dbcf004e143f… Patch: … [View More]

1 0

[kamailio/kamailio] Smsops 7bit support special chars (#2756)
by alexyosifov 07 Jun '21

07 Jun '21

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2756 -- Commit Summary -- * Add README.md * Merge branch 'master' of github.com:alexyosifov/kamailio * Merge remote-tracking branch 'remote_yosifov/master' * Merge branch 'master' of github.com:alexyosifov/kamailio * smsops: support for 7bit special chars -- File Changes -- M src/modules/smsops/smsops_impl.c (256) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2756.patch https://github.com/kamailio/kamailio/pull/2756.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2756 [View Less]

3 4

git:master:f82c4775: smsops: support for 7bit special chars
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: f82c4775efca0580401f4b1a48dcb4d2cf26814f URL: https://github.com/kamailio/kamailio/commit/f82c4775efca0580401f4b1a48dcb4d… Author: Aleksandar Yosifov <alexyosifov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:13:17+02:00 smsops: support for 7bit special chars - Added support for 7bit special chars for MO/MT SMSs. --- Modified: src/modules/smsops/smsops_impl.c --- Diff: https://github.… [View More]

1 0

[kamailio/kamailio] app_perl change to ignore "die" signals from eval blocks (#2754)
by rodolfojcj 07 Jun '21

07 Jun '21

Proposed fix for issue #2745. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2754 -- Commit Summary -- * app_perl change to ignore "die" signals from eval blocks -- File Changes -- M src/modules/app_perl/lib/perl/Kamailio.pm (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2754.patch https://github.com/kamailio/kamailio/pull/2754.diff -- You are receiving this because you are … [View More]

2 2

← Newer
1
...
23
24
25
26
27
28
29
...
32
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2021