sr-dev June 2021

sr-dev@lists.kamailio.org

15 participants
313 discussions

[kamailio/kamailio] Jchavanton/statsd (#2774)
by Julien Chavanton 10 Jun '21

10 Jun '21

adding support for histograms  #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] New feature (non-breaking change which adds new functionality) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2774 -- Commit Summary -- * rtpengine: ignore mos 0 when selecting min-mos * stastd: adding histogram -- File Changes -- M src/modules/rtpengine/rtpengine.c (2) M src/modules/statsd/doc/statsd_admin.xml (25) M src/modules/statsd/lib_statsd.c (6) M src/modules/statsd/lib_statsd.h (1) M src/modules/statsd/statsd.c (17) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2774.patch https://github.com/kamailio/kamailio/pull/2774.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2774

2 3

git:master:f2d1d644: stastd: adding histogram (#2774)
by GitHub 10 Jun '21

10 Jun '21

Module: kamailio Branch: master Commit: f2d1d64408ce3cc6e24e4709933990c8c80cf131 URL: https://github.com/kamailio/kamailio/commit/f2d1d64408ce3cc6e24e4709933990c… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2021-06-10T09:49:47-07:00 stastd: adding histogram (#2774) --- Modified: src/modules/statsd/doc/statsd_admin.xml Modified: src/modules/statsd/lib_statsd.c Modified: src/modules/statsd/lib_statsd.h Modified: src/modules/statsd/statsd.c --- Diff: https://github.com/kamailio/kamailio/commit/f2d1d64408ce3cc6e24e4709933990c… Patch: https://github.com/kamailio/kamailio/commit/f2d1d64408ce3cc6e24e4709933990c…

1 0

[kamailio/kamailio] postrgresql: kamdbctl create issue (#2773)
by Ilya Demyanov 10 Jun '21

10 Jun '21

``` # kamdbctl create -e \E[37;33mINFO: creating database kamailio ... -e \E[37;33mINFO: Core Kamailio tables successfully created. Install presence related tables? (y/n): y -e \E[37;33mINFO: creating presence tables into kamailio ... -e \E[37;33mINFO: Presence tables successfully created. Install tables for imc cpl siptrace domainpolicy carrierroute drouting userblocklist htable purple uac pipelimit mtree sca mohqueue rtpproxy rtpengine secfilter? (y/n): y -e \E[37;33mINFO: creating extra tables into kamailio ... ERROR: relation "globalblacklist" does not exist ERROR: relation "globalblacklist" does not exist ERROR: relation "globalblacklist_id_seq" does not exist ERROR: relation "globalblacklist_id_seq" does not exist -e \E[37;31mERROR: Grant privileges to extra tables failed! ``` ``` # apt list --installed 'kamailio*' Listing... Done kamailio-postgres-modules/unknown,now 5.5.0+bpo10 amd64 [installed] kamailio/unknown,now 5.5.0+bpo10 amd64 [installed] # cat /etc/debian_version 10.9 ``` at version 5.4 from this repository is not reproduced -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2773

2 4

[kamailio/kamailio] rtpengine: ignore mos 0 when selecting min-mos (#2771)
by Julien Chavanton 10 Jun '21

10 Jun '21

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description since mos 0 is unnitialized this can happen when RTP engine does not have a valid RTT (or missing one leg) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2771 -- Commit Summary -- * rtpengine: ignore mos 0 when selecting min-mos -- File Changes -- M src/modules/rtpengine/rtpengine.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2771.patch https://github.com/kamailio/kamailio/pull/2771.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2771

3 4

git:master:a378f97a: rtpengine: ignore mos 0 when selecting min-mos (#2771)
by GitHub 10 Jun '21

10 Jun '21

Module: kamailio Branch: master Commit: a378f97adac89077de2fb162ec20295f6e4352fe URL: https://github.com/kamailio/kamailio/commit/a378f97adac89077de2fb162ec20295… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2021-06-10T08:03:13-04:00 rtpengine: ignore mos 0 when selecting min-mos (#2771) and computing average mos --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/a378f97adac89077de2fb162ec20295… Patch: https://github.com/kamailio/kamailio/commit/a378f97adac89077de2fb162ec20295… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 6f91c222b2..6266520578 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -3588,13 +3588,15 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, bencode_item continue; if (decode_mos_vals_dict(&vals_decoded, ssrc_dict, "average MOS")) { - average_vals.avg_samples++; - average_vals.mos += vals_decoded.mos; - average_vals.packetloss += vals_decoded.packetloss; - average_vals.jitter += vals_decoded.jitter; - average_vals.roundtrip += vals_decoded.roundtrip; - average_vals.roundtrip_leg += vals_decoded.roundtrip_leg; - average_vals.samples += vals_decoded.samples; + if (vals_decoded.mos > 0) { + average_vals.avg_samples++; + average_vals.mos += vals_decoded.mos; + average_vals.packetloss += vals_decoded.packetloss; + average_vals.jitter += vals_decoded.jitter; + average_vals.roundtrip += vals_decoded.roundtrip; + average_vals.roundtrip_leg += vals_decoded.roundtrip_leg; + average_vals.samples += vals_decoded.samples; + } } if (decode_mos_vals_dict(&vals_decoded, ssrc_dict, "highest MOS")) { @@ -3602,7 +3604,7 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, bencode_item max_vals = vals_decoded; } if (decode_mos_vals_dict(&vals_decoded, ssrc_dict, "lowest MOS")) { - if (vals_decoded.mos < min_vals.mos) + if (vals_decoded.mos > 0 && vals_decoded.mos < min_vals.mos) min_vals = vals_decoded; } }

1 0

[kamailio/kamailio] ERROR: <core> [core/resolve.c:941]: get_record(): unknown type 41 (#2758)
by Andrew Webster 10 Jun '21

10 Jun '21

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.2 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST , HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 7.3.0 I check the source, type 41 isn't supported on the current source tree. ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2758

3 3

git:5.5:66370c47: kamctl: update name to globalblocklist in EXTRA_TABLES
by Daniel-Constantin Mierla 10 Jun '21

10 Jun '21

Module: kamailio Branch: 5.5 Commit: 66370c473967d567452a6cf26b8b3496cb1386be URL: https://github.com/kamailio/kamailio/commit/66370c473967d567452a6cf26b8b349… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-10T12:29:42+02:00 kamctl: update name to globalblocklist in EXTRA_TABLES - GH #2773 (cherry picked from commit 90fa160b5d4a7155fc3d82f39932ac0e9d74fae7) --- Modified: utils/kamctl/kamctlrc Modified: utils/kamctl/kamdbctl.base --- Diff: https://github.com/kamailio/kamailio/commit/66370c473967d567452a6cf26b8b349… Patch: https://github.com/kamailio/kamailio/commit/66370c473967d567452a6cf26b8b349… --- diff --git a/utils/kamctl/kamctlrc b/utils/kamctl/kamctlrc index 03232be783..db703c6ed8 100644 --- a/utils/kamctl/kamctlrc +++ b/utils/kamctl/kamctlrc @@ -123,7 +123,7 @@ # dialplan" ## Kamailio extra modules -# EXTRA_MODULES="imc cpl siptrace domainpolicy carrierroute userblacklist htable purple sca" +# EXTRA_MODULES="imc cpl siptrace domainpolicy carrierroute userblocklist htable purple sca" ## type of aliases used: DB - database aliases; UL - usrloc aliases diff --git a/utils/kamctl/kamdbctl.base b/utils/kamctl/kamdbctl.base index 4cfd11c4f9..093334c024 100644 --- a/utils/kamctl/kamdbctl.base +++ b/utils/kamctl/kamdbctl.base @@ -40,7 +40,7 @@ STANDARD_TABLES=${STANDARD_TABLES:-'version acc dbaliases domain domain_attrs acc_cdrs topos_d topos_t'} EXTRA_TABLES=${EXTRA_TABLES:-'imc_members imc_rooms cpl sip_trace domainpolicy carrierroute carrier_name domain_name carrierfailureroute userblocklist - globalblacklist htable purplemap uacreg pl_pipes mtree mtrees + globalblocklist htable purplemap uacreg pl_pipes mtree mtrees sca_subscriptions mohqcalls mohqueues rtpproxy rtpengine dr_gateways dr_rules dr_gw_lists dr_groups secfilter'} PRESENCE_TABLES=${PRESENCE_TABLES:-'presentity active_watchers watchers xcap

1 0

git:5.5:903e4146: siptrace: fixed IPv6 without brackets
by Daniel-Constantin Mierla 10 Jun '21

10 Jun '21

Module: kamailio Branch: 5.5 Commit: 903e41468a00edeff52cbf1e3c0053c82860c92c URL: https://github.com/kamailio/kamailio/commit/903e41468a00edeff52cbf1e3c0053c… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-10T12:29:32+02:00 siptrace: fixed IPv6 without brackets more details GH #2775 (cherry picked from commit 417eb2a7052a9354712663cca9e3bc075a3f69c0) --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/903e41468a00edeff52cbf1e3c0053c… Patch: https://github.com/kamailio/kamailio/commit/903e41468a00edeff52cbf1e3c0053c… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 012644bfa0..102502105d 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -2117,7 +2117,7 @@ int siptrace_net_data_recv(sr_event_param_t *evp) sto.fromip.len = snprintf(sto.fromip_buff, SIPTRACE_ADDR_MAX, "%s:%s:%d", siptrace_proto_name(nd->rcv->proto), - ip_addr2a(&nd->rcv->src_ip), (int)nd->rcv->src_port); + ip_addr2strz(&nd->rcv->src_ip), (int)nd->rcv->src_port); if(sto.fromip.len<0 || sto.fromip.len>=SIPTRACE_ADDR_MAX) { LM_ERR("failed to format toip buffer (%d)\n", sto.fromip.len); sto.fromip.s = SIPTRACE_ANYADDR; @@ -2127,7 +2127,7 @@ int siptrace_net_data_recv(sr_event_param_t *evp) } sto.toip.len = snprintf(sto.toip_buff, SIPTRACE_ADDR_MAX, "%s:%s:%d", - siptrace_proto_name(nd->rcv->proto), ip_addr2a(&nd->rcv->dst_ip), + siptrace_proto_name(nd->rcv->proto), ip_addr2strz(&nd->rcv->dst_ip), (int)nd->rcv->dst_port); if(sto.toip.len<0 || sto.toip.len>=SIPTRACE_ADDR_MAX) { LM_ERR("failed to format toip buffer (%d)\n", sto.toip.len);

1 0

git:5.5:7b89c5e6: pv: added missing WS and WSS to $K(key) variable
by Daniel-Constantin Mierla 10 Jun '21

10 Jun '21

Module: kamailio Branch: 5.5 Commit: 7b89c5e6abe5f4ae3ee55d9c938c865806f29dec URL: https://github.com/kamailio/kamailio/commit/7b89c5e6abe5f4ae3ee55d9c938c865… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-10T12:29:07+02:00 pv: added missing WS and WSS to $K(key) variable (cherry picked from commit a8c9d0ae4fbafba89ef12737419037d141eed1d3) --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/7b89c5e6abe5f4ae3ee55d9c938c865… Patch: https://github.com/kamailio/kamailio/commit/7b89c5e6abe5f4ae3ee55d9c938c865… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 6ead708037..dd3d22e95a 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -3329,6 +3329,10 @@ int pv_parse_K_name(pv_spec_p sp, str *in) switch(in->len) { + case 2: + if(strncmp(in->s, "WS", 2)==0) + sp->pvp.pvn.u.isname.name.n = 6; + else goto error; case 3: if(strncmp(in->s, "UDP", 3)==0) sp->pvp.pvn.u.isname.name.n = 2; @@ -3336,6 +3340,8 @@ int pv_parse_K_name(pv_spec_p sp, str *in) sp->pvp.pvn.u.isname.name.n = 3; else if(strncmp(in->s, "TLS", 3)==0) sp->pvp.pvn.u.isname.name.n = 4; + else if(strncmp(in->s, "WSS", 3)==0) + sp->pvp.pvn.u.isname.name.n = 7; else goto error; break; case 4: @@ -3407,6 +3413,10 @@ int pv_get_K(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) return pv_get_uintval(msg, param, res, PROTO_TLS); case 5: return pv_get_uintval(msg, param, res, PROTO_SCTP); + case 6: + return pv_get_uintval(msg, param, res, PROTO_WS); + case 7: + return pv_get_uintval(msg, param, res, PROTO_WSS); default: return pv_get_uintval(msg, param, res, AF_INET); }

1 0

git:5.5:38459725: smsops: support for 7bit special chars
by Daniel-Constantin Mierla 10 Jun '21

10 Jun '21

Module: kamailio Branch: 5.5 Commit: 3845972598098add3996b19c6cedfbfb4d4d2ee6 URL: https://github.com/kamailio/kamailio/commit/3845972598098add3996b19c6cedfbf… Author: Aleksandar Yosifov <alexyosifov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-10T12:28:34+02:00 smsops: support for 7bit special chars - Added support for 7bit special chars for MO/MT SMSs. (cherry picked from commit f82c4775efca0580401f4b1a48dcb4d2cf26814f) --- Modified: src/modules/smsops/smsops_impl.c --- Diff: https://github.com/kamailio/kamailio/commit/3845972598098add3996b19c6cedfbf… Patch: https://github.com/kamailio/kamailio/commit/3845972598098add3996b19c6cedfbf…

1 0

← Newer
1
...
20
21
22
23
24
25
26
...
32
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2021