sr-dev May 2021

sr-dev@lists.kamailio.org

12 participants
289 discussions

[kamailio/kamailio] usrloc: cancel unnecessary db queries (#2726)
by korayvt 05 May '21

05 May '21

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  It looks like the db query is made before checking the configuration parameters for the following features: - internal keep-alive mechanism - contact-expired callback execution For example, although keepalive mode is turned off, the location table is periodically queried. This is also true when there is no usrloc:contact-expired route. In this commit, checks are added before these two db queries. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2726 -- Commit Summary -- * Merge pull request #1 from kamailio/master * Merge pull request #2 from kamailio/master * Merge pull request #3 from kamailio/master * usrloc: unnecessary periodic db queries cancelled -- File Changes -- M src/modules/usrloc/dlist.c (4) M src/modules/usrloc/udomain.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2726.patch https://github.com/kamailio/kamailio/pull/2726.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2726

2 2

git:master:42bc79b3: usrloc: unnecessary periodic db queries cancelled
by Daniel-Constantin Mierla 05 May '21

05 May '21

Module: kamailio Branch: master Commit: 42bc79b3b617632b6f83e1352b5cb8266706d7c0 URL: https://github.com/kamailio/kamailio/commit/42bc79b3b617632b6f83e1352b5cb82… Author: korayvt <koray.vatansever(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-05-05T20:53:48+02:00 usrloc: unnecessary periodic db queries cancelled --- Modified: src/modules/usrloc/dlist.c Modified: src/modules/usrloc/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/42bc79b3b617632b6f83e1352b5cb82… Patch: https://github.com/kamailio/kamailio/commit/42bc79b3b617632b6f83e1352b5cb82… --- diff --git a/src/modules/usrloc/dlist.c b/src/modules/usrloc/dlist.c index 44ce3c6376..252bb8bde0 100644 --- a/src/modules/usrloc/dlist.c +++ b/src/modules/usrloc/dlist.c @@ -960,7 +960,9 @@ int synchronize_all_udomains(int istart, int istep) res |= db_timer_udomain(ptr->d); } } - ul_ka_db_records((unsigned int)istart); + if (ul_ka_mode != ULKA_NONE) { + ul_ka_db_records((unsigned int)istart); + } } else { for( ptr=_ksr_ul_root ; ptr ; ptr=ptr->next) { mem_timer_udomain(ptr->d, istart, istep); diff --git a/src/modules/usrloc/udomain.c b/src/modules/usrloc/udomain.c index 9d96b2d7a6..204ddfd29f 100644 --- a/src/modules/usrloc/udomain.c +++ b/src/modules/usrloc/udomain.c @@ -1094,8 +1094,10 @@ int db_timer_udomain(udomain_t* _d) db_val_t vals[3]; int key_num = 2; - /* call contact expired call back for a domain before deleting database rows */ - udomain_contact_expired_cb(ul_dbh, _d); + /* If contact-expired callback exists, run it for a domain before deleting database rows */ + if (exists_ulcb_type(UL_CONTACT_EXPIRE)) { + udomain_contact_expired_cb(ul_dbh, _d); + } keys[0] = &ul_expires_col; ops[0] = "<";

1 0

git:master:c294dbf8: modules: readme files regenerated - uac ... [skip ci]
by Kamailio Dev 05 May '21

05 May '21

Module: kamailio Branch: master Commit: c294dbf84807c62f7bf519f4117b6e44b2e36070 URL: https://github.com/kamailio/kamailio/commit/c294dbf84807c62f7bf519f4117b6e4… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-05-05T20:46:11+02:00 modules: readme files regenerated - uac ... [skip ci] --- Modified: src/modules/uac/README --- Diff: https://github.com/kamailio/kamailio/commit/c294dbf84807c62f7bf519f4117b6e4… Patch: https://github.com/kamailio/kamailio/commit/c294dbf84807c62f7bf519f4117b6e4…

1 0

[kamailio/kamailio] uac: Add reg_hash_size parameter (#2725)
by Alex Hermann 05 May '21

05 May '21

Allow configuring the hash table size. The default(4) is hardly usable on anything but a test system.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2725 -- Commit Summary -- * uac: Add reg_hash_size parameter -- File Changes -- M src/modules/uac/doc/uac_admin.xml (20) M src/modules/uac/uac.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2725.patch https://github.com/kamailio/kamailio/pull/2725.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2725

2 2

git:master:880a14a6: uac: Add reg_hash_size parameter
by Daniel-Constantin Mierla 05 May '21

05 May '21

Module: kamailio Branch: master Commit: 880a14a6f45af27001ec348e9b44134915bcbeb7 URL: https://github.com/kamailio/kamailio/commit/880a14a6f45af27001ec348e9b44134… Author: Alex Hermann <alex(a)hexla.nl> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-05-05T20:45:23+02:00 uac: Add reg_hash_size parameter Allow configuring the hash table size. The default(4) is hardly usable on anything but a test system. --- Modified: src/modules/uac/doc/uac_admin.xml Modified: src/modules/uac/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/880a14a6f45af27001ec348e9b44134… Patch: https://github.com/kamailio/kamailio/commit/880a14a6f45af27001ec348e9b44134… --- diff --git a/src/modules/uac/doc/uac_admin.xml b/src/modules/uac/doc/uac_admin.xml index c8271974a3..352d038ea2 100644 --- a/src/modules/uac/doc/uac_admin.xml +++ b/src/modules/uac/doc/uac_admin.xml @@ -459,6 +459,26 @@ modparam("uac", "reg_random_delay", 300) </example> </section> + <section id="uac.p.reg_hash_size"> + <title><varname>reg_hash_size</varname> (int)</title> + <para> + The number of entries of the hash table used by uac_reg to store the + registration records is 2^hash_size. For hash_size=4, the number of + slots of the hash table is 16. + </para> + <para> + <emphasis>Default value is <quote>4</quote> (16 slots).</emphasis> + </para> + <example> + <title>Set <varname>reg_hash_size</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("uac", "reg_hash_size", 10) +... + </programlisting> + </example> + </section> + <section id="uac.p.reg_db_table"> <title><varname>reg_db_table</varname> (string)</title> <para> diff --git a/src/modules/uac/uac.c b/src/modules/uac/uac.c index 486fed2894..5f0a3ad635 100644 --- a/src/modules/uac/uac.c +++ b/src/modules/uac/uac.c @@ -181,6 +181,7 @@ static param_export_t params[] = { {"reg_random_delay", INT_PARAM, &reg_random_delay }, {"reg_active", INT_PARAM, &reg_active_param }, {"reg_gc_interval", INT_PARAM, &_uac_reg_gc_interval }, + {"reg_hash_size", INT_PARAM, &reg_htable_size }, {"default_socket", PARAM_STR, &uac_default_socket}, {"event_callback", PARAM_STR, &uac_event_callback}, {0, 0, 0}

1 0

git:5.4:0572c819: tm: lw parser - fix matching To header in lw_get_hf_name()
by Daniel-Constantin Mierla 05 May '21

05 May '21

Module: kamailio Branch: 5.4 Commit: 0572c8192d26702fc0ac21ae76cbf81fbad91126 URL: https://github.com/kamailio/kamailio/commit/0572c8192d26702fc0ac21ae76cbf81… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-05-05T18:57:57+02:00 tm: lw parser - fix matching To header in lw_get_hf_name() (cherry picked from commit 4ab6e05df56afb7802a2cd125e89b9282a1c6c85) (cherry picked from commit 33db4ffc558b7a9d4c291c929b9e73b3cf8b16f0) --- Modified: src/modules/tm/lw_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/0572c8192d26702fc0ac21ae76cbf81… Patch: https://github.com/kamailio/kamailio/commit/0572c8192d26702fc0ac21ae76cbf81… --- diff --git a/src/modules/tm/lw_parser.c b/src/modules/tm/lw_parser.c index d13ec58311..6f48304f53 100644 --- a/src/modules/tm/lw_parser.c +++ b/src/modules/tm/lw_parser.c @@ -188,9 +188,11 @@ char *lw_get_hf_name(char *begin, char *end, enum _hdr_types_t *type) case 't': /* To */ if(LOWER_BYTE(*(p + 1)) == 'o') { - p += 2; - *type = HDR_TO_T; - break; + if((*(p + 2) == ' ') || (*(p + 2) == ':')) { + p += 2; + *type = HDR_TO_T; + break; + } } if((*(p + 1) == ' ') || (*(p + 1) == ':')) { p++;

1 0

git:5.5:33db4ffc: tm: lw parser - fix matching To header in lw_get_hf_name()
by Daniel-Constantin Mierla 05 May '21

05 May '21

Module: kamailio Branch: 5.5 Commit: 33db4ffc558b7a9d4c291c929b9e73b3cf8b16f0 URL: https://github.com/kamailio/kamailio/commit/33db4ffc558b7a9d4c291c929b9e73b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-05-05T18:57:11+02:00 tm: lw parser - fix matching To header in lw_get_hf_name() (cherry picked from commit 4ab6e05df56afb7802a2cd125e89b9282a1c6c85) --- Modified: src/modules/tm/lw_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/33db4ffc558b7a9d4c291c929b9e73b… Patch: https://github.com/kamailio/kamailio/commit/33db4ffc558b7a9d4c291c929b9e73b… --- diff --git a/src/modules/tm/lw_parser.c b/src/modules/tm/lw_parser.c index d13ec58311..6f48304f53 100644 --- a/src/modules/tm/lw_parser.c +++ b/src/modules/tm/lw_parser.c @@ -188,9 +188,11 @@ char *lw_get_hf_name(char *begin, char *end, enum _hdr_types_t *type) case 't': /* To */ if(LOWER_BYTE(*(p + 1)) == 'o') { - p += 2; - *type = HDR_TO_T; - break; + if((*(p + 2) == ' ') || (*(p + 2) == ':')) { + p += 2; + *type = HDR_TO_T; + break; + } } if((*(p + 1) == ' ') || (*(p + 1) == ':')) { p++;

1 0

git:master:4ab6e05d: tm: lw parser - fix matching To header in lw_get_hf_name()
by Daniel-Constantin Mierla 05 May '21

05 May '21

Module: kamailio Branch: master Commit: 4ab6e05df56afb7802a2cd125e89b9282a1c6c85 URL: https://github.com/kamailio/kamailio/commit/4ab6e05df56afb7802a2cd125e89b92… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-05-05T18:56:39+02:00 tm: lw parser - fix matching To header in lw_get_hf_name() --- Modified: src/modules/tm/lw_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/4ab6e05df56afb7802a2cd125e89b92… Patch: https://github.com/kamailio/kamailio/commit/4ab6e05df56afb7802a2cd125e89b92… --- diff --git a/src/modules/tm/lw_parser.c b/src/modules/tm/lw_parser.c index d13ec58311..6f48304f53 100644 --- a/src/modules/tm/lw_parser.c +++ b/src/modules/tm/lw_parser.c @@ -188,9 +188,11 @@ char *lw_get_hf_name(char *begin, char *end, enum _hdr_types_t *type) case 't': /* To */ if(LOWER_BYTE(*(p + 1)) == 'o') { - p += 2; - *type = HDR_TO_T; - break; + if((*(p + 2) == ' ') || (*(p + 2) == ':')) { + p += 2; + *type = HDR_TO_T; + break; + } } if((*(p + 1) == ' ') || (*(p + 1) == ':')) { p++;

1 0

git:master:79167239: lost: use of parser functions parse_pai_header() and parse_from_header() related to #2723
by Wolfgang Kampichler 05 May '21

05 May '21

Module: kamailio Branch: master Commit: 791672393aeba320fd1608746fb61e9a96e19d06 URL: https://github.com/kamailio/kamailio/commit/791672393aeba320fd1608746fb61e9… Author: Wolfgang Kampichler <dev(a)kampichler.info> Committer: Wolfgang Kampichler <dev(a)kampichler.info> Date: 2021-05-05T18:40:05+02:00 lost: use of parser functions parse_pai_header() and parse_from_header() related to #2723 - lost_get_pai_header(): parsing method update lost_get_from_header(): parsing method update - memset(): fixed number of bytes to be filled (unrelated) --- Modified: src/modules/lost/utilities.c --- Diff: https://github.com/kamailio/kamailio/commit/791672393aeba320fd1608746fb61e9… Patch: https://github.com/kamailio/kamailio/commit/791672393aeba320fd1608746fb61e9…

1 0

Kamailio v5.5.0 Released - new major version is out
by Daniel-Constantin Mierla 05 May '21

05 May '21

Kamailio v5.5.0 is out – it comes with 6 new modules and a considerable set of improvements touching again more than 80 existing modules. You can read detailed release notes at: * https://www.kamailio.org/w/kamailio-v5-5-0-release-notes/ Many thanks to all developers and community members that made possible this release. v5.5.0 brings more flexibility and optimizations across many components, enhancements to distributed message queue (dmq module), load balancer, http client, STIR/SHAKEN support, IMS/VoLTE, rtpengine and tls as well as to make available more functions to KEMI interface ... just to list only a few here. Enjoy Kamailio v5.5.0! Thank you for flying Kamailio! Stay safe and healthy! Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - Online May 17-20, 2021 (Europe Timezone) - June 7-10, 2021 (America Timezone) * https://www.asipto.com/sw/kamailio-advanced-training-online/

1 0

← Newer
1
...
20
21
22
23
24
25
26
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2021