sr-dev May 2021

sr-dev@lists.kamailio.org

12 participants
288 discussions

git:5.5:6d71c939: dialog: ignore 408 on keepalive with cseq 0
by Daniel-Constantin Mierla 12 May '21

12 May '21

Module: kamailio Branch: 5.5 Commit: 6d71c9399027f2ed41cd6eae576d862440bd4fd4 URL: https://github.com/kamailio/kamailio/commit/6d71c9399027f2ed41cd6eae576d862… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-05-12T16:07:05+02:00 dialog: ignore 408 on keepalive with cseq 0 - some UAs do not reply at all (cherry picked from commit 7aa8056a5e3a9804133cb9ff79640d8116be63da) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/6d71c9399027f2ed41cd6eae576d862… Patch: https://github.com/kamailio/kamailio/commit/6d71c9399027f2ed41cd6eae576d862… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index d48d139965..809834527f 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -271,6 +271,12 @@ void dlg_ka_cb_all(struct cell* t, int type, struct tmcb_params* ps, int dir) LM_DBG("skip updating non-confirmed dialogs\n"); goto done; } + if(ps->code==408 && (dlg->cseq[dir].len==0 + || (dlg->cseq[dir].len==1 && dlg->cseq[dir].s[0]=='\0'))) { + LM_DBG("ignore 408 for %s cseq 0\n", + ((dir==DLG_CALLER_LEG)?"caller":"callee")); + goto done; + } tend = 0; if(dir==DLG_CALLER_LEG) { dlg->ka_src_counter++;

1 0

git:master:c441c922: pv: added $rpl(key) variable
by Daniel-Constantin Mierla 12 May '21

12 May '21

Module: kamailio Branch: master Commit: c441c9226635fb825096080029be7ba2d3ba8132 URL: https://github.com/kamailio/kamailio/commit/c441c9226635fb825096080029be7ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-05-12T13:14:12+02:00 pv: added $rpl(key) variable - return attributes of the sip reply that is processed at that moment - the key can be: - duri - SIP URI corresponding to the destination address where the reply is going to be sent based on 2nd via - dhost - host part of duri - dport - port part of duri - dproto - proto of duri - dprotoid - proto id of duri - cntvia - number of via header bodies --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_core.c Modified: src/modules/pv/pv_core.h --- Diff: https://github.com/kamailio/kamailio/commit/c441c9226635fb825096080029be7ba… Patch: https://github.com/kamailio/kamailio/commit/c441c9226635fb825096080029be7ba…

1 0

git:master:600c2cf5: modules: readme files regenerated - secsipid ... [skip ci]
by Kamailio Dev 12 May '21

12 May '21

Module: kamailio Branch: master Commit: 600c2cf5c7349fc924b53199280baba8bdd329e7 URL: https://github.com/kamailio/kamailio/commit/600c2cf5c7349fc924b53199280baba… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-05-12T08:46:14+02:00 modules: readme files regenerated - secsipid ... [skip ci] --- Modified: src/modules/secsipid/README --- Diff: https://github.com/kamailio/kamailio/commit/600c2cf5c7349fc924b53199280baba… Patch: https://github.com/kamailio/kamailio/commit/600c2cf5c7349fc924b53199280baba… --- diff --git a/src/modules/secsipid/README b/src/modules/secsipid/README index c96b7830c6..b42915943b 100644 --- a/src/modules/secsipid/README +++ b/src/modules/secsipid/README @@ -299,7 +299,7 @@ request_route { 5. Installation - The module needs "secsipdi_proc.so" module thatdepends on + The module needs "secsipdi_proc.so" module that depends on "libsecsipid", which is a component of "sipsecidx" project from https://github.com/asipto/secsipidx/. The library is implemented in Go language, with generated C API and library. Until the libsecsipid is @@ -313,6 +313,7 @@ request_route { Example 1.11. Libsecsipid Usage ... +export GO111MODULE=off go get https://github.com/asipto/secsipidx cd $GOPATH/src/github.com/asipto/secsipidx/csecsipid/ make liba @@ -328,3 +329,6 @@ make install # make modules modules=src/modules/secsipid_proc # make modules modules=src/modules/secsipid ... + + For more details about compilation and installation of libsecsipid, + see: https://github.com/asipto/secsipidx.

1 0

git:master:ecc8a34d: secsipid: docs - set GO111MODULE=off in installation example
by Daniel-Constantin Mierla 12 May '21

12 May '21

Module: kamailio Branch: master Commit: ecc8a34dae44883b125ae7a3da59d4a332e0b48c URL: https://github.com/kamailio/kamailio/commit/ecc8a34dae44883b125ae7a3da59d4a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-05-12T08:32:37+02:00 secsipid: docs - set GO111MODULE=off in installation example --- Modified: src/modules/secsipid/doc/secsipid_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ecc8a34dae44883b125ae7a3da59d4a… Patch: https://github.com/kamailio/kamailio/commit/ecc8a34dae44883b125ae7a3da59d4a… --- diff --git a/src/modules/secsipid/doc/secsipid_admin.xml b/src/modules/secsipid/doc/secsipid_admin.xml index d9d622af17..1e22e371fb 100644 --- a/src/modules/secsipid/doc/secsipid_admin.xml +++ b/src/modules/secsipid/doc/secsipid_admin.xml @@ -318,7 +318,7 @@ request_route { <section id="secsipid.s.installation"> <title>Installation</title> <para> - The module needs "secsipdi_proc.so" module thatdepends on "libsecsipid", + The module needs "secsipdi_proc.so" module that depends on "libsecsipid", which is a component of "sipsecidx" project from https://github.com/asipto/secsipidx/. The library is implemented in Go language, with generated C API and library. Until the @@ -334,6 +334,7 @@ request_route { <title>Libsecsipid Usage</title> <programlisting format="linespecific"> ... +export GO111MODULE=off go get https://github.com/asipto/secsipidx cd $GOPATH/src/github.com/asipto/secsipidx/csecsipid/ make liba @@ -351,6 +352,10 @@ make install ... </programlisting> </example> + <para> + For more details about compilation and installation of libsecsipid, see: + <ulink url="https://github.com/asipto/secsipidx">https://github.com/asipto/secsipidx</ulink>. + </para> </section> </chapter>

1 0

git:master:71d7d583: core: kemi - exported KSR.pv.geti("pv")
by Daniel-Constantin Mierla 12 May '21

12 May '21

Module: kamailio Branch: master Commit: 71d7d5835dd256201f50d14d7c7285f7d2881bb6 URL: https://github.com/kamailio/kamailio/commit/71d7d5835dd256201f50d14d7c7285f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-05-12T08:15:33+02:00 core: kemi - exported KSR.pv.geti("pv") - return integer value of the pv, trying to convert if its value is string --- Modified: src/core/kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/71d7d5835dd256201f50d14d7c7285f… Patch: https://github.com/kamailio/kamailio/commit/71d7d5835dd256201f50d14d7c7285f… --- diff --git a/src/core/kemi.c b/src/core/kemi.c index 0932339996..324e7cd6cf 100644 --- a/src/core/kemi.c +++ b/src/core/kemi.c @@ -2855,6 +2855,47 @@ static sr_kemi_xval_t* sr_kemi_pv_getvn (sip_msg_t *msg, str *pvn, int xival) return sr_kemi_pv_get_valx (msg, pvn, NULL, xival, 1); } +/** + * + */ +static int sr_kemi_pv_geti (sip_msg_t *msg, str *pvn) +{ + pv_spec_t *pvs; + pv_value_t val; + int vi; + + LM_DBG("pv get: %.*s\n", pvn->len, pvn->s); + vi = pv_locate_name(pvn); + if(vi != pvn->len) { + LM_WARN("invalid pv [%.*s] (%d/%d)\n", pvn->len, pvn->s, vi, pvn->len); + return 0; + } + pvs = pv_cache_get(pvn); + if(pvs==NULL) { + LM_WARN("cannot get pv spec for [%.*s]\n", pvn->len, pvn->s); + return 0; + } + + memset(&val, 0, sizeof(pv_value_t)); + if(pv_get_spec_value(msg, pvs, &val) != 0) { + LM_WARN("unable to get pv value for [%.*s]\n", pvn->len, pvn->s); + return 0; + } + if(val.flags&PV_VAL_NULL) { + return 0; + } + if(val.flags&(PV_TYPE_INT|PV_VAL_INT)) { + return val.ri; + } + if(val.ri!=0) { + return val.ri; + } + vi = 0; + str2sint(&val.rs, &vi); + + return vi; +} + /** * */ @@ -3003,6 +3044,11 @@ static sr_kemi_t _sr_kemi_pv[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("pv"), str_init("geti"), + SR_KEMIP_INT, sr_kemi_pv_geti, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("pv"), str_init("getvn"), SR_KEMIP_XVAL, sr_kemi_pv_getvn, { SR_KEMIP_STR, SR_KEMIP_INT, SR_KEMIP_NONE,

1 0

[kamailio/kamailio] Setting notifier_processes to 1 or more seems to cause memory leak (#2733)
by Amit Nir 11 May '21

11 May '21

Hello, We use Kamailio with KAZOO. We have set notifier_processes as follows: modparam("presence", "notifier_processes", 1) A value of 1 or greater seems to be required to avoid race conditions when multiple notify's need to be sent. We've noticed noticed what seems to be a memory leak in Kamailio process. After several days, Kamailio will crash after consuming all system memory. I have not found any other reports of this happening to others. Does this seem familiar to anyone? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2733

2 5

git:master:ca886ffa: modules: readme files regenerated - siputils ... [skip ci]
by Kamailio Dev 11 May '21

11 May '21

Module: kamailio Branch: master Commit: ca886ffa64db8cc209dcc7098ffb69902464da72 URL: https://github.com/kamailio/kamailio/commit/ca886ffa64db8cc209dcc7098ffb699… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-05-11T17:31:12+02:00 modules: readme files regenerated - siputils ... [skip ci] --- Modified: src/modules/siputils/README --- Diff: https://github.com/kamailio/kamailio/commit/ca886ffa64db8cc209dcc7098ffb699… Patch: https://github.com/kamailio/kamailio/commit/ca886ffa64db8cc209dcc7098ffb699… --- diff --git a/src/modules/siputils/README b/src/modules/siputils/README index a1aeae393c..453179d5a1 100644 --- a/src/modules/siputils/README +++ b/src/modules/siputils/README @@ -449,8 +449,9 @@ modparam("auth", "rpid_avp", "$avp(myrpid)") Inserting the call-id in the internal list, which is checked when further replies arrive. Any 183 reply that is received during the - timeout value will be converted to a 180 message. Please note that you - need to set a positive timeout value in order to use this function. + timeout value will be converted to a 180 message with removed SDP body. + Please note that you need to set a positive ring_timeout value in order + to use this function. The function returns TRUE on success, and FALSE during processing failures.

1 0

git:master:212840c3: siptuils: small doc extension for ring filter functionality
by Henning Westerholt 11 May '21

11 May '21

Module: kamailio Branch: master Commit: 212840c367e4b2945bb105e1fd087543f7fdf316 URL: https://github.com/kamailio/kamailio/commit/212840c367e4b2945bb105e1fd08754… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2021-05-11T15:24:01Z siptuils: small doc extension for ring filter functionality --- Modified: src/modules/siputils/doc/siputils_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/212840c367e4b2945bb105e1fd08754… Patch: https://github.com/kamailio/kamailio/commit/212840c367e4b2945bb105e1fd08754… --- diff --git a/src/modules/siputils/doc/siputils_admin.xml b/src/modules/siputils/doc/siputils_admin.xml index 5764c152d4..8e7140385d 100644 --- a/src/modules/siputils/doc/siputils_admin.xml +++ b/src/modules/siputils/doc/siputils_admin.xml @@ -281,8 +281,9 @@ modparam("auth", "rpid_avp", "$avp(myrpid)") <para> Inserting the call-id in the internal list, which is checked when further replies arrive. Any 183 reply that is received during the - timeout value will be converted to a 180 message. Please note that you - need to set a positive timeout value in order to use this function. + timeout value will be converted to a 180 message with removed SDP body. + Please note that you need to set a positive ring_timeout value in order + to use this function. </para> <para> The function returns TRUE on success, and FALSE during processing failures.

1 0

git:master:9c2fea2d: modules: readme files regenerated - siputils ... [skip ci]
by Kamailio Dev 11 May '21

11 May '21

Module: kamailio Branch: master Commit: 9c2fea2df70e3fe609324a9d868efe9998bcda10 URL: https://github.com/kamailio/kamailio/commit/9c2fea2df70e3fe609324a9d868efe9… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-05-11T15:46:16+02:00 modules: readme files regenerated - siputils ... [skip ci] --- Modified: src/modules/siputils/README --- Diff: https://github.com/kamailio/kamailio/commit/9c2fea2df70e3fe609324a9d868efe9… Patch: https://github.com/kamailio/kamailio/commit/9c2fea2df70e3fe609324a9d868efe9… --- diff --git a/src/modules/siputils/README b/src/modules/siputils/README index 87d3ecf9e4..a1aeae393c 100644 --- a/src/modules/siputils/README +++ b/src/modules/siputils/README @@ -96,7 +96,7 @@ Gabriel Vasile 4.30. is_reply() 4.31. is_gruu([uri]) 4.32. is_supported(option) - 4.33. is_first_hop() + 4.33. is_first_hop([mode]) 4.34. sip_p_charging_vector(flags) 4.35. contact_param_encode(pname, saddr) 4.36. contact_param_decode(pname) @@ -217,7 +217,7 @@ Chapter 1. Admin Guide 4.30. is_reply() 4.31. is_gruu([uri]) 4.32. is_supported(option) - 4.33. is_first_hop() + 4.33. is_first_hop([mode]) 4.34. sip_p_charging_vector(flags) 4.35. contact_param_encode(pname, saddr) 4.36. contact_param_decode(pname) @@ -438,7 +438,7 @@ modparam("auth", "rpid_avp", "$avp(myrpid)") 4.30. is_reply() 4.31. is_gruu([uri]) 4.32. is_supported(option) - 4.33. is_first_hop() + 4.33. is_first_hop([mode]) 4.34. sip_p_charging_vector(flags) 4.35. contact_param_encode(pname, saddr) 4.36. contact_param_decode(pname) @@ -994,24 +994,37 @@ if(is_gruu()) { ... } if (is_supported("outbound")) { ... } ... -4.33. is_first_hop() +4.33. is_first_hop([mode]) The function returns true if the proxy is first hop after the original - sender. For incoming SIP requests, it means there is only one Via - header. For incoming SIP replies, it means that top Record-Route URI is - 'myself' and source address is not matching it (to avoid detecting in - case of local loops). The detection is done only when Record-Route has - an IP address in its URI (for a domain, it returns -1/false). + sender based on a best effort estimation by checking Via and + Record-Route headers. + + For incoming SIP requests, it means there is only one Via header. + + For incoming SIP replies, if mode==0, it means that top Record-Route + URI is 'myself' and source address is not matching local IP (to avoid + detecting in case of local loops). Therefore for mode==0 the detection + is done only when Record-Route has an IP address in its URI (for a + domain, it returns -1/false). If mode==1, then the check of local IP is + no longer done, only if top Record-Route is myself, returning true also + if there is a domain, assuming that is expected no looping can happen + based on config rules. Note that it does not detect spirals, which can have the condition for replies true also in the case of additional SIP reply reception. + Parameter mode is optional and can be an integer or a varaible holding + an integer. If not provided, the behaviour is like mode==0. + This function can be used from ANY_ROUTE. Example 1.42. is_first_hop() usage ... if(is_first_hop()) { ... } ... +if(is_first_hop_mode("1")) { ... } +... 4.34. sip_p_charging_vector(flags)

1 0

git:master:425ba921: siputils: docs - updates to is_first_hop() for mode parameter
by Daniel-Constantin Mierla 11 May '21

11 May '21

Module: kamailio Branch: master Commit: 425ba921288c8d5a6ae3076287d0cf39c735a8fd URL: https://github.com/kamailio/kamailio/commit/425ba921288c8d5a6ae3076287d0cf3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-05-11T15:38:14+02:00 siputils: docs - updates to is_first_hop() for mode parameter --- Modified: src/modules/siputils/doc/siputils_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/425ba921288c8d5a6ae3076287d0cf3… Patch: https://github.com/kamailio/kamailio/commit/425ba921288c8d5a6ae3076287d0cf3… --- diff --git a/src/modules/siputils/doc/siputils_admin.xml b/src/modules/siputils/doc/siputils_admin.xml index 4667e42f63..5764c152d4 100644 --- a/src/modules/siputils/doc/siputils_admin.xml +++ b/src/modules/siputils/doc/siputils_admin.xml @@ -1169,22 +1169,35 @@ if (is_supported("outbound")) { ... } </section> <section id="siputils.f.is_first_hop"> <title> - <function moreinfo="none">is_first_hop()</function> + <function moreinfo="none">is_first_hop([mode])</function> </title> <para> The function returns true if the proxy is first hop after the - original sender. For incoming SIP requests, it means there is only - one Via header. For incoming SIP replies, it means that top - Record-Route URI is 'myself' and source address is not matching it - (to avoid detecting in case of local loops). The detection is done - only when Record-Route has an IP address in its URI (for a domain, - it returns -1/false). + original sender based on a best effort estimation by checking Via + and Record-Route headers. + </para> + <para> + For incoming SIP requests, it means there is only one Via header. + </para> + <para> + For incoming SIP replies, if mode==0, it means that top Record-Route + URI is 'myself' and source address is not matching local IP (to avoid + detecting in case of local loops). Therefore for mode==0 the detection + is done only when Record-Route has an IP address in its URI (for a domain, + it returns -1/false). If mode==1, then the check of local IP is no + longer done, only if top Record-Route is myself, returning true also if + there is a domain, assuming that is expected no looping can happen + based on config rules. </para> <para> Note that it does not detect spirals, which can have the condition for replies true also in the case of additional SIP reply reception. </para> <para> + Parameter mode is optional and can be an integer or a varaible holding + an integer. If not provided, the behaviour is like mode==0. + </para> + <para> This function can be used from ANY_ROUTE. </para> <example> @@ -1193,6 +1206,8 @@ if (is_supported("outbound")) { ... } ... if(is_first_hop()) { ... } ... +if(is_first_hop_mode("1")) { ... } +... </programlisting> </example> </section>

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2021